<feed xmlns='http://www.w3.org/2005/Atom'>
<title>ports/Mk/Scripts/smart_makepatch.sh, branch release/12.3.0</title>
<subtitle>FreeBSD ports tree</subtitle>
<id>https://cgit-dev.freebsd.org/ports/atom?h=release%2F12.3.0</id>
<link rel='self' href='https://cgit-dev.freebsd.org/ports/atom?h=release%2F12.3.0'/>
<link rel='alternate' type='text/html' href='https://cgit-dev.freebsd.org/ports/'/>
<updated>2021-07-14T16:15:03Z</updated>
<entry>
<title>Mk/Scripts/smart_makepatch.sh: Force diff to produce the patch file instead of "Binary files ... differ" message</title>
<updated>2021-07-14T16:15:03Z</updated>
<author>
<name>Po-Chuan Hsieh</name>
<email>sunpoet@FreeBSD.org</email>
</author>
<published>2021-07-14T16:06:05Z</published>
<link rel='alternate' type='text/html' href='https://cgit-dev.freebsd.org/ports/commit/?id=fcb34faf706733a667358b293970fac444251828'/>
<id>urn:sha1:fcb34faf706733a667358b293970fac444251828</id>
<content type='text'>
It helps avoid generating wrong patches, e.g. patch-grpc.gemspec in r567838 [1].

from diff manpage:
    -a --text
        Treat all files as ASCII text.  Normally diff will simply print
	"Binary files ... differ" if files contain binary characters.
        Use of this option forces diff to produce a diff.

[1] https://cgit.FreeBSD.org/ports/diff/net/rubygem-grpc130/files/patch-grpc.gemspec?id=073c1c710a0c7254820adab9920c1903ace83fae

PR:		257027
Approved by:	mat (portmgr)
</content>
</entry>
<entry>
<title>framework: Remove $FreeBSD$</title>
<updated>2021-04-06T14:27:10Z</updated>
<author>
<name>Mathieu Arnold</name>
<email>mat@FreeBSD.org</email>
</author>
<published>2021-04-06T11:32:08Z</published>
<link rel='alternate' type='text/html' href='https://cgit-dev.freebsd.org/ports/commit/?id=5d33e045968104ac678d8b4b4ec1e8956bbf68e0'/>
<id>urn:sha1:5d33e045968104ac678d8b4b4ec1e8956bbf68e0</id>
<content type='text'>
Where appropriate fiddle with a few other things.
</content>
</entry>
<entry>
<title>Add set pipefail in most framework scripts.</title>
<updated>2020-11-11T13:29:52Z</updated>
<author>
<name>Mathieu Arnold</name>
<email>mat@FreeBSD.org</email>
</author>
<published>2020-11-11T13:29:52Z</published>
<link rel='alternate' type='text/html' href='https://cgit-dev.freebsd.org/ports/commit/?id=f916081e1cf3cf8f63d7d2e708353f6a9303401c'/>
<id>urn:sha1:f916081e1cf3cf8f63d7d2e708353f6a9303401c</id>
<content type='text'>
set pipefail changes the pipeline return status from being the return
status of the last command to the last non 0 exit status of any command
in the pipeline.  This is needed to make sure all the commands in a
pipeline did actually return a non 0 status and not only the last one.

PR:		250723
Exp-run by:	antoine
Reviewed by:	bapt
Approved by:	bapt
Differential Revision:	https://reviews.freebsd.org/D27007
</content>
</entry>
<entry>
<title>Backout r554139.</title>
<updated>2020-11-05T16:51:30Z</updated>
<author>
<name>Mathieu Arnold</name>
<email>mat@FreeBSD.org</email>
</author>
<published>2020-11-05T16:51:30Z</published>
<link rel='alternate' type='text/html' href='https://cgit-dev.freebsd.org/ports/commit/?id=aeda355b1b6ff45a38b6fb053ccebe1f1ba2995e'/>
<id>urn:sha1:aeda355b1b6ff45a38b6fb053ccebe1f1ba2995e</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Add set pipefail in most framework scripts.</title>
<updated>2020-11-05T16:42:35Z</updated>
<author>
<name>Mathieu Arnold</name>
<email>mat@FreeBSD.org</email>
</author>
<published>2020-11-05T16:42:35Z</published>
<link rel='alternate' type='text/html' href='https://cgit-dev.freebsd.org/ports/commit/?id=e9b2078c6cc6d9d66ee4624024372db93a296921'/>
<id>urn:sha1:e9b2078c6cc6d9d66ee4624024372db93a296921</id>
<content type='text'>
set pipefail changes the pipeline return status from being the return
status of the last command to the last non 0 exit status of any command
in the pipeline.  This is needed to make sure all the commands in a
pipeline did actually return a non 0 status and not only the last one.
</content>
</entry>
<entry>
<title>Unbreak make makepatch.</title>
<updated>2020-01-23T08:55:25Z</updated>
<author>
<name>Mathieu Arnold</name>
<email>mat@FreeBSD.org</email>
</author>
<published>2020-01-23T08:55:25Z</published>
<link rel='alternate' type='text/html' href='https://cgit-dev.freebsd.org/ports/commit/?id=f5e4ea9e146c6e47042ed9df41e9f65f02eb0931'/>
<id>urn:sha1:f5e4ea9e146c6e47042ed9df41e9f65f02eb0931</id>
<content type='text'>
The glob in `find ./*` is handled by the shell and actually sorts the
files, so one needs to to ask find to sort the result, using `find -s`.

`find ./* -maxdepth 0` is not equivalent to `find . -maxdepth 0`, the
depth increases by one as `./x` is on level deeper than `.`.

Pointy hat:	bdrewery
</content>
</entry>
<entry>
<title>find(1) doesn't need a glob to search for patches.</title>
<updated>2020-01-21T20:36:14Z</updated>
<author>
<name>Bryan Drewery</name>
<email>bdrewery@FreeBSD.org</email>
</author>
<published>2020-01-21T20:36:14Z</published>
<link rel='alternate' type='text/html' href='https://cgit-dev.freebsd.org/ports/commit/?id=ed09885fec597eb62cafff8e5505b7fd558cf8a9'/>
<id>urn:sha1:ed09885fec597eb62cafff8e5505b7fd558cf8a9</id>
<content type='text'>
This change also avoids cmdline length errors and other subst
parsing issues that were previously targeted.

Sponsored by:	DellEMC
</content>
</entry>
<entry>
<title>Have makepatch ignore "C function prototype".</title>
<updated>2019-05-20T13:04:03Z</updated>
<author>
<name>Mathieu Arnold</name>
<email>mat@FreeBSD.org</email>
</author>
<published>2019-05-20T13:04:03Z</published>
<link rel='alternate' type='text/html' href='https://cgit-dev.freebsd.org/ports/commit/?id=7551edfa4ba6b8daef881b933b2cd535d510eb19'/>
<id>urn:sha1:7551edfa4ba6b8daef881b933b2cd535d510eb19</id>
<content type='text'>
This will reduce the churn when base system diff subtly changes what is
put in that field.
</content>
</entry>
<entry>
<title>SC1004: This backslash+linefeed is literal. Break outside single quotes if you just want to break the line.</title>
<updated>2018-06-08T09:26:41Z</updated>
<author>
<name>Mathieu Arnold</name>
<email>mat@FreeBSD.org</email>
</author>
<published>2018-06-08T09:26:41Z</published>
<link rel='alternate' type='text/html' href='https://cgit-dev.freebsd.org/ports/commit/?id=b19fe1e937f9ad207c85f935169d19e282adcb5d'/>
<id>urn:sha1:b19fe1e937f9ad207c85f935169d19e282adcb5d</id>
<content type='text'>
You have a single quoted string containing a backslash followed by a
linefeed (newline). Unlike double quotes or unquoted strings, this has
no special meaning. The string will contain a literal backslash and a
linefeed.

If you wanted to break the line but not add a linefeed to the string,
stop the single quote, break the line, and reopen it.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
</content>
</entry>
<entry>
<title>SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.</title>
<updated>2018-06-08T09:26:38Z</updated>
<author>
<name>Mathieu Arnold</name>
<email>mat@FreeBSD.org</email>
</author>
<published>2018-06-08T09:26:38Z</published>
<link rel='alternate' type='text/html' href='https://cgit-dev.freebsd.org/ports/commit/?id=49b7fa03acb4c78015afd4f0fbd62791e2b10e50'/>
<id>urn:sha1:49b7fa03acb4c78015afd4f0fbd62791e2b10e50</id>
<content type='text'>
Since files and arguments are strings passed the same way, programs
can't properly determine which is which, and rely on dashes to determine
what's what.

A file named -f (touch -- -f) will not be deleted by the problematic
code. It will instead be interpreted as a command line option, and rm
will even report success.

Using ./* will instead cause the glob to be expanded into ./-f, which no
program will treat as an option.

It is not possible to use `-f *` because -f only forces the next
argument to be a directory, a later directory named -delete would mess
things up.

PR:             227109
Submitted by:   mat
Sponsored by:   Absolight
</content>
</entry>
</feed>
