diff options
| author | Jan Beich <jbeich@FreeBSD.org> | 2017-03-30 14:04:58 +0000 |
|---|---|---|
| committer | Jan Beich <jbeich@FreeBSD.org> | 2017-03-30 14:04:58 +0000 |
| commit | 76fb5c84407fb2bc5f9c252208a26f3c10a67533 (patch) | |
| tree | 538751d3d68142dd489d4afa4dd1406f375962a6 | |
| parent | e9bc8d225f7f06abffaba806704fabffdf4fac8f (diff) | |
| download | ports-76fb5c84407fb2bc5f9c252208a26f3c10a67533.tar.gz ports-76fb5c84407fb2bc5f9c252208a26f3c10a67533.zip | |
MFH: r437293
x11-toolkits/gtk30: prefer warnings over crashes on bad behavior
devel/glib20 and x11-toolkits/gtk20 don't use --disable-debug.
Neither does gtk3 package on Debian or ArchLinux.
https://bugzilla.mozilla.org/show_bug.cgi?id=1351246#c9
$ cat >a.c
#include <gdk/gdk.h>
int main() {
gdk_get_default_root_window();
return 0;
}
$ cc a.c $(pkg-config --cflags --libs gtk+-3.0)
$ ./a.out
Segmentation fault
vs. (new behavior)
$ ./a.out
(process:40995): Gdk-CRITICAL **: gdk_screen_get_root_window: assertion 'GDK_IS_SCREEN (screen)' failed
Pointy hat to: kwm (r372768 broke consistency)
Approved by: ports-secteam blanket
Notes
Notes:
svn path=/branches/2017Q1/; revision=437294
| -rw-r--r-- | x11-toolkits/gtk30/Makefile | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/x11-toolkits/gtk30/Makefile b/x11-toolkits/gtk30/Makefile index 795032716c6b..d2d89ba15bb0 100644 --- a/x11-toolkits/gtk30/Makefile +++ b/x11-toolkits/gtk30/Makefile @@ -5,7 +5,7 @@ PORTNAME= gtk PORTVERSION= 3.18.8 -PORTREVISION?= 3 +PORTREVISION?= 4 CATEGORIES= x11-toolkits MASTER_SITES= GNOME/sources/gtk+/${PORTVERSION:C/^([0-9]+\.[0-9]+).*/\1/} PKGNAMESUFFIX= 3 @@ -73,7 +73,7 @@ CLOUDPRINT_CONFIGURE_ENABLE= cloudprint CLOUDPRINT_LIB_DEPENDS= librest-0.7.so:devel/librest \ libjson-glib-1.0.so:devel/json-glib -DEBUG_CONFIGURE_ENABLE=debug +DEBUG_CONFIGURE_ON= --enable-debug=yes post-patch: @${REINPLACE_CMD} -e 's|[{]libdir[}]/locale|{datadir}/locale|g' \ |