Revert previous commit -- appears to cause rc problems as I missed some subs

http://www.mail-archive.com/freebsd-ports@freebsd.org/msg35324.html

PR:		ports/157558 ports/157559 ports/157666 ports/157669
Submitted by:	rihad@mail.ru
Approved by:	maintainer (girgen; implicit -- this reverts a commit I did after maintainer timeout)

10 files changed, 186 insertions, 10 deletions

diff --git a/databases/postgresql82-server/Makefile b/databases/postgresql82-server/Makefile
index 9b2ef2b88abd..ab69ca9e7555 100644
--- a/databases/postgresql82-server/Makefile
+++ b/databases/postgresql82-server/Makefile
@@ -60,8 +60,6 @@ USE_RC_SUBR=	postgresql
 SUB_FILES+=	dot.cshrc dot.profile
 USE_PGSQL=	yes
 WANT_PGSQL_VER=	${PORTVERSION:C/([0-9][0-9]*)\.([0-9][0-9]*).*/\1\2/g}
-USERS=		pgsql
-GROUPS=		${USERS}
 .endif
 
 .if !defined(SLAVE_ONLY)
@@ -243,6 +241,12 @@ PKGMESSAGE=	${WRKSRC}/pkg-message${PKGNAMESUFFIX}
 .  endif
 .endif
 
+.if defined(SERVER_ONLY)
+pre-su-install:
+	@ ${SETENV} PKG_PREFIX=${PREFIX} \
+		${SH} ${PKGINSTALL} ${PORTNAME} PRE-INSTALL
+.endif
+
 .if !defined(NO_BUILD)
 post-patch:
 	@${REINPLACE_CMD} s/@PTHREAD_LIBS@// ${WRKSRC}/src/Makefile.global.in
diff --git a/databases/postgresql82-server/pkg-install-server b/databases/postgresql82-server/pkg-install-server
index bb5c69a88bed..c3db75540ffa 100644
--- a/databases/postgresql82-server/pkg-install-server
+++ b/databases/postgresql82-server/pkg-install-server
@@ -3,6 +3,8 @@
 # $FreeBSD$
 
 PATH=/bin:/usr/sbin
+PGUSER=pgsql
+DB_DIR=${PKG_PREFIX}/${PGUSER}
 
 backupwarning() { echo "
 
@@ -20,6 +22,43 @@ backupwarning() { echo "
 }
 
 case $2 in
+PRE-INSTALL)
+	backupwarning
+	USER=${PGUSER}
+	GROUP=${USER}
+	UID=70
+	GID=${UID}
+
+	if pw group show "${GROUP}" 2>/dev/null; then
+		echo "You already have a group \"${GROUP}\", so I will use it."
+	else
+		if pw groupadd ${GROUP} -g ${GID}; then
+			echo "Added group \"${GROUP}\"."
+		else
+			echo "Adding group \"${GROUP}\" failed..."
+			exit 1
+		fi
+	fi
+
+	if pw user show "${USER}" 2>/dev/null; then
+		echo "You already have a user \"${USER}\", so I will use it."
+	else
+		if pw useradd ${USER} -u ${UID} -g ${GROUP} -h - \
+			-d ${DB_DIR} -c "PostgreSQL Daemon"
+		then
+			echo "Added user \"${USER}\"."
+		else
+			echo "Adding user \"${USER}\" failed..."
+			exit 1
+		fi
+	fi
+
+	if ! [ -x ~${PGUSER} ] ; then 
+		mkdir -p ${DB_DIR}
+		chown pgsql:pgsql ${DB_DIR}
+	fi
+	;;
+
 BACKUPWARNING)
 	backupwarning
 	;;
diff --git a/databases/postgresql83-server/Makefile b/databases/postgresql83-server/Makefile
index e034cd0dcd84..99e01933a334 100644
--- a/databases/postgresql83-server/Makefile
+++ b/databases/postgresql83-server/Makefile
@@ -61,8 +61,6 @@ SERVER_ONLY=	yes
 USE_RC_SUBR=	postgresql
 USE_PGSQL=	yes
 WANT_PGSQL_VER=	${PORTVERSION:C/([0-9][0-9]*)\.([0-9][0-9]*).*/\1\2/g}
-USERS=		${PGUSER}
-GROUPS=		${PGGROUP}
 .endif
 
 .if !defined(SLAVE_ONLY)
@@ -275,6 +273,12 @@ PKGMESSAGE=	${WRKSRC}/pkg-message${PKGNAMESUFFIX}
 .  endif
 .endif
 
+.if defined(SERVER_ONLY)
+pre-su-install:
+	@ ${SETENV} PKG_PREFIX=${PREFIX} PGUSER=${PGUSER} PGGROUP=${PGGROUP} \
+		${SH} ${PKGINSTALL} ${PORTNAME} PRE-INSTALL
+.endif
+
 .if !defined(NO_BUILD)
 post-patch:
 	@${REINPLACE_CMD} s/@PTHREAD_LIBS@// ${WRKSRC}/src/Makefile.global.in
diff --git a/databases/postgresql83-server/pkg-install-server b/databases/postgresql83-server/pkg-install-server
index e3be291efdc1..6dc3b6fdbd67 100644
--- a/databases/postgresql83-server/pkg-install-server
+++ b/databases/postgresql83-server/pkg-install-server
@@ -20,6 +20,43 @@ backupwarning() { echo "
 }
 
 case $2 in
+PRE-INSTALL)
+	backupwarning
+	PGUSER=${PGUSER:-pgsql}
+	PGGROUP=${PGGROUP:-pgsql}
+	DB_DIR=${PKG_PREFIX}/${PGUSER}
+	UID=70
+	GID=70
+
+	if pw group show "${PGGROUP}" 2>/dev/null; then
+		echo "You already have a group \"${PGGROUP}\", so I will use it."
+	else
+		if pw groupadd ${PGGROUP} -g ${GID}; then
+			echo "Added group \"${PGGROUP}\"."
+		else
+			echo "Adding group \"${PGGROUP}\" failed..."
+			exit 1
+		fi
+	fi
+
+	if pw user show "${PGUSER}" 2>/dev/null; then
+		echo "You already have a user \"${PGUSER}\", so I will use it."
+	else
+		if pw useradd ${PGUSER} -u ${UID} -g ${PGGROUP} -h - \
+			-d ${DB_DIR} -c "PostgreSQL Daemon"
+		then
+			echo "Added user \"${PGUSER}\"."
+		else
+			echo "Adding user \"${PGUSER}\" failed..."
+			exit 1
+		fi
+	fi
+
+	if ! [ -x ~${PGUSER} ] ; then 
+		install -m 755 -o ${PGUSER} -g ${PGGROUP} -d ${DB_DIR}
+	fi
+	;;
+
 BACKUPWARNING)
 	backupwarning
 	;;
diff --git a/databases/postgresql84-server/Makefile b/databases/postgresql84-server/Makefile
index da72a935b758..8c6d4972a77b 100644
--- a/databases/postgresql84-server/Makefile
+++ b/databases/postgresql84-server/Makefile
@@ -37,6 +37,7 @@ GNU_CONFIGURE=	YES
 
 PG_USER?=	pgsql
 PG_GROUP?=	pgsql
+PG_UID?=	70
 
 LDFLAGS+=	-L${LOCALBASE}/lib
 INCLUDES+=	-I${LOCALBASE}/include
@@ -62,8 +63,6 @@ USE_RC_SUBR=	postgresql
 USE_PGSQL=	yes
 WANT_PGSQL_VER=	${PORTVERSION:C/([0-9][0-9]*)\.([0-9][0-9]*).*/\1\2/g}
 SUB_FILES+=	502.pgsql
-USERS=		${PG_USER}
-GROUPS=		${PG_GROUP}
 .endif
 
 .if !defined(SLAVE_ONLY)
@@ -285,11 +284,20 @@ PKGMESSAGE=	${WRKSRC}/pkg-message${PKGNAMESUFFIX}
 
 .  if exists(${FILESDIR}/pkg-install${PKGNAMESUFFIX}.in)
 SUB_FILES+=     pkg-install${PKGNAMESUFFIX}
+SUB_LIST=	PG_GROUP=$(PG_GROUP) \
+		PG_USER=$(PG_USER) \
+		PG_UID=$(PG_UID)
+PLIST_SUB+=	PG_USER=$(PG_USER)
 PKGINSTALL=	${WRKDIR}/pkg-install${PKGNAMESUFFIX}
 .  endif
 
 .endif
 
+.if defined(SERVER_ONLY)
+pre-su-install:
+	@ ${SETENV} PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PORTNAME} PRE-INSTALL
+.endif
+
 .if !defined(NO_BUILD)
 post-patch:
 	@${REINPLACE_CMD} s/@PTHREAD_LIBS@// ${WRKSRC}/src/Makefile.global.in
diff --git a/databases/postgresql84-server/files/pkg-install-server.in b/databases/postgresql84-server/files/pkg-install-server.in
index e3be291efdc1..da85c73b7e4c 100644
--- a/databases/postgresql84-server/files/pkg-install-server.in
+++ b/databases/postgresql84-server/files/pkg-install-server.in
@@ -4,6 +4,10 @@
 
 PATH=/bin:/usr/bin:/usr/sbin
 
+PG_USER=%%PG_USER%%
+PG_GROUP=%%PG_GROUP%%
+PG_UID=%%PG_UID%%
+
 backupwarning() { echo "
 
   =========== BACKUP YOUR DATA! =============
@@ -20,6 +24,39 @@ backupwarning() { echo "
 }
 
 case $2 in
+PRE-INSTALL)
+	backupwarning
+	DB_DIR=${PKG_PREFIX}/${PG_USER}
+
+	if pw group show "${PG_GROUP}" 2>/dev/null; then
+		echo "You already have a group \"${PG_GROUP}\", so I will use it."
+	else
+		if pw groupadd ${PG_GROUP} -g ${PG_UID}; then
+			echo "Added group \"${PG_GROUP}\"."
+		else
+			echo "Adding group \"${PG_GROUP}\" failed..."
+			exit 1
+		fi
+	fi
+
+	if pw user show "${PG_USER}" 2>/dev/null; then
+		echo "You already have a user \"${PG_USER}\", so I will use it."
+	else
+		if pw useradd ${PG_USER} -u ${PG_UID} -g ${PG_GROUP} -h - \
+			-d ${DB_DIR} -c "PostgreSQL Daemon"
+		then
+			echo "Added user \"${PG_USER}\"."
+		else
+			echo "Adding user \"${PG_USER}\" failed..."
+			exit 1
+		fi
+	fi
+
+	if ! [ -x ~${PG_USER} ] ; then 
+		install -m 755 -o ${PG_USER} -g ${PG_GROUP} -d ${DB_DIR}
+	fi
+	;;
+
 BACKUPWARNING)
 	backupwarning
 	;;
diff --git a/databases/postgresql84-server/pkg-plist-server b/databases/postgresql84-server/pkg-plist-server
index 4c64436eef2d..9134bcce6f4e 100644
--- a/databases/postgresql84-server/pkg-plist-server
+++ b/databases/postgresql84-server/pkg-plist-server
@@ -753,8 +753,9 @@ share/postgresql/tsearch_data/ispell_sample.dict
 share/postgresql/tsearch_data/synonym_sample.syn
 share/postgresql/tsearch_data/thesaurus_sample.ths
 @dirrmtry share/postgresql/tsearch_data
+@unexec echo "Warning: If you will *NOT* use this package anymore, please remove the pgsql user manually."
 @dirrmtry share/postgresql
 @dirrmtry etc/periodic/daily
 @dirrmtry etc/periodic
 @dirrmtry lib/postgresql
-@dirrmtry pgsql
+@dirrmtry %%PG_USER%%
diff --git a/databases/postgresql90-server/Makefile b/databases/postgresql90-server/Makefile
index 7417824cd567..5e702a374a7b 100644
--- a/databases/postgresql90-server/Makefile
+++ b/databases/postgresql90-server/Makefile
@@ -35,6 +35,7 @@ GNU_CONFIGURE=	YES
 
 PG_USER?=	pgsql
 PG_GROUP?=	pgsql
+PG_UID?=	70
 
 LDFLAGS+=	-L${LOCALBASE}/lib
 INCLUDES+=	-I${LOCALBASE}/include
@@ -61,8 +62,6 @@ USE_RC_SUBR=	postgresql
 USE_PGSQL=	yes
 WANT_PGSQL_VER=	${PORTVERSION:C/([0-9][0-9]*)\.([0-9][0-9]*).*/\1\2/g}
 SUB_FILES+=	502.pgsql
-USERS=		${PG_USER}
-GROUPS=		${PG_GROUP}
 .endif
 
 .if !defined(SLAVE_ONLY)
@@ -315,10 +314,19 @@ PKGMESSAGE=	${WRKSRC}/pkg-message${PKGNAMESUFFIX}
 .  endif
 .  if exists(${FILESDIR}/pkg-install${PKGNAMESUFFIX}.in)
 SUB_FILES+=     pkg-install${PKGNAMESUFFIX}
+SUB_LIST=       PG_GROUP=$(PG_GROUP) \
+                PG_USER=$(PG_USER) \
+                PG_UID=$(PG_UID)
+PLIST_SUB+=     PG_USER=$(PG_USER)
 PKGINSTALL=     ${WRKDIR}/pkg-install${PKGNAMESUFFIX}
 .  endif
 .endif
 
+.if defined(SERVER_ONLY)
+pre-su-install:
+	@ ${SETENV} PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PORTNAME} PRE-INSTALL
+.endif
+
 .if !defined(NO_BUILD)
 post-patch:
 	@${REINPLACE_CMD} s/@PTHREAD_LIBS@// ${WRKSRC}/src/Makefile.global.in
diff --git a/databases/postgresql90-server/files/pkg-install-server.in b/databases/postgresql90-server/files/pkg-install-server.in
index e3be291efdc1..da85c73b7e4c 100644
--- a/databases/postgresql90-server/files/pkg-install-server.in
+++ b/databases/postgresql90-server/files/pkg-install-server.in
@@ -4,6 +4,10 @@
 
 PATH=/bin:/usr/bin:/usr/sbin
 
+PG_USER=%%PG_USER%%
+PG_GROUP=%%PG_GROUP%%
+PG_UID=%%PG_UID%%
+
 backupwarning() { echo "
 
   =========== BACKUP YOUR DATA! =============
@@ -20,6 +24,39 @@ backupwarning() { echo "
 }
 
 case $2 in
+PRE-INSTALL)
+	backupwarning
+	DB_DIR=${PKG_PREFIX}/${PG_USER}
+
+	if pw group show "${PG_GROUP}" 2>/dev/null; then
+		echo "You already have a group \"${PG_GROUP}\", so I will use it."
+	else
+		if pw groupadd ${PG_GROUP} -g ${PG_UID}; then
+			echo "Added group \"${PG_GROUP}\"."
+		else
+			echo "Adding group \"${PG_GROUP}\" failed..."
+			exit 1
+		fi
+	fi
+
+	if pw user show "${PG_USER}" 2>/dev/null; then
+		echo "You already have a user \"${PG_USER}\", so I will use it."
+	else
+		if pw useradd ${PG_USER} -u ${PG_UID} -g ${PG_GROUP} -h - \
+			-d ${DB_DIR} -c "PostgreSQL Daemon"
+		then
+			echo "Added user \"${PG_USER}\"."
+		else
+			echo "Adding user \"${PG_USER}\" failed..."
+			exit 1
+		fi
+	fi
+
+	if ! [ -x ~${PG_USER} ] ; then 
+		install -m 755 -o ${PG_USER} -g ${PG_GROUP} -d ${DB_DIR}
+	fi
+	;;
+
 BACKUPWARNING)
 	backupwarning
 	;;
diff --git a/databases/postgresql90-server/pkg-plist-server b/databases/postgresql90-server/pkg-plist-server
index 92bd9dc89581..ffd6dfc752d2 100644
--- a/databases/postgresql90-server/pkg-plist-server
+++ b/databases/postgresql90-server/pkg-plist-server
@@ -756,8 +756,9 @@ share/postgresql/tsearch_data/ispell_sample.dict
 share/postgresql/tsearch_data/synonym_sample.syn
 share/postgresql/tsearch_data/thesaurus_sample.ths
 @dirrmtry share/postgresql/tsearch_data
+@unexec echo "Warning: If you will *NOT* use this package anymore, please remove the pgsql user manually."
 @dirrmtry share/postgresql
 @dirrmtry etc/periodic/daily
 @dirrmtry etc/periodic
 @dirrmtry lib/postgresql
-@dirrmtry pgsql
+@dirrmtry %%PG_USER%%