diff options
| author | Edwin Groothuis <edwin@FreeBSD.org> | 2006-01-05 00:43:42 +0000 |
|---|---|---|
| committer | Edwin Groothuis <edwin@FreeBSD.org> | 2006-01-05 00:43:42 +0000 |
| commit | 01394fbeed377e5f0352c17a802b726d455d9ec4 (patch) | |
| tree | 7a2ec0eb9e9060e25892cabd4b96b16baa0f92e1 /news | |
| parent | 8674d20fc7c304fde21fa5564c98249ef1d1a37d (diff) | |
Implement feedback from dougb@
It would be better to replace the SUB_FILES line in the
Makefile with:
USE_RC_SUBR= ${PORTNAME}.sh
This provides several benefits in the short term. It would
obviate the need for the post-install target and the pkg-plist
entry, as the USE_RC_SUBR macro handles that stuff (as well
as the SUB_FILES stuff) for you automatically. In the long
term, we're going to add even more support for good things
in the USE_RC_SUBR code, so it's a good idea to move that
direction now.
Notes
Notes:
svn path=/head/; revision=152769
Diffstat (limited to 'news')
| -rw-r--r-- | news/newscache/Makefile | 5 | ||||
| -rw-r--r-- | news/newscache/pkg-plist | 1 |
2 files changed, 1 insertions, 5 deletions
diff --git a/news/newscache/Makefile b/news/newscache/Makefile index 63d98d6f973a..b1c42bcc4a1c 100644 --- a/news/newscache/Makefile +++ b/news/newscache/Makefile @@ -24,7 +24,7 @@ AUTOMAKE_ARGS= --add-missing CONFIGURE_ENV= CPPFLAGS="${CFLAGS} -I${LOCALBASE}/include" \ LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib" CONFIGURE_ARGS+=--sysconfdir=${PREFIX}/etc -SUB_FILES= newscache.sh +USE_RC_SUBR= ${PORTNAME}.sh MAN5= newscache.conf.5 MAN8= newscache.8 newscacheclean.8 updatenews.8 @@ -36,7 +36,4 @@ post-patch: pre-configure: (cd ${WRKSRC}; ${SETENV} ${SCRIPTS_ENV} ${SH} ./autogen) -post-install: - cp ${WRKDIR}/newscache.sh ${PREFIX}/etc/rc.d - .include <bsd.port.mk> diff --git a/news/newscache/pkg-plist b/news/newscache/pkg-plist index 47ea849c34cc..f6d74ddf91be 100644 --- a/news/newscache/pkg-plist +++ b/news/newscache/pkg-plist @@ -1,6 +1,5 @@ bin/updatenews etc/newscache.conf-dist etc/newscache.auth-dist -etc/rc.d/newscache.sh sbin/newscache sbin/newscacheclean |