diff options
| author | Pav Lucistnik <pav@FreeBSD.org> | 2004-03-27 15:07:16 +0000 |
|---|---|---|
| committer | Pav Lucistnik <pav@FreeBSD.org> | 2004-03-27 15:07:16 +0000 |
| commit | fbfb1933d4ac0c288d3e38ad0057d7a0e7343645 (patch) | |
| tree | 2f92cf4217429b668eee47bc64cdb0f017c93f3d /www/phpbb/files | |
| parent | ed11cfda6db2c9cf4b6831e50b48f3f4bf1f35af (diff) | |
Notes
Diffstat (limited to 'www/phpbb/files')
| -rw-r--r-- | www/phpbb/files/patch-privmsg.php | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/www/phpbb/files/patch-privmsg.php b/www/phpbb/files/patch-privmsg.php new file mode 100644 index 000000000000..ae3bd897de5f --- /dev/null +++ b/www/phpbb/files/patch-privmsg.php @@ -0,0 +1,21 @@ +--- privmsg.php 2004-03-18 19:51:32.000000000 +0000 ++++ privmsg.1.php 2004-03-26 19:51:07.000000000 +0000 +@@ -212,7 +212,17 @@ + break; + case 'savebox': + $l_box_name = $lang['Savebox']; +- $pm_sql_user .= "AND ( ( pm.privmsgs_to_userid = " . $userdata['user_id'] . " ++ ++ // ++ // For some obscure reason, the assignment ++ // concatenation operator was coded below, which ++ // allowed an attacker to append arbitrary SQL code ++ // to the end of the $pm_sql_user variable. ++ // This is fixed below. ++ // ++ // -shaun2k2 ++ // ++ $pm_sql_user = "AND ( ( pm.privmsgs_to_userid = " . $userdata['user_id'] . " + AND pm.privmsgs_type = " . PRIVMSGS_SAVED_IN_MAIL . " ) + OR ( pm.privmsgs_from_userid = " . $userdata['user_id'] . " + AND pm.privmsgs_type = " . PRIVMSGS_SAVED_OUT_MAIL . " ) |