src-test/sys/dev/mrsas/mrsas_ioctl.c, branch main

Use uintptr_t instead of unsigned long for pointers.

2020-12-16T00:13:32Z

The sense_ptr thing is quite broken. As near as I can tell, the driver tries to copyout to a physical address rather than whatever user address the sense buffer should be copied to. It is not immediately obvious what user address the sense buffer should be copied to. Reviewed by: imp Obtained from: CheriBSD Sponsored by: DARPA Differential Revision: https://reviews.freebsd.org/D27578

Following bugs fixed as part of this patch:

2016-05-13T12:21:50Z

.Kernel panic while collecting kdump (reported by Doug A.) .NULL pointer dereference at sertain places .Removed dead codes Submitted by: Sumit Saxena Reviewed by: Kashyap Desai MFC after: 3 days Sponsored by: AVAGO Technologies

There was no ERROR handling for firmware command TIMEOUT. This patch

2016-05-13T12:00:46Z

takes care of any firmware command timeout scenarios by initiating OCR. Submitted by: Sumit Saxena Reviewed by: Kashyap Desai MFC after: 3 days Sponsored by: AVAGO Technologies

Replace 0 with NULL for pointers in misc. device drivers.

2016-04-12T17:23:03Z

Found with devel/coccinelle.

Corrected indentation on conflicted source files.

2015-05-06T10:46:28Z

Reviewed by: ambrisko MFC after: 2 weeks Sponsored by: AVAGO Technologies

1. All LSI namings are converted to AVAGO Tech.

2015-05-06T10:45:13Z

2. Fix in AEN path(suggested by John Baldwin). 3. Fix IOCTL path w.r.t Sense key handling Reviewed by: ambrisko MFC after: 2 weeks Sponsored by: AVAGO Technologies

No logical code change in this pathc.

2014-10-08T10:14:37Z

Only Style 9 changes for mrsas driver. Reviewed by: ambrisko MFC after: 2 weeks Sponsored by: AVAGO Technologies

In the passthru IOCTL path, the mfi command pool was freely accessible N times

2014-10-08T09:37:47Z

where as there are limited number(32) of mfi commands in the pool. The mfi command pool is now restricted to 27 simultaneous accesses by using a counting semaphore while calling the passthru function. In the mrsas_cam.c source file there was a same function name mrsas_poll(), which was same as the mrsas_poll() implemented in the mrsas.c file for the polling interface. To clearly distinguish the functionality by usage we have renamed the former as mrsas_cam_poll(). In the passthru function let's say it has got an mfi command from the pool but it has failed in one of the DMA function call which will lead to leak an mfi command because in the ERROR case it directly returns and not freeing up the occupied mfi command. Reviewed by: ambrisko MFC after: 2 weeks Sponsored by: AVAGO Technologies

This is a feature provided to run 32-bit linux binaries on FreeBSD 64bit

2014-10-08T09:19:35Z

machine, for which 32bit compatibilty code has been added. As in linux there is only one device entry that is used to fire IOCTL commands, a new device entry megaraid_sas_ioctl_node is added for solely this purpose. From one dev node i.e mrgaraid_sa_ioctl_node we have to find out the controller instance in case of multicontroller, for which one management info structure has been added. Reviewed by: ambrisko MFC after: 2 weeks Sponsored by: AVAGO Technologies

Add mrsas(4) driver from LSI official support of newer MegaRAID SAS

2014-05-07T16:16:49Z

cards. LSI has been maintaining this driver outside of the FreeBSD tree. It overlaps support of ThunderBolt and Invader cards that mfi(4) supports. By default mfi(4) will attach to cards. If the tunable: hw.mfi.mrsas_enable=1 is set then mfi(4) will not probe and attach to these newer cards and allow mrsas(4) to attach. So by default this driver will not effect a FreeBSD system unless mfi(4) is removed from the kernel or the tunable is enabled. mrsas(4) attaches disks to the CAM layer so it depends on CAM and devices show up as /dev/daX. mfiutil(8) does not work with mrsas. The FreeBSD version of MegaCli and StorCli from LSI do work with mrsas. It appears that StorCli only works with mrsas. MegaCli appears to work with mfi(4) and mrsas(4). It would be good to add mfiutil(4) support to mrsas, emulations modes, kernel logging, device aliases to ease the transition between mfi(4) and mrsas(4). Style issues should be resolved by LSI when they get committers approved. The plan is get this driver in FreeBSD 9.3 to improve HW support. Thanks to LSI for developing, testing and working with FreeBSD to make this driver co-exist in FreeBSD. This improves the overall support of MegaRAID SAS. Submitted by: Kashyap Desai Reviewed by: scottl MFC after: 3 days Sponsored by: LSI