FreeBSD source tree https://cgit-dev.freebsd.org/src-test/atom?h=main 2020-11-12T20:20:43Z 2020-11-12T20:20:43Z Alexander Motin mav@FreeBSD.org 2020-11-12T20:20:43Z urn:sha1:46fbd8004fbd88a0f385003f5b02458ce666400e MFC after: 1 week Sponsored by: iXsystems, Inc. 2020-11-05T21:44:58Z Mateusz Guzik mjg@FreeBSD.org 2020-11-05T21:44:58Z urn:sha1:71460dfcb275f0a2a20b39a332b0e1149c6e7e3f Both the size (128 bytes) and ephemeral nature of allocations make it a great fit for malloc. A dedicated zone unnecessarily avoids sharing buckets with 128-byte objects. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D27103 2020-09-01T22:03:10Z Mateusz Guzik mjg@FreeBSD.org 2020-09-01T22:03:10Z urn:sha1:d87b31e159cb313dad1049e91943dcdd479f2b2d 2020-05-02T20:47:58Z David Bright dab@FreeBSD.org 2020-05-02T20:47:58Z urn:sha1:4053f8ac4de7a978fe215f25e45469e512a2c7bb This fixes several Coverity-detected errors in the nvme driver. CIDs addressed: 1008344, 1009377, 1009380, 1193740, 1305470, 1403975, 1403980 Reviewed by: imp@, vangyzen@ MFC after: 5 days Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D24532 2020-05-01T21:24:19Z Warner Losh imp@FreeBSD.org 2020-05-01T21:24:19Z urn:sha1:d5cc572ce6009993fb3c4f6c887194b9ec3c9815 All callers are currently filtering bad nsid to this function, however, we'll have undefined behavior if that's not true. Add the KASSERT to prevent that. 2019-12-11T22:51:02Z Warner Losh imp@FreeBSD.org 2019-12-11T22:51:02Z urn:sha1:66e5985084a03bab06e5451d3fc606f955dfdfc8 This trims the boot time a bit more for AWS and other platforms that have nvme drives. There's no reason too do this inline. This has been in my tree a while, but IIRC I talked to Jim Harris about this at one of our face to face meetings. MFC After: 2 weeks 2019-09-03T15:26:11Z Warner Losh imp@FreeBSD.org 2019-09-03T15:26:11Z urn:sha1:4d5475613eda7c766896873dc7b7158e60fb9c58 When we suspend, we need to properly shutdown the NVME controller. The controller may go into D3 state (or may have the power removed), and to properly flush the metadata to non-volatile RAM, we must complete a normal shutdown. This consists of deleting the I/O queues and setting the shutodown bit. We have to do some extra stuff to make sure we reset the software state of the queues as well. On resume, we have to reset the card twice, for reasons described in the attach funcion. Once we've done that, we can restart the card. If any of this fails, we'll fail the NVMe card, just like we do when a reset fails. Set is_resetting for the duration of the suspend / resume. This keeps the reset taskqueue from running a concurrent reset, and also is needed to prevent any hw completions from queueing more I/O to the card. Pass resetting flag to nvme_ctrlr_start. It doesn't need to get that from the global state of the ctrlr. Wait for any pending reset to finish. All queued I/O will get sent to the hardware as part of nvme_ctrlr_start(), though the upper layers shouldn't send any down. Disabling the qpairs is the other failsafe to ensure all I/O is queued. Rename nvme_ctrlr_destory_qpairs to nvme_ctrlr_delete_qpairs to avoid confusion with all the other destroy functions. It just removes the queues in hardware, while the other _destroy_ functions tear down driver data structures. Split parts of the hardware reset function up so that I can do part of the reset in suspsend. Split out the software disabling of the qpairs into nvme_ctrlr_disable_qpairs. Finally, fix a couple of spelling errors in comments related to this. Relnotes: Yes MFC After: 1 week Reviewed by: scottl@ (prior version) Differential Revision: https://reviews.freebsd.org/D21493 2019-08-23T22:52:58Z Warner Losh imp@FreeBSD.org 2019-08-23T22:52:58Z urn:sha1:5f9e856e3a0ded0b1c45f42d3b93a4a5c695eb74 While it worked with the kenrel, it wasn't working with the loader. It failed to handle dependencies correctly. The reason for that is that we never created a nvme module with the DRIVER_MODULE, but instead a nvme_pci and nvme_ahci module. Create a real nvme module that nvd can be dependent on so it can import the nvme symbols it needs from there. Arguably, nvd should just be a simple child of nvme, but transitioning to that (and winning that argument given why it was done this way) is beyond the scope of this change. Reviewed by: jhb@ Differential Revision: https://reviews.freebsd.org/D21382 2019-08-22T02:53:51Z Warner Losh imp@FreeBSD.org 2019-08-22T02:53:51Z urn:sha1:acc48026b3019fe25360d781c6eb0a118cf2935b Noticed by: rpokala@ 2019-08-21T22:17:55Z Warner Losh imp@FreeBSD.org 2019-08-21T22:17:55Z urn:sha1:f182f928dba2089ceb897191e546f32362035ddc Nvme drives can be attached in a number of different ways. Separate out the PCI attachment so that we can have other attachment types, like ahci and various types of NVMeoF. Submitted by: cognet@