FreeBSD source tree https://cgit-dev.freebsd.org/src-test/atom?h=main 2020-12-14T22:23:08Z 2020-12-14T22:23:08Z Alexander V. Chernikov melifaro@FreeBSD.org 2020-12-14T22:23:08Z urn:sha1:d5fe384b4d41a5c5adeaa6039d33d59d7bc33e76 Ability to load-balance traffic over multiple path is a must-have thing for routers. It may be used by the servers to balance outgoing traffic over multiple default gateways. The previous implementation, RADIX_MPATH stayed in the shadow for too long. It was not well maintained, which lead us to a vicious circle - people were using non-contiguous mask or firewalls to achieve similar goals. As a result, some routing daemons implementation still don't have multipath support enabled for FreeBSD. Turning on ROUTE_MPATH by default would fix it. It will allow to reduce networking feature gap to other operating systems. Linux and OpenBSD enabled similar support at least 5 years ago. ROUTE_MPATH does not consume memory unless actually used. It enables around ~1k LOC. It does not bring any behaviour changes for userland. Additionally, feature is (temporarily) turned off by the net.route.multipath sysctl defaulting to 0. Differential Revision: https://reviews.freebsd.org/D27428 2020-12-13T03:58:43Z Brandon Bergren bdragon@FreeBSD.org 2020-12-13T03:58:43Z urn:sha1:ab5711797d0b0beede72e87aab3cc88fc8b5f2de * Fix incorrect operation on 32-bit caused by incorrectly-sized storage for a temporary FPSCR. * Fix several whitespace problems. * Don't try to enable VSX during cleanup_fpscr(). Reviewed by: alfredo, jhibbits (earlier version) Sponsored by: Tag1 Consulting, Inc. Differential Revision: https://reviews.freebsd.org/D27453 2020-12-05T00:33:28Z Conrad Meyer cem@FreeBSD.org 2020-12-05T00:33:28Z urn:sha1:78599c32efed3247d165302a1fbe8d9203e38974 Follow-up to r353959 and r368070: do the same for other architectures. arm32 already seems to use its own .fnstart/.fnend directives, which appear to be ARM-specific variants of the same thing. Likewise, MIPS uses .frame directives. Reviewed by: arichardson Differential Revision: https://reviews.freebsd.org/D27387 2020-12-03T01:39:59Z Brandon Bergren bdragon@FreeBSD.org 2020-12-03T01:39:59Z urn:sha1:3de50be851fefcfbca7a2cdecb1e86305cc2531d In the PCB struct, we need to match the VSX register file layout correctly, as the VSRs shadow the FPRs. In LE, we need to have a dword of padding before the fprs so they end up on the correct side, as the struct may be manipulated by either the FP routines or the VSX routines. Additionally, when saving and restoring fprs, we need to explicitly target the fpr union member so it gets offset correctly on LE. Fixes weirdness with FP registers in VSX-using programs (A FPR that was saved by the FP routines but restored by the VSX routines was becoming 0 due to being loaded to the wrong side of the VSR.) Original patch by jhibbits. Reviewed by: jhibbits Differential Revision: https://reviews.freebsd.org/D27431 2020-11-28T12:12:51Z Konstantin Belousov kib@FreeBSD.org 2020-11-28T12:12:51Z urn:sha1:cd8537910406e68d4719136a5b0cf6d23bb1b23b Replace MAXPHYS by runtime variable maxphys. It is initialized from MAXPHYS by default, but can be also adjusted with the tunable kern.maxphys. Make b_pages[] array in struct buf flexible. Size b_pages[] for buffer cache buffers exactly to atop(maxbcachebuf) (currently it is sized to atop(MAXPHYS)), and b_pages[] for pbufs is sized to atop(maxphys) + 1. The +1 for pbufs allow several pbuf consumers, among them vmapbuf(), to use unaligned buffers still sized to maxphys, esp. when such buffers come from userspace (*). Overall, we save significant amount of otherwise wasted memory in b_pages[] for buffer cache buffers, while bumping MAXPHYS to desired high value. Eliminate all direct uses of the MAXPHYS constant in kernel and driver sources, except a place which initialize maxphys. Some random (and arguably weird) uses of MAXPHYS, e.g. in linuxolator, are converted straight. Some drivers, which use MAXPHYS to size embeded structures, get private MAXPHYS-like constant; their convertion is out of scope for this work. Changes to cam/, dev/ahci, dev/ata, dev/mpr, dev/mpt, dev/mvs, dev/siis, where either submitted by, or based on changes by mav. Suggested by: mav (*) Reviewed by: imp, mav, imp, mckusick, scottl (intermediate versions) Tested by: pho Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D27225 2020-11-20T18:52:37Z Alfredo Dal'Ava Junior alfredo@FreeBSD.org 2020-11-20T18:52:37Z urn:sha1:e63daed1b8daf44927e9506ce4bb3759867a771d Print 'type' field in hex to improve readability Reviewed by: jhibbits Differential Revision: https://reviews.freebsd.org/D27294 2020-11-19T03:59:21Z Mark Johnston markj@FreeBSD.org 2020-11-19T03:59:21Z urn:sha1:431fb8abd7946ccb6710b41337ba8476fea448f2 It can useful for code outside the VM system to look up the NUMA domain of a page backing a virtual or physical address, specifically when creating NUMA-aware data structures. We have _vm_phys_domain() for this, but the leading underscore implies that it's an internal function, and vm_phys.h has dependencies on a number of other headers. Rename vm_phys_domain() to vm_page_domain(), and _vm_phys_domain() to vm_phys_domain(). Make the latter an inline function. Add _vm_phys.h and define struct vm_phys_seg there so that it's easier to use in other headers. Include it from vm_page.h so that vm_page_domain() can be defined there. Include machine/vmparam.h from _vm_phys.h since it depends directly on some constants defined there. Reviewed by: alc Reviewed by: dougm, kib (earlier versions) Differential Revision: https://reviews.freebsd.org/D27207 2020-11-17T12:33:12Z Alfredo Dal'Ava Junior alfredo@FreeBSD.org 2020-11-17T12:33:12Z urn:sha1:23f001f742d1cee649bde91ec8a787dc343ad1f8 r367416 should have called save_fpu() before kern_sigprocmask to avoid race condition Thanks jhibbits and bdragon for pointing it out Reviewed by: jhibbits Sponsored by: Eldorado Research Institute (eldorado.org.br) Differential Revision: https://reviews.freebsd.org/D27241 2020-11-17T11:36:31Z Leandro Lupori luporl@FreeBSD.org 2020-11-17T11:36:31Z urn:sha1:5b58b1aaf8c4aa39f5b9b42862e810ceeba94041 After r367417, both mmu_oea64 and mmu_radix were defining the vm.pmap sysctl node, resulting in the later definition hiding the properties of the previous one. Avoid this issue by defining vm.pmap in a common source file and declaring it where needed. This change also standardizes the tunable name used to enable superpages and change its default to disabled on radix MMU, because it still has some issues with superpages. Reviewed by: bdragon, jhibbits Sponsored by: Eldorado Research Institute (eldorado.org.br) Differential Revision: https://reviews.freebsd.org/D27156 2020-11-13T16:56:03Z Brandon Bergren bdragon@FreeBSD.org 2020-11-13T16:56:03Z urn:sha1:0e0457251ba01ccf44fa483ff425d600925571e1 There were many, many endianness fixes needed for Radix MMU. The Radix pagetable is stored in BE (as it is read and written to by the MMU hw), so we need to convert back and forth every time we interact with it when running in LE. With these changes, I can successfully boot with radix enabled on POWER9 hw. Reviewed by: luporl, jhibbits Sponsored by: Tag1 Consulting, Inc. Differential Revision: https://reviews.freebsd.org/D27181