FreeBSD source tree https://cgit-dev.freebsd.org/src-test/atom?h=main 2020-05-21T01:55:35Z 2020-05-21T01:55:35Z Ryan Moeller freqlabs@FreeBSD.org 2020-05-21T01:55:35Z urn:sha1:245bfd34da590e12884bd1a5677f3227a36d4bcf Comparing fsid_t objects requires internal knowledge of the fsid structure and yet this is duplicated across a number of places in the code. Simplify by creating a fsidcmp function (macro). Reviewed by: mjg, rmacklem Approved by: mav (mentor) MFC after: 1 week Sponsored by: iXsystems, Inc. Differential Revision: https://reviews.freebsd.org/D24749 2020-02-26T14:26:36Z Pawel Biernacki kaktus@FreeBSD.org 2020-02-26T14:26:36Z urn:sha1:7029da5c36f2d3cf6bb6c81bf551229f416399e8 r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes. This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags. Mark all obvious cases as MPSAFE. All entries that haven't been marked as MPSAFE before are by default marked as NEEDGIANT Approved by: kib (mentor, blanket) Commented by: kib, gallatin, melifaro Differential Revision: https://reviews.freebsd.org/D23718 2018-12-11T19:32:16Z Mateusz Guzik mjg@FreeBSD.org 2018-12-11T19:32:16Z urn:sha1:cc426dd31990b8b50b210efc450e404596548ca1 Patch mostly generated with cocinnelle: @@ expression E1,E2; @@ - priv_check_cred(E1,E2,0) + priv_check_cred(E1,E2) Sponsored by: The FreeBSD Foundation 2017-06-13T01:17:58Z Ed Maste emaste@FreeBSD.org 2017-06-13T01:17:58Z urn:sha1:993114dd2a6094cc985f3c567e188a7f0f3be522 PR: 218039 CID: 1008934 Reported by: Coverity, PVS-Studio Reviewed by: kib MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D10300 2014-06-28T03:56:17Z Hans Petter Selasky hselasky@FreeBSD.org 2014-06-28T03:56:17Z urn:sha1:af3b2549c4ba2ef00a7cbb4cb6836598bf0aefbe 2014-06-27T22:05:21Z Glen Barber gjb@FreeBSD.org 2014-06-27T22:05:21Z urn:sha1:37a107a407cdb47ee0f4c4337e369e9973b34076 These changes prevent sysctl(8) from returning proper output, such as: 1) no output from sysctl(8) 2) erroneously returning ENOMEM with tools like truss(1) or uname(1) truss: can not get etype: Cannot allocate memory 2014-06-27T16:33:43Z Hans Petter Selasky hselasky@FreeBSD.org 2014-06-27T16:33:43Z urn:sha1:3da1cf1e88f8448bb10c5f778ab56ff65c7a6938 there is an environment variable which shall initialize the SYSCTL during early boot. This works for all SYSCTL types both statically and dynamically created ones, except for the SYSCTL NODE type and SYSCTLs which belong to VNETs. A new flag, CTLFLAG_NOFETCH, has been added to be used in the case a tunable sysctl has a custom initialisation function allowing the sysctl to still be marked as a tunable. The kernel SYSCTL API is mostly the same, with a few exceptions for some special operations like iterating childrens of a static/extern SYSCTL node. This operation should probably be made into a factored out common macro, hence some device drivers use this. The reason for changing the SYSCTL API was the need for a SYSCTL parent OID pointer and not only the SYSCTL parent OID list pointer in order to quickly generate the sysctl path. The motivation behind this patch is to avoid parameter loading cludges inside the OFED driver subsystem. Instead of adding special code to the OFED driver subsystem to post-load tunables into dynamically created sysctls, we generalize this in the kernel. Other changes: - Corrected a possibly incorrect sysctl name from "hw.cbb.intr_mask" to "hw.pcic.intr_mask". - Removed redundant TUNABLE statements throughout the kernel. - Some minor code rewrites in connection to removing not needed TUNABLE statements. - Added a missing SYSCTL_DECL(). - Wrapped two very long lines. - Avoid malloc()/free() inside sysctl string handling, in case it is called to initialize a sysctl from a tunable, hence malloc()/free() is not ready when sysctls from the sysctl dataset are registered. - Bumped FreeBSD version to indicate SYSCTL API change. MFC after: 2 weeks Sponsored by: Mellanox Technologies 2011-11-07T15:43:11Z Ed Schouten ed@FreeBSD.org 2011-11-07T15:43:11Z urn:sha1:6472ac3d8a86336899b6cfb789a4cd9897e3fab5 The SYSCTL_NODE macro defines a list that stores all child-elements of that node. If there's no SYSCTL_DECL macro anywhere else, there's no reason why it shouldn't be static. 2011-11-07T06:44:47Z Ed Schouten ed@FreeBSD.org 2011-11-07T06:44:47Z urn:sha1:d745c852becf3792a2185003947324721209195a This means that their use is restricted to a single C file. 2009-05-27T14:11:23Z Jamie Gritton jamie@FreeBSD.org 2009-05-27T14:11:23Z urn:sha1:0304c7316344d7e2d1dee3aa0249724ec629e8ef by creating a child jail, which is visible to that jail and to any parent jails. Child jails may be restricted more than their parents, but never less. Jail names reflect this hierarchy, being MIB-style dot-separated strings. Every thread now points to a jail, the default being prison0, which contains information about the physical system. Prison0's root directory is the same as rootvnode; its hostname is the same as the global hostname, and its securelevel replaces the global securelevel. Note that the variable "securelevel" has actually gone away, which should not cause any problems for code that properly uses securelevel_gt() and securelevel_ge(). Some jail-related permissions that were kept in global variables and set via sysctls are now per-jail settings. The sysctls still exist for backward compatibility, used only by the now-deprecated jail(2) system call. Approved by: bz (mentor)