FreeBSD source tree https://cgit-dev.freebsd.org/src-test/atom?h=main 2020-05-25T16:40:48Z 2020-05-25T16:40:48Z Conrad Meyer cem@FreeBSD.org 2020-05-25T16:40:48Z urn:sha1:852c303b61d12d13b56ed7affe31df193aadf9ae This reapplies logical r360944 and r360946 (reverting r360955), with fixed copystr() stand-in replacement macro. Eventually the goal is to convert consumers and kill the macro, but for a first step it helps if the macro is correct. Prior commit message: Unlike the other copy*() functions, it does not serve to copy from one address space to another or protect against potential faults. It's just an older incarnation of the now-more-common strlcpy(). Add a coccinelle script to tools/ which can be used to mechanically convert existing instances where replacement with strlcpy is trivial. In the two cases which matched, fuse_vfsops.c and union_vfsops.c, the code was further refactored manually to simplify. Replace the declaration of copystr() in systm.h with a small macro wrapper around strlcpy (with correction from brooks@ -- thanks). Remove N redundant MI implementations of copystr. For MIPS, this entailed inlining the assembler copystr into the only consumer, copyinstr, and making the latter a leaf function. Reviewed by: jhb (earlier version) Discussed with: brooks (thanks!) Differential Revision: https://reviews.freebsd.org/D24672 2020-05-12T04:34:26Z Conrad Meyer cem@FreeBSD.org 2020-05-12T04:34:26Z urn:sha1:051fc58cb368b8d1670f2728e1c07103cae812dd Reported by: cy 2020-05-11T22:57:21Z Conrad Meyer cem@FreeBSD.org 2020-05-11T22:57:21Z urn:sha1:580744621f33383027108364dcadad718df46ffe Unlike the other copy*() functions, it does not serve to copy from one address space to another or protect against potential faults. It's just an older incarnation of the now-more-common strlcpy(). Add a coccinelle script to tools/ which can be used to mechanically convert existing instances where replacement with strlcpy is trivial. In the two cases which matched, fuse_vfsops.c and union_vfsops.c, the code was further refactored manually to simplify. Replace the declaration of copystr() in systm.h with a small macro wrapper around strlcpy. Remove N redundant MI implementations of copystr. For MIPS, this entailed inlining the assembler copystr into the only consumer, copyinstr, and making the latter a leaf function. Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D24672