FreeBSD source tree https://cgit-dev.freebsd.org/src-test/atom?h=main 2020-12-02T16:46:45Z 2020-12-02T16:46:45Z Mark Johnston markj@FreeBSD.org 2020-12-02T16:46:45Z urn:sha1:ecce515d54bcea54fea03f731aad646c87761d22 - Avoid leaking a socket if llflags_get() fails. - Avoid leaking a file handle if rtsold_init_dumpfile() fails. - Tighten the check in if_nametosdl() which determines whether we failed to find the specified interface. - Fix errno handling in an error path in rtsock_open(). MFC after: 1 week 2020-12-01T19:34:44Z Mark Johnston markj@FreeBSD.org 2020-12-01T19:34:44Z urn:sha1:f2fb8af155226583c50c1d836b83e21a3d40832c Approved by: so Security: CVE-2020-25577 MFC after: now 2020-11-27T18:40:51Z Hajimu UMEMOTO ume@FreeBSD.org 2020-11-27T18:40:51Z urn:sha1:1def0a6257f63f5985c9dbcd30531a2b603e6556 MFC after: 1 week 2020-10-23T14:56:17Z Mark Johnston markj@FreeBSD.org 2020-10-23T14:56:17Z urn:sha1:a792802f2b1d0ae078b922fe2b747770d748a6ab MFC after: 1 week 2020-08-25T16:09:23Z Bjoern A. Zeeb bz@FreeBSD.org 2020-08-25T16:09:23Z urn:sha1:60e7f66931a5cf268d356fd11532245e057267ac While we do support the "O bit" running a script (usually to start a dhcpv6 client) we have no options for setups which set the "M bit" for, e.g., static address assignment as in EC2. Duplicate most of the "O bit" logic to also start a script for the "M bit" with the one difference: if the "M bit" is set we will not start the script for the "O bit" as well (per RFC 4861, Section 4.2). Reviewed by: hrs, markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D26099 2019-12-11T17:37:53Z Simon J. Gerraty sjg@FreeBSD.org 2019-12-11T17:37:53Z urn:sha1:2c9a9dfc187d171de6b92654d71b977f067ed641 Update a bunch of Makefile.depend files as a result of adding Makefile.depend.options files Reviewed by: bdrewery MFC after: 1 week Sponsored by: Juniper Networks Differential Revision: https://reviews.freebsd.org/D22494 2019-12-11T17:37:37Z Simon J. Gerraty sjg@FreeBSD.org 2019-12-11T17:37:37Z urn:sha1:5ab1c5846ff41be24b1f6beb0317bf8258cd4409 Leaf directories that have dependencies impacted by options need a Makefile.depend.options file to avoid churn in Makefile.depend DIRDEPS for cases such as OPENSSL, TCP_WRAPPERS etc can be set in local.dirdeps-options.mk which can add to those set in Makefile.depend.options See share/mk/dirdeps-options.mk Reviewed by: bdrewery MFC after: 1 week Sponsored by: Juniper Networks Differential Revision: https://reviews.freebsd.org/D22469 2019-11-21T00:17:14Z Mark Johnston markj@FreeBSD.org 2019-11-21T00:17:14Z urn:sha1:e7485a436bad14cbf3f6a2180481ccc6bcd2997d Reported by: sjg Sponsored by: The FreeBSD Foundation 2019-02-27T18:13:41Z Mark Johnston markj@FreeBSD.org 2019-02-27T18:13:41Z urn:sha1:ee74c3327aeadabe5b55102e9d05ca3dc9f21d41 This ensures that the program name is included in the output, which makes it easy to identify the source of error messages printed during boot. MFC after: 1 week 2019-01-05T16:05:39Z Mark Johnston markj@FreeBSD.org 2019-01-05T16:05:39Z urn:sha1:04e9edb5442826a14616157962361ff81e4a38fe These programs parse ND6 Router Advertisement messages; rtsold(8) has required an SA, SA-14:20.rtsold, for a bug in this code. Thus, they are good candidates for sandboxing. The approach taken is to run the main executable in capability mode and use Casper services to provide functionality that cannot be implemented within the sandbox. In particular, several custom services were required. - A Casper service is used to send Router Solicitation messages on a raw ICMP6 socket. Initially I took the approach of creating a socket for each interface upon startup, and connect(2)ing it to the all-routers multicast group for the interface. This permits the use of sendmsg(2) in capability mode, but only works if the interface's link is up when rtsol(d) starts. So, instead, the rtsold.sendmsg service is used to transmit RS messages on behalf of the main process. One could alternately define a service which simply creates and connects a socket for each destination address, and returns the socket to the sandboxed process. However, to implement rtsold's -m option we also need to read the ND6 default router list, and this cannot be done in capability mode. - rtsold may execute resolvconf(8) in response to RDNSS and DNSSL options in received RA messages. A Casper service is used to fork and exec resolvconf(8), and to reap the child process. - A service is used to determine whether a given interface's link-local address is useable (i.e., not duplicated or undergoing DAD). This information is supplied by getifaddrs(3), which reads a sysctl not available in capability mode. The SIOCGIFCONF socket ioctl provides equivalent information and can be used in capability mode, but I decided against it for now because of some limitations of that interface. In addition to these new services, cap_syslog(3) is used to send messages to syslogd. Reviewed by: oshogbo Tested by: bz (previous versions) MFC after: 2 months Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D17572