diff options
| author | Attilio Rao <attilio@FreeBSD.org> | 2011-05-02 17:13:40 +0000 | 
|---|---|---|
| committer | Attilio Rao <attilio@FreeBSD.org> | 2011-05-02 17:13:40 +0000 | 
| commit | 1d221389b29cdb56e5dd018fb1d2a9d4c1bec71e (patch) | |
| tree | 5e4761b7b740732bfd3e9bd66d92f79684fe2e95 | |
| parent | 7be8a2de4f936c53ce385b624530d719ee6b14d4 (diff) | |
Notes
| -rw-r--r-- | lib/libmemstat/memstat.c | 2 | ||||
| -rw-r--r-- | lib/libmemstat/memstat.h | 7 | ||||
| -rw-r--r-- | lib/libmemstat/memstat_internal.h | 4 | ||||
| -rw-r--r-- | lib/libmemstat/memstat_malloc.c | 13 | ||||
| -rw-r--r-- | lib/libmemstat/memstat_uma.c | 9 | 
5 files changed, 12 insertions, 23 deletions
diff --git a/lib/libmemstat/memstat.c b/lib/libmemstat/memstat.c index 1a08d3f4d4621..b2749e2b49339 100644 --- a/lib/libmemstat/memstat.c +++ b/lib/libmemstat/memstat.c @@ -193,7 +193,7 @@ _memstat_mt_reset_stats(struct memory_type *mtp)  	mtp->mt_zonefree = 0;  	mtp->mt_kegfree = 0; -	for (i = 0; i < MEMSTAT_MAXCPU; i++) { +	for (i = 0; i < MAXCPU; i++) {  		mtp->mt_percpu_alloc[i].mtp_memalloced = 0;  		mtp->mt_percpu_alloc[i].mtp_memfreed = 0;  		mtp->mt_percpu_alloc[i].mtp_numallocs = 0; diff --git a/lib/libmemstat/memstat.h b/lib/libmemstat/memstat.h index bc1a336a5d779..fa269443196ee 100644 --- a/lib/libmemstat/memstat.h +++ b/lib/libmemstat/memstat.h @@ -29,13 +29,6 @@  #ifndef _MEMSTAT_H_  #define	_MEMSTAT_H_ -#include <machine/param.h> - -/* - * Number of CPU slots in library-internal data structures. - */ -#define	MEMSTAT_MAXCPU	MAXCPU -  /*   * Amount of caller data to maintain for each caller data slot.  Applications   * must not request more than this number of caller save data, or risk diff --git a/lib/libmemstat/memstat_internal.h b/lib/libmemstat/memstat_internal.h index b7fdd7197cfe5..8881e585f526f 100644 --- a/lib/libmemstat/memstat_internal.h +++ b/lib/libmemstat/memstat_internal.h @@ -100,11 +100,11 @@ struct memory_type {  		uint64_t	 mtp_sizemask;	/* Per-CPU mt_sizemask. */  		void		*mtp_caller_pointer[MEMSTAT_MAXCALLER];  		uint64_t	 mtp_caller_uint64[MEMSTAT_MAXCALLER]; -	}	mt_percpu_alloc[MEMSTAT_MAXCPU]; +	}	mt_percpu_alloc[MAXCPU];  	struct {  		uint64_t	 mtp_free;	/* Per-CPU cache free items. */ -	}	mt_percpu_cache[MEMSTAT_MAXCPU]; +	}	mt_percpu_cache[MAXCPU];  	LIST_ENTRY(memory_type)	mt_list;	/* List of types. */  }; diff --git a/lib/libmemstat/memstat_malloc.c b/lib/libmemstat/memstat_malloc.c index 28a48c660546f..a8d14f87593c1 100644 --- a/lib/libmemstat/memstat_malloc.c +++ b/lib/libmemstat/memstat_malloc.c @@ -96,7 +96,7 @@ retry:  		return (-1);  	} -	if (maxcpus > MEMSTAT_MAXCPU) { +	if (maxcpus > MAXCPU) {  		list->mtl_error = MEMSTAT_ERROR_TOOMANYCPUS;  		return (-1);  	} @@ -160,7 +160,7 @@ retry:  		return (-1);  	} -	if (mtshp->mtsh_maxcpus > MEMSTAT_MAXCPU) { +	if (mtshp->mtsh_maxcpus > MAXCPU) {  		list->mtl_error = MEMSTAT_ERROR_TOOMANYCPUS;  		free(buffer);  		return (-1); @@ -295,7 +295,7 @@ memstat_kvm_malloc(struct memory_type_list *list, void *kvm_handle)  	void *kmemstatistics;  	int hint_dontsearch, j, mp_maxcpus, ret;  	char name[MEMTYPE_MAXNAME]; -	struct malloc_type_stats mts[MEMSTAT_MAXCPU], *mtsp; +	struct malloc_type_stats mts[MAXCPU], *mtsp;  	struct malloc_type_internal *mtip;  	struct malloc_type type, *typep;  	kvm_t *kvm; @@ -322,7 +322,7 @@ memstat_kvm_malloc(struct memory_type_list *list, void *kvm_handle)  		return (-1);  	} -	if (mp_maxcpus > MEMSTAT_MAXCPU) { +	if (mp_maxcpus > MAXCPU) {  		list->mtl_error = MEMSTAT_ERROR_TOOMANYCPUS;  		return (-1);  	} @@ -348,11 +348,6 @@ memstat_kvm_malloc(struct memory_type_list *list, void *kvm_handle)  			list->mtl_error = ret;  			return (-1);  		} - -		/* -		 * Since our compile-time value for MAXCPU may differ from the -		 * kernel's, we populate our own array. -		 */  		mtip = type.ks_handle;  		ret = kread(kvm, mtip->mti_stats, mts, mp_maxcpus *  		    sizeof(struct malloc_type_stats), 0); diff --git a/lib/libmemstat/memstat_uma.c b/lib/libmemstat/memstat_uma.c index 4aae61a9bb059..10ff8ec36a813 100644 --- a/lib/libmemstat/memstat_uma.c +++ b/lib/libmemstat/memstat_uma.c @@ -27,6 +27,7 @@   */  #include <sys/param.h> +#include <sys/cpuset.h>  #include <sys/sysctl.h>  #define	LIBMEMSTAT	/* Cause vm_page.h not to include opt_vmpage.h */ @@ -104,7 +105,7 @@ retry:  		return (-1);  	} -	if (maxcpus > MEMSTAT_MAXCPU) { +	if (maxcpus > MAXCPU) {  		list->mtl_error = MEMSTAT_ERROR_TOOMANYCPUS;  		return (-1);  	} @@ -168,7 +169,7 @@ retry:  		return (-1);  	} -	if (ushp->ush_maxcpus > MEMSTAT_MAXCPU) { +	if (ushp->ush_maxcpus > MAXCPU) {  		list->mtl_error = MEMSTAT_ERROR_TOOMANYCPUS;  		free(buffer);  		return (-1); @@ -313,7 +314,7 @@ memstat_kvm_uma(struct memory_type_list *list, void *kvm_handle)  	struct uma_keg *kzp, kz;  	int hint_dontsearch, i, mp_maxid, ret;  	char name[MEMTYPE_MAXNAME]; -	__cpumask_t all_cpus; +	cpuset_t all_cpus;  	kvm_t *kvm;  	kvm = (kvm_t *)kvm_handle; @@ -407,7 +408,7 @@ memstat_kvm_uma(struct memory_type_list *list, void *kvm_handle)  			if (kz.uk_flags & UMA_ZFLAG_INTERNAL)  				goto skip_percpu;  			for (i = 0; i < mp_maxid + 1; i++) { -				if ((all_cpus & (1 << i)) == 0) +				if (!CPU_ISSET(i, &all_cpus))  					continue;  				ucp = &ucp_array[i];  				mtp->mt_numallocs += ucp->uc_allocs;  | 
