summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKonstantin Belousov <kib@FreeBSD.org>2018-05-02 08:26:59 +0000
committerKonstantin Belousov <kib@FreeBSD.org>2018-05-02 08:26:59 +0000
commit98491133fdbb5013ccf26b8c87503ae01a4a6e93 (patch)
tree5d46fe21e092a30b7893c552225de3b737b202df
parentaa7d7eb311b021c360fe0a2b2057df427fc2d92e (diff)
Notes
-rw-r--r--lib/libc/secure/stack_protector.c20
1 files changed, 16 insertions, 4 deletions
diff --git a/lib/libc/secure/stack_protector.c b/lib/libc/secure/stack_protector.c
index d55813e00f1de..34bb7d0332a3b 100644
--- a/lib/libc/secure/stack_protector.c
+++ b/lib/libc/secure/stack_protector.c
@@ -54,15 +54,27 @@ static void
__guard_setup(void)
{
static const int mib[2] = { CTL_KERN, KERN_ARND };
+ volatile long tmp_stack_chk_guard[nitems(__stack_chk_guard)];
size_t len;
- int error;
+ int error, idx;
if (__stack_chk_guard[0] != 0)
return;
- error = _elf_aux_info(AT_CANARY, __stack_chk_guard,
- sizeof(__stack_chk_guard));
- if (error == 0 && __stack_chk_guard[0] != 0)
+ /*
+ * Avoid using functions which might have stack protection
+ * enabled, to update the __stack_chk_guard. First fetch the
+ * data into a temporal array, then do manual volatile copy to
+ * not allow optimizer to call memcpy() behind us.
+ */
+ error = _elf_aux_info(AT_CANARY, (void *)tmp_stack_chk_guard,
+ sizeof(tmp_stack_chk_guard));
+ if (error == 0 && tmp_stack_chk_guard[0] != 0) {
+ for (idx = 0; idx < nitems(__stack_chk_guard); idx++) {
+ __stack_chk_guard[idx] = tmp_stack_chk_guard[idx];
+ tmp_stack_chk_guard[idx] = 0;
+ }
return;
+ }
len = sizeof(__stack_chk_guard);
if (__sysctl(mib, nitems(mib), __stack_chk_guard, &len, NULL, 0) ==