diff options
| author | Dimitry Andric <dim@FreeBSD.org> | 2018-08-02 17:32:43 +0000 | 
|---|---|---|
| committer | Dimitry Andric <dim@FreeBSD.org> | 2018-08-02 17:32:43 +0000 | 
| commit | b7eb8e35e481a74962664b63dfb09483b200209a (patch) | |
| tree | 1937fb4a348458ce2d02ade03ac3bb0aa18d2fcd /lib/IR/Instructions.cpp | |
| parent | eb11fae6d08f479c0799db45860a98af528fa6e7 (diff) | |
Notes
Diffstat (limited to 'lib/IR/Instructions.cpp')
| -rw-r--r-- | lib/IR/Instructions.cpp | 182 | 
1 files changed, 91 insertions, 91 deletions
diff --git a/lib/IR/Instructions.cpp b/lib/IR/Instructions.cpp index e0ad0d1ea1f1a..32db918dab973 100644 --- a/lib/IR/Instructions.cpp +++ b/lib/IR/Instructions.cpp @@ -310,7 +310,7 @@ void CallInst::init(FunctionType *FTy, Value *Func, ArrayRef<Value *> Args,           "Calling a function with bad signature!");    for (unsigned i = 0; i != Args.size(); ++i) -    assert((i >= FTy->getNumParams() ||  +    assert((i >= FTy->getNumParams() ||              FTy->getParamType(i) == Args[i]->getType()) &&             "Calling a function with a bad signature!");  #endif @@ -409,7 +409,7 @@ static Instruction *createMalloc(Instruction *InsertBefore,    assert(((!InsertBefore && InsertAtEnd) || (InsertBefore && !InsertAtEnd)) &&           "createMalloc needs either InsertBefore or InsertAtEnd"); -  // malloc(type) becomes:  +  // malloc(type) becomes:    //       bitcast (i8* malloc(typeSize)) to type*    // malloc(type, arraySize) becomes:    //       bitcast (i8* malloc(typeSize*arraySize)) to type* @@ -516,7 +516,7 @@ Instruction *CallInst::CreateMalloc(Instruction *InsertBefore,  /// responsibility of the caller.  Instruction *CallInst::CreateMalloc(BasicBlock *InsertAtEnd,                                      Type *IntPtrTy, Type *AllocTy, -                                    Value *AllocSize, Value *ArraySize,  +                                    Value *AllocSize, Value *ArraySize,                                      Function *MallocF, const Twine &Name) {    return createMalloc(nullptr, InsertAtEnd, IntPtrTy, AllocTy, AllocSize,                        ArraySize, None, MallocF, Name); @@ -612,7 +612,7 @@ void InvokeInst::init(FunctionType *FTy, Value *Fn, BasicBlock *IfNormal,           "Invoking a function with bad signature");    for (unsigned i = 0, e = Args.size(); i != e; i++) -    assert((i >= FTy->getNumParams() ||  +    assert((i >= FTy->getNumParams() ||              FTy->getParamType(i) == Args[i]->getType()) &&             "Invoking a function with a bad signature!");  #endif @@ -912,7 +912,7 @@ FuncletPadInst::FuncletPadInst(Instruction::FuncletPadOps Op, Value *ParentPad,  //                      UnreachableInst Implementation  //===----------------------------------------------------------------------===// -UnreachableInst::UnreachableInst(LLVMContext &Context,  +UnreachableInst::UnreachableInst(LLVMContext &Context,                                   Instruction *InsertBefore)    : TerminatorInst(Type::getVoidTy(Context), Instruction::Unreachable,                     nullptr, 0, InsertBefore) { @@ -1072,7 +1072,7 @@ bool AllocaInst::isArrayAllocation() const {  bool AllocaInst::isStaticAlloca() const {    // Must be constant size.    if (!isa<ConstantInt>(getArraySize())) return false; -   +    // Must be in the entry block.    const BasicBlock *Parent = getParent();    return Parent == &Parent->getParent()->front() && !isUsedWithInAlloca(); @@ -1125,7 +1125,7 @@ LoadInst::LoadInst(Type *Ty, Value *Ptr, const Twine &Name, bool isVolatile,    setName(Name);  } -LoadInst::LoadInst(Value *Ptr, const Twine &Name, bool isVolatile,  +LoadInst::LoadInst(Value *Ptr, const Twine &Name, bool isVolatile,                     unsigned Align, AtomicOrdering Order,                     SyncScope::ID SSID,                     BasicBlock *InsertAE) @@ -1380,7 +1380,7 @@ AtomicRMWInst::AtomicRMWInst(BinOp Operation, Value *Ptr, Value *Val,  //                       FenceInst Implementation  //===----------------------------------------------------------------------===// -FenceInst::FenceInst(LLVMContext &C, AtomicOrdering Ordering,  +FenceInst::FenceInst(LLVMContext &C, AtomicOrdering Ordering,                       SyncScope::ID SSID,                       Instruction *InsertBefore)    : Instruction(Type::getVoidTy(C), Fence, nullptr, 0, InsertBefore) { @@ -1388,7 +1388,7 @@ FenceInst::FenceInst(LLVMContext &C, AtomicOrdering Ordering,    setSyncScopeID(SSID);  } -FenceInst::FenceInst(LLVMContext &C, AtomicOrdering Ordering,  +FenceInst::FenceInst(LLVMContext &C, AtomicOrdering Ordering,                       SyncScope::ID SSID,                       BasicBlock *InsertAtEnd)    : Instruction(Type::getVoidTy(C), Fence, nullptr, 0, InsertAtEnd) { @@ -1575,14 +1575,14 @@ InsertElementInst::InsertElementInst(Value *Vec, Value *Elt, Value *Index,    setName(Name);  } -bool InsertElementInst::isValidOperands(const Value *Vec, const Value *Elt,  +bool InsertElementInst::isValidOperands(const Value *Vec, const Value *Elt,                                          const Value *Index) {    if (!Vec->getType()->isVectorTy())      return false;   // First operand of insertelement must be vector type. -   +    if (Elt->getType() != cast<VectorType>(Vec->getType())->getElementType())      return false;// Second operand of insertelement must be vector element type. -     +    if (!Index->getType()->isIntegerTy())      return false;  // Third operand of insertelement must be i32.    return true; @@ -1632,7 +1632,7 @@ bool ShuffleVectorInst::isValidOperands(const Value *V1, const Value *V2,    // V1 and V2 must be vectors of the same type.    if (!V1->getType()->isVectorTy() || V1->getType() != V2->getType())      return false; -   +    // Mask must be vector of i32.    auto *MaskTy = dyn_cast<VectorType>(Mask->getType());    if (!MaskTy || !MaskTy->getElementType()->isIntegerTy(32)) @@ -1654,7 +1654,7 @@ bool ShuffleVectorInst::isValidOperands(const Value *V1, const Value *V2,      }      return true;    } -   +    if (const auto *CDS = dyn_cast<ConstantDataSequential>(Mask)) {      unsigned V1Size = cast<VectorType>(V1->getType())->getNumElements();      for (unsigned i = 0, e = MaskTy->getNumElements(); i != e; ++i) @@ -1662,7 +1662,7 @@ bool ShuffleVectorInst::isValidOperands(const Value *V1, const Value *V2,          return false;      return true;    } -   +    // The bitcode reader can create a place holder for a forward reference    // used as the shuffle mask. When this occurs, the shuffle mask will    // fall into this case and fail. To avoid this error, do this bit of @@ -1687,12 +1687,12 @@ int ShuffleVectorInst::getMaskValue(const Constant *Mask, unsigned i) {  void ShuffleVectorInst::getShuffleMask(const Constant *Mask,                                         SmallVectorImpl<int> &Result) {    unsigned NumElts = Mask->getType()->getVectorNumElements(); -   +    if (auto *CDS = dyn_cast<ConstantDataSequential>(Mask)) {      for (unsigned i = 0; i != NumElts; ++i)        Result.push_back(CDS->getElementAsInteger(i));      return; -  }     +  }    for (unsigned i = 0; i != NumElts; ++i) {      Constant *C = Mask->getAggregateElement(i);      Result.push_back(isa<UndefValue>(C) ? -1 : @@ -1806,7 +1806,7 @@ bool ShuffleVectorInst::isTransposeMask(ArrayRef<int> Mask) {  //                             InsertValueInst Class  //===----------------------------------------------------------------------===// -void InsertValueInst::init(Value *Agg, Value *Val, ArrayRef<unsigned> Idxs,  +void InsertValueInst::init(Value *Agg, Value *Val, ArrayRef<unsigned> Idxs,                             const Twine &Name) {    assert(getNumOperands() == 2 && "NumOperands not initialized?"); @@ -1903,7 +1903,7 @@ BinaryOperator::BinaryOperator(BinaryOps iType, Value *S1, Value *S2,    AssertOK();  } -BinaryOperator::BinaryOperator(BinaryOps iType, Value *S1, Value *S2,  +BinaryOperator::BinaryOperator(BinaryOps iType, Value *S1, Value *S2,                                 Type *Ty, const Twine &Name,                                 BasicBlock *InsertAtEnd)    : Instruction(Ty, iType, @@ -1938,8 +1938,8 @@ void BinaryOperator::AssertOK() {             "Tried to create a floating-point operation on a "             "non-floating-point type!");      break; -  case UDiv:  -  case SDiv:  +  case UDiv: +  case SDiv:      assert(getType() == LHS->getType() &&             "Arithmetic operation should return same type as operands!");      assert(getType()->isIntOrIntVectorTy() && @@ -1951,8 +1951,8 @@ void BinaryOperator::AssertOK() {      assert(getType()->isFPOrFPVectorTy() &&             "Incorrect operand type (not floating point) for FDIV");      break; -  case URem:  -  case SRem:  +  case URem: +  case SRem:      assert(getType() == LHS->getType() &&             "Arithmetic operation should return same type as operands!");      assert(getType()->isIntOrIntVectorTy() && @@ -2185,7 +2185,7 @@ bool CastInst::isLosslessCast() const {    Type *DstTy = getType();    if (SrcTy == DstTy)      return true; -   +    // Pointer to pointer is always lossless.    if (SrcTy->isPointerTy())      return DstTy->isPointerTy(); @@ -2194,10 +2194,10 @@ bool CastInst::isLosslessCast() const {  /// This function determines if the CastInst does not require any bits to be  /// changed in order to effect the cast. Essentially, it identifies cases where -/// no code gen is necessary for the cast, hence the name no-op cast.  For  +/// no code gen is necessary for the cast, hence the name no-op cast.  For  /// example, the following are all no-op casts:  /// # bitcast i32* %x to i8* -/// # bitcast <2 x i32> %x to <4 x i16>  +/// # bitcast <2 x i32> %x to <4 x i16>  /// # ptrtoint i32* %x to i32     ; on 32-bit plaforms only  /// Determine if the described cast is a no-op.  bool CastInst::isNoopCast(Instruction::CastOps Opcode, @@ -2208,7 +2208,7 @@ bool CastInst::isNoopCast(Instruction::CastOps Opcode,      default: llvm_unreachable("Invalid CastOp");      case Instruction::Trunc:      case Instruction::ZExt: -    case Instruction::SExt:  +    case Instruction::SExt:      case Instruction::FPTrunc:      case Instruction::FPExt:      case Instruction::UIToFP: @@ -2247,7 +2247,7 @@ unsigned CastInst::isEliminableCastPair(    Type *DstIntPtrTy) {    // Define the 144 possibilities for these two cast instructions. The values    // in this matrix determine what to do in a given situation and select the -  // case in the switch below.  The rows correspond to firstOp, the columns  +  // case in the switch below.  The rows correspond to firstOp, the columns    // correspond to secondOp.  In looking at the table below, keep in mind    // the following cast properties:    // @@ -2315,16 +2315,16 @@ unsigned CastInst::isEliminableCastPair(    int ElimCase = CastResults[firstOp-Instruction::CastOpsBegin]                              [secondOp-Instruction::CastOpsBegin];    switch (ElimCase) { -    case 0:  +    case 0:        // Categorically disallowed.        return 0; -    case 1:  +    case 1:        // Allowed, use first cast's opcode.        return firstOp; -    case 2:  +    case 2:        // Allowed, use second cast's opcode.        return secondOp; -    case 3:  +    case 3:        // No-op cast in second op implies firstOp as long as the DestTy        // is integer and we are not converting between a vector and a        // non-vector type. @@ -2337,7 +2337,7 @@ unsigned CastInst::isEliminableCastPair(        if (DstTy->isFloatingPointTy())          return firstOp;        return 0; -    case 5:  +    case 5:        // No-op cast in first op implies secondOp as long as the SrcTy        // is an integer.        if (SrcTy->isIntegerTy()) @@ -2449,7 +2449,7 @@ unsigned CastInst::isEliminableCastPair(      case 17:        // (sitofp (zext x)) -> (uitofp x)        return Instruction::UIToFP; -    case 99:  +    case 99:        // Cast combination can't happen (error in input). This is for all cases        // where the MidTy is not the same for the two cast instructions.        llvm_unreachable("Invalid Cast Combination"); @@ -2458,7 +2458,7 @@ unsigned CastInst::isEliminableCastPair(    }  } -CastInst *CastInst::Create(Instruction::CastOps op, Value *S, Type *Ty,  +CastInst *CastInst::Create(Instruction::CastOps op, Value *S, Type *Ty,    const Twine &Name, Instruction *InsertBefore) {    assert(castIsValid(op, S, Ty) && "Invalid cast!");    // Construct and return the appropriate CastInst subclass @@ -2502,7 +2502,7 @@ CastInst *CastInst::Create(Instruction::CastOps op, Value *S, Type *Ty,    }  } -CastInst *CastInst::CreateZExtOrBitCast(Value *S, Type *Ty,  +CastInst *CastInst::CreateZExtOrBitCast(Value *S, Type *Ty,                                          const Twine &Name,                                          Instruction *InsertBefore) {    if (S->getType()->getScalarSizeInBits() == Ty->getScalarSizeInBits()) @@ -2510,7 +2510,7 @@ CastInst *CastInst::CreateZExtOrBitCast(Value *S, Type *Ty,    return Create(Instruction::ZExt, S, Ty, Name, InsertBefore);  } -CastInst *CastInst::CreateZExtOrBitCast(Value *S, Type *Ty,  +CastInst *CastInst::CreateZExtOrBitCast(Value *S, Type *Ty,                                          const Twine &Name,                                          BasicBlock *InsertAtEnd) {    if (S->getType()->getScalarSizeInBits() == Ty->getScalarSizeInBits()) @@ -2518,7 +2518,7 @@ CastInst *CastInst::CreateZExtOrBitCast(Value *S, Type *Ty,    return Create(Instruction::ZExt, S, Ty, Name, InsertAtEnd);  } -CastInst *CastInst::CreateSExtOrBitCast(Value *S, Type *Ty,  +CastInst *CastInst::CreateSExtOrBitCast(Value *S, Type *Ty,                                          const Twine &Name,                                          Instruction *InsertBefore) {    if (S->getType()->getScalarSizeInBits() == Ty->getScalarSizeInBits()) @@ -2526,7 +2526,7 @@ CastInst *CastInst::CreateSExtOrBitCast(Value *S, Type *Ty,    return Create(Instruction::SExt, S, Ty, Name, InsertBefore);  } -CastInst *CastInst::CreateSExtOrBitCast(Value *S, Type *Ty,  +CastInst *CastInst::CreateSExtOrBitCast(Value *S, Type *Ty,                                          const Twine &Name,                                          BasicBlock *InsertAtEnd) {    if (S->getType()->getScalarSizeInBits() == Ty->getScalarSizeInBits()) @@ -2543,7 +2543,7 @@ CastInst *CastInst::CreateTruncOrBitCast(Value *S, Type *Ty,  }  CastInst *CastInst::CreateTruncOrBitCast(Value *S, Type *Ty, -                                         const Twine &Name,  +                                         const Twine &Name,                                           BasicBlock *InsertAtEnd) {    if (S->getType()->getScalarSizeInBits() == Ty->getScalarSizeInBits())      return Create(Instruction::BitCast, S, Ty, Name, InsertAtEnd); @@ -2636,7 +2636,7 @@ CastInst *CastInst::CreateIntegerCast(Value *C, Type *Ty,    return Create(opcode, C, Ty, Name, InsertBefore);  } -CastInst *CastInst::CreateIntegerCast(Value *C, Type *Ty,  +CastInst *CastInst::CreateIntegerCast(Value *C, Type *Ty,                                        bool isSigned, const Twine &Name,                                        BasicBlock *InsertAtEnd) {    assert(C->getType()->isIntOrIntVectorTy() && Ty->isIntOrIntVectorTy() && @@ -2650,8 +2650,8 @@ CastInst *CastInst::CreateIntegerCast(Value *C, Type *Ty,    return Create(opcode, C, Ty, Name, InsertAtEnd);  } -CastInst *CastInst::CreateFPCast(Value *C, Type *Ty,  -                                 const Twine &Name,  +CastInst *CastInst::CreateFPCast(Value *C, Type *Ty, +                                 const Twine &Name,                                   Instruction *InsertBefore) {    assert(C->getType()->isFPOrFPVectorTy() && Ty->isFPOrFPVectorTy() &&           "Invalid cast"); @@ -2663,8 +2663,8 @@ CastInst *CastInst::CreateFPCast(Value *C, Type *Ty,    return Create(opcode, C, Ty, Name, InsertBefore);  } -CastInst *CastInst::CreateFPCast(Value *C, Type *Ty,  -                                 const Twine &Name,  +CastInst *CastInst::CreateFPCast(Value *C, Type *Ty, +                                 const Twine &Name,                                   BasicBlock *InsertAtEnd) {    assert(C->getType()->isFPOrFPVectorTy() && Ty->isFPOrFPVectorTy() &&           "Invalid cast"); @@ -2707,7 +2707,7 @@ bool CastInst::isCastable(Type *SrcTy, Type *DestTy) {        return DestBits == SrcBits;                                        // Casting from something else      return SrcTy->isPointerTy(); -  }  +  }    if (DestTy->isFloatingPointTy()) {  // Casting to floating pt      if (SrcTy->isIntegerTy())                // Casting from integral        return true; @@ -2724,7 +2724,7 @@ bool CastInst::isCastable(Type *SrcTy, Type *DestTy) {      if (SrcTy->isPointerTy())                // Casting from pointer        return true;      return SrcTy->isIntegerTy();             // Casting from integral -  }  +  }    if (DestTy->isX86_MMXTy()) {      if (SrcTy->isVectorTy())        return DestBits == SrcBits;       // 64-bit vector to MMX @@ -2834,10 +2834,10 @@ CastInst::getCastOpcode(          return BitCast;                             // Same size, No-op cast        }      } else if (SrcTy->isFloatingPointTy()) {        // Casting from floating pt -      if (DestIsSigned)  +      if (DestIsSigned)          return FPToSI;                              // FP -> sint        else -        return FPToUI;                              // FP -> uint  +        return FPToUI;                              // FP -> uint      } else if (SrcTy->isVectorTy()) {        assert(DestBits == SrcBits &&               "Casting vector to integer of different width"); @@ -2898,7 +2898,7 @@ CastInst::getCastOpcode(  /// could be broken out into the separate constructors but it is useful to have  /// it in one place and to eliminate the redundant code for getting the sizes  /// of the types involved. -bool  +bool  CastInst::castIsValid(Instruction::CastOps op, Value *S, Type *DstTy) {    // Check for type sanity on the arguments    Type *SrcTy = S->getType(); @@ -2928,7 +2928,7 @@ CastInst::castIsValid(Instruction::CastOps op, Value *S, Type *DstTy) {    case Instruction::ZExt:      return SrcTy->isIntOrIntVectorTy() && DstTy->isIntOrIntVectorTy() &&        SrcLength == DstLength && SrcBitSize < DstBitSize; -  case Instruction::SExt:  +  case Instruction::SExt:      return SrcTy->isIntOrIntVectorTy() && DstTy->isIntOrIntVectorTy() &&        SrcLength == DstLength && SrcBitSize < DstBitSize;    case Instruction::FPTrunc: @@ -3019,138 +3019,138 @@ TruncInst::TruncInst(  TruncInst::TruncInst(    Value *S, Type *Ty, const Twine &Name, BasicBlock *InsertAtEnd -) : CastInst(Ty, Trunc, S, Name, InsertAtEnd) {  +) : CastInst(Ty, Trunc, S, Name, InsertAtEnd) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal Trunc");  }  ZExtInst::ZExtInst(    Value *S, Type *Ty, const Twine &Name, Instruction *InsertBefore -)  : CastInst(Ty, ZExt, S, Name, InsertBefore) {  +)  : CastInst(Ty, ZExt, S, Name, InsertBefore) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal ZExt");  }  ZExtInst::ZExtInst(    Value *S, Type *Ty, const Twine &Name, BasicBlock *InsertAtEnd -)  : CastInst(Ty, ZExt, S, Name, InsertAtEnd) {  +)  : CastInst(Ty, ZExt, S, Name, InsertAtEnd) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal ZExt");  }  SExtInst::SExtInst(    Value *S, Type *Ty, const Twine &Name, Instruction *InsertBefore -) : CastInst(Ty, SExt, S, Name, InsertBefore) {  +) : CastInst(Ty, SExt, S, Name, InsertBefore) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal SExt");  }  SExtInst::SExtInst(    Value *S, Type *Ty, const Twine &Name, BasicBlock *InsertAtEnd -)  : CastInst(Ty, SExt, S, Name, InsertAtEnd) {  +)  : CastInst(Ty, SExt, S, Name, InsertAtEnd) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal SExt");  }  FPTruncInst::FPTruncInst(    Value *S, Type *Ty, const Twine &Name, Instruction *InsertBefore -) : CastInst(Ty, FPTrunc, S, Name, InsertBefore) {  +) : CastInst(Ty, FPTrunc, S, Name, InsertBefore) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal FPTrunc");  }  FPTruncInst::FPTruncInst(    Value *S, Type *Ty, const Twine &Name, BasicBlock *InsertAtEnd -) : CastInst(Ty, FPTrunc, S, Name, InsertAtEnd) {  +) : CastInst(Ty, FPTrunc, S, Name, InsertAtEnd) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal FPTrunc");  }  FPExtInst::FPExtInst(    Value *S, Type *Ty, const Twine &Name, Instruction *InsertBefore -) : CastInst(Ty, FPExt, S, Name, InsertBefore) {  +) : CastInst(Ty, FPExt, S, Name, InsertBefore) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal FPExt");  }  FPExtInst::FPExtInst(    Value *S, Type *Ty, const Twine &Name, BasicBlock *InsertAtEnd -) : CastInst(Ty, FPExt, S, Name, InsertAtEnd) {  +) : CastInst(Ty, FPExt, S, Name, InsertAtEnd) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal FPExt");  }  UIToFPInst::UIToFPInst(    Value *S, Type *Ty, const Twine &Name, Instruction *InsertBefore -) : CastInst(Ty, UIToFP, S, Name, InsertBefore) {  +) : CastInst(Ty, UIToFP, S, Name, InsertBefore) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal UIToFP");  }  UIToFPInst::UIToFPInst(    Value *S, Type *Ty, const Twine &Name, BasicBlock *InsertAtEnd -) : CastInst(Ty, UIToFP, S, Name, InsertAtEnd) {  +) : CastInst(Ty, UIToFP, S, Name, InsertAtEnd) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal UIToFP");  }  SIToFPInst::SIToFPInst(    Value *S, Type *Ty, const Twine &Name, Instruction *InsertBefore -) : CastInst(Ty, SIToFP, S, Name, InsertBefore) {  +) : CastInst(Ty, SIToFP, S, Name, InsertBefore) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal SIToFP");  }  SIToFPInst::SIToFPInst(    Value *S, Type *Ty, const Twine &Name, BasicBlock *InsertAtEnd -) : CastInst(Ty, SIToFP, S, Name, InsertAtEnd) {  +) : CastInst(Ty, SIToFP, S, Name, InsertAtEnd) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal SIToFP");  }  FPToUIInst::FPToUIInst(    Value *S, Type *Ty, const Twine &Name, Instruction *InsertBefore -) : CastInst(Ty, FPToUI, S, Name, InsertBefore) {  +) : CastInst(Ty, FPToUI, S, Name, InsertBefore) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal FPToUI");  }  FPToUIInst::FPToUIInst(    Value *S, Type *Ty, const Twine &Name, BasicBlock *InsertAtEnd -) : CastInst(Ty, FPToUI, S, Name, InsertAtEnd) {  +) : CastInst(Ty, FPToUI, S, Name, InsertAtEnd) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal FPToUI");  }  FPToSIInst::FPToSIInst(    Value *S, Type *Ty, const Twine &Name, Instruction *InsertBefore -) : CastInst(Ty, FPToSI, S, Name, InsertBefore) {  +) : CastInst(Ty, FPToSI, S, Name, InsertBefore) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal FPToSI");  }  FPToSIInst::FPToSIInst(    Value *S, Type *Ty, const Twine &Name, BasicBlock *InsertAtEnd -) : CastInst(Ty, FPToSI, S, Name, InsertAtEnd) {  +) : CastInst(Ty, FPToSI, S, Name, InsertAtEnd) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal FPToSI");  }  PtrToIntInst::PtrToIntInst(    Value *S, Type *Ty, const Twine &Name, Instruction *InsertBefore -) : CastInst(Ty, PtrToInt, S, Name, InsertBefore) {  +) : CastInst(Ty, PtrToInt, S, Name, InsertBefore) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal PtrToInt");  }  PtrToIntInst::PtrToIntInst(    Value *S, Type *Ty, const Twine &Name, BasicBlock *InsertAtEnd -) : CastInst(Ty, PtrToInt, S, Name, InsertAtEnd) {  +) : CastInst(Ty, PtrToInt, S, Name, InsertAtEnd) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal PtrToInt");  }  IntToPtrInst::IntToPtrInst(    Value *S, Type *Ty, const Twine &Name, Instruction *InsertBefore -) : CastInst(Ty, IntToPtr, S, Name, InsertBefore) {  +) : CastInst(Ty, IntToPtr, S, Name, InsertBefore) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal IntToPtr");  }  IntToPtrInst::IntToPtrInst(    Value *S, Type *Ty, const Twine &Name, BasicBlock *InsertAtEnd -) : CastInst(Ty, IntToPtr, S, Name, InsertAtEnd) {  +) : CastInst(Ty, IntToPtr, S, Name, InsertAtEnd) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal IntToPtr");  }  BitCastInst::BitCastInst(    Value *S, Type *Ty, const Twine &Name, Instruction *InsertBefore -) : CastInst(Ty, BitCast, S, Name, InsertBefore) {  +) : CastInst(Ty, BitCast, S, Name, InsertBefore) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal BitCast");  }  BitCastInst::BitCastInst(    Value *S, Type *Ty, const Twine &Name, BasicBlock *InsertAtEnd -) : CastInst(Ty, BitCast, S, Name, InsertAtEnd) {  +) : CastInst(Ty, BitCast, S, Name, InsertAtEnd) {    assert(castIsValid(getOpcode(), S, Ty) && "Illegal BitCast");  } @@ -3205,7 +3205,7 @@ CmpInst::Create(OtherOps Op, Predicate predicate, Value *S1, Value *S2,        return new ICmpInst(CmpInst::Predicate(predicate),                            S1, S2, Name);    } -   +    if (InsertBefore)      return new FCmpInst(InsertBefore, CmpInst::Predicate(predicate),                          S1, S2, Name); @@ -3312,8 +3312,8 @@ StringRef CmpInst::getPredicateName(Predicate Pred) {  ICmpInst::Predicate ICmpInst::getSignedPredicate(Predicate pred) {    switch (pred) {      default: llvm_unreachable("Unknown icmp predicate!"); -    case ICMP_EQ: case ICMP_NE:  -    case ICMP_SGT: case ICMP_SLT: case ICMP_SGE: case ICMP_SLE:  +    case ICMP_EQ: case ICMP_NE: +    case ICMP_SGT: case ICMP_SLT: case ICMP_SGE: case ICMP_SLE:         return pred;      case ICMP_UGT: return ICMP_SGT;      case ICMP_ULT: return ICMP_SLT; @@ -3325,8 +3325,8 @@ ICmpInst::Predicate ICmpInst::getSignedPredicate(Predicate pred) {  ICmpInst::Predicate ICmpInst::getUnsignedPredicate(Predicate pred) {    switch (pred) {      default: llvm_unreachable("Unknown icmp predicate!"); -    case ICMP_EQ: case ICMP_NE:  -    case ICMP_UGT: case ICMP_ULT: case ICMP_UGE: case ICMP_ULE:  +    case ICMP_EQ: case ICMP_NE: +    case ICMP_UGT: case ICMP_ULT: case ICMP_UGE: case ICMP_ULE:         return pred;      case ICMP_SGT: return ICMP_UGT;      case ICMP_SLT: return ICMP_ULT; @@ -3371,7 +3371,7 @@ CmpInst::Predicate CmpInst::getSwappedPredicate(Predicate pred) {      case ICMP_ULT: return ICMP_UGT;      case ICMP_UGE: return ICMP_ULE;      case ICMP_ULE: return ICMP_UGE; -   +      case FCMP_FALSE: case FCMP_TRUE:      case FCMP_OEQ: case FCMP_ONE:      case FCMP_UEQ: case FCMP_UNE: @@ -3422,7 +3422,7 @@ CmpInst::Predicate CmpInst::getSignedPredicate(Predicate pred) {  bool CmpInst::isUnsigned(Predicate predicate) {    switch (predicate) {      default: return false; -    case ICmpInst::ICMP_ULT: case ICmpInst::ICMP_ULE: case ICmpInst::ICMP_UGT:  +    case ICmpInst::ICMP_ULT: case ICmpInst::ICMP_ULE: case ICmpInst::ICMP_UGT:      case ICmpInst::ICMP_UGE: return true;    }  } @@ -3430,7 +3430,7 @@ bool CmpInst::isUnsigned(Predicate predicate) {  bool CmpInst::isSigned(Predicate predicate) {    switch (predicate) {      default: return false; -    case ICmpInst::ICMP_SLT: case ICmpInst::ICMP_SLE: case ICmpInst::ICMP_SGT:  +    case ICmpInst::ICMP_SLT: case ICmpInst::ICMP_SLE: case ICmpInst::ICMP_SGT:      case ICmpInst::ICMP_SGE: return true;    }  } @@ -3438,17 +3438,17 @@ bool CmpInst::isSigned(Predicate predicate) {  bool CmpInst::isOrdered(Predicate predicate) {    switch (predicate) {      default: return false; -    case FCmpInst::FCMP_OEQ: case FCmpInst::FCMP_ONE: case FCmpInst::FCMP_OGT:  -    case FCmpInst::FCMP_OLT: case FCmpInst::FCMP_OGE: case FCmpInst::FCMP_OLE:  +    case FCmpInst::FCMP_OEQ: case FCmpInst::FCMP_ONE: case FCmpInst::FCMP_OGT: +    case FCmpInst::FCMP_OLT: case FCmpInst::FCMP_OGE: case FCmpInst::FCMP_OLE:      case FCmpInst::FCMP_ORD: return true;    }  } -       +  bool CmpInst::isUnordered(Predicate predicate) {    switch (predicate) {      default: return false; -    case FCmpInst::FCMP_UEQ: case FCmpInst::FCMP_UNE: case FCmpInst::FCMP_UGT:  -    case FCmpInst::FCMP_ULT: case FCmpInst::FCMP_UGE: case FCmpInst::FCMP_ULE:  +    case FCmpInst::FCMP_UEQ: case FCmpInst::FCMP_UNE: case FCmpInst::FCMP_UGT: +    case FCmpInst::FCMP_ULT: case FCmpInst::FCMP_UGE: case FCmpInst::FCMP_ULE:      case FCmpInst::FCMP_UNO: return true;    }  } @@ -3619,7 +3619,7 @@ void IndirectBrInst::init(Value *Address, unsigned NumDests) {  void IndirectBrInst::growOperands() {    unsigned e = getNumOperands();    unsigned NumOps = e*2; -   +    ReservedSpace = NumOps;    growHungoffUses(ReservedSpace);  } @@ -3665,13 +3665,13 @@ void IndirectBrInst::addDestination(BasicBlock *DestBB) {  /// indirectbr instruction.  void IndirectBrInst::removeDestination(unsigned idx) {    assert(idx < getNumOperands()-1 && "Successor index out of range!"); -   +    unsigned NumOps = getNumOperands();    Use *OL = getOperandList();    // Replace this value with the last one.    OL[idx+1] = OL[NumOps-1]; -   +    // Nuke the last value.    OL[NumOps-1].set(nullptr);    setNumHungOffUseOperands(NumOps-1); @@ -3725,7 +3725,7 @@ LoadInst *LoadInst::cloneImpl() const {  StoreInst *StoreInst::cloneImpl() const {    return new StoreInst(getOperand(0), getOperand(1), isVolatile(),                         getAlignment(), getOrdering(), getSyncScopeID()); -   +  }  AtomicCmpXchgInst *AtomicCmpXchgInst::cloneImpl() const {  | 
