diff options
author | Dimitry Andric <dim@FreeBSD.org> | 2018-08-29 17:50:33 +0000 |
---|---|---|
committer | Dimitry Andric <dim@FreeBSD.org> | 2018-08-29 17:50:33 +0000 |
commit | 8568f9cb5af587ccee4088af3e2d617b3c30d403 (patch) | |
tree | 38ef3950af2e183a6c1c23947e35e837fce15a9a /lib/Support | |
parent | d0a9cbdae159210824ddf2da138e2dcaecbe1cd4 (diff) |
Notes
Diffstat (limited to 'lib/Support')
-rw-r--r-- | lib/Support/Path.cpp | 10 | ||||
-rw-r--r-- | lib/Support/Windows/Path.inc | 2 |
2 files changed, 10 insertions, 2 deletions
diff --git a/lib/Support/Path.cpp b/lib/Support/Path.cpp index 098230290ed28..768a819c8d05b 100644 --- a/lib/Support/Path.cpp +++ b/lib/Support/Path.cpp @@ -1150,8 +1150,16 @@ Error TempFile::keep(const Twine &Name) { // If we can't cancel the delete don't rename. auto H = reinterpret_cast<HANDLE>(_get_osfhandle(FD)); std::error_code RenameEC = setDeleteDisposition(H, false); - if (!RenameEC) + if (!RenameEC) { RenameEC = rename_fd(FD, Name); + // If rename failed because it's cross-device, copy instead + if (RenameEC == + std::error_code(ERROR_NOT_SAME_DEVICE, std::system_category())) { + RenameEC = copy_file(TmpName, Name); + setDeleteDisposition(H, true); + } + } + // If we can't rename, discard the temporary file. if (RenameEC) setDeleteDisposition(H, true); diff --git a/lib/Support/Windows/Path.inc b/lib/Support/Windows/Path.inc index b64b013d7407d..f425d607af47f 100644 --- a/lib/Support/Windows/Path.inc +++ b/lib/Support/Windows/Path.inc @@ -450,7 +450,7 @@ static std::error_code rename_handle(HANDLE FromHandle, const Twine &To) { if (std::error_code EC2 = realPathFromHandle(FromHandle, WideFrom)) return EC2; if (::MoveFileExW(WideFrom.begin(), WideTo.begin(), - MOVEFILE_REPLACE_EXISTING | MOVEFILE_COPY_ALLOWED)) + MOVEFILE_REPLACE_EXISTING)) return std::error_code(); return mapWindowsError(GetLastError()); } |