diff options
| author | Don Lewis <truckman@FreeBSD.org> | 2016-05-12 06:39:13 +0000 |
|---|---|---|
| committer | Don Lewis <truckman@FreeBSD.org> | 2016-05-12 06:39:13 +0000 |
| commit | 77b822dbc0f0223e5383b4377e1fa97657997d0d (patch) | |
| tree | baa89926a104467604c5aee607c213a43a13bfc9 /lib/libfetch | |
| parent | 5525a2edd83072e6e886f92e9d8a0bd85cc14330 (diff) | |
| download | src-test-77b822dbc0f0223e5383b4377e1fa97657997d0d.tar.gz src-test-77b822dbc0f0223e5383b4377e1fa97657997d0d.zip | |
Use strlcpy() instead of strncpy() to copy the string returned by
setlocale() so that static analyzers know that the string is NUL
terminated. This was causing a false positive in Coverity even
though the longest string returned by setlocale() is ENCODING_LEN
(31) and we are copying into a 64 byte buffer. This change is also
a bit of an optimization since we don't need the strncpy() feature
of padding the rest of the destination buffer with NUL characters.
Reported by: Coverity
CID: 974654
Notes
Notes:
svn path=/head/; revision=299520
Diffstat (limited to 'lib/libfetch')
| -rw-r--r-- | lib/libfetch/http.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/libfetch/http.c b/lib/libfetch/http.c index ca522a6bcb8c9..f80404d4e0b2d 100644 --- a/lib/libfetch/http.c +++ b/lib/libfetch/http.c @@ -875,7 +875,7 @@ http_parse_mtime(const char *p, time_t *mtime) char locale[64], *r; struct tm tm; - strncpy(locale, setlocale(LC_TIME, NULL), sizeof(locale)); + strlcpy(locale, setlocale(LC_TIME, NULL), sizeof(locale)); setlocale(LC_TIME, "C"); r = strptime(p, "%a, %d %b %Y %H:%M:%S GMT", &tm); /* |