Silence Clang Scan warning about potentially unsafe use of strcpy.

While this is a false positive, the use of strdup() simplifies the code.

MFC after:	2 weeks

1 files changed, 2 insertions, 3 deletions

diff --git a/lib/libfigpar/string_m.c b/lib/libfigpar/string_m.c
index d358e90488d7d..c991aebb4a575 100644
--- a/lib/libfigpar/string_m.c
+++ b/lib/libfigpar/string_m.c
@@ -119,10 +119,9 @@ replaceall(char *source, const char *find, const char *replace)
 
 	/* If replace is longer than find, we'll need to create a temp copy */
 	if (rlen > flen) {
-		temp = malloc(slen + 1);
-		if (errno != 0) /* could not allocate memory */
+		temp = strdup(source);
+		if (temp == NULL) /* could not allocate memory */
 			return (-1);
-		strcpy(temp, source);
 	} else
 		temp = source;