diff options
| author | Pedro F. Giffuni <pfg@FreeBSD.org> | 2018-01-27 22:57:01 +0000 |
|---|---|---|
| committer | Pedro F. Giffuni <pfg@FreeBSD.org> | 2018-01-27 22:57:01 +0000 |
| commit | e2d84d5adc77c22e473264072798e8c0356ef6f5 (patch) | |
| tree | 8e9a0a0a55d1b02dce204117900c7c5fd87fcf13 /sbin/pfctl | |
| parent | 90b809116a510d7455a111d852e17bffb3bfba66 (diff) | |
| download | src-test-e2d84d5adc77c22e473264072798e8c0356ef6f5.tar.gz src-test-e2d84d5adc77c22e473264072798e8c0356ef6f5.zip | |
pfctl(8): Fix two wrong conditions.
Caught by gcc80's -Wtautological-compare option.
MFC after: 5 days
Approved by: kp
Obtained from: DragonFlyBSD (git e3cdbf6c)
Differential Revision: https://reviews.freebsd.org/D14083
Notes
Notes:
svn path=/head/; revision=328497
Diffstat (limited to 'sbin/pfctl')
| -rw-r--r-- | sbin/pfctl/pfctl_optimize.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sbin/pfctl/pfctl_optimize.c b/sbin/pfctl/pfctl_optimize.c index 37b36f5f01260..7d4381d39524c 100644 --- a/sbin/pfctl/pfctl_optimize.c +++ b/sbin/pfctl/pfctl_optimize.c @@ -1092,7 +1092,7 @@ skip_cmp_dst_addr(struct pf_rule *a, struct pf_rule *b) return (0); case PF_ADDR_DYNIFTL: if (strcmp(a->dst.addr.v.ifname, b->dst.addr.v.ifname) != 0 || - a->dst.addr.iflags != a->dst.addr.iflags || + a->dst.addr.iflags != b->dst.addr.iflags || memcmp(&a->dst.addr.v.a.mask, &b->dst.addr.v.a.mask, sizeof(a->dst.addr.v.a.mask))) return (1); @@ -1164,7 +1164,7 @@ skip_cmp_src_addr(struct pf_rule *a, struct pf_rule *b) return (0); case PF_ADDR_DYNIFTL: if (strcmp(a->src.addr.v.ifname, b->src.addr.v.ifname) != 0 || - a->src.addr.iflags != a->src.addr.iflags || + a->src.addr.iflags != b->src.addr.iflags || memcmp(&a->src.addr.v.a.mask, &b->src.addr.v.a.mask, sizeof(a->src.addr.v.a.mask))) return (1); |