diff options
author | Dimitry Andric <dim@FreeBSD.org> | 2019-08-20 17:59:23 +0000 |
---|---|---|
committer | Dimitry Andric <dim@FreeBSD.org> | 2019-08-20 17:59:23 +0000 |
commit | 9a83721404652cea39e9f02ae3e3b5c964602a5c (patch) | |
tree | 23e9541ce27049a103f6ed046be61592123e02c9 /unittests/Format | |
parent | 676fbe8105eeb6ff4bb2ed261cb212fcfdbe7b63 (diff) |
Notes
Diffstat (limited to 'unittests/Format')
-rw-r--r-- | unittests/Format/CMakeLists.txt | 31 | ||||
-rw-r--r-- | unittests/Format/CleanupTest.cpp | 503 | ||||
-rw-r--r-- | unittests/Format/FormatTest.cpp | 12812 | ||||
-rw-r--r-- | unittests/Format/FormatTestComments.cpp | 3216 | ||||
-rw-r--r-- | unittests/Format/FormatTestJS.cpp | 2333 | ||||
-rw-r--r-- | unittests/Format/FormatTestJava.cpp | 583 | ||||
-rw-r--r-- | unittests/Format/FormatTestObjC.cpp | 1320 | ||||
-rw-r--r-- | unittests/Format/FormatTestProto.cpp | 653 | ||||
-rw-r--r-- | unittests/Format/FormatTestRawStrings.cpp | 987 | ||||
-rw-r--r-- | unittests/Format/FormatTestSelective.cpp | 609 | ||||
-rw-r--r-- | unittests/Format/FormatTestTableGen.cpp | 56 | ||||
-rw-r--r-- | unittests/Format/FormatTestTextProto.cpp | 739 | ||||
-rw-r--r-- | unittests/Format/FormatTestUtils.h | 68 | ||||
-rw-r--r-- | unittests/Format/NamespaceEndCommentsFixerTest.cpp | 786 | ||||
-rw-r--r-- | unittests/Format/SortImportsTestJS.cpp | 313 | ||||
-rw-r--r-- | unittests/Format/SortImportsTestJava.cpp | 267 | ||||
-rw-r--r-- | unittests/Format/SortIncludesTest.cpp | 596 | ||||
-rw-r--r-- | unittests/Format/UsingDeclarationsSorterTest.cpp | 375 |
18 files changed, 0 insertions, 26247 deletions
diff --git a/unittests/Format/CMakeLists.txt b/unittests/Format/CMakeLists.txt deleted file mode 100644 index 015c25ee6b96f..0000000000000 --- a/unittests/Format/CMakeLists.txt +++ /dev/null @@ -1,31 +0,0 @@ -set(LLVM_LINK_COMPONENTS - Support - ) - -add_clang_unittest(FormatTests - CleanupTest.cpp - FormatTest.cpp - FormatTestComments.cpp - FormatTestJS.cpp - FormatTestJava.cpp - FormatTestObjC.cpp - FormatTestProto.cpp - FormatTestRawStrings.cpp - FormatTestSelective.cpp - FormatTestTableGen.cpp - FormatTestTextProto.cpp - NamespaceEndCommentsFixerTest.cpp - SortImportsTestJS.cpp - SortImportsTestJava.cpp - SortIncludesTest.cpp - UsingDeclarationsSorterTest.cpp - ) - -target_link_libraries(FormatTests - PRIVATE - clangBasic - clangFormat - clangFrontend - clangRewrite - clangToolingCore - ) diff --git a/unittests/Format/CleanupTest.cpp b/unittests/Format/CleanupTest.cpp deleted file mode 100644 index f4a36d8e1f717..0000000000000 --- a/unittests/Format/CleanupTest.cpp +++ /dev/null @@ -1,503 +0,0 @@ -//===- unittest/Format/CleanupTest.cpp - Code cleanup unit tests ----------===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "clang/Format/Format.h" - -#include "../Tooling/ReplacementTest.h" -#include "../Tooling/RewriterTestContext.h" -#include "clang/Tooling/Core/Replacement.h" - -#include "gtest/gtest.h" - -using clang::tooling::ReplacementTest; -using clang::tooling::toReplacements; - -namespace clang { -namespace format { -namespace { - -class CleanupTest : public ::testing::Test { -protected: - std::string cleanup(llvm::StringRef Code, - const std::vector<tooling::Range> &Ranges, - const FormatStyle &Style = getLLVMStyle()) { - tooling::Replacements Replaces = format::cleanup(Style, Code, Ranges); - - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - return *Result; - } - - // Returns code after cleanup around \p Offsets. - std::string cleanupAroundOffsets(llvm::ArrayRef<unsigned> Offsets, - llvm::StringRef Code, - const FormatStyle &Style = getLLVMStyle()) { - std::vector<tooling::Range> Ranges; - for (auto Offset : Offsets) - Ranges.push_back(tooling::Range(Offset, 0)); - return cleanup(Code, Ranges, Style); - } -}; - -TEST_F(CleanupTest, DeleteEmptyNamespaces) { - std::string Code = "namespace A {\n" - "namespace B {\n" - "} // namespace B\n" - "} // namespace A\n\n" - "namespace C {\n" - "namespace D { int i; }\n" - "inline namespace E { namespace { } }\n" - "}"; - std::string Expected = "\n\n\n\n\nnamespace C {\n" - "namespace D { int i; }\n \n" - "}"; - EXPECT_EQ(Expected, cleanupAroundOffsets({28, 91, 132}, Code)); -} - -TEST_F(CleanupTest, NamespaceWithSyntaxError) { - std::string Code = "namespace A {\n" - "namespace B {\n" // missing r_brace - "} // namespace A\n\n" - "namespace C {\n" - "namespace D int i; }\n" - "inline namespace E { namespace { } }\n" - "}"; - std::string Expected = "namespace A {\n" - "\n\n\nnamespace C {\n" - "namespace D int i; }\n \n" - "}"; - std::vector<tooling::Range> Ranges(1, tooling::Range(0, Code.size())); - EXPECT_EQ(Expected, cleanup(Code, Ranges)); -} - -TEST_F(CleanupTest, EmptyNamespaceNotAffected) { - std::string Code = "namespace A {\n\n" - "namespace {\n\n}}"; - // Even though the namespaces are empty, but the inner most empty namespace - // block is not affected by the changed ranges. - std::string Expected = "namespace A {\n\n" - "namespace {\n\n}}"; - // Set the changed range to be the second "\n". - EXPECT_EQ(Expected, cleanupAroundOffsets({14}, Code)); -} - -TEST_F(CleanupTest, EmptyNamespaceWithCommentsNoBreakBeforeBrace) { - std::string Code = "namespace A {\n" - "namespace B {\n" - "// Yo\n" - "} // namespace B\n" - "} // namespace A\n" - "namespace C { // Yo\n" - "}"; - std::string Expected = "\n\n\n\n\n\n"; - std::vector<tooling::Range> Ranges(1, tooling::Range(0, Code.size())); - std::string Result = cleanup(Code, Ranges); - EXPECT_EQ(Expected, Result); -} - -TEST_F(CleanupTest, EmptyNamespaceWithCommentsBreakBeforeBrace) { - std::string Code = "namespace A\n" - "/* Yo */ {\n" - "namespace B\n" - "{\n" - "// Yo\n" - "} // namespace B\n" - "} // namespace A\n" - "namespace C\n" - "{ // Yo\n" - "}\n"; - std::string Expected = "\n\n\n\n\n\n\n\n\n\n"; - std::vector<tooling::Range> Ranges(1, tooling::Range(0, Code.size())); - FormatStyle Style = getLLVMStyle(); - Style.BraceWrapping.AfterNamespace = true; - std::string Result = cleanup(Code, Ranges, Style); - EXPECT_EQ(Expected, Result); -} - -TEST_F(CleanupTest, EmptyNamespaceAroundConditionalCompilation) { - std::string Code = "#ifdef A\n" - "int a;\n" - "int b;\n" - "#else\n" - "#endif\n" - "namespace {}"; - std::string Expected = "#ifdef A\n" - "int a;\n" - "int b;\n" - "#else\n" - "#endif\n"; - std::vector<tooling::Range> Ranges(1, tooling::Range(0, Code.size())); - FormatStyle Style = getLLVMStyle(); - std::string Result = cleanup(Code, Ranges, Style); - EXPECT_EQ(Expected, Result); -} - -TEST_F(CleanupTest, CtorInitializationSimpleRedundantComma) { - std::string Code = "class A {\nA() : , {} };"; - std::string Expected = "class A {\nA() {} };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({17, 19}, Code)); - - Code = "class A {\nA() : x(1), {} };"; - Expected = "class A {\nA() : x(1) {} };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({23}, Code)); - - Code = "class A {\nA() :,,,,{} };"; - Expected = "class A {\nA() {} };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({15}, Code)); -} - -TEST_F(CleanupTest, CtorInitializationSimpleRedundantColon) { - std::string Code = "class A {\nA() : =default; };"; - std::string Expected = "class A {\nA() =default; };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({15}, Code)); - - Code = "class A {\nA() : , =default; };"; - Expected = "class A {\nA() =default; };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({15}, Code)); -} - -TEST_F(CleanupTest, ListRedundantComma) { - std::string Code = "void f() { std::vector<int> v = {1,2,,,3,{4,5}}; }"; - std::string Expected = "void f() { std::vector<int> v = {1,2,3,{4,5}}; }"; - EXPECT_EQ(Expected, cleanupAroundOffsets({40}, Code)); - - Code = "int main() { f(1,,2,3,,4);}"; - Expected = "int main() { f(1,2,3,4);}"; - EXPECT_EQ(Expected, cleanupAroundOffsets({17, 22}, Code)); -} - -TEST_F(CleanupTest, NoCleanupsForJavaScript) { - std::string Code = "function f() { var x = [a, b, , c]; }"; - std::string Expected = "function f() { var x = [a, b, , c]; }"; - const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript); - - EXPECT_EQ(Expected, cleanupAroundOffsets({30}, Code, Style)); -} - -TEST_F(CleanupTest, TrailingCommaInParens) { - std::string Code = "int main() { f(,1,,2,3,f(1,2,),4,,);}"; - std::string Expected = "int main() { f(1,2,3,f(1,2),4);}"; - EXPECT_EQ(Expected, cleanupAroundOffsets({15, 18, 29, 33}, Code)); -} - -TEST_F(CleanupTest, TrailingCommaInBraces) { - // Trainling comma is allowed in brace list. - // If there was trailing comma in the original code, then trailing comma is - // preserved. In this example, element between the last two commas is deleted - // causing the second-last comma to be redundant. - std::string Code = "void f() { std::vector<int> v = {1,2,3,,}; }"; - std::string Expected = "void f() { std::vector<int> v = {1,2,3,}; }"; - EXPECT_EQ(Expected, cleanupAroundOffsets({39}, Code)); - - // If there was no trailing comma in the original code, then trainling comma - // introduced by replacements should be cleaned up. In this example, the - // element after the last comma is deleted causing the last comma to be - // redundant. - Code = "void f() { std::vector<int> v = {1,2,3,}; }"; - // FIXME: redundant trailing comma should be removed. - Expected = "void f() { std::vector<int> v = {1,2,3,}; }"; - EXPECT_EQ(Expected, cleanupAroundOffsets({39}, Code)); - - // Still no trailing comma in the original code, but two elements are deleted, - // which makes it seems like there was trailing comma. - Code = "void f() { std::vector<int> v = {1, 2, 3, , }; }"; - // FIXME: redundant trailing comma should also be removed. - Expected = "void f() { std::vector<int> v = {1, 2, 3, }; }"; - EXPECT_EQ(Expected, cleanupAroundOffsets({42, 44}, Code)); -} - -TEST_F(CleanupTest, CtorInitializationBracesInParens) { - std::string Code = "class A {\nA() : x({1}),, {} };"; - std::string Expected = "class A {\nA() : x({1}) {} };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({24, 26}, Code)); -} - -TEST_F(CleanupTest, RedundantCommaNotInAffectedRanges) { - std::string Code = - "class A {\nA() : x({1}), /* comment */, { int x = 0; } };"; - std::string Expected = - "class A {\nA() : x({1}), /* comment */, { int x = 0; } };"; - // Set the affected range to be "int x = 0", which does not intercept the - // constructor initialization list. - std::vector<tooling::Range> Ranges(1, tooling::Range(42, 9)); - std::string Result = cleanup(Code, Ranges); - EXPECT_EQ(Expected, Result); - - Code = "class A {\nA() : x(1), {} };"; - Expected = "class A {\nA() : x(1), {} };"; - // No range. Fixer should do nothing. - Ranges.clear(); - Result = cleanup(Code, Ranges); - EXPECT_EQ(Expected, Result); -} - -TEST_F(CleanupTest, RemoveCommentsAroundDeleteCode) { - std::string Code = - "class A {\nA() : x({1}), /* comment */, /* comment */ {} };"; - std::string Expected = "class A {\nA() : x({1}) {} };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({25, 40}, Code)); - - Code = "class A {\nA() : x({1}), // comment\n {} };"; - Expected = "class A {\nA() : x({1})\n {} };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({25}, Code)); - - Code = "class A {\nA() : x({1}), // comment\n , y(1),{} };"; - Expected = "class A {\nA() : x({1}), y(1){} };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({38}, Code)); - - Code = "class A {\nA() : x({1}), \n/* comment */, y(1),{} };"; - Expected = "class A {\nA() : x({1}), \n y(1){} };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({40}, Code)); - - Code = "class A {\nA() : , // comment\n y(1),{} };"; - Expected = "class A {\nA() : // comment\n y(1){} };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({17}, Code)); - - Code = "class A {\nA() // comment\n : ,,{} };"; - Expected = "class A {\nA() // comment\n {} };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({30}, Code)); - - Code = "class A {\nA() // comment\n : ,,=default; };"; - Expected = "class A {\nA() // comment\n =default; };"; - EXPECT_EQ(Expected, cleanupAroundOffsets({30}, Code)); -} - -TEST_F(CleanupTest, CtorInitializerInNamespace) { - std::string Code = "namespace A {\n" - "namespace B {\n" // missing r_brace - "} // namespace A\n\n" - "namespace C {\n" - "class A { A() : x(0),, {} };\n" - "inline namespace E { namespace { } }\n" - "}"; - std::string Expected = "namespace A {\n" - "\n\n\nnamespace C {\n" - "class A { A() : x(0) {} };\n \n" - "}"; - std::vector<tooling::Range> Ranges(1, tooling::Range(0, Code.size())); - std::string Result = cleanup(Code, Ranges); - EXPECT_EQ(Expected, Result); -} - -class CleanUpReplacementsTest : public ReplacementTest { -protected: - tooling::Replacement createReplacement(unsigned Offset, unsigned Length, - StringRef Text) { - return tooling::Replacement(FileName, Offset, Length, Text); - } - - tooling::Replacement createInsertion(StringRef IncludeDirective) { - return createReplacement(UINT_MAX, 0, IncludeDirective); - } - - tooling::Replacement createDeletion(StringRef HeaderName) { - return createReplacement(UINT_MAX, 1, HeaderName); - } - - inline std::string apply(StringRef Code, - const tooling::Replacements &Replaces) { - auto CleanReplaces = cleanupAroundReplacements(Code, Replaces, Style); - EXPECT_TRUE(static_cast<bool>(CleanReplaces)) - << llvm::toString(CleanReplaces.takeError()) << "\n"; - auto Result = applyAllReplacements(Code, *CleanReplaces); - EXPECT_TRUE(static_cast<bool>(Result)); - return *Result; - } - - inline std::string formatAndApply(StringRef Code, - const tooling::Replacements &Replaces) { - auto CleanReplaces = cleanupAroundReplacements(Code, Replaces, Style); - EXPECT_TRUE(static_cast<bool>(CleanReplaces)) - << llvm::toString(CleanReplaces.takeError()) << "\n"; - auto FormattedReplaces = formatReplacements(Code, *CleanReplaces, Style); - EXPECT_TRUE(static_cast<bool>(FormattedReplaces)) - << llvm::toString(FormattedReplaces.takeError()) << "\n"; - auto Result = applyAllReplacements(Code, *FormattedReplaces); - EXPECT_TRUE(static_cast<bool>(Result)); - return *Result; - } - - int getOffset(StringRef Code, int Line, int Column) { - RewriterTestContext Context; - FileID ID = Context.createInMemoryFile(FileName, Code); - auto DecomposedLocation = - Context.Sources.getDecomposedLoc(Context.getLocation(ID, Line, Column)); - return DecomposedLocation.second; - } - - const std::string FileName = "fix.cpp"; - FormatStyle Style = getLLVMStyle(); -}; - -TEST_F(CleanUpReplacementsTest, FixOnlyAffectedCodeAfterReplacements) { - std::string Code = "namespace A {\n" - "namespace B {\n" - " int x;\n" - "} // namespace B\n" - "} // namespace A\n" - "\n" - "namespace C {\n" - "namespace D { int i; }\n" - "inline namespace E { namespace { int y; } }\n" - "int x= 0;" - "}"; - std::string Expected = "\n\nnamespace C {\n" - "namespace D { int i; }\n\n" - "int x= 0;" - "}"; - tooling::Replacements Replaces = - toReplacements({createReplacement(getOffset(Code, 3, 3), 6, ""), - createReplacement(getOffset(Code, 9, 34), 6, "")}); - - EXPECT_EQ(Expected, formatAndApply(Code, Replaces)); -} - -TEST_F(CleanUpReplacementsTest, InsertMultipleIncludesLLVMStyle) { - std::string Code = "#include \"x/fix.h\"\n" - "#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"z.h\"\n" - "#include \"clang/Format/Format.h\"\n" - "#include <memory>\n"; - std::string Expected = "#include \"x/fix.h\"\n" - "#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"new/new.h\"\n" - "#include \"z.h\"\n" - "#include \"clang/Format/Format.h\"\n" - "#include <list>\n" - "#include <memory>\n"; - tooling::Replacements Replaces = - toReplacements({createInsertion("#include <list>"), - createInsertion("#include \"new/new.h\"")}); - EXPECT_EQ(Expected, apply(Code, Replaces)); -} - -TEST_F(CleanUpReplacementsTest, InsertMultipleIncludesGoogleStyle) { - std::string Code = "#include \"x/fix.h\"\n" - "\n" - "#include <vector>\n" - "\n" - "#include \"y/a.h\"\n" - "#include \"z/b.h\"\n"; - std::string Expected = "#include \"x/fix.h\"\n" - "\n" - "#include <list>\n" - "#include <vector>\n" - "\n" - "#include \"x/x.h\"\n" - "#include \"y/a.h\"\n" - "#include \"z/b.h\"\n"; - tooling::Replacements Replaces = - toReplacements({createInsertion("#include <list>"), - createInsertion("#include \"x/x.h\"")}); - Style = format::getGoogleStyle(format::FormatStyle::LanguageKind::LK_Cpp); - EXPECT_EQ(Expected, apply(Code, Replaces)); -} - -TEST_F(CleanUpReplacementsTest, InsertMultipleNewHeadersAndSortLLVM) { - std::string Code = "\nint x;"; - std::string Expected = "\n#include \"fix.h\"\n" - "#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n" - "#include <list>\n" - "#include <vector>\n" - "int x;"; - tooling::Replacements Replaces = toReplacements( - {createInsertion("#include \"a.h\""), createInsertion("#include \"c.h\""), - createInsertion("#include \"b.h\""), - createInsertion("#include <vector>"), createInsertion("#include <list>"), - createInsertion("#include \"fix.h\"")}); - EXPECT_EQ(Expected, formatAndApply(Code, Replaces)); -} - -TEST_F(CleanUpReplacementsTest, InsertMultipleNewHeadersAndSortGoogle) { - std::string Code = "\nint x;"; - std::string Expected = "\n#include \"fix.h\"\n" - "#include <list>\n" - "#include <vector>\n" - "#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n" - "int x;"; - tooling::Replacements Replaces = toReplacements( - {createInsertion("#include \"a.h\""), createInsertion("#include \"c.h\""), - createInsertion("#include \"b.h\""), - createInsertion("#include <vector>"), createInsertion("#include <list>"), - createInsertion("#include \"fix.h\"")}); - Style = format::getGoogleStyle(format::FormatStyle::LanguageKind::LK_Cpp); - EXPECT_EQ(Expected, formatAndApply(Code, Replaces)); -} - -TEST_F(CleanUpReplacementsTest, NoNewLineAtTheEndOfCodeMultipleInsertions) { - std::string Code = "#include <map>"; - // FIXME: a better behavior is to only append on newline to Code, but this - // case should be rare in practice. - std::string Expected = - "#include <map>\n#include <string>\n\n#include <vector>\n"; - tooling::Replacements Replaces = - toReplacements({createInsertion("#include <string>"), - createInsertion("#include <vector>")}); - EXPECT_EQ(Expected, apply(Code, Replaces)); -} - - -TEST_F(CleanUpReplacementsTest, FormatCorrectLineWhenHeadersAreInserted) { - std::string Code = "\n" - "int x;\n" - "int a;\n" - "int a;\n" - "int a;"; - - std::string Expected = "\n#include \"x.h\"\n" - "#include \"y.h\"\n" - "#include \"clang/x/x.h\"\n" - "#include <list>\n" - "#include <vector>\n" - "int x;\n" - "int a;\n" - "int b;\n" - "int a;"; - tooling::Replacements Replaces = toReplacements( - {createReplacement(getOffset(Code, 4, 8), 1, "b"), - createInsertion("#include <vector>"), createInsertion("#include <list>"), - createInsertion("#include \"clang/x/x.h\""), - createInsertion("#include \"y.h\""), - createInsertion("#include \"x.h\"")}); - EXPECT_EQ(Expected, formatAndApply(Code, Replaces)); -} - -TEST_F(CleanUpReplacementsTest, SimpleDeleteIncludes) { - std::string Code = "#include \"abc.h\"\n" - "#include \"xyz.h\" // comment\n" - "#include \"xyz\"\n" - "int x;\n"; - std::string Expected = "#include \"xyz\"\n" - "int x;\n"; - tooling::Replacements Replaces = - toReplacements({createDeletion("abc.h"), createDeletion("xyz.h")}); - EXPECT_EQ(Expected, apply(Code, Replaces)); -} - -TEST_F(CleanUpReplacementsTest, InsertionAndDeleteHeader) { - std::string Code = "#include \"a.h\"\n" - "\n" - "#include <vector>\n"; - std::string Expected = "#include \"a.h\"\n" - "\n" - "#include <map>\n"; - tooling::Replacements Replaces = toReplacements( - {createDeletion("<vector>"), createInsertion("#include <map>")}); - EXPECT_EQ(Expected, apply(Code, Replaces)); -} - -} // end namespace -} // end namespace format -} // end namespace clang diff --git a/unittests/Format/FormatTest.cpp b/unittests/Format/FormatTest.cpp deleted file mode 100644 index c05fceb4766c6..0000000000000 --- a/unittests/Format/FormatTest.cpp +++ /dev/null @@ -1,12812 +0,0 @@ -//===- unittest/Format/FormatTest.cpp - Formatting unit tests -------------===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "clang/Format/Format.h" - -#include "../Tooling/ReplacementTest.h" -#include "FormatTestUtils.h" - -#include "clang/Frontend/TextDiagnosticPrinter.h" -#include "llvm/Support/Debug.h" -#include "llvm/Support/MemoryBuffer.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -using clang::tooling::ReplacementTest; -using clang::tooling::toReplacements; - -namespace clang { -namespace format { -namespace { - -FormatStyle getGoogleStyle() { return getGoogleStyle(FormatStyle::LK_Cpp); } - -class FormatTest : public ::testing::Test { -protected: - enum StatusCheck { - SC_ExpectComplete, - SC_ExpectIncomplete, - SC_DoNotCheck - }; - - std::string format(llvm::StringRef Code, - const FormatStyle &Style = getLLVMStyle(), - StatusCheck CheckComplete = SC_ExpectComplete) { - LLVM_DEBUG(llvm::errs() << "---\n"); - LLVM_DEBUG(llvm::errs() << Code << "\n\n"); - std::vector<tooling::Range> Ranges(1, tooling::Range(0, Code.size())); - FormattingAttemptStatus Status; - tooling::Replacements Replaces = - reformat(Style, Code, Ranges, "<stdin>", &Status); - if (CheckComplete != SC_DoNotCheck) { - bool ExpectedCompleteFormat = CheckComplete == SC_ExpectComplete; - EXPECT_EQ(ExpectedCompleteFormat, Status.FormatComplete) - << Code << "\n\n"; - } - ReplacementCount = Replaces.size(); - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); - return *Result; - } - - FormatStyle getStyleWithColumns(FormatStyle Style, unsigned ColumnLimit) { - Style.ColumnLimit = ColumnLimit; - return Style; - } - - FormatStyle getLLVMStyleWithColumns(unsigned ColumnLimit) { - return getStyleWithColumns(getLLVMStyle(), ColumnLimit); - } - - FormatStyle getGoogleStyleWithColumns(unsigned ColumnLimit) { - return getStyleWithColumns(getGoogleStyle(), ColumnLimit); - } - - void verifyFormat(llvm::StringRef Expected, llvm::StringRef Code, - const FormatStyle &Style = getLLVMStyle()) { - EXPECT_EQ(Expected.str(), format(Expected, Style)) - << "Expected code is not stable"; - EXPECT_EQ(Expected.str(), format(Code, Style)); - if (Style.Language == FormatStyle::LK_Cpp) { - // Objective-C++ is a superset of C++, so everything checked for C++ - // needs to be checked for Objective-C++ as well. - FormatStyle ObjCStyle = Style; - ObjCStyle.Language = FormatStyle::LK_ObjC; - EXPECT_EQ(Expected.str(), format(test::messUp(Code), ObjCStyle)); - } - } - - void verifyFormat(llvm::StringRef Code, - const FormatStyle &Style = getLLVMStyle()) { - verifyFormat(Code, test::messUp(Code), Style); - } - - void verifyIncompleteFormat(llvm::StringRef Code, - const FormatStyle &Style = getLLVMStyle()) { - EXPECT_EQ(Code.str(), - format(test::messUp(Code), Style, SC_ExpectIncomplete)); - } - - void verifyGoogleFormat(llvm::StringRef Code) { - verifyFormat(Code, getGoogleStyle()); - } - - void verifyIndependentOfContext(llvm::StringRef text) { - verifyFormat(text); - verifyFormat(llvm::Twine("void f() { " + text + " }").str()); - } - - /// \brief Verify that clang-format does not crash on the given input. - void verifyNoCrash(llvm::StringRef Code, - const FormatStyle &Style = getLLVMStyle()) { - format(Code, Style, SC_DoNotCheck); - } - - int ReplacementCount; -}; - -TEST_F(FormatTest, MessUp) { - EXPECT_EQ("1 2 3", test::messUp("1 2 3")); - EXPECT_EQ("1 2 3\n", test::messUp("1\n2\n3\n")); - EXPECT_EQ("a\n//b\nc", test::messUp("a\n//b\nc")); - EXPECT_EQ("a\n#b\nc", test::messUp("a\n#b\nc")); - EXPECT_EQ("a\n#b c d\ne", test::messUp("a\n#b\\\nc\\\nd\ne")); -} - -//===----------------------------------------------------------------------===// -// Basic function tests. -//===----------------------------------------------------------------------===// - -TEST_F(FormatTest, DoesNotChangeCorrectlyFormattedCode) { - EXPECT_EQ(";", format(";")); -} - -TEST_F(FormatTest, FormatsGlobalStatementsAt0) { - EXPECT_EQ("int i;", format(" int i;")); - EXPECT_EQ("\nint i;", format(" \n\t \v \f int i;")); - EXPECT_EQ("int i;\nint j;", format(" int i; int j;")); - EXPECT_EQ("int i;\nint j;", format(" int i;\n int j;")); -} - -TEST_F(FormatTest, FormatsUnwrappedLinesAtFirstFormat) { - EXPECT_EQ("int i;", format("int\ni;")); -} - -TEST_F(FormatTest, FormatsNestedBlockStatements) { - EXPECT_EQ("{\n {\n {}\n }\n}", format("{{{}}}")); -} - -TEST_F(FormatTest, FormatsNestedCall) { - verifyFormat("Method(f1, f2(f3));"); - verifyFormat("Method(f1(f2, f3()));"); - verifyFormat("Method(f1(f2, (f3())));"); -} - -TEST_F(FormatTest, NestedNameSpecifiers) { - verifyFormat("vector<::Type> v;"); - verifyFormat("::ns::SomeFunction(::ns::SomeOtherFunction())"); - verifyFormat("static constexpr bool Bar = decltype(bar())::value;"); - verifyFormat("bool a = 2 < ::SomeFunction();"); - verifyFormat("ALWAYS_INLINE ::std::string getName();"); - verifyFormat("some::string getName();"); -} - -TEST_F(FormatTest, OnlyGeneratesNecessaryReplacements) { - EXPECT_EQ("if (a) {\n" - " f();\n" - "}", - format("if(a){f();}")); - EXPECT_EQ(4, ReplacementCount); - EXPECT_EQ("if (a) {\n" - " f();\n" - "}", - format("if (a) {\n" - " f();\n" - "}")); - EXPECT_EQ(0, ReplacementCount); - EXPECT_EQ("/*\r\n" - "\r\n" - "*/\r\n", - format("/*\r\n" - "\r\n" - "*/\r\n")); - EXPECT_EQ(0, ReplacementCount); -} - -TEST_F(FormatTest, RemovesEmptyLines) { - EXPECT_EQ("class C {\n" - " int i;\n" - "};", - format("class C {\n" - " int i;\n" - "\n" - "};")); - - // Don't remove empty lines at the start of namespaces or extern "C" blocks. - EXPECT_EQ("namespace N {\n" - "\n" - "int i;\n" - "}", - format("namespace N {\n" - "\n" - "int i;\n" - "}", - getGoogleStyle())); - EXPECT_EQ("/* something */ namespace N {\n" - "\n" - "int i;\n" - "}", - format("/* something */ namespace N {\n" - "\n" - "int i;\n" - "}", - getGoogleStyle())); - EXPECT_EQ("inline namespace N {\n" - "\n" - "int i;\n" - "}", - format("inline namespace N {\n" - "\n" - "int i;\n" - "}", - getGoogleStyle())); - EXPECT_EQ("/* something */ inline namespace N {\n" - "\n" - "int i;\n" - "}", - format("/* something */ inline namespace N {\n" - "\n" - "int i;\n" - "}", - getGoogleStyle())); - EXPECT_EQ("export namespace N {\n" - "\n" - "int i;\n" - "}", - format("export namespace N {\n" - "\n" - "int i;\n" - "}", - getGoogleStyle())); - EXPECT_EQ("extern /**/ \"C\" /**/ {\n" - "\n" - "int i;\n" - "}", - format("extern /**/ \"C\" /**/ {\n" - "\n" - "int i;\n" - "}", - getGoogleStyle())); - - // ...but do keep inlining and removing empty lines for non-block extern "C" - // functions. - verifyFormat("extern \"C\" int f() { return 42; }", getGoogleStyle()); - EXPECT_EQ("extern \"C\" int f() {\n" - " int i = 42;\n" - " return i;\n" - "}", - format("extern \"C\" int f() {\n" - "\n" - " int i = 42;\n" - " return i;\n" - "}", - getGoogleStyle())); - - // Remove empty lines at the beginning and end of blocks. - EXPECT_EQ("void f() {\n" - "\n" - " if (a) {\n" - "\n" - " f();\n" - " }\n" - "}", - format("void f() {\n" - "\n" - " if (a) {\n" - "\n" - " f();\n" - "\n" - " }\n" - "\n" - "}", - getLLVMStyle())); - EXPECT_EQ("void f() {\n" - " if (a) {\n" - " f();\n" - " }\n" - "}", - format("void f() {\n" - "\n" - " if (a) {\n" - "\n" - " f();\n" - "\n" - " }\n" - "\n" - "}", - getGoogleStyle())); - - // Don't remove empty lines in more complex control statements. - EXPECT_EQ("void f() {\n" - " if (a) {\n" - " f();\n" - "\n" - " } else if (b) {\n" - " f();\n" - " }\n" - "}", - format("void f() {\n" - " if (a) {\n" - " f();\n" - "\n" - " } else if (b) {\n" - " f();\n" - "\n" - " }\n" - "\n" - "}")); - - // Don't remove empty lines before namespace endings. - FormatStyle LLVMWithNoNamespaceFix = getLLVMStyle(); - LLVMWithNoNamespaceFix.FixNamespaceComments = false; - EXPECT_EQ("namespace {\n" - "int i;\n" - "\n" - "}", - format("namespace {\n" - "int i;\n" - "\n" - "}", LLVMWithNoNamespaceFix)); - EXPECT_EQ("namespace {\n" - "int i;\n" - "}", - format("namespace {\n" - "int i;\n" - "}", LLVMWithNoNamespaceFix)); - EXPECT_EQ("namespace {\n" - "int i;\n" - "\n" - "};", - format("namespace {\n" - "int i;\n" - "\n" - "};", LLVMWithNoNamespaceFix)); - EXPECT_EQ("namespace {\n" - "int i;\n" - "};", - format("namespace {\n" - "int i;\n" - "};", LLVMWithNoNamespaceFix)); - EXPECT_EQ("namespace {\n" - "int i;\n" - "\n" - "}", - format("namespace {\n" - "int i;\n" - "\n" - "}")); - EXPECT_EQ("namespace {\n" - "int i;\n" - "\n" - "} // namespace", - format("namespace {\n" - "int i;\n" - "\n" - "} // namespace")); - - FormatStyle Style = getLLVMStyle(); - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All; - Style.MaxEmptyLinesToKeep = 2; - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterClass = true; - Style.BraceWrapping.AfterFunction = true; - Style.KeepEmptyLinesAtTheStartOfBlocks = false; - - EXPECT_EQ("class Foo\n" - "{\n" - " Foo() {}\n" - "\n" - " void funk() {}\n" - "};", - format("class Foo\n" - "{\n" - " Foo()\n" - " {\n" - " }\n" - "\n" - " void funk() {}\n" - "};", - Style)); -} - -TEST_F(FormatTest, RecognizesBinaryOperatorKeywords) { - verifyFormat("x = (a) and (b);"); - verifyFormat("x = (a) or (b);"); - verifyFormat("x = (a) bitand (b);"); - verifyFormat("x = (a) bitor (b);"); - verifyFormat("x = (a) not_eq (b);"); - verifyFormat("x = (a) and_eq (b);"); - verifyFormat("x = (a) or_eq (b);"); - verifyFormat("x = (a) xor (b);"); -} - -TEST_F(FormatTest, RecognizesUnaryOperatorKeywords) { - verifyFormat("x = compl(a);"); - verifyFormat("x = not(a);"); - verifyFormat("x = bitand(a);"); - // Unary operator must not be merged with the next identifier - verifyFormat("x = compl a;"); - verifyFormat("x = not a;"); - verifyFormat("x = bitand a;"); -} - -//===----------------------------------------------------------------------===// -// Tests for control statements. -//===----------------------------------------------------------------------===// - -TEST_F(FormatTest, FormatIfWithoutCompoundStatement) { - verifyFormat("if (true)\n f();\ng();"); - verifyFormat("if (a)\n if (b)\n if (c)\n g();\nh();"); - verifyFormat("if (a)\n if (b) {\n f();\n }\ng();"); - verifyFormat("if constexpr (true)\n" - " f();\ng();"); - verifyFormat("if constexpr (a)\n" - " if constexpr (b)\n" - " if constexpr (c)\n" - " g();\n" - "h();"); - verifyFormat("if constexpr (a)\n" - " if constexpr (b) {\n" - " f();\n" - " }\n" - "g();"); - - FormatStyle AllowsMergedIf = getLLVMStyle(); - AllowsMergedIf.AlignEscapedNewlines = FormatStyle::ENAS_Left; - AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true; - verifyFormat("if (a)\n" - " // comment\n" - " f();", - AllowsMergedIf); - verifyFormat("{\n" - " if (a)\n" - " label:\n" - " f();\n" - "}", - AllowsMergedIf); - verifyFormat("#define A \\\n" - " if (a) \\\n" - " label: \\\n" - " f()", - AllowsMergedIf); - verifyFormat("if (a)\n" - " ;", - AllowsMergedIf); - verifyFormat("if (a)\n" - " if (b) return;", - AllowsMergedIf); - - verifyFormat("if (a) // Can't merge this\n" - " f();\n", - AllowsMergedIf); - verifyFormat("if (a) /* still don't merge */\n" - " f();", - AllowsMergedIf); - verifyFormat("if (a) { // Never merge this\n" - " f();\n" - "}", - AllowsMergedIf); - verifyFormat("if (a) { /* Never merge this */\n" - " f();\n" - "}", - AllowsMergedIf); - - AllowsMergedIf.ColumnLimit = 14; - verifyFormat("if (a) return;", AllowsMergedIf); - verifyFormat("if (aaaaaaaaa)\n" - " return;", - AllowsMergedIf); - - AllowsMergedIf.ColumnLimit = 13; - verifyFormat("if (a)\n return;", AllowsMergedIf); -} - -TEST_F(FormatTest, FormatLoopsWithoutCompoundStatement) { - FormatStyle AllowsMergedLoops = getLLVMStyle(); - AllowsMergedLoops.AllowShortLoopsOnASingleLine = true; - verifyFormat("while (true) continue;", AllowsMergedLoops); - verifyFormat("for (;;) continue;", AllowsMergedLoops); - verifyFormat("for (int &v : vec) v *= 2;", AllowsMergedLoops); - verifyFormat("while (true)\n" - " ;", - AllowsMergedLoops); - verifyFormat("for (;;)\n" - " ;", - AllowsMergedLoops); - verifyFormat("for (;;)\n" - " for (;;) continue;", - AllowsMergedLoops); - verifyFormat("for (;;) // Can't merge this\n" - " continue;", - AllowsMergedLoops); - verifyFormat("for (;;) /* still don't merge */\n" - " continue;", - AllowsMergedLoops); -} - -TEST_F(FormatTest, FormatShortBracedStatements) { - FormatStyle AllowSimpleBracedStatements = getLLVMStyle(); - AllowSimpleBracedStatements.ColumnLimit = 40; - AllowSimpleBracedStatements.AllowShortBlocksOnASingleLine = true; - - AllowSimpleBracedStatements.AllowShortIfStatementsOnASingleLine = true; - AllowSimpleBracedStatements.AllowShortLoopsOnASingleLine = true; - - AllowSimpleBracedStatements.BreakBeforeBraces = FormatStyle::BS_Custom; - AllowSimpleBracedStatements.BraceWrapping.AfterFunction = true; - AllowSimpleBracedStatements.BraceWrapping.SplitEmptyRecord = false; - - verifyFormat("if (true) {}", AllowSimpleBracedStatements); - verifyFormat("if constexpr (true) {}", AllowSimpleBracedStatements); - verifyFormat("while (true) {}", AllowSimpleBracedStatements); - verifyFormat("for (;;) {}", AllowSimpleBracedStatements); - verifyFormat("if (true) { f(); }", AllowSimpleBracedStatements); - verifyFormat("if constexpr (true) { f(); }", AllowSimpleBracedStatements); - verifyFormat("while (true) { f(); }", AllowSimpleBracedStatements); - verifyFormat("for (;;) { f(); }", AllowSimpleBracedStatements); - verifyFormat("if (true) {\n" - " ffffffffffffffffffffffffffffffffffffffffffffffffffffff();\n" - "}", - AllowSimpleBracedStatements); - verifyFormat("if (true) { //\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - verifyFormat("if (true) {\n" - " f();\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - verifyFormat("if (true) {\n" - " f();\n" - "} else {\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - - verifyFormat("struct A2 {\n" - " int X;\n" - "};", - AllowSimpleBracedStatements); - verifyFormat("typedef struct A2 {\n" - " int X;\n" - "} A2_t;", - AllowSimpleBracedStatements); - verifyFormat("template <int> struct A2 {\n" - " struct B {};\n" - "};", - AllowSimpleBracedStatements); - - AllowSimpleBracedStatements.AllowShortIfStatementsOnASingleLine = false; - verifyFormat("if (true) {}", AllowSimpleBracedStatements); - verifyFormat("if (true) {\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - verifyFormat("if (true) {\n" - " f();\n" - "} else {\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - - AllowSimpleBracedStatements.AllowShortLoopsOnASingleLine = false; - verifyFormat("while (true) {}", AllowSimpleBracedStatements); - verifyFormat("while (true) {\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - verifyFormat("for (;;) {}", AllowSimpleBracedStatements); - verifyFormat("for (;;) {\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - - AllowSimpleBracedStatements.AllowShortIfStatementsOnASingleLine = true; - AllowSimpleBracedStatements.AllowShortLoopsOnASingleLine = true; - AllowSimpleBracedStatements.BraceWrapping.AfterControlStatement = true; - - verifyFormat("if (true) {}", AllowSimpleBracedStatements); - verifyFormat("if constexpr (true) {}", AllowSimpleBracedStatements); - verifyFormat("while (true) {}", AllowSimpleBracedStatements); - verifyFormat("for (;;) {}", AllowSimpleBracedStatements); - verifyFormat("if (true) { f(); }", AllowSimpleBracedStatements); - verifyFormat("if constexpr (true) { f(); }", AllowSimpleBracedStatements); - verifyFormat("while (true) { f(); }", AllowSimpleBracedStatements); - verifyFormat("for (;;) { f(); }", AllowSimpleBracedStatements); - verifyFormat("if (true)\n" - "{\n" - " ffffffffffffffffffffffffffffffffffffffffffffffffffffff();\n" - "}", - AllowSimpleBracedStatements); - verifyFormat("if (true)\n" - "{ //\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - verifyFormat("if (true)\n" - "{\n" - " f();\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - verifyFormat("if (true)\n" - "{\n" - " f();\n" - "} else\n" - "{\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - - AllowSimpleBracedStatements.AllowShortIfStatementsOnASingleLine = false; - verifyFormat("if (true) {}", AllowSimpleBracedStatements); - verifyFormat("if (true)\n" - "{\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - verifyFormat("if (true)\n" - "{\n" - " f();\n" - "} else\n" - "{\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - - AllowSimpleBracedStatements.AllowShortLoopsOnASingleLine = false; - verifyFormat("while (true) {}", AllowSimpleBracedStatements); - verifyFormat("while (true)\n" - "{\n" - " f();\n" - "}", - AllowSimpleBracedStatements); - verifyFormat("for (;;) {}", AllowSimpleBracedStatements); - verifyFormat("for (;;)\n" - "{\n" - " f();\n" - "}", - AllowSimpleBracedStatements); -} - -TEST_F(FormatTest, ShortBlocksInMacrosDontMergeWithCodeAfterMacro) { - FormatStyle Style = getLLVMStyleWithColumns(60); - Style.AllowShortBlocksOnASingleLine = true; - Style.AllowShortIfStatementsOnASingleLine = true; - Style.BreakBeforeBraces = FormatStyle::BS_Allman; - EXPECT_EQ("#define A \\\n" - " if (HANDLEwernufrnuLwrmviferuvnierv) \\\n" - " { RET_ERR1_ANUIREUINERUIFNIOAerwfwrvnuier; }\n" - "X;", - format("#define A \\\n" - " if (HANDLEwernufrnuLwrmviferuvnierv) { \\\n" - " RET_ERR1_ANUIREUINERUIFNIOAerwfwrvnuier; \\\n" - " }\n" - "X;", - Style)); -} - -TEST_F(FormatTest, ParseIfElse) { - verifyFormat("if (true)\n" - " if (true)\n" - " if (true)\n" - " f();\n" - " else\n" - " g();\n" - " else\n" - " h();\n" - "else\n" - " i();"); - verifyFormat("if (true)\n" - " if (true)\n" - " if (true) {\n" - " if (true)\n" - " f();\n" - " } else {\n" - " g();\n" - " }\n" - " else\n" - " h();\n" - "else {\n" - " i();\n" - "}"); - verifyFormat("if (true)\n" - " if constexpr (true)\n" - " if (true) {\n" - " if constexpr (true)\n" - " f();\n" - " } else {\n" - " g();\n" - " }\n" - " else\n" - " h();\n" - "else {\n" - " i();\n" - "}"); - verifyFormat("void f() {\n" - " if (a) {\n" - " } else {\n" - " }\n" - "}"); -} - -TEST_F(FormatTest, ElseIf) { - verifyFormat("if (a) {\n} else if (b) {\n}"); - verifyFormat("if (a)\n" - " f();\n" - "else if (b)\n" - " g();\n" - "else\n" - " h();"); - verifyFormat("if constexpr (a)\n" - " f();\n" - "else if constexpr (b)\n" - " g();\n" - "else\n" - " h();"); - verifyFormat("if (a) {\n" - " f();\n" - "}\n" - "// or else ..\n" - "else {\n" - " g()\n" - "}"); - - verifyFormat("if (a) {\n" - "} else if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa)) {\n" - "}"); - verifyFormat("if (a) {\n" - "} else if (\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" - "}", - getLLVMStyleWithColumns(62)); - verifyFormat("if (a) {\n" - "} else if constexpr (\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" - "}", - getLLVMStyleWithColumns(62)); -} - -TEST_F(FormatTest, FormatsForLoop) { - verifyFormat( - "for (int VeryVeryLongLoopVariable = 0; VeryVeryLongLoopVariable < 10;\n" - " ++VeryVeryLongLoopVariable)\n" - " ;"); - verifyFormat("for (;;)\n" - " f();"); - verifyFormat("for (;;) {\n}"); - verifyFormat("for (;;) {\n" - " f();\n" - "}"); - verifyFormat("for (int i = 0; (i < 10); ++i) {\n}"); - - verifyFormat( - "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n" - " E = UnwrappedLines.end();\n" - " I != E; ++I) {\n}"); - - verifyFormat( - "for (MachineFun::iterator IIII = PrevIt, EEEE = F.end(); IIII != EEEE;\n" - " ++IIIII) {\n}"); - verifyFormat("for (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaa =\n" - " aaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa;\n" - " aaaaaaaaaaa != aaaaaaaaaaaaaaaaaaa; ++aaaaaaaaaaa) {\n}"); - verifyFormat("for (llvm::ArrayRef<NamedDecl *>::iterator\n" - " I = FD->getDeclsInPrototypeScope().begin(),\n" - " E = FD->getDeclsInPrototypeScope().end();\n" - " I != E; ++I) {\n}"); - verifyFormat("for (SmallVectorImpl<TemplateIdAnnotationn *>::iterator\n" - " I = Container.begin(),\n" - " E = Container.end();\n" - " I != E; ++I) {\n}", - getLLVMStyleWithColumns(76)); - - verifyFormat( - "for (aaaaaaaaaaaaaaaaa aaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa !=\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" - " ++aaaaaaaaaaa) {\n}"); - verifyFormat("for (int i = 0; i < aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" - " bbbbbbbbbbbbbbbbbbbb < ccccccccccccccc;\n" - " ++i) {\n}"); - verifyFormat("for (int aaaaaaaaaaa = 1; aaaaaaaaaaa <= bbbbbbbbbbbbbbb;\n" - " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n" - "}"); - verifyFormat("for (some_namespace::SomeIterator iter( // force break\n" - " aaaaaaaaaa);\n" - " iter; ++iter) {\n" - "}"); - verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa != bbbbbbbbbbbbbbbbbbbbbbb;\n" - " ++aaaaaaaaaaaaaaaaaaaaaaaaaaa) {"); - - // These should not be formatted as Objective-C for-in loops. - verifyFormat("for (Foo *x = 0; x != in; x++) {\n}"); - verifyFormat("Foo *x;\nfor (x = 0; x != in; x++) {\n}"); - verifyFormat("Foo *x;\nfor (x in y) {\n}"); - verifyFormat("for (const Foo<Bar> &baz = in.value(); !baz.at_end(); ++baz) {\n}"); - - FormatStyle NoBinPacking = getLLVMStyle(); - NoBinPacking.BinPackParameters = false; - verifyFormat("for (int aaaaaaaaaaa = 1;\n" - " aaaaaaaaaaa <= aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaa);\n" - " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n" - "}", - NoBinPacking); - verifyFormat( - "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n" - " E = UnwrappedLines.end();\n" - " I != E;\n" - " ++I) {\n}", - NoBinPacking); - - FormatStyle AlignLeft = getLLVMStyle(); - AlignLeft.PointerAlignment = FormatStyle::PAS_Left; - verifyFormat("for (A* a = start; a < end; ++a, ++value) {\n}", AlignLeft); -} - -TEST_F(FormatTest, RangeBasedForLoops) { - verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); - verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaa :\n" - " aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa, aaaaaaaaaaaaa)) {\n}"); - verifyFormat("for (const aaaaaaaaaaaaaaaaaaaaa &aaaaaaaaa :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); - verifyFormat("for (aaaaaaaaa aaaaaaaaaaaaaaaaaaaaa :\n" - " aaaaaaaaaaaa.aaaaaaaaaaaa().aaaaaaaaa().a()) {\n}"); -} - -TEST_F(FormatTest, ForEachLoops) { - verifyFormat("void f() {\n" - " foreach (Item *item, itemlist) {}\n" - " Q_FOREACH (Item *item, itemlist) {}\n" - " BOOST_FOREACH (Item *item, itemlist) {}\n" - " UNKNOWN_FORACH(Item * item, itemlist) {}\n" - "}"); - - // As function-like macros. - verifyFormat("#define foreach(x, y)\n" - "#define Q_FOREACH(x, y)\n" - "#define BOOST_FOREACH(x, y)\n" - "#define UNKNOWN_FOREACH(x, y)\n"); - - // Not as function-like macros. - verifyFormat("#define foreach (x, y)\n" - "#define Q_FOREACH (x, y)\n" - "#define BOOST_FOREACH (x, y)\n" - "#define UNKNOWN_FOREACH (x, y)\n"); -} - -TEST_F(FormatTest, FormatsWhileLoop) { - verifyFormat("while (true) {\n}"); - verifyFormat("while (true)\n" - " f();"); - verifyFormat("while () {\n}"); - verifyFormat("while () {\n" - " f();\n" - "}"); -} - -TEST_F(FormatTest, FormatsDoWhile) { - verifyFormat("do {\n" - " do_something();\n" - "} while (something());"); - verifyFormat("do\n" - " do_something();\n" - "while (something());"); -} - -TEST_F(FormatTest, FormatsSwitchStatement) { - verifyFormat("switch (x) {\n" - "case 1:\n" - " f();\n" - " break;\n" - "case kFoo:\n" - "case ns::kBar:\n" - "case kBaz:\n" - " break;\n" - "default:\n" - " g();\n" - " break;\n" - "}"); - verifyFormat("switch (x) {\n" - "case 1: {\n" - " f();\n" - " break;\n" - "}\n" - "case 2: {\n" - " break;\n" - "}\n" - "}"); - verifyFormat("switch (x) {\n" - "case 1: {\n" - " f();\n" - " {\n" - " g();\n" - " h();\n" - " }\n" - " break;\n" - "}\n" - "}"); - verifyFormat("switch (x) {\n" - "case 1: {\n" - " f();\n" - " if (foo) {\n" - " g();\n" - " h();\n" - " }\n" - " break;\n" - "}\n" - "}"); - verifyFormat("switch (x) {\n" - "case 1: {\n" - " f();\n" - " g();\n" - "} break;\n" - "}"); - verifyFormat("switch (test)\n" - " ;"); - verifyFormat("switch (x) {\n" - "default: {\n" - " // Do nothing.\n" - "}\n" - "}"); - verifyFormat("switch (x) {\n" - "// comment\n" - "// if 1, do f()\n" - "case 1:\n" - " f();\n" - "}"); - verifyFormat("switch (x) {\n" - "case 1:\n" - " // Do amazing stuff\n" - " {\n" - " f();\n" - " g();\n" - " }\n" - " break;\n" - "}"); - verifyFormat("#define A \\\n" - " switch (x) { \\\n" - " case a: \\\n" - " foo = b; \\\n" - " }", - getLLVMStyleWithColumns(20)); - verifyFormat("#define OPERATION_CASE(name) \\\n" - " case OP_name: \\\n" - " return operations::Operation##name\n", - getLLVMStyleWithColumns(40)); - verifyFormat("switch (x) {\n" - "case 1:;\n" - "default:;\n" - " int i;\n" - "}"); - - verifyGoogleFormat("switch (x) {\n" - " case 1:\n" - " f();\n" - " break;\n" - " case kFoo:\n" - " case ns::kBar:\n" - " case kBaz:\n" - " break;\n" - " default:\n" - " g();\n" - " break;\n" - "}"); - verifyGoogleFormat("switch (x) {\n" - " case 1: {\n" - " f();\n" - " break;\n" - " }\n" - "}"); - verifyGoogleFormat("switch (test)\n" - " ;"); - - verifyGoogleFormat("#define OPERATION_CASE(name) \\\n" - " case OP_name: \\\n" - " return operations::Operation##name\n"); - verifyGoogleFormat("Operation codeToOperation(OperationCode OpCode) {\n" - " // Get the correction operation class.\n" - " switch (OpCode) {\n" - " CASE(Add);\n" - " CASE(Subtract);\n" - " default:\n" - " return operations::Unknown;\n" - " }\n" - "#undef OPERATION_CASE\n" - "}"); - verifyFormat("DEBUG({\n" - " switch (x) {\n" - " case A:\n" - " f();\n" - " break;\n" - " // fallthrough\n" - " case B:\n" - " g();\n" - " break;\n" - " }\n" - "});"); - EXPECT_EQ("DEBUG({\n" - " switch (x) {\n" - " case A:\n" - " f();\n" - " break;\n" - " // On B:\n" - " case B:\n" - " g();\n" - " break;\n" - " }\n" - "});", - format("DEBUG({\n" - " switch (x) {\n" - " case A:\n" - " f();\n" - " break;\n" - " // On B:\n" - " case B:\n" - " g();\n" - " break;\n" - " }\n" - "});", - getLLVMStyle())); - EXPECT_EQ("switch (n) {\n" - "case 0: {\n" - " return false;\n" - "}\n" - "default: {\n" - " return true;\n" - "}\n" - "}", - format("switch (n)\n" - "{\n" - "case 0: {\n" - " return false;\n" - "}\n" - "default: {\n" - " return true;\n" - "}\n" - "}", - getLLVMStyle())); - verifyFormat("switch (a) {\n" - "case (b):\n" - " return;\n" - "}"); - - verifyFormat("switch (a) {\n" - "case some_namespace::\n" - " some_constant:\n" - " return;\n" - "}", - getLLVMStyleWithColumns(34)); - - FormatStyle Style = getLLVMStyle(); - Style.IndentCaseLabels = true; - Style.AllowShortBlocksOnASingleLine = false; - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterControlStatement = true; - EXPECT_EQ("switch (n)\n" - "{\n" - " case 0:\n" - " {\n" - " return false;\n" - " }\n" - " default:\n" - " {\n" - " return true;\n" - " }\n" - "}", - format("switch (n) {\n" - " case 0: {\n" - " return false;\n" - " }\n" - " default: {\n" - " return true;\n" - " }\n" - "}", - Style)); -} - -TEST_F(FormatTest, CaseRanges) { - verifyFormat("switch (x) {\n" - "case 'A' ... 'Z':\n" - "case 1 ... 5:\n" - "case a ... b:\n" - " break;\n" - "}"); -} - -TEST_F(FormatTest, ShortCaseLabels) { - FormatStyle Style = getLLVMStyle(); - Style.AllowShortCaseLabelsOnASingleLine = true; - verifyFormat("switch (a) {\n" - "case 1: x = 1; break;\n" - "case 2: return;\n" - "case 3:\n" - "case 4:\n" - "case 5: return;\n" - "case 6: // comment\n" - " return;\n" - "case 7:\n" - " // comment\n" - " return;\n" - "case 8:\n" - " x = 8; // comment\n" - " break;\n" - "default: y = 1; break;\n" - "}", - Style); - verifyFormat("switch (a) {\n" - "case 0: return; // comment\n" - "case 1: break; // comment\n" - "case 2: return;\n" - "// comment\n" - "case 3: return;\n" - "// comment 1\n" - "// comment 2\n" - "// comment 3\n" - "case 4: break; /* comment */\n" - "case 5:\n" - " // comment\n" - " break;\n" - "case 6: /* comment */ x = 1; break;\n" - "case 7: x = /* comment */ 1; break;\n" - "case 8:\n" - " x = 1; /* comment */\n" - " break;\n" - "case 9:\n" - " break; // comment line 1\n" - " // comment line 2\n" - "}", - Style); - EXPECT_EQ("switch (a) {\n" - "case 1:\n" - " x = 8;\n" - " // fall through\n" - "case 2: x = 8;\n" - "// comment\n" - "case 3:\n" - " return; /* comment line 1\n" - " * comment line 2 */\n" - "case 4: i = 8;\n" - "// something else\n" - "#if FOO\n" - "case 5: break;\n" - "#endif\n" - "}", - format("switch (a) {\n" - "case 1: x = 8;\n" - " // fall through\n" - "case 2:\n" - " x = 8;\n" - "// comment\n" - "case 3:\n" - " return; /* comment line 1\n" - " * comment line 2 */\n" - "case 4:\n" - " i = 8;\n" - "// something else\n" - "#if FOO\n" - "case 5: break;\n" - "#endif\n" - "}", - Style)); - EXPECT_EQ("switch (a) {\n" "case 0:\n" - " return; // long long long long long long long long long long long long comment\n" - " // line\n" "}", - format("switch (a) {\n" - "case 0: return; // long long long long long long long long long long long long comment line\n" - "}", - Style)); - EXPECT_EQ("switch (a) {\n" - "case 0:\n" - " return; /* long long long long long long long long long long long long comment\n" - " line */\n" - "}", - format("switch (a) {\n" - "case 0: return; /* long long long long long long long long long long long long comment line */\n" - "}", - Style)); - verifyFormat("switch (a) {\n" - "#if FOO\n" - "case 0: return 0;\n" - "#endif\n" - "}", - Style); - verifyFormat("switch (a) {\n" - "case 1: {\n" - "}\n" - "case 2: {\n" - " return;\n" - "}\n" - "case 3: {\n" - " x = 1;\n" - " return;\n" - "}\n" - "case 4:\n" - " if (x)\n" - " return;\n" - "}", - Style); - Style.ColumnLimit = 21; - verifyFormat("switch (a) {\n" - "case 1: x = 1; break;\n" - "case 2: return;\n" - "case 3:\n" - "case 4:\n" - "case 5: return;\n" - "default:\n" - " y = 1;\n" - " break;\n" - "}", - Style); - Style.ColumnLimit = 80; - Style.AllowShortCaseLabelsOnASingleLine = false; - Style.IndentCaseLabels = true; - EXPECT_EQ("switch (n) {\n" - " default /*comments*/:\n" - " return true;\n" - " case 0:\n" - " return false;\n" - "}", - format("switch (n) {\n" - "default/*comments*/:\n" - " return true;\n" - "case 0:\n" - " return false;\n" - "}", - Style)); - Style.AllowShortCaseLabelsOnASingleLine = true; - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterControlStatement = true; - EXPECT_EQ("switch (n)\n" - "{\n" - " case 0:\n" - " {\n" - " return false;\n" - " }\n" - " default:\n" - " {\n" - " return true;\n" - " }\n" - "}", - format("switch (n) {\n" - " case 0: {\n" - " return false;\n" - " }\n" - " default:\n" - " {\n" - " return true;\n" - " }\n" - "}", - Style)); -} - -TEST_F(FormatTest, FormatsLabels) { - verifyFormat("void f() {\n" - " some_code();\n" - "test_label:\n" - " some_other_code();\n" - " {\n" - " some_more_code();\n" - " another_label:\n" - " some_more_code();\n" - " }\n" - "}"); - verifyFormat("{\n" - " some_code();\n" - "test_label:\n" - " some_other_code();\n" - "}"); - verifyFormat("{\n" - " some_code();\n" - "test_label:;\n" - " int i = 0;\n" - "}"); -} - -//===----------------------------------------------------------------------===// -// Tests for classes, namespaces, etc. -//===----------------------------------------------------------------------===// - -TEST_F(FormatTest, DoesNotBreakSemiAfterClassDecl) { - verifyFormat("class A {};"); -} - -TEST_F(FormatTest, UnderstandsAccessSpecifiers) { - verifyFormat("class A {\n" - "public:\n" - "public: // comment\n" - "protected:\n" - "private:\n" - " void f() {}\n" - "};"); - verifyFormat("export class A {\n" - "public:\n" - "public: // comment\n" - "protected:\n" - "private:\n" - " void f() {}\n" - "};"); - verifyGoogleFormat("class A {\n" - " public:\n" - " protected:\n" - " private:\n" - " void f() {}\n" - "};"); - verifyGoogleFormat("export class A {\n" - " public:\n" - " protected:\n" - " private:\n" - " void f() {}\n" - "};"); - verifyFormat("class A {\n" - "public slots:\n" - " void f1() {}\n" - "public Q_SLOTS:\n" - " void f2() {}\n" - "protected slots:\n" - " void f3() {}\n" - "protected Q_SLOTS:\n" - " void f4() {}\n" - "private slots:\n" - " void f5() {}\n" - "private Q_SLOTS:\n" - " void f6() {}\n" - "signals:\n" - " void g1();\n" - "Q_SIGNALS:\n" - " void g2();\n" - "};"); - - // Don't interpret 'signals' the wrong way. - verifyFormat("signals.set();"); - verifyFormat("for (Signals signals : f()) {\n}"); - verifyFormat("{\n" - " signals.set(); // This needs indentation.\n" - "}"); - verifyFormat("void f() {\n" - "label:\n" - " signals.baz();\n" - "}"); -} - -TEST_F(FormatTest, SeparatesLogicalBlocks) { - EXPECT_EQ("class A {\n" - "public:\n" - " void f();\n" - "\n" - "private:\n" - " void g() {}\n" - " // test\n" - "protected:\n" - " int h;\n" - "};", - format("class A {\n" - "public:\n" - "void f();\n" - "private:\n" - "void g() {}\n" - "// test\n" - "protected:\n" - "int h;\n" - "};")); - EXPECT_EQ("class A {\n" - "protected:\n" - "public:\n" - " void f();\n" - "};", - format("class A {\n" - "protected:\n" - "\n" - "public:\n" - "\n" - " void f();\n" - "};")); - - // Even ensure proper spacing inside macros. - EXPECT_EQ("#define B \\\n" - " class A { \\\n" - " protected: \\\n" - " public: \\\n" - " void f(); \\\n" - " };", - format("#define B \\\n" - " class A { \\\n" - " protected: \\\n" - " \\\n" - " public: \\\n" - " \\\n" - " void f(); \\\n" - " };", - getGoogleStyle())); - // But don't remove empty lines after macros ending in access specifiers. - EXPECT_EQ("#define A private:\n" - "\n" - "int i;", - format("#define A private:\n" - "\n" - "int i;")); -} - -TEST_F(FormatTest, FormatsClasses) { - verifyFormat("class A : public B {};"); - verifyFormat("class A : public ::B {};"); - - verifyFormat( - "class AAAAAAAAAAAAAAAAAAAA : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" - " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {};"); - verifyFormat("class AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\n" - " : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" - " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {};"); - verifyFormat( - "class A : public B, public C, public D, public E, public F {};"); - verifyFormat("class AAAAAAAAAAAA : public B,\n" - " public C,\n" - " public D,\n" - " public E,\n" - " public F,\n" - " public G {};"); - - verifyFormat("class\n" - " ReallyReallyLongClassName {\n" - " int i;\n" - "};", - getLLVMStyleWithColumns(32)); - verifyFormat("struct aaaaaaaaaaaaa : public aaaaaaaaaaaaaaaaaaa< // break\n" - " aaaaaaaaaaaaaaaa> {};"); - verifyFormat("struct aaaaaaaaaaaaaaaaaaaa\n" - " : public aaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaa> {};"); - verifyFormat("template <class R, class C>\n" - "struct Aaaaaaaaaaaaaaaaa<R (C::*)(int) const>\n" - " : Aaaaaaaaaaaaaaaaa<R (C::*)(int)> {};"); - verifyFormat("class ::A::B {};"); -} - -TEST_F(FormatTest, BreakInheritanceStyle) { - FormatStyle StyleWithInheritanceBreakBeforeComma = getLLVMStyle(); - StyleWithInheritanceBreakBeforeComma.BreakInheritanceList = - FormatStyle::BILS_BeforeComma; - verifyFormat("class MyClass : public X {};", - StyleWithInheritanceBreakBeforeComma); - verifyFormat("class MyClass\n" - " : public X\n" - " , public Y {};", - StyleWithInheritanceBreakBeforeComma); - verifyFormat("class AAAAAAAAAAAAAAAAAAAAAA\n" - " : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB\n" - " , public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {};", - StyleWithInheritanceBreakBeforeComma); - verifyFormat("struct aaaaaaaaaaaaa\n" - " : public aaaaaaaaaaaaaaaaaaa< // break\n" - " aaaaaaaaaaaaaaaa> {};", - StyleWithInheritanceBreakBeforeComma); - - FormatStyle StyleWithInheritanceBreakAfterColon = getLLVMStyle(); - StyleWithInheritanceBreakAfterColon.BreakInheritanceList = - FormatStyle::BILS_AfterColon; - verifyFormat("class MyClass : public X {};", - StyleWithInheritanceBreakAfterColon); - verifyFormat("class MyClass : public X, public Y {};", - StyleWithInheritanceBreakAfterColon); - verifyFormat("class AAAAAAAAAAAAAAAAAAAAAA :\n" - " public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" - " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {};", - StyleWithInheritanceBreakAfterColon); - verifyFormat("struct aaaaaaaaaaaaa :\n" - " public aaaaaaaaaaaaaaaaaaa< // break\n" - " aaaaaaaaaaaaaaaa> {};", - StyleWithInheritanceBreakAfterColon); -} - -TEST_F(FormatTest, FormatsVariableDeclarationsAfterStructOrClass) { - verifyFormat("class A {\n} a, b;"); - verifyFormat("struct A {\n} a, b;"); - verifyFormat("union A {\n} a;"); -} - -TEST_F(FormatTest, FormatsEnum) { - verifyFormat("enum {\n" - " Zero,\n" - " One = 1,\n" - " Two = One + 1,\n" - " Three = (One + Two),\n" - " Four = (Zero && (One ^ Two)) | (One << Two),\n" - " Five = (One, Two, Three, Four, 5)\n" - "};"); - verifyGoogleFormat("enum {\n" - " Zero,\n" - " One = 1,\n" - " Two = One + 1,\n" - " Three = (One + Two),\n" - " Four = (Zero && (One ^ Two)) | (One << Two),\n" - " Five = (One, Two, Three, Four, 5)\n" - "};"); - verifyFormat("enum Enum {};"); - verifyFormat("enum {};"); - verifyFormat("enum X E {} d;"); - verifyFormat("enum __attribute__((...)) E {} d;"); - verifyFormat("enum __declspec__((...)) E {} d;"); - verifyFormat("enum {\n" - " Bar = Foo<int, int>::value\n" - "};", - getLLVMStyleWithColumns(30)); - - verifyFormat("enum ShortEnum { A, B, C };"); - verifyGoogleFormat("enum ShortEnum { A, B, C };"); - - EXPECT_EQ("enum KeepEmptyLines {\n" - " ONE,\n" - "\n" - " TWO,\n" - "\n" - " THREE\n" - "}", - format("enum KeepEmptyLines {\n" - " ONE,\n" - "\n" - " TWO,\n" - "\n" - "\n" - " THREE\n" - "}")); - verifyFormat("enum E { // comment\n" - " ONE,\n" - " TWO\n" - "};\n" - "int i;"); - // Not enums. - verifyFormat("enum X f() {\n" - " a();\n" - " return 42;\n" - "}"); - verifyFormat("enum X Type::f() {\n" - " a();\n" - " return 42;\n" - "}"); - verifyFormat("enum ::X f() {\n" - " a();\n" - " return 42;\n" - "}"); - verifyFormat("enum ns::X f() {\n" - " a();\n" - " return 42;\n" - "}"); -} - -TEST_F(FormatTest, FormatsEnumsWithErrors) { - verifyFormat("enum Type {\n" - " One = 0; // These semicolons should be commas.\n" - " Two = 1;\n" - "};"); - verifyFormat("namespace n {\n" - "enum Type {\n" - " One,\n" - " Two, // missing };\n" - " int i;\n" - "}\n" - "void g() {}"); -} - -TEST_F(FormatTest, FormatsEnumStruct) { - verifyFormat("enum struct {\n" - " Zero,\n" - " One = 1,\n" - " Two = One + 1,\n" - " Three = (One + Two),\n" - " Four = (Zero && (One ^ Two)) | (One << Two),\n" - " Five = (One, Two, Three, Four, 5)\n" - "};"); - verifyFormat("enum struct Enum {};"); - verifyFormat("enum struct {};"); - verifyFormat("enum struct X E {} d;"); - verifyFormat("enum struct __attribute__((...)) E {} d;"); - verifyFormat("enum struct __declspec__((...)) E {} d;"); - verifyFormat("enum struct X f() {\n a();\n return 42;\n}"); -} - -TEST_F(FormatTest, FormatsEnumClass) { - verifyFormat("enum class {\n" - " Zero,\n" - " One = 1,\n" - " Two = One + 1,\n" - " Three = (One + Two),\n" - " Four = (Zero && (One ^ Two)) | (One << Two),\n" - " Five = (One, Two, Three, Four, 5)\n" - "};"); - verifyFormat("enum class Enum {};"); - verifyFormat("enum class {};"); - verifyFormat("enum class X E {} d;"); - verifyFormat("enum class __attribute__((...)) E {} d;"); - verifyFormat("enum class __declspec__((...)) E {} d;"); - verifyFormat("enum class X f() {\n a();\n return 42;\n}"); -} - -TEST_F(FormatTest, FormatsEnumTypes) { - verifyFormat("enum X : int {\n" - " A, // Force multiple lines.\n" - " B\n" - "};"); - verifyFormat("enum X : int { A, B };"); - verifyFormat("enum X : std::uint32_t { A, B };"); -} - -TEST_F(FormatTest, FormatsTypedefEnum) { - FormatStyle Style = getLLVMStyle(); - Style.ColumnLimit = 40; - verifyFormat("typedef enum {} EmptyEnum;"); - verifyFormat("typedef enum { A, B, C } ShortEnum;"); - verifyFormat("typedef enum {\n" - " ZERO = 0,\n" - " ONE = 1,\n" - " TWO = 2,\n" - " THREE = 3\n" - "} LongEnum;", - Style); - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterEnum = true; - verifyFormat("typedef enum {} EmptyEnum;"); - verifyFormat("typedef enum { A, B, C } ShortEnum;"); - verifyFormat("typedef enum\n" - "{\n" - " ZERO = 0,\n" - " ONE = 1,\n" - " TWO = 2,\n" - " THREE = 3\n" - "} LongEnum;", - Style); -} - -TEST_F(FormatTest, FormatsNSEnums) { - verifyGoogleFormat("typedef NS_ENUM(NSInteger, SomeName) { AAA, BBB }"); - verifyGoogleFormat("typedef NS_ENUM(NSInteger, MyType) {\n" - " // Information about someDecentlyLongValue.\n" - " someDecentlyLongValue,\n" - " // Information about anotherDecentlyLongValue.\n" - " anotherDecentlyLongValue,\n" - " // Information about aThirdDecentlyLongValue.\n" - " aThirdDecentlyLongValue\n" - "};"); - verifyGoogleFormat("typedef NS_OPTIONS(NSInteger, MyType) {\n" - " a = 1,\n" - " b = 2,\n" - " c = 3,\n" - "};"); - verifyGoogleFormat("typedef CF_ENUM(NSInteger, MyType) {\n" - " a = 1,\n" - " b = 2,\n" - " c = 3,\n" - "};"); - verifyGoogleFormat("typedef CF_OPTIONS(NSInteger, MyType) {\n" - " a = 1,\n" - " b = 2,\n" - " c = 3,\n" - "};"); -} - -TEST_F(FormatTest, FormatsBitfields) { - verifyFormat("struct Bitfields {\n" - " unsigned sClass : 8;\n" - " unsigned ValueKind : 2;\n" - "};"); - verifyFormat("struct A {\n" - " int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa : 1,\n" - " bbbbbbbbbbbbbbbbbbbbbbbbb;\n" - "};"); - verifyFormat("struct MyStruct {\n" - " uchar data;\n" - " uchar : 8;\n" - " uchar : 8;\n" - " uchar other;\n" - "};"); -} - -TEST_F(FormatTest, FormatsNamespaces) { - FormatStyle LLVMWithNoNamespaceFix = getLLVMStyle(); - LLVMWithNoNamespaceFix.FixNamespaceComments = false; - - verifyFormat("namespace some_namespace {\n" - "class A {};\n" - "void f() { f(); }\n" - "}", - LLVMWithNoNamespaceFix); - verifyFormat("/* something */ namespace some_namespace {\n" - "class A {};\n" - "void f() { f(); }\n" - "}", - LLVMWithNoNamespaceFix); - verifyFormat("namespace {\n" - "class A {};\n" - "void f() { f(); }\n" - "}", - LLVMWithNoNamespaceFix); - verifyFormat("/* something */ namespace {\n" - "class A {};\n" - "void f() { f(); }\n" - "}", - LLVMWithNoNamespaceFix); - verifyFormat("inline namespace X {\n" - "class A {};\n" - "void f() { f(); }\n" - "}", - LLVMWithNoNamespaceFix); - verifyFormat("/* something */ inline namespace X {\n" - "class A {};\n" - "void f() { f(); }\n" - "}", - LLVMWithNoNamespaceFix); - verifyFormat("export namespace X {\n" - "class A {};\n" - "void f() { f(); }\n" - "}", - LLVMWithNoNamespaceFix); - verifyFormat("using namespace some_namespace;\n" - "class A {};\n" - "void f() { f(); }", - LLVMWithNoNamespaceFix); - - // This code is more common than we thought; if we - // layout this correctly the semicolon will go into - // its own line, which is undesirable. - verifyFormat("namespace {};", - LLVMWithNoNamespaceFix); - verifyFormat("namespace {\n" - "class A {};\n" - "};", - LLVMWithNoNamespaceFix); - - verifyFormat("namespace {\n" - "int SomeVariable = 0; // comment\n" - "} // namespace", - LLVMWithNoNamespaceFix); - EXPECT_EQ("#ifndef HEADER_GUARD\n" - "#define HEADER_GUARD\n" - "namespace my_namespace {\n" - "int i;\n" - "} // my_namespace\n" - "#endif // HEADER_GUARD", - format("#ifndef HEADER_GUARD\n" - " #define HEADER_GUARD\n" - " namespace my_namespace {\n" - "int i;\n" - "} // my_namespace\n" - "#endif // HEADER_GUARD", - LLVMWithNoNamespaceFix)); - - EXPECT_EQ("namespace A::B {\n" - "class C {};\n" - "}", - format("namespace A::B {\n" - "class C {};\n" - "}", - LLVMWithNoNamespaceFix)); - - FormatStyle Style = getLLVMStyle(); - Style.NamespaceIndentation = FormatStyle::NI_All; - EXPECT_EQ("namespace out {\n" - " int i;\n" - " namespace in {\n" - " int i;\n" - " } // namespace in\n" - "} // namespace out", - format("namespace out {\n" - "int i;\n" - "namespace in {\n" - "int i;\n" - "} // namespace in\n" - "} // namespace out", - Style)); - - Style.NamespaceIndentation = FormatStyle::NI_Inner; - EXPECT_EQ("namespace out {\n" - "int i;\n" - "namespace in {\n" - " int i;\n" - "} // namespace in\n" - "} // namespace out", - format("namespace out {\n" - "int i;\n" - "namespace in {\n" - "int i;\n" - "} // namespace in\n" - "} // namespace out", - Style)); -} - -TEST_F(FormatTest, FormatsCompactNamespaces) { - FormatStyle Style = getLLVMStyle(); - Style.CompactNamespaces = true; - - verifyFormat("namespace A { namespace B {\n" - "}} // namespace A::B", - Style); - - EXPECT_EQ("namespace out { namespace in {\n" - "}} // namespace out::in", - format("namespace out {\n" - "namespace in {\n" - "} // namespace in\n" - "} // namespace out", - Style)); - - // Only namespaces which have both consecutive opening and end get compacted - EXPECT_EQ("namespace out {\n" - "namespace in1 {\n" - "} // namespace in1\n" - "namespace in2 {\n" - "} // namespace in2\n" - "} // namespace out", - format("namespace out {\n" - "namespace in1 {\n" - "} // namespace in1\n" - "namespace in2 {\n" - "} // namespace in2\n" - "} // namespace out", - Style)); - - EXPECT_EQ("namespace out {\n" - "int i;\n" - "namespace in {\n" - "int j;\n" - "} // namespace in\n" - "int k;\n" - "} // namespace out", - format("namespace out { int i;\n" - "namespace in { int j; } // namespace in\n" - "int k; } // namespace out", - Style)); - - EXPECT_EQ("namespace A { namespace B { namespace C {\n" - "}}} // namespace A::B::C\n", - format("namespace A { namespace B {\n" - "namespace C {\n" - "}} // namespace B::C\n" - "} // namespace A\n", - Style)); - - Style.ColumnLimit = 40; - EXPECT_EQ("namespace aaaaaaaaaa {\n" - "namespace bbbbbbbbbb {\n" - "}} // namespace aaaaaaaaaa::bbbbbbbbbb", - format("namespace aaaaaaaaaa {\n" - "namespace bbbbbbbbbb {\n" - "} // namespace bbbbbbbbbb\n" - "} // namespace aaaaaaaaaa", - Style)); - - EXPECT_EQ("namespace aaaaaa { namespace bbbbbb {\n" - "namespace cccccc {\n" - "}}} // namespace aaaaaa::bbbbbb::cccccc", - format("namespace aaaaaa {\n" - "namespace bbbbbb {\n" - "namespace cccccc {\n" - "} // namespace cccccc\n" - "} // namespace bbbbbb\n" - "} // namespace aaaaaa", - Style)); - Style.ColumnLimit = 80; - - // Extra semicolon after 'inner' closing brace prevents merging - EXPECT_EQ("namespace out { namespace in {\n" - "}; } // namespace out::in", - format("namespace out {\n" - "namespace in {\n" - "}; // namespace in\n" - "} // namespace out", - Style)); - - // Extra semicolon after 'outer' closing brace is conserved - EXPECT_EQ("namespace out { namespace in {\n" - "}}; // namespace out::in", - format("namespace out {\n" - "namespace in {\n" - "} // namespace in\n" - "}; // namespace out", - Style)); - - Style.NamespaceIndentation = FormatStyle::NI_All; - EXPECT_EQ("namespace out { namespace in {\n" - " int i;\n" - "}} // namespace out::in", - format("namespace out {\n" - "namespace in {\n" - "int i;\n" - "} // namespace in\n" - "} // namespace out", - Style)); - EXPECT_EQ("namespace out { namespace mid {\n" - " namespace in {\n" - " int j;\n" - " } // namespace in\n" - " int k;\n" - "}} // namespace out::mid", - format("namespace out { namespace mid {\n" - "namespace in { int j; } // namespace in\n" - "int k; }} // namespace out::mid", - Style)); - - Style.NamespaceIndentation = FormatStyle::NI_Inner; - EXPECT_EQ("namespace out { namespace in {\n" - " int i;\n" - "}} // namespace out::in", - format("namespace out {\n" - "namespace in {\n" - "int i;\n" - "} // namespace in\n" - "} // namespace out", - Style)); - EXPECT_EQ("namespace out { namespace mid { namespace in {\n" - " int i;\n" - "}}} // namespace out::mid::in", - format("namespace out {\n" - "namespace mid {\n" - "namespace in {\n" - "int i;\n" - "} // namespace in\n" - "} // namespace mid\n" - "} // namespace out", - Style)); -} - -TEST_F(FormatTest, FormatsExternC) { - verifyFormat("extern \"C\" {\nint a;"); - verifyFormat("extern \"C\" {}"); - verifyFormat("extern \"C\" {\n" - "int foo();\n" - "}"); - verifyFormat("extern \"C\" int foo() {}"); - verifyFormat("extern \"C\" int foo();"); - verifyFormat("extern \"C\" int foo() {\n" - " int i = 42;\n" - " return i;\n" - "}"); - - FormatStyle Style = getLLVMStyle(); - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterFunction = true; - verifyFormat("extern \"C\" int foo() {}", Style); - verifyFormat("extern \"C\" int foo();", Style); - verifyFormat("extern \"C\" int foo()\n" - "{\n" - " int i = 42;\n" - " return i;\n" - "}", - Style); - - Style.BraceWrapping.AfterExternBlock = true; - Style.BraceWrapping.SplitEmptyRecord = false; - verifyFormat("extern \"C\"\n" - "{}", - Style); - verifyFormat("extern \"C\"\n" - "{\n" - " int foo();\n" - "}", - Style); -} - -TEST_F(FormatTest, FormatsInlineASM) { - verifyFormat("asm(\"xyz\" : \"=a\"(a), \"=d\"(b) : \"a\"(data));"); - verifyFormat("asm(\"nop\" ::: \"memory\");"); - verifyFormat( - "asm(\"movq\\t%%rbx, %%rsi\\n\\t\"\n" - " \"cpuid\\n\\t\"\n" - " \"xchgq\\t%%rbx, %%rsi\\n\\t\"\n" - " : \"=a\"(*rEAX), \"=S\"(*rEBX), \"=c\"(*rECX), \"=d\"(*rEDX)\n" - " : \"a\"(value));"); - EXPECT_EQ( - "void NS_InvokeByIndex(void *that, unsigned int methodIndex) {\n" - " __asm {\n" - " mov edx,[that] // vtable in edx\n" - " mov eax,methodIndex\n" - " call [edx][eax*4] // stdcall\n" - " }\n" - "}", - format("void NS_InvokeByIndex(void *that, unsigned int methodIndex) {\n" - " __asm {\n" - " mov edx,[that] // vtable in edx\n" - " mov eax,methodIndex\n" - " call [edx][eax*4] // stdcall\n" - " }\n" - "}")); - EXPECT_EQ("_asm {\n" - " xor eax, eax;\n" - " cpuid;\n" - "}", - format("_asm {\n" - " xor eax, eax;\n" - " cpuid;\n" - "}")); - verifyFormat("void function() {\n" - " // comment\n" - " asm(\"\");\n" - "}"); - EXPECT_EQ("__asm {\n" - "}\n" - "int i;", - format("__asm {\n" - "}\n" - "int i;")); -} - -TEST_F(FormatTest, FormatTryCatch) { - verifyFormat("try {\n" - " throw a * b;\n" - "} catch (int a) {\n" - " // Do nothing.\n" - "} catch (...) {\n" - " exit(42);\n" - "}"); - - // Function-level try statements. - verifyFormat("int f() try { return 4; } catch (...) {\n" - " return 5;\n" - "}"); - verifyFormat("class A {\n" - " int a;\n" - " A() try : a(0) {\n" - " } catch (...) {\n" - " throw;\n" - " }\n" - "};\n"); - - // Incomplete try-catch blocks. - verifyIncompleteFormat("try {} catch ("); -} - -TEST_F(FormatTest, FormatSEHTryCatch) { - verifyFormat("__try {\n" - " int a = b * c;\n" - "} __except (EXCEPTION_EXECUTE_HANDLER) {\n" - " // Do nothing.\n" - "}"); - - verifyFormat("__try {\n" - " int a = b * c;\n" - "} __finally {\n" - " // Do nothing.\n" - "}"); - - verifyFormat("DEBUG({\n" - " __try {\n" - " } __finally {\n" - " }\n" - "});\n"); -} - -TEST_F(FormatTest, IncompleteTryCatchBlocks) { - verifyFormat("try {\n" - " f();\n" - "} catch {\n" - " g();\n" - "}"); - verifyFormat("try {\n" - " f();\n" - "} catch (A a) MACRO(x) {\n" - " g();\n" - "} catch (B b) MACRO(x) {\n" - " g();\n" - "}"); -} - -TEST_F(FormatTest, FormatTryCatchBraceStyles) { - FormatStyle Style = getLLVMStyle(); - for (auto BraceStyle : {FormatStyle::BS_Attach, FormatStyle::BS_Mozilla, - FormatStyle::BS_WebKit}) { - Style.BreakBeforeBraces = BraceStyle; - verifyFormat("try {\n" - " // something\n" - "} catch (...) {\n" - " // something\n" - "}", - Style); - } - Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup; - verifyFormat("try {\n" - " // something\n" - "}\n" - "catch (...) {\n" - " // something\n" - "}", - Style); - verifyFormat("__try {\n" - " // something\n" - "}\n" - "__finally {\n" - " // something\n" - "}", - Style); - verifyFormat("@try {\n" - " // something\n" - "}\n" - "@finally {\n" - " // something\n" - "}", - Style); - Style.BreakBeforeBraces = FormatStyle::BS_Allman; - verifyFormat("try\n" - "{\n" - " // something\n" - "}\n" - "catch (...)\n" - "{\n" - " // something\n" - "}", - Style); - Style.BreakBeforeBraces = FormatStyle::BS_GNU; - verifyFormat("try\n" - " {\n" - " // something\n" - " }\n" - "catch (...)\n" - " {\n" - " // something\n" - " }", - Style); - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.BeforeCatch = true; - verifyFormat("try {\n" - " // something\n" - "}\n" - "catch (...) {\n" - " // something\n" - "}", - Style); -} - -TEST_F(FormatTest, StaticInitializers) { - verifyFormat("static SomeClass SC = {1, 'a'};"); - - verifyFormat("static SomeClass WithALoooooooooooooooooooongName = {\n" - " 100000000, " - "\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"};"); - - // Here, everything other than the "}" would fit on a line. - verifyFormat("static int LooooooooooooooooooooooooongVariable[1] = {\n" - " 10000000000000000000000000};"); - EXPECT_EQ("S s = {a,\n" - "\n" - " b};", - format("S s = {\n" - " a,\n" - "\n" - " b\n" - "};")); - - // FIXME: This would fit into the column limit if we'd fit "{ {" on the first - // line. However, the formatting looks a bit off and this probably doesn't - // happen often in practice. - verifyFormat("static int Variable[1] = {\n" - " {1000000000000000000000000000000000000}};", - getLLVMStyleWithColumns(40)); -} - -TEST_F(FormatTest, DesignatedInitializers) { - verifyFormat("const struct A a = {.a = 1, .b = 2};"); - verifyFormat("const struct A a = {.aaaaaaaaaa = 1,\n" - " .bbbbbbbbbb = 2,\n" - " .cccccccccc = 3,\n" - " .dddddddddd = 4,\n" - " .eeeeeeeeee = 5};"); - verifyFormat("const struct Aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaa = {\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaa = 1,\n" - " .bbbbbbbbbbbbbbbbbbbbbbbbbbb = 2,\n" - " .ccccccccccccccccccccccccccc = 3,\n" - " .ddddddddddddddddddddddddddd = 4,\n" - " .eeeeeeeeeeeeeeeeeeeeeeeeeee = 5};"); - - verifyGoogleFormat("const struct A a = {.a = 1, .b = 2};"); - - verifyFormat("const struct A a = {[0] = 1, [1] = 2};"); - verifyFormat("const struct A a = {[1] = aaaaaaaaaa,\n" - " [2] = bbbbbbbbbb,\n" - " [3] = cccccccccc,\n" - " [4] = dddddddddd,\n" - " [5] = eeeeeeeeee};"); - verifyFormat("const struct Aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaa = {\n" - " [1] = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " [2] = bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" - " [3] = cccccccccccccccccccccccccccccccccccccc,\n" - " [4] = dddddddddddddddddddddddddddddddddddddd,\n" - " [5] = eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee};"); -} - -TEST_F(FormatTest, NestedStaticInitializers) { - verifyFormat("static A x = {{{}}};\n"); - verifyFormat("static A x = {{{init1, init2, init3, init4},\n" - " {init1, init2, init3, init4}}};", - getLLVMStyleWithColumns(50)); - - verifyFormat("somes Status::global_reps[3] = {\n" - " {kGlobalRef, OK_CODE, NULL, NULL, NULL},\n" - " {kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL},\n" - " {kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL}};", - getLLVMStyleWithColumns(60)); - verifyGoogleFormat("SomeType Status::global_reps[3] = {\n" - " {kGlobalRef, OK_CODE, NULL, NULL, NULL},\n" - " {kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL},\n" - " {kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL}};"); - verifyFormat("CGRect cg_rect = {{rect.fLeft, rect.fTop},\n" - " {rect.fRight - rect.fLeft, rect.fBottom - " - "rect.fTop}};"); - - verifyFormat( - "SomeArrayOfSomeType a = {\n" - " {{1, 2, 3},\n" - " {1, 2, 3},\n" - " {111111111111111111111111111111, 222222222222222222222222222222,\n" - " 333333333333333333333333333333},\n" - " {1, 2, 3},\n" - " {1, 2, 3}}};"); - verifyFormat( - "SomeArrayOfSomeType a = {\n" - " {{1, 2, 3}},\n" - " {{1, 2, 3}},\n" - " {{111111111111111111111111111111, 222222222222222222222222222222,\n" - " 333333333333333333333333333333}},\n" - " {{1, 2, 3}},\n" - " {{1, 2, 3}}};"); - - verifyFormat("struct {\n" - " unsigned bit;\n" - " const char *const name;\n" - "} kBitsToOs[] = {{kOsMac, \"Mac\"},\n" - " {kOsWin, \"Windows\"},\n" - " {kOsLinux, \"Linux\"},\n" - " {kOsCrOS, \"Chrome OS\"}};"); - verifyFormat("struct {\n" - " unsigned bit;\n" - " const char *const name;\n" - "} kBitsToOs[] = {\n" - " {kOsMac, \"Mac\"},\n" - " {kOsWin, \"Windows\"},\n" - " {kOsLinux, \"Linux\"},\n" - " {kOsCrOS, \"Chrome OS\"},\n" - "};"); -} - -TEST_F(FormatTest, FormatsSmallMacroDefinitionsInSingleLine) { - verifyFormat("#define ALooooooooooooooooooooooooooooooooooooooongMacro(" - " \\\n" - " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)"); -} - -TEST_F(FormatTest, DoesNotBreakPureVirtualFunctionDefinition) { - verifyFormat("virtual void write(ELFWriter *writerrr,\n" - " OwningPtr<FileOutputBuffer> &buffer) = 0;"); - - // Do break defaulted and deleted functions. - verifyFormat("virtual void ~Deeeeeeeestructor() =\n" - " default;", - getLLVMStyleWithColumns(40)); - verifyFormat("virtual void ~Deeeeeeeestructor() =\n" - " delete;", - getLLVMStyleWithColumns(40)); -} - -TEST_F(FormatTest, BreaksStringLiteralsOnlyInDefine) { - verifyFormat("# 1111 \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\" 2 3", - getLLVMStyleWithColumns(40)); - verifyFormat("#line 11111 \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\"", - getLLVMStyleWithColumns(40)); - EXPECT_EQ("#define Q \\\n" - " \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/\" \\\n" - " \"aaaaaaaa.cpp\"", - format("#define Q \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\"", - getLLVMStyleWithColumns(40))); -} - -TEST_F(FormatTest, UnderstandsLinePPDirective) { - EXPECT_EQ("# 123 \"A string literal\"", - format(" # 123 \"A string literal\"")); -} - -TEST_F(FormatTest, LayoutUnknownPPDirective) { - EXPECT_EQ("#;", format("#;")); - verifyFormat("#\n;\n;\n;"); -} - -TEST_F(FormatTest, UnescapedEndOfLineEndsPPDirective) { - EXPECT_EQ("#line 42 \"test\"\n", - format("# \\\n line \\\n 42 \\\n \"test\"\n")); - EXPECT_EQ("#define A B\n", format("# \\\n define \\\n A \\\n B\n", - getLLVMStyleWithColumns(12))); -} - -TEST_F(FormatTest, EndOfFileEndsPPDirective) { - EXPECT_EQ("#line 42 \"test\"", - format("# \\\n line \\\n 42 \\\n \"test\"")); - EXPECT_EQ("#define A B", format("# \\\n define \\\n A \\\n B")); -} - -TEST_F(FormatTest, DoesntRemoveUnknownTokens) { - verifyFormat("#define A \\x20"); - verifyFormat("#define A \\ x20"); - EXPECT_EQ("#define A \\ x20", format("#define A \\ x20")); - verifyFormat("#define A ''"); - verifyFormat("#define A ''qqq"); - verifyFormat("#define A `qqq"); - verifyFormat("f(\"aaaa, bbbb, \"\\\"ccccc\\\"\");"); - EXPECT_EQ("const char *c = STRINGIFY(\n" - "\\na : b);", - format("const char * c = STRINGIFY(\n" - "\\na : b);")); - - verifyFormat("a\r\\"); - verifyFormat("a\v\\"); - verifyFormat("a\f\\"); -} - -TEST_F(FormatTest, IndentsPPDirectiveInReducedSpace) { - verifyFormat("#define A(BB)", getLLVMStyleWithColumns(13)); - verifyFormat("#define A( \\\n BB)", getLLVMStyleWithColumns(12)); - verifyFormat("#define A( \\\n A, B)", getLLVMStyleWithColumns(12)); - // FIXME: We never break before the macro name. - verifyFormat("#define AA( \\\n B)", getLLVMStyleWithColumns(12)); - - verifyFormat("#define A A\n#define A A"); - verifyFormat("#define A(X) A\n#define A A"); - - verifyFormat("#define Something Other", getLLVMStyleWithColumns(23)); - verifyFormat("#define Something \\\n Other", getLLVMStyleWithColumns(22)); -} - -TEST_F(FormatTest, HandlePreprocessorDirectiveContext) { - EXPECT_EQ("// somecomment\n" - "#include \"a.h\"\n" - "#define A( \\\n" - " A, B)\n" - "#include \"b.h\"\n" - "// somecomment\n", - format(" // somecomment\n" - " #include \"a.h\"\n" - "#define A(A,\\\n" - " B)\n" - " #include \"b.h\"\n" - " // somecomment\n", - getLLVMStyleWithColumns(13))); -} - -TEST_F(FormatTest, LayoutSingleHash) { EXPECT_EQ("#\na;", format("#\na;")); } - -TEST_F(FormatTest, LayoutCodeInMacroDefinitions) { - EXPECT_EQ("#define A \\\n" - " c; \\\n" - " e;\n" - "f;", - format("#define A c; e;\n" - "f;", - getLLVMStyleWithColumns(14))); -} - -TEST_F(FormatTest, LayoutRemainingTokens) { EXPECT_EQ("{}", format("{}")); } - -TEST_F(FormatTest, MacroDefinitionInsideStatement) { - EXPECT_EQ("int x,\n" - "#define A\n" - " y;", - format("int x,\n#define A\ny;")); -} - -TEST_F(FormatTest, HashInMacroDefinition) { - EXPECT_EQ("#define A(c) L#c", format("#define A(c) L#c", getLLVMStyle())); - verifyFormat("#define A \\\n b #c;", getLLVMStyleWithColumns(11)); - verifyFormat("#define A \\\n" - " { \\\n" - " f(#c); \\\n" - " }", - getLLVMStyleWithColumns(11)); - - verifyFormat("#define A(X) \\\n" - " void function##X()", - getLLVMStyleWithColumns(22)); - - verifyFormat("#define A(a, b, c) \\\n" - " void a##b##c()", - getLLVMStyleWithColumns(22)); - - verifyFormat("#define A void # ## #", getLLVMStyleWithColumns(22)); -} - -TEST_F(FormatTest, RespectWhitespaceInMacroDefinitions) { - EXPECT_EQ("#define A (x)", format("#define A (x)")); - EXPECT_EQ("#define A(x)", format("#define A(x)")); -} - -TEST_F(FormatTest, EmptyLinesInMacroDefinitions) { - EXPECT_EQ("#define A b;", format("#define A \\\n" - " \\\n" - " b;", - getLLVMStyleWithColumns(25))); - EXPECT_EQ("#define A \\\n" - " \\\n" - " a; \\\n" - " b;", - format("#define A \\\n" - " \\\n" - " a; \\\n" - " b;", - getLLVMStyleWithColumns(11))); - EXPECT_EQ("#define A \\\n" - " a; \\\n" - " \\\n" - " b;", - format("#define A \\\n" - " a; \\\n" - " \\\n" - " b;", - getLLVMStyleWithColumns(11))); -} - -TEST_F(FormatTest, MacroDefinitionsWithIncompleteCode) { - verifyIncompleteFormat("#define A :"); - verifyFormat("#define SOMECASES \\\n" - " case 1: \\\n" - " case 2\n", - getLLVMStyleWithColumns(20)); - verifyFormat("#define MACRO(a) \\\n" - " if (a) \\\n" - " f(); \\\n" - " else \\\n" - " g()", - getLLVMStyleWithColumns(18)); - verifyFormat("#define A template <typename T>"); - verifyIncompleteFormat("#define STR(x) #x\n" - "f(STR(this_is_a_string_literal{));"); - verifyFormat("#pragma omp threadprivate( \\\n" - " y)), // expected-warning", - getLLVMStyleWithColumns(28)); - verifyFormat("#d, = };"); - verifyFormat("#if \"a"); - verifyIncompleteFormat("({\n" - "#define b \\\n" - " } \\\n" - " a\n" - "a", - getLLVMStyleWithColumns(15)); - verifyFormat("#define A \\\n" - " { \\\n" - " {\n" - "#define B \\\n" - " } \\\n" - " }", - getLLVMStyleWithColumns(15)); - verifyNoCrash("#if a\na(\n#else\n#endif\n{a"); - verifyNoCrash("a={0,1\n#if a\n#else\n;\n#endif\n}"); - verifyNoCrash("#if a\na(\n#else\n#endif\n) a {a,b,c,d,f,g};"); - verifyNoCrash("#ifdef A\n a(\n #else\n #endif\n) = []() { \n)}"); -} - -TEST_F(FormatTest, MacrosWithoutTrailingSemicolon) { - verifyFormat("SOME_TYPE_NAME abc;"); // Gated on the newline. - EXPECT_EQ("class A : public QObject {\n" - " Q_OBJECT\n" - "\n" - " A() {}\n" - "};", - format("class A : public QObject {\n" - " Q_OBJECT\n" - "\n" - " A() {\n}\n" - "} ;")); - EXPECT_EQ("MACRO\n" - "/*static*/ int i;", - format("MACRO\n" - " /*static*/ int i;")); - EXPECT_EQ("SOME_MACRO\n" - "namespace {\n" - "void f();\n" - "} // namespace", - format("SOME_MACRO\n" - " namespace {\n" - "void f( );\n" - "} // namespace")); - // Only if the identifier contains at least 5 characters. - EXPECT_EQ("HTTP f();", format("HTTP\nf();")); - EXPECT_EQ("MACRO\nf();", format("MACRO\nf();")); - // Only if everything is upper case. - EXPECT_EQ("class A : public QObject {\n" - " Q_Object A() {}\n" - "};", - format("class A : public QObject {\n" - " Q_Object\n" - " A() {\n}\n" - "} ;")); - - // Only if the next line can actually start an unwrapped line. - EXPECT_EQ("SOME_WEIRD_LOG_MACRO << SomeThing;", - format("SOME_WEIRD_LOG_MACRO\n" - "<< SomeThing;")); - - verifyFormat("VISIT_GL_CALL(GenBuffers, void, (GLsizei n, GLuint* buffers), " - "(n, buffers))\n", - getChromiumStyle(FormatStyle::LK_Cpp)); -} - -TEST_F(FormatTest, MacroCallsWithoutTrailingSemicolon) { - EXPECT_EQ("INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n" - "INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n" - "INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n" - "class X {};\n" - "INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n" - "int *createScopDetectionPass() { return 0; }", - format(" INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n" - " INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n" - " INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n" - " class X {};\n" - " INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n" - " int *createScopDetectionPass() { return 0; }")); - // FIXME: We could probably treat IPC_BEGIN_MESSAGE_MAP/IPC_END_MESSAGE_MAP as - // braces, so that inner block is indented one level more. - EXPECT_EQ("int q() {\n" - " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n" - " IPC_MESSAGE_HANDLER(xxx, qqq)\n" - " IPC_END_MESSAGE_MAP()\n" - "}", - format("int q() {\n" - " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n" - " IPC_MESSAGE_HANDLER(xxx, qqq)\n" - " IPC_END_MESSAGE_MAP()\n" - "}")); - - // Same inside macros. - EXPECT_EQ("#define LIST(L) \\\n" - " L(A) \\\n" - " L(B) \\\n" - " L(C)", - format("#define LIST(L) \\\n" - " L(A) \\\n" - " L(B) \\\n" - " L(C)", - getGoogleStyle())); - - // These must not be recognized as macros. - EXPECT_EQ("int q() {\n" - " f(x);\n" - " f(x) {}\n" - " f(x)->g();\n" - " f(x)->*g();\n" - " f(x).g();\n" - " f(x) = x;\n" - " f(x) += x;\n" - " f(x) -= x;\n" - " f(x) *= x;\n" - " f(x) /= x;\n" - " f(x) %= x;\n" - " f(x) &= x;\n" - " f(x) |= x;\n" - " f(x) ^= x;\n" - " f(x) >>= x;\n" - " f(x) <<= x;\n" - " f(x)[y].z();\n" - " LOG(INFO) << x;\n" - " ifstream(x) >> x;\n" - "}\n", - format("int q() {\n" - " f(x)\n;\n" - " f(x)\n {}\n" - " f(x)\n->g();\n" - " f(x)\n->*g();\n" - " f(x)\n.g();\n" - " f(x)\n = x;\n" - " f(x)\n += x;\n" - " f(x)\n -= x;\n" - " f(x)\n *= x;\n" - " f(x)\n /= x;\n" - " f(x)\n %= x;\n" - " f(x)\n &= x;\n" - " f(x)\n |= x;\n" - " f(x)\n ^= x;\n" - " f(x)\n >>= x;\n" - " f(x)\n <<= x;\n" - " f(x)\n[y].z();\n" - " LOG(INFO)\n << x;\n" - " ifstream(x)\n >> x;\n" - "}\n")); - EXPECT_EQ("int q() {\n" - " F(x)\n" - " if (1) {\n" - " }\n" - " F(x)\n" - " while (1) {\n" - " }\n" - " F(x)\n" - " G(x);\n" - " F(x)\n" - " try {\n" - " Q();\n" - " } catch (...) {\n" - " }\n" - "}\n", - format("int q() {\n" - "F(x)\n" - "if (1) {}\n" - "F(x)\n" - "while (1) {}\n" - "F(x)\n" - "G(x);\n" - "F(x)\n" - "try { Q(); } catch (...) {}\n" - "}\n")); - EXPECT_EQ("class A {\n" - " A() : t(0) {}\n" - " A(int i) noexcept() : {}\n" - " A(X x)\n" // FIXME: function-level try blocks are broken. - " try : t(0) {\n" - " } catch (...) {\n" - " }\n" - "};", - format("class A {\n" - " A()\n : t(0) {}\n" - " A(int i)\n noexcept() : {}\n" - " A(X x)\n" - " try : t(0) {} catch (...) {}\n" - "};")); - FormatStyle Style = getLLVMStyle(); - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterControlStatement = true; - Style.BraceWrapping.AfterFunction = true; - EXPECT_EQ("void f()\n" - "try\n" - "{\n" - "}", - format("void f() try {\n" - "}", Style)); - EXPECT_EQ("class SomeClass {\n" - "public:\n" - " SomeClass() EXCLUSIVE_LOCK_FUNCTION(mu_);\n" - "};", - format("class SomeClass {\n" - "public:\n" - " SomeClass()\n" - " EXCLUSIVE_LOCK_FUNCTION(mu_);\n" - "};")); - EXPECT_EQ("class SomeClass {\n" - "public:\n" - " SomeClass()\n" - " EXCLUSIVE_LOCK_FUNCTION(mu_);\n" - "};", - format("class SomeClass {\n" - "public:\n" - " SomeClass()\n" - " EXCLUSIVE_LOCK_FUNCTION(mu_);\n" - "};", - getLLVMStyleWithColumns(40))); - - verifyFormat("MACRO(>)"); - - // Some macros contain an implicit semicolon. - Style = getLLVMStyle(); - Style.StatementMacros.push_back("FOO"); - verifyFormat("FOO(a) int b = 0;"); - verifyFormat("FOO(a)\n" - "int b = 0;", - Style); - verifyFormat("FOO(a);\n" - "int b = 0;", - Style); - verifyFormat("FOO(argc, argv, \"4.0.2\")\n" - "int b = 0;", - Style); - verifyFormat("FOO()\n" - "int b = 0;", - Style); - verifyFormat("FOO\n" - "int b = 0;", - Style); - verifyFormat("void f() {\n" - " FOO(a)\n" - " return a;\n" - "}", - Style); - verifyFormat("FOO(a)\n" - "FOO(b)", - Style); - verifyFormat("int a = 0;\n" - "FOO(b)\n" - "int c = 0;", - Style); - verifyFormat("int a = 0;\n" - "int x = FOO(a)\n" - "int b = 0;", - Style); - verifyFormat("void foo(int a) { FOO(a) }\n" - "uint32_t bar() {}", - Style); -} - -TEST_F(FormatTest, LayoutMacroDefinitionsStatementsSpanningBlocks) { - verifyFormat("#define A \\\n" - " f({ \\\n" - " g(); \\\n" - " });", - getLLVMStyleWithColumns(11)); -} - -TEST_F(FormatTest, IndentPreprocessorDirectives) { - FormatStyle Style = getLLVMStyle(); - Style.IndentPPDirectives = FormatStyle::PPDIS_None; - Style.ColumnLimit = 40; - verifyFormat("#ifdef _WIN32\n" - "#define A 0\n" - "#ifdef VAR2\n" - "#define B 1\n" - "#include <someheader.h>\n" - "#define MACRO \\\n" - " some_very_long_func_aaaaaaaaaa();\n" - "#endif\n" - "#else\n" - "#define A 1\n" - "#endif", - Style); - Style.IndentPPDirectives = FormatStyle::PPDIS_AfterHash; - verifyFormat("#ifdef _WIN32\n" - "# define A 0\n" - "# ifdef VAR2\n" - "# define B 1\n" - "# include <someheader.h>\n" - "# define MACRO \\\n" - " some_very_long_func_aaaaaaaaaa();\n" - "# endif\n" - "#else\n" - "# define A 1\n" - "#endif", - Style); - verifyFormat("#if A\n" - "# define MACRO \\\n" - " void a(int x) { \\\n" - " b(); \\\n" - " c(); \\\n" - " d(); \\\n" - " e(); \\\n" - " f(); \\\n" - " }\n" - "#endif", - Style); - // Comments before include guard. - verifyFormat("// file comment\n" - "// file comment\n" - "#ifndef HEADER_H\n" - "#define HEADER_H\n" - "code();\n" - "#endif", - Style); - // Test with include guards. - verifyFormat("#ifndef HEADER_H\n" - "#define HEADER_H\n" - "code();\n" - "#endif", - Style); - // Include guards must have a #define with the same variable immediately - // after #ifndef. - verifyFormat("#ifndef NOT_GUARD\n" - "# define FOO\n" - "code();\n" - "#endif", - Style); - - // Include guards must cover the entire file. - verifyFormat("code();\n" - "code();\n" - "#ifndef NOT_GUARD\n" - "# define NOT_GUARD\n" - "code();\n" - "#endif", - Style); - verifyFormat("#ifndef NOT_GUARD\n" - "# define NOT_GUARD\n" - "code();\n" - "#endif\n" - "code();", - Style); - // Test with trailing blank lines. - verifyFormat("#ifndef HEADER_H\n" - "#define HEADER_H\n" - "code();\n" - "#endif\n", - Style); - // Include guards don't have #else. - verifyFormat("#ifndef NOT_GUARD\n" - "# define NOT_GUARD\n" - "code();\n" - "#else\n" - "#endif", - Style); - verifyFormat("#ifndef NOT_GUARD\n" - "# define NOT_GUARD\n" - "code();\n" - "#elif FOO\n" - "#endif", - Style); - // Non-identifier #define after potential include guard. - verifyFormat("#ifndef FOO\n" - "# define 1\n" - "#endif\n", - Style); - // #if closes past last non-preprocessor line. - verifyFormat("#ifndef FOO\n" - "#define FOO\n" - "#if 1\n" - "int i;\n" - "# define A 0\n" - "#endif\n" - "#endif\n", - Style); - // FIXME: This doesn't handle the case where there's code between the - // #ifndef and #define but all other conditions hold. This is because when - // the #define line is parsed, UnwrappedLineParser::Lines doesn't hold the - // previous code line yet, so we can't detect it. - EXPECT_EQ("#ifndef NOT_GUARD\n" - "code();\n" - "#define NOT_GUARD\n" - "code();\n" - "#endif", - format("#ifndef NOT_GUARD\n" - "code();\n" - "# define NOT_GUARD\n" - "code();\n" - "#endif", - Style)); - // FIXME: This doesn't handle cases where legitimate preprocessor lines may - // be outside an include guard. Examples are #pragma once and - // #pragma GCC diagnostic, or anything else that does not change the meaning - // of the file if it's included multiple times. - EXPECT_EQ("#ifdef WIN32\n" - "# pragma once\n" - "#endif\n" - "#ifndef HEADER_H\n" - "# define HEADER_H\n" - "code();\n" - "#endif", - format("#ifdef WIN32\n" - "# pragma once\n" - "#endif\n" - "#ifndef HEADER_H\n" - "#define HEADER_H\n" - "code();\n" - "#endif", - Style)); - // FIXME: This does not detect when there is a single non-preprocessor line - // in front of an include-guard-like structure where other conditions hold - // because ScopedLineState hides the line. - EXPECT_EQ("code();\n" - "#ifndef HEADER_H\n" - "#define HEADER_H\n" - "code();\n" - "#endif", - format("code();\n" - "#ifndef HEADER_H\n" - "# define HEADER_H\n" - "code();\n" - "#endif", - Style)); - // Keep comments aligned with #, otherwise indent comments normally. These - // tests cannot use verifyFormat because messUp manipulates leading - // whitespace. - { - const char *Expected = "" - "void f() {\n" - "#if 1\n" - "// Preprocessor aligned.\n" - "# define A 0\n" - " // Code. Separated by blank line.\n" - "\n" - "# define B 0\n" - " // Code. Not aligned with #\n" - "# define C 0\n" - "#endif"; - const char *ToFormat = "" - "void f() {\n" - "#if 1\n" - "// Preprocessor aligned.\n" - "# define A 0\n" - "// Code. Separated by blank line.\n" - "\n" - "# define B 0\n" - " // Code. Not aligned with #\n" - "# define C 0\n" - "#endif"; - EXPECT_EQ(Expected, format(ToFormat, Style)); - EXPECT_EQ(Expected, format(Expected, Style)); - } - // Keep block quotes aligned. - { - const char *Expected = "" - "void f() {\n" - "#if 1\n" - "/* Preprocessor aligned. */\n" - "# define A 0\n" - " /* Code. Separated by blank line. */\n" - "\n" - "# define B 0\n" - " /* Code. Not aligned with # */\n" - "# define C 0\n" - "#endif"; - const char *ToFormat = "" - "void f() {\n" - "#if 1\n" - "/* Preprocessor aligned. */\n" - "# define A 0\n" - "/* Code. Separated by blank line. */\n" - "\n" - "# define B 0\n" - " /* Code. Not aligned with # */\n" - "# define C 0\n" - "#endif"; - EXPECT_EQ(Expected, format(ToFormat, Style)); - EXPECT_EQ(Expected, format(Expected, Style)); - } - // Keep comments aligned with un-indented directives. - { - const char *Expected = "" - "void f() {\n" - "// Preprocessor aligned.\n" - "#define A 0\n" - " // Code. Separated by blank line.\n" - "\n" - "#define B 0\n" - " // Code. Not aligned with #\n" - "#define C 0\n"; - const char *ToFormat = "" - "void f() {\n" - "// Preprocessor aligned.\n" - "#define A 0\n" - "// Code. Separated by blank line.\n" - "\n" - "#define B 0\n" - " // Code. Not aligned with #\n" - "#define C 0\n"; - EXPECT_EQ(Expected, format(ToFormat, Style)); - EXPECT_EQ(Expected, format(Expected, Style)); - } - // Test with tabs. - Style.UseTab = FormatStyle::UT_Always; - Style.IndentWidth = 8; - Style.TabWidth = 8; - verifyFormat("#ifdef _WIN32\n" - "#\tdefine A 0\n" - "#\tifdef VAR2\n" - "#\t\tdefine B 1\n" - "#\t\tinclude <someheader.h>\n" - "#\t\tdefine MACRO \\\n" - "\t\t\tsome_very_long_func_aaaaaaaaaa();\n" - "#\tendif\n" - "#else\n" - "#\tdefine A 1\n" - "#endif", - Style); - - // Regression test: Multiline-macro inside include guards. - verifyFormat("#ifndef HEADER_H\n" - "#define HEADER_H\n" - "#define A() \\\n" - " int i; \\\n" - " int j;\n" - "#endif // HEADER_H", - getLLVMStyleWithColumns(20)); -} - -TEST_F(FormatTest, FormatHashIfNotAtStartOfLine) { - verifyFormat("{\n { a #c; }\n}"); -} - -TEST_F(FormatTest, FormatUnbalancedStructuralElements) { - EXPECT_EQ("#define A \\\n { \\\n {\nint i;", - format("#define A { {\nint i;", getLLVMStyleWithColumns(11))); - EXPECT_EQ("#define A \\\n } \\\n }\nint i;", - format("#define A } }\nint i;", getLLVMStyleWithColumns(11))); -} - -TEST_F(FormatTest, EscapedNewlines) { - FormatStyle Narrow = getLLVMStyleWithColumns(11); - EXPECT_EQ("#define A \\\n int i; \\\n int j;", - format("#define A \\\nint i;\\\n int j;", Narrow)); - EXPECT_EQ("#define A\n\nint i;", format("#define A \\\n\n int i;")); - EXPECT_EQ("template <class T> f();", format("\\\ntemplate <class T> f();")); - EXPECT_EQ("/* \\ \\ \\\n */", format("\\\n/* \\ \\ \\\n */")); - EXPECT_EQ("<a\n\\\\\n>", format("<a\n\\\\\n>")); - - FormatStyle AlignLeft = getLLVMStyle(); - AlignLeft.AlignEscapedNewlines = FormatStyle::ENAS_Left; - EXPECT_EQ("#define MACRO(x) \\\n" - "private: \\\n" - " int x(int a);\n", - format("#define MACRO(x) \\\n" - "private: \\\n" - " int x(int a);\n", - AlignLeft)); - - // CRLF line endings - EXPECT_EQ("#define A \\\r\n int i; \\\r\n int j;", - format("#define A \\\r\nint i;\\\r\n int j;", Narrow)); - EXPECT_EQ("#define A\r\n\r\nint i;", format("#define A \\\r\n\r\n int i;")); - EXPECT_EQ("template <class T> f();", format("\\\ntemplate <class T> f();")); - EXPECT_EQ("/* \\ \\ \\\r\n */", format("\\\r\n/* \\ \\ \\\r\n */")); - EXPECT_EQ("<a\r\n\\\\\r\n>", format("<a\r\n\\\\\r\n>")); - EXPECT_EQ("#define MACRO(x) \\\r\n" - "private: \\\r\n" - " int x(int a);\r\n", - format("#define MACRO(x) \\\r\n" - "private: \\\r\n" - " int x(int a);\r\n", - AlignLeft)); - - FormatStyle DontAlign = getLLVMStyle(); - DontAlign.AlignEscapedNewlines = FormatStyle::ENAS_DontAlign; - DontAlign.MaxEmptyLinesToKeep = 3; - // FIXME: can't use verifyFormat here because the newline before - // "public:" is not inserted the first time it's reformatted - EXPECT_EQ("#define A \\\n" - " class Foo { \\\n" - " void bar(); \\\n" - "\\\n" - "\\\n" - "\\\n" - " public: \\\n" - " void baz(); \\\n" - " };", - format("#define A \\\n" - " class Foo { \\\n" - " void bar(); \\\n" - "\\\n" - "\\\n" - "\\\n" - " public: \\\n" - " void baz(); \\\n" - " };", - DontAlign)); -} - -TEST_F(FormatTest, CalculateSpaceOnConsecutiveLinesInMacro) { - verifyFormat("#define A \\\n" - " int v( \\\n" - " a); \\\n" - " int i;", - getLLVMStyleWithColumns(11)); -} - -TEST_F(FormatTest, MixingPreprocessorDirectivesAndNormalCode) { - EXPECT_EQ( - "#define ALooooooooooooooooooooooooooooooooooooooongMacro(" - " \\\n" - " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n" - "\n" - "AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n" - " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n", - format(" #define ALooooooooooooooooooooooooooooooooooooooongMacro(" - "\\\n" - "aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n" - " \n" - " AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n" - " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n")); -} - -TEST_F(FormatTest, LayoutStatementsAroundPreprocessorDirectives) { - EXPECT_EQ("int\n" - "#define A\n" - " a;", - format("int\n#define A\na;")); - verifyFormat("functionCallTo(\n" - " someOtherFunction(\n" - " withSomeParameters, whichInSequence,\n" - " areLongerThanALine(andAnotherCall,\n" - "#define A B\n" - " withMoreParamters,\n" - " whichStronglyInfluenceTheLayout),\n" - " andMoreParameters),\n" - " trailing);", - getLLVMStyleWithColumns(69)); - verifyFormat("Foo::Foo()\n" - "#ifdef BAR\n" - " : baz(0)\n" - "#endif\n" - "{\n" - "}"); - verifyFormat("void f() {\n" - " if (true)\n" - "#ifdef A\n" - " f(42);\n" - " x();\n" - "#else\n" - " g();\n" - " x();\n" - "#endif\n" - "}"); - verifyFormat("void f(param1, param2,\n" - " param3,\n" - "#ifdef A\n" - " param4(param5,\n" - "#ifdef A1\n" - " param6,\n" - "#ifdef A2\n" - " param7),\n" - "#else\n" - " param8),\n" - " param9,\n" - "#endif\n" - " param10,\n" - "#endif\n" - " param11)\n" - "#else\n" - " param12)\n" - "#endif\n" - "{\n" - " x();\n" - "}", - getLLVMStyleWithColumns(28)); - verifyFormat("#if 1\n" - "int i;"); - verifyFormat("#if 1\n" - "#endif\n" - "#if 1\n" - "#else\n" - "#endif\n"); - verifyFormat("DEBUG({\n" - " return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n" - "});\n" - "#if a\n" - "#else\n" - "#endif"); - - verifyIncompleteFormat("void f(\n" - "#if A\n" - ");\n" - "#else\n" - "#endif"); -} - -TEST_F(FormatTest, GraciouslyHandleIncorrectPreprocessorConditions) { - verifyFormat("#endif\n" - "#if B"); -} - -TEST_F(FormatTest, FormatsJoinedLinesOnSubsequentRuns) { - FormatStyle SingleLine = getLLVMStyle(); - SingleLine.AllowShortIfStatementsOnASingleLine = true; - verifyFormat("#if 0\n" - "#elif 1\n" - "#endif\n" - "void foo() {\n" - " if (test) foo2();\n" - "}", - SingleLine); -} - -TEST_F(FormatTest, LayoutBlockInsideParens) { - verifyFormat("functionCall({ int i; });"); - verifyFormat("functionCall({\n" - " int i;\n" - " int j;\n" - "});"); - verifyFormat("functionCall(\n" - " {\n" - " int i;\n" - " int j;\n" - " },\n" - " aaaa, bbbb, cccc);"); - verifyFormat("functionA(functionB({\n" - " int i;\n" - " int j;\n" - " }),\n" - " aaaa, bbbb, cccc);"); - verifyFormat("functionCall(\n" - " {\n" - " int i;\n" - " int j;\n" - " },\n" - " aaaa, bbbb, // comment\n" - " cccc);"); - verifyFormat("functionA(functionB({\n" - " int i;\n" - " int j;\n" - " }),\n" - " aaaa, bbbb, // comment\n" - " cccc);"); - verifyFormat("functionCall(aaaa, bbbb, { int i; });"); - verifyFormat("functionCall(aaaa, bbbb, {\n" - " int i;\n" - " int j;\n" - "});"); - verifyFormat( - "Aaa(\n" // FIXME: There shouldn't be a linebreak here. - " {\n" - " int i; // break\n" - " },\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" - " ccccccccccccccccc));"); - verifyFormat("DEBUG({\n" - " if (a)\n" - " f();\n" - "});"); -} - -TEST_F(FormatTest, LayoutBlockInsideStatement) { - EXPECT_EQ("SOME_MACRO { int i; }\n" - "int i;", - format(" SOME_MACRO {int i;} int i;")); -} - -TEST_F(FormatTest, LayoutNestedBlocks) { - verifyFormat("void AddOsStrings(unsigned bitmask) {\n" - " struct s {\n" - " int i;\n" - " };\n" - " s kBitsToOs[] = {{10}};\n" - " for (int i = 0; i < 10; ++i)\n" - " return;\n" - "}"); - verifyFormat("call(parameter, {\n" - " something();\n" - " // Comment using all columns.\n" - " somethingelse();\n" - "});", - getLLVMStyleWithColumns(40)); - verifyFormat("DEBUG( //\n" - " { f(); }, a);"); - verifyFormat("DEBUG( //\n" - " {\n" - " f(); //\n" - " },\n" - " a);"); - - EXPECT_EQ("call(parameter, {\n" - " something();\n" - " // Comment too\n" - " // looooooooooong.\n" - " somethingElse();\n" - "});", - format("call(parameter, {\n" - " something();\n" - " // Comment too looooooooooong.\n" - " somethingElse();\n" - "});", - getLLVMStyleWithColumns(29))); - EXPECT_EQ("DEBUG({ int i; });", format("DEBUG({ int i; });")); - EXPECT_EQ("DEBUG({ // comment\n" - " int i;\n" - "});", - format("DEBUG({ // comment\n" - "int i;\n" - "});")); - EXPECT_EQ("DEBUG({\n" - " int i;\n" - "\n" - " // comment\n" - " int j;\n" - "});", - format("DEBUG({\n" - " int i;\n" - "\n" - " // comment\n" - " int j;\n" - "});")); - - verifyFormat("DEBUG({\n" - " if (a)\n" - " return;\n" - "});"); - verifyGoogleFormat("DEBUG({\n" - " if (a) return;\n" - "});"); - FormatStyle Style = getGoogleStyle(); - Style.ColumnLimit = 45; - verifyFormat("Debug(\n" - " aaaaa,\n" - " {\n" - " if (aaaaaaaaaaaaaaaaaaaaaaaa) return;\n" - " },\n" - " a);", - Style); - - verifyFormat("SomeFunction({MACRO({ return output; }), b});"); - - verifyNoCrash("^{v^{a}}"); -} - -TEST_F(FormatTest, FormatNestedBlocksInMacros) { - EXPECT_EQ("#define MACRO() \\\n" - " Debug(aaa, /* force line break */ \\\n" - " { \\\n" - " int i; \\\n" - " int j; \\\n" - " })", - format("#define MACRO() Debug(aaa, /* force line break */ \\\n" - " { int i; int j; })", - getGoogleStyle())); - - EXPECT_EQ("#define A \\\n" - " [] { \\\n" - " xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx( \\\n" - " xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx); \\\n" - " }", - format("#define A [] { xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx( \\\n" - "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx); }", - getGoogleStyle())); -} - -TEST_F(FormatTest, PutEmptyBlocksIntoOneLine) { - EXPECT_EQ("{}", format("{}")); - verifyFormat("enum E {};"); - verifyFormat("enum E {}"); -} - -TEST_F(FormatTest, FormatBeginBlockEndMacros) { - FormatStyle Style = getLLVMStyle(); - Style.MacroBlockBegin = "^[A-Z_]+_BEGIN$"; - Style.MacroBlockEnd = "^[A-Z_]+_END$"; - verifyFormat("FOO_BEGIN\n" - " FOO_ENTRY\n" - "FOO_END", Style); - verifyFormat("FOO_BEGIN\n" - " NESTED_FOO_BEGIN\n" - " NESTED_FOO_ENTRY\n" - " NESTED_FOO_END\n" - "FOO_END", Style); - verifyFormat("FOO_BEGIN(Foo, Bar)\n" - " int x;\n" - " x = 1;\n" - "FOO_END(Baz)", Style); -} - -//===----------------------------------------------------------------------===// -// Line break tests. -//===----------------------------------------------------------------------===// - -TEST_F(FormatTest, PreventConfusingIndents) { - verifyFormat( - "void f() {\n" - " SomeLongMethodName(SomeReallyLongMethod(CallOtherReallyLongMethod(\n" - " parameter, parameter, parameter)),\n" - " SecondLongCall(parameter));\n" - "}"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " [aaaaaaaaaaaaaaaaaaaaaaaa\n" - " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]\n" - " [aaaaaaaaaaaaaaaaaaaaaaaa]];"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" - " aaaaaaaaaaaaaaaaaaaaaaaa<\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>,\n" - " aaaaaaaaaaaaaaaaaaaaaaaa>;"); - verifyFormat("int a = bbbb && ccc &&\n" - " fffff(\n" - "#define A Just forcing a new line\n" - " ddd);"); -} - -TEST_F(FormatTest, LineBreakingInBinaryExpressions) { - verifyFormat( - "bool aaaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaa).aaaaaaaaaaaaaaaaaaa() ||\n" - " bbbbbbbb();"); - verifyFormat( - "bool aaaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaa).aaaaaaaaaaaaaaaaaaa() or\n" - " bbbbbbbb();"); - - verifyFormat("bool aaaaaaaaaaaaaaaaaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa != bbbbbbbbbbbbbbbbbb &&\n" - " ccccccccc == ddddddddddd;"); - verifyFormat("bool aaaaaaaaaaaaaaaaaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa != bbbbbbbbbbbbbbbbbb and\n" - " ccccccccc == ddddddddddd;"); - verifyFormat( - "bool aaaaaaaaaaaaaaaaaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa not_eq bbbbbbbbbbbbbbbbbb and\n" - " ccccccccc == ddddddddddd;"); - - verifyFormat("aaaaaa = aaaaaaa(aaaaaaa, // break\n" - " aaaaaa) &&\n" - " bbbbbb && cccccc;"); - verifyFormat("aaaaaa = aaaaaaa(aaaaaaa, // break\n" - " aaaaaa) >>\n" - " bbbbbb;"); - verifyFormat("aa = Whitespaces.addUntouchableComment(\n" - " SourceMgr.getSpellingColumnNumber(\n" - " TheLine.Last->FormatTok.Tok.getLocation()) -\n" - " 1);"); - - verifyFormat("if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" - " bbbbbbbbbbbbbbbbbb) && // aaaaaaaaaaaaaaaa\n" - " cccccc) {\n}"); - verifyFormat("if constexpr ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" - " bbbbbbbbbbbbbbbbbb) && // aaaaaaaaaaa\n" - " cccccc) {\n}"); - verifyFormat("b = a &&\n" - " // Comment\n" - " b.c && d;"); - - // If the LHS of a comparison is not a binary expression itself, the - // additional linebreak confuses many people. - verifyFormat( - "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) > 5) {\n" - "}"); - verifyFormat( - "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" - "}"); - verifyFormat( - "if (aaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" - "}"); - verifyFormat( - "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) <=> 5) {\n" - "}"); - // Even explicit parentheses stress the precedence enough to make the - // additional break unnecessary. - verifyFormat("if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" - "}"); - // This cases is borderline, but with the indentation it is still readable. - verifyFormat( - "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaa) > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" - "}", - getLLVMStyleWithColumns(75)); - - // If the LHS is a binary expression, we should still use the additional break - // as otherwise the formatting hides the operator precedence. - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" - " 5) {\n" - "}"); - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa <=>\n" - " 5) {\n" - "}"); - - FormatStyle OnePerLine = getLLVMStyle(); - OnePerLine.BinPackParameters = false; - verifyFormat( - "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}", - OnePerLine); - - verifyFormat("int i = someFunction(aaaaaaa, 0)\n" - " .aaa(aaaaaaaaaaaaa) *\n" - " aaaaaaa +\n" - " aaaaaaa;", - getLLVMStyleWithColumns(40)); -} - -TEST_F(FormatTest, ExpressionIndentation) { - verifyFormat("bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb +\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >\n" - " ccccccccccccccccccccccccccccccccccccccccc;"); - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); - verifyFormat("if () {\n" - "} else if (aaaaa && bbbbb > // break\n" - " ccccc) {\n" - "}"); - verifyFormat("if () {\n" - "} else if (aaaaa &&\n" - " bbbbb > // break\n" - " ccccc &&\n" - " ddddd) {\n" - "}"); - - // Presence of a trailing comment used to change indentation of b. - verifyFormat("return aaaaaaaaaaaaaaaaaaa +\n" - " b;\n" - "return aaaaaaaaaaaaaaaaaaa +\n" - " b; //", - getLLVMStyleWithColumns(30)); -} - -TEST_F(FormatTest, ExpressionIndentationBreakingBeforeOperators) { - // Not sure what the best system is here. Like this, the LHS can be found - // immediately above an operator (everything with the same or a higher - // indent). The RHS is aligned right of the operator and so compasses - // everything until something with the same indent as the operator is found. - // FIXME: Is this a good system? - FormatStyle Style = getLLVMStyle(); - Style.BreakBeforeBinaryOperators = FormatStyle::BOS_All; - verifyFormat( - "bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " * bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" - " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" - " && aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " > ccccccccccccccccccccccccccccccccccccccccc;", - Style); - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " == bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", - Style); - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " == bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", - Style); - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", - Style); - verifyFormat("if () {\n" - "} else if (aaaaa\n" - " && bbbbb // break\n" - " > ccccc) {\n" - "}", - Style); - verifyFormat("return (a)\n" - " // comment\n" - " + b;", - Style); - verifyFormat( - "int aaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " * bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" - " + cc;", - Style); - - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " = aaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaa;", - Style); - - // Forced by comments. - verifyFormat( - "unsigned ContentSize =\n" - " sizeof(int16_t) // DWARF ARange version number\n" - " + sizeof(int32_t) // Offset of CU in the .debug_info section\n" - " + sizeof(int8_t) // Pointer Size (in bytes)\n" - " + sizeof(int8_t); // Segment Size (in bytes)"); - - verifyFormat("return boost::fusion::at_c<0>(iiii).second\n" - " == boost::fusion::at_c<1>(iiii).second;", - Style); - - Style.ColumnLimit = 60; - verifyFormat("zzzzzzzzzz\n" - " = bbbbbbbbbbbbbbbbb\n" - " >> aaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaa);", - Style); - - Style.ColumnLimit = 80; - Style.IndentWidth = 4; - Style.TabWidth = 4; - Style.UseTab = FormatStyle::UT_Always; - Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; - Style.AlignOperands = false; - EXPECT_EQ("return someVeryVeryLongConditionThatBarelyFitsOnALine\n" - "\t&& (someOtherLongishConditionPart1\n" - "\t\t|| someOtherEvenLongerNestedConditionPart2);", - format("return someVeryVeryLongConditionThatBarelyFitsOnALine && (someOtherLongishConditionPart1 || someOtherEvenLongerNestedConditionPart2);", - Style)); -} - -TEST_F(FormatTest, EnforcedOperatorWraps) { - // Here we'd like to wrap after the || operators, but a comment is forcing an - // earlier wrap. - verifyFormat("bool x = aaaaa //\n" - " || bbbbb\n" - " //\n" - " || cccc;"); -} - -TEST_F(FormatTest, NoOperandAlignment) { - FormatStyle Style = getLLVMStyle(); - Style.AlignOperands = false; - verifyFormat("aaaaaaaaaaaaaa(aaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - Style); - Style.BreakBeforeBinaryOperators = FormatStyle::BOS_NonAssignment; - verifyFormat("bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " * bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" - " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" - " && aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " > ccccccccccccccccccccccccccccccccccccccccc;", - Style); - - verifyFormat("int aaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " * bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" - " + cc;", - Style); - verifyFormat("int a = aa\n" - " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" - " * cccccccccccccccccccccccccccccccccccc;\n", - Style); - - Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; - verifyFormat("return (a > b\n" - " // comment1\n" - " // comment2\n" - " || c);", - Style); -} - -TEST_F(FormatTest, BreakingBeforeNonAssigmentOperators) { - FormatStyle Style = getLLVMStyle(); - Style.BreakBeforeBinaryOperators = FormatStyle::BOS_NonAssignment; - verifyFormat("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;", - Style); -} - -TEST_F(FormatTest, AllowBinPackingInsideArguments) { - FormatStyle Style = getLLVMStyle(); - Style.BreakBeforeBinaryOperators = FormatStyle::BOS_NonAssignment; - Style.BinPackArguments = false; - Style.ColumnLimit = 40; - verifyFormat("void test() {\n" - " someFunction(\n" - " this + argument + is + quite\n" - " + long + so + it + gets + wrapped\n" - " + but + remains + bin - packed);\n" - "}", - Style); - verifyFormat("void test() {\n" - " someFunction(arg1,\n" - " this + argument + is\n" - " + quite + long + so\n" - " + it + gets + wrapped\n" - " + but + remains + bin\n" - " - packed,\n" - " arg3);\n" - "}", - Style); - verifyFormat("void test() {\n" - " someFunction(\n" - " arg1,\n" - " this + argument + has\n" - " + anotherFunc(nested,\n" - " calls + whose\n" - " + arguments\n" - " + are + also\n" - " + wrapped,\n" - " in + addition)\n" - " + to + being + bin - packed,\n" - " arg3);\n" - "}", - Style); - - Style.BreakBeforeBinaryOperators = FormatStyle::BOS_None; - verifyFormat("void test() {\n" - " someFunction(\n" - " arg1,\n" - " this + argument + has +\n" - " anotherFunc(nested,\n" - " calls + whose +\n" - " arguments +\n" - " are + also +\n" - " wrapped,\n" - " in + addition) +\n" - " to + being + bin - packed,\n" - " arg3);\n" - "}", - Style); -} - -TEST_F(FormatTest, ConstructorInitializers) { - verifyFormat("Constructor() : Initializer(FitsOnTheLine) {}"); - verifyFormat("Constructor() : Inttializer(FitsOnTheLine) {}", - getLLVMStyleWithColumns(45)); - verifyFormat("Constructor()\n" - " : Inttializer(FitsOnTheLine) {}", - getLLVMStyleWithColumns(44)); - verifyFormat("Constructor()\n" - " : Inttializer(FitsOnTheLine) {}", - getLLVMStyleWithColumns(43)); - - verifyFormat("template <typename T>\n" - "Constructor() : Initializer(FitsOnTheLine) {}", - getLLVMStyleWithColumns(45)); - - verifyFormat( - "SomeClass::Constructor()\n" - " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}"); - - verifyFormat( - "SomeClass::Constructor()\n" - " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}"); - verifyFormat( - "SomeClass::Constructor()\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}"); - verifyFormat("Constructor(aaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " : aaaaaaaaaa(aaaaaa) {}"); - - verifyFormat("Constructor()\n" - " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaaaaaaaaaa() {}"); - - verifyFormat("Constructor()\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); - - verifyFormat("Constructor(int Parameter = 0)\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaa(aaaaaaaaaaaaaaaaa) {}"); - verifyFormat("Constructor()\n" - " : aaaaaaaaaaaaaaaaaaaa(a), bbbbbbbbbbbbbbbbbbbbbbbb(b) {\n" - "}", - getLLVMStyleWithColumns(60)); - verifyFormat("Constructor()\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa(aaaa, aaaa)) {}"); - - // Here a line could be saved by splitting the second initializer onto two - // lines, but that is not desirable. - verifyFormat("Constructor()\n" - " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaa(aaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaaaaaaaat(aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); - - FormatStyle OnePerLine = getLLVMStyle(); - OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; - OnePerLine.AllowAllParametersOfDeclarationOnNextLine = false; - verifyFormat("SomeClass::Constructor()\n" - " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", - OnePerLine); - verifyFormat("SomeClass::Constructor()\n" - " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), // Some comment\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", - OnePerLine); - verifyFormat("MyClass::MyClass(int var)\n" - " : some_var_(var), // 4 space indent\n" - " some_other_var_(var + 1) { // lined up\n" - "}", - OnePerLine); - verifyFormat("Constructor()\n" - " : aaaaa(aaaaaa),\n" - " aaaaa(aaaaaa),\n" - " aaaaa(aaaaaa),\n" - " aaaaa(aaaaaa),\n" - " aaaaa(aaaaaa) {}", - OnePerLine); - verifyFormat("Constructor()\n" - " : aaaaa(aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaa) {}", - OnePerLine); - OnePerLine.BinPackParameters = false; - verifyFormat( - "Constructor()\n" - " : aaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaa().aaa(),\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}", - OnePerLine); - OnePerLine.ColumnLimit = 60; - verifyFormat("Constructor()\n" - " : aaaaaaaaaaaaaaaaaaaa(a),\n" - " bbbbbbbbbbbbbbbbbbbbbbbb(b) {}", - OnePerLine); - - EXPECT_EQ("Constructor()\n" - " : // Comment forcing unwanted break.\n" - " aaaa(aaaa) {}", - format("Constructor() :\n" - " // Comment forcing unwanted break.\n" - " aaaa(aaaa) {}")); -} - -TEST_F(FormatTest, BreakConstructorInitializersAfterColon) { - FormatStyle Style = getLLVMStyle(); - Style.BreakConstructorInitializers = FormatStyle::BCIS_AfterColon; - - verifyFormat("Constructor() : Initializer(FitsOnTheLine) {}"); - verifyFormat("Constructor() : Initializer(FitsOnTheLine) {}", - getStyleWithColumns(Style, 45)); - verifyFormat("Constructor() :\n" - " Initializer(FitsOnTheLine) {}", - getStyleWithColumns(Style, 44)); - verifyFormat("Constructor() :\n" - " Initializer(FitsOnTheLine) {}", - getStyleWithColumns(Style, 43)); - - verifyFormat("template <typename T>\n" - "Constructor() : Initializer(FitsOnTheLine) {}", - getStyleWithColumns(Style, 50)); - - verifyFormat( - "SomeClass::Constructor() :\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}", - Style); - - verifyFormat( - "SomeClass::Constructor() :\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", - Style); - verifyFormat( - "SomeClass::Constructor() :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}", - Style); - verifyFormat("Constructor(aaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) :\n" - " aaaaaaaaaa(aaaaaa) {}", - Style); - - verifyFormat("Constructor() :\n" - " aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaaaaaaaaaa() {}", - Style); - - verifyFormat("Constructor() :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}", - Style); - - verifyFormat("Constructor(int Parameter = 0) :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaa(aaaaaaaaaaaaaaaaa) {}", - Style); - verifyFormat("Constructor() :\n" - " aaaaaaaaaaaaaaaaaaaaaa(a), bbbbbbbbbbbbbbbbbbbbbbbb(b) {\n" - "}", - getStyleWithColumns(Style, 60)); - verifyFormat("Constructor() :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa(aaaa, aaaa)) {}", - Style); - - // Here a line could be saved by splitting the second initializer onto two - // lines, but that is not desirable. - verifyFormat("Constructor() :\n" - " aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaa(aaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaaaaaaaat(aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}", - Style); - - FormatStyle OnePerLine = Style; - OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; - OnePerLine.AllowAllParametersOfDeclarationOnNextLine = false; - verifyFormat("SomeClass::Constructor() :\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", - OnePerLine); - verifyFormat("SomeClass::Constructor() :\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa), // Some comment\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", - OnePerLine); - verifyFormat("MyClass::MyClass(int var) :\n" - " some_var_(var), // 4 space indent\n" - " some_other_var_(var + 1) { // lined up\n" - "}", - OnePerLine); - verifyFormat("Constructor() :\n" - " aaaaa(aaaaaa),\n" - " aaaaa(aaaaaa),\n" - " aaaaa(aaaaaa),\n" - " aaaaa(aaaaaa),\n" - " aaaaa(aaaaaa) {}", - OnePerLine); - verifyFormat("Constructor() :\n" - " aaaaa(aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaa) {}", - OnePerLine); - OnePerLine.BinPackParameters = false; - verifyFormat( - "Constructor() :\n" - " aaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaa().aaa(),\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}", - OnePerLine); - OnePerLine.ColumnLimit = 60; - verifyFormat("Constructor() :\n" - " aaaaaaaaaaaaaaaaaaaa(a),\n" - " bbbbbbbbbbbbbbbbbbbbbbbb(b) {}", - OnePerLine); - - EXPECT_EQ("Constructor() :\n" - " // Comment forcing unwanted break.\n" - " aaaa(aaaa) {}", - format("Constructor() :\n" - " // Comment forcing unwanted break.\n" - " aaaa(aaaa) {}", - Style)); - - Style.ColumnLimit = 0; - verifyFormat("SomeClass::Constructor() :\n" - " a(a) {}", - Style); - verifyFormat("SomeClass::Constructor() noexcept :\n" - " a(a) {}", - Style); - verifyFormat("SomeClass::Constructor() :\n" - " a(a), b(b), c(c) {}", - Style); - verifyFormat("SomeClass::Constructor() :\n" - " a(a) {\n" - " foo();\n" - " bar();\n" - "}", - Style); - - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; - verifyFormat("SomeClass::Constructor() :\n" - " a(a), b(b), c(c) {\n" - "}", - Style); - verifyFormat("SomeClass::Constructor() :\n" - " a(a) {\n" - "}", - Style); - - Style.ColumnLimit = 80; - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All; - Style.ConstructorInitializerIndentWidth = 2; - verifyFormat("SomeClass::Constructor() : a(a), b(b), c(c) {}", - Style); - verifyFormat("SomeClass::Constructor() :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb {}", - Style); - - // `ConstructorInitializerIndentWidth` actually applies to InheritanceList as well - Style.BreakInheritanceList = FormatStyle::BILS_BeforeColon; - verifyFormat("class SomeClass\n" - " : public aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " public bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb {};", - Style); - Style.BreakInheritanceList = FormatStyle::BILS_BeforeComma; - verifyFormat("class SomeClass\n" - " : public aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " , public bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb {};", - Style); - Style.BreakInheritanceList = FormatStyle::BILS_AfterColon; - verifyFormat("class SomeClass :\n" - " public aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " public bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb {};", - Style); -} - -#ifndef EXPENSIVE_CHECKS -// Expensive checks enables libstdc++ checking which includes validating the -// state of ranges used in std::priority_queue - this blows out the -// runtime/scalability of the function and makes this test unacceptably slow. -TEST_F(FormatTest, MemoizationTests) { - // This breaks if the memoization lookup does not take \c Indent and - // \c LastSpace into account. - verifyFormat( - "extern CFRunLoopTimerRef\n" - "CFRunLoopTimerCreate(CFAllocatorRef allocato, CFAbsoluteTime fireDate,\n" - " CFTimeInterval interval, CFOptionFlags flags,\n" - " CFIndex order, CFRunLoopTimerCallBack callout,\n" - " CFRunLoopTimerContext *context) {}"); - - // Deep nesting somewhat works around our memoization. - verifyFormat( - "aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" - " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" - " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" - " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" - " aaaaa())))))))))))))))))))))))))))))))))))))));", - getLLVMStyleWithColumns(65)); - verifyFormat( - "aaaaa(\n" - " aaaaa,\n" - " aaaaa(\n" - " aaaaa,\n" - " aaaaa(\n" - " aaaaa,\n" - " aaaaa(\n" - " aaaaa,\n" - " aaaaa(\n" - " aaaaa,\n" - " aaaaa(\n" - " aaaaa,\n" - " aaaaa(\n" - " aaaaa,\n" - " aaaaa(\n" - " aaaaa,\n" - " aaaaa(\n" - " aaaaa,\n" - " aaaaa(\n" - " aaaaa,\n" - " aaaaa(\n" - " aaaaa,\n" - " aaaaa(\n" - " aaaaa,\n" - " aaaaa))))))))))));", - getLLVMStyleWithColumns(65)); - verifyFormat( - "a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(), a), a), a), a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a),\n" - " a)", - getLLVMStyleWithColumns(65)); - - // This test takes VERY long when memoization is broken. - FormatStyle OnePerLine = getLLVMStyle(); - OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; - OnePerLine.BinPackParameters = false; - std::string input = "Constructor()\n" - " : aaaa(a,\n"; - for (unsigned i = 0, e = 80; i != e; ++i) { - input += " a,\n"; - } - input += " a) {}"; - verifyFormat(input, OnePerLine); -} -#endif - -TEST_F(FormatTest, BreaksAsHighAsPossible) { - verifyFormat( - "void f() {\n" - " if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaa && aaaaaaaaaaaaaaaaaaaaaaaaaa) ||\n" - " (bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb && bbbbbbbbbbbbbbbbbbbbbbbbbb))\n" - " f();\n" - "}"); - verifyFormat("if (Intervals[i].getRange().getFirst() <\n" - " Intervals[i - 1].getRange().getLast()) {\n}"); -} - -TEST_F(FormatTest, BreaksFunctionDeclarations) { - // Principially, we break function declarations in a certain order: - // 1) break amongst arguments. - verifyFormat("Aaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccc,\n" - " Cccccccccccccc cccccccccccccc);"); - verifyFormat("template <class TemplateIt>\n" - "SomeReturnType SomeFunction(TemplateIt begin, TemplateIt end,\n" - " TemplateIt *stop) {}"); - - // 2) break after return type. - verifyFormat( - "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - "bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccccccccccccccc);", - getGoogleStyle()); - - // 3) break after (. - verifyFormat( - "Aaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbb(\n" - " Cccccccccccccccccccccccccccccc cccccccccccccccccccccccccccccccc);", - getGoogleStyle()); - - // 4) break before after nested name specifiers. - verifyFormat( - "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - "SomeClasssssssssssssssssssssssssssssssssssssss::\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc);", - getGoogleStyle()); - - // However, there are exceptions, if a sufficient amount of lines can be - // saved. - // FIXME: The precise cut-offs wrt. the number of saved lines might need some - // more adjusting. - verifyFormat("Aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc);"); - verifyFormat( - "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - "bbbbbbbbbbb(Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);", - getGoogleStyle()); - verifyFormat( - "Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc);"); - verifyFormat("Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" - " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" - " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);"); - - // Break after multi-line parameters. - verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " bbbb bbbb);"); - verifyFormat("void SomeLoooooooooooongFunction(\n" - " std::unique_ptr<aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " int bbbbbbbbbbbbb);"); - - // Treat overloaded operators like other functions. - verifyFormat("SomeLoooooooooooooooooooooooooogType\n" - "operator>(const SomeLoooooooooooooooooooooooooogType &other);"); - verifyFormat("SomeLoooooooooooooooooooooooooogType\n" - "operator>>(const SomeLooooooooooooooooooooooooogType &other);"); - verifyFormat("SomeLoooooooooooooooooooooooooogType\n" - "operator<<(const SomeLooooooooooooooooooooooooogType &other);"); - verifyGoogleFormat( - "SomeLoooooooooooooooooooooooooooooogType operator>>(\n" - " const SomeLooooooooogType &a, const SomeLooooooooogType &b);"); - verifyGoogleFormat( - "SomeLoooooooooooooooooooooooooooooogType operator<<(\n" - " const SomeLooooooooogType &a, const SomeLooooooooogType &b);"); - verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa = 1);"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaa\n" - "aaaaaaaaaaaaaaaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaa = 1);"); - verifyGoogleFormat( - "typename aaaaaaaaaa<aaaaaa>::aaaaaaaaaaa\n" - "aaaaaaaaaa<aaaaaa>::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " bool *aaaaaaaaaaaaaaaaaa, bool *aa) {}"); - verifyGoogleFormat( - "template <typename T>\n" - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - "aaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaa);"); - - FormatStyle Style = getLLVMStyle(); - Style.PointerAlignment = FormatStyle::PAS_Left; - verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa* const aaaaaaaaaaaa) {}", - Style); - verifyFormat("void aaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}", - Style); -} - -TEST_F(FormatTest, TrailingReturnType) { - verifyFormat("auto foo() -> int;\n"); - verifyFormat("struct S {\n" - " auto bar() const -> int;\n" - "};"); - verifyFormat("template <size_t Order, typename T>\n" - "auto load_img(const std::string &filename)\n" - " -> alias::tensor<Order, T, mem::tag::cpu> {}"); - verifyFormat("auto SomeFunction(A aaaaaaaaaaaaaaaaaaaaa) const\n" - " -> decltype(f(aaaaaaaaaaaaaaaaaaaaa)) {}"); - verifyFormat("auto doSomething(Aaaaaa *aaaaaa) -> decltype(aaaaaa->f()) {}"); - verifyFormat("template <typename T>\n" - "auto aaaaaaaaaaaaaaaaaaaaaa(T t)\n" - " -> decltype(eaaaaaaaaaaaaaaa<T>(t.a).aaaaaaaa());"); - - // Not trailing return types. - verifyFormat("void f() { auto a = b->c(); }"); -} - -TEST_F(FormatTest, BreaksFunctionDeclarationsWithTrailingTokens) { - // Avoid breaking before trailing 'const' or other trailing annotations, if - // they are not function-like. - FormatStyle Style = getGoogleStyle(); - Style.ColumnLimit = 47; - verifyFormat("void someLongFunction(\n" - " int someLoooooooooooooongParameter) const {\n}", - getLLVMStyleWithColumns(47)); - verifyFormat("LoooooongReturnType\n" - "someLoooooooongFunction() const {}", - getLLVMStyleWithColumns(47)); - verifyFormat("LoooooongReturnType someLoooooooongFunction()\n" - " const {}", - Style); - verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" - " aaaaa aaaaaaaaaaaaaaaaaaaa) OVERRIDE;"); - verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" - " aaaaa aaaaaaaaaaaaaaaaaaaa) OVERRIDE FINAL;"); - verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" - " aaaaa aaaaaaaaaaaaaaaaaaaa) override final;"); - verifyFormat("virtual void aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaa aaaa,\n" - " aaaaaaaaaaa aaaaa) const override;"); - verifyGoogleFormat( - "virtual void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()\n" - " const override;"); - - // Even if the first parameter has to be wrapped. - verifyFormat("void someLongFunction(\n" - " int someLongParameter) const {}", - getLLVMStyleWithColumns(46)); - verifyFormat("void someLongFunction(\n" - " int someLongParameter) const {}", - Style); - verifyFormat("void someLongFunction(\n" - " int someLongParameter) override {}", - Style); - verifyFormat("void someLongFunction(\n" - " int someLongParameter) OVERRIDE {}", - Style); - verifyFormat("void someLongFunction(\n" - " int someLongParameter) final {}", - Style); - verifyFormat("void someLongFunction(\n" - " int someLongParameter) FINAL {}", - Style); - verifyFormat("void someLongFunction(\n" - " int parameter) const override {}", - Style); - - Style.BreakBeforeBraces = FormatStyle::BS_Allman; - verifyFormat("void someLongFunction(\n" - " int someLongParameter) const\n" - "{\n" - "}", - Style); - - // Unless these are unknown annotations. - verifyFormat("void SomeFunction(aaaaaaaaaa aaaaaaaaaaaaaaa,\n" - " aaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " LONG_AND_UGLY_ANNOTATION;"); - - // Breaking before function-like trailing annotations is fine to keep them - // close to their arguments. - verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " LOCKS_EXCLUDED(aaaaaaaaaaaaa);"); - verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n" - " LOCKS_EXCLUDED(aaaaaaaaaaaaa);"); - verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n" - " LOCKS_EXCLUDED(aaaaaaaaaaaaa) {}"); - verifyGoogleFormat("void aaaaaaaaaaaaaa(aaaaaaaa aaa) override\n" - " AAAAAAAAAAAAAAAAAAAAAAAA(aaaaaaaaaaaaaaa);"); - verifyFormat("SomeFunction([](int i) LOCKS_EXCLUDED(a) {});"); - - verifyFormat( - "void aaaaaaaaaaaaaaaaaa()\n" - " __attribute__((aaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa));"); - verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " __attribute__((unused));"); - verifyGoogleFormat( - "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " GUARDED_BY(aaaaaaaaaaaa);"); - verifyGoogleFormat( - "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " GUARDED_BY(aaaaaaaaaaaa);"); - verifyGoogleFormat( - "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa GUARDED_BY(aaaaaaaaaaaa) =\n" - " aaaaaaaa::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyGoogleFormat( - "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa GUARDED_BY(aaaaaaaaaaaa) =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa;"); -} - -TEST_F(FormatTest, FunctionAnnotations) { - verifyFormat("DEPRECATED(\"Use NewClass::NewFunction instead.\")\n" - "int OldFunction(const string ¶meter) {}"); - verifyFormat("DEPRECATED(\"Use NewClass::NewFunction instead.\")\n" - "string OldFunction(const string ¶meter) {}"); - verifyFormat("template <typename T>\n" - "DEPRECATED(\"Use NewClass::NewFunction instead.\")\n" - "string OldFunction(const string ¶meter) {}"); - - // Not function annotations. - verifyFormat("ASSERT(\"aaaaa\") << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"); - verifyFormat("TEST_F(ThisIsATestFixtureeeeeeeeeeeee,\n" - " ThisIsATestWithAReallyReallyReallyReallyLongName) {}"); - verifyFormat("MACRO(abc).function() // wrap\n" - " << abc;"); - verifyFormat("MACRO(abc)->function() // wrap\n" - " << abc;"); - verifyFormat("MACRO(abc)::function() // wrap\n" - " << abc;"); -} - -TEST_F(FormatTest, BreaksDesireably) { - verifyFormat("if (aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n" - " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n" - " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa)) {\n}"); - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)) {\n" - "}"); - - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); - - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); - - verifyFormat( - "aaaaaaaa(aaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n" - " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));"); - - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" - " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - - verifyFormat( - "void f() {\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" - "}"); - verifyFormat( - "aaaaaa(new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); - verifyFormat( - "aaaaaa(aaa, new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); - verifyFormat( - "aaaaaa(aaa,\n" - " new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaa);"); - verifyFormat("aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - - // Indent consistently independent of call expression and unary operator. - verifyFormat("aaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" - " dddddddddddddddddddddddddddddd));"); - verifyFormat("aaaaaaaaaaa(!bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" - " dddddddddddddddddddddddddddddd));"); - verifyFormat("aaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbb.ccccccccccccccccc(\n" - " dddddddddddddddddddddddddddddd));"); - - // This test case breaks on an incorrect memoization, i.e. an optimization not - // taking into account the StopAt value. - verifyFormat( - "return aaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n" - " aaaaaaaaaaa(aaaaaaaaa) || aaaaaaaaaaaaaaaaaaaaaaa ||\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n" - " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - - verifyFormat("{\n {\n {\n" - " Annotation.SpaceRequiredBefore =\n" - " Line.Tokens[i - 1].Tok.isNot(tok::l_paren) &&\n" - " Line.Tokens[i - 1].Tok.isNot(tok::l_square);\n" - " }\n }\n}"); - - // Break on an outer level if there was a break on an inner level. - EXPECT_EQ("f(g(h(a, // comment\n" - " b, c),\n" - " d, e),\n" - " x, y);", - format("f(g(h(a, // comment\n" - " b, c), d, e), x, y);")); - - // Prefer breaking similar line breaks. - verifyFormat( - "const int kTrackingOptions = NSTrackingMouseMoved |\n" - " NSTrackingMouseEnteredAndExited |\n" - " NSTrackingActiveAlways;"); -} - -TEST_F(FormatTest, FormatsDeclarationsOnePerLine) { - FormatStyle NoBinPacking = getGoogleStyle(); - NoBinPacking.BinPackParameters = false; - NoBinPacking.BinPackArguments = true; - verifyFormat("void f() {\n" - " f(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" - "}", - NoBinPacking); - verifyFormat("void f(int aaaaaaaaaaaaaaaaaaaa,\n" - " int aaaaaaaaaaaaaaaaaaaa,\n" - " int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}", - NoBinPacking); - - NoBinPacking.AllowAllParametersOfDeclarationOnNextLine = false; - verifyFormat("void aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " vector<int> bbbbbbbbbbbbbbb);", - NoBinPacking); - // FIXME: This behavior difference is probably not wanted. However, currently - // we cannot distinguish BreakBeforeParameter being set because of the wrapped - // template arguments from BreakBeforeParameter being set because of the - // one-per-line formatting. - verifyFormat( - "void fffffffffff(aaaaaaaaaaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaa> aaaaaaaaaa);", - NoBinPacking); - verifyFormat( - "void fffffffffff(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaa>\n" - " aaaaaaaaaa);"); -} - -TEST_F(FormatTest, FormatsOneParameterPerLineIfNecessary) { - FormatStyle NoBinPacking = getGoogleStyle(); - NoBinPacking.BinPackParameters = false; - NoBinPacking.BinPackArguments = false; - verifyFormat("f(aaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaa);", - NoBinPacking); - verifyFormat("aaaaaaa(aaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));", - NoBinPacking); - verifyFormat( - "aaaaaaaa(aaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n" - " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));", - NoBinPacking); - verifyFormat("aaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n" - " .aaaaaaaaaaaaaaaaaa();", - NoBinPacking); - verifyFormat("void f() {\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaaa);\n" - "}", - NoBinPacking); - - verifyFormat( - "aaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaa,\n" - " aaaaaaaaaaaa);", - NoBinPacking); - verifyFormat( - "somefunction(someotherFunction(ddddddddddddddddddddddddddddddddddd,\n" - " ddddddddddddddddddddddddddddd),\n" - " test);", - NoBinPacking); - - verifyFormat("std::vector<aaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaa>\n" - " aaaaaaaaaaaaaaaaaa;", - NoBinPacking); - verifyFormat("a(\"a\"\n" - " \"a\",\n" - " a);"); - - NoBinPacking.AllowAllParametersOfDeclarationOnNextLine = false; - verifyFormat("void aaaaaaaaaa(aaaaaaaaa,\n" - " aaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - NoBinPacking); - verifyFormat( - "void f() {\n" - " aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n" - " .aaaaaaa();\n" - "}", - NoBinPacking); - verifyFormat( - "template <class SomeType, class SomeOtherType>\n" - "SomeType SomeFunction(SomeType Type, SomeOtherType OtherType) {}", - NoBinPacking); -} - -TEST_F(FormatTest, AdaptiveOnePerLineFormatting) { - FormatStyle Style = getLLVMStyleWithColumns(15); - Style.ExperimentalAutoDetectBinPacking = true; - EXPECT_EQ("aaa(aaaa,\n" - " aaaa,\n" - " aaaa);\n" - "aaa(aaaa,\n" - " aaaa,\n" - " aaaa);", - format("aaa(aaaa,\n" // one-per-line - " aaaa,\n" - " aaaa );\n" - "aaa(aaaa, aaaa, aaaa);", // inconclusive - Style)); - EXPECT_EQ("aaa(aaaa, aaaa,\n" - " aaaa);\n" - "aaa(aaaa, aaaa,\n" - " aaaa);", - format("aaa(aaaa, aaaa,\n" // bin-packed - " aaaa );\n" - "aaa(aaaa, aaaa, aaaa);", // inconclusive - Style)); -} - -TEST_F(FormatTest, FormatsBuilderPattern) { - verifyFormat("return llvm::StringSwitch<Reference::Kind>(name)\n" - " .StartsWith(\".eh_frame_hdr\", ORDER_EH_FRAMEHDR)\n" - " .StartsWith(\".eh_frame\", ORDER_EH_FRAME)\n" - " .StartsWith(\".init\", ORDER_INIT)\n" - " .StartsWith(\".fini\", ORDER_FINI)\n" - " .StartsWith(\".hash\", ORDER_HASH)\n" - " .Default(ORDER_TEXT);\n"); - - verifyFormat("return aaaaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa() <\n" - " aaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa();"); - verifyFormat( - "aaaaaaa->aaaaaaa\n" - " ->aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " ->aaaaaaaa(aaaaaaaaaaaaaaa);"); - verifyFormat( - "aaaaaaa->aaaaaaa\n" - " ->aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " ->aaaaaaaa(aaaaaaaaaaaaaaa);"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaa()->aaaaaa(bbbbb)->aaaaaaaaaaaaaaaaaaa( // break\n" - " aaaaaaaaaaaaaa);"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaa *aaaaaaaaa =\n" - " aaaaaa->aaaaaaaaaaaa()\n" - " ->aaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " ->aaaaaaaaaaaaaaaaa();"); - verifyGoogleFormat( - "void f() {\n" - " someo->Add((new util::filetools::Handler(dir))\n" - " ->OnEvent1(NewPermanentCallback(\n" - " this, &HandlerHolderClass::EventHandlerCBA))\n" - " ->OnEvent2(NewPermanentCallback(\n" - " this, &HandlerHolderClass::EventHandlerCBB))\n" - " ->OnEvent3(NewPermanentCallback(\n" - " this, &HandlerHolderClass::EventHandlerCBC))\n" - " ->OnEvent5(NewPermanentCallback(\n" - " this, &HandlerHolderClass::EventHandlerCBD))\n" - " ->OnEvent6(NewPermanentCallback(\n" - " this, &HandlerHolderClass::EventHandlerCBE)));\n" - "}"); - - verifyFormat( - "aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa();"); - verifyFormat("aaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaa();"); - verifyFormat("aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaa();"); - verifyFormat("aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaa();"); - verifyFormat("aaaaaaaaaaaaa->aaaaaaaaaaaaaaaaaaaaaaaa()\n" - " ->aaaaaaaaaaaaaae(0)\n" - " ->aaaaaaaaaaaaaaa();"); - - // Don't linewrap after very short segments. - verifyFormat("a().aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); - verifyFormat("aa().aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); - verifyFormat("aaa()\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); - - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaa()\n" - " .has<bbbbbbbbbbbbbbbbbbbbb>();"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>();"); - - // Prefer not to break after empty parentheses. - verifyFormat("FirstToken->WhitespaceRange.getBegin().getLocWithOffset(\n" - " First->LastNewlineOffset);"); - - // Prefer not to create "hanging" indents. - verifyFormat( - "return !soooooooooooooome_map\n" - " .insert(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " .second;"); - verifyFormat( - "return aaaaaaaaaaaaaaaa\n" - " .aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa)\n" - " .aaaa(aaaaaaaaaaaaaa);"); - // No hanging indent here. - verifyFormat("aaaaaaaaaaaaaaaa.aaaaaaaaaaaaaa.aaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("aaaaaaaaaaaaaaaa.aaaaaaaaaaaaaa().aaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("aaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa)\n" - " .aaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - getLLVMStyleWithColumns(60)); - verifyFormat("aaaaaaaaaaaaaaaaaa\n" - " .aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa)\n" - " .aaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - getLLVMStyleWithColumns(59)); - verifyFormat("aaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " .aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - - // Dont break if only closing statements before member call - verifyFormat("test() {\n" - " ([]() -> {\n" - " int b = 32;\n" - " return 3;\n" - " }).foo();\n" - "}"); - verifyFormat("test() {\n" - " (\n" - " []() -> {\n" - " int b = 32;\n" - " return 3;\n" - " },\n" - " foo, bar)\n" - " .foo();\n" - "}"); - verifyFormat("test() {\n" - " ([]() -> {\n" - " int b = 32;\n" - " return 3;\n" - " })\n" - " .foo()\n" - " .bar();\n" - "}"); - verifyFormat("test() {\n" - " ([]() -> {\n" - " int b = 32;\n" - " return 3;\n" - " })\n" - " .foo(\"aaaaaaaaaaaaaaaaa\"\n" - " \"bbbb\");\n" - "}", - getLLVMStyleWithColumns(30)); -} - -TEST_F(FormatTest, BreaksAccordingToOperatorPrecedence) { - verifyFormat( - "if (aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" - " bbbbbbbbbbbbbbbbbbbbbbbbb && ccccccccccccccccccccccccc) {\n}"); - verifyFormat( - "if (aaaaaaaaaaaaaaaaaaaaaaaaa or\n" - " bbbbbbbbbbbbbbbbbbbbbbbbb and cccccccccccccccccccccccc) {\n}"); - - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa && bbbbbbbbbbbbbbbbbbbbbbbbb ||\n" - " ccccccccccccccccccccccccc) {\n}"); - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa and bbbbbbbbbbbbbbbbbbbbbbbb or\n" - " ccccccccccccccccccccccccc) {\n}"); - - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb ||\n" - " ccccccccccccccccccccccccc) {\n}"); - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa or bbbbbbbbbbbbbbbbbbbbbbbbb or\n" - " ccccccccccccccccccccccccc) {\n}"); - - verifyFormat( - "if ((aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb) &&\n" - " ccccccccccccccccccccccccc) {\n}"); - verifyFormat( - "if ((aaaaaaaaaaaaaaaaaaaaaaaaa or bbbbbbbbbbbbbbbbbbbbbbbbb) and\n" - " ccccccccccccccccccccccccc) {\n}"); - - verifyFormat("return aaaa & AAAAAAAAAAAAAAAAAAAAAAAAAAAAA ||\n" - " bbbb & BBBBBBBBBBBBBBBBBBBBBBBBBBBBB ||\n" - " cccc & CCCCCCCCCCCCCCCCCCCCCCCCCC ||\n" - " dddd & DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD;"); - verifyFormat("return aaaa & AAAAAAAAAAAAAAAAAAAAAAAAAAAAA or\n" - " bbbb & BBBBBBBBBBBBBBBBBBBBBBBBBBBBB or\n" - " cccc & CCCCCCCCCCCCCCCCCCCCCCCCCC or\n" - " dddd & DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD;"); - - verifyFormat("if ((aaaaaaaaaa != aaaaaaaaaaaaaaa ||\n" - " aaaaaaaaaaaaaaaaaaaaaaaa() >= aaaaaaaaaaaaaaaaaaaa) &&\n" - " aaaaaaaaaaaaaaa != aa) {\n}"); - verifyFormat("if ((aaaaaaaaaa != aaaaaaaaaaaaaaa or\n" - " aaaaaaaaaaaaaaaaaaaaaaaa() >= aaaaaaaaaaaaaaaaaaaa) and\n" - " aaaaaaaaaaaaaaa != aa) {\n}"); -} - -TEST_F(FormatTest, BreaksAfterAssignments) { - verifyFormat( - "unsigned Cost =\n" - " TTI.getMemoryOpCost(I->getOpcode(), VectorTy, SI->getAlignment(),\n" - " SI->getPointerAddressSpaceee());\n"); - verifyFormat( - "CharSourceRange LineRange = CharSourceRange::getTokenRange(\n" - " Line.Tokens.front().Tok.getLo(), Line.Tokens.back().Tok.getLoc());"); - - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaa = aaaaaaaaaaaaaa(0).aaaa().aaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("unsigned OriginalStartColumn =\n" - " SourceMgr.getSpellingColumnNumber(\n" - " Current.FormatTok.getStartOfNonWhitespace()) -\n" - " 1;"); -} - -TEST_F(FormatTest, ConfigurableBreakAssignmentPenalty) { - FormatStyle Style = getLLVMStyle(); - verifyFormat("int aaaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbb + cccccccccccccccccccccccccc;", - Style); - - Style.PenaltyBreakAssignment = 20; - verifyFormat("int aaaaaaaaaaaaaaaaaaaaaaaaaa = bbbbbbbbbbbbbbbbbbbbbbbbbb +\n" - " cccccccccccccccccccccccccc;", - Style); -} - -TEST_F(FormatTest, AlignsAfterAssignments) { - verifyFormat( - "int Result = aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat( - "Result += aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat( - "Result >>= aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat( - "int Result = (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat( - "double LooooooooooooooooooooooooongResult = aaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaa;"); -} - -TEST_F(FormatTest, AlignsAfterReturn) { - verifyFormat( - "return aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat( - "return (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat( - "return aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n" - " aaaaaaaaaaaaaaaaaaaaaa();"); - verifyFormat( - "return (aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n" - " aaaaaaaaaaaaaaaaaaaaaa());"); - verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) &&\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat("return\n" - " // true if code is one of a or b.\n" - " code == a || code == b;"); -} - -TEST_F(FormatTest, AlignsAfterOpenBracket) { - verifyFormat( - "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaa aaaaaaaa,\n" - " aaaaaaaaa aaaaaaa) {}"); - verifyFormat( - "SomeLongVariableName->someVeryLongFunctionName(aaaaaaaaaaa aaaaaaaaa,\n" - " aaaaaaaaaaa aaaaaaaaa);"); - verifyFormat( - "SomeLongVariableName->someFunction(foooooooo(aaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaa));"); - FormatStyle Style = getLLVMStyle(); - Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; - verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaa aaaaaaaa, aaaaaaaaa aaaaaaa) {}", - Style); - verifyFormat("SomeLongVariableName->someVeryLongFunctionName(\n" - " aaaaaaaaaaa aaaaaaaaa, aaaaaaaaaaa aaaaaaaaa);", - Style); - verifyFormat("SomeLongVariableName->someFunction(\n" - " foooooooo(aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa));", - Style); - verifyFormat( - "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaa aaaaaaaa,\n" - " aaaaaaaaa aaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}", - Style); - verifyFormat( - "SomeLongVariableName->someVeryLongFunctionName(aaaaaaaaaaa aaaaaaaaa,\n" - " aaaaaaaaaaa aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - Style); - verifyFormat( - "SomeLongVariableName->someFunction(foooooooo(aaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa));", - Style); - - verifyFormat("bbbbbbbbbbbb(aaaaaaaaaaaaaaaaaaaaaaaa, //\n" - " ccccccc(aaaaaaaaaaaaaaaaa, //\n" - " b));", - Style); - - Style.AlignAfterOpenBracket = FormatStyle::BAS_AlwaysBreak; - Style.BinPackArguments = false; - Style.BinPackParameters = false; - verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaa aaaaaaaa,\n" - " aaaaaaaaa aaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}", - Style); - verifyFormat("SomeLongVariableName->someVeryLongFunctionName(\n" - " aaaaaaaaaaa aaaaaaaaa,\n" - " aaaaaaaaaaa aaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - Style); - verifyFormat("SomeLongVariableName->someFunction(foooooooo(\n" - " aaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa));", - Style); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa)));", - Style); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaa.aaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa)));", - Style); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa)),\n" - " aaaaaaaaaaaaaaaa);", - Style); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa)) &&\n" - " aaaaaaaaaaaaaaaa);", - Style); -} - -TEST_F(FormatTest, ParenthesesAndOperandAlignment) { - FormatStyle Style = getLLVMStyleWithColumns(40); - verifyFormat("int a = f(aaaaaaaaaaaaaaaaaaaaaa &&\n" - " bbbbbbbbbbbbbbbbbbbbbb);", - Style); - Style.AlignAfterOpenBracket = FormatStyle::BAS_Align; - Style.AlignOperands = false; - verifyFormat("int a = f(aaaaaaaaaaaaaaaaaaaaaa &&\n" - " bbbbbbbbbbbbbbbbbbbbbb);", - Style); - Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; - Style.AlignOperands = true; - verifyFormat("int a = f(aaaaaaaaaaaaaaaaaaaaaa &&\n" - " bbbbbbbbbbbbbbbbbbbbbb);", - Style); - Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; - Style.AlignOperands = false; - verifyFormat("int a = f(aaaaaaaaaaaaaaaaaaaaaa &&\n" - " bbbbbbbbbbbbbbbbbbbbbb);", - Style); -} - -TEST_F(FormatTest, BreaksConditionalExpressions) { - verifyFormat( - "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat( - "aaaa(aaaaaaaaaa, aaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat( - "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat( - "aaaa(aaaaaaaaa, aaaaaaaaa,\n" - " aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa)\n" - " : aaaaaaaaaaaaa);"); - verifyFormat( - "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaa);"); - verifyFormat( - "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaa ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaa);"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " ? aaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " : aaaaaaaaaaaaaaaa;"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " ? aaaaaaaaaaaaaaa\n" - " : aaaaaaaaaaaaaaa;"); - verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n" - " aaaaaaaaa\n" - " ? b\n" - " : c);"); - verifyFormat("return aaaa == bbbb\n" - " // comment\n" - " ? aaaa\n" - " : bbbb;"); - verifyFormat("unsigned Indent =\n" - " format(TheLine.First,\n" - " IndentForLevel[TheLine.Level] >= 0\n" - " ? IndentForLevel[TheLine.Level]\n" - " : TheLine * 2,\n" - " TheLine.InPPDirective, PreviousEndOfLineColumn);", - getLLVMStyleWithColumns(60)); - verifyFormat("bool aaaaaa = aaaaaaaaaaaaa //\n" - " ? aaaaaaaaaaaaaaa\n" - " : bbbbbbbbbbbbbbb //\n" - " ? ccccccccccccccc\n" - " : ddddddddddddddd;"); - verifyFormat("bool aaaaaa = aaaaaaaaaaaaa //\n" - " ? aaaaaaaaaaaaaaa\n" - " : (bbbbbbbbbbbbbbb //\n" - " ? ccccccccccccccc\n" - " : ddddddddddddddd);"); - verifyFormat( - "int aaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " ? aaaaaaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaa +\n" - " aaaaaaaaaaaaaaaaaaaaa\n" - " : aaaaaaaaaa;"); - verifyFormat( - "aaaaaa = aaaaaaaaaaaa ? aaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " : aaaaaaaaaaaaaaaaaaaaaa\n" - " : aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - - FormatStyle NoBinPacking = getLLVMStyle(); - NoBinPacking.BinPackArguments = false; - verifyFormat( - "void f() {\n" - " g(aaa,\n" - " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " ? aaaaaaaaaaaaaaa\n" - " : aaaaaaaaaaaaaaa);\n" - "}", - NoBinPacking); - verifyFormat( - "void f() {\n" - " g(aaa,\n" - " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " ?: aaaaaaaaaaaaaaa);\n" - "}", - NoBinPacking); - - verifyFormat("SomeFunction(aaaaaaaaaaaaaaaaa,\n" - " // comment.\n" - " ccccccccccccccccccccccccccccccccccccccc\n" - " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " : bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb);"); - - // Assignments in conditional expressions. Apparently not uncommon :-(. - verifyFormat("return a != b\n" - " // comment\n" - " ? a = b\n" - " : a = b;"); - verifyFormat("return a != b\n" - " // comment\n" - " ? a = a != b\n" - " // comment\n" - " ? a = b\n" - " : a\n" - " : a;\n"); - verifyFormat("return a != b\n" - " // comment\n" - " ? a\n" - " : a = a != b\n" - " // comment\n" - " ? a = b\n" - " : a;"); -} - -TEST_F(FormatTest, BreaksConditionalExpressionsAfterOperator) { - FormatStyle Style = getLLVMStyle(); - Style.BreakBeforeTernaryOperators = false; - Style.ColumnLimit = 70; - verifyFormat( - "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - Style); - verifyFormat( - "aaaa(aaaaaaaaaa, aaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - Style); - verifyFormat( - "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - Style); - verifyFormat( - "aaaa(aaaaaaaa, aaaaaaaaaa,\n" - " aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - Style); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa) :\n" - " aaaaaaaaaaaaa);", - Style); - verifyFormat( - "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaa);", - Style); - verifyFormat( - "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaa ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaa);", - Style); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - Style); - verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa);", - Style); - verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?:\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa);", - Style); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa;", - Style); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;", - Style); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" - " aaaaaaaaaaaaaaa :\n" - " aaaaaaaaaaaaaaa;", - Style); - verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n" - " aaaaaaaaa ?\n" - " b :\n" - " c);", - Style); - verifyFormat("unsigned Indent =\n" - " format(TheLine.First,\n" - " IndentForLevel[TheLine.Level] >= 0 ?\n" - " IndentForLevel[TheLine.Level] :\n" - " TheLine * 2,\n" - " TheLine.InPPDirective, PreviousEndOfLineColumn);", - Style); - verifyFormat("bool aaaaaa = aaaaaaaaaaaaa ? //\n" - " aaaaaaaaaaaaaaa :\n" - " bbbbbbbbbbbbbbb ? //\n" - " ccccccccccccccc :\n" - " ddddddddddddddd;", - Style); - verifyFormat("bool aaaaaa = aaaaaaaaaaaaa ? //\n" - " aaaaaaaaaaaaaaa :\n" - " (bbbbbbbbbbbbbbb ? //\n" - " ccccccccccccccc :\n" - " ddddddddddddddd);", - Style); - verifyFormat("int i = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" - " /*bbbbbbbbbbbbbbb=*/bbbbbbbbbbbbbbbbbbbbbbbbb :\n" - " ccccccccccccccccccccccccccc;", - Style); - verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" - " aaaaa :\n" - " bbbbbbbbbbbbbbb + cccccccccccccccc;", - Style); -} - -TEST_F(FormatTest, DeclarationsOfMultipleVariables) { - verifyFormat("bool aaaaaaaaaaaaaaaaa = aaaaaa->aaaaaaaaaaaaaaaaa(),\n" - " aaaaaaaaaaa = aaaaaa->aaaaaaaaaaa();"); - verifyFormat("bool a = true, b = false;"); - - verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa),\n" - " bbbbbbbbbbbbbbbbbbbbbbbbb =\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(bbbbbbbbbbbbbbbb);"); - verifyFormat( - "bool aaaaaaaaaaaaaaaaaaaaa =\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbb && cccccccccccccccccccccccccccc,\n" - " d = e && f;"); - verifyFormat("aaaaaaaaa a = aaaaaaaaaaaaaaaaaaaa, b = bbbbbbbbbbbbbbbbbbbb,\n" - " c = cccccccccccccccccccc, d = dddddddddddddddddddd;"); - verifyFormat("aaaaaaaaa *a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n" - " *c = ccccccccccccccccccc, *d = ddddddddddddddddddd;"); - verifyFormat("aaaaaaaaa ***a = aaaaaaaaaaaaaaaaaaa, ***b = bbbbbbbbbbbbbbb,\n" - " ***c = ccccccccccccccccccc, ***d = ddddddddddddddd;"); - - FormatStyle Style = getGoogleStyle(); - Style.PointerAlignment = FormatStyle::PAS_Left; - Style.DerivePointerAlignment = false; - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " *aaaaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaa,\n" - " *b = bbbbbbbbbbbbbbbbbbb;", - Style); - verifyFormat("aaaaaaaaa *a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n" - " *b = bbbbbbbbbbbbbbbbbbb, *d = ddddddddddddddddddd;", - Style); - verifyFormat("vector<int*> a, b;", Style); - verifyFormat("for (int *p, *q; p != q; p = p->next) {\n}", Style); -} - -TEST_F(FormatTest, ConditionalExpressionsInBrackets) { - verifyFormat("arr[foo ? bar : baz];"); - verifyFormat("f()[foo ? bar : baz];"); - verifyFormat("(a + b)[foo ? bar : baz];"); - verifyFormat("arr[foo ? (4 > 5 ? 4 : 5) : 5 < 5 ? 5 : 7];"); -} - -TEST_F(FormatTest, AlignsStringLiterals) { - verifyFormat("loooooooooooooooooooooooooongFunction(\"short literal \"\n" - " \"short literal\");"); - verifyFormat( - "looooooooooooooooooooooooongFunction(\n" - " \"short literal\"\n" - " \"looooooooooooooooooooooooooooooooooooooooooooooooong literal\");"); - verifyFormat("someFunction(\"Always break between multi-line\"\n" - " \" string literals\",\n" - " and, other, parameters);"); - EXPECT_EQ("fun + \"1243\" /* comment */\n" - " \"5678\";", - format("fun + \"1243\" /* comment */\n" - " \"5678\";", - getLLVMStyleWithColumns(28))); - EXPECT_EQ( - "aaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" - " \"aaaaaaaaaaaaaaaaaaaaa\"\n" - " \"aaaaaaaaaaaaaaaa\";", - format("aaaaaa =" - "\"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa " - "aaaaaaaaaaaaaaaaaaaaa\" " - "\"aaaaaaaaaaaaaaaa\";")); - verifyFormat("a = a + \"a\"\n" - " \"a\"\n" - " \"a\";"); - verifyFormat("f(\"a\", \"b\"\n" - " \"c\");"); - - verifyFormat( - "#define LL_FORMAT \"ll\"\n" - "printf(\"aaaaa: %d, bbbbbb: %\" LL_FORMAT \"d, cccccccc: %\" LL_FORMAT\n" - " \"d, ddddddddd: %\" LL_FORMAT \"d\");"); - - verifyFormat("#define A(X) \\\n" - " \"aaaaa\" #X \"bbbbbb\" \\\n" - " \"ccccc\"", - getLLVMStyleWithColumns(23)); - verifyFormat("#define A \"def\"\n" - "f(\"abc\" A \"ghi\"\n" - " \"jkl\");"); - - verifyFormat("f(L\"a\"\n" - " L\"b\");"); - verifyFormat("#define A(X) \\\n" - " L\"aaaaa\" #X L\"bbbbbb\" \\\n" - " L\"ccccc\"", - getLLVMStyleWithColumns(25)); - - verifyFormat("f(@\"a\"\n" - " @\"b\");"); - verifyFormat("NSString s = @\"a\"\n" - " @\"b\"\n" - " @\"c\";"); - verifyFormat("NSString s = @\"a\"\n" - " \"b\"\n" - " \"c\";"); -} - -TEST_F(FormatTest, ReturnTypeBreakingStyle) { - FormatStyle Style = getLLVMStyle(); - // No declarations or definitions should be moved to own line. - Style.AlwaysBreakAfterReturnType = FormatStyle::RTBS_None; - verifyFormat("class A {\n" - " int f() { return 1; }\n" - " int g();\n" - "};\n" - "int f() { return 1; }\n" - "int g();\n", - Style); - - // All declarations and definitions should have the return type moved to its - // own - // line. - Style.AlwaysBreakAfterReturnType = FormatStyle::RTBS_All; - verifyFormat("class E {\n" - " int\n" - " f() {\n" - " return 1;\n" - " }\n" - " int\n" - " g();\n" - "};\n" - "int\n" - "f() {\n" - " return 1;\n" - "}\n" - "int\n" - "g();\n", - Style); - - // Top-level definitions, and no kinds of declarations should have the - // return type moved to its own line. - Style.AlwaysBreakAfterReturnType = FormatStyle::RTBS_TopLevelDefinitions; - verifyFormat("class B {\n" - " int f() { return 1; }\n" - " int g();\n" - "};\n" - "int\n" - "f() {\n" - " return 1;\n" - "}\n" - "int g();\n", - Style); - - // Top-level definitions and declarations should have the return type moved - // to its own line. - Style.AlwaysBreakAfterReturnType = FormatStyle::RTBS_TopLevel; - verifyFormat("class C {\n" - " int f() { return 1; }\n" - " int g();\n" - "};\n" - "int\n" - "f() {\n" - " return 1;\n" - "}\n" - "int\n" - "g();\n", - Style); - - // All definitions should have the return type moved to its own line, but no - // kinds of declarations. - Style.AlwaysBreakAfterReturnType = FormatStyle::RTBS_AllDefinitions; - verifyFormat("class D {\n" - " int\n" - " f() {\n" - " return 1;\n" - " }\n" - " int g();\n" - "};\n" - "int\n" - "f() {\n" - " return 1;\n" - "}\n" - "int g();\n", - Style); - verifyFormat("const char *\n" - "f(void) {\n" // Break here. - " return \"\";\n" - "}\n" - "const char *bar(void);\n", // No break here. - Style); - verifyFormat("template <class T>\n" - "T *\n" - "f(T &c) {\n" // Break here. - " return NULL;\n" - "}\n" - "template <class T> T *f(T &c);\n", // No break here. - Style); - verifyFormat("class C {\n" - " int\n" - " operator+() {\n" - " return 1;\n" - " }\n" - " int\n" - " operator()() {\n" - " return 1;\n" - " }\n" - "};\n", - Style); - verifyFormat("void\n" - "A::operator()() {}\n" - "void\n" - "A::operator>>() {}\n" - "void\n" - "A::operator+() {}\n", - Style); - verifyFormat("void *operator new(std::size_t s);", // No break here. - Style); - verifyFormat("void *\n" - "operator new(std::size_t s) {}", - Style); - verifyFormat("void *\n" - "operator delete[](void *ptr) {}", - Style); - Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup; - verifyFormat("const char *\n" - "f(void)\n" // Break here. - "{\n" - " return \"\";\n" - "}\n" - "const char *bar(void);\n", // No break here. - Style); - verifyFormat("template <class T>\n" - "T *\n" // Problem here: no line break - "f(T &c)\n" // Break here. - "{\n" - " return NULL;\n" - "}\n" - "template <class T> T *f(T &c);\n", // No break here. - Style); -} - -TEST_F(FormatTest, AlwaysBreakBeforeMultilineStrings) { - FormatStyle NoBreak = getLLVMStyle(); - NoBreak.AlwaysBreakBeforeMultilineStrings = false; - FormatStyle Break = getLLVMStyle(); - Break.AlwaysBreakBeforeMultilineStrings = true; - verifyFormat("aaaa = \"bbbb\"\n" - " \"cccc\";", - NoBreak); - verifyFormat("aaaa =\n" - " \"bbbb\"\n" - " \"cccc\";", - Break); - verifyFormat("aaaa(\"bbbb\"\n" - " \"cccc\");", - NoBreak); - verifyFormat("aaaa(\n" - " \"bbbb\"\n" - " \"cccc\");", - Break); - verifyFormat("aaaa(qqq, \"bbbb\"\n" - " \"cccc\");", - NoBreak); - verifyFormat("aaaa(qqq,\n" - " \"bbbb\"\n" - " \"cccc\");", - Break); - verifyFormat("aaaa(qqq,\n" - " L\"bbbb\"\n" - " L\"cccc\");", - Break); - verifyFormat("aaaaa(aaaaaa, aaaaaaa(\"aaaa\"\n" - " \"bbbb\"));", - Break); - verifyFormat("string s = someFunction(\n" - " \"abc\"\n" - " \"abc\");", - Break); - - // As we break before unary operators, breaking right after them is bad. - verifyFormat("string foo = abc ? \"x\"\n" - " \"blah blah blah blah blah blah\"\n" - " : \"y\";", - Break); - - // Don't break if there is no column gain. - verifyFormat("f(\"aaaa\"\n" - " \"bbbb\");", - Break); - - // Treat literals with escaped newlines like multi-line string literals. - EXPECT_EQ("x = \"a\\\n" - "b\\\n" - "c\";", - format("x = \"a\\\n" - "b\\\n" - "c\";", - NoBreak)); - EXPECT_EQ("xxxx =\n" - " \"a\\\n" - "b\\\n" - "c\";", - format("xxxx = \"a\\\n" - "b\\\n" - "c\";", - Break)); - - EXPECT_EQ("NSString *const kString =\n" - " @\"aaaa\"\n" - " @\"bbbb\";", - format("NSString *const kString = @\"aaaa\"\n" - "@\"bbbb\";", - Break)); - - Break.ColumnLimit = 0; - verifyFormat("const char *hello = \"hello llvm\";", Break); -} - -TEST_F(FormatTest, AlignsPipes) { - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa\n" - " << aaaaaaaaaaaaaaaaaaaa;"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat( - "llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" - " \"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\"\n" - " << \"ccccccccccccccccccccccccccccccccccccccccccccccccc\";"); - verifyFormat( - "aaaaaaaa << (aaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat("llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); - verifyFormat("llvm::errs() << \"aaaaaaaaaaaaaaaaaaaaaaa: \"\n" - " << aaaaaaaaaaaaaaaaa(aaaaaaaa, aaaaaaaaaaa);"); - verifyFormat( - "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat( - "auto Diag = diag() << aaaaaaaaaaaaaaaa(aaaaaaaaaaaa, aaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaa);"); - - verifyFormat("llvm::outs() << \"aaaaaaaaaaaaaaaa: \"\n" - " << aaaaaaaa.aaaaaaaaaaaa(aaa)->aaaaaaaaaaaaaa();"); - verifyFormat("llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaa)\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat("LOG_IF(aaa == //\n" - " bbb)\n" - " << a << b;"); - - // But sometimes, breaking before the first "<<" is desirable. - verifyFormat("Diag(aaaaaaaaaaaaaaaaaaaa, aaaaaaaa)\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaa);"); - verifyFormat("Diag(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbb)\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat("SemaRef.Diag(Loc, diag::note_for_range_begin_end)\n" - " << BEF << IsTemplate << Description << E->getType();"); - verifyFormat("Diag(aaaaaaaaaaaaaaaaaaaa, aaaaaaaa)\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("Diag(aaaaaaaaaaaaaaaaaaaa, aaaaaaaa)\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " << aaa;"); - - verifyFormat( - "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); - - // Incomplete string literal. - EXPECT_EQ("llvm::errs() << \"\n" - " << a;", - format("llvm::errs() << \"\n<<a;")); - - verifyFormat("void f() {\n" - " CHECK_EQ(aaaa, (*bbbbbbbbb)->cccccc)\n" - " << \"qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\";\n" - "}"); - - // Handle 'endl'. - verifyFormat("llvm::errs() << aaaaaaaaaaaaaaaaaaaaaa << endl\n" - " << bbbbbbbbbbbbbbbbbbbbbb << endl;"); - verifyFormat("llvm::errs() << endl << bbbbbbbbbbbbbbbbbbbbbb << endl;"); - - // Handle '\n'. - verifyFormat("llvm::errs() << aaaaaaaaaaaaaaaaaaaaaa << \"\\n\"\n" - " << bbbbbbbbbbbbbbbbbbbbbb << \"\\n\";"); - verifyFormat("llvm::errs() << aaaaaaaaaaaaaaaaaaaaaa << \'\\n\'\n" - " << bbbbbbbbbbbbbbbbbbbbbb << \'\\n\';"); - verifyFormat("llvm::errs() << aaaa << \"aaaaaaaaaaaaaaaaaa\\n\"\n" - " << bbbb << \"bbbbbbbbbbbbbbbbbb\\n\";"); - verifyFormat("llvm::errs() << \"\\n\" << bbbbbbbbbbbbbbbbbbbbbb << \"\\n\";"); -} - -TEST_F(FormatTest, KeepStringLabelValuePairsOnALine) { - verifyFormat("return out << \"somepacket = {\\n\"\n" - " << \" aaaaaa = \" << pkt.aaaaaa << \"\\n\"\n" - " << \" bbbb = \" << pkt.bbbb << \"\\n\"\n" - " << \" cccccc = \" << pkt.cccccc << \"\\n\"\n" - " << \" ddd = [\" << pkt.ddd << \"]\\n\"\n" - " << \"}\";"); - - verifyFormat("llvm::outs() << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa\n" - " << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa\n" - " << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa;"); - verifyFormat( - "llvm::outs() << \"aaaaaaaaaaaaaaaaa = \" << aaaaaaaaaaaaaaaaa\n" - " << \"bbbbbbbbbbbbbbbbb = \" << bbbbbbbbbbbbbbbbb\n" - " << \"ccccccccccccccccc = \" << ccccccccccccccccc\n" - " << \"ddddddddddddddddd = \" << ddddddddddddddddd\n" - " << \"eeeeeeeeeeeeeeeee = \" << eeeeeeeeeeeeeeeee;"); - verifyFormat("llvm::outs() << aaaaaaaaaaaaaaaaaaaaaaaa << \"=\"\n" - " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); - verifyFormat( - "void f() {\n" - " llvm::outs() << \"aaaaaaaaaaaaaaaaaaaa: \"\n" - " << aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" - "}"); - - // Breaking before the first "<<" is generally not desirable. - verifyFormat( - "llvm::errs()\n" - " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;", - getLLVMStyleWithColumns(70)); - verifyFormat("llvm::errs() << \"aaaaaaaaaaaaaaaaaaa: \"\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " << \"aaaaaaaaaaaaaaaaaaa: \"\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " << \"aaaaaaaaaaaaaaaaaaa: \"\n" - " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;", - getLLVMStyleWithColumns(70)); - - verifyFormat("string v = \"aaaaaaaaaaaaaaaa: \" + aaaaaaaaaaaaaaaa +\n" - " \"aaaaaaaaaaaaaaaa: \" + aaaaaaaaaaaaaaaa +\n" - " \"aaaaaaaaaaaaaaaa: \" + aaaaaaaaaaaaaaaa;"); - verifyFormat("string v = StrCat(\"aaaaaaaaaaaaaaaa: \", aaaaaaaaaaaaaaaa,\n" - " \"aaaaaaaaaaaaaaaa: \", aaaaaaaaaaaaaaaa,\n" - " \"aaaaaaaaaaaaaaaa: \", aaaaaaaaaaaaaaaa);"); - verifyFormat("string v = \"aaaaaaaaaaaaaaaa: \" +\n" - " (aaaa + aaaa);", - getLLVMStyleWithColumns(40)); - verifyFormat("string v = StrCat(\"aaaaaaaaaaaa: \" +\n" - " (aaaaaaa + aaaaa));", - getLLVMStyleWithColumns(40)); - verifyFormat( - "string v = StrCat(\"aaaaaaaaaaaaaaaaaaaaaaaaaaa: \",\n" - " SomeFunction(aaaaaaaaaaaa, aaaaaaaa.aaaaaaa),\n" - " bbbbbbbbbbbbbbbbbbbbbbb);"); -} - -TEST_F(FormatTest, UnderstandsEquals) { - verifyFormat( - "aaaaaaaaaaaaaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat( - "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); - verifyFormat( - "if (a) {\n" - " f();\n" - "} else if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" - "}"); - - verifyFormat("if (int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " 100000000 + 10000000) {\n}"); -} - -TEST_F(FormatTest, WrapsAtFunctionCallsIfNecessary) { - verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n" - " .looooooooooooooooooooooooooooooooooooooongFunction();"); - - verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n" - " ->looooooooooooooooooooooooooooooooooooooongFunction();"); - - verifyFormat( - "LooooooooooooooooooooooooooooooooongObject->shortFunction(Parameter1,\n" - " Parameter2);"); - - verifyFormat( - "ShortObject->shortFunction(\n" - " LooooooooooooooooooooooooooooooooooooooooooooooongParameter1,\n" - " LooooooooooooooooooooooooooooooooooooooooooooooongParameter2);"); - - verifyFormat("loooooooooooooongFunction(\n" - " LoooooooooooooongObject->looooooooooooooooongFunction());"); - - verifyFormat( - "function(LoooooooooooooooooooooooooooooooooooongObject\n" - " ->loooooooooooooooooooooooooooooooooooooooongFunction());"); - - verifyFormat("EXPECT_CALL(SomeObject, SomeFunction(Parameter))\n" - " .WillRepeatedly(Return(SomeValue));"); - verifyFormat("void f() {\n" - " EXPECT_CALL(SomeObject, SomeFunction(Parameter))\n" - " .Times(2)\n" - " .WillRepeatedly(Return(SomeValue));\n" - "}"); - verifyFormat("SomeMap[std::pair(aaaaaaaaaaaa, bbbbbbbbbbbbbbb)].insert(\n" - " ccccccccccccccccccccccc);"); - verifyFormat("aaaaa(aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " .aaaaa(aaaaa),\n" - " aaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("void f() {\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa)->aaaaaaaaa());\n" - "}"); - verifyFormat("aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " .aaaaaaaaaaaaaaa(aa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa));"); - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()) {\n" - "}"); - - // Here, it is not necessary to wrap at "." or "->". - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaa) ||\n" - " aaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); - verifyFormat( - "aaaaaaaaaaa->aaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaa->aaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa));\n"); - - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa().aaaaaaaaaaaaaaaaa());"); - verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() *\n" - " aaaaaaaaa()->aaaaaa()->aaaaa());"); - verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() ||\n" - " aaaaaaaaa()->aaaaaa()->aaaaa());"); - - verifyFormat("aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " .a();"); - - FormatStyle NoBinPacking = getLLVMStyle(); - NoBinPacking.BinPackParameters = false; - verifyFormat("aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" - " .aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" - " .aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - NoBinPacking); - - // If there is a subsequent call, change to hanging indentation. - verifyFormat( - "aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa))\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa));"); - verifyFormat("aaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); - verifyFormat("aaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa());"); -} - -TEST_F(FormatTest, WrapsTemplateDeclarations) { - verifyFormat("template <typename T>\n" - "virtual void loooooooooooongFunction(int Param1, int Param2);"); - verifyFormat("template <typename T>\n" - "// T should be one of {A, B}.\n" - "virtual void loooooooooooongFunction(int Param1, int Param2);"); - verifyFormat( - "template <typename T>\n" - "using comment_to_xml_conversion = comment_to_xml_conversion<T, int>;"); - verifyFormat("template <typename T>\n" - "void f(int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram1,\n" - " int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram2);"); - verifyFormat( - "template <typename T>\n" - "void looooooooooooooooooooongFunction(int Paaaaaaaaaaaaaaaaaaaaram1,\n" - " int Paaaaaaaaaaaaaaaaaaaaram2);"); - verifyFormat( - "template <typename T>\n" - "aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("template <typename T>\n" - "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " int aaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat( - "template <typename T1, typename T2 = char, typename T3 = char,\n" - " typename T4 = char>\n" - "void f();"); - verifyFormat("template <typename aaaaaaaaaaa, typename bbbbbbbbbbbbb,\n" - " template <typename> class cccccccccccccccccccccc,\n" - " typename ddddddddddddd>\n" - "class C {};"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa>(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - - verifyFormat("void f() {\n" - " a<aaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaa>(\n" - " a(aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));\n" - "}"); - - verifyFormat("template <typename T> class C {};"); - verifyFormat("template <typename T> void f();"); - verifyFormat("template <typename T> void f() {}"); - verifyFormat( - "aaaaaaaaaaaaa<aaaaaaaaaa, aaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> *aaaa =\n" - " new aaaaaaaaaaaaa<aaaaaaaaaa, aaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>(\n" - " bbbbbbbbbbbbbbbbbbbbbbbb);", - getLLVMStyleWithColumns(72)); - EXPECT_EQ("static_cast<A< //\n" - " B> *>(\n" - "\n" - ");", - format("static_cast<A<//\n" - " B>*>(\n" - "\n" - " );")); - verifyFormat("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " const typename aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaa);"); - - FormatStyle AlwaysBreak = getLLVMStyle(); - AlwaysBreak.AlwaysBreakTemplateDeclarations = FormatStyle::BTDS_Yes; - verifyFormat("template <typename T>\nclass C {};", AlwaysBreak); - verifyFormat("template <typename T>\nvoid f();", AlwaysBreak); - verifyFormat("template <typename T>\nvoid f() {}", AlwaysBreak); - verifyFormat("void aaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbb>(\n" - " ccccccccccccccccccccccccccccccccccccccccccccccc);"); - verifyFormat("template <template <typename> class Fooooooo,\n" - " template <typename> class Baaaaaaar>\n" - "struct C {};", - AlwaysBreak); - verifyFormat("template <typename T> // T can be A, B or C.\n" - "struct C {};", - AlwaysBreak); - verifyFormat("template <enum E> class A {\n" - "public:\n" - " E *f();\n" - "};"); - - FormatStyle NeverBreak = getLLVMStyle(); - NeverBreak.AlwaysBreakTemplateDeclarations = FormatStyle::BTDS_No; - verifyFormat("template <typename T> class C {};", NeverBreak); - verifyFormat("template <typename T> void f();", NeverBreak); - verifyFormat("template <typename T> void f() {}", NeverBreak); - verifyFormat("template <typename T>\nvoid foo(aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbbbb) {}", - NeverBreak); - verifyFormat("void aaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbb>(\n" - " ccccccccccccccccccccccccccccccccccccccccccccccc);", - NeverBreak); - verifyFormat("template <template <typename> class Fooooooo,\n" - " template <typename> class Baaaaaaar>\n" - "struct C {};", - NeverBreak); - verifyFormat("template <typename T> // T can be A, B or C.\n" - "struct C {};", - NeverBreak); - verifyFormat("template <enum E> class A {\n" - "public:\n" - " E *f();\n" - "};", NeverBreak); - NeverBreak.PenaltyBreakTemplateDeclaration = 100; - verifyFormat("template <typename T> void\nfoo(aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbbbb) {}", - NeverBreak); -} - -TEST_F(FormatTest, WrapsTemplateDeclarationsWithComments) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_Cpp); - Style.ColumnLimit = 60; - EXPECT_EQ("// Baseline - no comments.\n" - "template <\n" - " typename aaaaaaaaaaaaaaaaaaaaaa<bbbbbbbbbbbb>::value>\n" - "void f() {}", - format("// Baseline - no comments.\n" - "template <\n" - " typename aaaaaaaaaaaaaaaaaaaaaa<bbbbbbbbbbbb>::value>\n" - "void f() {}", - Style)); - - EXPECT_EQ("template <\n" - " typename aaaaaaaaaa<bbbbbbbbbbbb>::value> // trailing\n" - "void f() {}", - format("template <\n" - " typename aaaaaaaaaa<bbbbbbbbbbbb>::value> // trailing\n" - "void f() {}", - Style)); - - EXPECT_EQ( - "template <\n" - " typename aaaaaaaaaa<bbbbbbbbbbbb>::value> /* line */\n" - "void f() {}", - format("template <typename aaaaaaaaaa<bbbbbbbbbbbb>::value> /* line */\n" - "void f() {}", - Style)); - - EXPECT_EQ( - "template <\n" - " typename aaaaaaaaaa<bbbbbbbbbbbb>::value> // trailing\n" - " // multiline\n" - "void f() {}", - format("template <\n" - " typename aaaaaaaaaa<bbbbbbbbbbbb>::value> // trailing\n" - " // multiline\n" - "void f() {}", - Style)); - - EXPECT_EQ( - "template <typename aaaaaaaaaa<\n" - " bbbbbbbbbbbb>::value> // trailing loooong\n" - "void f() {}", - format( - "template <\n" - " typename aaaaaaaaaa<bbbbbbbbbbbb>::value> // trailing loooong\n" - "void f() {}", - Style)); -} - -TEST_F(FormatTest, WrapsTemplateParameters) { - FormatStyle Style = getLLVMStyle(); - Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; - Style.BreakBeforeBinaryOperators = FormatStyle::BOS_None; - verifyFormat( - "template <typename... a> struct q {};\n" - "extern q<aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa>\n" - " y;", - Style); - Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; - Style.BreakBeforeBinaryOperators = FormatStyle::BOS_All; - verifyFormat( - "template <typename... a> struct r {};\n" - "extern r<aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa>\n" - " y;", - Style); - Style.AlignAfterOpenBracket = FormatStyle::BAS_AlwaysBreak; - Style.BreakBeforeBinaryOperators = FormatStyle::BOS_None; - verifyFormat( - "template <typename... a> struct s {};\n" - "extern s<\n" - " aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa>\n" - " y;", - Style); - Style.AlignAfterOpenBracket = FormatStyle::BAS_AlwaysBreak; - Style.BreakBeforeBinaryOperators = FormatStyle::BOS_All; - verifyFormat( - "template <typename... a> struct t {};\n" - "extern t<\n" - " aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa>\n" - " y;", - Style); -} - -TEST_F(FormatTest, WrapsAtNestedNameSpecifiers) { - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa());"); - - // FIXME: Should we have the extra indent after the second break? - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); - - verifyFormat( - "aaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb::\n" - " cccccccccccccccccccccccccccccccccccccccccccccc());"); - - // Breaking at nested name specifiers is generally not desirable. - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaa);"); - - verifyFormat( - "aaaaaaaaaaaaaaaaaa(aaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaa);", - getLLVMStyleWithColumns(74)); - - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); -} - -TEST_F(FormatTest, UnderstandsTemplateParameters) { - verifyFormat("A<int> a;"); - verifyFormat("A<A<A<int>>> a;"); - verifyFormat("A<A<A<int, 2>, 3>, 4> a;"); - verifyFormat("bool x = a < 1 || 2 > a;"); - verifyFormat("bool x = 5 < f<int>();"); - verifyFormat("bool x = f<int>() > 5;"); - verifyFormat("bool x = 5 < a<int>::x;"); - verifyFormat("bool x = a < 4 ? a > 2 : false;"); - verifyFormat("bool x = f() ? a < 2 : a > 2;"); - - verifyGoogleFormat("A<A<int>> a;"); - verifyGoogleFormat("A<A<A<int>>> a;"); - verifyGoogleFormat("A<A<A<A<int>>>> a;"); - verifyGoogleFormat("A<A<int> > a;"); - verifyGoogleFormat("A<A<A<int> > > a;"); - verifyGoogleFormat("A<A<A<A<int> > > > a;"); - verifyGoogleFormat("A<::A<int>> a;"); - verifyGoogleFormat("A<::A> a;"); - verifyGoogleFormat("A< ::A> a;"); - verifyGoogleFormat("A< ::A<int> > a;"); - EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A> >> a;", getGoogleStyle())); - EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A>> > a;", getGoogleStyle())); - EXPECT_EQ("A<::A<int>> a;", format("A< ::A<int>> a;", getGoogleStyle())); - EXPECT_EQ("A<::A<int>> a;", format("A<::A<int> > a;", getGoogleStyle())); - EXPECT_EQ("auto x = [] { A<A<A<A>>> a; };", - format("auto x=[]{A<A<A<A> >> a;};", getGoogleStyle())); - - verifyFormat("A<A>> a;", getChromiumStyle(FormatStyle::LK_Cpp)); - - verifyFormat("test >> a >> b;"); - verifyFormat("test << a >> b;"); - - verifyFormat("f<int>();"); - verifyFormat("template <typename T> void f() {}"); - verifyFormat("struct A<std::enable_if<sizeof(T2) < sizeof(int32)>::type>;"); - verifyFormat("struct A<std::enable_if<sizeof(T2) ? sizeof(int32) : " - "sizeof(char)>::type>;"); - verifyFormat("template <class T> struct S<std::is_arithmetic<T>{}> {};"); - verifyFormat("f(a.operator()<A>());"); - verifyFormat("f(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " .template operator()<A>());", - getLLVMStyleWithColumns(35)); - - // Not template parameters. - verifyFormat("return a < b && c > d;"); - verifyFormat("void f() {\n" - " while (a < b && c > d) {\n" - " }\n" - "}"); - verifyFormat("template <typename... Types>\n" - "typename enable_if<0 < sizeof...(Types)>::type Foo() {}"); - - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa >> aaaaa);", - getLLVMStyleWithColumns(60)); - verifyFormat("static_assert(is_convertible<A &&, B>::value, \"AAA\");"); - verifyFormat("Constructor(A... a) : a_(X<A>{std::forward<A>(a)}...) {}"); - verifyFormat("< < < < < < < < < < < < < < < < < < < < < < < < < < < < < <"); -} - -TEST_F(FormatTest, BitshiftOperatorWidth) { - EXPECT_EQ("int a = 1 << 2; /* foo\n" - " bar */", - format("int a=1<<2; /* foo\n" - " bar */")); - - EXPECT_EQ("int b = 256 >> 1; /* foo\n" - " bar */", - format("int b =256>>1 ; /* foo\n" - " bar */")); -} - -TEST_F(FormatTest, UnderstandsBinaryOperators) { - verifyFormat("COMPARE(a, ==, b);"); - verifyFormat("auto s = sizeof...(Ts) - 1;"); -} - -TEST_F(FormatTest, UnderstandsPointersToMembers) { - verifyFormat("int A::*x;"); - verifyFormat("int (S::*func)(void *);"); - verifyFormat("void f() { int (S::*func)(void *); }"); - verifyFormat("typedef bool *(Class::*Member)() const;"); - verifyFormat("void f() {\n" - " (a->*f)();\n" - " a->*x;\n" - " (a.*f)();\n" - " ((*a).*f)();\n" - " a.*x;\n" - "}"); - verifyFormat("void f() {\n" - " (a->*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)(\n" - " aaaa, bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb);\n" - "}"); - verifyFormat( - "(aaaaaaaaaa->*bbbbbbb)(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa));"); - FormatStyle Style = getLLVMStyle(); - Style.PointerAlignment = FormatStyle::PAS_Left; - verifyFormat("typedef bool* (Class::*Member)() const;", Style); -} - -TEST_F(FormatTest, UnderstandsUnaryOperators) { - verifyFormat("int a = -2;"); - verifyFormat("f(-1, -2, -3);"); - verifyFormat("a[-1] = 5;"); - verifyFormat("int a = 5 + -2;"); - verifyFormat("if (i == -1) {\n}"); - verifyFormat("if (i != -1) {\n}"); - verifyFormat("if (i > -1) {\n}"); - verifyFormat("if (i < -1) {\n}"); - verifyFormat("++(a->f());"); - verifyFormat("--(a->f());"); - verifyFormat("(a->f())++;"); - verifyFormat("a[42]++;"); - verifyFormat("if (!(a->f())) {\n}"); - verifyFormat("if (!+i) {\n}"); - verifyFormat("~&a;"); - - verifyFormat("a-- > b;"); - verifyFormat("b ? -a : c;"); - verifyFormat("n * sizeof char16;"); - verifyFormat("n * alignof char16;", getGoogleStyle()); - verifyFormat("sizeof(char);"); - verifyFormat("alignof(char);", getGoogleStyle()); - - verifyFormat("return -1;"); - verifyFormat("switch (a) {\n" - "case -1:\n" - " break;\n" - "}"); - verifyFormat("#define X -1"); - verifyFormat("#define X -kConstant"); - - verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = {-5, +3};"); - verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = {+5, -3};"); - - verifyFormat("int a = /* confusing comment */ -1;"); - // FIXME: The space after 'i' is wrong, but hopefully, this is a rare case. - verifyFormat("int a = i /* confusing comment */++;"); -} - -TEST_F(FormatTest, DoesNotIndentRelativeToUnaryOperators) { - verifyFormat("if (!aaaaaaaaaa( // break\n" - " aaaaa)) {\n" - "}"); - verifyFormat("aaaaaaaaaa(!aaaaaaaaaa( // break\n" - " aaaaa));"); - verifyFormat("*aaa = aaaaaaa( // break\n" - " bbbbbb);"); -} - -TEST_F(FormatTest, UnderstandsOverloadedOperators) { - verifyFormat("bool operator<();"); - verifyFormat("bool operator>();"); - verifyFormat("bool operator=();"); - verifyFormat("bool operator==();"); - verifyFormat("bool operator!=();"); - verifyFormat("int operator+();"); - verifyFormat("int operator++();"); - verifyFormat("int operator++(int) volatile noexcept;"); - verifyFormat("bool operator,();"); - verifyFormat("bool operator();"); - verifyFormat("bool operator()();"); - verifyFormat("bool operator[]();"); - verifyFormat("operator bool();"); - verifyFormat("operator int();"); - verifyFormat("operator void *();"); - verifyFormat("operator SomeType<int>();"); - verifyFormat("operator SomeType<int, int>();"); - verifyFormat("operator SomeType<SomeType<int>>();"); - verifyFormat("void *operator new(std::size_t size);"); - verifyFormat("void *operator new[](std::size_t size);"); - verifyFormat("void operator delete(void *ptr);"); - verifyFormat("void operator delete[](void *ptr);"); - verifyFormat("template <typename AAAAAAA, typename BBBBBBB>\n" - "AAAAAAA operator/(const AAAAAAA &a, BBBBBBB &b);"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaa operator,(\n" - " aaaaaaaaaaaaaaaaaaaaa &aaaaaaaaaaaaaaaaaaaaaaaaaa) const;"); - - verifyFormat( - "ostream &operator<<(ostream &OutputStream,\n" - " SomeReallyLongType WithSomeReallyLongValue);"); - verifyFormat("bool operator<(const aaaaaaaaaaaaaaaaaaaaa &left,\n" - " const aaaaaaaaaaaaaaaaaaaaa &right) {\n" - " return left.group < right.group;\n" - "}"); - verifyFormat("SomeType &operator=(const SomeType &S);"); - verifyFormat("f.template operator()<int>();"); - - verifyGoogleFormat("operator void*();"); - verifyGoogleFormat("operator SomeType<SomeType<int>>();"); - verifyGoogleFormat("operator ::A();"); - - verifyFormat("using A::operator+;"); - verifyFormat("inline A operator^(const A &lhs, const A &rhs) {}\n" - "int i;"); -} - -TEST_F(FormatTest, UnderstandsFunctionRefQualification) { - verifyFormat("Deleted &operator=(const Deleted &) & = default;"); - verifyFormat("Deleted &operator=(const Deleted &) && = delete;"); - verifyFormat("SomeType MemberFunction(const Deleted &) & = delete;"); - verifyFormat("SomeType MemberFunction(const Deleted &) && = delete;"); - verifyFormat("Deleted &operator=(const Deleted &) &;"); - verifyFormat("Deleted &operator=(const Deleted &) &&;"); - verifyFormat("SomeType MemberFunction(const Deleted &) &;"); - verifyFormat("SomeType MemberFunction(const Deleted &) &&;"); - verifyFormat("SomeType MemberFunction(const Deleted &) && {}"); - verifyFormat("SomeType MemberFunction(const Deleted &) && final {}"); - verifyFormat("SomeType MemberFunction(const Deleted &) && override {}"); - verifyFormat("void Fn(T const &) const &;"); - verifyFormat("void Fn(T const volatile &&) const volatile &&;"); - verifyFormat("template <typename T>\n" - "void F(T) && = delete;", - getGoogleStyle()); - - FormatStyle AlignLeft = getLLVMStyle(); - AlignLeft.PointerAlignment = FormatStyle::PAS_Left; - verifyFormat("void A::b() && {}", AlignLeft); - verifyFormat("Deleted& operator=(const Deleted&) & = default;", AlignLeft); - verifyFormat("SomeType MemberFunction(const Deleted&) & = delete;", - AlignLeft); - verifyFormat("Deleted& operator=(const Deleted&) &;", AlignLeft); - verifyFormat("SomeType MemberFunction(const Deleted&) &;", AlignLeft); - verifyFormat("auto Function(T t) & -> void {}", AlignLeft); - verifyFormat("auto Function(T... t) & -> void {}", AlignLeft); - verifyFormat("auto Function(T) & -> void {}", AlignLeft); - verifyFormat("auto Function(T) & -> void;", AlignLeft); - verifyFormat("void Fn(T const&) const&;", AlignLeft); - verifyFormat("void Fn(T const volatile&&) const volatile&&;", AlignLeft); - - FormatStyle Spaces = getLLVMStyle(); - Spaces.SpacesInCStyleCastParentheses = true; - verifyFormat("Deleted &operator=(const Deleted &) & = default;", Spaces); - verifyFormat("SomeType MemberFunction(const Deleted &) & = delete;", Spaces); - verifyFormat("Deleted &operator=(const Deleted &) &;", Spaces); - verifyFormat("SomeType MemberFunction(const Deleted &) &;", Spaces); - - Spaces.SpacesInCStyleCastParentheses = false; - Spaces.SpacesInParentheses = true; - verifyFormat("Deleted &operator=( const Deleted & ) & = default;", Spaces); - verifyFormat("SomeType MemberFunction( const Deleted & ) & = delete;", Spaces); - verifyFormat("Deleted &operator=( const Deleted & ) &;", Spaces); - verifyFormat("SomeType MemberFunction( const Deleted & ) &;", Spaces); -} - -TEST_F(FormatTest, UnderstandsNewAndDelete) { - verifyFormat("void f() {\n" - " A *a = new A;\n" - " A *a = new (placement) A;\n" - " delete a;\n" - " delete (A *)a;\n" - "}"); - verifyFormat("new (aaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa))\n" - " typename aaaaaaaaaaaaaaaaaaaaaaaa();"); - verifyFormat("auto aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " new (aaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa))\n" - " typename aaaaaaaaaaaaaaaaaaaaaaaa();"); - verifyFormat("delete[] h->p;"); -} - -TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) { - verifyFormat("int *f(int *a) {}"); - verifyFormat("int main(int argc, char **argv) {}"); - verifyFormat("Test::Test(int b) : a(b * b) {}"); - verifyIndependentOfContext("f(a, *a);"); - verifyFormat("void g() { f(*a); }"); - verifyIndependentOfContext("int a = b * 10;"); - verifyIndependentOfContext("int a = 10 * b;"); - verifyIndependentOfContext("int a = b * c;"); - verifyIndependentOfContext("int a += b * c;"); - verifyIndependentOfContext("int a -= b * c;"); - verifyIndependentOfContext("int a *= b * c;"); - verifyIndependentOfContext("int a /= b * c;"); - verifyIndependentOfContext("int a = *b;"); - verifyIndependentOfContext("int a = *b * c;"); - verifyIndependentOfContext("int a = b * *c;"); - verifyIndependentOfContext("int a = b * (10);"); - verifyIndependentOfContext("S << b * (10);"); - verifyIndependentOfContext("return 10 * b;"); - verifyIndependentOfContext("return *b * *c;"); - verifyIndependentOfContext("return a & ~b;"); - verifyIndependentOfContext("f(b ? *c : *d);"); - verifyIndependentOfContext("int a = b ? *c : *d;"); - verifyIndependentOfContext("*b = a;"); - verifyIndependentOfContext("a * ~b;"); - verifyIndependentOfContext("a * !b;"); - verifyIndependentOfContext("a * +b;"); - verifyIndependentOfContext("a * -b;"); - verifyIndependentOfContext("a * ++b;"); - verifyIndependentOfContext("a * --b;"); - verifyIndependentOfContext("a[4] * b;"); - verifyIndependentOfContext("a[a * a] = 1;"); - verifyIndependentOfContext("f() * b;"); - verifyIndependentOfContext("a * [self dostuff];"); - verifyIndependentOfContext("int x = a * (a + b);"); - verifyIndependentOfContext("(a *)(a + b);"); - verifyIndependentOfContext("*(int *)(p & ~3UL) = 0;"); - verifyIndependentOfContext("int *pa = (int *)&a;"); - verifyIndependentOfContext("return sizeof(int **);"); - verifyIndependentOfContext("return sizeof(int ******);"); - verifyIndependentOfContext("return (int **&)a;"); - verifyIndependentOfContext("f((*PointerToArray)[10]);"); - verifyFormat("void f(Type (*parameter)[10]) {}"); - verifyFormat("void f(Type (¶meter)[10]) {}"); - verifyGoogleFormat("return sizeof(int**);"); - verifyIndependentOfContext("Type **A = static_cast<Type **>(P);"); - verifyGoogleFormat("Type** A = static_cast<Type**>(P);"); - verifyFormat("auto a = [](int **&, int ***) {};"); - verifyFormat("auto PointerBinding = [](const char *S) {};"); - verifyFormat("typedef typeof(int(int, int)) *MyFunc;"); - verifyFormat("[](const decltype(*a) &value) {}"); - verifyFormat("decltype(a * b) F();"); - verifyFormat("#define MACRO() [](A *a) { return 1; }"); - verifyFormat("Constructor() : member([](A *a, B *b) {}) {}"); - verifyIndependentOfContext("typedef void (*f)(int *a);"); - verifyIndependentOfContext("int i{a * b};"); - verifyIndependentOfContext("aaa && aaa->f();"); - verifyIndependentOfContext("int x = ~*p;"); - verifyFormat("Constructor() : a(a), area(width * height) {}"); - verifyFormat("Constructor() : a(a), area(a, width * height) {}"); - verifyGoogleFormat("MACRO Constructor(const int& i) : a(a), b(b) {}"); - verifyFormat("void f() { f(a, c * d); }"); - verifyFormat("void f() { f(new a(), c * d); }"); - verifyFormat("void f(const MyOverride &override);"); - verifyFormat("void f(const MyFinal &final);"); - verifyIndependentOfContext("bool a = f() && override.f();"); - verifyIndependentOfContext("bool a = f() && final.f();"); - - verifyIndependentOfContext("InvalidRegions[*R] = 0;"); - - verifyIndependentOfContext("A<int *> a;"); - verifyIndependentOfContext("A<int **> a;"); - verifyIndependentOfContext("A<int *, int *> a;"); - verifyIndependentOfContext("A<int *[]> a;"); - verifyIndependentOfContext( - "const char *const p = reinterpret_cast<const char *const>(q);"); - verifyIndependentOfContext("A<int **, int **> a;"); - verifyIndependentOfContext("void f(int *a = d * e, int *b = c * d);"); - verifyFormat("for (char **a = b; *a; ++a) {\n}"); - verifyFormat("for (; a && b;) {\n}"); - verifyFormat("bool foo = true && [] { return false; }();"); - - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa, *aaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - - verifyGoogleFormat("int const* a = &b;"); - verifyGoogleFormat("**outparam = 1;"); - verifyGoogleFormat("*outparam = a * b;"); - verifyGoogleFormat("int main(int argc, char** argv) {}"); - verifyGoogleFormat("A<int*> a;"); - verifyGoogleFormat("A<int**> a;"); - verifyGoogleFormat("A<int*, int*> a;"); - verifyGoogleFormat("A<int**, int**> a;"); - verifyGoogleFormat("f(b ? *c : *d);"); - verifyGoogleFormat("int a = b ? *c : *d;"); - verifyGoogleFormat("Type* t = **x;"); - verifyGoogleFormat("Type* t = *++*x;"); - verifyGoogleFormat("*++*x;"); - verifyGoogleFormat("Type* t = const_cast<T*>(&*x);"); - verifyGoogleFormat("Type* t = x++ * y;"); - verifyGoogleFormat( - "const char* const p = reinterpret_cast<const char* const>(q);"); - verifyGoogleFormat("void f(int i = 0, SomeType** temps = NULL);"); - verifyGoogleFormat("void f(Bar* a = nullptr, Bar* b);"); - verifyGoogleFormat("template <typename T>\n" - "void f(int i = 0, SomeType** temps = NULL);"); - - FormatStyle Left = getLLVMStyle(); - Left.PointerAlignment = FormatStyle::PAS_Left; - verifyFormat("x = *a(x) = *a(y);", Left); - verifyFormat("for (;; *a = b) {\n}", Left); - verifyFormat("return *this += 1;", Left); - verifyFormat("throw *x;", Left); - verifyFormat("delete *x;", Left); - verifyFormat("typedef typeof(int(int, int))* MyFuncPtr;", Left); - verifyFormat("[](const decltype(*a)* ptr) {}", Left); - verifyFormat("typedef typeof /*comment*/ (int(int, int))* MyFuncPtr;", Left); - - verifyIndependentOfContext("a = *(x + y);"); - verifyIndependentOfContext("a = &(x + y);"); - verifyIndependentOfContext("*(x + y).call();"); - verifyIndependentOfContext("&(x + y)->call();"); - verifyFormat("void f() { &(*I).first; }"); - - verifyIndependentOfContext("f(b * /* confusing comment */ ++c);"); - verifyFormat( - "int *MyValues = {\n" - " *A, // Operator detection might be confused by the '{'\n" - " *BB // Operator detection might be confused by previous comment\n" - "};"); - - verifyIndependentOfContext("if (int *a = &b)"); - verifyIndependentOfContext("if (int &a = *b)"); - verifyIndependentOfContext("if (a & b[i])"); - verifyIndependentOfContext("if (a::b::c::d & b[i])"); - verifyIndependentOfContext("if (*b[i])"); - verifyIndependentOfContext("if (int *a = (&b))"); - verifyIndependentOfContext("while (int *a = &b)"); - verifyIndependentOfContext("size = sizeof *a;"); - verifyIndependentOfContext("if (a && (b = c))"); - verifyFormat("void f() {\n" - " for (const int &v : Values) {\n" - " }\n" - "}"); - verifyFormat("for (int i = a * a; i < 10; ++i) {\n}"); - verifyFormat("for (int i = 0; i < a * a; ++i) {\n}"); - verifyGoogleFormat("for (int i = 0; i * 2 < z; i *= 2) {\n}"); - - verifyFormat("#define A (!a * b)"); - verifyFormat("#define MACRO \\\n" - " int *i = a * b; \\\n" - " void f(a *b);", - getLLVMStyleWithColumns(19)); - - verifyIndependentOfContext("A = new SomeType *[Length];"); - verifyIndependentOfContext("A = new SomeType *[Length]();"); - verifyIndependentOfContext("T **t = new T *;"); - verifyIndependentOfContext("T **t = new T *();"); - verifyGoogleFormat("A = new SomeType*[Length]();"); - verifyGoogleFormat("A = new SomeType*[Length];"); - verifyGoogleFormat("T** t = new T*;"); - verifyGoogleFormat("T** t = new T*();"); - - verifyFormat("STATIC_ASSERT((a & b) == 0);"); - verifyFormat("STATIC_ASSERT(0 == (a & b));"); - verifyFormat("template <bool a, bool b> " - "typename t::if<x && y>::type f() {}"); - verifyFormat("template <int *y> f() {}"); - verifyFormat("vector<int *> v;"); - verifyFormat("vector<int *const> v;"); - verifyFormat("vector<int *const **const *> v;"); - verifyFormat("vector<int *volatile> v;"); - verifyFormat("vector<a * b> v;"); - verifyFormat("foo<b && false>();"); - verifyFormat("foo<b & 1>();"); - verifyFormat("decltype(*::std::declval<const T &>()) void F();"); - verifyFormat( - "template <class T, class = typename std::enable_if<\n" - " std::is_integral<T>::value &&\n" - " (sizeof(T) > 1 || sizeof(T) < 8)>::type>\n" - "void F();", - getLLVMStyleWithColumns(70)); - verifyFormat( - "template <class T,\n" - " class = typename std::enable_if<\n" - " std::is_integral<T>::value &&\n" - " (sizeof(T) > 1 || sizeof(T) < 8)>::type,\n" - " class U>\n" - "void F();", - getLLVMStyleWithColumns(70)); - verifyFormat( - "template <class T,\n" - " class = typename ::std::enable_if<\n" - " ::std::is_array<T>{} && ::std::is_array<T>{}>::type>\n" - "void F();", - getGoogleStyleWithColumns(68)); - - verifyIndependentOfContext("MACRO(int *i);"); - verifyIndependentOfContext("MACRO(auto *a);"); - verifyIndependentOfContext("MACRO(const A *a);"); - verifyIndependentOfContext("MACRO(A *const a);"); - verifyIndependentOfContext("MACRO('0' <= c && c <= '9');"); - verifyFormat("void f() { f(float{1}, a * a); }"); - // FIXME: Is there a way to make this work? - // verifyIndependentOfContext("MACRO(A *a);"); - - verifyFormat("DatumHandle const *operator->() const { return input_; }"); - verifyFormat("return options != nullptr && operator==(*options);"); - - EXPECT_EQ("#define OP(x) \\\n" - " ostream &operator<<(ostream &s, const A &a) { \\\n" - " return s << a.DebugString(); \\\n" - " }", - format("#define OP(x) \\\n" - " ostream &operator<<(ostream &s, const A &a) { \\\n" - " return s << a.DebugString(); \\\n" - " }", - getLLVMStyleWithColumns(50))); - - // FIXME: We cannot handle this case yet; we might be able to figure out that - // foo<x> d > v; doesn't make sense. - verifyFormat("foo<a<b && c> d> v;"); - - FormatStyle PointerMiddle = getLLVMStyle(); - PointerMiddle.PointerAlignment = FormatStyle::PAS_Middle; - verifyFormat("delete *x;", PointerMiddle); - verifyFormat("int * x;", PointerMiddle); - verifyFormat("int *[] x;", PointerMiddle); - verifyFormat("template <int * y> f() {}", PointerMiddle); - verifyFormat("int * f(int * a) {}", PointerMiddle); - verifyFormat("int main(int argc, char ** argv) {}", PointerMiddle); - verifyFormat("Test::Test(int b) : a(b * b) {}", PointerMiddle); - verifyFormat("A<int *> a;", PointerMiddle); - verifyFormat("A<int **> a;", PointerMiddle); - verifyFormat("A<int *, int *> a;", PointerMiddle); - verifyFormat("A<int *[]> a;", PointerMiddle); - verifyFormat("A = new SomeType *[Length]();", PointerMiddle); - verifyFormat("A = new SomeType *[Length];", PointerMiddle); - verifyFormat("T ** t = new T *;", PointerMiddle); - - // Member function reference qualifiers aren't binary operators. - verifyFormat("string // break\n" - "operator()() & {}"); - verifyFormat("string // break\n" - "operator()() && {}"); - verifyGoogleFormat("template <typename T>\n" - "auto x() & -> int {}"); -} - -TEST_F(FormatTest, UnderstandsAttributes) { - verifyFormat("SomeType s __attribute__((unused)) (InitValue);"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa __attribute__((unused))\n" - "aaaaaaaaaaaaaaaaaaaaaaa(int i);"); - FormatStyle AfterType = getLLVMStyle(); - AfterType.AlwaysBreakAfterReturnType = FormatStyle::RTBS_AllDefinitions; - verifyFormat("__attribute__((nodebug)) void\n" - "foo() {}\n", - AfterType); -} - -TEST_F(FormatTest, UnderstandsSquareAttributes) { - verifyFormat("SomeType s [[unused]] (InitValue);"); - verifyFormat("SomeType s [[gnu::unused]] (InitValue);"); - verifyFormat("SomeType s [[using gnu: unused]] (InitValue);"); - verifyFormat("[[gsl::suppress(\"clang-tidy-check-name\")]] void f() {}"); - verifyFormat("void f() [[deprecated(\"so sorry\")]];"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " [[unused]] aaaaaaaaaaaaaaaaaaaaaaa(int i);"); - - // Make sure we do not mistake attributes for array subscripts. - verifyFormat("int a() {}\n" - "[[unused]] int b() {}\n"); - verifyFormat("NSArray *arr;\n" - "arr[[Foo() bar]];"); - - // On the other hand, we still need to correctly find array subscripts. - verifyFormat("int a = std::vector<int>{1, 2, 3}[0];"); - - // Make sure we do not parse attributes as lambda introducers. - FormatStyle MultiLineFunctions = getLLVMStyle(); - MultiLineFunctions.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; - verifyFormat("[[unused]] int b() {\n" - " return 42;\n" - "}\n", - MultiLineFunctions); -} - -TEST_F(FormatTest, UnderstandsEllipsis) { - verifyFormat("int printf(const char *fmt, ...);"); - verifyFormat("template <class... Ts> void Foo(Ts... ts) { Foo(ts...); }"); - verifyFormat("template <class... Ts> void Foo(Ts *... ts) {}"); - - FormatStyle PointersLeft = getLLVMStyle(); - PointersLeft.PointerAlignment = FormatStyle::PAS_Left; - verifyFormat("template <class... Ts> void Foo(Ts*... ts) {}", PointersLeft); -} - -TEST_F(FormatTest, AdaptivelyFormatsPointersAndReferences) { - EXPECT_EQ("int *a;\n" - "int *a;\n" - "int *a;", - format("int *a;\n" - "int* a;\n" - "int *a;", - getGoogleStyle())); - EXPECT_EQ("int* a;\n" - "int* a;\n" - "int* a;", - format("int* a;\n" - "int* a;\n" - "int *a;", - getGoogleStyle())); - EXPECT_EQ("int *a;\n" - "int *a;\n" - "int *a;", - format("int *a;\n" - "int * a;\n" - "int * a;", - getGoogleStyle())); - EXPECT_EQ("auto x = [] {\n" - " int *a;\n" - " int *a;\n" - " int *a;\n" - "};", - format("auto x=[]{int *a;\n" - "int * a;\n" - "int * a;};", - getGoogleStyle())); -} - -TEST_F(FormatTest, UnderstandsRvalueReferences) { - verifyFormat("int f(int &&a) {}"); - verifyFormat("int f(int a, char &&b) {}"); - verifyFormat("void f() { int &&a = b; }"); - verifyGoogleFormat("int f(int a, char&& b) {}"); - verifyGoogleFormat("void f() { int&& a = b; }"); - - verifyIndependentOfContext("A<int &&> a;"); - verifyIndependentOfContext("A<int &&, int &&> a;"); - verifyGoogleFormat("A<int&&> a;"); - verifyGoogleFormat("A<int&&, int&&> a;"); - - // Not rvalue references: - verifyFormat("template <bool B, bool C> class A {\n" - " static_assert(B && C, \"Something is wrong\");\n" - "};"); - verifyGoogleFormat("#define IF(a, b, c) if (a && (b == c))"); - verifyGoogleFormat("#define WHILE(a, b, c) while (a && (b == c))"); - verifyFormat("#define A(a, b) (a && b)"); -} - -TEST_F(FormatTest, FormatsBinaryOperatorsPrecedingEquals) { - verifyFormat("void f() {\n" - " x[aaaaaaaaa -\n" - " b] = 23;\n" - "}", - getLLVMStyleWithColumns(15)); -} - -TEST_F(FormatTest, FormatsCasts) { - verifyFormat("Type *A = static_cast<Type *>(P);"); - verifyFormat("Type *A = (Type *)P;"); - verifyFormat("Type *A = (vector<Type *, int *>)P;"); - verifyFormat("int a = (int)(2.0f);"); - verifyFormat("int a = (int)2.0f;"); - verifyFormat("x[(int32)y];"); - verifyFormat("x = (int32)y;"); - verifyFormat("#define AA(X) sizeof(((X *)NULL)->a)"); - verifyFormat("int a = (int)*b;"); - verifyFormat("int a = (int)2.0f;"); - verifyFormat("int a = (int)~0;"); - verifyFormat("int a = (int)++a;"); - verifyFormat("int a = (int)sizeof(int);"); - verifyFormat("int a = (int)+2;"); - verifyFormat("my_int a = (my_int)2.0f;"); - verifyFormat("my_int a = (my_int)sizeof(int);"); - verifyFormat("return (my_int)aaa;"); - verifyFormat("#define x ((int)-1)"); - verifyFormat("#define LENGTH(x, y) (x) - (y) + 1"); - verifyFormat("#define p(q) ((int *)&q)"); - verifyFormat("fn(a)(b) + 1;"); - - verifyFormat("void f() { my_int a = (my_int)*b; }"); - verifyFormat("void f() { return P ? (my_int)*P : (my_int)0; }"); - verifyFormat("my_int a = (my_int)~0;"); - verifyFormat("my_int a = (my_int)++a;"); - verifyFormat("my_int a = (my_int)-2;"); - verifyFormat("my_int a = (my_int)1;"); - verifyFormat("my_int a = (my_int *)1;"); - verifyFormat("my_int a = (const my_int)-1;"); - verifyFormat("my_int a = (const my_int *)-1;"); - verifyFormat("my_int a = (my_int)(my_int)-1;"); - verifyFormat("my_int a = (ns::my_int)-2;"); - verifyFormat("case (my_int)ONE:"); - verifyFormat("auto x = (X)this;"); - - // FIXME: single value wrapped with paren will be treated as cast. - verifyFormat("void f(int i = (kValue)*kMask) {}"); - - verifyFormat("{ (void)F; }"); - - // Don't break after a cast's - verifyFormat("int aaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " (aaaaaaaaaaaaaaaaaaaaaaaaaa *)(aaaaaaaaaaaaaaaaaaaaaa +\n" - " bbbbbbbbbbbbbbbbbbbbbb);"); - - // These are not casts. - verifyFormat("void f(int *) {}"); - verifyFormat("f(foo)->b;"); - verifyFormat("f(foo).b;"); - verifyFormat("f(foo)(b);"); - verifyFormat("f(foo)[b];"); - verifyFormat("[](foo) { return 4; }(bar);"); - verifyFormat("(*funptr)(foo)[4];"); - verifyFormat("funptrs[4](foo)[4];"); - verifyFormat("void f(int *);"); - verifyFormat("void f(int *) = 0;"); - verifyFormat("void f(SmallVector<int>) {}"); - verifyFormat("void f(SmallVector<int>);"); - verifyFormat("void f(SmallVector<int>) = 0;"); - verifyFormat("void f(int i = (kA * kB) & kMask) {}"); - verifyFormat("int a = sizeof(int) * b;"); - verifyFormat("int a = alignof(int) * b;", getGoogleStyle()); - verifyFormat("template <> void f<int>(int i) SOME_ANNOTATION;"); - verifyFormat("f(\"%\" SOME_MACRO(ll) \"d\");"); - verifyFormat("aaaaa &operator=(const aaaaa &) LLVM_DELETED_FUNCTION;"); - - // These are not casts, but at some point were confused with casts. - verifyFormat("virtual void foo(int *) override;"); - verifyFormat("virtual void foo(char &) const;"); - verifyFormat("virtual void foo(int *a, char *) const;"); - verifyFormat("int a = sizeof(int *) + b;"); - verifyFormat("int a = alignof(int *) + b;", getGoogleStyle()); - verifyFormat("bool b = f(g<int>) && c;"); - verifyFormat("typedef void (*f)(int i) func;"); - - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *foo = (aaaaaaaaaaaaaaaaa *)\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); - // FIXME: The indentation here is not ideal. - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = (*cccccccccccccccc)\n" - " [dddddddddddddddddddddddddddddddddddddddddddddddddddddddd];"); -} - -TEST_F(FormatTest, FormatsFunctionTypes) { - verifyFormat("A<bool()> a;"); - verifyFormat("A<SomeType()> a;"); - verifyFormat("A<void (*)(int, std::string)> a;"); - verifyFormat("A<void *(int)>;"); - verifyFormat("void *(*a)(int *, SomeType *);"); - verifyFormat("int (*func)(void *);"); - verifyFormat("void f() { int (*func)(void *); }"); - verifyFormat("template <class CallbackClass>\n" - "using MyCallback = void (CallbackClass::*)(SomeObject *Data);"); - - verifyGoogleFormat("A<void*(int*, SomeType*)>;"); - verifyGoogleFormat("void* (*a)(int);"); - verifyGoogleFormat( - "template <class CallbackClass>\n" - "using MyCallback = void (CallbackClass::*)(SomeObject* Data);"); - - // Other constructs can look somewhat like function types: - verifyFormat("A<sizeof(*x)> a;"); - verifyFormat("#define DEREF_AND_CALL_F(x) f(*x)"); - verifyFormat("some_var = function(*some_pointer_var)[0];"); - verifyFormat("void f() { function(*some_pointer_var)[0] = 10; }"); - verifyFormat("int x = f(&h)();"); - verifyFormat("returnsFunction(¶m1, ¶m2)(param);"); - verifyFormat("std::function<\n" - " LooooooooooongTemplatedType<\n" - " SomeType>*(\n" - " LooooooooooooooooongType type)>\n" - " function;", - getGoogleStyleWithColumns(40)); -} - -TEST_F(FormatTest, FormatsPointersToArrayTypes) { - verifyFormat("A (*foo_)[6];"); - verifyFormat("vector<int> (*foo_)[6];"); -} - -TEST_F(FormatTest, BreaksLongVariableDeclarations) { - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" - " LoooooooooooooooooooooooooooooooooooooooongVariable;"); - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType const\n" - " LoooooooooooooooooooooooooooooooooooooooongVariable;"); - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" - " *LoooooooooooooooooooooooooooooooooooooooongVariable;"); - - // Different ways of ()-initializiation. - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" - " LoooooooooooooooooooooooooooooooooooooooongVariable(1);"); - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" - " LoooooooooooooooooooooooooooooooooooooooongVariable(a);"); - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" - " LoooooooooooooooooooooooooooooooooooooooongVariable({});"); - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" - " LoooooooooooooooooooooooooooooooooooooongVariable([A a]);"); - - // Lambdas should not confuse the variable declaration heuristic. - verifyFormat("LooooooooooooooooongType\n" - " variable(nullptr, [](A *a) {});", - getLLVMStyleWithColumns(40)); -} - -TEST_F(FormatTest, BreaksLongDeclarations) { - verifyFormat("typedef LoooooooooooooooooooooooooooooooooooooooongType\n" - " AnotherNameForTheLongType;"); - verifyFormat("typedef LongTemplateType<aaaaaaaaaaaaaaaaaaa()>\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" - "LoooooooooooooooooooooooooooooooongFunctionDeclaration();"); - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType *\n" - "LoooooooooooooooooooooooooooooooongFunctionDeclaration();"); - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" - "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType MACRO\n" - "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType const\n" - "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); - verifyFormat("decltype(LoooooooooooooooooooooooooooooooooooooooongName)\n" - "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" - "LooooooooooooooooooooooooooongFunctionDeclaration(T... t);"); - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" - "LooooooooooooooooooooooooooongFunctionDeclaration(T /*t*/) {}"); - FormatStyle Indented = getLLVMStyle(); - Indented.IndentWrappedFunctionNames = true; - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" - " LoooooooooooooooooooooooooooooooongFunctionDeclaration();", - Indented); - verifyFormat( - "LoooooooooooooooooooooooooooooooooooooooongReturnType\n" - " LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}", - Indented); - verifyFormat( - "LoooooooooooooooooooooooooooooooooooooooongReturnType const\n" - " LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}", - Indented); - verifyFormat( - "decltype(LoooooooooooooooooooooooooooooooooooooooongName)\n" - " LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}", - Indented); - - // FIXME: Without the comment, this breaks after "(". - verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType // break\n" - " (*LoooooooooooooooooooooooooooongFunctionTypeVarialbe)();", - getGoogleStyle()); - - verifyFormat("int *someFunction(int LoooooooooooooooooooongParam1,\n" - " int LoooooooooooooooooooongParam2) {}"); - verifyFormat( - "TypeSpecDecl *TypeSpecDecl::Create(ASTContext &C, DeclContext *DC,\n" - " SourceLocation L, IdentifierIn *II,\n" - " Type *T) {}"); - verifyFormat("ReallyLongReturnType<TemplateParam1, TemplateParam2>\n" - "ReallyReaaallyLongFunctionName(\n" - " const std::string &SomeParameter,\n" - " const SomeType<string, SomeOtherTemplateParameter>\n" - " &ReallyReallyLongParameterName,\n" - " const SomeType<string, SomeOtherTemplateParameter>\n" - " &AnotherLongParameterName) {}"); - verifyFormat("template <typename A>\n" - "SomeLoooooooooooooooooooooongType<\n" - " typename some_namespace::SomeOtherType<A>::Type>\n" - "Function() {}"); - - verifyGoogleFormat( - "aaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaa<aaaaaaaaaaaaa, aaaaaaaaaaaa>\n" - " aaaaaaaaaaaaaaaaaaaaaaa;"); - verifyGoogleFormat( - "TypeSpecDecl* TypeSpecDecl::Create(ASTContext& C, DeclContext* DC,\n" - " SourceLocation L) {}"); - verifyGoogleFormat( - "some_namespace::LongReturnType\n" - "long_namespace::SomeVeryLongClass::SomeVeryLongFunction(\n" - " int first_long_parameter, int second_parameter) {}"); - - verifyGoogleFormat("template <typename T>\n" - "aaaaaaaa::aaaaa::aaaaaa<T, aaaaaaaaaaaaaaaaaaaaaaaaa>\n" - "aaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaa() {}"); - verifyGoogleFormat("A<A<A>> aaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " int aaaaaaaaaaaaaaaaaaaaaaa);"); - - verifyFormat("typedef size_t (*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)(\n" - " const aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " *aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " vector<aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>\n" - " aaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " vector<aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>>\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - - verifyFormat("template <typename T> // Templates on own line.\n" - "static int // Some comment.\n" - "MyFunction(int a);", - getLLVMStyle()); -} - -TEST_F(FormatTest, FormatsArrays) { - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaa[aaaaaaaaaaaaaaaaaaaaaaaaa]\n" - " [bbbbbbbbbbbbbbbbbbbbbbbbb] = c;"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaa[aaaaaaaaaaa(aaaaaaaaaaaa)]\n" - " [bbbbbbbbbbb(bbbbbbbbbbbb)] = c;"); - verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaa &&\n" - " aaaaaaaaaaaaaaaaaaa[aaaaaaaaaaaaa][aaaaaaaaaaaaa]) {\n}"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = ccccccccccc;"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " [a][bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = cccccccc;"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]\n" - " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = ccccccccccc;"); - verifyFormat( - "llvm::outs() << \"aaaaaaaaaaaa: \"\n" - " << (*aaaaaaaiaaaaaaa)[aaaaaaaaaaaaaaaaaaaaaaaaa]\n" - " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa[aaaaaaaaaaaaaaaaa][a]\n" - " .aaaaaaaaaaaaaaaaaaaaaa();"); - - verifyGoogleFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<int>\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa[aaaaaaaaaaaa];"); - verifyFormat( - "aaaaaaaaaaa aaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaa->aaaaaaaaa[0]\n" - " .aaaaaaa[0]\n" - " .aaaaaaaaaaaaaaaaaaaaaa();"); - verifyFormat("a[::b::c];"); - - verifyNoCrash("a[,Y?)]", getLLVMStyleWithColumns(10)); - - FormatStyle NoColumnLimit = getLLVMStyleWithColumns(0); - verifyFormat("aaaaa[bbbbbb].cccccc()", NoColumnLimit); -} - -TEST_F(FormatTest, LineStartsWithSpecialCharacter) { - verifyFormat("(a)->b();"); - verifyFormat("--a;"); -} - -TEST_F(FormatTest, HandlesIncludeDirectives) { - verifyFormat("#include <string>\n" - "#include <a/b/c.h>\n" - "#include \"a/b/string\"\n" - "#include \"string.h\"\n" - "#include \"string.h\"\n" - "#include <a-a>\n" - "#include < path with space >\n" - "#include_next <test.h>" - "#include \"abc.h\" // this is included for ABC\n" - "#include \"some long include\" // with a comment\n" - "#include \"some very long include path\"\n" - "#include <some/very/long/include/path>\n", - getLLVMStyleWithColumns(35)); - EXPECT_EQ("#include \"a.h\"", format("#include \"a.h\"")); - EXPECT_EQ("#include <a>", format("#include<a>")); - - verifyFormat("#import <string>"); - verifyFormat("#import <a/b/c.h>"); - verifyFormat("#import \"a/b/string\""); - verifyFormat("#import \"string.h\""); - verifyFormat("#import \"string.h\""); - verifyFormat("#if __has_include(<strstream>)\n" - "#include <strstream>\n" - "#endif"); - - verifyFormat("#define MY_IMPORT <a/b>"); - - verifyFormat("#if __has_include(<a/b>)"); - verifyFormat("#if __has_include_next(<a/b>)"); - verifyFormat("#define F __has_include(<a/b>)"); - verifyFormat("#define F __has_include_next(<a/b>)"); - - // Protocol buffer definition or missing "#". - verifyFormat("import \"aaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaa\";", - getLLVMStyleWithColumns(30)); - - FormatStyle Style = getLLVMStyle(); - Style.AlwaysBreakBeforeMultilineStrings = true; - Style.ColumnLimit = 0; - verifyFormat("#import \"abc.h\"", Style); - - // But 'import' might also be a regular C++ namespace. - verifyFormat("import::SomeFunction(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); -} - -//===----------------------------------------------------------------------===// -// Error recovery tests. -//===----------------------------------------------------------------------===// - -TEST_F(FormatTest, IncompleteParameterLists) { - FormatStyle NoBinPacking = getLLVMStyle(); - NoBinPacking.BinPackParameters = false; - verifyFormat("void aaaaaaaaaaaaaaaaaa(int level,\n" - " double *min_x,\n" - " double *max_x,\n" - " double *min_y,\n" - " double *max_y,\n" - " double *min_z,\n" - " double *max_z, ) {}", - NoBinPacking); -} - -TEST_F(FormatTest, IncorrectCodeTrailingStuff) { - verifyFormat("void f() { return; }\n42"); - verifyFormat("void f() {\n" - " if (0)\n" - " return;\n" - "}\n" - "42"); - verifyFormat("void f() { return }\n42"); - verifyFormat("void f() {\n" - " if (0)\n" - " return\n" - "}\n" - "42"); -} - -TEST_F(FormatTest, IncorrectCodeMissingSemicolon) { - EXPECT_EQ("void f() { return }", format("void f ( ) { return }")); - EXPECT_EQ("void f() {\n" - " if (a)\n" - " return\n" - "}", - format("void f ( ) { if ( a ) return }")); - EXPECT_EQ("namespace N {\n" - "void f()\n" - "}", - format("namespace N { void f() }")); - EXPECT_EQ("namespace N {\n" - "void f() {}\n" - "void g()\n" - "} // namespace N", - format("namespace N { void f( ) { } void g( ) }")); -} - -TEST_F(FormatTest, IndentationWithinColumnLimitNotPossible) { - verifyFormat("int aaaaaaaa =\n" - " // Overlylongcomment\n" - " b;", - getLLVMStyleWithColumns(20)); - verifyFormat("function(\n" - " ShortArgument,\n" - " LoooooooooooongArgument);\n", - getLLVMStyleWithColumns(20)); -} - -TEST_F(FormatTest, IncorrectAccessSpecifier) { - verifyFormat("public:"); - verifyFormat("class A {\n" - "public\n" - " void f() {}\n" - "};"); - verifyFormat("public\n" - "int qwerty;"); - verifyFormat("public\n" - "B {}"); - verifyFormat("public\n" - "{}"); - verifyFormat("public\n" - "B { int x; }"); -} - -TEST_F(FormatTest, IncorrectCodeUnbalancedBraces) { - verifyFormat("{"); - verifyFormat("#})"); - verifyNoCrash("(/**/[:!] ?[)."); -} - -TEST_F(FormatTest, IncorrectUnbalancedBracesInMacrosWithUnicode) { - // Found by oss-fuzz: - // https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8212 - FormatStyle Style = getGoogleStyle(FormatStyle::LK_Cpp); - Style.ColumnLimit = 60; - verifyNoCrash( - "\x23\x47\xff\x20\x28\xff\x3c\xff\x3f\xff\x20\x2f\x7b\x7a\xff\x20" - "\xff\xff\xff\xca\xb5\xff\xff\xff\xff\x3a\x7b\x7d\xff\x20\xff\x20" - "\xff\x74\xff\x20\x7d\x7d\xff\x7b\x3a\xff\x20\x71\xff\x20\xff\x0a", - Style); -} - -TEST_F(FormatTest, IncorrectCodeDoNoWhile) { - verifyFormat("do {\n}"); - verifyFormat("do {\n}\n" - "f();"); - verifyFormat("do {\n}\n" - "wheeee(fun);"); - verifyFormat("do {\n" - " f();\n" - "}"); -} - -TEST_F(FormatTest, IncorrectCodeMissingParens) { - verifyFormat("if {\n foo;\n foo();\n}"); - verifyFormat("switch {\n foo;\n foo();\n}"); - verifyIncompleteFormat("for {\n foo;\n foo();\n}"); - verifyFormat("while {\n foo;\n foo();\n}"); - verifyFormat("do {\n foo;\n foo();\n} while;"); -} - -TEST_F(FormatTest, DoesNotTouchUnwrappedLinesWithErrors) { - verifyIncompleteFormat("namespace {\n" - "class Foo { Foo (\n" - "};\n" - "} // namespace"); -} - -TEST_F(FormatTest, IncorrectCodeErrorDetection) { - EXPECT_EQ("{\n {}\n", format("{\n{\n}\n")); - EXPECT_EQ("{\n {}\n", format("{\n {\n}\n")); - EXPECT_EQ("{\n {}\n", format("{\n {\n }\n")); - EXPECT_EQ("{\n {}\n}\n}\n", format("{\n {\n }\n }\n}\n")); - - EXPECT_EQ("{\n" - " {\n" - " breakme(\n" - " qwe);\n" - " }\n", - format("{\n" - " {\n" - " breakme(qwe);\n" - "}\n", - getLLVMStyleWithColumns(10))); -} - -TEST_F(FormatTest, LayoutCallsInsideBraceInitializers) { - verifyFormat("int x = {\n" - " avariable,\n" - " b(alongervariable)};", - getLLVMStyleWithColumns(25)); -} - -TEST_F(FormatTest, LayoutBraceInitializersInReturnStatement) { - verifyFormat("return (a)(b){1, 2, 3};"); -} - -TEST_F(FormatTest, LayoutCxx11BraceInitializers) { - verifyFormat("vector<int> x{1, 2, 3, 4};"); - verifyFormat("vector<int> x{\n" - " 1,\n" - " 2,\n" - " 3,\n" - " 4,\n" - "};"); - verifyFormat("vector<T> x{{}, {}, {}, {}};"); - verifyFormat("f({1, 2});"); - verifyFormat("auto v = Foo{-1};"); - verifyFormat("f({1, 2}, {{2, 3}, {4, 5}}, c, {d});"); - verifyFormat("Class::Class : member{1, 2, 3} {}"); - verifyFormat("new vector<int>{1, 2, 3};"); - verifyFormat("new int[3]{1, 2, 3};"); - verifyFormat("new int{1};"); - verifyFormat("return {arg1, arg2};"); - verifyFormat("return {arg1, SomeType{parameter}};"); - verifyFormat("int count = set<int>{f(), g(), h()}.size();"); - verifyFormat("new T{arg1, arg2};"); - verifyFormat("f(MyMap[{composite, key}]);"); - verifyFormat("class Class {\n" - " T member = {arg1, arg2};\n" - "};"); - verifyFormat("vector<int> foo = {::SomeGlobalFunction()};"); - verifyFormat("const struct A a = {.a = 1, .b = 2};"); - verifyFormat("const struct A a = {[0] = 1, [1] = 2};"); - verifyFormat("static_assert(std::is_integral<int>{} + 0, \"\");"); - verifyFormat("int a = std::is_integral<int>{} + 0;"); - - verifyFormat("int foo(int i) { return fo1{}(i); }"); - verifyFormat("int foo(int i) { return fo1{}(i); }"); - verifyFormat("auto i = decltype(x){};"); - verifyFormat("std::vector<int> v = {1, 0 /* comment */};"); - verifyFormat("Node n{1, Node{1000}, //\n" - " 2};"); - verifyFormat("Aaaa aaaaaaa{\n" - " {\n" - " aaaa,\n" - " },\n" - "};"); - verifyFormat("class C : public D {\n" - " SomeClass SC{2};\n" - "};"); - verifyFormat("class C : public A {\n" - " class D : public B {\n" - " void f() { int i{2}; }\n" - " };\n" - "};"); - verifyFormat("#define A {a, a},"); - - // Avoid breaking between equal sign and opening brace - FormatStyle AvoidBreakingFirstArgument = getLLVMStyle(); - AvoidBreakingFirstArgument.PenaltyBreakBeforeFirstCallParameter = 200; - verifyFormat("const std::unordered_map<std::string, int> MyHashTable =\n" - " {{\"aaaaaaaaaaaaaaaaaaaaa\", 0},\n" - " {\"bbbbbbbbbbbbbbbbbbbbb\", 1},\n" - " {\"ccccccccccccccccccccc\", 2}};", - AvoidBreakingFirstArgument); - - // Binpacking only if there is no trailing comma - verifyFormat("const Aaaaaa aaaaa = {aaaaaaaaaa, bbbbbbbbbb,\n" - " cccccccccc, dddddddddd};", - getLLVMStyleWithColumns(50)); - verifyFormat("const Aaaaaa aaaaa = {\n" - " aaaaaaaaaaa,\n" - " bbbbbbbbbbb,\n" - " ccccccccccc,\n" - " ddddddddddd,\n" - "};", getLLVMStyleWithColumns(50)); - - // Cases where distinguising braced lists and blocks is hard. - verifyFormat("vector<int> v{12} GUARDED_BY(mutex);"); - verifyFormat("void f() {\n" - " return; // comment\n" - "}\n" - "SomeType t;"); - verifyFormat("void f() {\n" - " if (a) {\n" - " f();\n" - " }\n" - "}\n" - "SomeType t;"); - - // In combination with BinPackArguments = false. - FormatStyle NoBinPacking = getLLVMStyle(); - NoBinPacking.BinPackArguments = false; - verifyFormat("const Aaaaaa aaaaa = {aaaaa,\n" - " bbbbb,\n" - " ccccc,\n" - " ddddd,\n" - " eeeee,\n" - " ffffff,\n" - " ggggg,\n" - " hhhhhh,\n" - " iiiiii,\n" - " jjjjjj,\n" - " kkkkkk};", - NoBinPacking); - verifyFormat("const Aaaaaa aaaaa = {\n" - " aaaaa,\n" - " bbbbb,\n" - " ccccc,\n" - " ddddd,\n" - " eeeee,\n" - " ffffff,\n" - " ggggg,\n" - " hhhhhh,\n" - " iiiiii,\n" - " jjjjjj,\n" - " kkkkkk,\n" - "};", - NoBinPacking); - verifyFormat( - "const Aaaaaa aaaaa = {\n" - " aaaaa, bbbbb, ccccc, ddddd, eeeee, ffffff, ggggg, hhhhhh,\n" - " iiiiii, jjjjjj, kkkkkk, aaaaa, bbbbb, ccccc, ddddd, eeeee,\n" - " ffffff, ggggg, hhhhhh, iiiiii, jjjjjj, kkkkkk,\n" - "};", - NoBinPacking); - - // FIXME: The alignment of these trailing comments might be bad. Then again, - // this might be utterly useless in real code. - verifyFormat("Constructor::Constructor()\n" - " : some_value{ //\n" - " aaaaaaa, //\n" - " bbbbbbb} {}"); - - // In braced lists, the first comment is always assumed to belong to the - // first element. Thus, it can be moved to the next or previous line as - // appropriate. - EXPECT_EQ("function({// First element:\n" - " 1,\n" - " // Second element:\n" - " 2});", - format("function({\n" - " // First element:\n" - " 1,\n" - " // Second element:\n" - " 2});")); - EXPECT_EQ("std::vector<int> MyNumbers{\n" - " // First element:\n" - " 1,\n" - " // Second element:\n" - " 2};", - format("std::vector<int> MyNumbers{// First element:\n" - " 1,\n" - " // Second element:\n" - " 2};", - getLLVMStyleWithColumns(30))); - // A trailing comma should still lead to an enforced line break and no - // binpacking. - EXPECT_EQ("vector<int> SomeVector = {\n" - " // aaa\n" - " 1,\n" - " 2,\n" - "};", - format("vector<int> SomeVector = { // aaa\n" - " 1, 2, };")); - - FormatStyle ExtraSpaces = getLLVMStyle(); - ExtraSpaces.Cpp11BracedListStyle = false; - ExtraSpaces.ColumnLimit = 75; - verifyFormat("vector<int> x{ 1, 2, 3, 4 };", ExtraSpaces); - verifyFormat("vector<T> x{ {}, {}, {}, {} };", ExtraSpaces); - verifyFormat("f({ 1, 2 });", ExtraSpaces); - verifyFormat("auto v = Foo{ 1 };", ExtraSpaces); - verifyFormat("f({ 1, 2 }, { { 2, 3 }, { 4, 5 } }, c, { d });", ExtraSpaces); - verifyFormat("Class::Class : member{ 1, 2, 3 } {}", ExtraSpaces); - verifyFormat("new vector<int>{ 1, 2, 3 };", ExtraSpaces); - verifyFormat("new int[3]{ 1, 2, 3 };", ExtraSpaces); - verifyFormat("return { arg1, arg2 };", ExtraSpaces); - verifyFormat("return { arg1, SomeType{ parameter } };", ExtraSpaces); - verifyFormat("int count = set<int>{ f(), g(), h() }.size();", ExtraSpaces); - verifyFormat("new T{ arg1, arg2 };", ExtraSpaces); - verifyFormat("f(MyMap[{ composite, key }]);", ExtraSpaces); - verifyFormat("class Class {\n" - " T member = { arg1, arg2 };\n" - "};", - ExtraSpaces); - verifyFormat( - "foo = aaaaaaaaaaa ? vector<int>{ aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaa, aaaaa }\n" - " : vector<int>{ bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" - " bbbbbbbbbbbbbbbbbbbb, bbbbb };", - ExtraSpaces); - verifyFormat("DoSomethingWithVector({} /* No data */);", ExtraSpaces); - verifyFormat("DoSomethingWithVector({ {} /* No data */ }, { { 1, 2 } });", - ExtraSpaces); - verifyFormat( - "someFunction(OtherParam,\n" - " BracedList{ // comment 1 (Forcing interesting break)\n" - " param1, param2,\n" - " // comment 2\n" - " param3, param4 });", - ExtraSpaces); - verifyFormat( - "std::this_thread::sleep_for(\n" - " std::chrono::nanoseconds{ std::chrono::seconds{ 1 } } / 5);", - ExtraSpaces); - verifyFormat("std::vector<MyValues> aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa{\n" - " aaaaaaa,\n" - " aaaaaaaaaa,\n" - " aaaaa,\n" - " aaaaaaaaaaaaaaa,\n" - " aaa,\n" - " aaaaaaaaaa,\n" - " a,\n" - " aaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaa,\n" - " a};"); - verifyFormat("vector<int> foo = { ::SomeGlobalFunction() };", ExtraSpaces); - verifyFormat("const struct A a = { .a = 1, .b = 2 };", ExtraSpaces); - verifyFormat("const struct A a = { [0] = 1, [1] = 2 };", ExtraSpaces); - - // Avoid breaking between initializer/equal sign and opening brace - ExtraSpaces.PenaltyBreakBeforeFirstCallParameter = 200; - verifyFormat("const std::unordered_map<std::string, int> MyHashTable = {\n" - " { \"aaaaaaaaaaaaaaaaaaaaa\", 0 },\n" - " { \"bbbbbbbbbbbbbbbbbbbbb\", 1 },\n" - " { \"ccccccccccccccccccccc\", 2 }\n" - "};", - ExtraSpaces); - verifyFormat("const std::unordered_map<std::string, int> MyHashTable{\n" - " { \"aaaaaaaaaaaaaaaaaaaaa\", 0 },\n" - " { \"bbbbbbbbbbbbbbbbbbbbb\", 1 },\n" - " { \"ccccccccccccccccccccc\", 2 }\n" - "};", - ExtraSpaces); - - FormatStyle SpaceBeforeBrace = getLLVMStyle(); - SpaceBeforeBrace.SpaceBeforeCpp11BracedList = true; - verifyFormat("vector<int> x {1, 2, 3, 4};", SpaceBeforeBrace); - verifyFormat("f({}, {{}, {}}, MyMap[{k, v}]);", SpaceBeforeBrace); -} - -TEST_F(FormatTest, FormatsBracedListsInColumnLayout) { - verifyFormat("vector<int> x = {1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777};"); - verifyFormat("vector<int> x = {1, 22, 333, 4444, 55555, 666666, 7777777, //\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, //\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777};"); - verifyFormat( - "vector<int> x = {1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, // comment\n" - " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" - " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" - " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" - " 7777777};"); - verifyFormat("static const uint16_t CallerSavedRegs64Bittttt[] = {\n" - " X86::RAX, X86::RDX, X86::RCX, X86::RSI, X86::RDI,\n" - " X86::R8, X86::R9, X86::R10, X86::R11, 0};"); - verifyFormat("static const uint16_t CallerSavedRegs64Bittttt[] = {\n" - " X86::RAX, X86::RDX, X86::RCX, X86::RSI, X86::RDI,\n" - " // Separating comment.\n" - " X86::R8, X86::R9, X86::R10, X86::R11, 0};"); - verifyFormat("static const uint16_t CallerSavedRegs64Bittttt[] = {\n" - " // Leading comment\n" - " X86::RAX, X86::RDX, X86::RCX, X86::RSI, X86::RDI,\n" - " X86::R8, X86::R9, X86::R10, X86::R11, 0};"); - verifyFormat("vector<int> x = {1, 1, 1, 1,\n" - " 1, 1, 1, 1};", - getLLVMStyleWithColumns(39)); - verifyFormat("vector<int> x = {1, 1, 1, 1,\n" - " 1, 1, 1, 1};", - getLLVMStyleWithColumns(38)); - verifyFormat("vector<int> aaaaaaaaaaaaaaaaaaaaaa = {\n" - " 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1};", - getLLVMStyleWithColumns(43)); - verifyFormat( - "static unsigned SomeValues[10][3] = {\n" - " {1, 4, 0}, {4, 9, 0}, {4, 5, 9}, {8, 5, 4}, {1, 8, 4},\n" - " {10, 1, 6}, {11, 0, 9}, {2, 11, 9}, {5, 2, 9}, {11, 2, 7}};"); - verifyFormat("static auto fields = new vector<string>{\n" - " \"aaaaaaaaaaaaa\",\n" - " \"aaaaaaaaaaaaa\",\n" - " \"aaaaaaaaaaaa\",\n" - " \"aaaaaaaaaaaaaa\",\n" - " \"aaaaaaaaaaaaaaaaaaaaaaaaa\",\n" - " \"aaaaaaaaaaaa\",\n" - " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\",\n" - "};"); - verifyFormat("vector<int> x = {1, 2, 3, 4, aaaaaaaaaaaaaaaaa, 6};"); - verifyFormat("vector<int> x = {1, aaaaaaaaaaaaaaaaaaaaaa,\n" - " 2, bbbbbbbbbbbbbbbbbbbbbb,\n" - " 3, cccccccccccccccccccccc};", - getLLVMStyleWithColumns(60)); - - // Trailing commas. - verifyFormat("vector<int> x = {\n" - " 1, 1, 1, 1, 1, 1, 1, 1,\n" - "};", - getLLVMStyleWithColumns(39)); - verifyFormat("vector<int> x = {\n" - " 1, 1, 1, 1, 1, 1, 1, 1, //\n" - "};", - getLLVMStyleWithColumns(39)); - verifyFormat("vector<int> x = {1, 1, 1, 1,\n" - " 1, 1, 1, 1,\n" - " /**/ /**/};", - getLLVMStyleWithColumns(39)); - - // Trailing comment in the first line. - verifyFormat("vector<int> iiiiiiiiiiiiiii = { //\n" - " 1111111111, 2222222222, 33333333333, 4444444444, //\n" - " 111111111, 222222222, 3333333333, 444444444, //\n" - " 11111111, 22222222, 333333333, 44444444};"); - // Trailing comment in the last line. - verifyFormat("int aaaaa[] = {\n" - " 1, 2, 3, // comment\n" - " 4, 5, 6 // comment\n" - "};"); - - // With nested lists, we should either format one item per line or all nested - // lists one on line. - // FIXME: For some nested lists, we can do better. - verifyFormat("return {{aaaaaaaaaaaaaaaaaaaaa},\n" - " {aaaaaaaaaaaaaaaaaaa},\n" - " {aaaaaaaaaaaaaaaaaaaaa},\n" - " {aaaaaaaaaaaaaaaaa}};", - getLLVMStyleWithColumns(60)); - verifyFormat( - "SomeStruct my_struct_array = {\n" - " {aaaaaa, aaaaaaaa, aaaaaaaaaa, aaaaaaaaa, aaaaaaaaa, aaaaaaaaaa,\n" - " aaaaaaaaaaaaa, aaaaaaa, aaa},\n" - " {aaa, aaa},\n" - " {aaa, aaa},\n" - " {aaaa, aaaa, aaaa, aaaa, aaaa, aaaa, aaaa, aaa},\n" - " {aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaa, a, aaaaaaaaaa, aaaaaaaaa, aaa}};"); - - // No column layout should be used here. - verifyFormat("aaaaaaaaaaaaaaa = {aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa, 0, 0,\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb};"); - - verifyNoCrash("a<,"); - - // No braced initializer here. - verifyFormat("void f() {\n" - " struct Dummy {};\n" - " f(v);\n" - "}"); - - // Long lists should be formatted in columns even if they are nested. - verifyFormat( - "vector<int> x = function({1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" - " 1, 22, 333, 4444, 55555, 666666, 7777777});"); - - // Allow "single-column" layout even if that violates the column limit. There - // isn't going to be a better way. - verifyFormat("std::vector<int> a = {\n" - " aaaaaaaa,\n" - " aaaaaaaa,\n" - " aaaaaaaa,\n" - " aaaaaaaa,\n" - " aaaaaaaaaa,\n" - " aaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa};", - getLLVMStyleWithColumns(30)); - verifyFormat("vector<int> aaaa = {\n" - " aaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaa.aaaaaaa,\n" - " aaaaaa.aaaaaaa,\n" - " aaaaaa.aaaaaaa,\n" - " aaaaaa.aaaaaaa,\n" - "};"); - - // Don't create hanging lists. - verifyFormat("someFunction(Param, {List1, List2,\n" - " List3});", - getLLVMStyleWithColumns(35)); - verifyFormat("someFunction(Param, Param,\n" - " {List1, List2,\n" - " List3});", - getLLVMStyleWithColumns(35)); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaa, {},\n" - " aaaaaaaaaaaaaaaaaaaaaaa);"); -} - -TEST_F(FormatTest, PullTrivialFunctionDefinitionsIntoSingleLine) { - FormatStyle DoNotMerge = getLLVMStyle(); - DoNotMerge.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; - - verifyFormat("void f() { return 42; }"); - verifyFormat("void f() {\n" - " return 42;\n" - "}", - DoNotMerge); - verifyFormat("void f() {\n" - " // Comment\n" - "}"); - verifyFormat("{\n" - "#error {\n" - " int a;\n" - "}"); - verifyFormat("{\n" - " int a;\n" - "#error {\n" - "}"); - verifyFormat("void f() {} // comment"); - verifyFormat("void f() { int a; } // comment"); - verifyFormat("void f() {\n" - "} // comment", - DoNotMerge); - verifyFormat("void f() {\n" - " int a;\n" - "} // comment", - DoNotMerge); - verifyFormat("void f() {\n" - "} // comment", - getLLVMStyleWithColumns(15)); - - verifyFormat("void f() { return 42; }", getLLVMStyleWithColumns(23)); - verifyFormat("void f() {\n return 42;\n}", getLLVMStyleWithColumns(22)); - - verifyFormat("void f() {}", getLLVMStyleWithColumns(11)); - verifyFormat("void f() {\n}", getLLVMStyleWithColumns(10)); - verifyFormat("class C {\n" - " C()\n" - " : iiiiiiii(nullptr),\n" - " kkkkkkk(nullptr),\n" - " mmmmmmm(nullptr),\n" - " nnnnnnn(nullptr) {}\n" - "};", - getGoogleStyle()); - - FormatStyle NoColumnLimit = getLLVMStyle(); - NoColumnLimit.ColumnLimit = 0; - EXPECT_EQ("A() : b(0) {}", format("A():b(0){}", NoColumnLimit)); - EXPECT_EQ("class C {\n" - " A() : b(0) {}\n" - "};", - format("class C{A():b(0){}};", NoColumnLimit)); - EXPECT_EQ("A()\n" - " : b(0) {\n" - "}", - format("A()\n:b(0)\n{\n}", NoColumnLimit)); - - FormatStyle DoNotMergeNoColumnLimit = NoColumnLimit; - DoNotMergeNoColumnLimit.AllowShortFunctionsOnASingleLine = - FormatStyle::SFS_None; - EXPECT_EQ("A()\n" - " : b(0) {\n" - "}", - format("A():b(0){}", DoNotMergeNoColumnLimit)); - EXPECT_EQ("A()\n" - " : b(0) {\n" - "}", - format("A()\n:b(0)\n{\n}", DoNotMergeNoColumnLimit)); - - verifyFormat("#define A \\\n" - " void f() { \\\n" - " int i; \\\n" - " }", - getLLVMStyleWithColumns(20)); - verifyFormat("#define A \\\n" - " void f() { int i; }", - getLLVMStyleWithColumns(21)); - verifyFormat("#define A \\\n" - " void f() { \\\n" - " int i; \\\n" - " } \\\n" - " int j;", - getLLVMStyleWithColumns(22)); - verifyFormat("#define A \\\n" - " void f() { int i; } \\\n" - " int j;", - getLLVMStyleWithColumns(23)); -} - -TEST_F(FormatTest, PullEmptyFunctionDefinitionsIntoSingleLine) { - FormatStyle MergeEmptyOnly = getLLVMStyle(); - MergeEmptyOnly.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Empty; - verifyFormat("class C {\n" - " int f() {}\n" - "};", - MergeEmptyOnly); - verifyFormat("class C {\n" - " int f() {\n" - " return 42;\n" - " }\n" - "};", - MergeEmptyOnly); - verifyFormat("int f() {}", MergeEmptyOnly); - verifyFormat("int f() {\n" - " return 42;\n" - "}", - MergeEmptyOnly); - - // Also verify behavior when BraceWrapping.AfterFunction = true - MergeEmptyOnly.BreakBeforeBraces = FormatStyle::BS_Custom; - MergeEmptyOnly.BraceWrapping.AfterFunction = true; - verifyFormat("int f() {}", MergeEmptyOnly); - verifyFormat("class C {\n" - " int f() {}\n" - "};", - MergeEmptyOnly); -} - -TEST_F(FormatTest, PullInlineFunctionDefinitionsIntoSingleLine) { - FormatStyle MergeInlineOnly = getLLVMStyle(); - MergeInlineOnly.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline; - verifyFormat("class C {\n" - " int f() { return 42; }\n" - "};", - MergeInlineOnly); - verifyFormat("int f() {\n" - " return 42;\n" - "}", - MergeInlineOnly); - - // SFS_Inline implies SFS_Empty - verifyFormat("class C {\n" - " int f() {}\n" - "};", - MergeInlineOnly); - verifyFormat("int f() {}", MergeInlineOnly); - - // Also verify behavior when BraceWrapping.AfterFunction = true - MergeInlineOnly.BreakBeforeBraces = FormatStyle::BS_Custom; - MergeInlineOnly.BraceWrapping.AfterFunction = true; - verifyFormat("class C {\n" - " int f() { return 42; }\n" - "};", - MergeInlineOnly); - verifyFormat("int f()\n" - "{\n" - " return 42;\n" - "}", - MergeInlineOnly); - - // SFS_Inline implies SFS_Empty - verifyFormat("int f() {}", MergeInlineOnly); - verifyFormat("class C {\n" - " int f() {}\n" - "};", - MergeInlineOnly); -} - -TEST_F(FormatTest, PullInlineOnlyFunctionDefinitionsIntoSingleLine) { - FormatStyle MergeInlineOnly = getLLVMStyle(); - MergeInlineOnly.AllowShortFunctionsOnASingleLine = - FormatStyle::SFS_InlineOnly; - verifyFormat("class C {\n" - " int f() { return 42; }\n" - "};", - MergeInlineOnly); - verifyFormat("int f() {\n" - " return 42;\n" - "}", - MergeInlineOnly); - - // SFS_InlineOnly does not imply SFS_Empty - verifyFormat("class C {\n" - " int f() {}\n" - "};", - MergeInlineOnly); - verifyFormat("int f() {\n" - "}", - MergeInlineOnly); - - // Also verify behavior when BraceWrapping.AfterFunction = true - MergeInlineOnly.BreakBeforeBraces = FormatStyle::BS_Custom; - MergeInlineOnly.BraceWrapping.AfterFunction = true; - verifyFormat("class C {\n" - " int f() { return 42; }\n" - "};", - MergeInlineOnly); - verifyFormat("int f()\n" - "{\n" - " return 42;\n" - "}", - MergeInlineOnly); - - // SFS_InlineOnly does not imply SFS_Empty - verifyFormat("int f()\n" - "{\n" - "}", - MergeInlineOnly); - verifyFormat("class C {\n" - " int f() {}\n" - "};", - MergeInlineOnly); -} - -TEST_F(FormatTest, SplitEmptyFunction) { - FormatStyle Style = getLLVMStyle(); - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterFunction = true; - Style.BraceWrapping.SplitEmptyFunction = false; - Style.ColumnLimit = 40; - - verifyFormat("int f()\n" - "{}", - Style); - verifyFormat("int f()\n" - "{\n" - " return 42;\n" - "}", - Style); - verifyFormat("int f()\n" - "{\n" - " // some comment\n" - "}", - Style); - - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Empty; - verifyFormat("int f() {}", Style); - verifyFormat("int aaaaaaaaaaaaaa(int bbbbbbbbbbbbbb)\n" - "{}", - Style); - verifyFormat("int f()\n" - "{\n" - " return 0;\n" - "}", - Style); - - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline; - verifyFormat("class Foo {\n" - " int f() {}\n" - "};\n", - Style); - verifyFormat("class Foo {\n" - " int f() { return 0; }\n" - "};\n", - Style); - verifyFormat("class Foo {\n" - " int aaaaaaaaaaaaaa(int bbbbbbbbbbbbbb)\n" - " {}\n" - "};\n", - Style); - verifyFormat("class Foo {\n" - " int aaaaaaaaaaaaaa(int bbbbbbbbbbbbbb)\n" - " {\n" - " return 0;\n" - " }\n" - "};\n", - Style); - - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All; - verifyFormat("int f() {}", Style); - verifyFormat("int f() { return 0; }", Style); - verifyFormat("int aaaaaaaaaaaaaa(int bbbbbbbbbbbbbb)\n" - "{}", - Style); - verifyFormat("int aaaaaaaaaaaaaa(int bbbbbbbbbbbbbb)\n" - "{\n" - " return 0;\n" - "}", - Style); -} -TEST_F(FormatTest, KeepShortFunctionAfterPPElse) { - FormatStyle Style = getLLVMStyle(); - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All; - verifyFormat("#ifdef A\n" - "int f() {}\n" - "#else\n" - "int g() {}\n" - "#endif", - Style); -} - -TEST_F(FormatTest, SplitEmptyClass) { - FormatStyle Style = getLLVMStyle(); - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterClass = true; - Style.BraceWrapping.SplitEmptyRecord = false; - - verifyFormat("class Foo\n" - "{};", - Style); - verifyFormat("/* something */ class Foo\n" - "{};", - Style); - verifyFormat("template <typename X> class Foo\n" - "{};", - Style); - verifyFormat("class Foo\n" - "{\n" - " Foo();\n" - "};", - Style); - verifyFormat("typedef class Foo\n" - "{\n" - "} Foo_t;", - Style); -} - -TEST_F(FormatTest, SplitEmptyStruct) { - FormatStyle Style = getLLVMStyle(); - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterStruct = true; - Style.BraceWrapping.SplitEmptyRecord = false; - - verifyFormat("struct Foo\n" - "{};", - Style); - verifyFormat("/* something */ struct Foo\n" - "{};", - Style); - verifyFormat("template <typename X> struct Foo\n" - "{};", - Style); - verifyFormat("struct Foo\n" - "{\n" - " Foo();\n" - "};", - Style); - verifyFormat("typedef struct Foo\n" - "{\n" - "} Foo_t;", - Style); - //typedef struct Bar {} Bar_t; -} - -TEST_F(FormatTest, SplitEmptyUnion) { - FormatStyle Style = getLLVMStyle(); - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterUnion = true; - Style.BraceWrapping.SplitEmptyRecord = false; - - verifyFormat("union Foo\n" - "{};", - Style); - verifyFormat("/* something */ union Foo\n" - "{};", - Style); - verifyFormat("union Foo\n" - "{\n" - " A,\n" - "};", - Style); - verifyFormat("typedef union Foo\n" - "{\n" - "} Foo_t;", - Style); -} - -TEST_F(FormatTest, SplitEmptyNamespace) { - FormatStyle Style = getLLVMStyle(); - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterNamespace = true; - Style.BraceWrapping.SplitEmptyNamespace = false; - - verifyFormat("namespace Foo\n" - "{};", - Style); - verifyFormat("/* something */ namespace Foo\n" - "{};", - Style); - verifyFormat("inline namespace Foo\n" - "{};", - Style); - verifyFormat("/* something */ inline namespace Foo\n" - "{};", - Style); - verifyFormat("export namespace Foo\n" - "{};", - Style); - verifyFormat("namespace Foo\n" - "{\n" - "void Bar();\n" - "};", - Style); -} - -TEST_F(FormatTest, NeverMergeShortRecords) { - FormatStyle Style = getLLVMStyle(); - - verifyFormat("class Foo {\n" - " Foo();\n" - "};", - Style); - verifyFormat("typedef class Foo {\n" - " Foo();\n" - "} Foo_t;", - Style); - verifyFormat("struct Foo {\n" - " Foo();\n" - "};", - Style); - verifyFormat("typedef struct Foo {\n" - " Foo();\n" - "} Foo_t;", - Style); - verifyFormat("union Foo {\n" - " A,\n" - "};", - Style); - verifyFormat("typedef union Foo {\n" - " A,\n" - "} Foo_t;", - Style); - verifyFormat("namespace Foo {\n" - "void Bar();\n" - "};", - Style); - - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterClass = true; - Style.BraceWrapping.AfterStruct = true; - Style.BraceWrapping.AfterUnion = true; - Style.BraceWrapping.AfterNamespace = true; - verifyFormat("class Foo\n" - "{\n" - " Foo();\n" - "};", - Style); - verifyFormat("typedef class Foo\n" - "{\n" - " Foo();\n" - "} Foo_t;", - Style); - verifyFormat("struct Foo\n" - "{\n" - " Foo();\n" - "};", - Style); - verifyFormat("typedef struct Foo\n" - "{\n" - " Foo();\n" - "} Foo_t;", - Style); - verifyFormat("union Foo\n" - "{\n" - " A,\n" - "};", - Style); - verifyFormat("typedef union Foo\n" - "{\n" - " A,\n" - "} Foo_t;", - Style); - verifyFormat("namespace Foo\n" - "{\n" - "void Bar();\n" - "};", - Style); -} - -TEST_F(FormatTest, UnderstandContextOfRecordTypeKeywords) { - // Elaborate type variable declarations. - verifyFormat("struct foo a = {bar};\nint n;"); - verifyFormat("class foo a = {bar};\nint n;"); - verifyFormat("union foo a = {bar};\nint n;"); - - // Elaborate types inside function definitions. - verifyFormat("struct foo f() {}\nint n;"); - verifyFormat("class foo f() {}\nint n;"); - verifyFormat("union foo f() {}\nint n;"); - - // Templates. - verifyFormat("template <class X> void f() {}\nint n;"); - verifyFormat("template <struct X> void f() {}\nint n;"); - verifyFormat("template <union X> void f() {}\nint n;"); - - // Actual definitions... - verifyFormat("struct {\n} n;"); - verifyFormat( - "template <template <class T, class Y>, class Z> class X {\n} n;"); - verifyFormat("union Z {\n int n;\n} x;"); - verifyFormat("class MACRO Z {\n} n;"); - verifyFormat("class MACRO(X) Z {\n} n;"); - verifyFormat("class __attribute__(X) Z {\n} n;"); - verifyFormat("class __declspec(X) Z {\n} n;"); - verifyFormat("class A##B##C {\n} n;"); - verifyFormat("class alignas(16) Z {\n} n;"); - verifyFormat("class MACRO(X) alignas(16) Z {\n} n;"); - verifyFormat("class MACROA MACRO(X) Z {\n} n;"); - - // Redefinition from nested context: - verifyFormat("class A::B::C {\n} n;"); - - // Template definitions. - verifyFormat( - "template <typename F>\n" - "Matcher(const Matcher<F> &Other,\n" - " typename enable_if_c<is_base_of<F, T>::value &&\n" - " !is_same<F, T>::value>::type * = 0)\n" - " : Implementation(new ImplicitCastMatcher<F>(Other)) {}"); - - // FIXME: This is still incorrectly handled at the formatter side. - verifyFormat("template <> struct X < 15, i<3 && 42 < 50 && 33 < 28> {};"); - verifyFormat("int i = SomeFunction(a<b, a> b);"); - - // FIXME: - // This now gets parsed incorrectly as class definition. - // verifyFormat("class A<int> f() {\n}\nint n;"); - - // Elaborate types where incorrectly parsing the structural element would - // break the indent. - verifyFormat("if (true)\n" - " class X x;\n" - "else\n" - " f();\n"); - - // This is simply incomplete. Formatting is not important, but must not crash. - verifyFormat("class A:"); -} - -TEST_F(FormatTest, DoNotInterfereWithErrorAndWarning) { - EXPECT_EQ("#error Leave all white!!!!! space* alone!\n", - format("#error Leave all white!!!!! space* alone!\n")); - EXPECT_EQ( - "#warning Leave all white!!!!! space* alone!\n", - format("#warning Leave all white!!!!! space* alone!\n")); - EXPECT_EQ("#error 1", format(" # error 1")); - EXPECT_EQ("#warning 1", format(" # warning 1")); -} - -TEST_F(FormatTest, FormatHashIfExpressions) { - verifyFormat("#if AAAA && BBBB"); - verifyFormat("#if (AAAA && BBBB)"); - verifyFormat("#elif (AAAA && BBBB)"); - // FIXME: Come up with a better indentation for #elif. - verifyFormat( - "#if !defined(AAAAAAA) && (defined CCCCCC || defined DDDDDD) && \\\n" - " defined(BBBBBBBB)\n" - "#elif !defined(AAAAAA) && (defined CCCCC || defined DDDDDD) && \\\n" - " defined(BBBBBBBB)\n" - "#endif", - getLLVMStyleWithColumns(65)); -} - -TEST_F(FormatTest, MergeHandlingInTheFaceOfPreprocessorDirectives) { - FormatStyle AllowsMergedIf = getGoogleStyle(); - AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true; - verifyFormat("void f() { f(); }\n#error E", AllowsMergedIf); - verifyFormat("if (true) return 42;\n#error E", AllowsMergedIf); - verifyFormat("if (true)\n#error E\n return 42;", AllowsMergedIf); - EXPECT_EQ("if (true) return 42;", - format("if (true)\nreturn 42;", AllowsMergedIf)); - FormatStyle ShortMergedIf = AllowsMergedIf; - ShortMergedIf.ColumnLimit = 25; - verifyFormat("#define A \\\n" - " if (true) return 42;", - ShortMergedIf); - verifyFormat("#define A \\\n" - " f(); \\\n" - " if (true)\n" - "#define B", - ShortMergedIf); - verifyFormat("#define A \\\n" - " f(); \\\n" - " if (true)\n" - "g();", - ShortMergedIf); - verifyFormat("{\n" - "#ifdef A\n" - " // Comment\n" - " if (true) continue;\n" - "#endif\n" - " // Comment\n" - " if (true) continue;\n" - "}", - ShortMergedIf); - ShortMergedIf.ColumnLimit = 33; - verifyFormat("#define A \\\n" - " if constexpr (true) return 42;", - ShortMergedIf); - ShortMergedIf.ColumnLimit = 29; - verifyFormat("#define A \\\n" - " if (aaaaaaaaaa) return 1; \\\n" - " return 2;", - ShortMergedIf); - ShortMergedIf.ColumnLimit = 28; - verifyFormat("#define A \\\n" - " if (aaaaaaaaaa) \\\n" - " return 1; \\\n" - " return 2;", - ShortMergedIf); - verifyFormat("#define A \\\n" - " if constexpr (aaaaaaa) \\\n" - " return 1; \\\n" - " return 2;", - ShortMergedIf); -} - -TEST_F(FormatTest, FormatStarDependingOnContext) { - verifyFormat("void f(int *a);"); - verifyFormat("void f() { f(fint * b); }"); - verifyFormat("class A {\n void f(int *a);\n};"); - verifyFormat("class A {\n int *a;\n};"); - verifyFormat("namespace a {\n" - "namespace b {\n" - "class A {\n" - " void f() {}\n" - " int *a;\n" - "};\n" - "} // namespace b\n" - "} // namespace a"); -} - -TEST_F(FormatTest, SpecialTokensAtEndOfLine) { - verifyFormat("while"); - verifyFormat("operator"); -} - -TEST_F(FormatTest, SkipsDeeplyNestedLines) { - // This code would be painfully slow to format if we didn't skip it. - std::string Code("A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(\n" // 20x - "A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(\n" - "A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(\n" - "A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(\n" - "A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(A(\n" - "A(1, 1)\n" - ", 1), 1), 1), 1), 1), 1), 1), 1), 1), 1)\n" // 10x - ", 1), 1), 1), 1), 1), 1), 1), 1), 1), 1)\n" - ", 1), 1), 1), 1), 1), 1), 1), 1), 1), 1)\n" - ", 1), 1), 1), 1), 1), 1), 1), 1), 1), 1)\n" - ", 1), 1), 1), 1), 1), 1), 1), 1), 1), 1)\n" - ", 1), 1), 1), 1), 1), 1), 1), 1), 1), 1)\n" - ", 1), 1), 1), 1), 1), 1), 1), 1), 1), 1)\n" - ", 1), 1), 1), 1), 1), 1), 1), 1), 1), 1)\n" - ", 1), 1), 1), 1), 1), 1), 1), 1), 1), 1)\n" - ", 1), 1), 1), 1), 1), 1), 1), 1), 1), 1);\n"); - // Deeply nested part is untouched, rest is formatted. - EXPECT_EQ(std::string("int i;\n") + Code + "int j;\n", - format(std::string("int i;\n") + Code + "int j;\n", - getLLVMStyle(), SC_ExpectIncomplete)); -} - -//===----------------------------------------------------------------------===// -// Objective-C tests. -//===----------------------------------------------------------------------===// - -TEST_F(FormatTest, FormatForObjectiveCMethodDecls) { - verifyFormat("- (void)sendAction:(SEL)aSelector to:(BOOL)anObject;"); - EXPECT_EQ("- (NSUInteger)indexOfObject:(id)anObject;", - format("-(NSUInteger)indexOfObject:(id)anObject;")); - EXPECT_EQ("- (NSInteger)Mthod1;", format("-(NSInteger)Mthod1;")); - EXPECT_EQ("+ (id)Mthod2;", format("+(id)Mthod2;")); - EXPECT_EQ("- (NSInteger)Method3:(id)anObject;", - format("-(NSInteger)Method3:(id)anObject;")); - EXPECT_EQ("- (NSInteger)Method4:(id)anObject;", - format("-(NSInteger)Method4:(id)anObject;")); - EXPECT_EQ("- (NSInteger)Method5:(id)anObject:(id)AnotherObject;", - format("-(NSInteger)Method5:(id)anObject:(id)AnotherObject;")); - EXPECT_EQ("- (id)Method6:(id)A:(id)B:(id)C:(id)D;", - format("- (id)Method6:(id)A:(id)B:(id)C:(id)D;")); - EXPECT_EQ("- (void)sendAction:(SEL)aSelector to:(id)anObject " - "forAllCells:(BOOL)flag;", - format("- (void)sendAction:(SEL)aSelector to:(id)anObject " - "forAllCells:(BOOL)flag;")); - - // Very long objectiveC method declaration. - verifyFormat("- (void)aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa:\n" - " (SoooooooooooooooooooooomeType *)bbbbbbbbbb;"); - verifyFormat("- (NSUInteger)indexOfObject:(id)anObject\n" - " inRange:(NSRange)range\n" - " outRange:(NSRange)out_range\n" - " outRange1:(NSRange)out_range1\n" - " outRange2:(NSRange)out_range2\n" - " outRange3:(NSRange)out_range3\n" - " outRange4:(NSRange)out_range4\n" - " outRange5:(NSRange)out_range5\n" - " outRange6:(NSRange)out_range6\n" - " outRange7:(NSRange)out_range7\n" - " outRange8:(NSRange)out_range8\n" - " outRange9:(NSRange)out_range9;"); - - // When the function name has to be wrapped. - FormatStyle Style = getLLVMStyle(); - // ObjC ignores IndentWrappedFunctionNames when wrapping methods - // and always indents instead. - Style.IndentWrappedFunctionNames = false; - verifyFormat("- (SomeLooooooooooooooooooooongType *)\n" - " veryLooooooooooongName:(NSString)aaaaaaaaaaaaaa\n" - " anotherName:(NSString)bbbbbbbbbbbbbb {\n" - "}", - Style); - Style.IndentWrappedFunctionNames = true; - verifyFormat("- (SomeLooooooooooooooooooooongType *)\n" - " veryLooooooooooongName:(NSString)cccccccccccccc\n" - " anotherName:(NSString)dddddddddddddd {\n" - "}", - Style); - - verifyFormat("- (int)sum:(vector<int>)numbers;"); - verifyGoogleFormat("- (void)setDelegate:(id<Protocol>)delegate;"); - // FIXME: In LLVM style, there should be a space in front of a '<' for ObjC - // protocol lists (but not for template classes): - // verifyFormat("- (void)setDelegate:(id <Protocol>)delegate;"); - - verifyFormat("- (int (*)())foo:(int (*)())f;"); - verifyGoogleFormat("- (int (*)())foo:(int (*)())foo;"); - - // If there's no return type (very rare in practice!), LLVM and Google style - // agree. - verifyFormat("- foo;"); - verifyFormat("- foo:(int)f;"); - verifyGoogleFormat("- foo:(int)foo;"); -} - - -TEST_F(FormatTest, BreaksStringLiterals) { - EXPECT_EQ("\"some text \"\n" - "\"other\";", - format("\"some text other\";", getLLVMStyleWithColumns(12))); - EXPECT_EQ("\"some text \"\n" - "\"other\";", - format("\\\n\"some text other\";", getLLVMStyleWithColumns(12))); - EXPECT_EQ( - "#define A \\\n" - " \"some \" \\\n" - " \"text \" \\\n" - " \"other\";", - format("#define A \"some text other\";", getLLVMStyleWithColumns(12))); - EXPECT_EQ( - "#define A \\\n" - " \"so \" \\\n" - " \"text \" \\\n" - " \"other\";", - format("#define A \"so text other\";", getLLVMStyleWithColumns(12))); - - EXPECT_EQ("\"some text\"", - format("\"some text\"", getLLVMStyleWithColumns(1))); - EXPECT_EQ("\"some text\"", - format("\"some text\"", getLLVMStyleWithColumns(11))); - EXPECT_EQ("\"some \"\n" - "\"text\"", - format("\"some text\"", getLLVMStyleWithColumns(10))); - EXPECT_EQ("\"some \"\n" - "\"text\"", - format("\"some text\"", getLLVMStyleWithColumns(7))); - EXPECT_EQ("\"some\"\n" - "\" tex\"\n" - "\"t\"", - format("\"some text\"", getLLVMStyleWithColumns(6))); - EXPECT_EQ("\"some\"\n" - "\" tex\"\n" - "\" and\"", - format("\"some tex and\"", getLLVMStyleWithColumns(6))); - EXPECT_EQ("\"some\"\n" - "\"/tex\"\n" - "\"/and\"", - format("\"some/tex/and\"", getLLVMStyleWithColumns(6))); - - EXPECT_EQ("variable =\n" - " \"long string \"\n" - " \"literal\";", - format("variable = \"long string literal\";", - getLLVMStyleWithColumns(20))); - - EXPECT_EQ("variable = f(\n" - " \"long string \"\n" - " \"literal\",\n" - " short,\n" - " loooooooooooooooooooong);", - format("variable = f(\"long string literal\", short, " - "loooooooooooooooooooong);", - getLLVMStyleWithColumns(20))); - - EXPECT_EQ( - "f(g(\"long string \"\n" - " \"literal\"),\n" - " b);", - format("f(g(\"long string literal\"), b);", getLLVMStyleWithColumns(20))); - EXPECT_EQ("f(g(\"long string \"\n" - " \"literal\",\n" - " a),\n" - " b);", - format("f(g(\"long string literal\", a), b);", - getLLVMStyleWithColumns(20))); - EXPECT_EQ( - "f(\"one two\".split(\n" - " variable));", - format("f(\"one two\".split(variable));", getLLVMStyleWithColumns(20))); - EXPECT_EQ("f(\"one two three four five six \"\n" - " \"seven\".split(\n" - " really_looooong_variable));", - format("f(\"one two three four five six seven\"." - "split(really_looooong_variable));", - getLLVMStyleWithColumns(33))); - - EXPECT_EQ("f(\"some \"\n" - " \"text\",\n" - " other);", - format("f(\"some text\", other);", getLLVMStyleWithColumns(10))); - - // Only break as a last resort. - verifyFormat( - "aaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaa(\"aaa aaaaa aaa aaa aaaaa aaa aaaaa aaa aaa aaaaaa\"));"); - - EXPECT_EQ("\"splitmea\"\n" - "\"trandomp\"\n" - "\"oint\"", - format("\"splitmeatrandompoint\"", getLLVMStyleWithColumns(10))); - - EXPECT_EQ("\"split/\"\n" - "\"pathat/\"\n" - "\"slashes\"", - format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10))); - - EXPECT_EQ("\"split/\"\n" - "\"pathat/\"\n" - "\"slashes\"", - format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10))); - EXPECT_EQ("\"split at \"\n" - "\"spaces/at/\"\n" - "\"slashes.at.any$\"\n" - "\"non-alphanumeric%\"\n" - "\"1111111111characte\"\n" - "\"rs\"", - format("\"split at " - "spaces/at/" - "slashes.at." - "any$non-" - "alphanumeric%" - "1111111111characte" - "rs\"", - getLLVMStyleWithColumns(20))); - - // Verify that splitting the strings understands - // Style::AlwaysBreakBeforeMultilineStrings. - EXPECT_EQ( - "aaaaaaaaaaaa(\n" - " \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa \"\n" - " \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa\");", - format("aaaaaaaaaaaa(\"aaaaaaaaaaaaaaaaaaaaaaaaaa " - "aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaa " - "aaaaaaaaaaaaaaaaaaaaaa\");", - getGoogleStyle())); - EXPECT_EQ("return \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" - " \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa\";", - format("return \"aaaaaaaaaaaaaaaaaaaaaa " - "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaa " - "aaaaaaaaaaaaaaaaaaaaaa\";", - getGoogleStyle())); - EXPECT_EQ("llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" - " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";", - format("llvm::outs() << " - "\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaa" - "aaaaaaaaaaaaaaaaaaa\";")); - EXPECT_EQ("ffff(\n" - " {\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" - " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"});", - format("ffff({\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa " - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"});", - getGoogleStyle())); - - FormatStyle Style = getLLVMStyleWithColumns(12); - Style.BreakStringLiterals = false; - EXPECT_EQ("\"some text other\";", format("\"some text other\";", Style)); - - FormatStyle AlignLeft = getLLVMStyleWithColumns(12); - AlignLeft.AlignEscapedNewlines = FormatStyle::ENAS_Left; - EXPECT_EQ("#define A \\\n" - " \"some \" \\\n" - " \"text \" \\\n" - " \"other\";", - format("#define A \"some text other\";", AlignLeft)); -} - -TEST_F(FormatTest, BreaksStringLiteralsAtColumnLimit) { - EXPECT_EQ("C a = \"some more \"\n" - " \"text\";", - format("C a = \"some more text\";", getLLVMStyleWithColumns(18))); -} - -TEST_F(FormatTest, FullyRemoveEmptyLines) { - FormatStyle NoEmptyLines = getLLVMStyleWithColumns(80); - NoEmptyLines.MaxEmptyLinesToKeep = 0; - EXPECT_EQ("int i = a(b());", - format("int i=a(\n\n b(\n\n\n )\n\n);", NoEmptyLines)); -} - -TEST_F(FormatTest, BreaksStringLiteralsWithTabs) { - EXPECT_EQ( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" - "(\n" - " \"x\t\");", - format("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" - "aaaaaaa(" - "\"x\t\");")); -} - -TEST_F(FormatTest, BreaksWideAndNSStringLiterals) { - EXPECT_EQ( - "u8\"utf8 string \"\n" - "u8\"literal\";", - format("u8\"utf8 string literal\";", getGoogleStyleWithColumns(16))); - EXPECT_EQ( - "u\"utf16 string \"\n" - "u\"literal\";", - format("u\"utf16 string literal\";", getGoogleStyleWithColumns(16))); - EXPECT_EQ( - "U\"utf32 string \"\n" - "U\"literal\";", - format("U\"utf32 string literal\";", getGoogleStyleWithColumns(16))); - EXPECT_EQ("L\"wide string \"\n" - "L\"literal\";", - format("L\"wide string literal\";", getGoogleStyleWithColumns(16))); - EXPECT_EQ("@\"NSString \"\n" - "@\"literal\";", - format("@\"NSString literal\";", getGoogleStyleWithColumns(19))); - verifyFormat(R"(NSString *s = @"那那那那";)", getLLVMStyleWithColumns(26)); - - // This input makes clang-format try to split the incomplete unicode escape - // sequence, which used to lead to a crasher. - verifyNoCrash( - "aaaaaaaaaaaaaaaaaaaa = L\"\\udff\"'; // aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", - getLLVMStyleWithColumns(60)); -} - -TEST_F(FormatTest, DoesNotBreakRawStringLiterals) { - FormatStyle Style = getGoogleStyleWithColumns(15); - EXPECT_EQ("R\"x(raw literal)x\";", format("R\"x(raw literal)x\";", Style)); - EXPECT_EQ("uR\"x(raw literal)x\";", format("uR\"x(raw literal)x\";", Style)); - EXPECT_EQ("LR\"x(raw literal)x\";", format("LR\"x(raw literal)x\";", Style)); - EXPECT_EQ("UR\"x(raw literal)x\";", format("UR\"x(raw literal)x\";", Style)); - EXPECT_EQ("u8R\"x(raw literal)x\";", - format("u8R\"x(raw literal)x\";", Style)); -} - -TEST_F(FormatTest, BreaksStringLiteralsWithin_TMacro) { - FormatStyle Style = getLLVMStyleWithColumns(20); - EXPECT_EQ( - "_T(\"aaaaaaaaaaaaaa\")\n" - "_T(\"aaaaaaaaaaaaaa\")\n" - "_T(\"aaaaaaaaaaaa\")", - format(" _T(\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\")", Style)); - EXPECT_EQ("f(x,\n" - " _T(\"aaaaaaaaaaaa\")\n" - " _T(\"aaa\"),\n" - " z);", - format("f(x, _T(\"aaaaaaaaaaaaaaa\"), z);", Style)); - - // FIXME: Handle embedded spaces in one iteration. - // EXPECT_EQ("_T(\"aaaaaaaaaaaaa\")\n" - // "_T(\"aaaaaaaaaaaaa\")\n" - // "_T(\"aaaaaaaaaaaaa\")\n" - // "_T(\"a\")", - // format(" _T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", - // getLLVMStyleWithColumns(20))); - EXPECT_EQ( - "_T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", - format(" _T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", Style)); - EXPECT_EQ("f(\n" - "#if !TEST\n" - " _T(\"XXXXXXXXXXXXXXXXXXXXXXXXXXXXXn\")\n" - "#endif\n" - ");", - format("f(\n" - "#if !TEST\n" - "_T(\"XXXXXXXXXXXXXXXXXXXXXXXXXXXXXn\")\n" - "#endif\n" - ");")); - EXPECT_EQ("f(\n" - "\n" - " _T(\"XXXXXXXXXXXXXXXXXXXXXXXXXXXXXn\"));", - format("f(\n" - "\n" - "_T(\"XXXXXXXXXXXXXXXXXXXXXXXXXXXXXn\"));")); -} - -TEST_F(FormatTest, BreaksStringLiteralOperands) { - // In a function call with two operands, the second can be broken with no line - // break before it. - EXPECT_EQ("func(a, \"long long \"\n" - " \"long long\");", - format("func(a, \"long long long long\");", - getLLVMStyleWithColumns(24))); - // In a function call with three operands, the second must be broken with a - // line break before it. - EXPECT_EQ("func(a,\n" - " \"long long long \"\n" - " \"long\",\n" - " c);", - format("func(a, \"long long long long\", c);", - getLLVMStyleWithColumns(24))); - // In a function call with three operands, the third must be broken with a - // line break before it. - EXPECT_EQ("func(a, b,\n" - " \"long long long \"\n" - " \"long\");", - format("func(a, b, \"long long long long\");", - getLLVMStyleWithColumns(24))); - // In a function call with three operands, both the second and the third must - // be broken with a line break before them. - EXPECT_EQ("func(a,\n" - " \"long long long \"\n" - " \"long\",\n" - " \"long long long \"\n" - " \"long\");", - format("func(a, \"long long long long\", \"long long long long\");", - getLLVMStyleWithColumns(24))); - // In a chain of << with two operands, the second can be broken with no line - // break before it. - EXPECT_EQ("a << \"line line \"\n" - " \"line\";", - format("a << \"line line line\";", - getLLVMStyleWithColumns(20))); - // In a chain of << with three operands, the second can be broken with no line - // break before it. - EXPECT_EQ("abcde << \"line \"\n" - " \"line line\"\n" - " << c;", - format("abcde << \"line line line\" << c;", - getLLVMStyleWithColumns(20))); - // In a chain of << with three operands, the third must be broken with a line - // break before it. - EXPECT_EQ("a << b\n" - " << \"line line \"\n" - " \"line\";", - format("a << b << \"line line line\";", - getLLVMStyleWithColumns(20))); - // In a chain of << with three operands, the second can be broken with no line - // break before it and the third must be broken with a line break before it. - EXPECT_EQ("abcd << \"line line \"\n" - " \"line\"\n" - " << \"line line \"\n" - " \"line\";", - format("abcd << \"line line line\" << \"line line line\";", - getLLVMStyleWithColumns(20))); - // In a chain of binary operators with two operands, the second can be broken - // with no line break before it. - EXPECT_EQ("abcd + \"line line \"\n" - " \"line line\";", - format("abcd + \"line line line line\";", - getLLVMStyleWithColumns(20))); - // In a chain of binary operators with three operands, the second must be - // broken with a line break before it. - EXPECT_EQ("abcd +\n" - " \"line line \"\n" - " \"line line\" +\n" - " e;", - format("abcd + \"line line line line\" + e;", - getLLVMStyleWithColumns(20))); - // In a function call with two operands, with AlignAfterOpenBracket enabled, - // the first must be broken with a line break before it. - FormatStyle Style = getLLVMStyleWithColumns(25); - Style.AlignAfterOpenBracket = FormatStyle::BAS_AlwaysBreak; - EXPECT_EQ("someFunction(\n" - " \"long long long \"\n" - " \"long\",\n" - " a);", - format("someFunction(\"long long long long\", a);", Style)); -} - -TEST_F(FormatTest, DontSplitStringLiteralsWithEscapedNewlines) { - EXPECT_EQ( - "aaaaaaaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";", - format("aaaaaaaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";")); -} - -TEST_F(FormatTest, CountsCharactersInMultilineRawStringLiterals) { - EXPECT_EQ("f(g(R\"x(raw literal)x\", a), b);", - format("f(g(R\"x(raw literal)x\", a), b);", getGoogleStyle())); - EXPECT_EQ("fffffffffff(g(R\"x(\n" - "multiline raw string literal xxxxxxxxxxxxxx\n" - ")x\",\n" - " a),\n" - " b);", - format("fffffffffff(g(R\"x(\n" - "multiline raw string literal xxxxxxxxxxxxxx\n" - ")x\", a), b);", - getGoogleStyleWithColumns(20))); - EXPECT_EQ("fffffffffff(\n" - " g(R\"x(qqq\n" - "multiline raw string literal xxxxxxxxxxxxxx\n" - ")x\",\n" - " a),\n" - " b);", - format("fffffffffff(g(R\"x(qqq\n" - "multiline raw string literal xxxxxxxxxxxxxx\n" - ")x\", a), b);", - getGoogleStyleWithColumns(20))); - - EXPECT_EQ("fffffffffff(R\"x(\n" - "multiline raw string literal xxxxxxxxxxxxxx\n" - ")x\");", - format("fffffffffff(R\"x(\n" - "multiline raw string literal xxxxxxxxxxxxxx\n" - ")x\");", - getGoogleStyleWithColumns(20))); - EXPECT_EQ("fffffffffff(R\"x(\n" - "multiline raw string literal xxxxxxxxxxxxxx\n" - ")x\" + bbbbbb);", - format("fffffffffff(R\"x(\n" - "multiline raw string literal xxxxxxxxxxxxxx\n" - ")x\" + bbbbbb);", - getGoogleStyleWithColumns(20))); - EXPECT_EQ("fffffffffff(\n" - " R\"x(\n" - "multiline raw string literal xxxxxxxxxxxxxx\n" - ")x\" +\n" - " bbbbbb);", - format("fffffffffff(\n" - " R\"x(\n" - "multiline raw string literal xxxxxxxxxxxxxx\n" - ")x\" + bbbbbb);", - getGoogleStyleWithColumns(20))); - EXPECT_EQ("fffffffffff(R\"(single line raw string)\" + bbbbbb);", - format("fffffffffff(\n" - " R\"(single line raw string)\" + bbbbbb);")); -} - -TEST_F(FormatTest, SkipsUnknownStringLiterals) { - verifyFormat("string a = \"unterminated;"); - EXPECT_EQ("function(\"unterminated,\n" - " OtherParameter);", - format("function( \"unterminated,\n" - " OtherParameter);")); -} - -TEST_F(FormatTest, DoesNotTryToParseUDLiteralsInPreCpp11Code) { - FormatStyle Style = getLLVMStyle(); - Style.Standard = FormatStyle::LS_Cpp03; - EXPECT_EQ("#define x(_a) printf(\"foo\" _a);", - format("#define x(_a) printf(\"foo\"_a);", Style)); -} - -TEST_F(FormatTest, UnderstandsCpp1y) { verifyFormat("int bi{1'000'000};"); } - -TEST_F(FormatTest, BreakStringLiteralsBeforeUnbreakableTokenSequence) { - EXPECT_EQ("someFunction(\"aaabbbcccd\"\n" - " \"ddeeefff\");", - format("someFunction(\"aaabbbcccdddeeefff\");", - getLLVMStyleWithColumns(25))); - EXPECT_EQ("someFunction1234567890(\n" - " \"aaabbbcccdddeeefff\");", - format("someFunction1234567890(\"aaabbbcccdddeeefff\");", - getLLVMStyleWithColumns(26))); - EXPECT_EQ("someFunction1234567890(\n" - " \"aaabbbcccdddeeeff\"\n" - " \"f\");", - format("someFunction1234567890(\"aaabbbcccdddeeefff\");", - getLLVMStyleWithColumns(25))); - EXPECT_EQ("someFunction1234567890(\n" - " \"aaabbbcccdddeeeff\"\n" - " \"f\");", - format("someFunction1234567890(\"aaabbbcccdddeeefff\");", - getLLVMStyleWithColumns(24))); - EXPECT_EQ("someFunction(\n" - " \"aaabbbcc ddde \"\n" - " \"efff\");", - format("someFunction(\"aaabbbcc ddde efff\");", - getLLVMStyleWithColumns(25))); - EXPECT_EQ("someFunction(\"aaabbbccc \"\n" - " \"ddeeefff\");", - format("someFunction(\"aaabbbccc ddeeefff\");", - getLLVMStyleWithColumns(25))); - EXPECT_EQ("someFunction1234567890(\n" - " \"aaabb \"\n" - " \"cccdddeeefff\");", - format("someFunction1234567890(\"aaabb cccdddeeefff\");", - getLLVMStyleWithColumns(25))); - EXPECT_EQ("#define A \\\n" - " string s = \\\n" - " \"123456789\" \\\n" - " \"0\"; \\\n" - " int i;", - format("#define A string s = \"1234567890\"; int i;", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("someFunction(\n" - " \"aaabbbcc \"\n" - " \"dddeeefff\");", - format("someFunction(\"aaabbbcc dddeeefff\");", - getLLVMStyleWithColumns(25))); -} - -TEST_F(FormatTest, DoNotBreakStringLiteralsInEscapeSequence) { - EXPECT_EQ("\"\\a\"", format("\"\\a\"", getLLVMStyleWithColumns(3))); - EXPECT_EQ("\"\\\"", format("\"\\\"", getLLVMStyleWithColumns(2))); - EXPECT_EQ("\"test\"\n" - "\"\\n\"", - format("\"test\\n\"", getLLVMStyleWithColumns(7))); - EXPECT_EQ("\"tes\\\\\"\n" - "\"n\"", - format("\"tes\\\\n\"", getLLVMStyleWithColumns(7))); - EXPECT_EQ("\"\\\\\\\\\"\n" - "\"\\n\"", - format("\"\\\\\\\\\\n\"", getLLVMStyleWithColumns(7))); - EXPECT_EQ("\"\\uff01\"", format("\"\\uff01\"", getLLVMStyleWithColumns(7))); - EXPECT_EQ("\"\\uff01\"\n" - "\"test\"", - format("\"\\uff01test\"", getLLVMStyleWithColumns(8))); - EXPECT_EQ("\"\\Uff01ff02\"", - format("\"\\Uff01ff02\"", getLLVMStyleWithColumns(11))); - EXPECT_EQ("\"\\x000000000001\"\n" - "\"next\"", - format("\"\\x000000000001next\"", getLLVMStyleWithColumns(16))); - EXPECT_EQ("\"\\x000000000001next\"", - format("\"\\x000000000001next\"", getLLVMStyleWithColumns(15))); - EXPECT_EQ("\"\\x000000000001\"", - format("\"\\x000000000001\"", getLLVMStyleWithColumns(7))); - EXPECT_EQ("\"test\"\n" - "\"\\000000\"\n" - "\"000001\"", - format("\"test\\000000000001\"", getLLVMStyleWithColumns(9))); - EXPECT_EQ("\"test\\000\"\n" - "\"00000000\"\n" - "\"1\"", - format("\"test\\000000000001\"", getLLVMStyleWithColumns(10))); -} - -TEST_F(FormatTest, DoNotCreateUnreasonableUnwrappedLines) { - verifyFormat("void f() {\n" - " return g() {}\n" - " void h() {}"); - verifyFormat("int a[] = {void forgot_closing_brace(){f();\n" - "g();\n" - "}"); -} - -TEST_F(FormatTest, DoNotPrematurelyEndUnwrappedLineForReturnStatements) { - verifyFormat( - "void f() { return C{param1, param2}.SomeCall(param1, param2); }"); -} - -TEST_F(FormatTest, FormatsClosingBracesInEmptyNestedBlocks) { - verifyFormat("class X {\n" - " void f() {\n" - " }\n" - "};", - getLLVMStyleWithColumns(12)); -} - -TEST_F(FormatTest, ConfigurableIndentWidth) { - FormatStyle EightIndent = getLLVMStyleWithColumns(18); - EightIndent.IndentWidth = 8; - EightIndent.ContinuationIndentWidth = 8; - verifyFormat("void f() {\n" - " someFunction();\n" - " if (true) {\n" - " f();\n" - " }\n" - "}", - EightIndent); - verifyFormat("class X {\n" - " void f() {\n" - " }\n" - "};", - EightIndent); - verifyFormat("int x[] = {\n" - " call(),\n" - " call()};", - EightIndent); -} - -TEST_F(FormatTest, ConfigurableFunctionDeclarationIndentAfterType) { - verifyFormat("double\n" - "f();", - getLLVMStyleWithColumns(8)); -} - -TEST_F(FormatTest, ConfigurableUseOfTab) { - FormatStyle Tab = getLLVMStyleWithColumns(42); - Tab.IndentWidth = 8; - Tab.UseTab = FormatStyle::UT_Always; - Tab.AlignEscapedNewlines = FormatStyle::ENAS_Left; - - EXPECT_EQ("if (aaaaaaaa && // q\n" - " bb)\t\t// w\n" - "\t;", - format("if (aaaaaaaa &&// q\n" - "bb)// w\n" - ";", - Tab)); - EXPECT_EQ("if (aaa && bbb) // w\n" - "\t;", - format("if(aaa&&bbb)// w\n" - ";", - Tab)); - - verifyFormat("class X {\n" - "\tvoid f() {\n" - "\t\tsomeFunction(parameter1,\n" - "\t\t\t parameter2);\n" - "\t}\n" - "};", - Tab); - verifyFormat("#define A \\\n" - "\tvoid f() { \\\n" - "\t\tsomeFunction( \\\n" - "\t\t parameter1, \\\n" - "\t\t parameter2); \\\n" - "\t}", - Tab); - - Tab.TabWidth = 4; - Tab.IndentWidth = 8; - verifyFormat("class TabWidth4Indent8 {\n" - "\t\tvoid f() {\n" - "\t\t\t\tsomeFunction(parameter1,\n" - "\t\t\t\t\t\t\t parameter2);\n" - "\t\t}\n" - "};", - Tab); - - Tab.TabWidth = 4; - Tab.IndentWidth = 4; - verifyFormat("class TabWidth4Indent4 {\n" - "\tvoid f() {\n" - "\t\tsomeFunction(parameter1,\n" - "\t\t\t\t\t parameter2);\n" - "\t}\n" - "};", - Tab); - - Tab.TabWidth = 8; - Tab.IndentWidth = 4; - verifyFormat("class TabWidth8Indent4 {\n" - " void f() {\n" - "\tsomeFunction(parameter1,\n" - "\t\t parameter2);\n" - " }\n" - "};", - Tab); - - Tab.TabWidth = 8; - Tab.IndentWidth = 8; - EXPECT_EQ("/*\n" - "\t a\t\tcomment\n" - "\t in multiple lines\n" - " */", - format(" /*\t \t \n" - " \t \t a\t\tcomment\t \t\n" - " \t \t in multiple lines\t\n" - " \t */", - Tab)); - - Tab.UseTab = FormatStyle::UT_ForIndentation; - verifyFormat("{\n" - "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" - "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" - "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" - "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" - "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" - "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" - "};", - Tab); - verifyFormat("enum AA {\n" - "\ta1, // Force multiple lines\n" - "\ta2,\n" - "\ta3\n" - "};", - Tab); - EXPECT_EQ("if (aaaaaaaa && // q\n" - " bb) // w\n" - "\t;", - format("if (aaaaaaaa &&// q\n" - "bb)// w\n" - ";", - Tab)); - verifyFormat("class X {\n" - "\tvoid f() {\n" - "\t\tsomeFunction(parameter1,\n" - "\t\t parameter2);\n" - "\t}\n" - "};", - Tab); - verifyFormat("{\n" - "\tQ(\n" - "\t {\n" - "\t\t int a;\n" - "\t\t someFunction(aaaaaaaa,\n" - "\t\t bbbbbbb);\n" - "\t },\n" - "\t p);\n" - "}", - Tab); - EXPECT_EQ("{\n" - "\t/* aaaa\n" - "\t bbbb */\n" - "}", - format("{\n" - "/* aaaa\n" - " bbbb */\n" - "}", - Tab)); - EXPECT_EQ("{\n" - "\t/*\n" - "\t aaaaaaaaaaaaaaaaaaaaaaaaaa\n" - "\t bbbbbbbbbbbbb\n" - "\t*/\n" - "}", - format("{\n" - "/*\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" - "*/\n" - "}", - Tab)); - EXPECT_EQ("{\n" - "\t// aaaaaaaaaaaaaaaaaaaaaaaaaa\n" - "\t// bbbbbbbbbbbbb\n" - "}", - format("{\n" - "\t// aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" - "}", - Tab)); - EXPECT_EQ("{\n" - "\t/*\n" - "\t aaaaaaaaaaaaaaaaaaaaaaaaaa\n" - "\t bbbbbbbbbbbbb\n" - "\t*/\n" - "}", - format("{\n" - "\t/*\n" - "\t aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" - "\t*/\n" - "}", - Tab)); - EXPECT_EQ("{\n" - "\t/*\n" - "\n" - "\t*/\n" - "}", - format("{\n" - "\t/*\n" - "\n" - "\t*/\n" - "}", - Tab)); - EXPECT_EQ("{\n" - "\t/*\n" - " asdf\n" - "\t*/\n" - "}", - format("{\n" - "\t/*\n" - " asdf\n" - "\t*/\n" - "}", - Tab)); - - Tab.UseTab = FormatStyle::UT_Never; - EXPECT_EQ("/*\n" - " a\t\tcomment\n" - " in multiple lines\n" - " */", - format(" /*\t \t \n" - " \t \t a\t\tcomment\t \t\n" - " \t \t in multiple lines\t\n" - " \t */", - Tab)); - EXPECT_EQ("/* some\n" - " comment */", - format(" \t \t /* some\n" - " \t \t comment */", - Tab)); - EXPECT_EQ("int a; /* some\n" - " comment */", - format(" \t \t int a; /* some\n" - " \t \t comment */", - Tab)); - - EXPECT_EQ("int a; /* some\n" - "comment */", - format(" \t \t int\ta; /* some\n" - " \t \t comment */", - Tab)); - EXPECT_EQ("f(\"\t\t\"); /* some\n" - " comment */", - format(" \t \t f(\"\t\t\"); /* some\n" - " \t \t comment */", - Tab)); - EXPECT_EQ("{\n" - " /*\n" - " * Comment\n" - " */\n" - " int i;\n" - "}", - format("{\n" - "\t/*\n" - "\t * Comment\n" - "\t */\n" - "\t int i;\n" - "}")); - - Tab.UseTab = FormatStyle::UT_ForContinuationAndIndentation; - Tab.TabWidth = 8; - Tab.IndentWidth = 8; - EXPECT_EQ("if (aaaaaaaa && // q\n" - " bb) // w\n" - "\t;", - format("if (aaaaaaaa &&// q\n" - "bb)// w\n" - ";", - Tab)); - EXPECT_EQ("if (aaa && bbb) // w\n" - "\t;", - format("if(aaa&&bbb)// w\n" - ";", - Tab)); - verifyFormat("class X {\n" - "\tvoid f() {\n" - "\t\tsomeFunction(parameter1,\n" - "\t\t\t parameter2);\n" - "\t}\n" - "};", - Tab); - verifyFormat("#define A \\\n" - "\tvoid f() { \\\n" - "\t\tsomeFunction( \\\n" - "\t\t parameter1, \\\n" - "\t\t parameter2); \\\n" - "\t}", - Tab); - Tab.TabWidth = 4; - Tab.IndentWidth = 8; - verifyFormat("class TabWidth4Indent8 {\n" - "\t\tvoid f() {\n" - "\t\t\t\tsomeFunction(parameter1,\n" - "\t\t\t\t\t\t\t parameter2);\n" - "\t\t}\n" - "};", - Tab); - Tab.TabWidth = 4; - Tab.IndentWidth = 4; - verifyFormat("class TabWidth4Indent4 {\n" - "\tvoid f() {\n" - "\t\tsomeFunction(parameter1,\n" - "\t\t\t\t\t parameter2);\n" - "\t}\n" - "};", - Tab); - Tab.TabWidth = 8; - Tab.IndentWidth = 4; - verifyFormat("class TabWidth8Indent4 {\n" - " void f() {\n" - "\tsomeFunction(parameter1,\n" - "\t\t parameter2);\n" - " }\n" - "};", - Tab); - Tab.TabWidth = 8; - Tab.IndentWidth = 8; - EXPECT_EQ("/*\n" - "\t a\t\tcomment\n" - "\t in multiple lines\n" - " */", - format(" /*\t \t \n" - " \t \t a\t\tcomment\t \t\n" - " \t \t in multiple lines\t\n" - " \t */", - Tab)); - verifyFormat("{\n" - "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" - "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" - "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" - "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" - "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" - "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" - "};", - Tab); - verifyFormat("enum AA {\n" - "\ta1, // Force multiple lines\n" - "\ta2,\n" - "\ta3\n" - "};", - Tab); - EXPECT_EQ("if (aaaaaaaa && // q\n" - " bb) // w\n" - "\t;", - format("if (aaaaaaaa &&// q\n" - "bb)// w\n" - ";", - Tab)); - verifyFormat("class X {\n" - "\tvoid f() {\n" - "\t\tsomeFunction(parameter1,\n" - "\t\t\t parameter2);\n" - "\t}\n" - "};", - Tab); - verifyFormat("{\n" - "\tQ(\n" - "\t {\n" - "\t\t int a;\n" - "\t\t someFunction(aaaaaaaa,\n" - "\t\t\t\t bbbbbbb);\n" - "\t },\n" - "\t p);\n" - "}", - Tab); - EXPECT_EQ("{\n" - "\t/* aaaa\n" - "\t bbbb */\n" - "}", - format("{\n" - "/* aaaa\n" - " bbbb */\n" - "}", - Tab)); - EXPECT_EQ("{\n" - "\t/*\n" - "\t aaaaaaaaaaaaaaaaaaaaaaaaaa\n" - "\t bbbbbbbbbbbbb\n" - "\t*/\n" - "}", - format("{\n" - "/*\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" - "*/\n" - "}", - Tab)); - EXPECT_EQ("{\n" - "\t// aaaaaaaaaaaaaaaaaaaaaaaaaa\n" - "\t// bbbbbbbbbbbbb\n" - "}", - format("{\n" - "\t// aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" - "}", - Tab)); - EXPECT_EQ("{\n" - "\t/*\n" - "\t aaaaaaaaaaaaaaaaaaaaaaaaaa\n" - "\t bbbbbbbbbbbbb\n" - "\t*/\n" - "}", - format("{\n" - "\t/*\n" - "\t aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" - "\t*/\n" - "}", - Tab)); - EXPECT_EQ("{\n" - "\t/*\n" - "\n" - "\t*/\n" - "}", - format("{\n" - "\t/*\n" - "\n" - "\t*/\n" - "}", - Tab)); - EXPECT_EQ("{\n" - "\t/*\n" - " asdf\n" - "\t*/\n" - "}", - format("{\n" - "\t/*\n" - " asdf\n" - "\t*/\n" - "}", - Tab)); - EXPECT_EQ("/*\n" - "\t a\t\tcomment\n" - "\t in multiple lines\n" - " */", - format(" /*\t \t \n" - " \t \t a\t\tcomment\t \t\n" - " \t \t in multiple lines\t\n" - " \t */", - Tab)); - EXPECT_EQ("/* some\n" - " comment */", - format(" \t \t /* some\n" - " \t \t comment */", - Tab)); - EXPECT_EQ("int a; /* some\n" - " comment */", - format(" \t \t int a; /* some\n" - " \t \t comment */", - Tab)); - EXPECT_EQ("int a; /* some\n" - "comment */", - format(" \t \t int\ta; /* some\n" - " \t \t comment */", - Tab)); - EXPECT_EQ("f(\"\t\t\"); /* some\n" - " comment */", - format(" \t \t f(\"\t\t\"); /* some\n" - " \t \t comment */", - Tab)); - EXPECT_EQ("{\n" - " /*\n" - " * Comment\n" - " */\n" - " int i;\n" - "}", - format("{\n" - "\t/*\n" - "\t * Comment\n" - "\t */\n" - "\t int i;\n" - "}")); - Tab.AlignConsecutiveAssignments = true; - Tab.AlignConsecutiveDeclarations = true; - Tab.TabWidth = 4; - Tab.IndentWidth = 4; - verifyFormat("class Assign {\n" - "\tvoid f() {\n" - "\t\tint x = 123;\n" - "\t\tint random = 4;\n" - "\t\tstd::string alphabet =\n" - "\t\t\t\"abcdefghijklmnopqrstuvwxyz\";\n" - "\t}\n" - "};", - Tab); -} - -TEST_F(FormatTest, CalculatesOriginalColumn) { - EXPECT_EQ("\"qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" - "q\"; /* some\n" - " comment */", - format(" \"qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" - "q\"; /* some\n" - " comment */", - getLLVMStyle())); - EXPECT_EQ("// qqqqqqqqqqqqqqqqqqqqqqqqqq\n" - "/* some\n" - " comment */", - format("// qqqqqqqqqqqqqqqqqqqqqqqqqq\n" - " /* some\n" - " comment */", - getLLVMStyle())); - EXPECT_EQ("// qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" - "qqq\n" - "/* some\n" - " comment */", - format("// qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" - "qqq\n" - " /* some\n" - " comment */", - getLLVMStyle())); - EXPECT_EQ("inttt qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" - "wwww; /* some\n" - " comment */", - format(" inttt qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" - "wwww; /* some\n" - " comment */", - getLLVMStyle())); -} - -TEST_F(FormatTest, ConfigurableSpaceBeforeParens) { - FormatStyle NoSpace = getLLVMStyle(); - NoSpace.SpaceBeforeParens = FormatStyle::SBPO_Never; - - verifyFormat("while(true)\n" - " continue;", - NoSpace); - verifyFormat("for(;;)\n" - " continue;", - NoSpace); - verifyFormat("if(true)\n" - " f();\n" - "else if(true)\n" - " f();", - NoSpace); - verifyFormat("do {\n" - " do_something();\n" - "} while(something());", - NoSpace); - verifyFormat("switch(x) {\n" - "default:\n" - " break;\n" - "}", - NoSpace); - verifyFormat("auto i = std::make_unique<int>(5);", NoSpace); - verifyFormat("size_t x = sizeof(x);", NoSpace); - verifyFormat("auto f(int x) -> decltype(x);", NoSpace); - verifyFormat("int f(T x) noexcept(x.create());", NoSpace); - verifyFormat("alignas(128) char a[128];", NoSpace); - verifyFormat("size_t x = alignof(MyType);", NoSpace); - verifyFormat("static_assert(sizeof(char) == 1, \"Impossible!\");", NoSpace); - verifyFormat("int f() throw(Deprecated);", NoSpace); - verifyFormat("typedef void (*cb)(int);", NoSpace); - verifyFormat("T A::operator()();", NoSpace); - verifyFormat("X A::operator++(T);", NoSpace); - - FormatStyle Space = getLLVMStyle(); - Space.SpaceBeforeParens = FormatStyle::SBPO_Always; - - verifyFormat("int f ();", Space); - verifyFormat("void f (int a, T b) {\n" - " while (true)\n" - " continue;\n" - "}", - Space); - verifyFormat("if (true)\n" - " f ();\n" - "else if (true)\n" - " f ();", - Space); - verifyFormat("do {\n" - " do_something ();\n" - "} while (something ());", - Space); - verifyFormat("switch (x) {\n" - "default:\n" - " break;\n" - "}", - Space); - verifyFormat("A::A () : a (1) {}", Space); - verifyFormat("void f () __attribute__ ((asdf));", Space); - verifyFormat("*(&a + 1);\n" - "&((&a)[1]);\n" - "a[(b + c) * d];\n" - "(((a + 1) * 2) + 3) * 4;", - Space); - verifyFormat("#define A(x) x", Space); - verifyFormat("#define A (x) x", Space); - verifyFormat("#if defined(x)\n" - "#endif", - Space); - verifyFormat("auto i = std::make_unique<int> (5);", Space); - verifyFormat("size_t x = sizeof (x);", Space); - verifyFormat("auto f (int x) -> decltype (x);", Space); - verifyFormat("int f (T x) noexcept (x.create ());", Space); - verifyFormat("alignas (128) char a[128];", Space); - verifyFormat("size_t x = alignof (MyType);", Space); - verifyFormat("static_assert (sizeof (char) == 1, \"Impossible!\");", Space); - verifyFormat("int f () throw (Deprecated);", Space); - verifyFormat("typedef void (*cb) (int);", Space); - verifyFormat("T A::operator() ();", Space); - verifyFormat("X A::operator++ (T);", Space); -} - -TEST_F(FormatTest, ConfigurableSpacesInParentheses) { - FormatStyle Spaces = getLLVMStyle(); - - Spaces.SpacesInParentheses = true; - verifyFormat("do_something( ::globalVar );", Spaces); - verifyFormat("call( x, y, z );", Spaces); - verifyFormat("call();", Spaces); - verifyFormat("std::function<void( int, int )> callback;", Spaces); - verifyFormat("void inFunction() { std::function<void( int, int )> fct; }", - Spaces); - verifyFormat("while ( (bool)1 )\n" - " continue;", - Spaces); - verifyFormat("for ( ;; )\n" - " continue;", - Spaces); - verifyFormat("if ( true )\n" - " f();\n" - "else if ( true )\n" - " f();", - Spaces); - verifyFormat("do {\n" - " do_something( (int)i );\n" - "} while ( something() );", - Spaces); - verifyFormat("switch ( x ) {\n" - "default:\n" - " break;\n" - "}", - Spaces); - - Spaces.SpacesInParentheses = false; - Spaces.SpacesInCStyleCastParentheses = true; - verifyFormat("Type *A = ( Type * )P;", Spaces); - verifyFormat("Type *A = ( vector<Type *, int *> )P;", Spaces); - verifyFormat("x = ( int32 )y;", Spaces); - verifyFormat("int a = ( int )(2.0f);", Spaces); - verifyFormat("#define AA(X) sizeof((( X * )NULL)->a)", Spaces); - verifyFormat("my_int a = ( my_int )sizeof(int);", Spaces); - verifyFormat("#define x (( int )-1)", Spaces); - - // Run the first set of tests again with: - Spaces.SpacesInParentheses = false; - Spaces.SpaceInEmptyParentheses = true; - Spaces.SpacesInCStyleCastParentheses = true; - verifyFormat("call(x, y, z);", Spaces); - verifyFormat("call( );", Spaces); - verifyFormat("std::function<void(int, int)> callback;", Spaces); - verifyFormat("while (( bool )1)\n" - " continue;", - Spaces); - verifyFormat("for (;;)\n" - " continue;", - Spaces); - verifyFormat("if (true)\n" - " f( );\n" - "else if (true)\n" - " f( );", - Spaces); - verifyFormat("do {\n" - " do_something(( int )i);\n" - "} while (something( ));", - Spaces); - verifyFormat("switch (x) {\n" - "default:\n" - " break;\n" - "}", - Spaces); - - // Run the first set of tests again with: - Spaces.SpaceAfterCStyleCast = true; - verifyFormat("call(x, y, z);", Spaces); - verifyFormat("call( );", Spaces); - verifyFormat("std::function<void(int, int)> callback;", Spaces); - verifyFormat("while (( bool ) 1)\n" - " continue;", - Spaces); - verifyFormat("for (;;)\n" - " continue;", - Spaces); - verifyFormat("if (true)\n" - " f( );\n" - "else if (true)\n" - " f( );", - Spaces); - verifyFormat("do {\n" - " do_something(( int ) i);\n" - "} while (something( ));", - Spaces); - verifyFormat("switch (x) {\n" - "default:\n" - " break;\n" - "}", - Spaces); - - // Run subset of tests again with: - Spaces.SpacesInCStyleCastParentheses = false; - Spaces.SpaceAfterCStyleCast = true; - verifyFormat("while ((bool) 1)\n" - " continue;", - Spaces); - verifyFormat("do {\n" - " do_something((int) i);\n" - "} while (something( ));", - Spaces); -} - -TEST_F(FormatTest, ConfigurableSpacesInSquareBrackets) { - verifyFormat("int a[5];"); - verifyFormat("a[3] += 42;"); - - FormatStyle Spaces = getLLVMStyle(); - Spaces.SpacesInSquareBrackets = true; - // Lambdas unchanged. - verifyFormat("int c = []() -> int { return 2; }();\n", Spaces); - verifyFormat("return [i, args...] {};", Spaces); - - // Not lambdas. - verifyFormat("int a[ 5 ];", Spaces); - verifyFormat("a[ 3 ] += 42;", Spaces); - verifyFormat("constexpr char hello[]{\"hello\"};", Spaces); - verifyFormat("double &operator[](int i) { return 0; }\n" - "int i;", - Spaces); - verifyFormat("std::unique_ptr<int[]> foo() {}", Spaces); - verifyFormat("int i = a[ a ][ a ]->f();", Spaces); - verifyFormat("int i = (*b)[ a ]->f();", Spaces); -} - -TEST_F(FormatTest, ConfigurableSpaceBeforeAssignmentOperators) { - verifyFormat("int a = 5;"); - verifyFormat("a += 42;"); - verifyFormat("a or_eq 8;"); - - FormatStyle Spaces = getLLVMStyle(); - Spaces.SpaceBeforeAssignmentOperators = false; - verifyFormat("int a= 5;", Spaces); - verifyFormat("a+= 42;", Spaces); - verifyFormat("a or_eq 8;", Spaces); -} - -TEST_F(FormatTest, ConfigurableSpaceBeforeColon) { - verifyFormat("class Foo : public Bar {};"); - verifyFormat("Foo::Foo() : foo(1) {}"); - verifyFormat("for (auto a : b) {\n}"); - verifyFormat("int x = a ? b : c;"); - verifyFormat("{\n" - "label0:\n" - " int x = 0;\n" - "}"); - verifyFormat("switch (x) {\n" - "case 1:\n" - "default:\n" - "}"); - - FormatStyle CtorInitializerStyle = getLLVMStyleWithColumns(30); - CtorInitializerStyle.SpaceBeforeCtorInitializerColon = false; - verifyFormat("class Foo : public Bar {};", CtorInitializerStyle); - verifyFormat("Foo::Foo(): foo(1) {}", CtorInitializerStyle); - verifyFormat("for (auto a : b) {\n}", CtorInitializerStyle); - verifyFormat("int x = a ? b : c;", CtorInitializerStyle); - verifyFormat("{\n" - "label1:\n" - " int x = 0;\n" - "}", - CtorInitializerStyle); - verifyFormat("switch (x) {\n" - "case 1:\n" - "default:\n" - "}", - CtorInitializerStyle); - CtorInitializerStyle.BreakConstructorInitializers = - FormatStyle::BCIS_AfterColon; - verifyFormat("Fooooooooooo::Fooooooooooo():\n" - " aaaaaaaaaaaaaaaa(1),\n" - " bbbbbbbbbbbbbbbb(2) {}", - CtorInitializerStyle); - CtorInitializerStyle.BreakConstructorInitializers = - FormatStyle::BCIS_BeforeComma; - verifyFormat("Fooooooooooo::Fooooooooooo()\n" - " : aaaaaaaaaaaaaaaa(1)\n" - " , bbbbbbbbbbbbbbbb(2) {}", - CtorInitializerStyle); - CtorInitializerStyle.BreakConstructorInitializers = - FormatStyle::BCIS_BeforeColon; - verifyFormat("Fooooooooooo::Fooooooooooo()\n" - " : aaaaaaaaaaaaaaaa(1),\n" - " bbbbbbbbbbbbbbbb(2) {}", - CtorInitializerStyle); - CtorInitializerStyle.ConstructorInitializerIndentWidth = 0; - verifyFormat("Fooooooooooo::Fooooooooooo()\n" - ": aaaaaaaaaaaaaaaa(1),\n" - " bbbbbbbbbbbbbbbb(2) {}", - CtorInitializerStyle); - - FormatStyle InheritanceStyle = getLLVMStyleWithColumns(30); - InheritanceStyle.SpaceBeforeInheritanceColon = false; - verifyFormat("class Foo: public Bar {};", InheritanceStyle); - verifyFormat("Foo::Foo() : foo(1) {}", InheritanceStyle); - verifyFormat("for (auto a : b) {\n}", InheritanceStyle); - verifyFormat("int x = a ? b : c;", InheritanceStyle); - verifyFormat("{\n" - "label2:\n" - " int x = 0;\n" - "}", - InheritanceStyle); - verifyFormat("switch (x) {\n" - "case 1:\n" - "default:\n" - "}", - InheritanceStyle); - InheritanceStyle.BreakInheritanceList = FormatStyle::BILS_AfterColon; - verifyFormat("class Foooooooooooooooooooooo:\n" - " public aaaaaaaaaaaaaaaaaa,\n" - " public bbbbbbbbbbbbbbbbbb {\n" - "}", - InheritanceStyle); - InheritanceStyle.BreakInheritanceList = FormatStyle::BILS_BeforeComma; - verifyFormat("class Foooooooooooooooooooooo\n" - " : public aaaaaaaaaaaaaaaaaa\n" - " , public bbbbbbbbbbbbbbbbbb {\n" - "}", - InheritanceStyle); - InheritanceStyle.BreakInheritanceList = FormatStyle::BILS_BeforeColon; - verifyFormat("class Foooooooooooooooooooooo\n" - " : public aaaaaaaaaaaaaaaaaa,\n" - " public bbbbbbbbbbbbbbbbbb {\n" - "}", - InheritanceStyle); - InheritanceStyle.ConstructorInitializerIndentWidth = 0; - verifyFormat("class Foooooooooooooooooooooo\n" - ": public aaaaaaaaaaaaaaaaaa,\n" - " public bbbbbbbbbbbbbbbbbb {}", - InheritanceStyle); - - FormatStyle ForLoopStyle = getLLVMStyle(); - ForLoopStyle.SpaceBeforeRangeBasedForLoopColon = false; - verifyFormat("class Foo : public Bar {};", ForLoopStyle); - verifyFormat("Foo::Foo() : foo(1) {}", ForLoopStyle); - verifyFormat("for (auto a: b) {\n}", ForLoopStyle); - verifyFormat("int x = a ? b : c;", ForLoopStyle); - verifyFormat("{\n" - "label2:\n" - " int x = 0;\n" - "}", - ForLoopStyle); - verifyFormat("switch (x) {\n" - "case 1:\n" - "default:\n" - "}", - ForLoopStyle); - - FormatStyle NoSpaceStyle = getLLVMStyle(); - NoSpaceStyle.SpaceBeforeCtorInitializerColon = false; - NoSpaceStyle.SpaceBeforeInheritanceColon = false; - NoSpaceStyle.SpaceBeforeRangeBasedForLoopColon = false; - verifyFormat("class Foo: public Bar {};", NoSpaceStyle); - verifyFormat("Foo::Foo(): foo(1) {}", NoSpaceStyle); - verifyFormat("for (auto a: b) {\n}", NoSpaceStyle); - verifyFormat("int x = a ? b : c;", NoSpaceStyle); - verifyFormat("{\n" - "label3:\n" - " int x = 0;\n" - "}", - NoSpaceStyle); - verifyFormat("switch (x) {\n" - "case 1:\n" - "default:\n" - "}", - NoSpaceStyle); -} - -TEST_F(FormatTest, AlignConsecutiveAssignments) { - FormatStyle Alignment = getLLVMStyle(); - Alignment.AlignConsecutiveAssignments = false; - verifyFormat("int a = 5;\n" - "int oneTwoThree = 123;", - Alignment); - verifyFormat("int a = 5;\n" - "int oneTwoThree = 123;", - Alignment); - - Alignment.AlignConsecutiveAssignments = true; - verifyFormat("int a = 5;\n" - "int oneTwoThree = 123;", - Alignment); - verifyFormat("int a = method();\n" - "int oneTwoThree = 133;", - Alignment); - verifyFormat("a &= 5;\n" - "bcd *= 5;\n" - "ghtyf += 5;\n" - "dvfvdb -= 5;\n" - "a /= 5;\n" - "vdsvsv %= 5;\n" - "sfdbddfbdfbb ^= 5;\n" - "dvsdsv |= 5;\n" - "int dsvvdvsdvvv = 123;", - Alignment); - verifyFormat("int i = 1, j = 10;\n" - "something = 2000;", - Alignment); - verifyFormat("something = 2000;\n" - "int i = 1, j = 10;\n", - Alignment); - verifyFormat("something = 2000;\n" - "another = 911;\n" - "int i = 1, j = 10;\n" - "oneMore = 1;\n" - "i = 2;", - Alignment); - verifyFormat("int a = 5;\n" - "int one = 1;\n" - "method();\n" - "int oneTwoThree = 123;\n" - "int oneTwo = 12;", - Alignment); - verifyFormat("int oneTwoThree = 123;\n" - "int oneTwo = 12;\n" - "method();\n", - Alignment); - verifyFormat("int oneTwoThree = 123; // comment\n" - "int oneTwo = 12; // comment", - Alignment); - EXPECT_EQ("int a = 5;\n" - "\n" - "int oneTwoThree = 123;", - format("int a = 5;\n" - "\n" - "int oneTwoThree= 123;", - Alignment)); - EXPECT_EQ("int a = 5;\n" - "int one = 1;\n" - "\n" - "int oneTwoThree = 123;", - format("int a = 5;\n" - "int one = 1;\n" - "\n" - "int oneTwoThree = 123;", - Alignment)); - EXPECT_EQ("int a = 5;\n" - "int one = 1;\n" - "\n" - "int oneTwoThree = 123;\n" - "int oneTwo = 12;", - format("int a = 5;\n" - "int one = 1;\n" - "\n" - "int oneTwoThree = 123;\n" - "int oneTwo = 12;", - Alignment)); - Alignment.AlignEscapedNewlines = FormatStyle::ENAS_DontAlign; - verifyFormat("#define A \\\n" - " int aaaa = 12; \\\n" - " int b = 23; \\\n" - " int ccc = 234; \\\n" - " int dddddddddd = 2345;", - Alignment); - Alignment.AlignEscapedNewlines = FormatStyle::ENAS_Left; - verifyFormat("#define A \\\n" - " int aaaa = 12; \\\n" - " int b = 23; \\\n" - " int ccc = 234; \\\n" - " int dddddddddd = 2345;", - Alignment); - Alignment.AlignEscapedNewlines = FormatStyle::ENAS_Right; - verifyFormat("#define A " - " \\\n" - " int aaaa = 12; " - " \\\n" - " int b = 23; " - " \\\n" - " int ccc = 234; " - " \\\n" - " int dddddddddd = 2345;", - Alignment); - verifyFormat("void SomeFunction(int parameter = 1, int i = 2, int j = 3, int " - "k = 4, int l = 5,\n" - " int m = 6) {\n" - " int j = 10;\n" - " otherThing = 1;\n" - "}", - Alignment); - verifyFormat("void SomeFunction(int parameter = 0) {\n" - " int i = 1;\n" - " int j = 2;\n" - " int big = 10000;\n" - "}", - Alignment); - verifyFormat("class C {\n" - "public:\n" - " int i = 1;\n" - " virtual void f() = 0;\n" - "};", - Alignment); - verifyFormat("int i = 1;\n" - "if (SomeType t = getSomething()) {\n" - "}\n" - "int j = 2;\n" - "int big = 10000;", - Alignment); - verifyFormat("int j = 7;\n" - "for (int k = 0; k < N; ++k) {\n" - "}\n" - "int j = 2;\n" - "int big = 10000;\n" - "}", - Alignment); - Alignment.BreakBeforeBinaryOperators = FormatStyle::BOS_All; - verifyFormat("int i = 1;\n" - "LooooooooooongType loooooooooooooooooooooongVariable\n" - " = someLooooooooooooooooongFunction();\n" - "int j = 2;", - Alignment); - Alignment.BreakBeforeBinaryOperators = FormatStyle::BOS_None; - verifyFormat("int i = 1;\n" - "LooooooooooongType loooooooooooooooooooooongVariable =\n" - " someLooooooooooooooooongFunction();\n" - "int j = 2;", - Alignment); - - verifyFormat("auto lambda = []() {\n" - " auto i = 0;\n" - " return 0;\n" - "};\n" - "int i = 0;\n" - "auto v = type{\n" - " i = 1, //\n" - " (i = 2), //\n" - " i = 3 //\n" - "};", - Alignment); - - verifyFormat( - "int i = 1;\n" - "SomeType a = SomeFunction(looooooooooooooooooooooongParameterA,\n" - " loooooooooooooooooooooongParameterB);\n" - "int j = 2;", - Alignment); - - verifyFormat("template <typename T, typename T_0 = very_long_type_name_0,\n" - " typename B = very_long_type_name_1,\n" - " typename T_2 = very_long_type_name_2>\n" - "auto foo() {}\n", - Alignment); - verifyFormat("int a, b = 1;\n" - "int c = 2;\n" - "int dd = 3;\n", - Alignment); - verifyFormat("int aa = ((1 > 2) ? 3 : 4);\n" - "float b[1][] = {{3.f}};\n", - Alignment); - verifyFormat("for (int i = 0; i < 1; i++)\n" - " int x = 1;\n", - Alignment); - verifyFormat("for (i = 0; i < 1; i++)\n" - " x = 1;\n" - "y = 1;\n", - Alignment); -} - -TEST_F(FormatTest, AlignConsecutiveDeclarations) { - FormatStyle Alignment = getLLVMStyle(); - Alignment.AlignConsecutiveDeclarations = false; - verifyFormat("float const a = 5;\n" - "int oneTwoThree = 123;", - Alignment); - verifyFormat("int a = 5;\n" - "float const oneTwoThree = 123;", - Alignment); - - Alignment.AlignConsecutiveDeclarations = true; - verifyFormat("float const a = 5;\n" - "int oneTwoThree = 123;", - Alignment); - verifyFormat("int a = method();\n" - "float const oneTwoThree = 133;", - Alignment); - verifyFormat("int i = 1, j = 10;\n" - "something = 2000;", - Alignment); - verifyFormat("something = 2000;\n" - "int i = 1, j = 10;\n", - Alignment); - verifyFormat("float something = 2000;\n" - "double another = 911;\n" - "int i = 1, j = 10;\n" - "const int *oneMore = 1;\n" - "unsigned i = 2;", - Alignment); - verifyFormat("float a = 5;\n" - "int one = 1;\n" - "method();\n" - "const double oneTwoThree = 123;\n" - "const unsigned int oneTwo = 12;", - Alignment); - verifyFormat("int oneTwoThree{0}; // comment\n" - "unsigned oneTwo; // comment", - Alignment); - EXPECT_EQ("float const a = 5;\n" - "\n" - "int oneTwoThree = 123;", - format("float const a = 5;\n" - "\n" - "int oneTwoThree= 123;", - Alignment)); - EXPECT_EQ("float a = 5;\n" - "int one = 1;\n" - "\n" - "unsigned oneTwoThree = 123;", - format("float a = 5;\n" - "int one = 1;\n" - "\n" - "unsigned oneTwoThree = 123;", - Alignment)); - EXPECT_EQ("float a = 5;\n" - "int one = 1;\n" - "\n" - "unsigned oneTwoThree = 123;\n" - "int oneTwo = 12;", - format("float a = 5;\n" - "int one = 1;\n" - "\n" - "unsigned oneTwoThree = 123;\n" - "int oneTwo = 12;", - Alignment)); - // Function prototype alignment - verifyFormat("int a();\n" - "double b();", - Alignment); - verifyFormat("int a(int x);\n" - "double b();", - Alignment); - unsigned OldColumnLimit = Alignment.ColumnLimit; - // We need to set ColumnLimit to zero, in order to stress nested alignments, - // otherwise the function parameters will be re-flowed onto a single line. - Alignment.ColumnLimit = 0; - EXPECT_EQ("int a(int x,\n" - " float y);\n" - "double b(int x,\n" - " double y);", - format("int a(int x,\n" - " float y);\n" - "double b(int x,\n" - " double y);", - Alignment)); - // This ensures that function parameters of function declarations are - // correctly indented when their owning functions are indented. - // The failure case here is for 'double y' to not be indented enough. - EXPECT_EQ("double a(int x);\n" - "int b(int y,\n" - " double z);", - format("double a(int x);\n" - "int b(int y,\n" - " double z);", - Alignment)); - // Set ColumnLimit low so that we induce wrapping immediately after - // the function name and opening paren. - Alignment.ColumnLimit = 13; - verifyFormat("int function(\n" - " int x,\n" - " bool y);", - Alignment); - Alignment.ColumnLimit = OldColumnLimit; - // Ensure function pointers don't screw up recursive alignment - verifyFormat("int a(int x, void (*fp)(int y));\n" - "double b();", - Alignment); - Alignment.AlignConsecutiveAssignments = true; - // Ensure recursive alignment is broken by function braces, so that the - // "a = 1" does not align with subsequent assignments inside the function - // body. - verifyFormat("int func(int a = 1) {\n" - " int b = 2;\n" - " int cc = 3;\n" - "}", - Alignment); - verifyFormat("float something = 2000;\n" - "double another = 911;\n" - "int i = 1, j = 10;\n" - "const int *oneMore = 1;\n" - "unsigned i = 2;", - Alignment); - verifyFormat("int oneTwoThree = {0}; // comment\n" - "unsigned oneTwo = 0; // comment", - Alignment); - // Make sure that scope is correctly tracked, in the absence of braces - verifyFormat("for (int i = 0; i < n; i++)\n" - " j = i;\n" - "double x = 1;\n", - Alignment); - verifyFormat("if (int i = 0)\n" - " j = i;\n" - "double x = 1;\n", - Alignment); - // Ensure operator[] and operator() are comprehended - verifyFormat("struct test {\n" - " long long int foo();\n" - " int operator[](int a);\n" - " double bar();\n" - "};\n", - Alignment); - verifyFormat("struct test {\n" - " long long int foo();\n" - " int operator()(int a);\n" - " double bar();\n" - "};\n", - Alignment); - EXPECT_EQ("void SomeFunction(int parameter = 0) {\n" - " int const i = 1;\n" - " int * j = 2;\n" - " int big = 10000;\n" - "\n" - " unsigned oneTwoThree = 123;\n" - " int oneTwo = 12;\n" - " method();\n" - " float k = 2;\n" - " int ll = 10000;\n" - "}", - format("void SomeFunction(int parameter= 0) {\n" - " int const i= 1;\n" - " int *j=2;\n" - " int big = 10000;\n" - "\n" - "unsigned oneTwoThree =123;\n" - "int oneTwo = 12;\n" - " method();\n" - "float k= 2;\n" - "int ll=10000;\n" - "}", - Alignment)); - Alignment.AlignConsecutiveAssignments = false; - Alignment.AlignEscapedNewlines = FormatStyle::ENAS_DontAlign; - verifyFormat("#define A \\\n" - " int aaaa = 12; \\\n" - " float b = 23; \\\n" - " const int ccc = 234; \\\n" - " unsigned dddddddddd = 2345;", - Alignment); - Alignment.AlignEscapedNewlines = FormatStyle::ENAS_Left; - verifyFormat("#define A \\\n" - " int aaaa = 12; \\\n" - " float b = 23; \\\n" - " const int ccc = 234; \\\n" - " unsigned dddddddddd = 2345;", - Alignment); - Alignment.AlignEscapedNewlines = FormatStyle::ENAS_Right; - Alignment.ColumnLimit = 30; - verifyFormat("#define A \\\n" - " int aaaa = 12; \\\n" - " float b = 23; \\\n" - " const int ccc = 234; \\\n" - " int dddddddddd = 2345;", - Alignment); - Alignment.ColumnLimit = 80; - verifyFormat("void SomeFunction(int parameter = 1, int i = 2, int j = 3, int " - "k = 4, int l = 5,\n" - " int m = 6) {\n" - " const int j = 10;\n" - " otherThing = 1;\n" - "}", - Alignment); - verifyFormat("void SomeFunction(int parameter = 0) {\n" - " int const i = 1;\n" - " int * j = 2;\n" - " int big = 10000;\n" - "}", - Alignment); - verifyFormat("class C {\n" - "public:\n" - " int i = 1;\n" - " virtual void f() = 0;\n" - "};", - Alignment); - verifyFormat("float i = 1;\n" - "if (SomeType t = getSomething()) {\n" - "}\n" - "const unsigned j = 2;\n" - "int big = 10000;", - Alignment); - verifyFormat("float j = 7;\n" - "for (int k = 0; k < N; ++k) {\n" - "}\n" - "unsigned j = 2;\n" - "int big = 10000;\n" - "}", - Alignment); - Alignment.BreakBeforeBinaryOperators = FormatStyle::BOS_All; - verifyFormat("float i = 1;\n" - "LooooooooooongType loooooooooooooooooooooongVariable\n" - " = someLooooooooooooooooongFunction();\n" - "int j = 2;", - Alignment); - Alignment.BreakBeforeBinaryOperators = FormatStyle::BOS_None; - verifyFormat("int i = 1;\n" - "LooooooooooongType loooooooooooooooooooooongVariable =\n" - " someLooooooooooooooooongFunction();\n" - "int j = 2;", - Alignment); - - Alignment.AlignConsecutiveAssignments = true; - verifyFormat("auto lambda = []() {\n" - " auto ii = 0;\n" - " float j = 0;\n" - " return 0;\n" - "};\n" - "int i = 0;\n" - "float i2 = 0;\n" - "auto v = type{\n" - " i = 1, //\n" - " (i = 2), //\n" - " i = 3 //\n" - "};", - Alignment); - Alignment.AlignConsecutiveAssignments = false; - - verifyFormat( - "int i = 1;\n" - "SomeType a = SomeFunction(looooooooooooooooooooooongParameterA,\n" - " loooooooooooooooooooooongParameterB);\n" - "int j = 2;", - Alignment); - - // Test interactions with ColumnLimit and AlignConsecutiveAssignments: - // We expect declarations and assignments to align, as long as it doesn't - // exceed the column limit, starting a new alignment sequence whenever it - // happens. - Alignment.AlignConsecutiveAssignments = true; - Alignment.ColumnLimit = 30; - verifyFormat("float ii = 1;\n" - "unsigned j = 2;\n" - "int someVerylongVariable = 1;\n" - "AnotherLongType ll = 123456;\n" - "VeryVeryLongType k = 2;\n" - "int myvar = 1;", - Alignment); - Alignment.ColumnLimit = 80; - Alignment.AlignConsecutiveAssignments = false; - - verifyFormat( - "template <typename LongTemplate, typename VeryLongTemplateTypeName,\n" - " typename LongType, typename B>\n" - "auto foo() {}\n", - Alignment); - verifyFormat("float a, b = 1;\n" - "int c = 2;\n" - "int dd = 3;\n", - Alignment); - verifyFormat("int aa = ((1 > 2) ? 3 : 4);\n" - "float b[1][] = {{3.f}};\n", - Alignment); - Alignment.AlignConsecutiveAssignments = true; - verifyFormat("float a, b = 1;\n" - "int c = 2;\n" - "int dd = 3;\n", - Alignment); - verifyFormat("int aa = ((1 > 2) ? 3 : 4);\n" - "float b[1][] = {{3.f}};\n", - Alignment); - Alignment.AlignConsecutiveAssignments = false; - - Alignment.ColumnLimit = 30; - Alignment.BinPackParameters = false; - verifyFormat("void foo(float a,\n" - " float b,\n" - " int c,\n" - " uint32_t *d) {\n" - " int * e = 0;\n" - " float f = 0;\n" - " double g = 0;\n" - "}\n" - "void bar(ino_t a,\n" - " int b,\n" - " uint32_t *c,\n" - " bool d) {}\n", - Alignment); - Alignment.BinPackParameters = true; - Alignment.ColumnLimit = 80; - - // Bug 33507 - Alignment.PointerAlignment = FormatStyle::PAS_Middle; - verifyFormat( - "auto found = range::find_if(vsProducts, [&](auto * aProduct) {\n" - " static const Version verVs2017;\n" - " return true;\n" - "});\n", - Alignment); - Alignment.PointerAlignment = FormatStyle::PAS_Right; - - // See llvm.org/PR35641 - Alignment.AlignConsecutiveDeclarations = true; - verifyFormat("int func() { //\n" - " int b;\n" - " unsigned c;\n" - "}", - Alignment); -} - -TEST_F(FormatTest, LinuxBraceBreaking) { - FormatStyle LinuxBraceStyle = getLLVMStyle(); - LinuxBraceStyle.BreakBeforeBraces = FormatStyle::BS_Linux; - verifyFormat("namespace a\n" - "{\n" - "class A\n" - "{\n" - " void f()\n" - " {\n" - " if (true) {\n" - " a();\n" - " b();\n" - " } else {\n" - " a();\n" - " }\n" - " }\n" - " void g() { return; }\n" - "};\n" - "struct B {\n" - " int x;\n" - "};\n" - "} // namespace a\n", - LinuxBraceStyle); - verifyFormat("enum X {\n" - " Y = 0,\n" - "}\n", - LinuxBraceStyle); - verifyFormat("struct S {\n" - " int Type;\n" - " union {\n" - " int x;\n" - " double y;\n" - " } Value;\n" - " class C\n" - " {\n" - " MyFavoriteType Value;\n" - " } Class;\n" - "}\n", - LinuxBraceStyle); -} - -TEST_F(FormatTest, MozillaBraceBreaking) { - FormatStyle MozillaBraceStyle = getLLVMStyle(); - MozillaBraceStyle.BreakBeforeBraces = FormatStyle::BS_Mozilla; - MozillaBraceStyle.FixNamespaceComments = false; - verifyFormat("namespace a {\n" - "class A\n" - "{\n" - " void f()\n" - " {\n" - " if (true) {\n" - " a();\n" - " b();\n" - " }\n" - " }\n" - " void g() { return; }\n" - "};\n" - "enum E\n" - "{\n" - " A,\n" - " // foo\n" - " B,\n" - " C\n" - "};\n" - "struct B\n" - "{\n" - " int x;\n" - "};\n" - "}\n", - MozillaBraceStyle); - verifyFormat("struct S\n" - "{\n" - " int Type;\n" - " union\n" - " {\n" - " int x;\n" - " double y;\n" - " } Value;\n" - " class C\n" - " {\n" - " MyFavoriteType Value;\n" - " } Class;\n" - "}\n", - MozillaBraceStyle); -} - -TEST_F(FormatTest, StroustrupBraceBreaking) { - FormatStyle StroustrupBraceStyle = getLLVMStyle(); - StroustrupBraceStyle.BreakBeforeBraces = FormatStyle::BS_Stroustrup; - verifyFormat("namespace a {\n" - "class A {\n" - " void f()\n" - " {\n" - " if (true) {\n" - " a();\n" - " b();\n" - " }\n" - " }\n" - " void g() { return; }\n" - "};\n" - "struct B {\n" - " int x;\n" - "};\n" - "} // namespace a\n", - StroustrupBraceStyle); - - verifyFormat("void foo()\n" - "{\n" - " if (a) {\n" - " a();\n" - " }\n" - " else {\n" - " b();\n" - " }\n" - "}\n", - StroustrupBraceStyle); - - verifyFormat("#ifdef _DEBUG\n" - "int foo(int i = 0)\n" - "#else\n" - "int foo(int i = 5)\n" - "#endif\n" - "{\n" - " return i;\n" - "}", - StroustrupBraceStyle); - - verifyFormat("void foo() {}\n" - "void bar()\n" - "#ifdef _DEBUG\n" - "{\n" - " foo();\n" - "}\n" - "#else\n" - "{\n" - "}\n" - "#endif", - StroustrupBraceStyle); - - verifyFormat("void foobar() { int i = 5; }\n" - "#ifdef _DEBUG\n" - "void bar() {}\n" - "#else\n" - "void bar() { foobar(); }\n" - "#endif", - StroustrupBraceStyle); -} - -TEST_F(FormatTest, AllmanBraceBreaking) { - FormatStyle AllmanBraceStyle = getLLVMStyle(); - AllmanBraceStyle.BreakBeforeBraces = FormatStyle::BS_Allman; - - EXPECT_EQ("namespace a\n" - "{\n" - "void f();\n" - "void g();\n" - "} // namespace a\n", - format("namespace a\n" - "{\n" - "void f();\n" - "void g();\n" - "}\n", - AllmanBraceStyle)); - - verifyFormat("namespace a\n" - "{\n" - "class A\n" - "{\n" - " void f()\n" - " {\n" - " if (true)\n" - " {\n" - " a();\n" - " b();\n" - " }\n" - " }\n" - " void g() { return; }\n" - "};\n" - "struct B\n" - "{\n" - " int x;\n" - "};\n" - "} // namespace a", - AllmanBraceStyle); - - verifyFormat("void f()\n" - "{\n" - " if (true)\n" - " {\n" - " a();\n" - " }\n" - " else if (false)\n" - " {\n" - " b();\n" - " }\n" - " else\n" - " {\n" - " c();\n" - " }\n" - "}\n", - AllmanBraceStyle); - - verifyFormat("void f()\n" - "{\n" - " for (int i = 0; i < 10; ++i)\n" - " {\n" - " a();\n" - " }\n" - " while (false)\n" - " {\n" - " b();\n" - " }\n" - " do\n" - " {\n" - " c();\n" - " } while (false)\n" - "}\n", - AllmanBraceStyle); - - verifyFormat("void f(int a)\n" - "{\n" - " switch (a)\n" - " {\n" - " case 0:\n" - " break;\n" - " case 1:\n" - " {\n" - " break;\n" - " }\n" - " case 2:\n" - " {\n" - " }\n" - " break;\n" - " default:\n" - " break;\n" - " }\n" - "}\n", - AllmanBraceStyle); - - verifyFormat("enum X\n" - "{\n" - " Y = 0,\n" - "}\n", - AllmanBraceStyle); - verifyFormat("enum X\n" - "{\n" - " Y = 0\n" - "}\n", - AllmanBraceStyle); - - verifyFormat("@interface BSApplicationController ()\n" - "{\n" - "@private\n" - " id _extraIvar;\n" - "}\n" - "@end\n", - AllmanBraceStyle); - - verifyFormat("#ifdef _DEBUG\n" - "int foo(int i = 0)\n" - "#else\n" - "int foo(int i = 5)\n" - "#endif\n" - "{\n" - " return i;\n" - "}", - AllmanBraceStyle); - - verifyFormat("void foo() {}\n" - "void bar()\n" - "#ifdef _DEBUG\n" - "{\n" - " foo();\n" - "}\n" - "#else\n" - "{\n" - "}\n" - "#endif", - AllmanBraceStyle); - - verifyFormat("void foobar() { int i = 5; }\n" - "#ifdef _DEBUG\n" - "void bar() {}\n" - "#else\n" - "void bar() { foobar(); }\n" - "#endif", - AllmanBraceStyle); - - // This shouldn't affect ObjC blocks.. - verifyFormat("[self doSomeThingWithACompletionHandler:^{\n" - " // ...\n" - " int i;\n" - "}];", - AllmanBraceStyle); - verifyFormat("void (^block)(void) = ^{\n" - " // ...\n" - " int i;\n" - "};", - AllmanBraceStyle); - // .. or dict literals. - verifyFormat("void f()\n" - "{\n" - " // ...\n" - " [object someMethod:@{@\"a\" : @\"b\"}];\n" - "}", - AllmanBraceStyle); - verifyFormat("void f()\n" - "{\n" - " // ...\n" - " [object someMethod:@{a : @\"b\"}];\n" - "}", - AllmanBraceStyle); - verifyFormat("int f()\n" - "{ // comment\n" - " return 42;\n" - "}", - AllmanBraceStyle); - - AllmanBraceStyle.ColumnLimit = 19; - verifyFormat("void f() { int i; }", AllmanBraceStyle); - AllmanBraceStyle.ColumnLimit = 18; - verifyFormat("void f()\n" - "{\n" - " int i;\n" - "}", - AllmanBraceStyle); - AllmanBraceStyle.ColumnLimit = 80; - - FormatStyle BreakBeforeBraceShortIfs = AllmanBraceStyle; - BreakBeforeBraceShortIfs.AllowShortIfStatementsOnASingleLine = true; - BreakBeforeBraceShortIfs.AllowShortLoopsOnASingleLine = true; - verifyFormat("void f(bool b)\n" - "{\n" - " if (b)\n" - " {\n" - " return;\n" - " }\n" - "}\n", - BreakBeforeBraceShortIfs); - verifyFormat("void f(bool b)\n" - "{\n" - " if constexpr (b)\n" - " {\n" - " return;\n" - " }\n" - "}\n", - BreakBeforeBraceShortIfs); - verifyFormat("void f(bool b)\n" - "{\n" - " if (b) return;\n" - "}\n", - BreakBeforeBraceShortIfs); - verifyFormat("void f(bool b)\n" - "{\n" - " if constexpr (b) return;\n" - "}\n", - BreakBeforeBraceShortIfs); - verifyFormat("void f(bool b)\n" - "{\n" - " while (b)\n" - " {\n" - " return;\n" - " }\n" - "}\n", - BreakBeforeBraceShortIfs); -} - -TEST_F(FormatTest, GNUBraceBreaking) { - FormatStyle GNUBraceStyle = getLLVMStyle(); - GNUBraceStyle.BreakBeforeBraces = FormatStyle::BS_GNU; - verifyFormat("namespace a\n" - "{\n" - "class A\n" - "{\n" - " void f()\n" - " {\n" - " int a;\n" - " {\n" - " int b;\n" - " }\n" - " if (true)\n" - " {\n" - " a();\n" - " b();\n" - " }\n" - " }\n" - " void g() { return; }\n" - "}\n" - "} // namespace a", - GNUBraceStyle); - - verifyFormat("void f()\n" - "{\n" - " if (true)\n" - " {\n" - " a();\n" - " }\n" - " else if (false)\n" - " {\n" - " b();\n" - " }\n" - " else\n" - " {\n" - " c();\n" - " }\n" - "}\n", - GNUBraceStyle); - - verifyFormat("void f()\n" - "{\n" - " for (int i = 0; i < 10; ++i)\n" - " {\n" - " a();\n" - " }\n" - " while (false)\n" - " {\n" - " b();\n" - " }\n" - " do\n" - " {\n" - " c();\n" - " }\n" - " while (false);\n" - "}\n", - GNUBraceStyle); - - verifyFormat("void f(int a)\n" - "{\n" - " switch (a)\n" - " {\n" - " case 0:\n" - " break;\n" - " case 1:\n" - " {\n" - " break;\n" - " }\n" - " case 2:\n" - " {\n" - " }\n" - " break;\n" - " default:\n" - " break;\n" - " }\n" - "}\n", - GNUBraceStyle); - - verifyFormat("enum X\n" - "{\n" - " Y = 0,\n" - "}\n", - GNUBraceStyle); - - verifyFormat("@interface BSApplicationController ()\n" - "{\n" - "@private\n" - " id _extraIvar;\n" - "}\n" - "@end\n", - GNUBraceStyle); - - verifyFormat("#ifdef _DEBUG\n" - "int foo(int i = 0)\n" - "#else\n" - "int foo(int i = 5)\n" - "#endif\n" - "{\n" - " return i;\n" - "}", - GNUBraceStyle); - - verifyFormat("void foo() {}\n" - "void bar()\n" - "#ifdef _DEBUG\n" - "{\n" - " foo();\n" - "}\n" - "#else\n" - "{\n" - "}\n" - "#endif", - GNUBraceStyle); - - verifyFormat("void foobar() { int i = 5; }\n" - "#ifdef _DEBUG\n" - "void bar() {}\n" - "#else\n" - "void bar() { foobar(); }\n" - "#endif", - GNUBraceStyle); -} - -TEST_F(FormatTest, WebKitBraceBreaking) { - FormatStyle WebKitBraceStyle = getLLVMStyle(); - WebKitBraceStyle.BreakBeforeBraces = FormatStyle::BS_WebKit; - WebKitBraceStyle.FixNamespaceComments = false; - verifyFormat("namespace a {\n" - "class A {\n" - " void f()\n" - " {\n" - " if (true) {\n" - " a();\n" - " b();\n" - " }\n" - " }\n" - " void g() { return; }\n" - "};\n" - "enum E {\n" - " A,\n" - " // foo\n" - " B,\n" - " C\n" - "};\n" - "struct B {\n" - " int x;\n" - "};\n" - "}\n", - WebKitBraceStyle); - verifyFormat("struct S {\n" - " int Type;\n" - " union {\n" - " int x;\n" - " double y;\n" - " } Value;\n" - " class C {\n" - " MyFavoriteType Value;\n" - " } Class;\n" - "};\n", - WebKitBraceStyle); -} - -TEST_F(FormatTest, CatchExceptionReferenceBinding) { - verifyFormat("void f() {\n" - " try {\n" - " } catch (const Exception &e) {\n" - " }\n" - "}\n", - getLLVMStyle()); -} - -TEST_F(FormatTest, UnderstandsPragmas) { - verifyFormat("#pragma omp reduction(| : var)"); - verifyFormat("#pragma omp reduction(+ : var)"); - - EXPECT_EQ("#pragma mark Any non-hyphenated or hyphenated string " - "(including parentheses).", - format("#pragma mark Any non-hyphenated or hyphenated string " - "(including parentheses).")); -} - -TEST_F(FormatTest, UnderstandPragmaOption) { - verifyFormat("#pragma option -C -A"); - - EXPECT_EQ("#pragma option -C -A", format("#pragma option -C -A")); -} - -TEST_F(FormatTest, OptimizeBreakPenaltyVsExcess) { - FormatStyle Style = getLLVMStyle(); - Style.ColumnLimit = 20; - - verifyFormat("int a; // the\n" - " // comment", Style); - EXPECT_EQ("int a; /* first line\n" - " * second\n" - " * line third\n" - " * line\n" - " */", - format("int a; /* first line\n" - " * second\n" - " * line third\n" - " * line\n" - " */", - Style)); - EXPECT_EQ("int a; // first line\n" - " // second\n" - " // line third\n" - " // line", - format("int a; // first line\n" - " // second line\n" - " // third line", - Style)); - - Style.PenaltyExcessCharacter = 90; - verifyFormat("int a; // the comment", Style); - EXPECT_EQ("int a; // the comment\n" - " // aaa", - format("int a; // the comment aaa", Style)); - EXPECT_EQ("int a; /* first line\n" - " * second line\n" - " * third line\n" - " */", - format("int a; /* first line\n" - " * second line\n" - " * third line\n" - " */", - Style)); - EXPECT_EQ("int a; // first line\n" - " // second line\n" - " // third line", - format("int a; // first line\n" - " // second line\n" - " // third line", - Style)); - // FIXME: Investigate why this is not getting the same layout as the test - // above. - EXPECT_EQ("int a; /* first line\n" - " * second line\n" - " * third line\n" - " */", - format("int a; /* first line second line third line" - "\n*/", - Style)); - - EXPECT_EQ("// foo bar baz bazfoo\n" - "// foo bar foo bar\n", - format("// foo bar baz bazfoo\n" - "// foo bar foo bar\n", - Style)); - EXPECT_EQ("// foo bar baz bazfoo\n" - "// foo bar foo bar\n", - format("// foo bar baz bazfoo\n" - "// foo bar foo bar\n", - Style)); - - // FIXME: Optimally, we'd keep bazfoo on the first line and reflow bar to the - // next one. - EXPECT_EQ("// foo bar baz bazfoo\n" - "// bar foo bar\n", - format("// foo bar baz bazfoo bar\n" - "// foo bar\n", - Style)); - - EXPECT_EQ("// foo bar baz bazfoo\n" - "// foo bar baz bazfoo\n" - "// bar foo bar\n", - format("// foo bar baz bazfoo\n" - "// foo bar baz bazfoo bar\n" - "// foo bar\n", - Style)); - - EXPECT_EQ("// foo bar baz bazfoo\n" - "// foo bar baz bazfoo\n" - "// bar foo bar\n", - format("// foo bar baz bazfoo\n" - "// foo bar baz bazfoo bar\n" - "// foo bar\n", - Style)); - - // Make sure we do not keep protruding characters if strict mode reflow is - // cheaper than keeping protruding characters. - Style.ColumnLimit = 21; - EXPECT_EQ("// foo foo foo foo\n" - "// foo foo foo foo\n" - "// foo foo foo foo\n", - format("// foo foo foo foo foo foo foo foo foo foo foo foo\n", - Style)); - - EXPECT_EQ("int a = /* long block\n" - " comment */\n" - " 42;", - format("int a = /* long block comment */ 42;", Style)); -} - -#define EXPECT_ALL_STYLES_EQUAL(Styles) \ - for (size_t i = 1; i < Styles.size(); ++i) \ - EXPECT_EQ(Styles[0], Styles[i]) << "Style #" << i << " of " << Styles.size() \ - << " differs from Style #0" - -TEST_F(FormatTest, GetsPredefinedStyleByName) { - SmallVector<FormatStyle, 3> Styles; - Styles.resize(3); - - Styles[0] = getLLVMStyle(); - EXPECT_TRUE(getPredefinedStyle("LLVM", FormatStyle::LK_Cpp, &Styles[1])); - EXPECT_TRUE(getPredefinedStyle("lLvM", FormatStyle::LK_Cpp, &Styles[2])); - EXPECT_ALL_STYLES_EQUAL(Styles); - - Styles[0] = getGoogleStyle(); - EXPECT_TRUE(getPredefinedStyle("Google", FormatStyle::LK_Cpp, &Styles[1])); - EXPECT_TRUE(getPredefinedStyle("gOOgle", FormatStyle::LK_Cpp, &Styles[2])); - EXPECT_ALL_STYLES_EQUAL(Styles); - - Styles[0] = getGoogleStyle(FormatStyle::LK_JavaScript); - EXPECT_TRUE( - getPredefinedStyle("Google", FormatStyle::LK_JavaScript, &Styles[1])); - EXPECT_TRUE( - getPredefinedStyle("gOOgle", FormatStyle::LK_JavaScript, &Styles[2])); - EXPECT_ALL_STYLES_EQUAL(Styles); - - Styles[0] = getChromiumStyle(FormatStyle::LK_Cpp); - EXPECT_TRUE(getPredefinedStyle("Chromium", FormatStyle::LK_Cpp, &Styles[1])); - EXPECT_TRUE(getPredefinedStyle("cHRoMiUM", FormatStyle::LK_Cpp, &Styles[2])); - EXPECT_ALL_STYLES_EQUAL(Styles); - - Styles[0] = getMozillaStyle(); - EXPECT_TRUE(getPredefinedStyle("Mozilla", FormatStyle::LK_Cpp, &Styles[1])); - EXPECT_TRUE(getPredefinedStyle("moZILla", FormatStyle::LK_Cpp, &Styles[2])); - EXPECT_ALL_STYLES_EQUAL(Styles); - - Styles[0] = getWebKitStyle(); - EXPECT_TRUE(getPredefinedStyle("WebKit", FormatStyle::LK_Cpp, &Styles[1])); - EXPECT_TRUE(getPredefinedStyle("wEbKit", FormatStyle::LK_Cpp, &Styles[2])); - EXPECT_ALL_STYLES_EQUAL(Styles); - - Styles[0] = getGNUStyle(); - EXPECT_TRUE(getPredefinedStyle("GNU", FormatStyle::LK_Cpp, &Styles[1])); - EXPECT_TRUE(getPredefinedStyle("gnU", FormatStyle::LK_Cpp, &Styles[2])); - EXPECT_ALL_STYLES_EQUAL(Styles); - - EXPECT_FALSE(getPredefinedStyle("qwerty", FormatStyle::LK_Cpp, &Styles[0])); -} - -TEST_F(FormatTest, GetsCorrectBasedOnStyle) { - SmallVector<FormatStyle, 8> Styles; - Styles.resize(2); - - Styles[0] = getGoogleStyle(); - Styles[1] = getLLVMStyle(); - EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google", &Styles[1]).value()); - EXPECT_ALL_STYLES_EQUAL(Styles); - - Styles.resize(5); - Styles[0] = getGoogleStyle(FormatStyle::LK_JavaScript); - Styles[1] = getLLVMStyle(); - Styles[1].Language = FormatStyle::LK_JavaScript; - EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google", &Styles[1]).value()); - - Styles[2] = getLLVMStyle(); - Styles[2].Language = FormatStyle::LK_JavaScript; - EXPECT_EQ(0, parseConfiguration("Language: JavaScript\n" - "BasedOnStyle: Google", - &Styles[2]) - .value()); - - Styles[3] = getLLVMStyle(); - Styles[3].Language = FormatStyle::LK_JavaScript; - EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google\n" - "Language: JavaScript", - &Styles[3]) - .value()); - - Styles[4] = getLLVMStyle(); - Styles[4].Language = FormatStyle::LK_JavaScript; - EXPECT_EQ(0, parseConfiguration("---\n" - "BasedOnStyle: LLVM\n" - "IndentWidth: 123\n" - "---\n" - "BasedOnStyle: Google\n" - "Language: JavaScript", - &Styles[4]) - .value()); - EXPECT_ALL_STYLES_EQUAL(Styles); -} - -#define CHECK_PARSE_BOOL_FIELD(FIELD, CONFIG_NAME) \ - Style.FIELD = false; \ - EXPECT_EQ(0, parseConfiguration(CONFIG_NAME ": true", &Style).value()); \ - EXPECT_TRUE(Style.FIELD); \ - EXPECT_EQ(0, parseConfiguration(CONFIG_NAME ": false", &Style).value()); \ - EXPECT_FALSE(Style.FIELD); - -#define CHECK_PARSE_BOOL(FIELD) CHECK_PARSE_BOOL_FIELD(FIELD, #FIELD) - -#define CHECK_PARSE_NESTED_BOOL_FIELD(STRUCT, FIELD, CONFIG_NAME) \ - Style.STRUCT.FIELD = false; \ - EXPECT_EQ(0, \ - parseConfiguration(#STRUCT ":\n " CONFIG_NAME ": true", &Style) \ - .value()); \ - EXPECT_TRUE(Style.STRUCT.FIELD); \ - EXPECT_EQ(0, \ - parseConfiguration(#STRUCT ":\n " CONFIG_NAME ": false", &Style) \ - .value()); \ - EXPECT_FALSE(Style.STRUCT.FIELD); - -#define CHECK_PARSE_NESTED_BOOL(STRUCT, FIELD) \ - CHECK_PARSE_NESTED_BOOL_FIELD(STRUCT, FIELD, #FIELD) - -#define CHECK_PARSE(TEXT, FIELD, VALUE) \ - EXPECT_NE(VALUE, Style.FIELD); \ - EXPECT_EQ(0, parseConfiguration(TEXT, &Style).value()); \ - EXPECT_EQ(VALUE, Style.FIELD) - -TEST_F(FormatTest, ParsesConfigurationBools) { - FormatStyle Style = {}; - Style.Language = FormatStyle::LK_Cpp; - CHECK_PARSE_BOOL(AlignOperands); - CHECK_PARSE_BOOL(AlignTrailingComments); - CHECK_PARSE_BOOL(AlignConsecutiveAssignments); - CHECK_PARSE_BOOL(AlignConsecutiveDeclarations); - CHECK_PARSE_BOOL(AllowAllParametersOfDeclarationOnNextLine); - CHECK_PARSE_BOOL(AllowShortBlocksOnASingleLine); - CHECK_PARSE_BOOL(AllowShortCaseLabelsOnASingleLine); - CHECK_PARSE_BOOL(AllowShortIfStatementsOnASingleLine); - CHECK_PARSE_BOOL(AllowShortLoopsOnASingleLine); - CHECK_PARSE_BOOL(BinPackArguments); - CHECK_PARSE_BOOL(BinPackParameters); - CHECK_PARSE_BOOL(BreakAfterJavaFieldAnnotations); - CHECK_PARSE_BOOL(BreakBeforeTernaryOperators); - CHECK_PARSE_BOOL(BreakStringLiterals); - CHECK_PARSE_BOOL(CompactNamespaces); - CHECK_PARSE_BOOL(ConstructorInitializerAllOnOneLineOrOnePerLine); - CHECK_PARSE_BOOL(DerivePointerAlignment); - CHECK_PARSE_BOOL_FIELD(DerivePointerAlignment, "DerivePointerBinding"); - CHECK_PARSE_BOOL(DisableFormat); - CHECK_PARSE_BOOL(IndentCaseLabels); - CHECK_PARSE_BOOL(IndentWrappedFunctionNames); - CHECK_PARSE_BOOL(KeepEmptyLinesAtTheStartOfBlocks); - CHECK_PARSE_BOOL(ObjCSpaceAfterProperty); - CHECK_PARSE_BOOL(ObjCSpaceBeforeProtocolList); - CHECK_PARSE_BOOL(Cpp11BracedListStyle); - CHECK_PARSE_BOOL(ReflowComments); - CHECK_PARSE_BOOL(SortIncludes); - CHECK_PARSE_BOOL(SortUsingDeclarations); - CHECK_PARSE_BOOL(SpacesInParentheses); - CHECK_PARSE_BOOL(SpacesInSquareBrackets); - CHECK_PARSE_BOOL(SpacesInAngles); - CHECK_PARSE_BOOL(SpaceInEmptyParentheses); - CHECK_PARSE_BOOL(SpacesInContainerLiterals); - CHECK_PARSE_BOOL(SpacesInCStyleCastParentheses); - CHECK_PARSE_BOOL(SpaceAfterCStyleCast); - CHECK_PARSE_BOOL(SpaceAfterTemplateKeyword); - CHECK_PARSE_BOOL(SpaceBeforeAssignmentOperators); - CHECK_PARSE_BOOL(SpaceBeforeCpp11BracedList); - CHECK_PARSE_BOOL(SpaceBeforeCtorInitializerColon); - CHECK_PARSE_BOOL(SpaceBeforeInheritanceColon); - CHECK_PARSE_BOOL(SpaceBeforeRangeBasedForLoopColon); - - CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterClass); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterControlStatement); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterEnum); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterFunction); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterNamespace); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterObjCDeclaration); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterStruct); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterUnion); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterExternBlock); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, BeforeCatch); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, BeforeElse); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, IndentBraces); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, SplitEmptyFunction); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, SplitEmptyRecord); - CHECK_PARSE_NESTED_BOOL(BraceWrapping, SplitEmptyNamespace); -} - -#undef CHECK_PARSE_BOOL - -TEST_F(FormatTest, ParsesConfiguration) { - FormatStyle Style = {}; - Style.Language = FormatStyle::LK_Cpp; - CHECK_PARSE("AccessModifierOffset: -1234", AccessModifierOffset, -1234); - CHECK_PARSE("ConstructorInitializerIndentWidth: 1234", - ConstructorInitializerIndentWidth, 1234u); - CHECK_PARSE("ObjCBlockIndentWidth: 1234", ObjCBlockIndentWidth, 1234u); - CHECK_PARSE("ColumnLimit: 1234", ColumnLimit, 1234u); - CHECK_PARSE("MaxEmptyLinesToKeep: 1234", MaxEmptyLinesToKeep, 1234u); - CHECK_PARSE("PenaltyBreakAssignment: 1234", - PenaltyBreakAssignment, 1234u); - CHECK_PARSE("PenaltyBreakBeforeFirstCallParameter: 1234", - PenaltyBreakBeforeFirstCallParameter, 1234u); - CHECK_PARSE("PenaltyBreakTemplateDeclaration: 1234", - PenaltyBreakTemplateDeclaration, 1234u); - CHECK_PARSE("PenaltyExcessCharacter: 1234", PenaltyExcessCharacter, 1234u); - CHECK_PARSE("PenaltyReturnTypeOnItsOwnLine: 1234", - PenaltyReturnTypeOnItsOwnLine, 1234u); - CHECK_PARSE("SpacesBeforeTrailingComments: 1234", - SpacesBeforeTrailingComments, 1234u); - CHECK_PARSE("IndentWidth: 32", IndentWidth, 32u); - CHECK_PARSE("ContinuationIndentWidth: 11", ContinuationIndentWidth, 11u); - CHECK_PARSE("CommentPragmas: '// abc$'", CommentPragmas, "// abc$"); - - Style.PointerAlignment = FormatStyle::PAS_Middle; - CHECK_PARSE("PointerAlignment: Left", PointerAlignment, - FormatStyle::PAS_Left); - CHECK_PARSE("PointerAlignment: Right", PointerAlignment, - FormatStyle::PAS_Right); - CHECK_PARSE("PointerAlignment: Middle", PointerAlignment, - FormatStyle::PAS_Middle); - // For backward compatibility: - CHECK_PARSE("PointerBindsToType: Left", PointerAlignment, - FormatStyle::PAS_Left); - CHECK_PARSE("PointerBindsToType: Right", PointerAlignment, - FormatStyle::PAS_Right); - CHECK_PARSE("PointerBindsToType: Middle", PointerAlignment, - FormatStyle::PAS_Middle); - - Style.Standard = FormatStyle::LS_Auto; - CHECK_PARSE("Standard: Cpp03", Standard, FormatStyle::LS_Cpp03); - CHECK_PARSE("Standard: Cpp11", Standard, FormatStyle::LS_Cpp11); - CHECK_PARSE("Standard: C++03", Standard, FormatStyle::LS_Cpp03); - CHECK_PARSE("Standard: C++11", Standard, FormatStyle::LS_Cpp11); - CHECK_PARSE("Standard: Auto", Standard, FormatStyle::LS_Auto); - - Style.BreakBeforeBinaryOperators = FormatStyle::BOS_All; - CHECK_PARSE("BreakBeforeBinaryOperators: NonAssignment", - BreakBeforeBinaryOperators, FormatStyle::BOS_NonAssignment); - CHECK_PARSE("BreakBeforeBinaryOperators: None", BreakBeforeBinaryOperators, - FormatStyle::BOS_None); - CHECK_PARSE("BreakBeforeBinaryOperators: All", BreakBeforeBinaryOperators, - FormatStyle::BOS_All); - // For backward compatibility: - CHECK_PARSE("BreakBeforeBinaryOperators: false", BreakBeforeBinaryOperators, - FormatStyle::BOS_None); - CHECK_PARSE("BreakBeforeBinaryOperators: true", BreakBeforeBinaryOperators, - FormatStyle::BOS_All); - - Style.BreakConstructorInitializers = FormatStyle::BCIS_BeforeColon; - CHECK_PARSE("BreakConstructorInitializers: BeforeComma", - BreakConstructorInitializers, FormatStyle::BCIS_BeforeComma); - CHECK_PARSE("BreakConstructorInitializers: AfterColon", - BreakConstructorInitializers, FormatStyle::BCIS_AfterColon); - CHECK_PARSE("BreakConstructorInitializers: BeforeColon", - BreakConstructorInitializers, FormatStyle::BCIS_BeforeColon); - // For backward compatibility: - CHECK_PARSE("BreakConstructorInitializersBeforeComma: true", - BreakConstructorInitializers, FormatStyle::BCIS_BeforeComma); - - Style.BreakInheritanceList = FormatStyle::BILS_BeforeColon; - CHECK_PARSE("BreakInheritanceList: BeforeComma", - BreakInheritanceList, FormatStyle::BILS_BeforeComma); - CHECK_PARSE("BreakInheritanceList: AfterColon", - BreakInheritanceList, FormatStyle::BILS_AfterColon); - CHECK_PARSE("BreakInheritanceList: BeforeColon", - BreakInheritanceList, FormatStyle::BILS_BeforeColon); - // For backward compatibility: - CHECK_PARSE("BreakBeforeInheritanceComma: true", - BreakInheritanceList, FormatStyle::BILS_BeforeComma); - - Style.AlignAfterOpenBracket = FormatStyle::BAS_AlwaysBreak; - CHECK_PARSE("AlignAfterOpenBracket: Align", AlignAfterOpenBracket, - FormatStyle::BAS_Align); - CHECK_PARSE("AlignAfterOpenBracket: DontAlign", AlignAfterOpenBracket, - FormatStyle::BAS_DontAlign); - CHECK_PARSE("AlignAfterOpenBracket: AlwaysBreak", AlignAfterOpenBracket, - FormatStyle::BAS_AlwaysBreak); - // For backward compatibility: - CHECK_PARSE("AlignAfterOpenBracket: false", AlignAfterOpenBracket, - FormatStyle::BAS_DontAlign); - CHECK_PARSE("AlignAfterOpenBracket: true", AlignAfterOpenBracket, - FormatStyle::BAS_Align); - - Style.AlignEscapedNewlines = FormatStyle::ENAS_Left; - CHECK_PARSE("AlignEscapedNewlines: DontAlign", AlignEscapedNewlines, - FormatStyle::ENAS_DontAlign); - CHECK_PARSE("AlignEscapedNewlines: Left", AlignEscapedNewlines, - FormatStyle::ENAS_Left); - CHECK_PARSE("AlignEscapedNewlines: Right", AlignEscapedNewlines, - FormatStyle::ENAS_Right); - // For backward compatibility: - CHECK_PARSE("AlignEscapedNewlinesLeft: true", AlignEscapedNewlines, - FormatStyle::ENAS_Left); - CHECK_PARSE("AlignEscapedNewlinesLeft: false", AlignEscapedNewlines, - FormatStyle::ENAS_Right); - - Style.UseTab = FormatStyle::UT_ForIndentation; - CHECK_PARSE("UseTab: Never", UseTab, FormatStyle::UT_Never); - CHECK_PARSE("UseTab: ForIndentation", UseTab, FormatStyle::UT_ForIndentation); - CHECK_PARSE("UseTab: Always", UseTab, FormatStyle::UT_Always); - CHECK_PARSE("UseTab: ForContinuationAndIndentation", UseTab, - FormatStyle::UT_ForContinuationAndIndentation); - // For backward compatibility: - CHECK_PARSE("UseTab: false", UseTab, FormatStyle::UT_Never); - CHECK_PARSE("UseTab: true", UseTab, FormatStyle::UT_Always); - - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline; - CHECK_PARSE("AllowShortFunctionsOnASingleLine: None", - AllowShortFunctionsOnASingleLine, FormatStyle::SFS_None); - CHECK_PARSE("AllowShortFunctionsOnASingleLine: Inline", - AllowShortFunctionsOnASingleLine, FormatStyle::SFS_Inline); - CHECK_PARSE("AllowShortFunctionsOnASingleLine: Empty", - AllowShortFunctionsOnASingleLine, FormatStyle::SFS_Empty); - CHECK_PARSE("AllowShortFunctionsOnASingleLine: All", - AllowShortFunctionsOnASingleLine, FormatStyle::SFS_All); - // For backward compatibility: - CHECK_PARSE("AllowShortFunctionsOnASingleLine: false", - AllowShortFunctionsOnASingleLine, FormatStyle::SFS_None); - CHECK_PARSE("AllowShortFunctionsOnASingleLine: true", - AllowShortFunctionsOnASingleLine, FormatStyle::SFS_All); - - Style.SpaceBeforeParens = FormatStyle::SBPO_Always; - CHECK_PARSE("SpaceBeforeParens: Never", SpaceBeforeParens, - FormatStyle::SBPO_Never); - CHECK_PARSE("SpaceBeforeParens: Always", SpaceBeforeParens, - FormatStyle::SBPO_Always); - CHECK_PARSE("SpaceBeforeParens: ControlStatements", SpaceBeforeParens, - FormatStyle::SBPO_ControlStatements); - // For backward compatibility: - CHECK_PARSE("SpaceAfterControlStatementKeyword: false", SpaceBeforeParens, - FormatStyle::SBPO_Never); - CHECK_PARSE("SpaceAfterControlStatementKeyword: true", SpaceBeforeParens, - FormatStyle::SBPO_ControlStatements); - - Style.ColumnLimit = 123; - FormatStyle BaseStyle = getLLVMStyle(); - CHECK_PARSE("BasedOnStyle: LLVM", ColumnLimit, BaseStyle.ColumnLimit); - CHECK_PARSE("BasedOnStyle: LLVM\nColumnLimit: 1234", ColumnLimit, 1234u); - - Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup; - CHECK_PARSE("BreakBeforeBraces: Attach", BreakBeforeBraces, - FormatStyle::BS_Attach); - CHECK_PARSE("BreakBeforeBraces: Linux", BreakBeforeBraces, - FormatStyle::BS_Linux); - CHECK_PARSE("BreakBeforeBraces: Mozilla", BreakBeforeBraces, - FormatStyle::BS_Mozilla); - CHECK_PARSE("BreakBeforeBraces: Stroustrup", BreakBeforeBraces, - FormatStyle::BS_Stroustrup); - CHECK_PARSE("BreakBeforeBraces: Allman", BreakBeforeBraces, - FormatStyle::BS_Allman); - CHECK_PARSE("BreakBeforeBraces: GNU", BreakBeforeBraces, FormatStyle::BS_GNU); - CHECK_PARSE("BreakBeforeBraces: WebKit", BreakBeforeBraces, - FormatStyle::BS_WebKit); - CHECK_PARSE("BreakBeforeBraces: Custom", BreakBeforeBraces, - FormatStyle::BS_Custom); - - Style.AlwaysBreakAfterReturnType = FormatStyle::RTBS_All; - CHECK_PARSE("AlwaysBreakAfterReturnType: None", AlwaysBreakAfterReturnType, - FormatStyle::RTBS_None); - CHECK_PARSE("AlwaysBreakAfterReturnType: All", AlwaysBreakAfterReturnType, - FormatStyle::RTBS_All); - CHECK_PARSE("AlwaysBreakAfterReturnType: TopLevel", - AlwaysBreakAfterReturnType, FormatStyle::RTBS_TopLevel); - CHECK_PARSE("AlwaysBreakAfterReturnType: AllDefinitions", - AlwaysBreakAfterReturnType, FormatStyle::RTBS_AllDefinitions); - CHECK_PARSE("AlwaysBreakAfterReturnType: TopLevelDefinitions", - AlwaysBreakAfterReturnType, - FormatStyle::RTBS_TopLevelDefinitions); - - Style.AlwaysBreakTemplateDeclarations = FormatStyle::BTDS_Yes; - CHECK_PARSE("AlwaysBreakTemplateDeclarations: No", AlwaysBreakTemplateDeclarations, - FormatStyle::BTDS_No); - CHECK_PARSE("AlwaysBreakTemplateDeclarations: MultiLine", AlwaysBreakTemplateDeclarations, - FormatStyle::BTDS_MultiLine); - CHECK_PARSE("AlwaysBreakTemplateDeclarations: Yes", AlwaysBreakTemplateDeclarations, - FormatStyle::BTDS_Yes); - CHECK_PARSE("AlwaysBreakTemplateDeclarations: false", AlwaysBreakTemplateDeclarations, - FormatStyle::BTDS_MultiLine); - CHECK_PARSE("AlwaysBreakTemplateDeclarations: true", AlwaysBreakTemplateDeclarations, - FormatStyle::BTDS_Yes); - - Style.AlwaysBreakAfterDefinitionReturnType = FormatStyle::DRTBS_All; - CHECK_PARSE("AlwaysBreakAfterDefinitionReturnType: None", - AlwaysBreakAfterDefinitionReturnType, FormatStyle::DRTBS_None); - CHECK_PARSE("AlwaysBreakAfterDefinitionReturnType: All", - AlwaysBreakAfterDefinitionReturnType, FormatStyle::DRTBS_All); - CHECK_PARSE("AlwaysBreakAfterDefinitionReturnType: TopLevel", - AlwaysBreakAfterDefinitionReturnType, - FormatStyle::DRTBS_TopLevel); - - Style.NamespaceIndentation = FormatStyle::NI_All; - CHECK_PARSE("NamespaceIndentation: None", NamespaceIndentation, - FormatStyle::NI_None); - CHECK_PARSE("NamespaceIndentation: Inner", NamespaceIndentation, - FormatStyle::NI_Inner); - CHECK_PARSE("NamespaceIndentation: All", NamespaceIndentation, - FormatStyle::NI_All); - - // FIXME: This is required because parsing a configuration simply overwrites - // the first N elements of the list instead of resetting it. - Style.ForEachMacros.clear(); - std::vector<std::string> BoostForeach; - BoostForeach.push_back("BOOST_FOREACH"); - CHECK_PARSE("ForEachMacros: [BOOST_FOREACH]", ForEachMacros, BoostForeach); - std::vector<std::string> BoostAndQForeach; - BoostAndQForeach.push_back("BOOST_FOREACH"); - BoostAndQForeach.push_back("Q_FOREACH"); - CHECK_PARSE("ForEachMacros: [BOOST_FOREACH, Q_FOREACH]", ForEachMacros, - BoostAndQForeach); - - Style.StatementMacros.clear(); - CHECK_PARSE("StatementMacros: [QUNUSED]", StatementMacros, - std::vector<std::string>{"QUNUSED"}); - CHECK_PARSE("StatementMacros: [QUNUSED, QT_REQUIRE_VERSION]", StatementMacros, - std::vector<std::string>({"QUNUSED", "QT_REQUIRE_VERSION"})); - - Style.IncludeStyle.IncludeCategories.clear(); - std::vector<tooling::IncludeStyle::IncludeCategory> ExpectedCategories = { - {"abc/.*", 2}, {".*", 1}}; - CHECK_PARSE("IncludeCategories:\n" - " - Regex: abc/.*\n" - " Priority: 2\n" - " - Regex: .*\n" - " Priority: 1", - IncludeStyle.IncludeCategories, ExpectedCategories); - CHECK_PARSE("IncludeIsMainRegex: 'abc$'", IncludeStyle.IncludeIsMainRegex, - "abc$"); - - Style.RawStringFormats.clear(); - std::vector<FormatStyle::RawStringFormat> ExpectedRawStringFormats = { - { - FormatStyle::LK_TextProto, - {"pb", "proto"}, - {"PARSE_TEXT_PROTO"}, - /*CanonicalDelimiter=*/"", - "llvm", - }, - { - FormatStyle::LK_Cpp, - {"cc", "cpp"}, - {"C_CODEBLOCK", "CPPEVAL"}, - /*CanonicalDelimiter=*/"cc", - /*BasedOnStyle=*/"", - }, - }; - - CHECK_PARSE("RawStringFormats:\n" - " - Language: TextProto\n" - " Delimiters:\n" - " - 'pb'\n" - " - 'proto'\n" - " EnclosingFunctions:\n" - " - 'PARSE_TEXT_PROTO'\n" - " BasedOnStyle: llvm\n" - " - Language: Cpp\n" - " Delimiters:\n" - " - 'cc'\n" - " - 'cpp'\n" - " EnclosingFunctions:\n" - " - 'C_CODEBLOCK'\n" - " - 'CPPEVAL'\n" - " CanonicalDelimiter: 'cc'", - RawStringFormats, ExpectedRawStringFormats); -} - -TEST_F(FormatTest, ParsesConfigurationWithLanguages) { - FormatStyle Style = {}; - Style.Language = FormatStyle::LK_Cpp; - CHECK_PARSE("Language: Cpp\n" - "IndentWidth: 12", - IndentWidth, 12u); - EXPECT_EQ(parseConfiguration("Language: JavaScript\n" - "IndentWidth: 34", - &Style), - ParseError::Unsuitable); - EXPECT_EQ(12u, Style.IndentWidth); - CHECK_PARSE("IndentWidth: 56", IndentWidth, 56u); - EXPECT_EQ(FormatStyle::LK_Cpp, Style.Language); - - Style.Language = FormatStyle::LK_JavaScript; - CHECK_PARSE("Language: JavaScript\n" - "IndentWidth: 12", - IndentWidth, 12u); - CHECK_PARSE("IndentWidth: 23", IndentWidth, 23u); - EXPECT_EQ(parseConfiguration("Language: Cpp\n" - "IndentWidth: 34", - &Style), - ParseError::Unsuitable); - EXPECT_EQ(23u, Style.IndentWidth); - CHECK_PARSE("IndentWidth: 56", IndentWidth, 56u); - EXPECT_EQ(FormatStyle::LK_JavaScript, Style.Language); - - CHECK_PARSE("BasedOnStyle: LLVM\n" - "IndentWidth: 67", - IndentWidth, 67u); - - CHECK_PARSE("---\n" - "Language: JavaScript\n" - "IndentWidth: 12\n" - "---\n" - "Language: Cpp\n" - "IndentWidth: 34\n" - "...\n", - IndentWidth, 12u); - - Style.Language = FormatStyle::LK_Cpp; - CHECK_PARSE("---\n" - "Language: JavaScript\n" - "IndentWidth: 12\n" - "---\n" - "Language: Cpp\n" - "IndentWidth: 34\n" - "...\n", - IndentWidth, 34u); - CHECK_PARSE("---\n" - "IndentWidth: 78\n" - "---\n" - "Language: JavaScript\n" - "IndentWidth: 56\n" - "...\n", - IndentWidth, 78u); - - Style.ColumnLimit = 123; - Style.IndentWidth = 234; - Style.BreakBeforeBraces = FormatStyle::BS_Linux; - Style.TabWidth = 345; - EXPECT_FALSE(parseConfiguration("---\n" - "IndentWidth: 456\n" - "BreakBeforeBraces: Allman\n" - "---\n" - "Language: JavaScript\n" - "IndentWidth: 111\n" - "TabWidth: 111\n" - "---\n" - "Language: Cpp\n" - "BreakBeforeBraces: Stroustrup\n" - "TabWidth: 789\n" - "...\n", - &Style)); - EXPECT_EQ(123u, Style.ColumnLimit); - EXPECT_EQ(456u, Style.IndentWidth); - EXPECT_EQ(FormatStyle::BS_Stroustrup, Style.BreakBeforeBraces); - EXPECT_EQ(789u, Style.TabWidth); - - EXPECT_EQ(parseConfiguration("---\n" - "Language: JavaScript\n" - "IndentWidth: 56\n" - "---\n" - "IndentWidth: 78\n" - "...\n", - &Style), - ParseError::Error); - EXPECT_EQ(parseConfiguration("---\n" - "Language: JavaScript\n" - "IndentWidth: 56\n" - "---\n" - "Language: JavaScript\n" - "IndentWidth: 78\n" - "...\n", - &Style), - ParseError::Error); - - EXPECT_EQ(FormatStyle::LK_Cpp, Style.Language); -} - -#undef CHECK_PARSE - -TEST_F(FormatTest, UsesLanguageForBasedOnStyle) { - FormatStyle Style = {}; - Style.Language = FormatStyle::LK_JavaScript; - Style.BreakBeforeTernaryOperators = true; - EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google", &Style).value()); - EXPECT_FALSE(Style.BreakBeforeTernaryOperators); - - Style.BreakBeforeTernaryOperators = true; - EXPECT_EQ(0, parseConfiguration("---\n" - "BasedOnStyle: Google\n" - "---\n" - "Language: JavaScript\n" - "IndentWidth: 76\n" - "...\n", - &Style) - .value()); - EXPECT_FALSE(Style.BreakBeforeTernaryOperators); - EXPECT_EQ(76u, Style.IndentWidth); - EXPECT_EQ(FormatStyle::LK_JavaScript, Style.Language); -} - -TEST_F(FormatTest, ConfigurationRoundTripTest) { - FormatStyle Style = getLLVMStyle(); - std::string YAML = configurationAsText(Style); - FormatStyle ParsedStyle = {}; - ParsedStyle.Language = FormatStyle::LK_Cpp; - EXPECT_EQ(0, parseConfiguration(YAML, &ParsedStyle).value()); - EXPECT_EQ(Style, ParsedStyle); -} - -TEST_F(FormatTest, WorksFor8bitEncodings) { - EXPECT_EQ("\"\xce\xe4\xed\xe0\xe6\xe4\xfb \xe2 \"\n" - "\"\xf1\xf2\xf3\xe4\xb8\xed\xf3\xfe \"\n" - "\"\xe7\xe8\xec\xed\xfe\xfe \"\n" - "\"\xef\xee\xf0\xf3...\"", - format("\"\xce\xe4\xed\xe0\xe6\xe4\xfb \xe2 " - "\xf1\xf2\xf3\xe4\xb8\xed\xf3\xfe \xe7\xe8\xec\xed\xfe\xfe " - "\xef\xee\xf0\xf3...\"", - getLLVMStyleWithColumns(12))); -} - -TEST_F(FormatTest, HandlesUTF8BOM) { - EXPECT_EQ("\xef\xbb\xbf", format("\xef\xbb\xbf")); - EXPECT_EQ("\xef\xbb\xbf#include <iostream>", - format("\xef\xbb\xbf#include <iostream>")); - EXPECT_EQ("\xef\xbb\xbf\n#include <iostream>", - format("\xef\xbb\xbf\n#include <iostream>")); -} - -// FIXME: Encode Cyrillic and CJK characters below to appease MS compilers. -#if !defined(_MSC_VER) - -TEST_F(FormatTest, CountsUTF8CharactersProperly) { - verifyFormat("\"Однажды в студёную зимнюю пору...\"", - getLLVMStyleWithColumns(35)); - verifyFormat("\"一 二 三 四 五 六 七 八 九 十\"", - getLLVMStyleWithColumns(31)); - verifyFormat("// Однажды в студёную зимнюю пору...", - getLLVMStyleWithColumns(36)); - verifyFormat("// 一 二 三 四 五 六 七 八 九 十", getLLVMStyleWithColumns(32)); - verifyFormat("/* Однажды в студёную зимнюю пору... */", - getLLVMStyleWithColumns(39)); - verifyFormat("/* 一 二 三 四 五 六 七 八 九 十 */", - getLLVMStyleWithColumns(35)); -} - -TEST_F(FormatTest, SplitsUTF8Strings) { - // Non-printable characters' width is currently considered to be the length in - // bytes in UTF8. The characters can be displayed in very different manner - // (zero-width, single width with a substitution glyph, expanded to their code - // (e.g. "<8d>"), so there's no single correct way to handle them. - EXPECT_EQ("\"aaaaÄ\"\n" - "\"\xc2\x8d\";", - format("\"aaaaÄ\xc2\x8d\";", getLLVMStyleWithColumns(10))); - EXPECT_EQ("\"aaaaaaaÄ\"\n" - "\"\xc2\x8d\";", - format("\"aaaaaaaÄ\xc2\x8d\";", getLLVMStyleWithColumns(10))); - EXPECT_EQ("\"Однажды, в \"\n" - "\"студёную \"\n" - "\"зимнюю \"\n" - "\"пору,\"", - format("\"Однажды, в студёную зимнюю пору,\"", - getLLVMStyleWithColumns(13))); - EXPECT_EQ( - "\"一 二 三 \"\n" - "\"四 五六 \"\n" - "\"七 八 九 \"\n" - "\"十\"", - format("\"一 二 三 四 五六 七 八 九 十\"", getLLVMStyleWithColumns(11))); - EXPECT_EQ("\"一\t\"\n" - "\"二 \t\"\n" - "\"三 四 \"\n" - "\"五\t\"\n" - "\"六 \t\"\n" - "\"七 \"\n" - "\"八九十\tqq\"", - format("\"一\t二 \t三 四 五\t六 \t七 八九十\tqq\"", - getLLVMStyleWithColumns(11))); - - // UTF8 character in an escape sequence. - EXPECT_EQ("\"aaaaaa\"\n" - "\"\\\xC2\x8D\"", - format("\"aaaaaa\\\xC2\x8D\"", getLLVMStyleWithColumns(10))); -} - -TEST_F(FormatTest, HandlesDoubleWidthCharsInMultiLineStrings) { - EXPECT_EQ("const char *sssss =\n" - " \"一二三四五六七八\\\n" - " 九 十\";", - format("const char *sssss = \"一二三四五六七八\\\n" - " 九 十\";", - getLLVMStyleWithColumns(30))); -} - -TEST_F(FormatTest, SplitsUTF8LineComments) { - EXPECT_EQ("// aaaaÄ\xc2\x8d", - format("// aaaaÄ\xc2\x8d", getLLVMStyleWithColumns(10))); - EXPECT_EQ("// Я из лесу\n" - "// вышел; был\n" - "// сильный\n" - "// мороз.", - format("// Я из лесу вышел; был сильный мороз.", - getLLVMStyleWithColumns(13))); - EXPECT_EQ("// 一二三\n" - "// 四五六七\n" - "// 八 九\n" - "// 十", - format("// 一二三 四五六七 八 九 十", getLLVMStyleWithColumns(9))); -} - -TEST_F(FormatTest, SplitsUTF8BlockComments) { - EXPECT_EQ("/* Гляжу,\n" - " * поднимается\n" - " * медленно в\n" - " * гору\n" - " * Лошадка,\n" - " * везущая\n" - " * хворосту\n" - " * воз. */", - format("/* Гляжу, поднимается медленно в гору\n" - " * Лошадка, везущая хворосту воз. */", - getLLVMStyleWithColumns(13))); - EXPECT_EQ( - "/* 一二三\n" - " * 四五六七\n" - " * 八 九\n" - " * 十 */", - format("/* 一二三 四五六七 八 九 十 */", getLLVMStyleWithColumns(9))); - EXPECT_EQ("/* 𝓣𝓮𝓼𝓽 𝔣𝔬𝔲𝔯\n" - " * 𝕓𝕪𝕥𝕖\n" - " * 𝖀𝕿𝕱-𝟠 */", - format("/* 𝓣𝓮𝓼𝓽 𝔣𝔬𝔲𝔯 𝕓𝕪𝕥𝕖 𝖀𝕿𝕱-𝟠 */", getLLVMStyleWithColumns(12))); -} - -#endif // _MSC_VER - -TEST_F(FormatTest, ConstructorInitializerIndentWidth) { - FormatStyle Style = getLLVMStyle(); - - Style.ConstructorInitializerIndentWidth = 4; - verifyFormat( - "SomeClass::Constructor()\n" - " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", - Style); - - Style.ConstructorInitializerIndentWidth = 2; - verifyFormat( - "SomeClass::Constructor()\n" - " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", - Style); - - Style.ConstructorInitializerIndentWidth = 0; - verifyFormat( - "SomeClass::Constructor()\n" - ": aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" - " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", - Style); - Style.AlignAfterOpenBracket = FormatStyle::BAS_AlwaysBreak; - verifyFormat( - "SomeLongTemplateVariableName<\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>", - Style); - verifyFormat( - "bool smaller = 1 < bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", - Style); -} - -TEST_F(FormatTest, BreakConstructorInitializersBeforeComma) { - FormatStyle Style = getLLVMStyle(); - Style.BreakConstructorInitializers = FormatStyle::BCIS_BeforeComma; - Style.ConstructorInitializerIndentWidth = 4; - verifyFormat("SomeClass::Constructor()\n" - " : a(a)\n" - " , b(b)\n" - " , c(c) {}", - Style); - verifyFormat("SomeClass::Constructor()\n" - " : a(a) {}", - Style); - - Style.ColumnLimit = 0; - verifyFormat("SomeClass::Constructor()\n" - " : a(a) {}", - Style); - verifyFormat("SomeClass::Constructor() noexcept\n" - " : a(a) {}", - Style); - verifyFormat("SomeClass::Constructor()\n" - " : a(a)\n" - " , b(b)\n" - " , c(c) {}", - Style); - verifyFormat("SomeClass::Constructor()\n" - " : a(a) {\n" - " foo();\n" - " bar();\n" - "}", - Style); - - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; - verifyFormat("SomeClass::Constructor()\n" - " : a(a)\n" - " , b(b)\n" - " , c(c) {\n}", - Style); - verifyFormat("SomeClass::Constructor()\n" - " : a(a) {\n}", - Style); - - Style.ColumnLimit = 80; - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All; - Style.ConstructorInitializerIndentWidth = 2; - verifyFormat("SomeClass::Constructor()\n" - " : a(a)\n" - " , b(b)\n" - " , c(c) {}", - Style); - - Style.ConstructorInitializerIndentWidth = 0; - verifyFormat("SomeClass::Constructor()\n" - ": a(a)\n" - ", b(b)\n" - ", c(c) {}", - Style); - - Style.ConstructorInitializerAllOnOneLineOrOnePerLine = true; - Style.ConstructorInitializerIndentWidth = 4; - verifyFormat("SomeClass::Constructor() : aaaaaaaa(aaaaaaaa) {}", Style); - verifyFormat( - "SomeClass::Constructor() : aaaaa(aaaaa), aaaaa(aaaaa), aaaaa(aaaaa)\n", - Style); - verifyFormat( - "SomeClass::Constructor()\n" - " : aaaaaaaa(aaaaaaaa), aaaaaaaa(aaaaaaaa), aaaaaaaa(aaaaaaaa) {}", - Style); - Style.ConstructorInitializerIndentWidth = 4; - Style.ColumnLimit = 60; - verifyFormat("SomeClass::Constructor()\n" - " : aaaaaaaa(aaaaaaaa)\n" - " , aaaaaaaa(aaaaaaaa)\n" - " , aaaaaaaa(aaaaaaaa) {}", - Style); -} - -TEST_F(FormatTest, Destructors) { - verifyFormat("void F(int &i) { i.~int(); }"); - verifyFormat("void F(int &i) { i->~int(); }"); -} - -TEST_F(FormatTest, FormatsWithWebKitStyle) { - FormatStyle Style = getWebKitStyle(); - - // Don't indent in outer namespaces. - verifyFormat("namespace outer {\n" - "int i;\n" - "namespace inner {\n" - " int i;\n" - "} // namespace inner\n" - "} // namespace outer\n" - "namespace other_outer {\n" - "int i;\n" - "}", - Style); - - // Don't indent case labels. - verifyFormat("switch (variable) {\n" - "case 1:\n" - "case 2:\n" - " doSomething();\n" - " break;\n" - "default:\n" - " ++variable;\n" - "}", - Style); - - // Wrap before binary operators. - EXPECT_EQ("void f()\n" - "{\n" - " if (aaaaaaaaaaaaaaaa\n" - " && bbbbbbbbbbbbbbbbbbbbbbbb\n" - " && (cccccccccccccccccccccccccc || dddddddddddddddddddd))\n" - " return;\n" - "}", - format("void f() {\n" - "if (aaaaaaaaaaaaaaaa\n" - "&& bbbbbbbbbbbbbbbbbbbbbbbb\n" - "&& (cccccccccccccccccccccccccc || dddddddddddddddddddd))\n" - "return;\n" - "}", - Style)); - - // Allow functions on a single line. - verifyFormat("void f() { return; }", Style); - - // Constructor initializers are formatted one per line with the "," on the - // new line. - verifyFormat("Constructor()\n" - " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " , aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaa, // break\n" - " aaaaaaaaaaaaaa)\n" - " , aaaaaaaaaaaaaaaaaaaaaaa()\n" - "{\n" - "}", - Style); - verifyFormat("SomeClass::Constructor()\n" - " : a(a)\n" - "{\n" - "}", - Style); - EXPECT_EQ("SomeClass::Constructor()\n" - " : a(a)\n" - "{\n" - "}", - format("SomeClass::Constructor():a(a){}", Style)); - verifyFormat("SomeClass::Constructor()\n" - " : a(a)\n" - " , b(b)\n" - " , c(c)\n" - "{\n" - "}", - Style); - verifyFormat("SomeClass::Constructor()\n" - " : a(a)\n" - "{\n" - " foo();\n" - " bar();\n" - "}", - Style); - - // Access specifiers should be aligned left. - verifyFormat("class C {\n" - "public:\n" - " int i;\n" - "};", - Style); - - // Do not align comments. - verifyFormat("int a; // Do not\n" - "double b; // align comments.", - Style); - - // Do not align operands. - EXPECT_EQ("ASSERT(aaaa\n" - " || bbbb);", - format("ASSERT ( aaaa\n||bbbb);", Style)); - - // Accept input's line breaks. - EXPECT_EQ("if (aaaaaaaaaaaaaaa\n" - " || bbbbbbbbbbbbbbb) {\n" - " i++;\n" - "}", - format("if (aaaaaaaaaaaaaaa\n" - "|| bbbbbbbbbbbbbbb) { i++; }", - Style)); - EXPECT_EQ("if (aaaaaaaaaaaaaaa || bbbbbbbbbbbbbbb) {\n" - " i++;\n" - "}", - format("if (aaaaaaaaaaaaaaa || bbbbbbbbbbbbbbb) { i++; }", Style)); - - // Don't automatically break all macro definitions (llvm.org/PR17842). - verifyFormat("#define aNumber 10", Style); - // However, generally keep the line breaks that the user authored. - EXPECT_EQ("#define aNumber \\\n" - " 10", - format("#define aNumber \\\n" - " 10", - Style)); - - // Keep empty and one-element array literals on a single line. - EXPECT_EQ("NSArray* a = [[NSArray alloc] initWithArray:@[]\n" - " copyItems:YES];", - format("NSArray*a=[[NSArray alloc] initWithArray:@[]\n" - "copyItems:YES];", - Style)); - EXPECT_EQ("NSArray* a = [[NSArray alloc] initWithArray:@[ @\"a\" ]\n" - " copyItems:YES];", - format("NSArray*a=[[NSArray alloc]initWithArray:@[ @\"a\" ]\n" - " copyItems:YES];", - Style)); - // FIXME: This does not seem right, there should be more indentation before - // the array literal's entries. Nested blocks have the same problem. - EXPECT_EQ("NSArray* a = [[NSArray alloc] initWithArray:@[\n" - " @\"a\",\n" - " @\"a\"\n" - "]\n" - " copyItems:YES];", - format("NSArray* a = [[NSArray alloc] initWithArray:@[\n" - " @\"a\",\n" - " @\"a\"\n" - " ]\n" - " copyItems:YES];", - Style)); - EXPECT_EQ( - "NSArray* a = [[NSArray alloc] initWithArray:@[ @\"a\", @\"a\" ]\n" - " copyItems:YES];", - format("NSArray* a = [[NSArray alloc] initWithArray:@[ @\"a\", @\"a\" ]\n" - " copyItems:YES];", - Style)); - - verifyFormat("[self.a b:c c:d];", Style); - EXPECT_EQ("[self.a b:c\n" - " c:d];", - format("[self.a b:c\n" - "c:d];", - Style)); -} - -TEST_F(FormatTest, FormatsLambdas) { - verifyFormat("int c = [b]() mutable { return [&b] { return b++; }(); }();\n"); - verifyFormat("int c = [&] { [=] { return b++; }(); }();\n"); - verifyFormat("int c = [&, &a, a] { [=, c, &d] { return b++; }(); }();\n"); - verifyFormat("int c = [&a, &a, a] { [=, a, b, &c] { return b++; }(); }();\n"); - verifyFormat("auto c = {[&a, &a, a] { [=, a, b, &c] { return b++; }(); }}\n"); - verifyFormat("auto c = {[&a, &a, a] { [=, a, b, &c] {}(); }}\n"); - verifyFormat("auto c = [a = [b = 42] {}] {};\n"); - verifyFormat("auto c = [a = &i + 10, b = [] {}] {};\n"); - verifyFormat("int x = f(*+[] {});"); - verifyFormat("void f() {\n" - " other(x.begin(), x.end(), [&](int, int) { return 1; });\n" - "}\n"); - verifyFormat("void f() {\n" - " other(x.begin(), //\n" - " x.end(), //\n" - " [&](int, int) { return 1; });\n" - "}\n"); - verifyFormat("void f() {\n" - " other.other.other.other.other(\n" - " x.begin(), x.end(),\n" - " [something, rather](int, int, int, int, int, int, int) { return 1; });\n" - "}\n"); - verifyFormat("void f() {\n" - " other.other.other.other.other(\n" - " x.begin(), x.end(),\n" - " [something, rather](int, int, int, int, int, int, int) {\n" - " //\n" - " });\n" - "}\n"); - verifyFormat("SomeFunction([]() { // A cool function...\n" - " return 43;\n" - "});"); - EXPECT_EQ("SomeFunction([]() {\n" - "#define A a\n" - " return 43;\n" - "});", - format("SomeFunction([](){\n" - "#define A a\n" - "return 43;\n" - "});")); - verifyFormat("void f() {\n" - " SomeFunction([](decltype(x), A *a) {});\n" - "}"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " [](const aaaaaaaaaa &a) { return a; });"); - verifyFormat("string abc = SomeFunction(aaaaaaaaaaaaa, aaaaa, []() {\n" - " SomeOtherFunctioooooooooooooooooooooooooon();\n" - "});"); - verifyFormat("Constructor()\n" - " : Field([] { // comment\n" - " int i;\n" - " }) {}"); - verifyFormat("auto my_lambda = [](const string &some_parameter) {\n" - " return some_parameter.size();\n" - "};"); - verifyFormat("std::function<std::string(const std::string &)> my_lambda =\n" - " [](const string &s) { return s; };"); - verifyFormat("int i = aaaaaa ? 1 //\n" - " : [] {\n" - " return 2; //\n" - " }();"); - verifyFormat("llvm::errs() << \"number of twos is \"\n" - " << std::count_if(v.begin(), v.end(), [](int x) {\n" - " return x == 2; // force break\n" - " });"); - verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " [=](int iiiiiiiiiiii) {\n" - " return aaaaaaaaaaaaaaaaaaaaaaa !=\n" - " aaaaaaaaaaaaaaaaaaaaaaa;\n" - " });", - getLLVMStyleWithColumns(60)); - verifyFormat("SomeFunction({[&] {\n" - " // comment\n" - " },\n" - " [&] {\n" - " // comment\n" - " }});"); - verifyFormat("SomeFunction({[&] {\n" - " // comment\n" - "}});"); - verifyFormat("virtual aaaaaaaaaaaaaaaa(\n" - " std::function<bool()> bbbbbbbbbbbb = [&]() { return true; },\n" - " aaaaa aaaaaaaaa);"); - - // Lambdas with return types. - verifyFormat("int c = []() -> int { return 2; }();\n"); - verifyFormat("int c = []() -> int * { return 2; }();\n"); - verifyFormat("int c = []() -> vector<int> { return {2}; }();\n"); - verifyFormat("Foo([]() -> std::vector<int> { return {2}; }());"); - verifyGoogleFormat("auto a = [&b, c](D* d) -> D* {};"); - verifyGoogleFormat("auto a = [&b, c](D* d) -> pair<D*, D*> {};"); - verifyGoogleFormat("auto a = [&b, c](D* d) -> D& {};"); - verifyGoogleFormat("auto a = [&b, c](D* d) -> const D* {};"); - verifyFormat("[a, a]() -> a<1> {};"); - verifyFormat("auto aaaaaaaa = [](int i, // break for some reason\n" - " int j) -> int {\n" - " return ffffffffffffffffffffffffffffffffffffffffffff(i * j);\n" - "};"); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaa(\n" - " [](aaaaaaaaaaaaaaaaaaaaaaaaaaa &aaa) -> aaaaaaaaaaaaaaaa {\n" - " return aaaaaaaaaaaaaaaaa;\n" - " });", - getLLVMStyleWithColumns(70)); - verifyFormat("[]() //\n" - " -> int {\n" - " return 1; //\n" - "};"); - - // Multiple lambdas in the same parentheses change indentation rules. These - // lambdas are forced to start on new lines. - verifyFormat("SomeFunction(\n" - " []() {\n" - " //\n" - " },\n" - " []() {\n" - " //\n" - " });"); - - // A lambda passed as arg0 is always pushed to the next line. - verifyFormat("SomeFunction(\n" - " [this] {\n" - " //\n" - " },\n" - " 1);\n"); - - // A multi-line lambda passed as arg1 forces arg0 to be pushed out, just like the arg0 - // case above. - auto Style = getGoogleStyle(); - Style.BinPackArguments = false; - verifyFormat("SomeFunction(\n" - " a,\n" - " [this] {\n" - " //\n" - " },\n" - " b);\n", - Style); - verifyFormat("SomeFunction(\n" - " a,\n" - " [this] {\n" - " //\n" - " },\n" - " b);\n"); - - // A lambda with a very long line forces arg0 to be pushed out irrespective of - // the BinPackArguments value (as long as the code is wide enough). - verifyFormat("something->SomeFunction(\n" - " a,\n" - " [this] {\n" - " D0000000000000000000000000000000000000000000000000000000000001();\n" - " },\n" - " b);\n"); - - // A multi-line lambda is pulled up as long as the introducer fits on the previous - // line and there are no further args. - verifyFormat("function(1, [this, that] {\n" - " //\n" - "});\n"); - verifyFormat("function([this, that] {\n" - " //\n" - "});\n"); - // FIXME: this format is not ideal and we should consider forcing the first arg - // onto its own line. - verifyFormat("function(a, b, c, //\n" - " d, [this, that] {\n" - " //\n" - " });\n"); - - // Multiple lambdas are treated correctly even when there is a short arg0. - verifyFormat("SomeFunction(\n" - " 1,\n" - " [this] {\n" - " //\n" - " },\n" - " [this] {\n" - " //\n" - " },\n" - " 1);\n"); - - // More complex introducers. - verifyFormat("return [i, args...] {};"); - - // Not lambdas. - verifyFormat("constexpr char hello[]{\"hello\"};"); - verifyFormat("double &operator[](int i) { return 0; }\n" - "int i;"); - verifyFormat("std::unique_ptr<int[]> foo() {}"); - verifyFormat("int i = a[a][a]->f();"); - verifyFormat("int i = (*b)[a]->f();"); - - // Other corner cases. - verifyFormat("void f() {\n" - " bar([]() {} // Did not respect SpacesBeforeTrailingComments\n" - " );\n" - "}"); - - // Lambdas created through weird macros. - verifyFormat("void f() {\n" - " MACRO((const AA &a) { return 1; });\n" - " MACRO((AA &a) { return 1; });\n" - "}"); - - verifyFormat("if (blah_blah(whatever, whatever, [] {\n" - " doo_dah();\n" - " doo_dah();\n" - " })) {\n" - "}"); - verifyFormat("if constexpr (blah_blah(whatever, whatever, [] {\n" - " doo_dah();\n" - " doo_dah();\n" - " })) {\n" - "}"); - verifyFormat("auto lambda = []() {\n" - " int a = 2\n" - "#if A\n" - " + 2\n" - "#endif\n" - " ;\n" - "};"); - - // Lambdas with complex multiline introducers. - verifyFormat( - "aaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]()\n" - " -> ::std::unordered_set<\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> {\n" - " //\n" - " });"); -} - -TEST_F(FormatTest, EmptyLinesInLambdas) { - verifyFormat("auto lambda = []() {\n" - " x(); //\n" - "};", - "auto lambda = []() {\n" - "\n" - " x(); //\n" - "\n" - "};"); -} - -TEST_F(FormatTest, FormatsBlocks) { - FormatStyle ShortBlocks = getLLVMStyle(); - ShortBlocks.AllowShortBlocksOnASingleLine = true; - verifyFormat("int (^Block)(int, int);", ShortBlocks); - verifyFormat("int (^Block1)(int, int) = ^(int i, int j)", ShortBlocks); - verifyFormat("void (^block)(int) = ^(id test) { int i; };", ShortBlocks); - verifyFormat("void (^block)(int) = ^(int test) { int i; };", ShortBlocks); - verifyFormat("void (^block)(int) = ^id(int test) { int i; };", ShortBlocks); - verifyFormat("void (^block)(int) = ^int(int test) { int i; };", ShortBlocks); - - verifyFormat("foo(^{ bar(); });", ShortBlocks); - verifyFormat("foo(a, ^{ bar(); });", ShortBlocks); - verifyFormat("{ void (^block)(Object *x); }", ShortBlocks); - - verifyFormat("[operation setCompletionBlock:^{\n" - " [self onOperationDone];\n" - "}];"); - verifyFormat("int i = {[operation setCompletionBlock:^{\n" - " [self onOperationDone];\n" - "}]};"); - verifyFormat("[operation setCompletionBlock:^(int *i) {\n" - " f();\n" - "}];"); - verifyFormat("int a = [operation block:^int(int *i) {\n" - " return 1;\n" - "}];"); - verifyFormat("[myObject doSomethingWith:arg1\n" - " aaa:^int(int *a) {\n" - " return 1;\n" - " }\n" - " bbb:f(a * bbbbbbbb)];"); - - verifyFormat("[operation setCompletionBlock:^{\n" - " [self.delegate newDataAvailable];\n" - "}];", - getLLVMStyleWithColumns(60)); - verifyFormat("dispatch_async(_fileIOQueue, ^{\n" - " NSString *path = [self sessionFilePath];\n" - " if (path) {\n" - " // ...\n" - " }\n" - "});"); - verifyFormat("[[SessionService sharedService]\n" - " loadWindowWithCompletionBlock:^(SessionWindow *window) {\n" - " if (window) {\n" - " [self windowDidLoad:window];\n" - " } else {\n" - " [self errorLoadingWindow];\n" - " }\n" - " }];"); - verifyFormat("void (^largeBlock)(void) = ^{\n" - " // ...\n" - "};\n", - getLLVMStyleWithColumns(40)); - verifyFormat("[[SessionService sharedService]\n" - " loadWindowWithCompletionBlock: //\n" - " ^(SessionWindow *window) {\n" - " if (window) {\n" - " [self windowDidLoad:window];\n" - " } else {\n" - " [self errorLoadingWindow];\n" - " }\n" - " }];", - getLLVMStyleWithColumns(60)); - verifyFormat("[myObject doSomethingWith:arg1\n" - " firstBlock:^(Foo *a) {\n" - " // ...\n" - " int i;\n" - " }\n" - " secondBlock:^(Bar *b) {\n" - " // ...\n" - " int i;\n" - " }\n" - " thirdBlock:^Foo(Bar *b) {\n" - " // ...\n" - " int i;\n" - " }];"); - verifyFormat("[myObject doSomethingWith:arg1\n" - " firstBlock:-1\n" - " secondBlock:^(Bar *b) {\n" - " // ...\n" - " int i;\n" - " }];"); - - verifyFormat("f(^{\n" - " @autoreleasepool {\n" - " if (a) {\n" - " g();\n" - " }\n" - " }\n" - "});"); - verifyFormat("Block b = ^int *(A *a, B *b) {}"); - verifyFormat("BOOL (^aaa)(void) = ^BOOL {\n" - "};"); - - FormatStyle FourIndent = getLLVMStyle(); - FourIndent.ObjCBlockIndentWidth = 4; - verifyFormat("[operation setCompletionBlock:^{\n" - " [self onOperationDone];\n" - "}];", - FourIndent); -} - -TEST_F(FormatTest, FormatsBlocksWithZeroColumnWidth) { - FormatStyle ZeroColumn = getLLVMStyle(); - ZeroColumn.ColumnLimit = 0; - - verifyFormat("[[SessionService sharedService] " - "loadWindowWithCompletionBlock:^(SessionWindow *window) {\n" - " if (window) {\n" - " [self windowDidLoad:window];\n" - " } else {\n" - " [self errorLoadingWindow];\n" - " }\n" - "}];", - ZeroColumn); - EXPECT_EQ("[[SessionService sharedService]\n" - " loadWindowWithCompletionBlock:^(SessionWindow *window) {\n" - " if (window) {\n" - " [self windowDidLoad:window];\n" - " } else {\n" - " [self errorLoadingWindow];\n" - " }\n" - " }];", - format("[[SessionService sharedService]\n" - "loadWindowWithCompletionBlock:^(SessionWindow *window) {\n" - " if (window) {\n" - " [self windowDidLoad:window];\n" - " } else {\n" - " [self errorLoadingWindow];\n" - " }\n" - "}];", - ZeroColumn)); - verifyFormat("[myObject doSomethingWith:arg1\n" - " firstBlock:^(Foo *a) {\n" - " // ...\n" - " int i;\n" - " }\n" - " secondBlock:^(Bar *b) {\n" - " // ...\n" - " int i;\n" - " }\n" - " thirdBlock:^Foo(Bar *b) {\n" - " // ...\n" - " int i;\n" - " }];", - ZeroColumn); - verifyFormat("f(^{\n" - " @autoreleasepool {\n" - " if (a) {\n" - " g();\n" - " }\n" - " }\n" - "});", - ZeroColumn); - verifyFormat("void (^largeBlock)(void) = ^{\n" - " // ...\n" - "};", - ZeroColumn); - - ZeroColumn.AllowShortBlocksOnASingleLine = true; - EXPECT_EQ("void (^largeBlock)(void) = ^{ int i; };", - format("void (^largeBlock)(void) = ^{ int i; };", ZeroColumn)); - ZeroColumn.AllowShortBlocksOnASingleLine = false; - EXPECT_EQ("void (^largeBlock)(void) = ^{\n" - " int i;\n" - "};", - format("void (^largeBlock)(void) = ^{ int i; };", ZeroColumn)); -} - -TEST_F(FormatTest, SupportsCRLF) { - EXPECT_EQ("int a;\r\n" - "int b;\r\n" - "int c;\r\n", - format("int a;\r\n" - " int b;\r\n" - " int c;\r\n", - getLLVMStyle())); - EXPECT_EQ("int a;\r\n" - "int b;\r\n" - "int c;\r\n", - format("int a;\r\n" - " int b;\n" - " int c;\r\n", - getLLVMStyle())); - EXPECT_EQ("int a;\n" - "int b;\n" - "int c;\n", - format("int a;\r\n" - " int b;\n" - " int c;\n", - getLLVMStyle())); - EXPECT_EQ("\"aaaaaaa \"\r\n" - "\"bbbbbbb\";\r\n", - format("\"aaaaaaa bbbbbbb\";\r\n", getLLVMStyleWithColumns(10))); - EXPECT_EQ("#define A \\\r\n" - " b; \\\r\n" - " c; \\\r\n" - " d;\r\n", - format("#define A \\\r\n" - " b; \\\r\n" - " c; d; \r\n", - getGoogleStyle())); - - EXPECT_EQ("/*\r\n" - "multi line block comments\r\n" - "should not introduce\r\n" - "an extra carriage return\r\n" - "*/\r\n", - format("/*\r\n" - "multi line block comments\r\n" - "should not introduce\r\n" - "an extra carriage return\r\n" - "*/\r\n")); -} - -TEST_F(FormatTest, MunchSemicolonAfterBlocks) { - verifyFormat("MY_CLASS(C) {\n" - " int i;\n" - " int j;\n" - "};"); -} - -TEST_F(FormatTest, ConfigurableContinuationIndentWidth) { - FormatStyle TwoIndent = getLLVMStyleWithColumns(15); - TwoIndent.ContinuationIndentWidth = 2; - - EXPECT_EQ("int i =\n" - " longFunction(\n" - " arg);", - format("int i = longFunction(arg);", TwoIndent)); - - FormatStyle SixIndent = getLLVMStyleWithColumns(20); - SixIndent.ContinuationIndentWidth = 6; - - EXPECT_EQ("int i =\n" - " longFunction(\n" - " arg);", - format("int i = longFunction(arg);", SixIndent)); -} - -TEST_F(FormatTest, SpacesInAngles) { - FormatStyle Spaces = getLLVMStyle(); - Spaces.SpacesInAngles = true; - - verifyFormat("static_cast< int >(arg);", Spaces); - verifyFormat("template < typename T0, typename T1 > void f() {}", Spaces); - verifyFormat("f< int, float >();", Spaces); - verifyFormat("template <> g() {}", Spaces); - verifyFormat("template < std::vector< int > > f() {}", Spaces); - verifyFormat("std::function< void(int, int) > fct;", Spaces); - verifyFormat("void inFunction() { std::function< void(int, int) > fct; }", - Spaces); - - Spaces.Standard = FormatStyle::LS_Cpp03; - Spaces.SpacesInAngles = true; - verifyFormat("A< A< int > >();", Spaces); - - Spaces.SpacesInAngles = false; - verifyFormat("A<A<int> >();", Spaces); - - Spaces.Standard = FormatStyle::LS_Cpp11; - Spaces.SpacesInAngles = true; - verifyFormat("A< A< int > >();", Spaces); - - Spaces.SpacesInAngles = false; - verifyFormat("A<A<int>>();", Spaces); -} - -TEST_F(FormatTest, SpaceAfterTemplateKeyword) { - FormatStyle Style = getLLVMStyle(); - Style.SpaceAfterTemplateKeyword = false; - verifyFormat("template<int> void foo();", Style); -} - -TEST_F(FormatTest, TripleAngleBrackets) { - verifyFormat("f<<<1, 1>>>();"); - verifyFormat("f<<<1, 1, 1, s>>>();"); - verifyFormat("f<<<a, b, c, d>>>();"); - EXPECT_EQ("f<<<1, 1>>>();", format("f <<< 1, 1 >>> ();")); - verifyFormat("f<param><<<1, 1>>>();"); - verifyFormat("f<1><<<1, 1>>>();"); - EXPECT_EQ("f<param><<<1, 1>>>();", format("f< param > <<< 1, 1 >>> ();")); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" - "aaaaaaaaaaa<<<\n 1, 1>>>();"); - verifyFormat("aaaaaaaaaaaaaaa<aaaaaaaaa, aaaaaaaaaa, aaaaaaaaaaaaaa>\n" - " <<<aaaaaaaaa, aaaaaaaaaa, aaaaaaaaaaaaaaaaaa>>>();"); -} - -TEST_F(FormatTest, MergeLessLessAtEnd) { - verifyFormat("<<"); - EXPECT_EQ("< < <", format("\\\n<<<")); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" - "aaallvm::outs() <<"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" - "aaaallvm::outs()\n <<"); -} - -TEST_F(FormatTest, HandleUnbalancedImplicitBracesAcrossPPBranches) { - std::string code = "#if A\n" - "#if B\n" - "a.\n" - "#endif\n" - " a = 1;\n" - "#else\n" - "#endif\n" - "#if C\n" - "#else\n" - "#endif\n"; - EXPECT_EQ(code, format(code)); -} - -TEST_F(FormatTest, HandleConflictMarkers) { - // Git/SVN conflict markers. - EXPECT_EQ("int a;\n" - "void f() {\n" - " callme(some(parameter1,\n" - "<<<<<<< text by the vcs\n" - " parameter2),\n" - "||||||| text by the vcs\n" - " parameter2),\n" - " parameter3,\n" - "======= text by the vcs\n" - " parameter2, parameter3),\n" - ">>>>>>> text by the vcs\n" - " otherparameter);\n", - format("int a;\n" - "void f() {\n" - " callme(some(parameter1,\n" - "<<<<<<< text by the vcs\n" - " parameter2),\n" - "||||||| text by the vcs\n" - " parameter2),\n" - " parameter3,\n" - "======= text by the vcs\n" - " parameter2,\n" - " parameter3),\n" - ">>>>>>> text by the vcs\n" - " otherparameter);\n")); - - // Perforce markers. - EXPECT_EQ("void f() {\n" - " function(\n" - ">>>> text by the vcs\n" - " parameter,\n" - "==== text by the vcs\n" - " parameter,\n" - "==== text by the vcs\n" - " parameter,\n" - "<<<< text by the vcs\n" - " parameter);\n", - format("void f() {\n" - " function(\n" - ">>>> text by the vcs\n" - " parameter,\n" - "==== text by the vcs\n" - " parameter,\n" - "==== text by the vcs\n" - " parameter,\n" - "<<<< text by the vcs\n" - " parameter);\n")); - - EXPECT_EQ("<<<<<<<\n" - "|||||||\n" - "=======\n" - ">>>>>>>", - format("<<<<<<<\n" - "|||||||\n" - "=======\n" - ">>>>>>>")); - - EXPECT_EQ("<<<<<<<\n" - "|||||||\n" - "int i;\n" - "=======\n" - ">>>>>>>", - format("<<<<<<<\n" - "|||||||\n" - "int i;\n" - "=======\n" - ">>>>>>>")); - - // FIXME: Handle parsing of macros around conflict markers correctly: - EXPECT_EQ("#define Macro \\\n" - "<<<<<<<\n" - "Something \\\n" - "|||||||\n" - "Else \\\n" - "=======\n" - "Other \\\n" - ">>>>>>>\n" - " End int i;\n", - format("#define Macro \\\n" - "<<<<<<<\n" - " Something \\\n" - "|||||||\n" - " Else \\\n" - "=======\n" - " Other \\\n" - ">>>>>>>\n" - " End\n" - "int i;\n")); -} - -TEST_F(FormatTest, DisableRegions) { - EXPECT_EQ("int i;\n" - "// clang-format off\n" - " int j;\n" - "// clang-format on\n" - "int k;", - format(" int i;\n" - " // clang-format off\n" - " int j;\n" - " // clang-format on\n" - " int k;")); - EXPECT_EQ("int i;\n" - "/* clang-format off */\n" - " int j;\n" - "/* clang-format on */\n" - "int k;", - format(" int i;\n" - " /* clang-format off */\n" - " int j;\n" - " /* clang-format on */\n" - " int k;")); - - // Don't reflow comments within disabled regions. - EXPECT_EQ( - "// clang-format off\n" - "// long long long long long long line\n" - "/* clang-format on */\n" - "/* long long long\n" - " * long long long\n" - " * line */\n" - "int i;\n" - "/* clang-format off */\n" - "/* long long long long long long line */\n", - format("// clang-format off\n" - "// long long long long long long line\n" - "/* clang-format on */\n" - "/* long long long long long long line */\n" - "int i;\n" - "/* clang-format off */\n" - "/* long long long long long long line */\n", - getLLVMStyleWithColumns(20))); -} - -TEST_F(FormatTest, DoNotCrashOnInvalidInput) { - format("? ) ="); - verifyNoCrash("#define a\\\n /**/}"); -} - -TEST_F(FormatTest, FormatsTableGenCode) { - FormatStyle Style = getLLVMStyle(); - Style.Language = FormatStyle::LK_TableGen; - verifyFormat("include \"a.td\"\ninclude \"b.td\"", Style); -} - -TEST_F(FormatTest, ArrayOfTemplates) { - EXPECT_EQ("auto a = new unique_ptr<int>[10];", - format("auto a = new unique_ptr<int > [ 10];")); - - FormatStyle Spaces = getLLVMStyle(); - Spaces.SpacesInSquareBrackets = true; - EXPECT_EQ("auto a = new unique_ptr<int>[ 10 ];", - format("auto a = new unique_ptr<int > [10];", Spaces)); -} - -TEST_F(FormatTest, ArrayAsTemplateType) { - EXPECT_EQ("auto a = unique_ptr<Foo<Bar>[10]>;", - format("auto a = unique_ptr < Foo < Bar>[ 10]> ;")); - - FormatStyle Spaces = getLLVMStyle(); - Spaces.SpacesInSquareBrackets = true; - EXPECT_EQ("auto a = unique_ptr<Foo<Bar>[ 10 ]>;", - format("auto a = unique_ptr < Foo < Bar>[10]> ;", Spaces)); -} - -TEST_F(FormatTest, NoSpaceAfterSuper) { - verifyFormat("__super::FooBar();"); -} - -TEST(FormatStyle, GetStyleWithEmptyFileName) { - llvm::vfs::InMemoryFileSystem FS; - auto Style1 = getStyle("file", "", "Google", "", &FS); - ASSERT_TRUE((bool)Style1); - ASSERT_EQ(*Style1, getGoogleStyle()); -} - -TEST(FormatStyle, GetStyleOfFile) { - llvm::vfs::InMemoryFileSystem FS; - // Test 1: format file in the same directory. - ASSERT_TRUE( - FS.addFile("/a/.clang-format", 0, - llvm::MemoryBuffer::getMemBuffer("BasedOnStyle: LLVM"))); - ASSERT_TRUE( - FS.addFile("/a/test.cpp", 0, llvm::MemoryBuffer::getMemBuffer("int i;"))); - auto Style1 = getStyle("file", "/a/.clang-format", "Google", "", &FS); - ASSERT_TRUE((bool)Style1); - ASSERT_EQ(*Style1, getLLVMStyle()); - - // Test 2.1: fallback to default. - ASSERT_TRUE( - FS.addFile("/b/test.cpp", 0, llvm::MemoryBuffer::getMemBuffer("int i;"))); - auto Style2 = getStyle("file", "/b/test.cpp", "Mozilla", "", &FS); - ASSERT_TRUE((bool)Style2); - ASSERT_EQ(*Style2, getMozillaStyle()); - - // Test 2.2: no format on 'none' fallback style. - Style2 = getStyle("file", "/b/test.cpp", "none", "", &FS); - ASSERT_TRUE((bool)Style2); - ASSERT_EQ(*Style2, getNoStyle()); - - // Test 2.3: format if config is found with no based style while fallback is - // 'none'. - ASSERT_TRUE(FS.addFile("/b/.clang-format", 0, - llvm::MemoryBuffer::getMemBuffer("IndentWidth: 2"))); - Style2 = getStyle("file", "/b/test.cpp", "none", "", &FS); - ASSERT_TRUE((bool)Style2); - ASSERT_EQ(*Style2, getLLVMStyle()); - - // Test 2.4: format if yaml with no based style, while fallback is 'none'. - Style2 = getStyle("{}", "a.h", "none", "", &FS); - ASSERT_TRUE((bool)Style2); - ASSERT_EQ(*Style2, getLLVMStyle()); - - // Test 3: format file in parent directory. - ASSERT_TRUE( - FS.addFile("/c/.clang-format", 0, - llvm::MemoryBuffer::getMemBuffer("BasedOnStyle: Google"))); - ASSERT_TRUE(FS.addFile("/c/sub/sub/sub/test.cpp", 0, - llvm::MemoryBuffer::getMemBuffer("int i;"))); - auto Style3 = getStyle("file", "/c/sub/sub/sub/test.cpp", "LLVM", "", &FS); - ASSERT_TRUE((bool)Style3); - ASSERT_EQ(*Style3, getGoogleStyle()); - - // Test 4: error on invalid fallback style - auto Style4 = getStyle("file", "a.h", "KungFu", "", &FS); - ASSERT_FALSE((bool)Style4); - llvm::consumeError(Style4.takeError()); - - // Test 5: error on invalid yaml on command line - auto Style5 = getStyle("{invalid_key=invalid_value}", "a.h", "LLVM", "", &FS); - ASSERT_FALSE((bool)Style5); - llvm::consumeError(Style5.takeError()); - - // Test 6: error on invalid style - auto Style6 = getStyle("KungFu", "a.h", "LLVM", "", &FS); - ASSERT_FALSE((bool)Style6); - llvm::consumeError(Style6.takeError()); - - // Test 7: found config file, error on parsing it - ASSERT_TRUE( - FS.addFile("/d/.clang-format", 0, - llvm::MemoryBuffer::getMemBuffer("BasedOnStyle: LLVM\n" - "InvalidKey: InvalidValue"))); - ASSERT_TRUE( - FS.addFile("/d/test.cpp", 0, llvm::MemoryBuffer::getMemBuffer("int i;"))); - auto Style7 = getStyle("file", "/d/.clang-format", "LLVM", "", &FS); - ASSERT_FALSE((bool)Style7); - llvm::consumeError(Style7.takeError()); -} - -TEST_F(ReplacementTest, FormatCodeAfterReplacements) { - // Column limit is 20. - std::string Code = "Type *a =\n" - " new Type();\n" - "g(iiiii, 0, jjjjj,\n" - " 0, kkkkk, 0, mm);\n" - "int bad = format ;"; - std::string Expected = "auto a = new Type();\n" - "g(iiiii, nullptr,\n" - " jjjjj, nullptr,\n" - " kkkkk, nullptr,\n" - " mm);\n" - "int bad = format ;"; - FileID ID = Context.createInMemoryFile("format.cpp", Code); - tooling::Replacements Replaces = toReplacements( - {tooling::Replacement(Context.Sources, Context.getLocation(ID, 1, 1), 6, - "auto "), - tooling::Replacement(Context.Sources, Context.getLocation(ID, 3, 10), 1, - "nullptr"), - tooling::Replacement(Context.Sources, Context.getLocation(ID, 4, 3), 1, - "nullptr"), - tooling::Replacement(Context.Sources, Context.getLocation(ID, 4, 13), 1, - "nullptr")}); - - format::FormatStyle Style = format::getLLVMStyle(); - Style.ColumnLimit = 20; // Set column limit to 20 to increase readibility. - auto FormattedReplaces = formatReplacements(Code, Replaces, Style); - EXPECT_TRUE(static_cast<bool>(FormattedReplaces)) - << llvm::toString(FormattedReplaces.takeError()) << "\n"; - auto Result = applyAllReplacements(Code, *FormattedReplaces); - EXPECT_TRUE(static_cast<bool>(Result)); - EXPECT_EQ(Expected, *Result); -} - -TEST_F(ReplacementTest, SortIncludesAfterReplacement) { - std::string Code = "#include \"a.h\"\n" - "#include \"c.h\"\n" - "\n" - "int main() {\n" - " return 0;\n" - "}"; - std::string Expected = "#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n" - "\n" - "int main() {\n" - " return 0;\n" - "}"; - FileID ID = Context.createInMemoryFile("fix.cpp", Code); - tooling::Replacements Replaces = toReplacements( - {tooling::Replacement(Context.Sources, Context.getLocation(ID, 1, 1), 0, - "#include \"b.h\"\n")}); - - format::FormatStyle Style = format::getLLVMStyle(); - Style.SortIncludes = true; - auto FormattedReplaces = formatReplacements(Code, Replaces, Style); - EXPECT_TRUE(static_cast<bool>(FormattedReplaces)) - << llvm::toString(FormattedReplaces.takeError()) << "\n"; - auto Result = applyAllReplacements(Code, *FormattedReplaces); - EXPECT_TRUE(static_cast<bool>(Result)); - EXPECT_EQ(Expected, *Result); -} - -TEST_F(FormatTest, FormatSortsUsingDeclarations) { - EXPECT_EQ("using std::cin;\n" - "using std::cout;", - format("using std::cout;\n" - "using std::cin;", getGoogleStyle())); -} - -TEST_F(FormatTest, UTF8CharacterLiteralCpp03) { - format::FormatStyle Style = format::getLLVMStyle(); - Style.Standard = FormatStyle::LS_Cpp03; - // cpp03 recognize this string as identifier u8 and literal character 'a' - EXPECT_EQ("auto c = u8 'a';", format("auto c = u8'a';", Style)); -} - -TEST_F(FormatTest, UTF8CharacterLiteralCpp11) { - // u8'a' is a C++17 feature, utf8 literal character, LS_Cpp11 covers - // all modes, including C++11, C++14 and C++17 - EXPECT_EQ("auto c = u8'a';", format("auto c = u8'a';")); -} - -TEST_F(FormatTest, DoNotFormatLikelyXml) { - EXPECT_EQ("<!-- ;> -->", - format("<!-- ;> -->", getGoogleStyle())); - EXPECT_EQ(" <!-- >; -->", - format(" <!-- >; -->", getGoogleStyle())); -} - -TEST_F(FormatTest, StructuredBindings) { - // Structured bindings is a C++17 feature. - // all modes, including C++11, C++14 and C++17 - verifyFormat("auto [a, b] = f();"); - EXPECT_EQ("auto [a, b] = f();", format("auto[a, b] = f();")); - EXPECT_EQ("const auto [a, b] = f();", format("const auto[a, b] = f();")); - EXPECT_EQ("auto const [a, b] = f();", format("auto const[a, b] = f();")); - EXPECT_EQ("auto const volatile [a, b] = f();", - format("auto const volatile[a, b] = f();")); - EXPECT_EQ("auto [a, b, c] = f();", format("auto [ a , b,c ] = f();")); - EXPECT_EQ("auto &[a, b, c] = f();", - format("auto &[ a , b,c ] = f();")); - EXPECT_EQ("auto &&[a, b, c] = f();", - format("auto &&[ a , b,c ] = f();")); - EXPECT_EQ("auto const &[a, b] = f();", format("auto const&[a, b] = f();")); - EXPECT_EQ("auto const volatile &&[a, b] = f();", - format("auto const volatile &&[a, b] = f();")); - EXPECT_EQ("auto const &&[a, b] = f();", format("auto const && [a, b] = f();")); - EXPECT_EQ("const auto &[a, b] = f();", format("const auto & [a, b] = f();")); - EXPECT_EQ("const auto volatile &&[a, b] = f();", - format("const auto volatile &&[a, b] = f();")); - EXPECT_EQ("volatile const auto &&[a, b] = f();", - format("volatile const auto &&[a, b] = f();")); - EXPECT_EQ("const auto &&[a, b] = f();", format("const auto && [a, b] = f();")); - - // Make sure we don't mistake structured bindings for lambdas. - FormatStyle PointerMiddle = getLLVMStyle(); - PointerMiddle.PointerAlignment = FormatStyle::PAS_Middle; - verifyFormat("auto [a1, b]{A * i};", getGoogleStyle()); - verifyFormat("auto [a2, b]{A * i};", getLLVMStyle()); - verifyFormat("auto [a3, b]{A * i};", PointerMiddle); - verifyFormat("auto const [a1, b]{A * i};", getGoogleStyle()); - verifyFormat("auto const [a2, b]{A * i};", getLLVMStyle()); - verifyFormat("auto const [a3, b]{A * i};", PointerMiddle); - verifyFormat("auto const& [a1, b]{A * i};", getGoogleStyle()); - verifyFormat("auto const &[a2, b]{A * i};", getLLVMStyle()); - verifyFormat("auto const & [a3, b]{A * i};", PointerMiddle); - verifyFormat("auto const&& [a1, b]{A * i};", getGoogleStyle()); - verifyFormat("auto const &&[a2, b]{A * i};", getLLVMStyle()); - verifyFormat("auto const && [a3, b]{A * i};", PointerMiddle); - - EXPECT_EQ("for (const auto &&[a, b] : some_range) {\n}", - format("for (const auto && [a, b] : some_range) {\n}")); - EXPECT_EQ("for (const auto &[a, b] : some_range) {\n}", - format("for (const auto & [a, b] : some_range) {\n}")); - EXPECT_EQ("for (const auto [a, b] : some_range) {\n}", - format("for (const auto[a, b] : some_range) {\n}")); - EXPECT_EQ("auto [x, y](expr);", format("auto[x,y] (expr);")); - EXPECT_EQ("auto &[x, y](expr);", format("auto & [x,y] (expr);")); - EXPECT_EQ("auto &&[x, y](expr);", format("auto && [x,y] (expr);")); - EXPECT_EQ("auto const &[x, y](expr);", format("auto const & [x,y] (expr);")); - EXPECT_EQ("auto const &&[x, y](expr);", format("auto const && [x,y] (expr);")); - EXPECT_EQ("auto [x, y]{expr};", format("auto[x,y] {expr};")); - EXPECT_EQ("auto const &[x, y]{expr};", format("auto const & [x,y] {expr};")); - EXPECT_EQ("auto const &&[x, y]{expr};", format("auto const && [x,y] {expr};")); - - format::FormatStyle Spaces = format::getLLVMStyle(); - Spaces.SpacesInSquareBrackets = true; - verifyFormat("auto [ a, b ] = f();", Spaces); - verifyFormat("auto &&[ a, b ] = f();", Spaces); - verifyFormat("auto &[ a, b ] = f();", Spaces); - verifyFormat("auto const &&[ a, b ] = f();", Spaces); - verifyFormat("auto const &[ a, b ] = f();", Spaces); -} - -TEST_F(FormatTest, FileAndCode) { - EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo.cc", "")); - EXPECT_EQ(FormatStyle::LK_ObjC, guessLanguage("foo.m", "")); - EXPECT_EQ(FormatStyle::LK_ObjC, guessLanguage("foo.mm", "")); - EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo.h", "")); - EXPECT_EQ(FormatStyle::LK_ObjC, guessLanguage("foo.h", "@interface Foo\n@end\n")); - EXPECT_EQ( - FormatStyle::LK_ObjC, - guessLanguage("foo.h", "#define TRY(x, y) @try { x; } @finally { y; }")); - EXPECT_EQ(FormatStyle::LK_ObjC, - guessLanguage("foo.h", "#define AVAIL(x) @available(x, *))")); - EXPECT_EQ(FormatStyle::LK_ObjC, guessLanguage("foo.h", "@class Foo;")); - EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo", "")); - EXPECT_EQ(FormatStyle::LK_ObjC, guessLanguage("foo", "@interface Foo\n@end\n")); - EXPECT_EQ(FormatStyle::LK_ObjC, - guessLanguage("foo.h", "int DoStuff(CGRect rect);\n")); - EXPECT_EQ( - FormatStyle::LK_ObjC, - guessLanguage("foo.h", - "#define MY_POINT_MAKE(x, y) CGPointMake((x), (y));\n")); - EXPECT_EQ( - FormatStyle::LK_Cpp, - guessLanguage("foo.h", "#define FOO(...) auto bar = [] __VA_ARGS__;")); -} - -TEST_F(FormatTest, GuessLanguageWithCpp11AttributeSpecifiers) { - EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo.h", "[[noreturn]];")); - EXPECT_EQ(FormatStyle::LK_ObjC, - guessLanguage("foo.h", "array[[calculator getIndex]];")); - EXPECT_EQ(FormatStyle::LK_Cpp, - guessLanguage("foo.h", "[[noreturn, deprecated(\"so sorry\")]];")); - EXPECT_EQ( - FormatStyle::LK_Cpp, - guessLanguage("foo.h", "[[noreturn, deprecated(\"gone, sorry\")]];")); - EXPECT_EQ(FormatStyle::LK_ObjC, - guessLanguage("foo.h", "[[noreturn foo] bar];")); - EXPECT_EQ(FormatStyle::LK_Cpp, - guessLanguage("foo.h", "[[clang::fallthrough]];")); - EXPECT_EQ(FormatStyle::LK_ObjC, - guessLanguage("foo.h", "[[clang:fallthrough] foo];")); - EXPECT_EQ(FormatStyle::LK_Cpp, - guessLanguage("foo.h", "[[gsl::suppress(\"type\")]];")); - EXPECT_EQ(FormatStyle::LK_Cpp, - guessLanguage("foo.h", "[[using clang: fallthrough]];")); - EXPECT_EQ(FormatStyle::LK_ObjC, - guessLanguage("foo.h", "[[abusing clang:fallthrough] bar];")); - EXPECT_EQ(FormatStyle::LK_Cpp, - guessLanguage("foo.h", "[[using gsl: suppress(\"type\")]];")); - EXPECT_EQ( - FormatStyle::LK_Cpp, - guessLanguage("foo.h", - "[[clang::callable_when(\"unconsumed\", \"unknown\")]]")); - EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo.h", "[[foo::bar, ...]]")); -} - -TEST_F(FormatTest, GuessLanguageWithCaret) { - EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo.h", "FOO(^);")); - EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo.h", "FOO(^, Bar);")); - EXPECT_EQ(FormatStyle::LK_ObjC, - guessLanguage("foo.h", "int(^)(char, float);")); - EXPECT_EQ(FormatStyle::LK_ObjC, - guessLanguage("foo.h", "int(^foo)(char, float);")); - EXPECT_EQ(FormatStyle::LK_ObjC, - guessLanguage("foo.h", "int(^foo[10])(char, float);")); - EXPECT_EQ(FormatStyle::LK_ObjC, - guessLanguage("foo.h", "int(^foo[kNumEntries])(char, float);")); - EXPECT_EQ( - FormatStyle::LK_ObjC, - guessLanguage("foo.h", "int(^foo[(kNumEntries + 10)])(char, float);")); -} - -TEST_F(FormatTest, GuessedLanguageWithInlineAsmClobbers) { - EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo.h", - "void f() {\n" - " asm (\"mov %[e], %[d]\"\n" - " : [d] \"=rm\" (d)\n" - " [e] \"rm\" (*e));\n" - "}")); - EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo.h", - "void f() {\n" - " _asm (\"mov %[e], %[d]\"\n" - " : [d] \"=rm\" (d)\n" - " [e] \"rm\" (*e));\n" - "}")); - EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo.h", - "void f() {\n" - " __asm (\"mov %[e], %[d]\"\n" - " : [d] \"=rm\" (d)\n" - " [e] \"rm\" (*e));\n" - "}")); - EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo.h", - "void f() {\n" - " __asm__ (\"mov %[e], %[d]\"\n" - " : [d] \"=rm\" (d)\n" - " [e] \"rm\" (*e));\n" - "}")); - EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo.h", - "void f() {\n" - " asm (\"mov %[e], %[d]\"\n" - " : [d] \"=rm\" (d),\n" - " [e] \"rm\" (*e));\n" - "}")); - EXPECT_EQ(FormatStyle::LK_Cpp, - guessLanguage("foo.h", "void f() {\n" - " asm volatile (\"mov %[e], %[d]\"\n" - " : [d] \"=rm\" (d)\n" - " [e] \"rm\" (*e));\n" - "}")); -} - -TEST_F(FormatTest, GuessLanguageWithChildLines) { - EXPECT_EQ(FormatStyle::LK_Cpp, - guessLanguage("foo.h", "#define FOO ({ std::string s; })")); - EXPECT_EQ(FormatStyle::LK_ObjC, - guessLanguage("foo.h", "#define FOO ({ NSString *s; })")); - EXPECT_EQ( - FormatStyle::LK_Cpp, - guessLanguage("foo.h", "#define FOO ({ foo(); ({ std::string s; }) })")); - EXPECT_EQ( - FormatStyle::LK_ObjC, - guessLanguage("foo.h", "#define FOO ({ foo(); ({ NSString *s; }) })")); -} - -} // end namespace -} // end namespace format -} // end namespace clang diff --git a/unittests/Format/FormatTestComments.cpp b/unittests/Format/FormatTestComments.cpp deleted file mode 100644 index 9f43677b70dfa..0000000000000 --- a/unittests/Format/FormatTestComments.cpp +++ /dev/null @@ -1,3216 +0,0 @@ -//===- unittest/Format/FormatTestComments.cpp - Formatting unit tests -----===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "clang/Format/Format.h" - -#include "../Tooling/ReplacementTest.h" -#include "FormatTestUtils.h" - -#include "clang/Frontend/TextDiagnosticPrinter.h" -#include "llvm/Support/Debug.h" -#include "llvm/Support/MemoryBuffer.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -using clang::tooling::ReplacementTest; - -namespace clang { -namespace format { -namespace { - -FormatStyle getGoogleStyle() { return getGoogleStyle(FormatStyle::LK_Cpp); } - -class FormatTestComments : public ::testing::Test { -protected: - enum StatusCheck { - SC_ExpectComplete, - SC_ExpectIncomplete, - SC_DoNotCheck - }; - - std::string format(llvm::StringRef Code, - const FormatStyle &Style = getLLVMStyle(), - StatusCheck CheckComplete = SC_ExpectComplete) { - LLVM_DEBUG(llvm::errs() << "---\n"); - LLVM_DEBUG(llvm::errs() << Code << "\n\n"); - std::vector<tooling::Range> Ranges(1, tooling::Range(0, Code.size())); - FormattingAttemptStatus Status; - tooling::Replacements Replaces = - reformat(Style, Code, Ranges, "<stdin>", &Status); - if (CheckComplete != SC_DoNotCheck) { - bool ExpectedCompleteFormat = CheckComplete == SC_ExpectComplete; - EXPECT_EQ(ExpectedCompleteFormat, Status.FormatComplete) - << Code << "\n\n"; - } - ReplacementCount = Replaces.size(); - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); - return *Result; - } - - FormatStyle getLLVMStyleWithColumns(unsigned ColumnLimit) { - FormatStyle Style = getLLVMStyle(); - Style.ColumnLimit = ColumnLimit; - return Style; - } - - FormatStyle getTextProtoStyleWithColumns(unsigned ColumnLimit) { - FormatStyle Style = getGoogleStyle(FormatStyle::FormatStyle::LK_TextProto); - Style.ColumnLimit = ColumnLimit; - return Style; - } - - void verifyFormat(llvm::StringRef Code, - const FormatStyle &Style = getLLVMStyle()) { - EXPECT_EQ(Code.str(), format(Code, Style)) << "Expected code is not stable"; - EXPECT_EQ(Code.str(), format(test::messUp(Code), Style)); - } - - void verifyGoogleFormat(llvm::StringRef Code) { - verifyFormat(Code, getGoogleStyle()); - } - - /// \brief Verify that clang-format does not crash on the given input. - void verifyNoCrash(llvm::StringRef Code, - const FormatStyle &Style = getLLVMStyle()) { - format(Code, Style, SC_DoNotCheck); - } - - int ReplacementCount; -}; - -//===----------------------------------------------------------------------===// -// Tests for comments. -//===----------------------------------------------------------------------===// - -TEST_F(FormatTestComments, UnderstandsSingleLineComments) { - verifyFormat("//* */"); - verifyFormat("// line 1\n" - "// line 2\n" - "void f() {}\n"); - - verifyFormat("void f() {\n" - " // Doesn't do anything\n" - "}"); - verifyFormat("SomeObject\n" - " // Calling someFunction on SomeObject\n" - " .someFunction();"); - verifyFormat("auto result = SomeObject\n" - " // Calling someFunction on SomeObject\n" - " .someFunction();"); - verifyFormat("void f(int i, // some comment (probably for i)\n" - " int j, // some comment (probably for j)\n" - " int k); // some comment (probably for k)"); - verifyFormat("void f(int i,\n" - " // some comment (probably for j)\n" - " int j,\n" - " // some comment (probably for k)\n" - " int k);"); - - verifyFormat("int i // This is a fancy variable\n" - " = 5; // with nicely aligned comment."); - - verifyFormat("// Leading comment.\n" - "int a; // Trailing comment."); - verifyFormat("int a; // Trailing comment\n" - " // on 2\n" - " // or 3 lines.\n" - "int b;"); - verifyFormat("int a; // Trailing comment\n" - "\n" - "// Leading comment.\n" - "int b;"); - verifyFormat("int a; // Comment.\n" - " // More details.\n" - "int bbbb; // Another comment."); - verifyFormat( - "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; // comment\n" - "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // comment\n" - "int cccccccccccccccccccccccccccccc; // comment\n" - "int ddd; // looooooooooooooooooooooooong comment\n" - "int aaaaaaaaaaaaaaaaaaaaaaa; // comment\n" - "int bbbbbbbbbbbbbbbbbbbbb; // comment\n" - "int ccccccccccccccccccc; // comment"); - - verifyFormat("#include \"a\" // comment\n" - "#include \"a/b/c\" // comment"); - verifyFormat("#include <a> // comment\n" - "#include <a/b/c> // comment"); - EXPECT_EQ("#include \"a\" // comment\n" - "#include \"a/b/c\" // comment", - format("#include \\\n" - " \"a\" // comment\n" - "#include \"a/b/c\" // comment")); - - verifyFormat("enum E {\n" - " // comment\n" - " VAL_A, // comment\n" - " VAL_B\n" - "};"); - - EXPECT_EQ("enum A {\n" - " // line a\n" - " a,\n" - " b, // line b\n" - "\n" - " // line c\n" - " c\n" - "};", - format("enum A {\n" - " // line a\n" - " a,\n" - " b, // line b\n" - "\n" - " // line c\n" - " c\n" - "};", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("enum A {\n" - " a, // line 1\n" - " // line 2\n" - "};", - format("enum A {\n" - " a, // line 1\n" - " // line 2\n" - "};", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("enum A {\n" - " a, // line 1\n" - " // line 2\n" - "};", - format("enum A {\n" - " a, // line 1\n" - " // line 2\n" - "};", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("enum A {\n" - " a, // line 1\n" - " // line 2\n" - " b\n" - "};", - format("enum A {\n" - " a, // line 1\n" - " // line 2\n" - " b\n" - "};", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("enum A {\n" - " a, // line 1\n" - " // line 2\n" - " b\n" - "};", - format("enum A {\n" - " a, // line 1\n" - " // line 2\n" - " b\n" - "};", - getLLVMStyleWithColumns(20))); - verifyFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // Trailing comment"); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " // Comment inside a statement.\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); - verifyFormat("SomeFunction(a,\n" - " // comment\n" - " b + x);"); - verifyFormat("SomeFunction(a, a,\n" - " // comment\n" - " b + x);"); - verifyFormat( - "bool aaaaaaaaaaaaa = // comment\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - - verifyFormat("int aaaa; // aaaaa\n" - "int aa; // aaaaaaa", - getLLVMStyleWithColumns(20)); - - EXPECT_EQ("void f() { // This does something ..\n" - "}\n" - "int a; // This is unrelated", - format("void f() { // This does something ..\n" - " }\n" - "int a; // This is unrelated")); - EXPECT_EQ("class C {\n" - " void f() { // This does something ..\n" - " } // awesome..\n" - "\n" - " int a; // This is unrelated\n" - "};", - format("class C{void f() { // This does something ..\n" - " } // awesome..\n" - " \n" - "int a; // This is unrelated\n" - "};")); - - EXPECT_EQ("int i; // single line trailing comment", - format("int i;\\\n// single line trailing comment")); - - verifyGoogleFormat("int a; // Trailing comment."); - - verifyFormat("someFunction(anotherFunction( // Force break.\n" - " parameter));"); - - verifyGoogleFormat("#endif // HEADER_GUARD"); - - verifyFormat("const char *test[] = {\n" - " // A\n" - " \"aaaa\",\n" - " // B\n" - " \"aaaaa\"};"); - verifyGoogleFormat( - "aaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaa); // 81_cols_with_this_comment"); - EXPECT_EQ("D(a, {\n" - " // test\n" - " int a;\n" - "});", - format("D(a, {\n" - "// test\n" - "int a;\n" - "});")); - - EXPECT_EQ("lineWith(); // comment\n" - "// at start\n" - "otherLine();", - format("lineWith(); // comment\n" - "// at start\n" - "otherLine();")); - EXPECT_EQ("lineWith(); // comment\n" - "/*\n" - " * at start */\n" - "otherLine();", - format("lineWith(); // comment\n" - "/*\n" - " * at start */\n" - "otherLine();")); - EXPECT_EQ("lineWith(); // comment\n" - " // at start\n" - "otherLine();", - format("lineWith(); // comment\n" - " // at start\n" - "otherLine();")); - - EXPECT_EQ("lineWith(); // comment\n" - "// at start\n" - "otherLine(); // comment", - format("lineWith(); // comment\n" - "// at start\n" - "otherLine(); // comment")); - EXPECT_EQ("lineWith();\n" - "// at start\n" - "otherLine(); // comment", - format("lineWith();\n" - " // at start\n" - "otherLine(); // comment")); - EXPECT_EQ("// first\n" - "// at start\n" - "otherLine(); // comment", - format("// first\n" - " // at start\n" - "otherLine(); // comment")); - EXPECT_EQ("f();\n" - "// first\n" - "// at start\n" - "otherLine(); // comment", - format("f();\n" - "// first\n" - " // at start\n" - "otherLine(); // comment")); - verifyFormat("f(); // comment\n" - "// first\n" - "// at start\n" - "otherLine();"); - EXPECT_EQ("f(); // comment\n" - "// first\n" - "// at start\n" - "otherLine();", - format("f(); // comment\n" - "// first\n" - " // at start\n" - "otherLine();")); - EXPECT_EQ("f(); // comment\n" - " // first\n" - "// at start\n" - "otherLine();", - format("f(); // comment\n" - " // first\n" - "// at start\n" - "otherLine();")); - EXPECT_EQ("void f() {\n" - " lineWith(); // comment\n" - " // at start\n" - "}", - format("void f() {\n" - " lineWith(); // comment\n" - " // at start\n" - "}")); - EXPECT_EQ("int xy; // a\n" - "int z; // b", - format("int xy; // a\n" - "int z; //b")); - EXPECT_EQ("int xy; // a\n" - "int z; // bb", - format("int xy; // a\n" - "int z; //bb", - getLLVMStyleWithColumns(12))); - - verifyFormat("#define A \\\n" - " int i; /* iiiiiiiiiiiiiiiiiiiii */ \\\n" - " int jjjjjjjjjjjjjjjjjjjjjjjj; /* */", - getLLVMStyleWithColumns(60)); - verifyFormat( - "#define A \\\n" - " int i; /* iiiiiiiiiiiiiiiiiiiii */ \\\n" - " int jjjjjjjjjjjjjjjjjjjjjjjj; /* */", - getLLVMStyleWithColumns(61)); - - verifyFormat("if ( // This is some comment\n" - " x + 3) {\n" - "}"); - EXPECT_EQ("if ( // This is some comment\n" - " // spanning two lines\n" - " x + 3) {\n" - "}", - format("if( // This is some comment\n" - " // spanning two lines\n" - " x + 3) {\n" - "}")); - - verifyNoCrash("/\\\n/"); - verifyNoCrash("/\\\n* */"); - // The 0-character somehow makes the lexer return a proper comment. - verifyNoCrash(StringRef("/*\\\0\n/", 6)); -} - -TEST_F(FormatTestComments, KeepsParameterWithTrailingCommentsOnTheirOwnLine) { - EXPECT_EQ("SomeFunction(a,\n" - " b, // comment\n" - " c);", - format("SomeFunction(a,\n" - " b, // comment\n" - " c);")); - EXPECT_EQ("SomeFunction(a, b,\n" - " // comment\n" - " c);", - format("SomeFunction(a,\n" - " b,\n" - " // comment\n" - " c);")); - EXPECT_EQ("SomeFunction(a, b, // comment (unclear relation)\n" - " c);", - format("SomeFunction(a, b, // comment (unclear relation)\n" - " c);")); - EXPECT_EQ("SomeFunction(a, // comment\n" - " b,\n" - " c); // comment", - format("SomeFunction(a, // comment\n" - " b,\n" - " c); // comment")); - EXPECT_EQ("aaaaaaaaaa(aaaa(aaaa,\n" - " aaaa), //\n" - " aaaa, bbbbb);", - format("aaaaaaaaaa(aaaa(aaaa,\n" - "aaaa), //\n" - "aaaa, bbbbb);")); -} - -TEST_F(FormatTestComments, RemovesTrailingWhitespaceOfComments) { - EXPECT_EQ("// comment", format("// comment ")); - EXPECT_EQ("int aaaaaaa, bbbbbbb; // comment", - format("int aaaaaaa, bbbbbbb; // comment ", - getLLVMStyleWithColumns(33))); - EXPECT_EQ("// comment\\\n", format("// comment\\\n \t \v \f ")); - EXPECT_EQ("// comment \\\n", format("// comment \\\n \t \v \f ")); -} - -TEST_F(FormatTestComments, UnderstandsBlockComments) { - verifyFormat("f(/*noSpaceAfterParameterNamingComment=*/true);"); - verifyFormat("void f() { g(/*aaa=*/x, /*bbb=*/!y, /*c=*/::c); }"); - EXPECT_EQ("f(aaaaaaaaaaaaaaaaaaaaaaaaa, /* Trailing comment for aa... */\n" - " bbbbbbbbbbbbbbbbbbbbbbbbb);", - format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \\\n" - "/* Trailing comment for aa... */\n" - " bbbbbbbbbbbbbbbbbbbbbbbbb);")); - EXPECT_EQ( - "f(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " /* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);", - format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \n" - "/* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);")); - EXPECT_EQ( - "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaa) { /*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*/\n" - "}", - format("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaa ,\n" - " aaaaaaaaaaaaaaaaaa) { /*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*/\n" - "}")); - verifyFormat("f(/* aaaaaaaaaaaaaaaaaa = */\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - - FormatStyle NoBinPacking = getLLVMStyle(); - NoBinPacking.BinPackParameters = false; - verifyFormat("aaaaaaaa(/* parameter 1 */ aaaaaa,\n" - " /* parameter 2 */ aaaaaa,\n" - " /* parameter 3 */ aaaaaa,\n" - " /* parameter 4 */ aaaaaa);", - NoBinPacking); - - // Aligning block comments in macros. - verifyGoogleFormat("#define A \\\n" - " int i; /*a*/ \\\n" - " int jjj; /*b*/"); -} - -TEST_F(FormatTestComments, AlignsBlockComments) { - EXPECT_EQ("/*\n" - " * Really multi-line\n" - " * comment.\n" - " */\n" - "void f() {}", - format(" /*\n" - " * Really multi-line\n" - " * comment.\n" - " */\n" - " void f() {}")); - EXPECT_EQ("class C {\n" - " /*\n" - " * Another multi-line\n" - " * comment.\n" - " */\n" - " void f() {}\n" - "};", - format("class C {\n" - "/*\n" - " * Another multi-line\n" - " * comment.\n" - " */\n" - "void f() {}\n" - "};")); - EXPECT_EQ("/*\n" - " 1. This is a comment with non-trivial formatting.\n" - " 1.1. We have to indent/outdent all lines equally\n" - " 1.1.1. to keep the formatting.\n" - " */", - format(" /*\n" - " 1. This is a comment with non-trivial formatting.\n" - " 1.1. We have to indent/outdent all lines equally\n" - " 1.1.1. to keep the formatting.\n" - " */")); - EXPECT_EQ("/*\n" - "Don't try to outdent if there's not enough indentation.\n" - "*/", - format(" /*\n" - " Don't try to outdent if there's not enough indentation.\n" - " */")); - - EXPECT_EQ("int i; /* Comment with empty...\n" - " *\n" - " * line. */", - format("int i; /* Comment with empty...\n" - " *\n" - " * line. */")); - EXPECT_EQ("int foobar = 0; /* comment */\n" - "int bar = 0; /* multiline\n" - " comment 1 */\n" - "int baz = 0; /* multiline\n" - " comment 2 */\n" - "int bzz = 0; /* multiline\n" - " comment 3 */", - format("int foobar = 0; /* comment */\n" - "int bar = 0; /* multiline\n" - " comment 1 */\n" - "int baz = 0; /* multiline\n" - " comment 2 */\n" - "int bzz = 0; /* multiline\n" - " comment 3 */")); - EXPECT_EQ("int foobar = 0; /* comment */\n" - "int bar = 0; /* multiline\n" - " comment */\n" - "int baz = 0; /* multiline\n" - "comment */", - format("int foobar = 0; /* comment */\n" - "int bar = 0; /* multiline\n" - "comment */\n" - "int baz = 0; /* multiline\n" - "comment */")); -} - -TEST_F(FormatTestComments, CommentReflowingCanBeTurnedOff) { - FormatStyle Style = getLLVMStyleWithColumns(20); - Style.ReflowComments = false; - verifyFormat("// aaaaaaaaa aaaaaaaaaa aaaaaaaaaa", Style); - verifyFormat("/* aaaaaaaaa aaaaaaaaaa aaaaaaaaaa */", Style); -} - -TEST_F(FormatTestComments, CorrectlyHandlesLengthOfBlockComments) { - EXPECT_EQ("double *x; /* aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa */", - format("double *x; /* aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa */")); - EXPECT_EQ( - "void ffffffffffff(\n" - " int aaaaaaaa, int bbbbbbbb,\n" - " int cccccccccccc) { /*\n" - " aaaaaaaaaa\n" - " aaaaaaaaaaaaa\n" - " bbbbbbbbbbbbbb\n" - " bbbbbbbbbb\n" - " */\n" - "}", - format("void ffffffffffff(int aaaaaaaa, int bbbbbbbb, int cccccccccccc)\n" - "{ /*\n" - " aaaaaaaaaa aaaaaaaaaaaaa\n" - " bbbbbbbbbbbbbb bbbbbbbbbb\n" - " */\n" - "}", - getLLVMStyleWithColumns(40))); -} - -TEST_F(FormatTestComments, DontBreakNonTrailingBlockComments) { - EXPECT_EQ("void ffffffffff(\n" - " int aaaaa /* test */);", - format("void ffffffffff(int aaaaa /* test */);", - getLLVMStyleWithColumns(35))); -} - -TEST_F(FormatTestComments, SplitsLongCxxComments) { - EXPECT_EQ("// A comment that\n" - "// doesn't fit on\n" - "// one line", - format("// A comment that doesn't fit on one line", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/// A comment that\n" - "/// doesn't fit on\n" - "/// one line", - format("/// A comment that doesn't fit on one line", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("//! A comment that\n" - "//! doesn't fit on\n" - "//! one line", - format("//! A comment that doesn't fit on one line", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("// a b c d\n" - "// e f g\n" - "// h i j k", - format("// a b c d e f g h i j k", getLLVMStyleWithColumns(10))); - EXPECT_EQ( - "// a b c d\n" - "// e f g\n" - "// h i j k", - format("\\\n// a b c d e f g h i j k", getLLVMStyleWithColumns(10))); - EXPECT_EQ("if (true) // A comment that\n" - " // doesn't fit on\n" - " // one line", - format("if (true) // A comment that doesn't fit on one line ", - getLLVMStyleWithColumns(30))); - EXPECT_EQ("// Don't_touch_leading_whitespace", - format("// Don't_touch_leading_whitespace", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("// Add leading\n" - "// whitespace", - format("//Add leading whitespace", getLLVMStyleWithColumns(20))); - EXPECT_EQ("/// Add leading\n" - "/// whitespace", - format("///Add leading whitespace", getLLVMStyleWithColumns(20))); - EXPECT_EQ("//! Add leading\n" - "//! whitespace", - format("//!Add leading whitespace", getLLVMStyleWithColumns(20))); - EXPECT_EQ("// whitespace", format("//whitespace", getLLVMStyle())); - EXPECT_EQ("// Even if it makes the line exceed the column\n" - "// limit", - format("//Even if it makes the line exceed the column limit", - getLLVMStyleWithColumns(51))); - EXPECT_EQ("//--But not here", format("//--But not here", getLLVMStyle())); - EXPECT_EQ("/// line 1\n" - "// add leading whitespace", - format("/// line 1\n" - "//add leading whitespace", - getLLVMStyleWithColumns(30))); - EXPECT_EQ("/// line 1\n" - "/// line 2\n" - "//! line 3\n" - "//! line 4\n" - "//! line 5\n" - "// line 6\n" - "// line 7", - format("///line 1\n" - "///line 2\n" - "//! line 3\n" - "//!line 4\n" - "//!line 5\n" - "// line 6\n" - "//line 7", getLLVMStyleWithColumns(20))); - - EXPECT_EQ("// aa bb cc dd", - format("// aa bb cc dd ", - getLLVMStyleWithColumns(15))); - - EXPECT_EQ("// A comment before\n" - "// a macro\n" - "// definition\n" - "#define a b", - format("// A comment before a macro definition\n" - "#define a b", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("void ffffff(\n" - " int aaaaaaaaa, // wwww\n" - " int bbbbbbbbbb, // xxxxxxx\n" - " // yyyyyyyyyy\n" - " int c, int d, int e) {}", - format("void ffffff(\n" - " int aaaaaaaaa, // wwww\n" - " int bbbbbbbbbb, // xxxxxxx yyyyyyyyyy\n" - " int c, int d, int e) {}", - getLLVMStyleWithColumns(40))); - EXPECT_EQ("//\t aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", - format("//\t aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", - getLLVMStyleWithColumns(20))); - EXPECT_EQ( - "#define XXX // a b c d\n" - " // e f g h", - format("#define XXX // a b c d e f g h", getLLVMStyleWithColumns(22))); - EXPECT_EQ( - "#define XXX // q w e r\n" - " // t y u i", - format("#define XXX //q w e r t y u i", getLLVMStyleWithColumns(22))); - EXPECT_EQ("{\n" - " //\n" - " //\\\n" - " // long 1 2 3 4 5\n" - "}", - format("{\n" - " //\n" - " //\\\n" - " // long 1 2 3 4 5\n" - "}", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("{\n" - " //\n" - " //\\\n" - " // long 1 2 3 4 5\n" - " // 6\n" - "}", - format("{\n" - " //\n" - " //\\\n" - " // long 1 2 3 4 5 6\n" - "}", - getLLVMStyleWithColumns(20))); -} - -TEST_F(FormatTestComments, PreservesHangingIndentInCxxComments) { - EXPECT_EQ("// A comment\n" - "// that doesn't\n" - "// fit on one\n" - "// line", - format("// A comment that doesn't fit on one line", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/// A comment\n" - "/// that doesn't\n" - "/// fit on one\n" - "/// line", - format("/// A comment that doesn't fit on one line", - getLLVMStyleWithColumns(20))); -} - -TEST_F(FormatTestComments, DontSplitLineCommentsWithEscapedNewlines) { - EXPECT_EQ("// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" - "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" - "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", - format("// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" - "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" - "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")); - EXPECT_EQ("int a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" - " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" - " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", - format("int a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" - " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" - " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", - getLLVMStyleWithColumns(50))); - // FIXME: One day we might want to implement adjustment of leading whitespace - // of the consecutive lines in this kind of comment: - EXPECT_EQ("double\n" - " a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" - " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" - " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", - format("double a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" - " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" - " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", - getLLVMStyleWithColumns(49))); -} - -TEST_F(FormatTestComments, DontSplitLineCommentsWithPragmas) { - FormatStyle Pragmas = getLLVMStyleWithColumns(30); - Pragmas.CommentPragmas = "^ IWYU pragma:"; - EXPECT_EQ( - "// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb", - format("// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb", Pragmas)); - EXPECT_EQ( - "/* IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb */", - format("/* IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb */", Pragmas)); -} - -TEST_F(FormatTestComments, PriorityOfCommentBreaking) { - EXPECT_EQ("if (xxx ==\n" - " yyy && // aaaaaaaaaaaa bbbbbbbbb\n" - " zzz)\n" - " q();", - format("if (xxx == yyy && // aaaaaaaaaaaa bbbbbbbbb\n" - " zzz) q();", - getLLVMStyleWithColumns(40))); - EXPECT_EQ("if (xxxxxxxxxx ==\n" - " yyy && // aaaaaa bbbbbbbb cccc\n" - " zzz)\n" - " q();", - format("if (xxxxxxxxxx == yyy && // aaaaaa bbbbbbbb cccc\n" - " zzz) q();", - getLLVMStyleWithColumns(40))); - EXPECT_EQ("if (xxxxxxxxxx &&\n" - " yyy || // aaaaaa bbbbbbbb cccc\n" - " zzz)\n" - " q();", - format("if (xxxxxxxxxx && yyy || // aaaaaa bbbbbbbb cccc\n" - " zzz) q();", - getLLVMStyleWithColumns(40))); - EXPECT_EQ("fffffffff(\n" - " &xxx, // aaaaaaaaaaaa bbbbbbbbbbb\n" - " zzz);", - format("fffffffff(&xxx, // aaaaaaaaaaaa bbbbbbbbbbb\n" - " zzz);", - getLLVMStyleWithColumns(40))); -} - -TEST_F(FormatTestComments, MultiLineCommentsInDefines) { - EXPECT_EQ("#define A(x) /* \\\n" - " a comment \\\n" - " inside */ \\\n" - " f();", - format("#define A(x) /* \\\n" - " a comment \\\n" - " inside */ \\\n" - " f();", - getLLVMStyleWithColumns(17))); - EXPECT_EQ("#define A( \\\n" - " x) /* \\\n" - " a comment \\\n" - " inside */ \\\n" - " f();", - format("#define A( \\\n" - " x) /* \\\n" - " a comment \\\n" - " inside */ \\\n" - " f();", - getLLVMStyleWithColumns(17))); -} - -TEST_F(FormatTestComments, ParsesCommentsAdjacentToPPDirectives) { - EXPECT_EQ("namespace {}\n// Test\n#define A", - format("namespace {}\n // Test\n#define A")); - EXPECT_EQ("namespace {}\n/* Test */\n#define A", - format("namespace {}\n /* Test */\n#define A")); - EXPECT_EQ("namespace {}\n/* Test */ #define A", - format("namespace {}\n /* Test */ #define A")); -} - -TEST_F(FormatTestComments, KeepsLevelOfCommentBeforePPDirective) { - // Keep the current level if the comment was originally not aligned with - // the preprocessor directive. - EXPECT_EQ("void f() {\n" - " int i;\n" - " /* comment */\n" - "#ifdef A\n" - " int j;\n" - "}", - format("void f() {\n" - " int i;\n" - " /* comment */\n" - "#ifdef A\n" - " int j;\n" - "}")); - - EXPECT_EQ("void f() {\n" - " int i;\n" - " /* comment */\n" - "\n" - "#ifdef A\n" - " int j;\n" - "}", - format("void f() {\n" - " int i;\n" - " /* comment */\n" - "\n" - "#ifdef A\n" - " int j;\n" - "}")); - - EXPECT_EQ("int f(int i) {\n" - " if (true) {\n" - " ++i;\n" - " }\n" - " // comment\n" - "#ifdef A\n" - " int j;\n" - "#endif\n" - "}", - format("int f(int i) {\n" - " if (true) {\n" - " ++i;\n" - " }\n" - " // comment\n" - "#ifdef A\n" - "int j;\n" - "#endif\n" - "}")); - - EXPECT_EQ("int f(int i) {\n" - " if (true) {\n" - " i++;\n" - " } else {\n" - " // comment in else\n" - "#ifdef A\n" - " j++;\n" - "#endif\n" - " }\n" - "}", - format("int f(int i) {\n" - " if (true) {\n" - " i++;\n" - " } else {\n" - " // comment in else\n" - "#ifdef A\n" - " j++;\n" - "#endif\n" - " }\n" - "}")); - - EXPECT_EQ("int f(int i) {\n" - " if (true) {\n" - " i++;\n" - " } else {\n" - " /* comment in else */\n" - "#ifdef A\n" - " j++;\n" - "#endif\n" - " }\n" - "}", - format("int f(int i) {\n" - " if (true) {\n" - " i++;\n" - " } else {\n" - " /* comment in else */\n" - "#ifdef A\n" - " j++;\n" - "#endif\n" - " }\n" - "}")); - - // Keep the current level if there is an empty line between the comment and - // the preprocessor directive. - EXPECT_EQ("void f() {\n" - " int i;\n" - " /* comment */\n" - "\n" - "#ifdef A\n" - " int j;\n" - "}", - format("void f() {\n" - " int i;\n" - "/* comment */\n" - "\n" - "#ifdef A\n" - " int j;\n" - "}")); - - EXPECT_EQ("void f() {\n" - " int i;\n" - " return i;\n" - "}\n" - "// comment\n" - "\n" - "#ifdef A\n" - "int i;\n" - "#endif // A", - format("void f() {\n" - " int i;\n" - " return i;\n" - "}\n" - "// comment\n" - "\n" - "#ifdef A\n" - "int i;\n" - "#endif // A")); - - EXPECT_EQ("int f(int i) {\n" - " if (true) {\n" - " ++i;\n" - " }\n" - " // comment\n" - "\n" - "#ifdef A\n" - " int j;\n" - "#endif\n" - "}", - format("int f(int i) {\n" - " if (true) {\n" - " ++i;\n" - " }\n" - " // comment\n" - "\n" - "#ifdef A\n" - " int j;\n" - "#endif\n" - "}")); - - EXPECT_EQ("int f(int i) {\n" - " if (true) {\n" - " i++;\n" - " } else {\n" - " // comment in else\n" - "\n" - "#ifdef A\n" - " j++;\n" - "#endif\n" - " }\n" - "}", - format("int f(int i) {\n" - " if (true) {\n" - " i++;\n" - " } else {\n" - "// comment in else\n" - "\n" - "#ifdef A\n" - " j++;\n" - "#endif\n" - " }\n" - "}")); - - EXPECT_EQ("int f(int i) {\n" - " if (true) {\n" - " i++;\n" - " } else {\n" - " /* comment in else */\n" - "\n" - "#ifdef A\n" - " j++;\n" - "#endif\n" - " }\n" - "}", - format("int f(int i) {\n" - " if (true) {\n" - " i++;\n" - " } else {\n" - "/* comment in else */\n" - "\n" - "#ifdef A\n" - " j++;\n" - "#endif\n" - " }\n" - "}")); - - // Align with the preprocessor directive if the comment was originally aligned - // with the preprocessor directive and there is no newline between the comment - // and the preprocessor directive. - EXPECT_EQ("void f() {\n" - " int i;\n" - "/* comment */\n" - "#ifdef A\n" - " int j;\n" - "}", - format("void f() {\n" - " int i;\n" - "/* comment */\n" - "#ifdef A\n" - " int j;\n" - "}")); - - EXPECT_EQ("int f(int i) {\n" - " if (true) {\n" - " ++i;\n" - " }\n" - "// comment\n" - "#ifdef A\n" - " int j;\n" - "#endif\n" - "}", - format("int f(int i) {\n" - " if (true) {\n" - " ++i;\n" - " }\n" - "// comment\n" - "#ifdef A\n" - " int j;\n" - "#endif\n" - "}")); - - EXPECT_EQ("int f(int i) {\n" - " if (true) {\n" - " i++;\n" - " } else {\n" - "// comment in else\n" - "#ifdef A\n" - " j++;\n" - "#endif\n" - " }\n" - "}", - format("int f(int i) {\n" - " if (true) {\n" - " i++;\n" - " } else {\n" - " // comment in else\n" - " #ifdef A\n" - " j++;\n" - "#endif\n" - " }\n" - "}")); - - EXPECT_EQ("int f(int i) {\n" - " if (true) {\n" - " i++;\n" - " } else {\n" - "/* comment in else */\n" - "#ifdef A\n" - " j++;\n" - "#endif\n" - " }\n" - "}", - format("int f(int i) {\n" - " if (true) {\n" - " i++;\n" - " } else {\n" - " /* comment in else */\n" - " #ifdef A\n" - " j++;\n" - "#endif\n" - " }\n" - "}")); -} - -TEST_F(FormatTestComments, SplitsLongLinesInComments) { - // FIXME: Do we need to fix up the " */" at the end? - // It doesn't look like any of our current logic triggers this. - EXPECT_EQ("/* This is a long\n" - " * comment that\n" - " * doesn't fit on\n" - " * one line. */", - format("/* " - "This is a long " - "comment that " - "doesn't " - "fit on one line. */", - getLLVMStyleWithColumns(20))); - EXPECT_EQ( - "/* a b c d\n" - " * e f g\n" - " * h i j k\n" - " */", - format("/* a b c d e f g h i j k */", getLLVMStyleWithColumns(10))); - EXPECT_EQ( - "/* a b c d\n" - " * e f g\n" - " * h i j k\n" - " */", - format("\\\n/* a b c d e f g h i j k */", getLLVMStyleWithColumns(10))); - EXPECT_EQ("/*\n" - "This is a long\n" - "comment that doesn't\n" - "fit on one line.\n" - "*/", - format("/*\n" - "This is a long " - "comment that doesn't " - "fit on one line. \n" - "*/", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/*\n" - " * This is a long\n" - " * comment that\n" - " * doesn't fit on\n" - " * one line.\n" - " */", - format("/* \n" - " * This is a long " - " comment that " - " doesn't fit on " - " one line. \n" - " */", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/*\n" - " * This_is_a_comment_with_words_that_dont_fit_on_one_line\n" - " * so_it_should_be_broken\n" - " * wherever_a_space_occurs\n" - " */", - format("/*\n" - " * This_is_a_comment_with_words_that_dont_fit_on_one_line " - " so_it_should_be_broken " - " wherever_a_space_occurs \n" - " */", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/*\n" - " * This_comment_can_not_be_broken_into_lines\n" - " */", - format("/*\n" - " * This_comment_can_not_be_broken_into_lines\n" - " */", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("{\n" - " /*\n" - " This is another\n" - " long comment that\n" - " doesn't fit on one\n" - " line 1234567890\n" - " */\n" - "}", - format("{\n" - "/*\n" - "This is another " - " long comment that " - " doesn't fit on one" - " line 1234567890\n" - "*/\n" - "}", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("{\n" - " /*\n" - " * This i s\n" - " * another comment\n" - " * t hat doesn' t\n" - " * fit on one l i\n" - " * n e\n" - " */\n" - "}", - format("{\n" - "/*\n" - " * This i s" - " another comment" - " t hat doesn' t" - " fit on one l i" - " n e\n" - " */\n" - "}", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/*\n" - " * This is a long\n" - " * comment that\n" - " * doesn't fit on\n" - " * one line\n" - " */", - format(" /*\n" - " * This is a long comment that doesn't fit on one line\n" - " */", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("{\n" - " if (something) /* This is a\n" - " long\n" - " comment */\n" - " ;\n" - "}", - format("{\n" - " if (something) /* This is a long comment */\n" - " ;\n" - "}", - getLLVMStyleWithColumns(30))); - - EXPECT_EQ("/* A comment before\n" - " * a macro\n" - " * definition */\n" - "#define a b", - format("/* A comment before a macro definition */\n" - "#define a b", - getLLVMStyleWithColumns(20))); - - EXPECT_EQ("/* some comment\n" - " * a comment that\n" - " * we break another\n" - " * comment we have\n" - " * to break a left\n" - " * comment\n" - " */", - format(" /* some comment\n" - " * a comment that we break\n" - " * another comment we have to break\n" - "* a left comment\n" - " */", - getLLVMStyleWithColumns(20))); - - EXPECT_EQ("/**\n" - " * multiline block\n" - " * comment\n" - " *\n" - " */", - format("/**\n" - " * multiline block comment\n" - " *\n" - " */", - getLLVMStyleWithColumns(20))); - - // This reproduces a crashing bug where both adaptStartOfLine and - // getCommentSplit were trying to wrap after the "/**". - EXPECT_EQ("/** multilineblockcommentwithnowrapopportunity */", - format("/** multilineblockcommentwithnowrapopportunity */", - getLLVMStyleWithColumns(20))); - - EXPECT_EQ("/*\n" - "\n" - "\n" - " */\n", - format(" /* \n" - " \n" - " \n" - " */\n")); - - EXPECT_EQ("/* a a */", - format("/* a a */", getLLVMStyleWithColumns(15))); - EXPECT_EQ("/* a a bc */", - format("/* a a bc */", getLLVMStyleWithColumns(15))); - EXPECT_EQ("/* aaa aaa\n" - " * aaaaa */", - format("/* aaa aaa aaaaa */", getLLVMStyleWithColumns(15))); - EXPECT_EQ("/* aaa aaa\n" - " * aaaaa */", - format("/* aaa aaa aaaaa */", getLLVMStyleWithColumns(15))); -} - -TEST_F(FormatTestComments, SplitsLongLinesInCommentsInPreprocessor) { - EXPECT_EQ("#define X \\\n" - " /* \\\n" - " Test \\\n" - " Macro comment \\\n" - " with a long \\\n" - " line \\\n" - " */ \\\n" - " A + B", - format("#define X \\\n" - " /*\n" - " Test\n" - " Macro comment with a long line\n" - " */ \\\n" - " A + B", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("#define X \\\n" - " /* Macro comment \\\n" - " with a long \\\n" - " line */ \\\n" - " A + B", - format("#define X \\\n" - " /* Macro comment with a long\n" - " line */ \\\n" - " A + B", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("#define X \\\n" - " /* Macro comment \\\n" - " * with a long \\\n" - " * line */ \\\n" - " A + B", - format("#define X \\\n" - " /* Macro comment with a long line */ \\\n" - " A + B", - getLLVMStyleWithColumns(20))); -} - -TEST_F(FormatTestComments, KeepsTrailingPPCommentsAndSectionCommentsSeparate) { - verifyFormat("#ifdef A // line about A\n" - "// section comment\n" - "#endif", - getLLVMStyleWithColumns(80)); - verifyFormat("#ifdef A // line 1 about A\n" - " // line 2 about A\n" - "// section comment\n" - "#endif", - getLLVMStyleWithColumns(80)); - EXPECT_EQ("#ifdef A // line 1 about A\n" - " // line 2 about A\n" - "// section comment\n" - "#endif", - format("#ifdef A // line 1 about A\n" - " // line 2 about A\n" - "// section comment\n" - "#endif", - getLLVMStyleWithColumns(80))); - verifyFormat("int f() {\n" - " int i;\n" - "#ifdef A // comment about A\n" - " // section comment 1\n" - " // section comment 2\n" - " i = 2;\n" - "#else // comment about #else\n" - " // section comment 3\n" - " i = 4;\n" - "#endif\n" - "}", getLLVMStyleWithColumns(80)); -} - -TEST_F(FormatTestComments, AlignsPPElseEndifComments) { - verifyFormat("#if A\n" - "#else // A\n" - "int iiii;\n" - "#endif // B", - getLLVMStyleWithColumns(20)); - verifyFormat("#if A\n" - "#else // A\n" - "int iiii; // CC\n" - "#endif // B", - getLLVMStyleWithColumns(20)); - EXPECT_EQ("#if A\n" - "#else // A1\n" - " // A2\n" - "int ii;\n" - "#endif // B", - format("#if A\n" - "#else // A1\n" - " // A2\n" - "int ii;\n" - "#endif // B", - getLLVMStyleWithColumns(20))); -} - -TEST_F(FormatTestComments, CommentsInStaticInitializers) { - EXPECT_EQ( - "static SomeType type = {aaaaaaaaaaaaaaaaaaaa, /* comment */\n" - " aaaaaaaaaaaaaaaaaaaa /* comment */,\n" - " /* comment */ aaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaa, // comment\n" - " aaaaaaaaaaaaaaaaaaaa};", - format("static SomeType type = { aaaaaaaaaaaaaaaaaaaa , /* comment */\n" - " aaaaaaaaaaaaaaaaaaaa /* comment */ ,\n" - " /* comment */ aaaaaaaaaaaaaaaaaaaa ,\n" - " aaaaaaaaaaaaaaaaaaaa , // comment\n" - " aaaaaaaaaaaaaaaaaaaa };")); - verifyFormat("static SomeType type = {aaaaaaaaaaa, // comment for aa...\n" - " bbbbbbbbbbb, ccccccccccc};"); - verifyFormat("static SomeType type = {aaaaaaaaaaa,\n" - " // comment for bb....\n" - " bbbbbbbbbbb, ccccccccccc};"); - verifyGoogleFormat( - "static SomeType type = {aaaaaaaaaaa, // comment for aa...\n" - " bbbbbbbbbbb, ccccccccccc};"); - verifyGoogleFormat("static SomeType type = {aaaaaaaaaaa,\n" - " // comment for bb....\n" - " bbbbbbbbbbb, ccccccccccc};"); - - verifyFormat("S s = {{a, b, c}, // Group #1\n" - " {d, e, f}, // Group #2\n" - " {g, h, i}}; // Group #3"); - verifyFormat("S s = {{// Group #1\n" - " a, b, c},\n" - " {// Group #2\n" - " d, e, f},\n" - " {// Group #3\n" - " g, h, i}};"); - - EXPECT_EQ("S s = {\n" - " // Some comment\n" - " a,\n" - "\n" - " // Comment after empty line\n" - " b}", - format("S s = {\n" - " // Some comment\n" - " a,\n" - " \n" - " // Comment after empty line\n" - " b\n" - "}")); - EXPECT_EQ("S s = {\n" - " /* Some comment */\n" - " a,\n" - "\n" - " /* Comment after empty line */\n" - " b}", - format("S s = {\n" - " /* Some comment */\n" - " a,\n" - " \n" - " /* Comment after empty line */\n" - " b\n" - "}")); - verifyFormat("const uint8_t aaaaaaaaaaaaaaaaaaaaaa[0] = {\n" - " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" - " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" - " 0x00, 0x00, 0x00, 0x00}; // comment\n"); -} - -TEST_F(FormatTestComments, LineCommentsAfterRightBrace) { - EXPECT_EQ("if (true) { // comment about branch\n" - " // comment about f\n" - " f();\n" - "}", - format("if (true) { // comment about branch\n" - " // comment about f\n" - " f();\n" - "}", - getLLVMStyleWithColumns(80))); - EXPECT_EQ("if (1) { // if line 1\n" - " // if line 2\n" - " // if line 3\n" - " // f line 1\n" - " // f line 2\n" - " f();\n" - "} else { // else line 1\n" - " // else line 2\n" - " // else line 3\n" - " // g line 1\n" - " g();\n" - "}", - format("if (1) { // if line 1\n" - " // if line 2\n" - " // if line 3\n" - " // f line 1\n" - " // f line 2\n" - " f();\n" - "} else { // else line 1\n" - " // else line 2\n" - " // else line 3\n" - " // g line 1\n" - " g();\n" - "}")); - EXPECT_EQ("do { // line 1\n" - " // line 2\n" - " // line 3\n" - " f();\n" - "} while (true);", - format("do { // line 1\n" - " // line 2\n" - " // line 3\n" - " f();\n" - "} while (true);", - getLLVMStyleWithColumns(80))); - EXPECT_EQ("while (a < b) { // line 1\n" - " // line 2\n" - " // line 3\n" - " f();\n" - "}", - format("while (a < b) {// line 1\n" - " // line 2\n" - " // line 3\n" - " f();\n" - "}", - getLLVMStyleWithColumns(80))); -} - -TEST_F(FormatTestComments, ReflowsComments) { - // Break a long line and reflow with the full next line. - EXPECT_EQ("// long long long\n" - "// long long", - format("// long long long long\n" - "// long", - getLLVMStyleWithColumns(20))); - - // Keep the trailing newline while reflowing. - EXPECT_EQ("// long long long\n" - "// long long\n", - format("// long long long long\n" - "// long\n", - getLLVMStyleWithColumns(20))); - - // Break a long line and reflow with a part of the next line. - EXPECT_EQ("// long long long\n" - "// long long\n" - "// long_long", - format("// long long long long\n" - "// long long_long", - getLLVMStyleWithColumns(20))); - - // Break but do not reflow if the first word from the next line is too long. - EXPECT_EQ("// long long long\n" - "// long\n" - "// long_long_long\n", - format("// long long long long\n" - "// long_long_long\n", - getLLVMStyleWithColumns(20))); - - // Don't break or reflow short lines. - verifyFormat("// long\n" - "// long long long lo\n" - "// long long long lo\n" - "// long", - getLLVMStyleWithColumns(20)); - - // Keep prefixes and decorations while reflowing. - EXPECT_EQ("/// long long long\n" - "/// long long\n", - format("/// long long long long\n" - "/// long\n", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("//! long long long\n" - "//! long long\n", - format("//! long long long long\n" - "//! long\n", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/* long long long\n" - " * long long */", - format("/* long long long long\n" - " * long */", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("///< long long long\n" - "///< long long\n", - format("///< long long long long\n" - "///< long\n", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("//!< long long long\n" - "//!< long long\n", - format("//!< long long long long\n" - "//!< long\n", - getLLVMStyleWithColumns(20))); - - // Don't bring leading whitespace up while reflowing. - EXPECT_EQ("/* long long long\n" - " * long long long\n" - " */", - format("/* long long long long\n" - " * long long\n" - " */", - getLLVMStyleWithColumns(20))); - - // Reflow the last line of a block comment with its trailing '*/'. - EXPECT_EQ("/* long long long\n" - " long long */", - format("/* long long long long\n" - " long */", - getLLVMStyleWithColumns(20))); - - // Reflow two short lines; keep the postfix of the last one. - EXPECT_EQ("/* long long long\n" - " * long long long */", - format("/* long long long long\n" - " * long\n" - " * long */", - getLLVMStyleWithColumns(20))); - - // Put the postfix of the last short reflow line on a newline if it doesn't - // fit. - EXPECT_EQ("/* long long long\n" - " * long long longg\n" - " */", - format("/* long long long long\n" - " * long\n" - " * longg */", - getLLVMStyleWithColumns(20))); - - // Reflow lines with leading whitespace. - EXPECT_EQ("{\n" - " /*\n" - " * long long long\n" - " * long long long\n" - " * long long long\n" - " */\n" - "}", - format("{\n" - "/*\n" - " * long long long long\n" - " * long\n" - " * long long long long\n" - " */\n" - "}", - getLLVMStyleWithColumns(20))); - - // Break single line block comments that are first in the line with ' *' - // decoration. - EXPECT_EQ("/* long long long\n" - " * long */", - format("/* long long long long */", getLLVMStyleWithColumns(20))); - - // Break single line block comment that are not first in the line with ' ' - // decoration. - EXPECT_EQ("int i; /* long long\n" - " long */", - format("int i; /* long long long */", getLLVMStyleWithColumns(20))); - - // Reflow a line that goes just over the column limit. - EXPECT_EQ("// long long long\n" - "// lon long", - format("// long long long lon\n" - "// long", - getLLVMStyleWithColumns(20))); - - // Stop reflowing if the next line has a different indentation than the - // previous line. - EXPECT_EQ("// long long long\n" - "// long\n" - "// long long\n" - "// long", - format("// long long long long\n" - "// long long\n" - "// long", - getLLVMStyleWithColumns(20))); - - // Reflow into the last part of a really long line that has been broken into - // multiple lines. - EXPECT_EQ("// long long long\n" - "// long long long\n" - "// long long long\n", - format("// long long long long long long long long\n" - "// long\n", - getLLVMStyleWithColumns(20))); - - // Break the first line, then reflow the beginning of the second and third - // line up. - EXPECT_EQ("// long long long\n" - "// lon1 lon2 lon2\n" - "// lon2 lon3 lon3", - format("// long long long lon1\n" - "// lon2 lon2 lon2\n" - "// lon3 lon3", - getLLVMStyleWithColumns(20))); - - // Reflow the beginning of the second line, then break the rest. - EXPECT_EQ("// long long long\n" - "// lon1 lon2 lon2\n" - "// lon2 lon2 lon2\n" - "// lon3", - format("// long long long lon1\n" - "// lon2 lon2 lon2 lon2 lon2 lon3", - getLLVMStyleWithColumns(20))); - - // Shrink the first line, then reflow the second line up. - EXPECT_EQ("// long long long", format("// long long\n" - "// long", - getLLVMStyleWithColumns(20))); - - // Don't shrink leading whitespace. - EXPECT_EQ("int i; /// a", - format("int i; /// a", getLLVMStyleWithColumns(20))); - - // Shrink trailing whitespace if there is no postfix and reflow. - EXPECT_EQ("// long long long\n" - "// long long", - format("// long long long long \n" - "// long", - getLLVMStyleWithColumns(20))); - - // Shrink trailing whitespace to a single one if there is postfix. - EXPECT_EQ("/* long long long */", - format("/* long long long */", getLLVMStyleWithColumns(20))); - - // Break a block comment postfix if exceeding the line limit. - EXPECT_EQ("/* long\n" - " */", - format("/* long */", getLLVMStyleWithColumns(20))); - - // Reflow indented comments. - EXPECT_EQ("{\n" - " // long long long\n" - " // long long\n" - " int i; /* long lon\n" - " g long\n" - " */\n" - "}", - format("{\n" - " // long long long long\n" - " // long\n" - " int i; /* long lon g\n" - " long */\n" - "}", - getLLVMStyleWithColumns(20))); - - // Don't realign trailing comments after reflow has happened. - EXPECT_EQ("// long long long\n" - "// long long\n" - "long i; // long", - format("// long long long long\n" - "// long\n" - "long i; // long", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("// long long long\n" - "// longng long long\n" - "// long lo", - format("// long long long longng\n" - "// long long long\n" - "// lo", - getLLVMStyleWithColumns(20))); - - // Reflow lines after a broken line. - EXPECT_EQ("int a; // Trailing\n" - " // comment on\n" - " // 2 or 3\n" - " // lines.\n", - format("int a; // Trailing comment\n" - " // on 2\n" - " // or 3\n" - " // lines.\n", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/// This long line\n" - "/// gets reflown.\n", - format("/// This long line gets\n" - "/// reflown.\n", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("//! This long line\n" - "//! gets reflown.\n", - format(" //! This long line gets\n" - " //! reflown.\n", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/* This long line\n" - " * gets reflown.\n" - " */\n", - format("/* This long line gets\n" - " * reflown.\n" - " */\n", - getLLVMStyleWithColumns(20))); - - // Reflow after indentation makes a line too long. - EXPECT_EQ("{\n" - " // long long long\n" - " // lo long\n" - "}\n", - format("{\n" - "// long long long lo\n" - "// long\n" - "}\n", - getLLVMStyleWithColumns(20))); - - // Break and reflow multiple lines. - EXPECT_EQ("/*\n" - " * Reflow the end of\n" - " * line by 11 22 33\n" - " * 4.\n" - " */\n", - format("/*\n" - " * Reflow the end of line\n" - " * by\n" - " * 11\n" - " * 22\n" - " * 33\n" - " * 4.\n" - " */\n", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/// First line gets\n" - "/// broken. Second\n" - "/// line gets\n" - "/// reflown and\n" - "/// broken. Third\n" - "/// gets reflown.\n", - format("/// First line gets broken.\n" - "/// Second line gets reflown and broken.\n" - "/// Third gets reflown.\n", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("int i; // first long\n" - " // long snd\n" - " // long.\n", - format("int i; // first long long\n" - " // snd long.\n", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("{\n" - " // first long line\n" - " // line second\n" - " // long line line\n" - " // third long line\n" - " // line\n" - "}\n", - format("{\n" - " // first long line line\n" - " // second long line line\n" - " // third long line line\n" - "}\n", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("int i; /* first line\n" - " * second\n" - " * line third\n" - " * line\n" - " */", - format("int i; /* first line\n" - " * second line\n" - " * third line\n" - " */", - getLLVMStyleWithColumns(20))); - - // Reflow the last two lines of a section that starts with a line having - // different indentation. - EXPECT_EQ( - "// long\n" - "// long long long\n" - "// long long", - format("// long\n" - "// long long long long\n" - "// long", - getLLVMStyleWithColumns(20))); - - // Keep the block comment endling '*/' while reflowing. - EXPECT_EQ("/* Long long long\n" - " * line short */\n", - format("/* Long long long line\n" - " * short */\n", - getLLVMStyleWithColumns(20))); - - // Don't reflow between separate blocks of comments. - EXPECT_EQ("/* First comment\n" - " * block will */\n" - "/* Snd\n" - " */\n", - format("/* First comment block\n" - " * will */\n" - "/* Snd\n" - " */\n", - getLLVMStyleWithColumns(20))); - - // Don't reflow across blank comment lines. - EXPECT_EQ("int i; // This long\n" - " // line gets\n" - " // broken.\n" - " //\n" - " // keep.\n", - format("int i; // This long line gets broken.\n" - " // \n" - " // keep.\n", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("{\n" - " /// long long long\n" - " /// long long\n" - " ///\n" - " /// long\n" - "}", - format("{\n" - " /// long long long long\n" - " /// long\n" - " ///\n" - " /// long\n" - "}", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("//! long long long\n" - "//! long\n" - "\n" - "//! long", - format("//! long long long long\n" - "\n" - "//! long", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/* long long long\n" - " long\n" - "\n" - " long */", - format("/* long long long long\n" - "\n" - " long */", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/* long long long\n" - " * long\n" - " *\n" - " * long */", - format("/* long long long long\n" - " *\n" - " * long */", - getLLVMStyleWithColumns(20))); - - // Don't reflow lines having content that is a single character. - EXPECT_EQ("// long long long\n" - "// long\n" - "// l", - format("// long long long long\n" - "// l", - getLLVMStyleWithColumns(20))); - - // Don't reflow lines starting with two punctuation characters. - EXPECT_EQ("// long long long\n" - "// long\n" - "// ... --- ...", - format( - "// long long long long\n" - "// ... --- ...", - getLLVMStyleWithColumns(20))); - - // Don't reflow lines starting with '@'. - EXPECT_EQ("// long long long\n" - "// long\n" - "// @param arg", - format("// long long long long\n" - "// @param arg", - getLLVMStyleWithColumns(20))); - - // Don't reflow lines starting with 'TODO'. - EXPECT_EQ("// long long long\n" - "// long\n" - "// TODO: long", - format("// long long long long\n" - "// TODO: long", - getLLVMStyleWithColumns(20))); - - // Don't reflow lines starting with 'FIXME'. - EXPECT_EQ("// long long long\n" - "// long\n" - "// FIXME: long", - format("// long long long long\n" - "// FIXME: long", - getLLVMStyleWithColumns(20))); - - // Don't reflow lines starting with 'XXX'. - EXPECT_EQ("// long long long\n" - "// long\n" - "// XXX: long", - format("// long long long long\n" - "// XXX: long", - getLLVMStyleWithColumns(20))); - - // Don't reflow comment pragmas. - EXPECT_EQ("// long long long\n" - "// long\n" - "// IWYU pragma:", - format("// long long long long\n" - "// IWYU pragma:", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("/* long long long\n" - " * long\n" - " * IWYU pragma:\n" - " */", - format("/* long long long long\n" - " * IWYU pragma:\n" - " */", - getLLVMStyleWithColumns(20))); - - // Reflow lines that have a non-punctuation character among their first 2 - // characters. - EXPECT_EQ("// long long long\n" - "// long 'long'", - format( - "// long long long long\n" - "// 'long'", - getLLVMStyleWithColumns(20))); - - // Don't reflow between separate blocks of comments. - EXPECT_EQ("/* First comment\n" - " * block will */\n" - "/* Snd\n" - " */\n", - format("/* First comment block\n" - " * will */\n" - "/* Snd\n" - " */\n", - getLLVMStyleWithColumns(20))); - - // Don't reflow lines having different indentation. - EXPECT_EQ("// long long long\n" - "// long\n" - "// long", - format("// long long long long\n" - "// long", - getLLVMStyleWithColumns(20))); - - // Don't reflow separate bullets in list - EXPECT_EQ("// - long long long\n" - "// long\n" - "// - long", - format("// - long long long long\n" - "// - long", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("// * long long long\n" - "// long\n" - "// * long", - format("// * long long long long\n" - "// * long", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("// + long long long\n" - "// long\n" - "// + long", - format("// + long long long long\n" - "// + long", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("// 1. long long long\n" - "// long\n" - "// 2. long", - format("// 1. long long long long\n" - "// 2. long", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("// -# long long long\n" - "// long\n" - "// -# long", - format("// -# long long long long\n" - "// -# long", - getLLVMStyleWithColumns(20))); - - EXPECT_EQ("// - long long long\n" - "// long long long\n" - "// - long", - format("// - long long long long\n" - "// long long\n" - "// - long", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("// - long long long\n" - "// long long long\n" - "// long\n" - "// - long", - format("// - long long long long\n" - "// long long long\n" - "// - long", - getLLVMStyleWithColumns(20))); - - // Large number (>2 digits) are not list items - EXPECT_EQ("// long long long\n" - "// long 1024. long.", - format("// long long long long\n" - "// 1024. long.", - getLLVMStyleWithColumns(20))); - - // Do not break before number, to avoid introducing a non-reflowable doxygen - // list item. - EXPECT_EQ("// long long\n" - "// long 10. long.", - format("// long long long 10.\n" - "// long.", - getLLVMStyleWithColumns(20))); - - // Don't break or reflow after implicit string literals. - verifyFormat("#include <t> // l l l\n" - " // l", - getLLVMStyleWithColumns(20)); - - // Don't break or reflow comments on import lines. - EXPECT_EQ("#include \"t\" /* l l l\n" - " * l */", - format("#include \"t\" /* l l l\n" - " * l */", - getLLVMStyleWithColumns(20))); - - // Don't reflow between different trailing comment sections. - EXPECT_EQ("int i; // long long\n" - " // long\n" - "int j; // long long\n" - " // long\n", - format("int i; // long long long\n" - "int j; // long long long\n", - getLLVMStyleWithColumns(20))); - - // Don't reflow if the first word on the next line is longer than the - // available space at current line. - EXPECT_EQ("int i; // trigger\n" - " // reflow\n" - " // longsec\n", - format("int i; // trigger reflow\n" - " // longsec\n", - getLLVMStyleWithColumns(20))); - - // Simple case that correctly handles reflow in parameter lists. - EXPECT_EQ("a = f(/* looooooooong\n" - " * long long\n" - " */\n" - " a);", - format("a = f(/* looooooooong long\n* long\n*/ a);", - getLLVMStyleWithColumns(22))); - // Tricky case that has fewer lines if we reflow the comment, ending up with - // fewer lines. - EXPECT_EQ("a = f(/* loooooong\n" - " * long long\n" - " */\n" - " a);", - format("a = f(/* loooooong long\n* long\n*/ a);", - getLLVMStyleWithColumns(22))); - - // Keep empty comment lines. - EXPECT_EQ("/**/", format(" /**/", getLLVMStyleWithColumns(20))); - EXPECT_EQ("/* */", format(" /* */", getLLVMStyleWithColumns(20))); - EXPECT_EQ("/* */", format(" /* */", getLLVMStyleWithColumns(20))); - EXPECT_EQ("//", format(" // ", getLLVMStyleWithColumns(20))); - EXPECT_EQ("///", format(" /// ", getLLVMStyleWithColumns(20))); -} - -TEST_F(FormatTestComments, ReflowsCommentsPrecise) { - // FIXME: This assumes we do not continue compressing whitespace once we are - // in reflow mode. Consider compressing whitespace. - - // Test that we stop reflowing precisely at the column limit. - // After reflowing, "// reflows into foo" does not fit the column limit, - // so we compress the whitespace. - EXPECT_EQ("// some text that\n" - "// reflows into foo\n", - format("// some text that reflows\n" - "// into foo\n", - getLLVMStyleWithColumns(20))); - // Given one more column, "// reflows into foo" does fit the limit, so we - // do not compress the whitespace. - EXPECT_EQ("// some text that\n" - "// reflows into foo\n", - format("// some text that reflows\n" - "// into foo\n", - getLLVMStyleWithColumns(21))); - - // Make sure that we correctly account for the space added in the reflow case - // when making the reflowing decision. - // First, when the next line ends precisely one column over the limit, do not - // reflow. - EXPECT_EQ("// some text that\n" - "// reflows\n" - "// into1234567\n", - format("// some text that reflows\n" - "// into1234567\n", - getLLVMStyleWithColumns(21))); - // Secondly, when the next line ends later, but the first word in that line - // is precisely one column over the limit, do not reflow. - EXPECT_EQ("// some text that\n" - "// reflows\n" - "// into1234567 f\n", - format("// some text that reflows\n" - "// into1234567 f\n", - getLLVMStyleWithColumns(21))); -} - -TEST_F(FormatTestComments, ReflowsCommentsWithExtraWhitespace) { - // Baseline. - EXPECT_EQ("// some text\n" - "// that re flows\n", - format("// some text that\n" - "// re flows\n", - getLLVMStyleWithColumns(16))); - EXPECT_EQ("// some text\n" - "// that re flows\n", - format("// some text that\n" - "// re flows\n", - getLLVMStyleWithColumns(16))); - EXPECT_EQ("/* some text\n" - " * that re flows\n" - " */\n", - format("/* some text that\n" - "* re flows\n" - "*/\n", - getLLVMStyleWithColumns(16))); - // FIXME: We do not reflow if the indent of two subsequent lines differs; - // given that this is different behavior from block comments, do we want - // to keep this? - EXPECT_EQ("// some text\n" - "// that\n" - "// re flows\n", - format("// some text that\n" - "// re flows\n", - getLLVMStyleWithColumns(16))); - // Space within parts of a line that fit. - // FIXME: Use the earliest possible split while reflowing to compress the - // whitespace within the line. - EXPECT_EQ("// some text that\n" - "// does re flow\n" - "// more here\n", - format("// some text that does\n" - "// re flow more here\n", - getLLVMStyleWithColumns(21))); -} - -TEST_F(FormatTestComments, IgnoresIf0Contents) { - EXPECT_EQ("#if 0\n" - "}{)(&*(^%%#%@! fsadj f;ldjs ,:;| <<<>>>][)(][\n" - "#endif\n" - "void f() {}", - format("#if 0\n" - "}{)(&*(^%%#%@! fsadj f;ldjs ,:;| <<<>>>][)(][\n" - "#endif\n" - "void f( ) { }")); - EXPECT_EQ("#if false\n" - "void f( ) { }\n" - "#endif\n" - "void g() {}\n", - format("#if false\n" - "void f( ) { }\n" - "#endif\n" - "void g( ) { }\n")); - EXPECT_EQ("enum E {\n" - " One,\n" - " Two,\n" - "#if 0\n" - "Three,\n" - " Four,\n" - "#endif\n" - " Five\n" - "};", - format("enum E {\n" - " One,Two,\n" - "#if 0\n" - "Three,\n" - " Four,\n" - "#endif\n" - " Five};")); - EXPECT_EQ("enum F {\n" - " One,\n" - "#if 1\n" - " Two,\n" - "#if 0\n" - "Three,\n" - " Four,\n" - "#endif\n" - " Five\n" - "#endif\n" - "};", - format("enum F {\n" - "One,\n" - "#if 1\n" - "Two,\n" - "#if 0\n" - "Three,\n" - " Four,\n" - "#endif\n" - "Five\n" - "#endif\n" - "};")); - EXPECT_EQ("enum G {\n" - " One,\n" - "#if 0\n" - "Two,\n" - "#else\n" - " Three,\n" - "#endif\n" - " Four\n" - "};", - format("enum G {\n" - "One,\n" - "#if 0\n" - "Two,\n" - "#else\n" - "Three,\n" - "#endif\n" - "Four\n" - "};")); - EXPECT_EQ("enum H {\n" - " One,\n" - "#if 0\n" - "#ifdef Q\n" - "Two,\n" - "#else\n" - "Three,\n" - "#endif\n" - "#endif\n" - " Four\n" - "};", - format("enum H {\n" - "One,\n" - "#if 0\n" - "#ifdef Q\n" - "Two,\n" - "#else\n" - "Three,\n" - "#endif\n" - "#endif\n" - "Four\n" - "};")); - EXPECT_EQ("enum I {\n" - " One,\n" - "#if /* test */ 0 || 1\n" - "Two,\n" - "Three,\n" - "#endif\n" - " Four\n" - "};", - format("enum I {\n" - "One,\n" - "#if /* test */ 0 || 1\n" - "Two,\n" - "Three,\n" - "#endif\n" - "Four\n" - "};")); - EXPECT_EQ("enum J {\n" - " One,\n" - "#if 0\n" - "#if 0\n" - "Two,\n" - "#else\n" - "Three,\n" - "#endif\n" - "Four,\n" - "#endif\n" - " Five\n" - "};", - format("enum J {\n" - "One,\n" - "#if 0\n" - "#if 0\n" - "Two,\n" - "#else\n" - "Three,\n" - "#endif\n" - "Four,\n" - "#endif\n" - "Five\n" - "};")); - - // Ignore stuff in SWIG-blocks. - EXPECT_EQ("#ifdef SWIG\n" - "}{)(&*(^%%#%@! fsadj f;ldjs ,:;| <<<>>>][)(][\n" - "#endif\n" - "void f() {}", - format("#ifdef SWIG\n" - "}{)(&*(^%%#%@! fsadj f;ldjs ,:;| <<<>>>][)(][\n" - "#endif\n" - "void f( ) { }")); - EXPECT_EQ("#ifndef SWIG\n" - "void f() {}\n" - "#endif", - format("#ifndef SWIG\n" - "void f( ) { }\n" - "#endif")); -} - -TEST_F(FormatTestComments, DontCrashOnBlockComments) { - EXPECT_EQ( - "int xxxxxxxxx; /* " - "yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy\n" - "zzzzzz\n" - "0*/", - format("int xxxxxxxxx; /* " - "yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy zzzzzz\n" - "0*/")); -} - -TEST_F(FormatTestComments, BlockCommentsInControlLoops) { - verifyFormat("if (0) /* a comment in a strange place */ {\n" - " f();\n" - "}"); - verifyFormat("if (0) /* a comment in a strange place */ {\n" - " f();\n" - "} /* another comment */ else /* comment #3 */ {\n" - " g();\n" - "}"); - verifyFormat("while (0) /* a comment in a strange place */ {\n" - " f();\n" - "}"); - verifyFormat("for (;;) /* a comment in a strange place */ {\n" - " f();\n" - "}"); - verifyFormat("do /* a comment in a strange place */ {\n" - " f();\n" - "} /* another comment */ while (0);"); -} - -TEST_F(FormatTestComments, BlockComments) { - EXPECT_EQ("/* */ /* */ /* */\n/* */ /* */ /* */", - format("/* *//* */ /* */\n/* *//* */ /* */")); - EXPECT_EQ("/* */ a /* */ b;", format(" /* */ a/* */ b;")); - EXPECT_EQ("#define A /*123*/ \\\n" - " b\n" - "/* */\n" - "someCall(\n" - " parameter);", - format("#define A /*123*/ b\n" - "/* */\n" - "someCall(parameter);", - getLLVMStyleWithColumns(15))); - - EXPECT_EQ("#define A\n" - "/* */ someCall(\n" - " parameter);", - format("#define A\n" - "/* */someCall(parameter);", - getLLVMStyleWithColumns(15))); - EXPECT_EQ("/*\n**\n*/", format("/*\n**\n*/")); - EXPECT_EQ("/*\n" - " *\n" - " * aaaaaa\n" - " * aaaaaa\n" - " */", - format("/*\n" - "*\n" - " * aaaaaa aaaaaa\n" - "*/", - getLLVMStyleWithColumns(10))); - EXPECT_EQ("/*\n" - "**\n" - "* aaaaaa\n" - "*aaaaaa\n" - "*/", - format("/*\n" - "**\n" - "* aaaaaa aaaaaa\n" - "*/", - getLLVMStyleWithColumns(10))); - EXPECT_EQ("int aaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " /* line 1\n" - " bbbbbbbbbbbb */\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbb;", - format("int aaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " /* line 1\n" - " bbbbbbbbbbbb */ bbbbbbbbbbbbbbbbbbbbbbbbbbbb;", - getLLVMStyleWithColumns(50))); - - FormatStyle NoBinPacking = getLLVMStyle(); - NoBinPacking.BinPackParameters = false; - EXPECT_EQ("someFunction(1, /* comment 1 */\n" - " 2, /* comment 2 */\n" - " 3, /* comment 3 */\n" - " aaaa,\n" - " bbbb);", - format("someFunction (1, /* comment 1 */\n" - " 2, /* comment 2 */ \n" - " 3, /* comment 3 */\n" - "aaaa, bbbb );", - NoBinPacking)); - verifyFormat( - "bool aaaaaaaaaaaaa = /* comment: */ aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - EXPECT_EQ( - "bool aaaaaaaaaaaaa = /* trailing comment */\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;", - format( - "bool aaaaaaaaaaaaa = /* trailing comment */\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa||aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;")); - EXPECT_EQ( - "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n" - "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n" - "int cccccccccccccccccccccccccccccc; /* comment */\n", - format("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n" - "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n" - "int cccccccccccccccccccccccccccccc; /* comment */\n")); - - verifyFormat("void f(int * /* unused */) {}"); - - EXPECT_EQ("/*\n" - " **\n" - " */", - format("/*\n" - " **\n" - " */")); - EXPECT_EQ("/*\n" - " *q\n" - " */", - format("/*\n" - " *q\n" - " */")); - EXPECT_EQ("/*\n" - " * q\n" - " */", - format("/*\n" - " * q\n" - " */")); - EXPECT_EQ("/*\n" - " **/", - format("/*\n" - " **/")); - EXPECT_EQ("/*\n" - " ***/", - format("/*\n" - " ***/")); -} - -TEST_F(FormatTestComments, BlockCommentsInMacros) { - EXPECT_EQ("#define A \\\n" - " { \\\n" - " /* one line */ \\\n" - " someCall();", - format("#define A { \\\n" - " /* one line */ \\\n" - " someCall();", - getLLVMStyleWithColumns(20))); - EXPECT_EQ("#define A \\\n" - " { \\\n" - " /* previous */ \\\n" - " /* one line */ \\\n" - " someCall();", - format("#define A { \\\n" - " /* previous */ \\\n" - " /* one line */ \\\n" - " someCall();", - getLLVMStyleWithColumns(20))); -} - -TEST_F(FormatTestComments, BlockCommentsAtEndOfLine) { - EXPECT_EQ("a = {\n" - " 1111 /* */\n" - "};", - format("a = {1111 /* */\n" - "};", - getLLVMStyleWithColumns(15))); - EXPECT_EQ("a = {\n" - " 1111 /* */\n" - "};", - format("a = {1111 /* */\n" - "};", - getLLVMStyleWithColumns(15))); - EXPECT_EQ("a = {\n" - " 1111 /* a\n" - " */\n" - "};", - format("a = {1111 /* a */\n" - "};", - getLLVMStyleWithColumns(15))); -} - -TEST_F(FormatTestComments, BreaksAfterMultilineBlockCommentsInParamLists) { - EXPECT_EQ("a = f(/* long\n" - " long */\n" - " a);", - format("a = f(/* long long */ a);", getLLVMStyleWithColumns(16))); - EXPECT_EQ("a = f(\n" - " /* long\n" - " long */\n" - " a);", - format("a = f(/* long long */ a);", getLLVMStyleWithColumns(15))); - - EXPECT_EQ("a = f(/* long\n" - " long\n" - " */\n" - " a);", - format("a = f(/* long\n" - " long\n" - " */a);", - getLLVMStyleWithColumns(16))); - - EXPECT_EQ("a = f(/* long\n" - " long\n" - " */\n" - " a);", - format("a = f(/* long\n" - " long\n" - " */ a);", - getLLVMStyleWithColumns(16))); - - EXPECT_EQ("a = f(/* long\n" - " long\n" - " */\n" - " (1 + 1));", - format("a = f(/* long\n" - " long\n" - " */ (1 + 1));", - getLLVMStyleWithColumns(16))); - - EXPECT_EQ( - "a = f(a,\n" - " /* long\n" - " long */\n" - " b);", - format("a = f(a, /* long long */ b);", getLLVMStyleWithColumns(16))); - - EXPECT_EQ( - "a = f(\n" - " a,\n" - " /* long\n" - " long */\n" - " b);", - format("a = f(a, /* long long */ b);", getLLVMStyleWithColumns(15))); - - EXPECT_EQ("a = f(a,\n" - " /* long\n" - " long */\n" - " (1 + 1));", - format("a = f(a, /* long long */ (1 + 1));", - getLLVMStyleWithColumns(16))); - EXPECT_EQ("a = f(\n" - " a,\n" - " /* long\n" - " long */\n" - " (1 + 1));", - format("a = f(a, /* long long */ (1 + 1));", - getLLVMStyleWithColumns(15))); -} - -TEST_F(FormatTestComments, IndentLineCommentsInStartOfBlockAtEndOfFile) { - verifyFormat("{\n" - " // a\n" - " // b"); -} - -TEST_F(FormatTestComments, AlignTrailingComments) { - EXPECT_EQ("#define MACRO(V) \\\n" - " V(Rt2) /* one more char */ \\\n" - " V(Rs) /* than here */ \\\n" - "/* comment 3 */\n", - format("#define MACRO(V)\\\n" - "V(Rt2) /* one more char */ \\\n" - "V(Rs) /* than here */ \\\n" - "/* comment 3 */\n", - getLLVMStyleWithColumns(40))); - EXPECT_EQ("int i = f(abc, // line 1\n" - " d, // line 2\n" - " // line 3\n" - " b);", - format("int i = f(abc, // line 1\n" - " d, // line 2\n" - " // line 3\n" - " b);", - getLLVMStyleWithColumns(40))); - - // Align newly broken trailing comments. - EXPECT_EQ("int ab; // line\n" - "int a; // long\n" - " // long\n", - format("int ab; // line\n" - "int a; // long long\n", - getLLVMStyleWithColumns(15))); - EXPECT_EQ("int ab; // line\n" - "int a; // long\n" - " // long\n" - " // long", - format("int ab; // line\n" - "int a; // long long\n" - " // long", - getLLVMStyleWithColumns(15))); - EXPECT_EQ("int ab; // line\n" - "int a; // long\n" - " // long\n" - "pt c; // long", - format("int ab; // line\n" - "int a; // long long\n" - "pt c; // long", - getLLVMStyleWithColumns(15))); - EXPECT_EQ("int ab; // line\n" - "int a; // long\n" - " // long\n" - "\n" - "// long", - format("int ab; // line\n" - "int a; // long long\n" - "\n" - "// long", - getLLVMStyleWithColumns(15))); - - // Don't align newly broken trailing comments if that would put them over the - // column limit. - EXPECT_EQ("int i, j; // line 1\n" - "int k; // line longg\n" - " // long", - format("int i, j; // line 1\n" - "int k; // line longg long", - getLLVMStyleWithColumns(20))); - - // Always align if ColumnLimit = 0 - EXPECT_EQ("int i, j; // line 1\n" - "int k; // line longg long", - format("int i, j; // line 1\n" - "int k; // line longg long", - getLLVMStyleWithColumns(0))); - - // Align comment line sections aligned with the next token with the next - // token. - EXPECT_EQ("class A {\n" - "public: // public comment\n" - " // comment about a\n" - " int a;\n" - "};", - format("class A {\n" - "public: // public comment\n" - " // comment about a\n" - " int a;\n" - "};", - getLLVMStyleWithColumns(40))); - EXPECT_EQ("class A {\n" - "public: // public comment 1\n" - " // public comment 2\n" - " // comment 1 about a\n" - " // comment 2 about a\n" - " int a;\n" - "};", - format("class A {\n" - "public: // public comment 1\n" - " // public comment 2\n" - " // comment 1 about a\n" - " // comment 2 about a\n" - " int a;\n" - "};", - getLLVMStyleWithColumns(40))); - EXPECT_EQ("int f(int n) { // comment line 1 on f\n" - " // comment line 2 on f\n" - " // comment line 1 before return\n" - " // comment line 2 before return\n" - " return n; // comment line 1 on return\n" - " // comment line 2 on return\n" - " // comment line 1 after return\n" - "}", - format("int f(int n) { // comment line 1 on f\n" - " // comment line 2 on f\n" - " // comment line 1 before return\n" - " // comment line 2 before return\n" - " return n; // comment line 1 on return\n" - " // comment line 2 on return\n" - " // comment line 1 after return\n" - "}", - getLLVMStyleWithColumns(40))); - EXPECT_EQ("int f(int n) {\n" - " switch (n) { // comment line 1 on switch\n" - " // comment line 2 on switch\n" - " // comment line 1 before case 1\n" - " // comment line 2 before case 1\n" - " case 1: // comment line 1 on case 1\n" - " // comment line 2 on case 1\n" - " // comment line 1 before return 1\n" - " // comment line 2 before return 1\n" - " return 1; // comment line 1 on return 1\n" - " // comment line 2 on return 1\n" - " // comment line 1 before default\n" - " // comment line 2 before default\n" - " default: // comment line 1 on default\n" - " // comment line 2 on default\n" - " // comment line 1 before return 2\n" - " return 2 * f(n - 1); // comment line 1 on return 2\n" - " // comment line 2 on return 2\n" - " // comment line 1 after return\n" - " // comment line 2 after return\n" - " }\n" - "}", - format("int f(int n) {\n" - " switch (n) { // comment line 1 on switch\n" - " // comment line 2 on switch\n" - " // comment line 1 before case 1\n" - " // comment line 2 before case 1\n" - " case 1: // comment line 1 on case 1\n" - " // comment line 2 on case 1\n" - " // comment line 1 before return 1\n" - " // comment line 2 before return 1\n" - " return 1; // comment line 1 on return 1\n" - " // comment line 2 on return 1\n" - " // comment line 1 before default\n" - " // comment line 2 before default\n" - " default: // comment line 1 on default\n" - " // comment line 2 on default\n" - " // comment line 1 before return 2\n" - " return 2 * f(n - 1); // comment line 1 on return 2\n" - " // comment line 2 on return 2\n" - " // comment line 1 after return\n" - " // comment line 2 after return\n" - " }\n" - "}", - getLLVMStyleWithColumns(80))); - - // If all the lines in a sequence of line comments are aligned with the next - // token, the first line belongs to the previous token and the other lines - // belong to the next token. - EXPECT_EQ("int a; // line about a\n" - "long b;", - format("int a; // line about a\n" - " long b;", - getLLVMStyleWithColumns(80))); - EXPECT_EQ("int a; // line about a\n" - "// line about b\n" - "long b;", - format("int a; // line about a\n" - " // line about b\n" - " long b;", - getLLVMStyleWithColumns(80))); - EXPECT_EQ("int a; // line about a\n" - "// line 1 about b\n" - "// line 2 about b\n" - "long b;", - format("int a; // line about a\n" - " // line 1 about b\n" - " // line 2 about b\n" - " long b;", - getLLVMStyleWithColumns(80))); -} - -TEST_F(FormatTestComments, AlignsBlockCommentDecorations) { - EXPECT_EQ("/*\n" - " */", - format("/*\n" - "*/", getLLVMStyle())); - EXPECT_EQ("/*\n" - " */", - format("/*\n" - " */", getLLVMStyle())); - EXPECT_EQ("/*\n" - " */", - format("/*\n" - " */", getLLVMStyle())); - - // Align a single line. - EXPECT_EQ("/*\n" - " * line */", - format("/*\n" - "* line */", - getLLVMStyle())); - EXPECT_EQ("/*\n" - " * line */", - format("/*\n" - " * line */", - getLLVMStyle())); - EXPECT_EQ("/*\n" - " * line */", - format("/*\n" - " * line */", - getLLVMStyle())); - EXPECT_EQ("/*\n" - " * line */", - format("/*\n" - " * line */", - getLLVMStyle())); - EXPECT_EQ("/**\n" - " * line */", - format("/**\n" - "* line */", - getLLVMStyle())); - EXPECT_EQ("/**\n" - " * line */", - format("/**\n" - " * line */", - getLLVMStyle())); - EXPECT_EQ("/**\n" - " * line */", - format("/**\n" - " * line */", - getLLVMStyle())); - EXPECT_EQ("/**\n" - " * line */", - format("/**\n" - " * line */", - getLLVMStyle())); - EXPECT_EQ("/**\n" - " * line */", - format("/**\n" - " * line */", - getLLVMStyle())); - - // Align the end '*/' after a line. - EXPECT_EQ("/*\n" - " * line\n" - " */", - format("/*\n" - "* line\n" - "*/", getLLVMStyle())); - EXPECT_EQ("/*\n" - " * line\n" - " */", - format("/*\n" - " * line\n" - " */", getLLVMStyle())); - EXPECT_EQ("/*\n" - " * line\n" - " */", - format("/*\n" - " * line\n" - " */", getLLVMStyle())); - - // Align two lines. - EXPECT_EQ("/* line 1\n" - " * line 2 */", - format("/* line 1\n" - " * line 2 */", - getLLVMStyle())); - EXPECT_EQ("/* line 1\n" - " * line 2 */", - format("/* line 1\n" - "* line 2 */", - getLLVMStyle())); - EXPECT_EQ("/* line 1\n" - " * line 2 */", - format("/* line 1\n" - " * line 2 */", - getLLVMStyle())); - EXPECT_EQ("/* line 1\n" - " * line 2 */", - format("/* line 1\n" - " * line 2 */", - getLLVMStyle())); - EXPECT_EQ("/* line 1\n" - " * line 2 */", - format("/* line 1\n" - " * line 2 */", - getLLVMStyle())); - EXPECT_EQ("int i; /* line 1\n" - " * line 2 */", - format("int i; /* line 1\n" - "* line 2 */", - getLLVMStyle())); - EXPECT_EQ("int i; /* line 1\n" - " * line 2 */", - format("int i; /* line 1\n" - " * line 2 */", - getLLVMStyle())); - EXPECT_EQ("int i; /* line 1\n" - " * line 2 */", - format("int i; /* line 1\n" - " * line 2 */", - getLLVMStyle())); - - // Align several lines. - EXPECT_EQ("/* line 1\n" - " * line 2\n" - " * line 3 */", - format("/* line 1\n" - " * line 2\n" - "* line 3 */", - getLLVMStyle())); - EXPECT_EQ("/* line 1\n" - " * line 2\n" - " * line 3 */", - format("/* line 1\n" - " * line 2\n" - "* line 3 */", - getLLVMStyle())); - EXPECT_EQ("/*\n" - "** line 1\n" - "** line 2\n" - "*/", - format("/*\n" - "** line 1\n" - " ** line 2\n" - "*/", - getLLVMStyle())); - - // Align with different indent after the decorations. - EXPECT_EQ("/*\n" - " * line 1\n" - " * line 2\n" - " * line 3\n" - " * line 4\n" - " */", - format("/*\n" - "* line 1\n" - " * line 2\n" - " * line 3\n" - "* line 4\n" - "*/", getLLVMStyle())); - - // Align empty or blank lines. - EXPECT_EQ("/**\n" - " *\n" - " *\n" - " *\n" - " */", - format("/**\n" - "* \n" - " * \n" - " *\n" - "*/", getLLVMStyle())); - - // Align while breaking and reflowing. - EXPECT_EQ("/*\n" - " * long long long\n" - " * long long\n" - " *\n" - " * long */", - format("/*\n" - " * long long long long\n" - " * long\n" - " *\n" - "* long */", - getLLVMStyleWithColumns(20))); -} - -TEST_F(FormatTestComments, NoCrash_Bug34236) { - // This is a test case from a crasher reported in: - // https://bugs.llvm.org/show_bug.cgi?id=34236 - // Temporarily disable formatting for readability. - // clang-format off - EXPECT_EQ( -"/* */ /*\n" -" * a\n" -" * b c d*/", - format( -"/* */ /*\n" -" * a b\n" -" * c d*/", - getLLVMStyleWithColumns(80))); - // clang-format on -} - -TEST_F(FormatTestComments, NonTrailingBlockComments) { - verifyFormat("const /** comment comment */ A = B;", - getLLVMStyleWithColumns(40)); - - verifyFormat("const /** comment comment comment */ A =\n" - " B;", - getLLVMStyleWithColumns(40)); - - EXPECT_EQ("const /** comment comment comment\n" - " comment */\n" - " A = B;", - format("const /** comment comment comment comment */\n" - " A = B;", - getLLVMStyleWithColumns(40))); -} - -TEST_F(FormatTestComments, PythonStyleComments) { - // Keeps a space after '#'. - EXPECT_EQ("# comment\n" - "key: value", - format("#comment\n" - "key:value", - getTextProtoStyleWithColumns(20))); - EXPECT_EQ("# comment\n" - "key: value", - format("# comment\n" - "key:value", - getTextProtoStyleWithColumns(20))); - // Breaks long comment. - EXPECT_EQ("# comment comment\n" - "# comment\n" - "key: value", - format("# comment comment comment\n" - "key:value", - getTextProtoStyleWithColumns(20))); - // Indents comments. - EXPECT_EQ("data {\n" - " # comment comment\n" - " # comment\n" - " key: value\n" - "}", - format("data {\n" - "# comment comment comment\n" - "key: value}", - getTextProtoStyleWithColumns(20))); - EXPECT_EQ("data {\n" - " # comment comment\n" - " # comment\n" - " key: value\n" - "}", - format("data {# comment comment comment\n" - "key: value}", - getTextProtoStyleWithColumns(20))); - // Reflows long comments. - EXPECT_EQ("# comment comment\n" - "# comment comment\n" - "key: value", - format("# comment comment comment\n" - "# comment\n" - "key:value", - getTextProtoStyleWithColumns(20))); - // Breaks trailing comments. - EXPECT_EQ("k: val # comment\n" - " # comment\n" - "a: 1", - format("k:val#comment comment\n" - "a:1", - getTextProtoStyleWithColumns(20))); - EXPECT_EQ("id {\n" - " k: val # comment\n" - " # comment\n" - " # line line\n" - " a: 1\n" - "}", - format("id {k:val#comment comment\n" - "# line line\n" - "a:1}", - getTextProtoStyleWithColumns(20))); - // Aligns trailing comments. - EXPECT_EQ("k: val # commen1\n" - " # commen2\n" - " # commen3\n" - "# commen4\n" - "a: 1 # commen5\n" - " # commen6\n" - " # commen7", - format("k:val#commen1 commen2\n" - " # commen3\n" - "# commen4\n" - "a:1#commen5 commen6\n" - " #commen7", - getTextProtoStyleWithColumns(20))); -} - -TEST_F(FormatTestComments, BreaksBeforeTrailingUnbreakableSequence) { - // The end of /* trail */ is exactly at 80 columns, but the unbreakable - // trailing sequence ); after it exceeds the column limit. Make sure we - // correctly break the line in that case. - verifyFormat("int a =\n" - " foo(/* trail */);", - getLLVMStyleWithColumns(23)); -} - -TEST_F(FormatTestComments, ReflowBackslashCrash) { -// clang-format off - EXPECT_EQ( -"// How to run:\n" -"// bbbbb run \\\n" -"// rrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr\n" -"// \\ <log_file> -- --output_directory=\"<output_directory>\"", - format( -"// How to run:\n" -"// bbbbb run \\\n" -"// rrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr \\\n" -"// <log_file> -- --output_directory=\"<output_directory>\"")); -// clang-format on -} - -TEST_F(FormatTestComments, IndentsLongJavadocAnnotatedLines) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_Java); - Style.ColumnLimit = 60; - FormatStyle Style20 = getGoogleStyle(FormatStyle::LK_Java); - Style20.ColumnLimit = 20; - EXPECT_EQ( - "/**\n" - " * @param x long long long long long long long long long\n" - " * long\n" - " */\n", - format("/**\n" - " * @param x long long long long long long long long long long\n" - " */\n", - Style)); - EXPECT_EQ("/**\n" - " * @param x long long long long long long long long long\n" - " * long long long long long long long long long long\n" - " */\n", - format("/**\n" - " * @param x long long long long long long long long long " - "long long long long long long long long long long\n" - " */\n", - Style)); - EXPECT_EQ("/**\n" - " * @param x long long long long long long long long long\n" - " * long long long long long long long long long long\n" - " * long\n" - " */\n", - format("/**\n" - " * @param x long long long long long long long long long " - "long long long long long long long long long long long\n" - " */\n", - Style)); - EXPECT_EQ( - "/**\n" - " * Sentence that\n" - " * should be broken.\n" - " * @param short\n" - " * keep indentation\n" - " */\n", format( - "/**\n" - " * Sentence that should be broken.\n" - " * @param short\n" - " * keep indentation\n" - " */\n", Style20)); - - EXPECT_EQ("/**\n" - " * @param l1 long1\n" - " * to break\n" - " * @param l2 long2\n" - " * to break\n" - " */\n", - format("/**\n" - " * @param l1 long1 to break\n" - " * @param l2 long2 to break\n" - " */\n", - Style20)); - - EXPECT_EQ("/**\n" - " * @param xx to\n" - " * break\n" - " * no reflow\n" - " */\n", - format("/**\n" - " * @param xx to break\n" - " * no reflow\n" - " */\n", - Style20)); - - EXPECT_EQ("/**\n" - " * @param xx to\n" - " * break yes\n" - " * reflow\n" - " */\n", - format("/**\n" - " * @param xx to break\n" - " * yes reflow\n" - " */\n", - Style20)); - - FormatStyle JSStyle20 = getGoogleStyle(FormatStyle::LK_JavaScript); - JSStyle20.ColumnLimit = 20; - EXPECT_EQ("/**\n" - " * @param l1 long1\n" - " * to break\n" - " */\n", - format("/**\n" - " * @param l1 long1 to break\n" - " */\n", - JSStyle20)); - EXPECT_EQ("/**\n" - " * @param {l1 long1\n" - " * to break}\n" - " */\n", - format("/**\n" - " * @param {l1 long1 to break}\n" - " */\n", - JSStyle20)); -} - -} // end namespace -} // end namespace format -} // end namespace clang diff --git a/unittests/Format/FormatTestJS.cpp b/unittests/Format/FormatTestJS.cpp deleted file mode 100644 index 67b99ba146dad..0000000000000 --- a/unittests/Format/FormatTestJS.cpp +++ /dev/null @@ -1,2333 +0,0 @@ -//===- unittest/Format/FormatTestJS.cpp - Formatting unit tests for JS ----===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "FormatTestUtils.h" -#include "clang/Format/Format.h" -#include "llvm/Support/Debug.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -namespace clang { -namespace format { - -class FormatTestJS : public ::testing::Test { -protected: - static std::string format(llvm::StringRef Code, unsigned Offset, - unsigned Length, const FormatStyle &Style) { - LLVM_DEBUG(llvm::errs() << "---\n"); - LLVM_DEBUG(llvm::errs() << Code << "\n\n"); - std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length)); - FormattingAttemptStatus Status; - tooling::Replacements Replaces = - reformat(Style, Code, Ranges, "<stdin>", &Status); - EXPECT_TRUE(Status.FormatComplete); - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); - return *Result; - } - - static std::string format( - llvm::StringRef Code, - const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) { - return format(Code, 0, Code.size(), Style); - } - - static FormatStyle getGoogleJSStyleWithColumns(unsigned ColumnLimit) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript); - Style.ColumnLimit = ColumnLimit; - return Style; - } - - static void verifyFormat( - llvm::StringRef Code, - const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) { - EXPECT_EQ(Code.str(), format(Code, Style)) - << "Expected code is not stable"; - std::string Result = format(test::messUp(Code), Style); - EXPECT_EQ(Code.str(), Result) << "Formatted:\n" << Result; - } - - static void verifyFormat( - llvm::StringRef Expected, - llvm::StringRef Code, - const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) { - EXPECT_EQ(Expected.str(), format(Expected, Style)) - << "Expected code is not stable"; - std::string Result = format(Code, Style); - EXPECT_EQ(Expected.str(), Result) << "Formatted:\n" << Result; - } -}; - -TEST_F(FormatTestJS, BlockComments) { - verifyFormat("/* aaaaaaaaaaaaa */ aaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - // Breaks after a single line block comment. - EXPECT_EQ("aaaaa = bbbb.ccccccccccccccc(\n" - " /** @type_{!cccc.rrrrrrr.MMMMMMMMMMMM.LLLLLLLLLLL.lala} */\n" - " mediaMessage);", - format("aaaaa = bbbb.ccccccccccccccc(\n" - " /** " - "@type_{!cccc.rrrrrrr.MMMMMMMMMMMM.LLLLLLLLLLL.lala} */ " - "mediaMessage);", - getGoogleJSStyleWithColumns(70))); - // Breaks after a multiline block comment. - EXPECT_EQ( - "aaaaa = bbbb.ccccccccccccccc(\n" - " /**\n" - " * @type_{!cccc.rrrrrrr.MMMMMMMMMMMM.LLLLLLLLLLL.lala}\n" - " */\n" - " mediaMessage);", - format("aaaaa = bbbb.ccccccccccccccc(\n" - " /**\n" - " * @type_{!cccc.rrrrrrr.MMMMMMMMMMMM.LLLLLLLLLLL.lala}\n" - " */ mediaMessage);", - getGoogleJSStyleWithColumns(70))); -} - -TEST_F(FormatTestJS, JSDocComments) { - // Break the first line of a multiline jsdoc comment. - EXPECT_EQ("/**\n" - " * jsdoc line 1\n" - " * jsdoc line 2\n" - " */", - format("/** jsdoc line 1\n" - " * jsdoc line 2\n" - " */", - getGoogleJSStyleWithColumns(20))); - // Both break after '/**' and break the line itself. - EXPECT_EQ("/**\n" - " * jsdoc line long\n" - " * long jsdoc line 2\n" - " */", - format("/** jsdoc line long long\n" - " * jsdoc line 2\n" - " */", - getGoogleJSStyleWithColumns(20))); - // Break a short first line if the ending '*/' is on a newline. - EXPECT_EQ("/**\n" - " * jsdoc line 1\n" - " */", - format("/** jsdoc line 1\n" - " */", getGoogleJSStyleWithColumns(20))); - // Don't break the first line of a short single line jsdoc comment. - EXPECT_EQ("/** jsdoc line 1 */", - format("/** jsdoc line 1 */", getGoogleJSStyleWithColumns(20))); - // Don't break the first line of a single line jsdoc comment if it just fits - // the column limit. - EXPECT_EQ("/** jsdoc line 12 */", - format("/** jsdoc line 12 */", getGoogleJSStyleWithColumns(20))); - // Don't break after '/**' and before '*/' if there is no space between - // '/**' and the content. - EXPECT_EQ( - "/*** nonjsdoc long\n" - " * line */", - format("/*** nonjsdoc long line */", getGoogleJSStyleWithColumns(20))); - EXPECT_EQ( - "/**strange long long\n" - " * line */", - format("/**strange long long line */", getGoogleJSStyleWithColumns(20))); - // Break the first line of a single line jsdoc comment if it just exceeds the - // column limit. - EXPECT_EQ("/**\n" - " * jsdoc line 123\n" - " */", - format("/** jsdoc line 123 */", getGoogleJSStyleWithColumns(20))); - // Break also if the leading indent of the first line is more than 1 column. - EXPECT_EQ("/**\n" - " * jsdoc line 123\n" - " */", - format("/** jsdoc line 123 */", getGoogleJSStyleWithColumns(20))); - // Break also if the leading indent of the first line is more than 1 column. - EXPECT_EQ("/**\n" - " * jsdoc line 123\n" - " */", - format("/** jsdoc line 123 */", getGoogleJSStyleWithColumns(20))); - // Break after the content of the last line. - EXPECT_EQ("/**\n" - " * line 1\n" - " * line 2\n" - " */", - format("/**\n" - " * line 1\n" - " * line 2 */", - getGoogleJSStyleWithColumns(20))); - // Break both the content and after the content of the last line. - EXPECT_EQ("/**\n" - " * line 1\n" - " * line long long\n" - " * long\n" - " */", - format("/**\n" - " * line 1\n" - " * line long long long */", - getGoogleJSStyleWithColumns(20))); - - // The comment block gets indented. - EXPECT_EQ("function f() {\n" - " /**\n" - " * comment about\n" - " * x\n" - " */\n" - " var x = 1;\n" - "}", - format("function f() {\n" - "/** comment about x */\n" - "var x = 1;\n" - "}", - getGoogleJSStyleWithColumns(20))); - - // Don't break the first line of a single line short jsdoc comment pragma. - EXPECT_EQ("/** @returns j */", - format("/** @returns j */", - getGoogleJSStyleWithColumns(20))); - - // Break a single line long jsdoc comment pragma. - EXPECT_EQ("/**\n" - " * @returns {string} jsdoc line 12\n" - " */", - format("/** @returns {string} jsdoc line 12 */", - getGoogleJSStyleWithColumns(20))); - EXPECT_EQ("/**\n" - " * @returns {string}\n" - " * jsdoc line 12\n" - " */", - format("/** @returns {string} jsdoc line 12 */", - getGoogleJSStyleWithColumns(25))); - - EXPECT_EQ("/**\n" - " * @returns {string} jsdoc line 12\n" - " */", - format("/** @returns {string} jsdoc line 12 */", - getGoogleJSStyleWithColumns(20))); - - // FIXME: this overcounts the */ as a continuation of the 12 when breaking. - // Related to the FIXME in BreakableBlockComment::getRangeLength. - EXPECT_EQ("/**\n" - " * @returns {string}\n" - " * jsdoc line line\n" - " * 12\n" - " */", - format("/** @returns {string} jsdoc line line 12*/", - getGoogleJSStyleWithColumns(25))); - - // Fix a multiline jsdoc comment ending in a comment pragma. - EXPECT_EQ("/**\n" - " * line 1\n" - " * line 2\n" - " * @returns {string}\n" - " * jsdoc line 12\n" - " */", - format("/** line 1\n" - " * line 2\n" - " * @returns {string} jsdoc line 12 */", - getGoogleJSStyleWithColumns(20))); - - EXPECT_EQ("/**\n" - " * line 1\n" - " * line 2\n" - " *\n" - " * @returns j\n" - " */", - format("/** line 1\n" - " * line 2\n" - " *\n" - " * @returns j */", - getGoogleJSStyleWithColumns(20))); -} - -TEST_F(FormatTestJS, UnderstandsJavaScriptOperators) { - verifyFormat("a == = b;"); - verifyFormat("a != = b;"); - - verifyFormat("a === b;"); - verifyFormat("aaaaaaa ===\n b;", getGoogleJSStyleWithColumns(10)); - verifyFormat("a !== b;"); - verifyFormat("aaaaaaa !==\n b;", getGoogleJSStyleWithColumns(10)); - verifyFormat("if (a + b + c +\n" - " d !==\n" - " e + f + g)\n" - " q();", - getGoogleJSStyleWithColumns(20)); - - verifyFormat("a >> >= b;"); - - verifyFormat("a >>> b;"); - verifyFormat("aaaaaaa >>>\n b;", getGoogleJSStyleWithColumns(10)); - verifyFormat("a >>>= b;"); - verifyFormat("aaaaaaa >>>=\n b;", getGoogleJSStyleWithColumns(10)); - verifyFormat("if (a + b + c +\n" - " d >>>\n" - " e + f + g)\n" - " q();", - getGoogleJSStyleWithColumns(20)); - verifyFormat("var x = aaaaaaaaaa ?\n" - " bbbbbb :\n" - " ccc;", - getGoogleJSStyleWithColumns(20)); - - verifyFormat("var b = a.map((x) => x + 1);"); - verifyFormat("return ('aaa') in bbbb;"); - verifyFormat("var x = aaaaaaaaaaaaaaaaaaaaaaaaa() in\n" - " aaaa.aaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); - FormatStyle Style = getGoogleJSStyleWithColumns(80); - Style.AlignOperands = true; - verifyFormat("var x = aaaaaaaaaaaaaaaaaaaaaaaaa() in\n" - " aaaa.aaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;", - Style); - Style.BreakBeforeBinaryOperators = FormatStyle::BOS_All; - verifyFormat("var x = aaaaaaaaaaaaaaaaaaaaaaaaa()\n" - " in aaaa.aaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;", - Style); - - // ES6 spread operator. - verifyFormat("someFunction(...a);"); - verifyFormat("var x = [1, ...a, 2];"); -} - -TEST_F(FormatTestJS, UnderstandsAmpAmp) { - verifyFormat("e && e.SomeFunction();"); -} - -TEST_F(FormatTestJS, LiteralOperatorsCanBeKeywords) { - verifyFormat("not.and.or.not_eq = 1;"); -} - -TEST_F(FormatTestJS, ReservedWords) { - // JavaScript reserved words (aka keywords) are only illegal when used as - // Identifiers, but are legal as IdentifierNames. - verifyFormat("x.class.struct = 1;"); - verifyFormat("x.case = 1;"); - verifyFormat("x.interface = 1;"); - verifyFormat("x.for = 1;"); - verifyFormat("x.of();"); - verifyFormat("of(null);"); - verifyFormat("return of(null);"); - verifyFormat("import {of} from 'x';"); - verifyFormat("x.in();"); - verifyFormat("x.let();"); - verifyFormat("x.var();"); - verifyFormat("x.for();"); - verifyFormat("x.as();"); - verifyFormat("x.instanceof();"); - verifyFormat("x.switch();"); - verifyFormat("x.case();"); - verifyFormat("x.delete();"); - verifyFormat("x.throw();"); - verifyFormat("x.throws();"); - verifyFormat("x.if();"); - verifyFormat("x = {\n" - " a: 12,\n" - " interface: 1,\n" - " switch: 1,\n" - "};"); - verifyFormat("var struct = 2;"); - verifyFormat("var union = 2;"); - verifyFormat("var interface = 2;"); - verifyFormat("interface = 2;"); - verifyFormat("x = interface instanceof y;"); - verifyFormat("interface Test {\n" - " x: string;\n" - " switch: string;\n" - " case: string;\n" - " default: string;\n" - "}\n"); - verifyFormat("const Axis = {\n" - " for: 'for',\n" - " x: 'x'\n" - "};", - "const Axis = {for: 'for', x: 'x'};"); -} - -TEST_F(FormatTestJS, ReservedWordsMethods) { - verifyFormat( - "class X {\n" - " delete() {\n" - " x();\n" - " }\n" - " interface() {\n" - " x();\n" - " }\n" - " let() {\n" - " x();\n" - " }\n" - "}\n"); -} - -TEST_F(FormatTestJS, ReservedWordsParenthesized) { - // All of these are statements using the keyword, not function calls. - verifyFormat("throw (x + y);\n" - "await (await x).y;\n" - "typeof (x) === 'string';\n" - "void (0);\n" - "delete (x.y);\n" - "return (x);\n"); -} - -TEST_F(FormatTestJS, CppKeywords) { - // Make sure we don't mess stuff up because of C++ keywords. - verifyFormat("return operator && (aa);"); - // .. or QT ones. - verifyFormat("slots: Slot[];"); -} - -TEST_F(FormatTestJS, ES6DestructuringAssignment) { - verifyFormat("var [a, b, c] = [1, 2, 3];"); - verifyFormat("const [a, b, c] = [1, 2, 3];"); - verifyFormat("let [a, b, c] = [1, 2, 3];"); - verifyFormat("var {a, b} = {a: 1, b: 2};"); - verifyFormat("let {a, b} = {a: 1, b: 2};"); -} - -TEST_F(FormatTestJS, ContainerLiterals) { - verifyFormat("var x = {\n" - " y: function(a) {\n" - " return a;\n" - " }\n" - "};"); - verifyFormat("return {\n" - " link: function() {\n" - " f(); //\n" - " }\n" - "};"); - verifyFormat("return {\n" - " a: a,\n" - " link: function() {\n" - " f(); //\n" - " }\n" - "};"); - verifyFormat("return {\n" - " a: a,\n" - " link: function() {\n" - " f(); //\n" - " },\n" - " link: function() {\n" - " f(); //\n" - " }\n" - "};"); - verifyFormat("var stuff = {\n" - " // comment for update\n" - " update: false,\n" - " // comment for modules\n" - " modules: false,\n" - " // comment for tasks\n" - " tasks: false\n" - "};"); - verifyFormat("return {\n" - " 'finish':\n" - " //\n" - " a\n" - "};"); - verifyFormat("var obj = {\n" - " fooooooooo: function(x) {\n" - " return x.zIsTooLongForOneLineWithTheDeclarationLine();\n" - " }\n" - "};"); - // Simple object literal, as opposed to enum style below. - verifyFormat("var obj = {a: 123};"); - // Enum style top level assignment. - verifyFormat("X = {\n a: 123\n};"); - verifyFormat("X.Y = {\n a: 123\n};"); - // But only on the top level, otherwise its a plain object literal assignment. - verifyFormat("function x() {\n" - " y = {z: 1};\n" - "}"); - verifyFormat("x = foo && {a: 123};"); - - // Arrow functions in object literals. - verifyFormat("var x = {\n" - " y: (a) => {\n" - " return a;\n" - " }\n" - "};"); - verifyFormat("var x = {y: (a) => a};"); - - // Methods in object literals. - verifyFormat("var x = {\n" - " y(a: string): number {\n" - " return a;\n" - " }\n" - "};"); - verifyFormat("var x = {\n" - " y(a: string) {\n" - " return a;\n" - " }\n" - "};"); - - // Computed keys. - verifyFormat("var x = {[a]: 1, b: 2, [c]: 3};"); - verifyFormat("var x = {\n" - " [a]: 1,\n" - " b: 2,\n" - " [c]: 3,\n" - "};"); - - // Object literals can leave out labels. - verifyFormat("f({a}, () => {\n" - " g(); //\n" - "});"); - - // Keys can be quoted. - verifyFormat("var x = {\n" - " a: a,\n" - " b: b,\n" - " 'c': c,\n" - "};"); - - // Dict literals can skip the label names. - verifyFormat("var x = {\n" - " aaa,\n" - " aaa,\n" - " aaa,\n" - "};"); - verifyFormat("return {\n" - " a,\n" - " b: 'b',\n" - " c,\n" - "};"); -} - -TEST_F(FormatTestJS, MethodsInObjectLiterals) { - verifyFormat("var o = {\n" - " value: 'test',\n" - " get value() { // getter\n" - " return this.value;\n" - " }\n" - "};"); - verifyFormat("var o = {\n" - " value: 'test',\n" - " set value(val) { // setter\n" - " this.value = val;\n" - " }\n" - "};"); - verifyFormat("var o = {\n" - " value: 'test',\n" - " someMethod(val) { // method\n" - " doSomething(this.value + val);\n" - " }\n" - "};"); - verifyFormat("var o = {\n" - " someMethod(val) { // method\n" - " doSomething(this.value + val);\n" - " },\n" - " someOtherMethod(val) { // method\n" - " doSomething(this.value + val);\n" - " }\n" - "};"); -} - -TEST_F(FormatTestJS, GettersSettersVisibilityKeywords) { - // Don't break after "protected" - verifyFormat("class X {\n" - " protected get getter():\n" - " number {\n" - " return 1;\n" - " }\n" - "}", - getGoogleJSStyleWithColumns(12)); - // Don't break after "get" - verifyFormat("class X {\n" - " protected get someReallyLongGetterName():\n" - " number {\n" - " return 1;\n" - " }\n" - "}", - getGoogleJSStyleWithColumns(40)); -} - -TEST_F(FormatTestJS, SpacesInContainerLiterals) { - verifyFormat("var arr = [1, 2, 3];"); - verifyFormat("f({a: 1, b: 2, c: 3});"); - - verifyFormat("var object_literal_with_long_name = {\n" - " a: 'aaaaaaaaaaaaaaaaaa',\n" - " b: 'bbbbbbbbbbbbbbbbbb'\n" - "};"); - - verifyFormat("f({a: 1, b: 2, c: 3});", - getChromiumStyle(FormatStyle::LK_JavaScript)); - verifyFormat("f({'a': [{}]});"); -} - -TEST_F(FormatTestJS, SingleQuotedStrings) { - verifyFormat("this.function('', true);"); -} - -TEST_F(FormatTestJS, GoogScopes) { - verifyFormat("goog.scope(function() {\n" - "var x = a.b;\n" - "var y = c.d;\n" - "}); // goog.scope"); - verifyFormat("goog.scope(function() {\n" - "// test\n" - "var x = 0;\n" - "// test\n" - "});"); -} - -TEST_F(FormatTestJS, IIFEs) { - // Internal calling parens; no semi. - verifyFormat("(function() {\n" - "var a = 1;\n" - "}())"); - // External calling parens; no semi. - verifyFormat("(function() {\n" - "var b = 2;\n" - "})()"); - // Internal calling parens; with semi. - verifyFormat("(function() {\n" - "var c = 3;\n" - "}());"); - // External calling parens; with semi. - verifyFormat("(function() {\n" - "var d = 4;\n" - "})();"); -} - -TEST_F(FormatTestJS, GoogModules) { - verifyFormat("goog.module('this.is.really.absurdly.long');", - getGoogleJSStyleWithColumns(40)); - verifyFormat("goog.require('this.is.really.absurdly.long');", - getGoogleJSStyleWithColumns(40)); - verifyFormat("goog.provide('this.is.really.absurdly.long');", - getGoogleJSStyleWithColumns(40)); - verifyFormat("var long = goog.require('this.is.really.absurdly.long');", - getGoogleJSStyleWithColumns(40)); - verifyFormat("const X = goog.requireType('this.is.really.absurdly.long');", - getGoogleJSStyleWithColumns(40)); - verifyFormat("goog.forwardDeclare('this.is.really.absurdly.long');", - getGoogleJSStyleWithColumns(40)); - - // These should be wrapped normally. - verifyFormat( - "var MyLongClassName =\n" - " goog.module.get('my.long.module.name.followedBy.MyLongClassName');"); - verifyFormat("function a() {\n" - " goog.setTestOnly();\n" - "}\n", - "function a() {\n" - "goog.setTestOnly();\n" - "}\n"); -} - -TEST_F(FormatTestJS, FormatsNamespaces) { - verifyFormat("namespace Foo {\n" - " export let x = 1;\n" - "}\n"); - verifyFormat("declare namespace Foo {\n" - " export let x: number;\n" - "}\n"); -} - -TEST_F(FormatTestJS, NamespacesMayNotWrap) { - verifyFormat("declare namespace foobarbaz {\n" - "}\n", getGoogleJSStyleWithColumns(18)); - verifyFormat("declare module foobarbaz {\n" - "}\n", getGoogleJSStyleWithColumns(15)); - verifyFormat("namespace foobarbaz {\n" - "}\n", getGoogleJSStyleWithColumns(10)); - verifyFormat("module foobarbaz {\n" - "}\n", getGoogleJSStyleWithColumns(7)); -} - -TEST_F(FormatTestJS, AmbientDeclarations) { - FormatStyle NineCols = getGoogleJSStyleWithColumns(9); - verifyFormat( - "declare class\n" - " X {}", - NineCols); - verifyFormat( - "declare function\n" - "x();", // TODO(martinprobst): should ideally be indented. - NineCols); - verifyFormat("declare function foo();\n" - "let x = 1;\n"); - verifyFormat("declare function foo(): string;\n" - "let x = 1;\n"); - verifyFormat("declare function foo(): {x: number};\n" - "let x = 1;\n"); - verifyFormat("declare class X {}\n" - "let x = 1;\n"); - verifyFormat("declare interface Y {}\n" - "let x = 1;\n"); - verifyFormat( - "declare enum X {\n" - "}", - NineCols); - verifyFormat( - "declare let\n" - " x: number;", - NineCols); -} - -TEST_F(FormatTestJS, FormatsFreestandingFunctions) { - verifyFormat("function outer1(a, b) {\n" - " function inner1(a, b) {\n" - " return a;\n" - " }\n" - " inner1(a, b);\n" - "}\n" - "function outer2(a, b) {\n" - " function inner2(a, b) {\n" - " return a;\n" - " }\n" - " inner2(a, b);\n" - "}"); - verifyFormat("function f() {}"); - verifyFormat("function aFunction() {}\n" - "(function f() {\n" - " var x = 1;\n" - "}());\n"); - verifyFormat("function aFunction() {}\n" - "{\n" - " let x = 1;\n" - " console.log(x);\n" - "}\n"); -} - -TEST_F(FormatTestJS, GeneratorFunctions) { - verifyFormat("function* f() {\n" - " let x = 1;\n" - " yield x;\n" - " yield* something();\n" - " yield [1, 2];\n" - " yield {a: 1};\n" - "}"); - verifyFormat("function*\n" - " f() {\n" - "}", - getGoogleJSStyleWithColumns(8)); - verifyFormat("export function* f() {\n" - " yield 1;\n" - "}\n"); - verifyFormat("class X {\n" - " * generatorMethod() {\n" - " yield x;\n" - " }\n" - "}"); - verifyFormat("var x = {\n" - " a: function*() {\n" - " //\n" - " }\n" - "}\n"); -} - -TEST_F(FormatTestJS, AsyncFunctions) { - verifyFormat("async function f() {\n" - " let x = 1;\n" - " return fetch(x);\n" - "}"); - verifyFormat("async function f() {\n" - " return 1;\n" - "}\n" - "\n" - "function a() {\n" - " return 1;\n" - "}\n", - " async function f() {\n" - " return 1;\n" - "}\n" - "\n" - " function a() {\n" - " return 1;\n" - "} \n"); - verifyFormat("async function* f() {\n" - " yield fetch(x);\n" - "}"); - verifyFormat("export async function f() {\n" - " return fetch(x);\n" - "}"); - verifyFormat("let x = async () => f();"); - verifyFormat("let x = async function() {\n" - " f();\n" - "};"); - verifyFormat("let x = async();"); - verifyFormat("class X {\n" - " async asyncMethod() {\n" - " return fetch(1);\n" - " }\n" - "}"); - verifyFormat("function initialize() {\n" - " // Comment.\n" - " return async.then();\n" - "}\n"); - verifyFormat("for await (const x of y) {\n" - " console.log(x);\n" - "}\n"); - verifyFormat("function asyncLoop() {\n" - " for await (const x of y) {\n" - " console.log(x);\n" - " }\n" - "}\n"); -} - -TEST_F(FormatTestJS, FunctionParametersTrailingComma) { - verifyFormat("function trailingComma(\n" - " p1,\n" - " p2,\n" - " p3,\n" - ") {\n" - " a; //\n" - "}\n", - "function trailingComma(p1, p2, p3,) {\n" - " a; //\n" - "}\n"); - verifyFormat("trailingComma(\n" - " p1,\n" - " p2,\n" - " p3,\n" - ");\n", - "trailingComma(p1, p2, p3,);\n"); - verifyFormat("trailingComma(\n" - " p1 // hello\n" - ");\n", - "trailingComma(p1 // hello\n" - ");\n"); -} - -TEST_F(FormatTestJS, ArrayLiterals) { - verifyFormat("var aaaaa: List<SomeThing> =\n" - " [new SomeThingAAAAAAAAAAAA(), new SomeThingBBBBBBBBB()];"); - verifyFormat("return [\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" - " ccccccccccccccccccccccccccc\n" - "];"); - verifyFormat("return [\n" - " aaaa().bbbbbbbb('A'),\n" - " aaaa().bbbbbbbb('B'),\n" - " aaaa().bbbbbbbb('C'),\n" - "];"); - verifyFormat("var someVariable = SomeFunction([\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" - " ccccccccccccccccccccccccccc\n" - "]);"); - verifyFormat("var someVariable = SomeFunction([\n" - " [aaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbb],\n" - "]);", - getGoogleJSStyleWithColumns(51)); - verifyFormat("var someVariable = SomeFunction(aaaa, [\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" - " ccccccccccccccccccccccccccc\n" - "]);"); - verifyFormat("var someVariable = SomeFunction(\n" - " aaaa,\n" - " [\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbbbbbb,\n" - " cccccccccccccccccccccccccc\n" - " ],\n" - " aaaa);"); - verifyFormat("var aaaa = aaaaa || // wrap\n" - " [];"); - - verifyFormat("someFunction([], {a: a});"); - - verifyFormat("var string = [\n" - " 'aaaaaa',\n" - " 'bbbbbb',\n" - "].join('+');"); -} - -TEST_F(FormatTestJS, ColumnLayoutForArrayLiterals) { - verifyFormat("var array = [\n" - " a, a, a, a, a, a, a, a, a, a, a, a, a, a, a,\n" - " a, a, a, a, a, a, a, a, a, a, a, a, a, a, a,\n" - "];"); - verifyFormat("var array = someFunction([\n" - " a, a, a, a, a, a, a, a, a, a, a, a, a, a, a,\n" - " a, a, a, a, a, a, a, a, a, a, a, a, a, a, a,\n" - "]);"); -} - -TEST_F(FormatTestJS, FunctionLiterals) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript); - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline; - verifyFormat("doFoo(function() {});"); - verifyFormat("doFoo(function() { return 1; });", Style); - verifyFormat("var func = function() {\n" - " return 1;\n" - "};"); - verifyFormat("var func = //\n" - " function() {\n" - " return 1;\n" - "};"); - verifyFormat("return {\n" - " body: {\n" - " setAttribute: function(key, val) { this[key] = val; },\n" - " getAttribute: function(key) { return this[key]; },\n" - " style: {direction: ''}\n" - " }\n" - "};", - Style); - verifyFormat("abc = xyz ? function() {\n" - " return 1;\n" - "} : function() {\n" - " return -1;\n" - "};"); - - verifyFormat("var closure = goog.bind(\n" - " function() { // comment\n" - " foo();\n" - " bar();\n" - " },\n" - " this, arg1IsReallyLongAndNeedsLineBreaks,\n" - " arg3IsReallyLongAndNeedsLineBreaks);"); - verifyFormat("var closure = goog.bind(function() { // comment\n" - " foo();\n" - " bar();\n" - "}, this);"); - verifyFormat("return {\n" - " a: 'E',\n" - " b: function() {\n" - " return function() {\n" - " f(); //\n" - " };\n" - " }\n" - "};"); - verifyFormat("{\n" - " var someVariable = function(x) {\n" - " return x.zIsTooLongForOneLineWithTheDeclarationLine();\n" - " };\n" - "}"); - verifyFormat("someLooooooooongFunction(\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " function(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" - " // code\n" - " });"); - - verifyFormat("return {\n" - " a: function SomeFunction() {\n" - " // ...\n" - " return 1;\n" - " }\n" - "};"); - verifyFormat("this.someObject.doSomething(aaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " .then(goog.bind(function(aaaaaaaaaaa) {\n" - " someFunction();\n" - " someFunction();\n" - " }, this), aaaaaaaaaaaaaaaaa);"); - - verifyFormat("someFunction(goog.bind(function() {\n" - " doSomething();\n" - " doSomething();\n" - "}, this), goog.bind(function() {\n" - " doSomething();\n" - " doSomething();\n" - "}, this));"); - - verifyFormat("SomeFunction(function() {\n" - " foo();\n" - " bar();\n" - "}.bind(this));"); - - verifyFormat("SomeFunction((function() {\n" - " foo();\n" - " bar();\n" - " }).bind(this));"); - - // FIXME: This is bad, we should be wrapping before "function() {". - verifyFormat("someFunction(function() {\n" - " doSomething(); // break\n" - "})\n" - " .doSomethingElse(\n" - " // break\n" - " );"); - - Style.ColumnLimit = 33; - verifyFormat("f({a: function() { return 1; }});", Style); - Style.ColumnLimit = 32; - verifyFormat("f({\n" - " a: function() { return 1; }\n" - "});", - Style); - -} - -TEST_F(FormatTestJS, DontWrapEmptyLiterals) { - verifyFormat("(aaaaaaaaaaaaaaaaaaaaa.getData as jasmine.Spy)\n" - " .and.returnValue(Observable.of([]));"); - verifyFormat("(aaaaaaaaaaaaaaaaaaaaa.getData as jasmine.Spy)\n" - " .and.returnValue(Observable.of({}));"); - verifyFormat("(aaaaaaaaaaaaaaaaaaaaa.getData as jasmine.Spy)\n" - " .and.returnValue(Observable.of(()));"); -} - -TEST_F(FormatTestJS, InliningFunctionLiterals) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript); - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline; - verifyFormat("var func = function() {\n" - " return 1;\n" - "};", - Style); - verifyFormat("var func = doSomething(function() { return 1; });", Style); - verifyFormat("var outer = function() {\n" - " var inner = function() { return 1; }\n" - "};", - Style); - verifyFormat("function outer1(a, b) {\n" - " function inner1(a, b) { return a; }\n" - "}", - Style); - - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All; - verifyFormat("var func = function() { return 1; };", Style); - verifyFormat("var func = doSomething(function() { return 1; });", Style); - verifyFormat( - "var outer = function() { var inner = function() { return 1; } };", - Style); - verifyFormat("function outer1(a, b) {\n" - " function inner1(a, b) { return a; }\n" - "}", - Style); - - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; - verifyFormat("var func = function() {\n" - " return 1;\n" - "};", - Style); - verifyFormat("var func = doSomething(function() {\n" - " return 1;\n" - "});", - Style); - verifyFormat("var outer = function() {\n" - " var inner = function() {\n" - " return 1;\n" - " }\n" - "};", - Style); - verifyFormat("function outer1(a, b) {\n" - " function inner1(a, b) {\n" - " return a;\n" - " }\n" - "}", - Style); - - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Empty; - verifyFormat("var func = function() {\n" - " return 1;\n" - "};", - Style); -} - -TEST_F(FormatTestJS, MultipleFunctionLiterals) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript); - Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All; - verifyFormat("promise.then(\n" - " function success() {\n" - " doFoo();\n" - " doBar();\n" - " },\n" - " function error() {\n" - " doFoo();\n" - " doBaz();\n" - " },\n" - " []);\n"); - verifyFormat("promise.then(\n" - " function success() {\n" - " doFoo();\n" - " doBar();\n" - " },\n" - " [],\n" - " function error() {\n" - " doFoo();\n" - " doBaz();\n" - " });\n"); - verifyFormat("promise.then(\n" - " [],\n" - " function success() {\n" - " doFoo();\n" - " doBar();\n" - " },\n" - " function error() {\n" - " doFoo();\n" - " doBaz();\n" - " });\n"); - - verifyFormat("getSomeLongPromise()\n" - " .then(function(value) { body(); })\n" - " .thenCatch(function(error) {\n" - " body();\n" - " body();\n" - " });", - Style); - verifyFormat("getSomeLongPromise()\n" - " .then(function(value) {\n" - " body();\n" - " body();\n" - " })\n" - " .thenCatch(function(error) {\n" - " body();\n" - " body();\n" - " });"); - - verifyFormat("getSomeLongPromise()\n" - " .then(function(value) { body(); })\n" - " .thenCatch(function(error) { body(); });", - Style); - - verifyFormat("return [aaaaaaaaaaaaaaaaaaaaaa]\n" - " .aaaaaaa(function() {\n" - " //\n" - " })\n" - " .bbbbbb();"); -} - -TEST_F(FormatTestJS, ArrowFunctions) { - verifyFormat("var x = (a) => {\n" - " return a;\n" - "};"); - verifyFormat("var x = (a) => {\n" - " function y() {\n" - " return 42;\n" - " }\n" - " return a;\n" - "};"); - verifyFormat("var x = (a: type): {some: type} => {\n" - " return a;\n" - "};"); - verifyFormat("var x = (a) => a;"); - verifyFormat("return () => [];"); - verifyFormat("var aaaaaaaaaaaaaaaaaaaa = {\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:\n" - " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) =>\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - "};"); - verifyFormat("var a = a.aaaaaaa(\n" - " (a: a) => aaaaaaaaaaaaaaaaaaaaaaaaa(bbbbbbbbb) &&\n" - " aaaaaaaaaaaaaaaaaaaaaaaaa(bbbbbbb));"); - verifyFormat("var a = a.aaaaaaa(\n" - " (a: a) => aaaaaaaaaaaaaaaaaaaaa(bbbbbbbbb) ?\n" - " aaaaaaaaaaaaaaaaaaaaa(bbbbbbb) :\n" - " aaaaaaaaaaaaaaaaaaaaa(bbbbbbb));"); - - // FIXME: This is bad, we should be wrapping before "() => {". - verifyFormat("someFunction(() => {\n" - " doSomething(); // break\n" - "})\n" - " .doSomethingElse(\n" - " // break\n" - " );"); - verifyFormat("const f = (x: string|null): string|null => {\n" - " return x;\n" - "}\n"); -} - -TEST_F(FormatTestJS, ReturnStatements) { - verifyFormat("function() {\n" - " return [hello, world];\n" - "}"); -} - -TEST_F(FormatTestJS, ForLoops) { - verifyFormat("for (var i in [2, 3]) {\n" - "}"); - verifyFormat("for (var i of [2, 3]) {\n" - "}"); - verifyFormat("for (let {a, b} of x) {\n" - "}"); - verifyFormat("for (let {a, b} of [x]) {\n" - "}"); - verifyFormat("for (let [a, b] of [x]) {\n" - "}"); - verifyFormat("for (let {a, b} in x) {\n" - "}"); -} - -TEST_F(FormatTestJS, WrapRespectsAutomaticSemicolonInsertion) { - // The following statements must not wrap, as otherwise the program meaning - // would change due to automatic semicolon insertion. - // See http://www.ecma-international.org/ecma-262/5.1/#sec-7.9.1. - verifyFormat("return aaaaa;", getGoogleJSStyleWithColumns(10)); - verifyFormat("yield aaaaa;", getGoogleJSStyleWithColumns(10)); - verifyFormat("return /* hello! */ aaaaa;", getGoogleJSStyleWithColumns(10)); - verifyFormat("continue aaaaa;", getGoogleJSStyleWithColumns(10)); - verifyFormat("continue /* hello! */ aaaaa;", getGoogleJSStyleWithColumns(10)); - verifyFormat("break aaaaa;", getGoogleJSStyleWithColumns(10)); - verifyFormat("throw aaaaa;", getGoogleJSStyleWithColumns(10)); - verifyFormat("aaaaaaaaa++;", getGoogleJSStyleWithColumns(10)); - verifyFormat("aaaaaaaaa--;", getGoogleJSStyleWithColumns(10)); - verifyFormat("return [\n" - " aaa\n" - "];", - getGoogleJSStyleWithColumns(12)); - verifyFormat("class X {\n" - " readonly ratherLongField =\n" - " 1;\n" - "}", - "class X {\n" - " readonly ratherLongField = 1;\n" - "}", - getGoogleJSStyleWithColumns(20)); - verifyFormat("const x = (5 + 9)\n" - "const y = 3\n", - "const x = ( 5 + 9)\n" - "const y = 3\n"); - // Ideally the foo() bit should be indented relative to the async function(). - verifyFormat("async function\n" - "foo() {}", - getGoogleJSStyleWithColumns(10)); - verifyFormat("await theReckoning;", getGoogleJSStyleWithColumns(10)); - verifyFormat("some['a']['b']", getGoogleJSStyleWithColumns(10)); - verifyFormat("x = (a['a']\n" - " ['b']);", - getGoogleJSStyleWithColumns(10)); - verifyFormat("function f() {\n" - " return foo.bar(\n" - " (param): param is {\n" - " a: SomeType\n" - " }&ABC => 1)\n" - "}", - getGoogleJSStyleWithColumns(25)); -} - -TEST_F(FormatTestJS, AddsIsTheDictKeyOnNewline) { - // Do not confuse is, the dict key with is, the type matcher. Put is, the dict - // key, on a newline. - verifyFormat("Polymer({\n" - " is: '', //\n" - " rest: 1\n" - "});", - getGoogleJSStyleWithColumns(20)); -} - -TEST_F(FormatTestJS, AutomaticSemicolonInsertionHeuristic) { - verifyFormat("a\n" - "b;", - " a \n" - " b ;"); - verifyFormat("a()\n" - "b;", - " a ()\n" - " b ;"); - verifyFormat("a[b]\n" - "c;", - "a [b]\n" - "c ;"); - verifyFormat("1\n" - "a;", - "1 \n" - "a ;"); - verifyFormat("a\n" - "1;", - "a \n" - "1 ;"); - verifyFormat("a\n" - "'x';", - "a \n" - " 'x';"); - verifyFormat("a++\n" - "b;", - "a ++\n" - "b ;"); - verifyFormat("a\n" - "!b && c;", - "a \n" - " ! b && c;"); - verifyFormat("a\n" - "if (1) f();", - " a\n" - " if (1) f();"); - verifyFormat("a\n" - "class X {}", - " a\n" - " class X {}"); - verifyFormat("var a", "var\n" - "a"); - verifyFormat("x instanceof String", "x\n" - "instanceof\n" - "String"); - verifyFormat("function f(@Foo bar) {}", "function f(@Foo\n" - " bar) {}"); - verifyFormat("function f(@Foo(Param) bar) {}", "function f(@Foo(Param)\n" - " bar) {}"); - verifyFormat("a = true\n" - "return 1", - "a = true\n" - " return 1"); - verifyFormat("a = 's'\n" - "return 1", - "a = 's'\n" - " return 1"); - verifyFormat("a = null\n" - "return 1", - "a = null\n" - " return 1"); - // Below "class Y {}" should ideally be on its own line. - verifyFormat( - "x = {\n" - " a: 1\n" - "} class Y {}", - " x = {a : 1}\n" - " class Y { }"); - verifyFormat( - "if (x) {\n" - "}\n" - "return 1", - "if (x) {}\n" - " return 1"); - verifyFormat( - "if (x) {\n" - "}\n" - "class X {}", - "if (x) {}\n" - " class X {}"); -} - -TEST_F(FormatTestJS, ImportExportASI) { - verifyFormat( - "import {x} from 'y'\n" - "export function z() {}", - "import {x} from 'y'\n" - " export function z() {}"); - // Below "class Y {}" should ideally be on its own line. - verifyFormat( - "export {x} class Y {}", - " export {x}\n" - " class Y {\n}"); - verifyFormat( - "if (x) {\n" - "}\n" - "export class Y {}", - "if ( x ) { }\n" - " export class Y {}"); -} - -TEST_F(FormatTestJS, ClosureStyleCasts) { - verifyFormat("var x = /** @type {foo} */ (bar);"); -} - -TEST_F(FormatTestJS, TryCatch) { - verifyFormat("try {\n" - " f();\n" - "} catch (e) {\n" - " g();\n" - "} finally {\n" - " h();\n" - "}"); - - // But, of course, "catch" is a perfectly fine function name in JavaScript. - verifyFormat("someObject.catch();"); - verifyFormat("someObject.new();"); -} - -TEST_F(FormatTestJS, StringLiteralConcatenation) { - verifyFormat("var literal = 'hello ' +\n" - " 'world';"); -} - -TEST_F(FormatTestJS, RegexLiteralClassification) { - // Regex literals. - verifyFormat("var regex = /abc/;"); - verifyFormat("f(/abc/);"); - verifyFormat("f(abc, /abc/);"); - verifyFormat("some_map[/abc/];"); - verifyFormat("var x = a ? /abc/ : /abc/;"); - verifyFormat("for (var i = 0; /abc/.test(s[i]); i++) {\n}"); - verifyFormat("var x = !/abc/.test(y);"); - verifyFormat("var x = foo()! / 10;"); - verifyFormat("var x = a && /abc/.test(y);"); - verifyFormat("var x = a || /abc/.test(y);"); - verifyFormat("var x = a + /abc/.search(y);"); - verifyFormat("/abc/.search(y);"); - verifyFormat("var regexs = {/abc/, /abc/};"); - verifyFormat("return /abc/;"); - - // Not regex literals. - verifyFormat("var a = a / 2 + b / 3;"); - verifyFormat("var a = a++ / 2;"); - // Prefix unary can operate on regex literals, not that it makes sense. - verifyFormat("var a = ++/a/;"); - - // This is a known issue, regular expressions are incorrectly detected if - // directly following a closing parenthesis. - verifyFormat("if (foo) / bar /.exec(baz);"); -} - -TEST_F(FormatTestJS, RegexLiteralSpecialCharacters) { - verifyFormat("var regex = /=/;"); - verifyFormat("var regex = /a*/;"); - verifyFormat("var regex = /a+/;"); - verifyFormat("var regex = /a?/;"); - verifyFormat("var regex = /.a./;"); - verifyFormat("var regex = /a\\*/;"); - verifyFormat("var regex = /^a$/;"); - verifyFormat("var regex = /\\/a/;"); - verifyFormat("var regex = /(?:x)/;"); - verifyFormat("var regex = /x(?=y)/;"); - verifyFormat("var regex = /x(?!y)/;"); - verifyFormat("var regex = /x|y/;"); - verifyFormat("var regex = /a{2}/;"); - verifyFormat("var regex = /a{1,3}/;"); - - verifyFormat("var regex = /[abc]/;"); - verifyFormat("var regex = /[^abc]/;"); - verifyFormat("var regex = /[\\b]/;"); - verifyFormat("var regex = /[/]/;"); - verifyFormat("var regex = /[\\/]/;"); - verifyFormat("var regex = /\\[/;"); - verifyFormat("var regex = /\\\\[/]/;"); - verifyFormat("var regex = /}[\"]/;"); - verifyFormat("var regex = /}[/\"]/;"); - verifyFormat("var regex = /}[\"/]/;"); - - verifyFormat("var regex = /\\b/;"); - verifyFormat("var regex = /\\B/;"); - verifyFormat("var regex = /\\d/;"); - verifyFormat("var regex = /\\D/;"); - verifyFormat("var regex = /\\f/;"); - verifyFormat("var regex = /\\n/;"); - verifyFormat("var regex = /\\r/;"); - verifyFormat("var regex = /\\s/;"); - verifyFormat("var regex = /\\S/;"); - verifyFormat("var regex = /\\t/;"); - verifyFormat("var regex = /\\v/;"); - verifyFormat("var regex = /\\w/;"); - verifyFormat("var regex = /\\W/;"); - verifyFormat("var regex = /a(a)\\1/;"); - verifyFormat("var regex = /\\0/;"); - verifyFormat("var regex = /\\\\/g;"); - verifyFormat("var regex = /\\a\\\\/g;"); - verifyFormat("var regex = /\a\\//g;"); - verifyFormat("var regex = /a\\//;\n" - "var x = 0;"); - verifyFormat("var regex = /'/g;", "var regex = /'/g ;"); - verifyFormat("var regex = /'/g; //'", "var regex = /'/g ; //'"); - verifyFormat("var regex = /\\/*/;\n" - "var x = 0;", - "var regex = /\\/*/;\n" - "var x=0;"); - verifyFormat("var x = /a\\//;", "var x = /a\\// \n;"); - verifyFormat("var regex = /\"/;", getGoogleJSStyleWithColumns(16)); - verifyFormat("var regex =\n" - " /\"/;", - getGoogleJSStyleWithColumns(15)); - verifyFormat("var regex = //\n" - " /a/;"); - verifyFormat("var regexs = [\n" - " /d/, //\n" - " /aa/, //\n" - "];"); -} - -TEST_F(FormatTestJS, RegexLiteralModifiers) { - verifyFormat("var regex = /abc/g;"); - verifyFormat("var regex = /abc/i;"); - verifyFormat("var regex = /abc/m;"); - verifyFormat("var regex = /abc/y;"); -} - -TEST_F(FormatTestJS, RegexLiteralLength) { - verifyFormat("var regex = /aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;", - getGoogleJSStyleWithColumns(60)); - verifyFormat("var regex =\n" - " /aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;", - getGoogleJSStyleWithColumns(60)); - verifyFormat("var regex = /\\xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/;", - getGoogleJSStyleWithColumns(50)); -} - -TEST_F(FormatTestJS, RegexLiteralExamples) { - verifyFormat("var regex = search.match(/(?:\?|&)times=([^?&]+)/i);"); -} - -TEST_F(FormatTestJS, IgnoresMpegTS) { - std::string MpegTS(200, ' '); - MpegTS.replace(0, strlen("nearlyLooks + like + ts + code; "), - "nearlyLooks + like + ts + code; "); - MpegTS[0] = 0x47; - MpegTS[188] = 0x47; - verifyFormat(MpegTS, MpegTS); -} - -TEST_F(FormatTestJS, TypeAnnotations) { - verifyFormat("var x: string;"); - verifyFormat("var x: {a: string; b: number;} = {};"); - verifyFormat("function x(): string {\n return 'x';\n}"); - verifyFormat("function x(): {x: string} {\n return {x: 'x'};\n}"); - verifyFormat("function x(y: string): string {\n return 'x';\n}"); - verifyFormat("for (var y: string in x) {\n x();\n}"); - verifyFormat("for (var y: string of x) {\n x();\n}"); - verifyFormat("function x(y: {a?: number;} = {}): number {\n" - " return 12;\n" - "}"); - verifyFormat("const x: Array<{a: number; b: string;}> = [];"); - verifyFormat("((a: string, b: number): string => a + b);"); - verifyFormat("var x: (y: number) => string;"); - verifyFormat("var x: P<string, (a: number) => string>;"); - verifyFormat("var x = {\n" - " y: function(): z {\n" - " return 1;\n" - " }\n" - "};"); - verifyFormat("var x = {\n" - " y: function(): {a: number} {\n" - " return 1;\n" - " }\n" - "};"); - verifyFormat("function someFunc(args: string[]):\n" - " {longReturnValue: string[]} {}", - getGoogleJSStyleWithColumns(60)); - verifyFormat( - "var someValue = (v as aaaaaaaaaaaaaaaaaaaa<T>[])\n" - " .someFunction(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("const xIsALongIdent:\n"" YJustBarelyFitsLinex[];", - getGoogleJSStyleWithColumns(20)); -} - -TEST_F(FormatTestJS, UnionIntersectionTypes) { - verifyFormat("let x: A|B = A | B;"); - verifyFormat("let x: A&B|C = A & B;"); - verifyFormat("let x: Foo<A|B> = new Foo<A|B>();"); - verifyFormat("function(x: A|B): C&D {}"); - verifyFormat("function(x: A|B = A | B): C&D {}"); - verifyFormat("function x(path: number|string) {}"); - verifyFormat("function x(): string|number {}"); - verifyFormat("type Foo = Bar|Baz;"); - verifyFormat("type Foo = Bar<X>|Baz;"); - verifyFormat("type Foo = (Bar<X>|Baz);"); - verifyFormat("let x: Bar|Baz;"); - verifyFormat("let x: Bar<X>|Baz;"); - verifyFormat("let x: (Foo|Bar)[];"); - verifyFormat("type X = {\n" - " a: Foo|Bar;\n" - "};"); - verifyFormat("export type X = {\n" - " a: Foo|Bar;\n" - "};"); -} - -TEST_F(FormatTestJS, UnionIntersectionTypesInObjectType) { - verifyFormat("let x: {x: number|null} = {x: number | null};"); - verifyFormat("let nested: {x: {y: number|null}};"); - verifyFormat("let mixed: {x: [number|null, {w: number}]};"); - verifyFormat("class X {\n" - " contructor(x: {\n" - " a: a|null,\n" - " b: b|null,\n" - " }) {}\n" - "}"); -} - -TEST_F(FormatTestJS, ClassDeclarations) { - verifyFormat("class C {\n x: string = 12;\n}"); - verifyFormat("class C {\n x(): string => 12;\n}"); - verifyFormat("class C {\n ['x' + 2]: string = 12;\n}"); - verifyFormat("class C {\n" - " foo() {}\n" - " [bar]() {}\n" - "}\n"); - verifyFormat("class C {\n private x: string = 12;\n}"); - verifyFormat("class C {\n private static x: string = 12;\n}"); - verifyFormat("class C {\n static x(): string {\n return 'asd';\n }\n}"); - verifyFormat("class C extends P implements I {}"); - verifyFormat("class C extends p.P implements i.I {}"); - verifyFormat( - "x(class {\n" - " a(): A {}\n" - "});"); - verifyFormat("class Test {\n" - " aaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa: aaaaaaaaaaaaaaaaaaaa):\n" - " aaaaaaaaaaaaaaaaaaaaaa {}\n" - "}"); - verifyFormat("foo = class Name {\n" - " constructor() {}\n" - "};"); - verifyFormat("foo = class {\n" - " constructor() {}\n" - "};"); - verifyFormat("class C {\n" - " x: {y: Z;} = {};\n" - " private y: {y: Z;} = {};\n" - "}"); - - // ':' is not a type declaration here. - verifyFormat("class X {\n" - " subs = {\n" - " 'b': {\n" - " 'c': 1,\n" - " },\n" - " };\n" - "}"); - verifyFormat("@Component({\n" - " moduleId: module.id,\n" - "})\n" - "class SessionListComponent implements OnDestroy, OnInit {\n" - "}"); -} - -TEST_F(FormatTestJS, StrictPropInitWrap) { - const FormatStyle &Style = getGoogleJSStyleWithColumns(22); - verifyFormat("class X {\n" - " strictPropInitField!:\n" - " string;\n" - "}", - Style); -} - -TEST_F(FormatTestJS, InterfaceDeclarations) { - verifyFormat("interface I {\n" - " x: string;\n" - " enum: string[];\n" - " enum?: string[];\n" - "}\n" - "var y;"); - // Ensure that state is reset after parsing the interface. - verifyFormat("interface a {}\n" - "export function b() {}\n" - "var x;"); - - // Arrays of object type literals. - verifyFormat("interface I {\n" - " o: {}[];\n" - "}"); -} - -TEST_F(FormatTestJS, ObjectTypesInExtendsImplements) { - verifyFormat("class C extends {} {}"); - verifyFormat("class C implements {bar: number} {}"); - // Somewhat odd, but probably closest to reasonable formatting? - verifyFormat("class C implements {\n" - " bar: number,\n" - " baz: string,\n" - "} {}"); - verifyFormat("class C<P extends {}> {}"); -} - -TEST_F(FormatTestJS, EnumDeclarations) { - verifyFormat("enum Foo {\n" - " A = 1,\n" - " B\n" - "}"); - verifyFormat("export /* somecomment*/ enum Foo {\n" - " A = 1,\n" - " B\n" - "}"); - verifyFormat("enum Foo {\n" - " A = 1, // comment\n" - " B\n" - "}\n" - "var x = 1;"); - verifyFormat("const enum Foo {\n" - " A = 1,\n" - " B\n" - "}"); - verifyFormat("export const enum Foo {\n" - " A = 1,\n" - " B\n" - "}"); -} - -TEST_F(FormatTestJS, Decorators) { - verifyFormat("@A\nclass C {\n}"); - verifyFormat("@A({arg: 'value'})\nclass C {\n}"); - verifyFormat("@A\n@B\nclass C {\n}"); - verifyFormat("class C {\n @A x: string;\n}"); - verifyFormat("class C {\n" - " @A\n" - " private x(): string {\n" - " return 'y';\n" - " }\n" - "}"); - verifyFormat("class C {\n" - " private x(@A x: string) {}\n" - "}"); - verifyFormat("class X {}\n" - "class Y {}"); - verifyFormat("class X {\n" - " @property() private isReply = false;\n" - "}\n"); -} - -TEST_F(FormatTestJS, TypeAliases) { - verifyFormat("type X = number;\n" - "class C {}"); - verifyFormat("type X<Y> = Z<Y>;"); - verifyFormat("type X = {\n" - " y: number\n" - "};\n" - "class C {}"); - verifyFormat("export type X = {\n" - " a: string,\n" - " b?: string,\n" - "};\n"); -} - -TEST_F(FormatTestJS, TypeInterfaceLineWrapping) { - const FormatStyle &Style = getGoogleJSStyleWithColumns(20); - verifyFormat("type LongTypeIsReallyUnreasonablyLong =\n" - " string;\n", - "type LongTypeIsReallyUnreasonablyLong = string;\n", - Style); - verifyFormat( - "interface AbstractStrategyFactoryProvider {\n" - " a: number\n" - "}\n", - "interface AbstractStrategyFactoryProvider { a: number }\n", - Style); -} - -TEST_F(FormatTestJS, RemoveEmptyLinesInArrowFunctions) { - verifyFormat("x = () => {\n" - " foo();\n" - "};\n", - "x = () => {\n" - "\n" - " foo();\n" - "\n" - "};\n"); -} - -TEST_F(FormatTestJS, Modules) { - verifyFormat("import SomeThing from 'some/module.js';"); - verifyFormat("import {X, Y} from 'some/module.js';"); - verifyFormat("import a, {X, Y} from 'some/module.js';"); - verifyFormat("import {X, Y,} from 'some/module.js';"); - verifyFormat("import {X as myLocalX, Y as myLocalY} from 'some/module.js';"); - // Ensure Automatic Semicolon Insertion does not break on "as\n". - verifyFormat("import {X as myX} from 'm';", "import {X as\n" - " myX} from 'm';"); - verifyFormat("import * as lib from 'some/module.js';"); - verifyFormat("var x = {import: 1};\nx.import = 2;"); - - verifyFormat("export function fn() {\n" - " return 'fn';\n" - "}"); - verifyFormat("export function A() {}\n" - "export default function B() {}\n" - "export function C() {}"); - verifyFormat("export default () => {\n" - " let x = 1;\n" - " return x;\n" - "}"); - verifyFormat("export const x = 12;"); - verifyFormat("export default class X {}"); - verifyFormat("export {X, Y} from 'some/module.js';"); - verifyFormat("export {X, Y,} from 'some/module.js';"); - verifyFormat("export {SomeVeryLongExport as X, " - "SomeOtherVeryLongExport as Y} from 'some/module.js';"); - // export without 'from' is wrapped. - verifyFormat("export let someRatherLongVariableName =\n" - " someSurprisinglyLongVariable + someOtherRatherLongVar;"); - // ... but not if from is just an identifier. - verifyFormat("export {\n" - " from as from,\n" - " someSurprisinglyLongVariable as\n" - " from\n" - "};", - getGoogleJSStyleWithColumns(20)); - verifyFormat("export class C {\n" - " x: number;\n" - " y: string;\n" - "}"); - verifyFormat("export class X {\n" - " y: number;\n" - "}"); - verifyFormat("export abstract class X {\n" - " y: number;\n" - "}"); - verifyFormat("export default class X {\n" - " y: number\n" - "}"); - verifyFormat("export default function() {\n return 1;\n}"); - verifyFormat("export var x = 12;"); - verifyFormat("class C {}\n" - "export function f() {}\n" - "var v;"); - verifyFormat("export var x: number = 12;"); - verifyFormat("export const y = {\n" - " a: 1,\n" - " b: 2\n" - "};"); - verifyFormat("export enum Foo {\n" - " BAR,\n" - " // adsdasd\n" - " BAZ\n" - "}"); - verifyFormat("export default [\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" - "];"); - verifyFormat("export default [];"); - verifyFormat("export default () => {};"); - verifyFormat("export interface Foo {\n" - " foo: number;\n" - "}\n" - "export class Bar {\n" - " blah(): string {\n" - " return this.blah;\n" - " };\n" - "}"); -} - -TEST_F(FormatTestJS, ImportWrapping) { - verifyFormat("import {VeryLongImportsAreAnnoying, VeryLongImportsAreAnnoying," - " VeryLongImportsAreAnnoying, VeryLongImportsAreAnnoying" - "} from 'some/module.js';"); - FormatStyle Style = getGoogleJSStyleWithColumns(80); - Style.JavaScriptWrapImports = true; - verifyFormat("import {\n" - " VeryLongImportsAreAnnoying,\n" - " VeryLongImportsAreAnnoying,\n" - " VeryLongImportsAreAnnoying,\n" - "} from 'some/module.js';", - Style); - verifyFormat("import {\n" - " A,\n" - " A,\n" - "} from 'some/module.js';", - Style); - verifyFormat("export {\n" - " A,\n" - " A,\n" - "} from 'some/module.js';", - Style); - Style.ColumnLimit = 40; - // Using this version of verifyFormat because test::messUp hides the issue. - verifyFormat("import {\n" - " A,\n" - "} from\n" - " 'some/path/longer/than/column/limit/module.js';", - " import { \n" - " A, \n" - " } from\n" - " 'some/path/longer/than/column/limit/module.js' ; ", - Style); -} - -TEST_F(FormatTestJS, TemplateStrings) { - // Keeps any whitespace/indentation within the template string. - verifyFormat("var x = `hello\n" - " ${name}\n" - " !`;", - "var x = `hello\n" - " ${ name }\n" - " !`;"); - - verifyFormat("var x =\n" - " `hello ${world}` >= some();", - getGoogleJSStyleWithColumns(34)); // Barely doesn't fit. - verifyFormat("var x = `hello ${world}` >= some();", - getGoogleJSStyleWithColumns(35)); // Barely fits. - verifyFormat("var x = `hellö ${wörld}` >= söme();", - getGoogleJSStyleWithColumns(35)); // Fits due to UTF-8. - verifyFormat("var x = `hello\n" - " ${world}` >=\n" - " some();", - "var x =\n" - " `hello\n" - " ${world}` >= some();", - getGoogleJSStyleWithColumns(21)); // Barely doesn't fit. - verifyFormat("var x = `hello\n" - " ${world}` >= some();", - "var x =\n" - " `hello\n" - " ${world}` >= some();", - getGoogleJSStyleWithColumns(22)); // Barely fits. - - verifyFormat("var x =\n" - " `h`;", - getGoogleJSStyleWithColumns(11)); - verifyFormat("var x =\n `multi\n line`;", "var x = `multi\n line`;", - getGoogleJSStyleWithColumns(13)); - verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" - " `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa`);"); - // Repro for an obscure width-miscounting issue with template strings. - verifyFormat( - "someLongVariable =\n" - " " - "`${logPrefix[11]}/${logPrefix[12]}/${logPrefix[13]}${logPrefix[14]}`;", - "someLongVariable = " - "`${logPrefix[11]}/${logPrefix[12]}/${logPrefix[13]}${logPrefix[14]}`;"); - - // Make sure template strings get a proper ColumnWidth assigned, even if they - // are first token in line. - verifyFormat( - "var a = aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" - " `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa`;"); - - // Two template strings. - verifyFormat("var x = `hello` == `hello`;"); - - // Comments in template strings. - verifyFormat("var x = `//a`;\n" - "var y;", - "var x =\n `//a`;\n" - "var y ;"); - verifyFormat("var x = `/*a`;\n" - "var y;", - "var x =\n `/*a`;\n" - "var y;"); - // Unterminated string literals in a template string. - verifyFormat("var x = `'`; // comment with matching quote '\n" - "var y;"); - verifyFormat("var x = `\"`; // comment with matching quote \"\n" - "var y;"); - verifyFormat("it(`'aaaaaaaaaaaaaaa `, aaaaaaaaa);", - "it(`'aaaaaaaaaaaaaaa `, aaaaaaaaa) ;", - getGoogleJSStyleWithColumns(40)); - // Backticks in a comment - not a template string. - verifyFormat("var x = 1 // `/*a`;\n" - " ;", - "var x =\n 1 // `/*a`;\n" - " ;"); - verifyFormat("/* ` */ var x = 1; /* ` */", "/* ` */ var x\n= 1; /* ` */"); - // Comment spans multiple template strings. - verifyFormat("var x = `/*a`;\n" - "var y = ` */ `;", - "var x =\n `/*a`;\n" - "var y =\n ` */ `;"); - // Escaped backtick. - verifyFormat("var x = ` \\` a`;\n" - "var y;", - "var x = ` \\` a`;\n" - "var y;"); - // Escaped dollar. - verifyFormat("var x = ` \\${foo}`;\n"); - - // The token stream can contain two string_literals in sequence, but that - // doesn't mean that they are implicitly concatenated in JavaScript. - verifyFormat("var f = `aaaa ${a ? 'a' : 'b'}`;"); - - // Ensure that scopes are appropriately set around evaluated expressions in - // template strings. - verifyFormat("var f = `aaaaaaaaaaaaa:${aaaaaaa.aaaaa} aaaaaaaa\n" - " aaaaaaaaaaaaa:${aaaaaaa.aaaaa} aaaaaaaa`;", - "var f = `aaaaaaaaaaaaa:${aaaaaaa. aaaaa} aaaaaaaa\n" - " aaaaaaaaaaaaa:${ aaaaaaa. aaaaa} aaaaaaaa`;"); - verifyFormat("var x = someFunction(`${})`) //\n" - " .oooooooooooooooooon();"); - verifyFormat("var x = someFunction(`${aaaa}${\n" - " aaaaa( //\n" - " aaaaa)})`);"); -} - -TEST_F(FormatTestJS, TemplateStringMultiLineExpression) { - verifyFormat("var f = `aaaaaaaaaaaaaaaaaa: ${\n" - " aaaaa + //\n" - " bbbb}`;", - "var f = `aaaaaaaaaaaaaaaaaa: ${aaaaa + //\n" - " bbbb}`;"); - verifyFormat("var f = `\n" - " aaaaaaaaaaaaaaaaaa: ${\n" - " aaaaa + //\n" - " bbbb}`;", - "var f = `\n" - " aaaaaaaaaaaaaaaaaa: ${ aaaaa + //\n" - " bbbb }`;"); - verifyFormat("var f = `\n" - " aaaaaaaaaaaaaaaaaa: ${\n" - " someFunction(\n" - " aaaaa + //\n" - " bbbb)}`;", - "var f = `\n" - " aaaaaaaaaaaaaaaaaa: ${someFunction (\n" - " aaaaa + //\n" - " bbbb)}`;"); - - // It might be preferable to wrap before "someFunction". - verifyFormat("var f = `\n" - " aaaaaaaaaaaaaaaaaa: ${someFunction({\n" - " aaaa: aaaaa,\n" - " bbbb: bbbbb,\n" - "})}`;", - "var f = `\n" - " aaaaaaaaaaaaaaaaaa: ${someFunction ({\n" - " aaaa: aaaaa,\n" - " bbbb: bbbbb,\n" - " })}`;"); -} - -TEST_F(FormatTestJS, TemplateStringASI) { - verifyFormat("var x = `hello${world}`;", "var x = `hello${\n" - " world\n" - "}`;"); -} - -TEST_F(FormatTestJS, NestedTemplateStrings) { - verifyFormat( - "var x = `<ul>${xs.map(x => `<li>${x}</li>`).join('\\n')}</ul>`;"); - verifyFormat("var x = `he${({text: 'll'}.text)}o`;"); - - // Crashed at some point. - verifyFormat("}"); -} - -TEST_F(FormatTestJS, TaggedTemplateStrings) { - verifyFormat("var x = html`<ul>`;"); - verifyFormat("yield `hello`;"); -} - -TEST_F(FormatTestJS, CastSyntax) { - verifyFormat("var x = <type>foo;"); - verifyFormat("var x = foo as type;"); - verifyFormat("let x = (a + b) as\n" - " LongTypeIsLong;", - getGoogleJSStyleWithColumns(20)); - verifyFormat("foo = <Bar[]>[\n" - " 1, //\n" - " 2\n" - "];"); - verifyFormat("var x = [{x: 1} as type];"); - verifyFormat("x = x as [a, b];"); - verifyFormat("x = x as {a: string};"); - verifyFormat("x = x as (string);"); - verifyFormat("x = x! as (string);"); - verifyFormat("x = y! in z;"); - verifyFormat("var x = something.someFunction() as\n" - " something;", - getGoogleJSStyleWithColumns(40)); -} - -TEST_F(FormatTestJS, TypeArguments) { - verifyFormat("class X<Y> {}"); - verifyFormat("new X<Y>();"); - verifyFormat("foo<Y>(a);"); - verifyFormat("var x: X<Y>[];"); - verifyFormat("class C extends D<E> implements F<G>, H<I> {}"); - verifyFormat("function f(a: List<any> = null) {}"); - verifyFormat("function f(): List<any> {}"); - verifyFormat("function aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa():\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb {}"); - verifyFormat("function aaaaaaaaaa(\n" - " aaaaaaaaaaaaaaaa: aaaaaaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaaa: aaaaaaaaaaaaaaaaaaa):\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa {}"); -} - -TEST_F(FormatTestJS, UserDefinedTypeGuards) { - verifyFormat( - "function foo(check: Object):\n" - " check is {foo: string, bar: string, baz: string, foobar: string} {\n" - " return 'bar' in check;\n" - "}\n"); -} - -TEST_F(FormatTestJS, OptionalTypes) { - verifyFormat("function x(a?: b, c?, d?) {}"); - verifyFormat("class X {\n" - " y?: z;\n" - " z?;\n" - "}"); - verifyFormat("interface X {\n" - " y?(): z;\n" - "}"); - verifyFormat("constructor({aa}: {\n" - " aa?: string,\n" - " aaaaaaaa?: string,\n" - " aaaaaaaaaaaaaaa?: boolean,\n" - " aaaaaa?: List<string>\n" - "}) {}"); -} - -TEST_F(FormatTestJS, IndexSignature) { - verifyFormat("var x: {[k: string]: v};"); -} - -TEST_F(FormatTestJS, WrapAfterParen) { - verifyFormat("xxxxxxxxxxx(\n" - " aaa, aaa);", - getGoogleJSStyleWithColumns(20)); - verifyFormat("xxxxxxxxxxx(\n" - " aaa, aaa, aaa,\n" - " aaa, aaa, aaa);", - getGoogleJSStyleWithColumns(20)); - verifyFormat("xxxxxxxxxxx(\n" - " aaaaaaaaaaaaaaaaaaaaaaaa,\n" - " function(x) {\n" - " y(); //\n" - " });", - getGoogleJSStyleWithColumns(40)); - verifyFormat("while (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); -} - -TEST_F(FormatTestJS, JSDocAnnotations) { - verifyFormat("/**\n" - " * @exports {this.is.a.long.path.to.a.Type}\n" - " */", - "/**\n" - " * @exports {this.is.a.long.path.to.a.Type}\n" - " */", - getGoogleJSStyleWithColumns(20)); - verifyFormat("/**\n" - " * @mods {this.is.a.long.path.to.a.Type}\n" - " */", - "/**\n" - " * @mods {this.is.a.long.path.to.a.Type}\n" - " */", - getGoogleJSStyleWithColumns(20)); - verifyFormat("/**\n" - " * @mods {this.is.a.long.path.to.a.Type}\n" - " */", - "/**\n" - " * @mods {this.is.a.long.path.to.a.Type}\n" - " */", - getGoogleJSStyleWithColumns(20)); - verifyFormat("/**\n" - " * @param {canWrap\n" - " * onSpace}\n" - " */", - "/**\n" - " * @param {canWrap onSpace}\n" - " */", - getGoogleJSStyleWithColumns(20)); - // make sure clang-format doesn't break before *any* '{' - verifyFormat("/**\n" - " * @lala {lala {lalala\n" - " */\n", - "/**\n" - " * @lala {lala {lalala\n" - " */\n", - getGoogleJSStyleWithColumns(20)); - verifyFormat("/**\n" - " * @see http://very/very/long/url/is/long\n" - " */", - "/**\n" - " * @see http://very/very/long/url/is/long\n" - " */", - getGoogleJSStyleWithColumns(20)); - verifyFormat( - "/**\n" - " * @param This is a\n" - " * long comment\n" - " * but no type\n" - " */", - "/**\n" - " * @param This is a long comment but no type\n" - " */", - getGoogleJSStyleWithColumns(20)); - // Break and reindent @param line and reflow unrelated lines. - EXPECT_EQ("{\n" - " /**\n" - " * long long long\n" - " * long\n" - " * @param {this.is.a.long.path.to.a.Type}\n" - " * a\n" - " * long long long\n" - " * long long\n" - " */\n" - " function f(a) {}\n" - "}", - format("{\n" - "/**\n" - " * long long long long\n" - " * @param {this.is.a.long.path.to.a.Type} a\n" - " * long long long long\n" - " * long\n" - " */\n" - " function f(a) {}\n" - "}", - getGoogleJSStyleWithColumns(20))); -} - -TEST_F(FormatTestJS, RequoteStringsSingle) { - verifyFormat("var x = 'foo';", "var x = \"foo\";"); - verifyFormat("var x = 'fo\\'o\\'';", "var x = \"fo'o'\";"); - verifyFormat("var x = 'fo\\'o\\'';", "var x = \"fo\\'o'\";"); - verifyFormat( - "var x =\n" - " 'foo\\'';", - // Code below is 15 chars wide, doesn't fit into the line with the - // \ escape added. - "var x = \"foo'\";", getGoogleJSStyleWithColumns(15)); - // Removes no-longer needed \ escape from ". - verifyFormat("var x = 'fo\"o';", "var x = \"fo\\\"o\";"); - // Code below fits into 15 chars *after* removing the \ escape. - verifyFormat("var x = 'fo\"o';", "var x = \"fo\\\"o\";", - getGoogleJSStyleWithColumns(15)); - verifyFormat("// clang-format off\n" - "let x = \"double\";\n" - "// clang-format on\n" - "let x = 'single';\n", - "// clang-format off\n" - "let x = \"double\";\n" - "// clang-format on\n" - "let x = \"single\";\n"); -} - -TEST_F(FormatTestJS, RequoteAndIndent) { - verifyFormat("let x = someVeryLongFunctionThatGoesOnAndOn(\n" - " 'double quoted string that needs wrapping');", - "let x = someVeryLongFunctionThatGoesOnAndOn(" - "\"double quoted string that needs wrapping\");"); - - verifyFormat("let x =\n" - " 'foo\\'oo';\n" - "let x =\n" - " 'foo\\'oo';", - "let x=\"foo'oo\";\n" - "let x=\"foo'oo\";", - getGoogleJSStyleWithColumns(15)); -} - -TEST_F(FormatTestJS, RequoteStringsDouble) { - FormatStyle DoubleQuotes = getGoogleStyle(FormatStyle::LK_JavaScript); - DoubleQuotes.JavaScriptQuotes = FormatStyle::JSQS_Double; - verifyFormat("var x = \"foo\";", DoubleQuotes); - verifyFormat("var x = \"foo\";", "var x = 'foo';", DoubleQuotes); - verifyFormat("var x = \"fo'o\";", "var x = 'fo\\'o';", DoubleQuotes); -} - -TEST_F(FormatTestJS, RequoteStringsLeave) { - FormatStyle LeaveQuotes = getGoogleStyle(FormatStyle::LK_JavaScript); - LeaveQuotes.JavaScriptQuotes = FormatStyle::JSQS_Leave; - verifyFormat("var x = \"foo\";", LeaveQuotes); - verifyFormat("var x = 'foo';", LeaveQuotes); -} - -TEST_F(FormatTestJS, SupportShebangLines) { - verifyFormat("#!/usr/bin/env node\n" - "var x = hello();", - "#!/usr/bin/env node\n" - "var x = hello();"); -} - -TEST_F(FormatTestJS, NonNullAssertionOperator) { - verifyFormat("let x = foo!.bar();\n"); - verifyFormat("let x = foo ? bar! : baz;\n"); - verifyFormat("let x = !foo;\n"); - verifyFormat("if (!+a) {\n}"); - verifyFormat("let x = foo[0]!;\n"); - verifyFormat("let x = (foo)!;\n"); - verifyFormat("let x = x(foo!);\n"); - verifyFormat( - "a.aaaaaa(a.a!).then(\n" - " x => x(x));\n", - getGoogleJSStyleWithColumns(20)); - verifyFormat("let x = foo! - 1;\n"); - verifyFormat("let x = {foo: 1}!;\n"); - verifyFormat( - "let x = hello.foo()!\n" - " .foo()!\n" - " .foo()!\n" - " .foo()!;\n", - getGoogleJSStyleWithColumns(20)); - verifyFormat("let x = namespace!;\n"); - verifyFormat("return !!x;\n"); -} - -TEST_F(FormatTestJS, Conditional) { - verifyFormat("y = x ? 1 : 2;"); - verifyFormat("x ? 1 : 2;"); - verifyFormat("class Foo {\n" - " field = true ? 1 : 2;\n" - " method(a = true ? 1 : 2) {}\n" - "}"); -} - -TEST_F(FormatTestJS, ImportComments) { - verifyFormat("import {x} from 'x'; // from some location", - getGoogleJSStyleWithColumns(25)); - verifyFormat("// taze: x from 'location'", getGoogleJSStyleWithColumns(10)); - verifyFormat("/// <reference path=\"some/location\" />", getGoogleJSStyleWithColumns(10)); -} - -TEST_F(FormatTestJS, Exponentiation) { - verifyFormat("squared = x ** 2;"); - verifyFormat("squared **= 2;"); -} - -TEST_F(FormatTestJS, NestedLiterals) { - FormatStyle FourSpaces = getGoogleJSStyleWithColumns(15); - FourSpaces.IndentWidth = 4; - verifyFormat("var l = [\n" - " [\n" - " 1,\n" - " ],\n" - "];", FourSpaces); - verifyFormat("var l = [\n" - " {\n" - " 1: 1,\n" - " },\n" - "];", FourSpaces); - verifyFormat("someFunction(\n" - " p1,\n" - " [\n" - " 1,\n" - " ],\n" - ");", FourSpaces); - verifyFormat("someFunction(\n" - " p1,\n" - " {\n" - " 1: 1,\n" - " },\n" - ");", FourSpaces); - verifyFormat("var o = {\n" - " 1: 1,\n" - " 2: {\n" - " 3: 3,\n" - " },\n" - "};", FourSpaces); - verifyFormat("var o = {\n" - " 1: 1,\n" - " 2: [\n" - " 3,\n" - " ],\n" - "};", FourSpaces); -} - -TEST_F(FormatTestJS, BackslashesInComments) { - verifyFormat("// hello \\\n" - "if (x) foo();\n", - "// hello \\\n" - " if ( x) \n" - " foo();\n"); - verifyFormat("/* ignore \\\n" - " */\n" - "if (x) foo();\n", - "/* ignore \\\n" - " */\n" - " if ( x) foo();\n"); - verifyFormat("// st \\ art\\\n" - "// comment" - "// continue \\\n" - "formatMe();\n", - "// st \\ art\\\n" - "// comment" - "// continue \\\n" - "formatMe( );\n"); -} - -TEST_F(FormatTestJS, AddsLastLinePenaltyIfEndingIsBroken) { - EXPECT_EQ( - "a = function() {\n" - " b = function() {\n" - " this.aaaaaaaaaaaaaaaaaaa[aaaaaaaaaaa] = aaaa.aaaaaa ?\n" - " aaaa.aaaaaa : /** @type " - "{aaaa.aaaa.aaaaaaaaa.aaaaaaaaaaaaaaaaaaa} */\n" - " (aaaa.aaaa.aaaaaaaaa.aaaaaaaaaaaaa.aaaaaaaaaaaaaaaaa);\n" - " };\n" - "};", - format("a = function() {\n" - " b = function() {\n" - " this.aaaaaaaaaaaaaaaaaaa[aaaaaaaaaaa] = aaaa.aaaaaa ? " - "aaaa.aaaaaa : /** @type " - "{aaaa.aaaa.aaaaaaaaa.aaaaaaaaaaaaaaaaaaa} */\n" - " (aaaa.aaaa.aaaaaaaaa.aaaaaaaaaaaaa.aaaaaaaaaaaaaaaaa);\n" - " };\n" - "};")); -} - -TEST_F(FormatTestJS, ParameterNamingComment) { - verifyFormat("callFoo(/*spaceAfterParameterNamingComment=*/ 1);"); -} - -TEST_F(FormatTestJS, ConditionalTypes) { - // Formatting below is not necessarily intentional, this just ensures that - // clang-format does not break the code. - verifyFormat( // wrap - "type UnionToIntersection<U> =\n" - " (U extends any ? (k: U) => void :\n" - " never) extends((k: infer I) => void) ? I : never;"); -} - -} // end namespace tooling -} // end namespace clang diff --git a/unittests/Format/FormatTestJava.cpp b/unittests/Format/FormatTestJava.cpp deleted file mode 100644 index f12d7fba50593..0000000000000 --- a/unittests/Format/FormatTestJava.cpp +++ /dev/null @@ -1,583 +0,0 @@ -//===- unittest/Format/FormatTestJava.cpp - Formatting tests for Java -----===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "FormatTestUtils.h" -#include "clang/Format/Format.h" -#include "llvm/Support/Debug.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -namespace clang { -namespace format { - -class FormatTestJava : public ::testing::Test { -protected: - static std::string format(llvm::StringRef Code, unsigned Offset, - unsigned Length, const FormatStyle &Style) { - LLVM_DEBUG(llvm::errs() << "---\n"); - LLVM_DEBUG(llvm::errs() << Code << "\n\n"); - std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length)); - tooling::Replacements Replaces = reformat(Style, Code, Ranges); - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); - return *Result; - } - - static std::string - format(llvm::StringRef Code, - const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_Java)) { - return format(Code, 0, Code.size(), Style); - } - - static FormatStyle getStyleWithColumns(unsigned ColumnLimit) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_Java); - Style.ColumnLimit = ColumnLimit; - return Style; - } - - static void verifyFormat( - llvm::StringRef Code, - const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_Java)) { - EXPECT_EQ(Code.str(), format(Code, Style)) << "Expected code is not stable"; - EXPECT_EQ(Code.str(), format(test::messUp(Code), Style)); - } -}; - -TEST_F(FormatTestJava, NoAlternativeOperatorNames) { - verifyFormat("someObject.and();"); -} - -TEST_F(FormatTestJava, UnderstandsCasts) { - verifyFormat("a[b >> 1] = (byte) (c() << 4);"); -} - -TEST_F(FormatTestJava, FormatsInstanceOfLikeOperators) { - FormatStyle Style = getStyleWithColumns(50); - verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " instanceof bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;", - Style); - Style.BreakBeforeBinaryOperators = FormatStyle::BOS_None; - verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaa instanceof\n" - " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;", - Style); - verifyFormat("return aaaaaaaaaaaaaaaaaaa instanceof bbbbbbbbbbbbbbbbbbbbbbb\n" - " && ccccccccccccccccccc instanceof dddddddddddddddddddddd;"); -} - -TEST_F(FormatTestJava, Chromium) { - verifyFormat("class SomeClass {\n" - " void f() {}\n" - " int g() {\n" - " return 0;\n" - " }\n" - " void h() {\n" - " while (true) f();\n" - " for (;;) f();\n" - " if (true) f();\n" - " }\n" - "}", - getChromiumStyle(FormatStyle::LK_Java)); -} - -TEST_F(FormatTestJava, QualifiedNames) { - verifyFormat("public some.package.Type someFunction( // comment\n" - " int parameter) {}"); -} - -TEST_F(FormatTestJava, ClassKeyword) { - verifyFormat("SomeClass.class.getName();"); - verifyFormat("Class c = SomeClass.class;"); -} - -TEST_F(FormatTestJava, ClassDeclarations) { - verifyFormat("public class SomeClass {\n" - " private int a;\n" - " private int b;\n" - "}"); - verifyFormat("public class A {\n" - " class B {\n" - " int i;\n" - " }\n" - " class C {\n" - " int j;\n" - " }\n" - "}"); - verifyFormat("public class A extends B.C {}"); - - verifyFormat("abstract class SomeClass\n" - " extends SomeOtherClass implements SomeInterface {}", - getStyleWithColumns(60)); - verifyFormat("abstract class SomeClass extends SomeOtherClass\n" - " implements SomeInterfaceeeeeeeeeeeee {}", - getStyleWithColumns(60)); - verifyFormat("abstract class SomeClass\n" - " extends SomeOtherClass\n" - " implements SomeInterface {}", - getStyleWithColumns(40)); - verifyFormat("abstract class SomeClass\n" - " extends SomeOtherClass\n" - " implements SomeInterface,\n" - " AnotherInterface {}", - getStyleWithColumns(40)); - verifyFormat("abstract class SomeClass\n" - " implements SomeInterface, AnotherInterface {}", - getStyleWithColumns(60)); - verifyFormat("@SomeAnnotation()\n" - "abstract class aaaaaaaaaaaa\n" - " extends bbbbbbbbbbbbbbb implements cccccccccccc {}", - getStyleWithColumns(76)); - verifyFormat("@SomeAnnotation()\n" - "abstract class aaaaaaaaa<a>\n" - " extends bbbbbbbbbbbb<b> implements cccccccccccc {}", - getStyleWithColumns(76)); - verifyFormat("interface SomeInterface<A> extends Foo, Bar {\n" - " void doStuff(int theStuff);\n" - " void doMoreStuff(int moreStuff);\n" - "}"); - verifyFormat("public interface SomeInterface {\n" - " void doStuff(int theStuff);\n" - " void doMoreStuff(int moreStuff);\n" - " default void doStuffWithDefault() {}\n" - "}"); - verifyFormat("@interface SomeInterface {\n" - " void doStuff(int theStuff);\n" - " void doMoreStuff(int moreStuff);\n" - "}"); - verifyFormat("public @interface SomeInterface {\n" - " void doStuff(int theStuff);\n" - " void doMoreStuff(int moreStuff);\n" - "}"); - verifyFormat("class A {\n" - " public @interface SomeInterface {\n" - " int stuff;\n" - " void doMoreStuff(int moreStuff);\n" - " }\n" - "}"); - verifyFormat("class A {\n" - " public @interface SomeInterface {}\n" - "}"); -} - -TEST_F(FormatTestJava, AnonymousClasses) { - verifyFormat("return new A() {\n" - " public String toString() {\n" - " return \"NotReallyA\";\n" - " }\n" - "};"); - verifyFormat("A a = new A() {\n" - " public String toString() {\n" - " return \"NotReallyA\";\n" - " }\n" - "};"); -} - -TEST_F(FormatTestJava, EnumDeclarations) { - verifyFormat("enum SomeThing { ABC, CDE }"); - verifyFormat("enum SomeThing {\n" - " ABC,\n" - " CDE,\n" - "}"); - verifyFormat("public class SomeClass {\n" - " enum SomeThing { ABC, CDE }\n" - " void f() {}\n" - "}"); - verifyFormat("public class SomeClass implements SomeInterface {\n" - " enum SomeThing { ABC, CDE }\n" - " void f() {}\n" - "}"); - verifyFormat("enum SomeThing {\n" - " ABC,\n" - " CDE;\n" - " void f() {}\n" - "}"); - verifyFormat("enum SomeThing {\n" - " ABC(1, \"ABC\"),\n" - " CDE(2, \"CDE\");\n" - " Something(int i, String s) {}\n" - "}"); - verifyFormat("enum SomeThing {\n" - " ABC(new int[] {1, 2}),\n" - " CDE(new int[] {2, 3});\n" - " Something(int[] i) {}\n" - "}"); - verifyFormat("public enum SomeThing {\n" - " ABC {\n" - " public String toString() {\n" - " return \"ABC\";\n" - " }\n" - " },\n" - " CDE {\n" - " @Override\n" - " public String toString() {\n" - " return \"CDE\";\n" - " }\n" - " };\n" - " public void f() {}\n" - "}"); - verifyFormat("private enum SomeEnum implements Foo<?, B> {\n" - " ABC {\n" - " @Override\n" - " public String toString() {\n" - " return \"ABC\";\n" - " }\n" - " },\n" - " CDE {\n" - " @Override\n" - " public String toString() {\n" - " return \"CDE\";\n" - " }\n" - " };\n" - "}"); - verifyFormat("public enum VeryLongEnum {\n" - " ENUM_WITH_MANY_PARAMETERS(\n" - " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\", \"bbbbbbbbbbbbbbbb\", " - "\"cccccccccccccccccccccccc\"),\n" - " SECOND_ENUM(\"a\", \"b\", \"c\");\n" - " private VeryLongEnum(String a, String b, String c) {}\n" - "}\n"); -} - -TEST_F(FormatTestJava, ArrayInitializers) { - verifyFormat("new int[] {1, 2, 3, 4};"); - verifyFormat("new int[] {\n" - " 1,\n" - " 2,\n" - " 3,\n" - " 4,\n" - "};"); - - FormatStyle Style = getStyleWithColumns(65); - Style.Cpp11BracedListStyle = false; - verifyFormat( - "expected = new int[] { 10, 10, 10, 10, 10, 10, 10, 10, 10, 10,\n" - " 100, 100, 100, 100, 100, 100, 100, 100, 100, 100 };", - Style); -} - -TEST_F(FormatTestJava, ThrowsDeclarations) { - verifyFormat("public void doSooooooooooooooooooooooooooomething()\n" - " throws LooooooooooooooooooooooooooooongException {}"); - verifyFormat("public void doSooooooooooooooooooooooooooomething()\n" - " throws LoooooooooongException, LooooooooooongException {}"); -} - -TEST_F(FormatTestJava, Annotations) { - verifyFormat("@Override\n" - "public String toString() {}"); - verifyFormat("@Override\n" - "@Nullable\n" - "public String getNameIfPresent() {}"); - verifyFormat("@Override // comment\n" - "@Nullable\n" - "public String getNameIfPresent() {}"); - verifyFormat("@java.lang.Override // comment\n" - "@Nullable\n" - "public String getNameIfPresent() {}"); - - verifyFormat("@SuppressWarnings(value = \"unchecked\")\n" - "public void doSomething() {}"); - verifyFormat("@SuppressWarnings(value = \"unchecked\")\n" - "@Author(name = \"abc\")\n" - "public void doSomething() {}"); - - verifyFormat("DoSomething(new A() {\n" - " @Override\n" - " public String toString() {}\n" - "});"); - - verifyFormat("void SomeFunction(@Nullable String something) {}"); - verifyFormat("void SomeFunction(@org.llvm.Nullable String something) {}"); - - verifyFormat("@Partial @Mock DataLoader loader;"); - verifyFormat("@Partial\n" - "@Mock\n" - "DataLoader loader;", - getChromiumStyle(FormatStyle::LK_Java)); - verifyFormat("@SuppressWarnings(value = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\")\n" - "public static int iiiiiiiiiiiiiiiiiiiiiiii;"); - - verifyFormat("@SomeAnnotation(\"With some really looooooooooooooong text\")\n" - "private static final long something = 0L;"); - verifyFormat("@org.llvm.Qualified(\"With some really looooooooooong text\")\n" - "private static final long something = 0L;"); - verifyFormat("@Mock\n" - "DataLoader loooooooooooooooooooooooader =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;", - getStyleWithColumns(60)); - verifyFormat("@org.llvm.QualifiedMock\n" - "DataLoader loooooooooooooooooooooooader =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;", - getStyleWithColumns(60)); - verifyFormat("@Test(a)\n" - "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa);"); - verifyFormat("@SomeAnnotation(\n" - " aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa)\n" - "int i;", - getStyleWithColumns(50)); - verifyFormat("@Test\n" - "ReturnType doSomething(\n" - " String aaaaaaaaaaaaa, String bbbbbbbbbbbbbbb) {}", - getStyleWithColumns(60)); - verifyFormat("{\n" - " boolean someFunction(\n" - " @Param(aaaaaaaaaaaaaaaa) String aaaaa,\n" - " String bbbbbbbbbbbbbbb) {}\n" - "}", - getStyleWithColumns(60)); - verifyFormat("@Annotation(\"Some\"\n" - " + \" text\")\n" - "List<Integer> list;"); -} - -TEST_F(FormatTestJava, Generics) { - verifyFormat("Iterable<?> a;"); - verifyFormat("Iterable<?> a;"); - verifyFormat("Iterable<? extends SomeObject> a;"); - - verifyFormat("A.<B>doSomething();"); - verifyFormat("A.<B<C>>doSomething();"); - verifyFormat("A.<B<C<D>>>doSomething();"); - verifyFormat("A.<B<C<D<E>>>>doSomething();"); - - verifyFormat("OrderedPair<String, List<Box<Integer>>> p = null;"); - - verifyFormat("@Override\n" - "public Map<String, ?> getAll() {}"); - - verifyFormat("public <R> ArrayList<R> get() {}"); - verifyFormat("protected <R> ArrayList<R> get() {}"); - verifyFormat("private <R> ArrayList<R> get() {}"); - verifyFormat("public static <R> ArrayList<R> get() {}"); - verifyFormat("public static native <R> ArrayList<R> get();"); - verifyFormat("public final <X> Foo foo() {}"); - verifyFormat("public abstract <X> Foo foo();"); - verifyFormat("<T extends B> T getInstance(Class<T> type);"); - verifyFormat("Function<F, ? extends T> function;"); - - verifyFormat("private Foo<X, Y>[] foos;"); - verifyFormat("Foo<X, Y>[] foos = this.foos;"); - verifyFormat("return (a instanceof List<?>)\n" - " ? aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" - " : aaaaaaaaaaaaaaaaaaaaaaa;", - getStyleWithColumns(60)); - - verifyFormat( - "SomeLoooooooooooooooooooooongType name =\n" - " SomeType.foo(someArgument)\n" - " .<X>method()\n" - " .aaaaaaaaaaaaaaaaaaa()\n" - " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); -} - -TEST_F(FormatTestJava, StringConcatenation) { - verifyFormat("String someString = \"abc\"\n" - " + \"cde\";"); -} - -TEST_F(FormatTestJava, TryCatchFinally) { - verifyFormat("try {\n" - " Something();\n" - "} catch (SomeException e) {\n" - " HandleException(e);\n" - "}"); - verifyFormat("try {\n" - " Something();\n" - "} finally {\n" - " AlwaysDoThis();\n" - "}"); - verifyFormat("try {\n" - " Something();\n" - "} catch (SomeException e) {\n" - " HandleException(e);\n" - "} finally {\n" - " AlwaysDoThis();\n" - "}"); - - verifyFormat("try {\n" - " Something();\n" - "} catch (SomeException | OtherException e) {\n" - " HandleException(e);\n" - "}"); -} - -TEST_F(FormatTestJava, TryWithResources) { - verifyFormat("try (SomeResource rs = someFunction()) {\n" - " Something();\n" - "}"); - verifyFormat("try (SomeResource rs = someFunction()) {\n" - " Something();\n" - "} catch (SomeException e) {\n" - " HandleException(e);\n" - "}"); -} - -TEST_F(FormatTestJava, SynchronizedKeyword) { - verifyFormat("synchronized (mData) {\n" - " // ...\n" - "}"); -} - -TEST_F(FormatTestJava, AssertKeyword) { - verifyFormat("assert a && b;"); - verifyFormat("assert (a && b);"); -} - -TEST_F(FormatTestJava, PackageDeclarations) { - verifyFormat("package some.really.loooooooooooooooooooooong.package;", - getStyleWithColumns(50)); -} - -TEST_F(FormatTestJava, ImportDeclarations) { - verifyFormat("import some.really.loooooooooooooooooooooong.imported.Class;", - getStyleWithColumns(50)); - verifyFormat("import static some.really.looooooooooooooooong.imported.Class;", - getStyleWithColumns(50)); -} - -TEST_F(FormatTestJava, MethodDeclarations) { - verifyFormat("void methodName(Object arg1,\n" - " Object arg2, Object arg3) {}", - getStyleWithColumns(40)); - verifyFormat("void methodName(\n" - " Object arg1, Object arg2) {}", - getStyleWithColumns(40)); -} - -TEST_F(FormatTestJava, MethodReference) { - EXPECT_EQ( - "private void foo() {\n" - " f(this::methodReference);\n" - " f(C.super::methodReference);\n" - " Consumer<String> c = System.out::println;\n" - " Iface<Integer> mRef = Ty::<Integer>meth;\n" - "}", - format("private void foo() {\n" - " f(this ::methodReference);\n" - " f(C.super ::methodReference);\n" - " Consumer<String> c = System.out ::println;\n" - " Iface<Integer> mRef = Ty :: <Integer> meth;\n" - "}")); -} - -TEST_F(FormatTestJava, CppKeywords) { - verifyFormat("public void union(Type a, Type b);"); - verifyFormat("public void struct(Object o);"); - verifyFormat("public void delete(Object o);"); - verifyFormat("return operator && (aa);"); -} - -TEST_F(FormatTestJava, NeverAlignAfterReturn) { - verifyFormat("return aaaaaaaaaaaaaaaaaaa\n" - " && bbbbbbbbbbbbbbbbbbb\n" - " && ccccccccccccccccccc;", - getStyleWithColumns(40)); - verifyFormat("return (result == null)\n" - " ? aaaaaaaaaaaaaaaaa\n" - " : bbbbbbbbbbbbbbbbb;", - getStyleWithColumns(40)); - verifyFormat("return aaaaaaaaaaaaaaaaaaa()\n" - " .bbbbbbbbbbbbbbbbbbb()\n" - " .ccccccccccccccccccc();", - getStyleWithColumns(40)); - verifyFormat("return aaaaaaaaaaaaaaaaaaa()\n" - " .bbbbbbbbbbbbbbbbbbb(\n" - " ccccccccccccccc)\n" - " .ccccccccccccccccccc();", - getStyleWithColumns(40)); -} - -TEST_F(FormatTestJava, FormatsInnerBlocks) { - verifyFormat("someObject.someFunction(new Runnable() {\n" - " @Override\n" - " public void run() {\n" - " System.out.println(42);\n" - " }\n" - "}, someOtherParameter);"); - verifyFormat("someFunction(new Runnable() {\n" - " public void run() {\n" - " System.out.println(42);\n" - " }\n" - "});"); - verifyFormat("someObject.someFunction(\n" - " new Runnable() {\n" - " @Override\n" - " public void run() {\n" - " System.out.println(42);\n" - " }\n" - " },\n" - " new Runnable() {\n" - " @Override\n" - " public void run() {\n" - " System.out.println(43);\n" - " }\n" - " },\n" - " someOtherParameter);"); -} - -TEST_F(FormatTestJava, FormatsLambdas) { - verifyFormat("(aaaaaaaaaa, bbbbbbbbbb) -> aaaaaaaaaa + bbbbbbbbbb;"); - verifyFormat("(aaaaaaaaaa, bbbbbbbbbb)\n" - " -> aaaaaaaaaa + bbbbbbbbbb;", - getStyleWithColumns(40)); - verifyFormat("Runnable someLambda = () -> DoSomething();"); - verifyFormat("Runnable someLambda = () -> {\n" - " DoSomething();\n" - "}"); - - verifyFormat("Runnable someLambda =\n" - " (int aaaaa) -> DoSomething(aaaaa);", - getStyleWithColumns(40)); -} - -TEST_F(FormatTestJava, BreaksStringLiterals) { - // FIXME: String literal breaking is currently disabled for Java and JS, as it - // requires strings to be merged using "+" which we don't support. - EXPECT_EQ("\"some text other\";", - format("\"some text other\";", getStyleWithColumns(14))); -} - -TEST_F(FormatTestJava, AlignsBlockComments) { - EXPECT_EQ("/*\n" - " * Really multi-line\n" - " * comment.\n" - " */\n" - "void f() {}", - format(" /*\n" - " * Really multi-line\n" - " * comment.\n" - " */\n" - " void f() {}")); -} - -TEST_F(FormatTestJava, KeepsDelimitersOnOwnLineInJavaDocComments) { - EXPECT_EQ("/**\n" - " * javadoc line 1\n" - " * javadoc line 2\n" - " */", - format("/** javadoc line 1\n" - " * javadoc line 2 */")); -} - -TEST_F(FormatTestJava, RetainsLogicalShifts) { - verifyFormat("void f() {\n" - " int a = 1;\n" - " a >>>= 1;\n" - "}"); - verifyFormat("void f() {\n" - " int a = 1;\n" - " a = a >>> 1;\n" - "}"); -} - - -} // end namespace tooling -} // end namespace clang diff --git a/unittests/Format/FormatTestObjC.cpp b/unittests/Format/FormatTestObjC.cpp deleted file mode 100644 index a417b6710da26..0000000000000 --- a/unittests/Format/FormatTestObjC.cpp +++ /dev/null @@ -1,1320 +0,0 @@ -//===- unittest/Format/FormatTestObjC.cpp - Formatting unit tests----------===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "clang/Format/Format.h" - -#include "../Tooling/ReplacementTest.h" -#include "FormatTestUtils.h" - -#include "clang/Frontend/TextDiagnosticPrinter.h" -#include "llvm/Support/Debug.h" -#include "llvm/Support/MemoryBuffer.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -using clang::tooling::ReplacementTest; - -namespace clang { -namespace format { -namespace { - -class FormatTestObjC : public ::testing::Test { -protected: - FormatTestObjC() { - Style = getLLVMStyle(); - Style.Language = FormatStyle::LK_ObjC; - } - - enum StatusCheck { - SC_ExpectComplete, - SC_ExpectIncomplete, - SC_DoNotCheck - }; - - std::string format(llvm::StringRef Code, - StatusCheck CheckComplete = SC_ExpectComplete) { - LLVM_DEBUG(llvm::errs() << "---\n"); - LLVM_DEBUG(llvm::errs() << Code << "\n\n"); - std::vector<tooling::Range> Ranges(1, tooling::Range(0, Code.size())); - FormattingAttemptStatus Status; - tooling::Replacements Replaces = - reformat(Style, Code, Ranges, "<stdin>", &Status); - if (CheckComplete != SC_DoNotCheck) { - bool ExpectedCompleteFormat = CheckComplete == SC_ExpectComplete; - EXPECT_EQ(ExpectedCompleteFormat, Status.FormatComplete) - << Code << "\n\n"; - } - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); - return *Result; - } - - void verifyFormat(StringRef Code) { - EXPECT_EQ(Code.str(), format(Code)) << "Expected code is not stable"; - EXPECT_EQ(Code.str(), format(test::messUp(Code))); - } - - void verifyIncompleteFormat(StringRef Code) { - EXPECT_EQ(Code.str(), format(test::messUp(Code), SC_ExpectIncomplete)); - } - - FormatStyle Style; -}; - -TEST(FormatTestObjCStyle, DetectsObjCInHeaders) { - auto Style = getStyle("LLVM", "a.h", "none", "@interface\n" - "- (id)init;"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - Style = getStyle("LLVM", "a.h", "none", "@interface\n" - "+ (id)init;"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - Style = getStyle("LLVM", "a.h", "none", "@interface\n" - "@end\n" - "//comment"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - Style = getStyle("LLVM", "a.h", "none", "@interface\n" - "@end //comment"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - // No recognizable ObjC. - Style = getStyle("LLVM", "a.h", "none", "void f() {}"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); - - Style = getStyle("{}", "a.h", "none", "@interface Foo\n@end\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - Style = getStyle("{}", "a.h", "none", - "const int interface = 1;\nconst int end = 2;\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); - - Style = getStyle("{}", "a.h", "none", "@protocol Foo\n@end\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - Style = getStyle("{}", "a.h", "none", - "const int protocol = 1;\nconst int end = 2;\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); - - Style = - getStyle("{}", "a.h", "none", "typedef NS_ENUM(NSInteger, Foo) {};\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - Style = getStyle("{}", "a.h", "none", "enum Foo {};"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); - - Style = - getStyle("{}", "a.h", "none", "inline void Foo() { Log(@\"Foo\"); }\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - Style = - getStyle("{}", "a.h", "none", "inline void Foo() { Log(\"Foo\"); }\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); - - Style = - getStyle("{}", "a.h", "none", "inline void Foo() { id = @[1, 2, 3]; }\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - Style = getStyle("{}", "a.h", "none", - "inline void Foo() { id foo = @{1: 2, 3: 4, 5: 6}; }\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - Style = getStyle("{}", "a.h", "none", - "inline void Foo() { int foo[] = {1, 2, 3}; }\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); - - // ObjC characteristic types. - Style = getStyle("{}", "a.h", "none", "extern NSString *kFoo;\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - Style = getStyle("{}", "a.h", "none", "extern NSInteger Foo();\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - Style = getStyle("{}", "a.h", "none", "NSObject *Foo();\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); - - Style = getStyle("{}", "a.h", "none", "NSSet *Foo();\n"); - ASSERT_TRUE((bool)Style); - EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); -} - -TEST_F(FormatTestObjC, FormatObjCTryCatch) { - verifyFormat("@try {\n" - " f();\n" - "} @catch (NSException e) {\n" - " @throw;\n" - "} @finally {\n" - " exit(42);\n" - "}"); - verifyFormat("DEBUG({\n" - " @try {\n" - " } @finally {\n" - " }\n" - "});\n"); -} - -TEST_F(FormatTestObjC, FormatObjCAutoreleasepool) { - verifyFormat("@autoreleasepool {\n" - " f();\n" - "}\n" - "@autoreleasepool {\n" - " f();\n" - "}\n"); - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterControlStatement = true; - verifyFormat("@autoreleasepool\n" - "{\n" - " f();\n" - "}\n" - "@autoreleasepool\n" - "{\n" - " f();\n" - "}\n"); -} - -TEST_F(FormatTestObjC, FormatObjCGenerics) { - Style.ColumnLimit = 40; - verifyFormat("int aaaaaaaaaaaaaaaa(\n" - " NSArray<aaaaaaaaaaaaaaaaaa *>\n" - " aaaaaaaaaaaaaaaaa);\n"); - verifyFormat("int aaaaaaaaaaaaaaaa(\n" - " NSArray<aaaaaaaaaaaaaaaaaaa<\n" - " aaaaaaaaaaaaaaaa *> *>\n" - " aaaaaaaaaaaaaaaaa);\n"); -} - -TEST_F(FormatTestObjC, FormatObjCSynchronized) { - verifyFormat("@synchronized(self) {\n" - " f();\n" - "}\n" - "@synchronized(self) {\n" - " f();\n" - "}\n"); - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterControlStatement = true; - verifyFormat("@synchronized(self)\n" - "{\n" - " f();\n" - "}\n" - "@synchronized(self)\n" - "{\n" - " f();\n" - "}\n"); -} - -TEST_F(FormatTestObjC, FormatObjCInterface) { - verifyFormat("@interface Foo : NSObject <NSSomeDelegate> {\n" - "@public\n" - " int field1;\n" - "@protected\n" - " int field2;\n" - "@private\n" - " int field3;\n" - "@package\n" - " int field4;\n" - "}\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface /* wait for it */ Foo\n" - "+ (id)init;\n" - "// Look, a comment!\n" - "- (int)answerWith:(int)i;\n" - "@end"); - - verifyFormat("@interface Foo\n" - "@end\n" - "@interface Bar\n" - "@end"); - - verifyFormat("@interface Foo : Bar\n" - "@property(assign, readwrite) NSInteger bar;\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("FOUNDATION_EXPORT NS_AVAILABLE_IOS(10.0) @interface Foo : Bar\n" - "@property(assign, readwrite) NSInteger bar;\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface Foo : /**/ Bar /**/ <Baz, /**/ Quux>\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface Foo (HackStuff)\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface Foo ()\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface Foo (HackStuff) <MyProtocol>\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface Foo {\n" - " int _i;\n" - "}\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface Foo : Bar {\n" - " int _i;\n" - "}\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface Foo : Bar <Baz, Quux> {\n" - " int _i;\n" - "}\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface Foo<Baz : Blech> : Bar <Baz, Quux> {\n" - " int _i;\n" - "}\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface Foo<Bar : Baz <Blech>> : Xyzzy <Corge> {\n" - " int _i;\n" - "}\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface Foo (HackStuff) {\n" - " int _i;\n" - "}\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface Foo () {\n" - " int _i;\n" - "}\n" - "+ (id)init;\n" - "@end"); - - verifyFormat("@interface Foo (HackStuff) <MyProtocol> {\n" - " int _i;\n" - "}\n" - "+ (id)init;\n" - "@end"); - verifyFormat("@interface Foo\n" - "- (void)foo {\n" - "}\n" - "@end\n" - "@implementation Bar\n" - "- (void)bar {\n" - "}\n" - "@end"); - Style.ColumnLimit = 40; - verifyFormat("@interface ccccccccccccc () <\n" - " ccccccccccccc, ccccccccccccc,\n" - " ccccccccccccc, ccccccccccccc> {\n" - "}"); - verifyFormat("@interface ccccccccccccc (ccccccccccc) <\n" - " ccccccccccccc> {\n" - "}"); - Style.ObjCBinPackProtocolList = FormatStyle::BPS_Never; - verifyFormat("@interface ddddddddddddd () <\n" - " ddddddddddddd,\n" - " ddddddddddddd,\n" - " ddddddddddddd,\n" - " ddddddddddddd> {\n" - "}"); - - Style.BinPackParameters = false; - Style.ObjCBinPackProtocolList = FormatStyle::BPS_Auto; - verifyFormat("@interface eeeeeeeeeeeee () <\n" - " eeeeeeeeeeeee,\n" - " eeeeeeeeeeeee,\n" - " eeeeeeeeeeeee,\n" - " eeeeeeeeeeeee> {\n" - "}"); - Style.ObjCBinPackProtocolList = FormatStyle::BPS_Always; - verifyFormat("@interface fffffffffffff () <\n" - " fffffffffffff, fffffffffffff,\n" - " fffffffffffff, fffffffffffff> {\n" - "}"); - - Style = getGoogleStyle(FormatStyle::LK_ObjC); - verifyFormat("@interface Foo : NSObject <NSSomeDelegate> {\n" - " @public\n" - " int field1;\n" - " @protected\n" - " int field2;\n" - " @private\n" - " int field3;\n" - " @package\n" - " int field4;\n" - "}\n" - "+ (id)init;\n" - "@end"); - verifyFormat("@interface Foo : Bar <Baz, Quux>\n" - "+ (id)init;\n" - "@end"); - verifyFormat("@interface Foo (HackStuff) <MyProtocol>\n" - "+ (id)init;\n" - "@end"); - Style.ColumnLimit = 40; - // BinPackParameters should be true by default. - verifyFormat("void eeeeeeee(int eeeee, int eeeee,\n" - " int eeeee, int eeeee);\n"); - // ObjCBinPackProtocolList should be BPS_Never by default. - verifyFormat("@interface fffffffffffff () <\n" - " fffffffffffff,\n" - " fffffffffffff,\n" - " fffffffffffff,\n" - " fffffffffffff> {\n" - "}"); -} - -TEST_F(FormatTestObjC, FormatObjCImplementation) { - verifyFormat("@implementation Foo : NSObject {\n" - "@public\n" - " int field1;\n" - "@protected\n" - " int field2;\n" - "@private\n" - " int field3;\n" - "@package\n" - " int field4;\n" - "}\n" - "+ (id)init {\n}\n" - "@end"); - - verifyFormat("@implementation Foo\n" - "+ (id)init {\n" - " if (true)\n" - " return nil;\n" - "}\n" - "// Look, a comment!\n" - "- (int)answerWith:(int)i {\n" - " return i;\n" - "}\n" - "+ (int)answerWith:(int)i {\n" - " return i;\n" - "}\n" - "@end"); - - verifyFormat("@implementation Foo\n" - "@end\n" - "@implementation Bar\n" - "@end"); - - EXPECT_EQ("@implementation Foo : Bar\n" - "+ (id)init {\n}\n" - "- (void)foo {\n}\n" - "@end", - format("@implementation Foo : Bar\n" - "+(id)init{}\n" - "-(void)foo{}\n" - "@end")); - - verifyFormat("@implementation Foo {\n" - " int _i;\n" - "}\n" - "+ (id)init {\n}\n" - "@end"); - - verifyFormat("@implementation Foo : Bar {\n" - " int _i;\n" - "}\n" - "+ (id)init {\n}\n" - "@end"); - - verifyFormat("@implementation Foo (HackStuff)\n" - "+ (id)init {\n}\n" - "@end"); - verifyFormat("@implementation ObjcClass\n" - "- (void)method;\n" - "{}\n" - "@end"); - - Style = getGoogleStyle(FormatStyle::LK_ObjC); - verifyFormat("@implementation Foo : NSObject {\n" - " @public\n" - " int field1;\n" - " @protected\n" - " int field2;\n" - " @private\n" - " int field3;\n" - " @package\n" - " int field4;\n" - "}\n" - "+ (id)init {\n}\n" - "@end"); -} - -TEST_F(FormatTestObjC, FormatObjCProtocol) { - verifyFormat("@protocol Foo\n" - "@property(weak) id delegate;\n" - "- (NSUInteger)numberOfThings;\n" - "@end"); - - verifyFormat("@protocol MyProtocol <NSObject>\n" - "- (NSUInteger)numberOfThings;\n" - "@end"); - - verifyFormat("@protocol Foo;\n" - "@protocol Bar;\n"); - - verifyFormat("@protocol Foo\n" - "@end\n" - "@protocol Bar\n" - "@end"); - - verifyFormat("FOUNDATION_EXPORT NS_AVAILABLE_IOS(10.0) @protocol Foo\n" - "@property(assign, readwrite) NSInteger bar;\n" - "@end"); - - verifyFormat("@protocol myProtocol\n" - "- (void)mandatoryWithInt:(int)i;\n" - "@optional\n" - "- (void)optional;\n" - "@required\n" - "- (void)required;\n" - "@optional\n" - "@property(assign) int madProp;\n" - "@end\n"); - - verifyFormat("@property(nonatomic, assign, readonly)\n" - " int *looooooooooooooooooooooooooooongNumber;\n" - "@property(nonatomic, assign, readonly)\n" - " NSString *looooooooooooooooooooooooooooongName;"); - - verifyFormat("@implementation PR18406\n" - "}\n" - "@end"); - - Style = getGoogleStyle(FormatStyle::LK_ObjC); - verifyFormat("@protocol MyProtocol <NSObject>\n" - "- (NSUInteger)numberOfThings;\n" - "@end"); -} - -TEST_F(FormatTestObjC, FormatObjCMethodDeclarations) { - verifyFormat("- (void)doSomethingWith:(GTMFoo *)theFoo\n" - " rect:(NSRect)theRect\n" - " interval:(float)theInterval {\n" - "}"); - verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" - " longKeyword:(NSRect)theRect\n" - " longerKeyword:(float)theInterval\n" - " error:(NSError **)theError {\n" - "}"); - verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" - " longKeyword:(NSRect)theRect\n" - " evenLongerKeyword:(float)theInterval\n" - " error:(NSError **)theError {\n" - "}"); - verifyFormat("+ (instancetype)new;\n"); - Style.ColumnLimit = 60; - verifyFormat("- (instancetype)initXxxxxx:(id<x>)x\n" - " y:(id<yyyyyyyyyyyyyyyyyyyy>)y\n" - " NS_DESIGNATED_INITIALIZER;"); - verifyFormat("- (void)drawRectOn:(id)surface\n" - " ofSize:(size_t)height\n" - " :(size_t)width;"); - Style.ColumnLimit = 40; - // Make sure selectors with 0, 1, or more arguments are indented when wrapped. - verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n"); - verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); - verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); - verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); - verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); - - // Continuation indent width should win over aligning colons if the function - // name is long. - Style = getGoogleStyle(FormatStyle::LK_ObjC); - Style.ColumnLimit = 40; - verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" - " dontAlignNamef:(NSRect)theRect {\n" - "}"); - - // Make sure we don't break aligning for short parameter names. - verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" - " aShortf:(NSRect)theRect {\n" - "}"); - - // Format pairs correctly. - Style.ColumnLimit = 80; - verifyFormat("- (void)drawRectOn:(id)surface\n" - " ofSize:(aaaaaaaa)height\n" - " :(size_t)width\n" - " atOrigin:(size_t)x\n" - " :(size_t)y\n" - " aaaaa:(a)yyy\n" - " bbb:(d)cccc;"); - verifyFormat("- (void)drawRectOn:(id)surface ofSize:(aaa)height:(bbb)width;"); - - // BraceWrapping AfterFunction is respected for ObjC methods - Style = getGoogleStyle(FormatStyle::LK_ObjC); - Style.BreakBeforeBraces = FormatStyle::BS_Custom; - Style.BraceWrapping.AfterFunction = true; - verifyFormat("@implementation Foo\n" - "- (void)foo:(id)bar\n" - "{\n" - "}\n" - "@end\n"); -} - -TEST_F(FormatTestObjC, FormatObjCMethodExpr) { - verifyFormat("[foo bar:baz];"); - verifyFormat("return [foo bar:baz];"); - verifyFormat("return (a)[foo bar:baz];"); - verifyFormat("f([foo bar:baz]);"); - verifyFormat("f(2, [foo bar:baz]);"); - verifyFormat("f(2, a ? b : c);"); - verifyFormat("[[self initWithInt:4] bar:[baz quux:arrrr]];"); - - // Unary operators. - verifyFormat("int a = +[foo bar:baz];"); - verifyFormat("int a = -[foo bar:baz];"); - verifyFormat("int a = ![foo bar:baz];"); - verifyFormat("int a = ~[foo bar:baz];"); - verifyFormat("int a = ++[foo bar:baz];"); - verifyFormat("int a = --[foo bar:baz];"); - verifyFormat("int a = sizeof [foo bar:baz];"); - verifyFormat("int a = alignof [foo bar:baz];"); - verifyFormat("int a = &[foo bar:baz];"); - verifyFormat("int a = *[foo bar:baz];"); - // FIXME: Make casts work, without breaking f()[4]. - // verifyFormat("int a = (int)[foo bar:baz];"); - // verifyFormat("return (int)[foo bar:baz];"); - // verifyFormat("(void)[foo bar:baz];"); - verifyFormat("return (MyType *)[self.tableView cellForRowAtIndexPath:cell];"); - - // Binary operators. - verifyFormat("[foo bar:baz], [foo bar:baz];"); - verifyFormat("[foo bar:baz] = [foo bar:baz];"); - verifyFormat("[foo bar:baz] *= [foo bar:baz];"); - verifyFormat("[foo bar:baz] /= [foo bar:baz];"); - verifyFormat("[foo bar:baz] %= [foo bar:baz];"); - verifyFormat("[foo bar:baz] += [foo bar:baz];"); - verifyFormat("[foo bar:baz] -= [foo bar:baz];"); - verifyFormat("[foo bar:baz] <<= [foo bar:baz];"); - verifyFormat("[foo bar:baz] >>= [foo bar:baz];"); - verifyFormat("[foo bar:baz] &= [foo bar:baz];"); - verifyFormat("[foo bar:baz] ^= [foo bar:baz];"); - verifyFormat("[foo bar:baz] |= [foo bar:baz];"); - verifyFormat("[foo bar:baz] ? [foo bar:baz] : [foo bar:baz];"); - verifyFormat("[foo bar:baz] || [foo bar:baz];"); - verifyFormat("[foo bar:baz] && [foo bar:baz];"); - verifyFormat("[foo bar:baz] | [foo bar:baz];"); - verifyFormat("[foo bar:baz] ^ [foo bar:baz];"); - verifyFormat("[foo bar:baz] & [foo bar:baz];"); - verifyFormat("[foo bar:baz] == [foo bar:baz];"); - verifyFormat("[foo bar:baz] != [foo bar:baz];"); - verifyFormat("[foo bar:baz] >= [foo bar:baz];"); - verifyFormat("[foo bar:baz] <= [foo bar:baz];"); - verifyFormat("[foo bar:baz] > [foo bar:baz];"); - verifyFormat("[foo bar:baz] < [foo bar:baz];"); - verifyFormat("[foo bar:baz] >> [foo bar:baz];"); - verifyFormat("[foo bar:baz] << [foo bar:baz];"); - verifyFormat("[foo bar:baz] - [foo bar:baz];"); - verifyFormat("[foo bar:baz] + [foo bar:baz];"); - verifyFormat("[foo bar:baz] * [foo bar:baz];"); - verifyFormat("[foo bar:baz] / [foo bar:baz];"); - verifyFormat("[foo bar:baz] % [foo bar:baz];"); - // Whew! - - verifyFormat("return in[42];"); - verifyFormat("for (auto v : in[1]) {\n}"); - verifyFormat("for (int i = 0; i < in[a]; ++i) {\n}"); - verifyFormat("for (int i = 0; in[a] < i; ++i) {\n}"); - verifyFormat("for (int i = 0; i < n; ++i, ++in[a]) {\n}"); - verifyFormat("for (int i = 0; i < n; ++i, in[a]++) {\n}"); - verifyFormat("for (int i = 0; i < f(in[a]); ++i, in[a]++) {\n}"); - verifyFormat("for (id foo in [self getStuffFor:bla]) {\n" - "}"); - verifyFormat("[self aaaaa:MACRO(a, b:, c:)];"); - verifyFormat("[self aaaaa:MACRO(a, b:c:, d:e:)];"); - verifyFormat("[self aaaaa:MACRO(a, b:c:d:, e:f:g:)];"); - verifyFormat("int XYMyFoo(int a, int b) NS_SWIFT_NAME(foo(self:scale:));"); - verifyFormat("[self aaaaa:(1 + 2) bbbbb:3];"); - verifyFormat("[self aaaaa:(Type)a bbbbb:3];"); - - verifyFormat("[self stuffWithInt:(4 + 2) float:4.5];"); - verifyFormat("[self stuffWithInt:a ? b : c float:4.5];"); - verifyFormat("[self stuffWithInt:a ? [self foo:bar] : c];"); - verifyFormat("[self stuffWithInt:a ? (e ? f : g) : c];"); - verifyFormat("[cond ? obj1 : obj2 methodWithParam:param]"); - verifyFormat("[button setAction:@selector(zoomOut:)];"); - verifyFormat("[color getRed:&r green:&g blue:&b alpha:&a];"); - - verifyFormat("arr[[self indexForFoo:a]];"); - verifyFormat("throw [self errorFor:a];"); - verifyFormat("@throw [self errorFor:a];"); - - verifyFormat("[(id)foo bar:(id)baz quux:(id)snorf];"); - verifyFormat("[(id)foo bar:(id) ? baz : quux];"); - verifyFormat("4 > 4 ? (id)a : (id)baz;"); - - unsigned PreviousColumnLimit = Style.ColumnLimit; - Style.ColumnLimit = 50; - // Instead of: - // bool a = - // ([object a:42] == 0 || [object a:42 - // b:42] == 0); - verifyFormat("bool a = ([object a:42] == 0 ||\n" - " [object a:42 b:42] == 0);"); - Style.ColumnLimit = PreviousColumnLimit; - verifyFormat("bool a = ([aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaa ||\n" - " [aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaaaaa);"); - - // This tests that the formatter doesn't break after "backing" but before ":", - // which would be at 80 columns. - verifyFormat( - "void f() {\n" - " if ((self = [super initWithContentRect:contentRect\n" - " styleMask:styleMask ?: otherMask\n" - " backing:NSBackingStoreBuffered\n" - " defer:YES]))"); - - verifyFormat( - "[foo checkThatBreakingAfterColonWorksOk:\n" - " [bar ifItDoes:reduceOverallLineLengthLikeInThisCase]];"); - - verifyFormat("[myObj short:arg1 // Force line break\n" - " longKeyword:arg2 != nil ? arg2 : @\"longKeyword\"\n" - " evenLongerKeyword:arg3 ?: @\"evenLongerKeyword\"\n" - " error:arg4];"); - verifyFormat( - "void f() {\n" - " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" - " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n" - " pos.width(), pos.height())\n" - " styleMask:NSBorderlessWindowMask\n" - " backing:NSBackingStoreBuffered\n" - " defer:NO]);\n" - "}"); - verifyFormat("[contentsContainer replaceSubview:[subviews objectAtIndex:0]\n" - " with:contentsNativeView];"); - - verifyFormat( - "[pboard addTypes:[NSArray arrayWithObject:kBookmarkButtonDragType]\n" - " owner:nillllll];"); - - verifyFormat( - "[pboard setData:[NSData dataWithBytes:&button length:sizeof(button)]\n" - " forType:kBookmarkButtonDragType];"); - - verifyFormat("[defaultCenter addObserver:self\n" - " selector:@selector(willEnterFullscreen)\n" - " name:kWillEnterFullscreenNotification\n" - " object:nil];"); - verifyFormat("[image_rep drawInRect:drawRect\n" - " fromRect:NSZeroRect\n" - " operation:NSCompositeCopy\n" - " fraction:1.0\n" - " respectFlipped:NO\n" - " hints:nil];"); - verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); - verifyFormat("[aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" - " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); - verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaa[aaaaaaaaaaaaaaaaaaaaa]\n" - " aaaaaaaaaaaaaaaaaaaaaa];"); - - verifyFormat( - "scoped_nsobject<NSTextField> message(\n" - " // The frame will be fixed up when |-setMessageText:| is called.\n" - " [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 0, 0)]);"); - verifyFormat("[self aaaaaa:bbbbbbbbbbbbb\n" - " aaaaaaaaaa:bbbbbbbbbbbbbbbbb\n" - " aaaaa:bbbbbbbbbbb + bbbbbbbbbbbb\n" - " aaaa:bbb];"); - verifyFormat("[self param:function( //\n" - " parameter)]"); - verifyFormat( - "[self aaaaaaaaaa:aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" - " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" - " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa];"); - - // Variadic parameters. - verifyFormat( - "NSArray *myStrings = [NSArray stringarray:@\"a\", @\"b\", nil];"); - verifyFormat( - "[self aaaaaaaaaaaaa:aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" - " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa];"); - - verifyFormat("[self // break\n" - " a:a\n" - " aaa:aaa];"); - - // Formats pair-parameters. - verifyFormat("[I drawRectOn:surface ofSize:aa:bbb atOrigin:cc:dd];"); - verifyFormat("[I drawRectOn:surface //\n" - " ofSize:aa:bbb\n" - " atOrigin:cc:dd];"); - - // Inline block as a first argument. - verifyFormat("[object justBlock:^{\n" - " a = 42;\n" - "}];"); - verifyFormat("[object\n" - " justBlock:^{\n" - " a = 42;\n" - " }\n" - " notBlock:42\n" - " a:42];"); - verifyFormat("[object\n" - " firstBlock:^{\n" - " a = 42;\n" - " }\n" - " blockWithLongerName:^{\n" - " a = 42;\n" - " }];"); - verifyFormat("[object\n" - " blockWithLongerName:^{\n" - " a = 42;\n" - " }\n" - " secondBlock:^{\n" - " a = 42;\n" - " }];"); - verifyFormat("[object\n" - " firstBlock:^{\n" - " a = 42;\n" - " }\n" - " notBlock:42\n" - " secondBlock:^{\n" - " a = 42;\n" - " }];"); - - // Space between cast rparen and selector name component. - verifyFormat("[((Foo *)foo) bar];"); - verifyFormat("[((Foo *)foo) bar:1 blech:2];"); - - Style.ColumnLimit = 20; - verifyFormat("aaaaa = [a aa:aa\n" - " aa:aa];"); - verifyFormat("aaaaaa = [aa aa:aa\n" - " aa:aa];"); - - // Message receiver taking multiple lines. - // Non-corner case. - verifyFormat("[[object block:^{\n" - " return 42;\n" - "}] a:42 b:42];"); - // Arguments just fit into one line. - verifyFormat("[[object block:^{\n" - " return 42;\n" - "}] aaaaaaa:42 b:42];"); - // Arguments just over a column limit. - verifyFormat("[[object block:^{\n" - " return 42;\n" - "}] aaaaaaa:42\n" - " bb:42];"); - // Arguments just fit into one line. - Style.ColumnLimit = 23; - verifyFormat("[[obj a:42\n" - " b:42\n" - " c:42\n" - " d:42] e:42 f:42];"); - - // Arguments do not fit into one line with a receiver. - Style.ColumnLimit = 20; - verifyFormat("[[obj a:42] a:42\n" - " b:42];"); - verifyFormat("[[obj a:42] a:42\n" - " b:42\n" - " c:42];"); - verifyFormat("[[obj aaaaaa:42\n" - " b:42]\n" - " cc:42\n" - " d:42];"); - - // Avoid breaking receiver expression. - Style.ColumnLimit = 30; - verifyFormat("fooooooo =\n" - " [[obj fooo] aaa:42\n" - " aaa:42];"); - verifyFormat("[[[obj foo] bar] aa:42\n" - " bb:42\n" - " cc:42];"); - - Style.ColumnLimit = 70; - verifyFormat( - "void f() {\n" - " popup_wdow_.reset([[RenderWidgetPopupWindow alloc]\n" - " iniithContentRect:NSMakRet(origin_global.x, origin_global.y,\n" - " pos.width(), pos.height())\n" - " syeMask:NSBorderlessWindowMask\n" - " bking:NSBackingStoreBuffered\n" - " der:NO]);\n" - "}"); - - Style.ColumnLimit = 60; - verifyFormat("[call aaaaaaaa.aaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa\n" - " .aaaaaaaa];"); // FIXME: Indentation seems off. - // FIXME: This violates the column limit. - verifyFormat( - "[aaaaaaaaaaaaaaaaaaaaaaaaa\n" - " aaaaaaaaaaaaaaaaa:aaaaaaaa\n" - " aaa:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); - - Style = getChromiumStyle(FormatStyle::LK_ObjC); - Style.ColumnLimit = 80; - verifyFormat( - "void f() {\n" - " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" - " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n" - " pos.width(), pos.height())\n" - " styleMask:NSBorderlessWindowMask\n" - " backing:NSBackingStoreBuffered\n" - " defer:NO]);\n" - "}"); - - // Respect continuation indent and colon alignment (e.g. when object name is - // short, and first selector is the longest one) - Style = getLLVMStyle(); - Style.Language = FormatStyle::LK_ObjC; - Style.ContinuationIndentWidth = 8; - verifyFormat("[self performSelectorOnMainThread:@selector(loadAccessories)\n" - " withObject:nil\n" - " waitUntilDone:false];"); - verifyFormat("[self performSelector:@selector(loadAccessories)\n" - " withObjectOnMainThread:nil\n" - " waitUntilDone:false];"); - verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaaaa\n" - " performSelectorOnMainThread:@selector(loadAccessories)\n" - " withObject:nil\n" - " waitUntilDone:false];"); - verifyFormat("[self // force wrapping\n" - " performSelectorOnMainThread:@selector(loadAccessories)\n" - " withObject:nil\n" - " waitUntilDone:false];"); -} - -TEST_F(FormatTestObjC, ObjCAt) { - verifyFormat("@autoreleasepool"); - verifyFormat("@catch"); - verifyFormat("@class"); - verifyFormat("@compatibility_alias"); - verifyFormat("@defs"); - verifyFormat("@dynamic"); - verifyFormat("@encode"); - verifyFormat("@end"); - verifyFormat("@finally"); - verifyFormat("@implementation"); - verifyFormat("@import"); - verifyFormat("@interface"); - verifyFormat("@optional"); - verifyFormat("@package"); - verifyFormat("@private"); - verifyFormat("@property"); - verifyFormat("@protected"); - verifyFormat("@protocol"); - verifyFormat("@public"); - verifyFormat("@required"); - verifyFormat("@selector"); - verifyFormat("@synchronized"); - verifyFormat("@synthesize"); - verifyFormat("@throw"); - verifyFormat("@try"); - - EXPECT_EQ("@interface", format("@ interface")); - - // The precise formatting of this doesn't matter, nobody writes code like - // this. - verifyFormat("@ /*foo*/ interface"); -} - -TEST_F(FormatTestObjC, ObjCBlockTypesAndVariables) { - verifyFormat("void DoStuffWithBlockType(int (^)(char));"); - verifyFormat("int (^foo)(char, float);"); - verifyFormat("int (^foo[10])(char, float);"); - verifyFormat("int (^foo[kNumEntries])(char, float);"); - verifyFormat("int (^foo[kNumEntries + 10])(char, float);"); - verifyFormat("int (^foo[(kNumEntries + 10)])(char, float);"); -} - -TEST_F(FormatTestObjC, ObjCSnippets) { - verifyFormat("@autoreleasepool {\n" - " foo();\n" - "}"); - verifyFormat("@class Foo, Bar;"); - verifyFormat("@compatibility_alias AliasName ExistingClass;"); - verifyFormat("@dynamic textColor;"); - verifyFormat("char *buf1 = @encode(int *);"); - verifyFormat("char *buf1 = @encode(typeof(4 * 5));"); - verifyFormat("char *buf1 = @encode(int **);"); - verifyFormat("Protocol *proto = @protocol(p1);"); - verifyFormat("SEL s = @selector(foo:);"); - verifyFormat("@synchronized(self) {\n" - " f();\n" - "}"); - - verifyFormat("@import foo.bar;\n" - "@import baz;"); - - verifyFormat("@synthesize dropArrowPosition = dropArrowPosition_;"); - - verifyFormat("@property(assign, nonatomic) CGFloat hoverAlpha;"); - verifyFormat("@property(assign, getter=isEditable) BOOL editable;"); - - Style.ColumnLimit = 50; - verifyFormat("@interface Foo\n" - "- (void)doStuffWithFoo:(id)name\n" - " bar:(id)bar\n" - " baz:(id)baz\n" - " NS_SWIFT_NAME(doStuff(withFoo:bar:baz:));\n" - "@end"); - - Style = getMozillaStyle(); - verifyFormat("@property (assign, getter=isEditable) BOOL editable;"); - verifyFormat("@property BOOL editable;"); - - Style = getWebKitStyle(); - verifyFormat("@property (assign, getter=isEditable) BOOL editable;"); - verifyFormat("@property BOOL editable;"); - - Style = getGoogleStyle(FormatStyle::LK_ObjC); - verifyFormat("@synthesize dropArrowPosition = dropArrowPosition_;"); - verifyFormat("@property(assign, getter=isEditable) BOOL editable;"); -} - -TEST_F(FormatTestObjC, ObjCForIn) { - verifyFormat("- (void)test {\n" - " for (NSString *n in arrayOfStrings) {\n" - " foo(n);\n" - " }\n" - "}"); - verifyFormat("- (void)test {\n" - " for (NSString *n in (__bridge NSArray *)arrayOfStrings) {\n" - " foo(n);\n" - " }\n" - "}"); - verifyFormat("for (Foo *x in bar) {\n}"); - verifyFormat("for (Foo *x in [bar baz]) {\n}"); - verifyFormat("for (Foo *x in [bar baz:blech]) {\n}"); - verifyFormat("for (Foo *x in [bar baz:blech, 1, 2, 3, 0]) {\n}"); - verifyFormat("for (Foo *x in [bar baz:^{\n" - " [uh oh];\n" - " }]) {\n}"); -} - -TEST_F(FormatTestObjC, ObjCCxxKeywords) { - verifyFormat("+ (instancetype)new {\n" - " return nil;\n" - "}\n"); - verifyFormat("+ (instancetype)myNew {\n" - " return [self new];\n" - "}\n"); - verifyFormat("SEL NewSelector(void) { return @selector(new); }\n"); - verifyFormat("SEL MacroSelector(void) { return MACRO(new); }\n"); - verifyFormat("+ (instancetype)delete {\n" - " return nil;\n" - "}\n"); - verifyFormat("+ (instancetype)myDelete {\n" - " return [self delete];\n" - "}\n"); - verifyFormat("SEL DeleteSelector(void) { return @selector(delete); }\n"); - verifyFormat("SEL MacroSelector(void) { return MACRO(delete); }\n"); - verifyFormat("MACRO(new:)\n"); - verifyFormat("MACRO(delete:)\n"); - verifyFormat("foo = @{MACRO(new:) : MACRO(delete:)}\n"); - verifyFormat("@implementation Foo\n" - "// Testing\n" - "- (Class)class {\n" - "}\n" - "- (void)foo {\n" - "}\n" - "@end\n"); - verifyFormat("@implementation Foo\n" - "- (Class)class {\n" - "}\n" - "- (void)foo {\n" - "}\n" - "@end"); - verifyFormat("@implementation Foo\n" - "+ (Class)class {\n" - "}\n" - "- (void)foo {\n" - "}\n" - "@end"); - verifyFormat("@implementation Foo\n" - "- (Class)class:(Class)klass {\n" - "}\n" - "- (void)foo {\n" - "}\n" - "@end"); - verifyFormat("@implementation Foo\n" - "+ (Class)class:(Class)klass {\n" - "}\n" - "- (void)foo {\n" - "}\n" - "@end"); - - verifyFormat("@interface Foo\n" - "// Testing\n" - "- (Class)class;\n" - "- (void)foo;\n" - "@end\n"); - verifyFormat("@interface Foo\n" - "- (Class)class;\n" - "- (void)foo;\n" - "@end"); - verifyFormat("@interface Foo\n" - "+ (Class)class;\n" - "- (void)foo;\n" - "@end"); - verifyFormat("@interface Foo\n" - "- (Class)class:(Class)klass;\n" - "- (void)foo;\n" - "@end"); - verifyFormat("@interface Foo\n" - "+ (Class)class:(Class)klass;\n" - "- (void)foo;\n" - "@end"); -} - -TEST_F(FormatTestObjC, ObjCLiterals) { - verifyFormat("@\"String\""); - verifyFormat("@1"); - verifyFormat("@+4.8"); - verifyFormat("@-4"); - verifyFormat("@1LL"); - verifyFormat("@.5"); - verifyFormat("@'c'"); - verifyFormat("@true"); - - verifyFormat("NSNumber *smallestInt = @(-INT_MAX - 1);"); - verifyFormat("NSNumber *piOverTwo = @(M_PI / 2);"); - verifyFormat("NSNumber *favoriteColor = @(Green);"); - verifyFormat("NSString *path = @(getenv(\"PATH\"));"); - - verifyFormat("[dictionary setObject:@(1) forKey:@\"number\"];"); -} - -TEST_F(FormatTestObjC, ObjCDictLiterals) { - verifyFormat("@{"); - verifyFormat("@{}"); - verifyFormat("@{@\"one\" : @1}"); - verifyFormat("return @{@\"one\" : @1;"); - verifyFormat("@{@\"one\" : @1}"); - - verifyFormat("@{@\"one\" : @{@2 : @1}}"); - verifyFormat("@{\n" - " @\"one\" : @{@2 : @1},\n" - "}"); - - verifyFormat("@{1 > 2 ? @\"one\" : @\"two\" : 1 > 2 ? @1 : @2}"); - verifyIncompleteFormat("[self setDict:@{}"); - verifyIncompleteFormat("[self setDict:@{@1 : @2}"); - verifyFormat("NSLog(@\"%@\", @{@1 : @2, @2 : @3}[@1]);"); - verifyFormat( - "NSDictionary *masses = @{@\"H\" : @1.0078, @\"He\" : @4.0026};"); - verifyFormat( - "NSDictionary *settings = @{AVEncoderKey : @(AVAudioQualityMax)};"); - - verifyFormat("NSDictionary *d = @{\n" - " @\"nam\" : NSUserNam(),\n" - " @\"dte\" : [NSDate date],\n" - " @\"processInfo\" : [NSProcessInfo processInfo]\n" - "};"); - verifyFormat( - "@{\n" - " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " - "regularFont,\n" - "};"); - verifyFormat( - "@{\n" - " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee :\n" - " reeeeeeeeeeeeeeeeeeeeeeeegularFont,\n" - "};"); - - // We should try to be robust in case someone forgets the "@". - verifyFormat("NSDictionary *d = {\n" - " @\"nam\" : NSUserNam(),\n" - " @\"dte\" : [NSDate date],\n" - " @\"processInfo\" : [NSProcessInfo processInfo]\n" - "};"); - verifyFormat("NSMutableDictionary *dictionary =\n" - " [NSMutableDictionary dictionaryWithDictionary:@{\n" - " aaaaaaaaaaaaaaaaaaaaa : aaaaaaaaaaaaa,\n" - " bbbbbbbbbbbbbbbbbb : bbbbb,\n" - " cccccccccccccccc : ccccccccccccccc\n" - " }];"); - - // Ensure that casts before the key are kept on the same line as the key. - verifyFormat( - "NSDictionary *d = @{\n" - " (aaaaaaaa id)aaaaaaaaa : (aaaaaaaa id)aaaaaaaaaaaaaaaaaaaaaaaa,\n" - " (aaaaaaaa id)aaaaaaaaaaaaaa : (aaaaaaaa id)aaaaaaaaaaaaaa,\n" - "};"); - Style.ColumnLimit = 40; - verifyFormat("int Foo() {\n" - " a12345 = @{a12345 : a12345};\n" - "}"); - verifyFormat("int Foo() {\n" - " a12345 = @{a12345 : @(a12345)};\n" - "}"); - verifyFormat("int Foo() {\n" - " a12345 = @{(Foo *)a12345 : @(a12345)};\n" - "}"); - verifyFormat("int Foo() {\n" - " a12345 = @{@(a12345) : a12345};\n" - "}"); - verifyFormat("int Foo() {\n" - " a12345 = @{@(a12345) : @YES};\n" - "}"); - Style.SpacesInContainerLiterals = false; - verifyFormat("int Foo() {\n" - " b12345 = @{b12345: b12345};\n" - "}"); - verifyFormat("int Foo() {\n" - " b12345 = @{(Foo *)b12345: @(b12345)};\n" - "}"); - Style.SpacesInContainerLiterals = true; - - Style = getGoogleStyle(FormatStyle::LK_ObjC); - verifyFormat( - "@{\n" - " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " - "regularFont,\n" - "};"); -} - -TEST_F(FormatTestObjC, ObjCArrayLiterals) { - verifyIncompleteFormat("@["); - verifyFormat("@[]"); - verifyFormat( - "NSArray *array = @[ @\" Hey \", NSApp, [NSNumber numberWithInt:42] ];"); - verifyFormat("return @[ @3, @[], @[ @4, @5 ] ];"); - verifyFormat("NSArray *array = @[ [foo description] ];"); - - verifyFormat( - "NSArray *some_variable = @[\n" - " aaaa == bbbbbbbbbbb ? @\"aaaaaaaaaaaa\" : @\"aaaaaaaaaaaaaa\",\n" - " @\"aaaaaaaaaaaaaaaaa\",\n" - " @\"aaaaaaaaaaaaaaaaa\",\n" - " @\"aaaaaaaaaaaaaaaaa\",\n" - "];"); - verifyFormat( - "NSArray *some_variable = @[\n" - " aaaa == bbbbbbbbbbb ? @\"aaaaaaaaaaaa\" : @\"aaaaaaaaaaaaaa\",\n" - " @\"aaaaaaaaaaaaaaaa\", @\"aaaaaaaaaaaaaaaa\", @\"aaaaaaaaaaaaaaaa\"\n" - "];"); - verifyFormat("NSArray *some_variable = @[\n" - " @\"aaaaaaaaaaaaaaaaa\",\n" - " @\"aaaaaaaaaaaaaaaaa\",\n" - " @\"aaaaaaaaaaaaaaaaa\",\n" - " @\"aaaaaaaaaaaaaaaaa\",\n" - "];"); - verifyFormat("NSArray *array = @[\n" - " @\"a\",\n" - " @\"a\",\n" // Trailing comma -> one per line. - "];"); - - // We should try to be robust in case someone forgets the "@". - verifyFormat("NSArray *some_variable = [\n" - " @\"aaaaaaaaaaaaaaaaa\",\n" - " @\"aaaaaaaaaaaaaaaaa\",\n" - " @\"aaaaaaaaaaaaaaaaa\",\n" - " @\"aaaaaaaaaaaaaaaaa\",\n" - "];"); - verifyFormat( - "- (NSAttributedString *)attributedStringForSegment:(NSUInteger)segment\n" - " index:(NSUInteger)index\n" - " nonDigitAttributes:\n" - " (NSDictionary *)noDigitAttributes;"); - verifyFormat("[someFunction someLooooooooooooongParameter:@[\n" - " NSBundle.mainBundle.infoDictionary[@\"a\"]\n" - "]];"); - Style.ColumnLimit = 40; - verifyFormat("int Foo() {\n" - " a12345 = @[ a12345, a12345 ];\n" - "}"); - verifyFormat("int Foo() {\n" - " a123 = @[ (Foo *)a12345, @(a12345) ];\n" - "}"); - Style.SpacesInContainerLiterals = false; - verifyFormat("int Foo() {\n" - " b12345 = @[b12345, b12345];\n" - "}"); - verifyFormat("int Foo() {\n" - " b12345 = @[(Foo *)b12345, @(b12345)];\n" - "}"); - Style.SpacesInContainerLiterals = true; - Style.ColumnLimit = 20; - // We can't break string literals inside NSArray literals - // (that raises -Wobjc-string-concatenation). - verifyFormat("NSArray *foo = @[\n" - " @\"aaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" - "];\n"); -} - -TEST_F(FormatTestObjC, BreaksCallStatementWhereSemiJustOverTheLimit) { - Style.ColumnLimit = 60; - // If the statement starting with 'a = ...' is put on a single line, the ';' - // is at line 61. - verifyFormat("int f(int a) {\n" - " a = [self aaaaaaaaaa:bbbbbbbbb\n" - " ccccccccc:dddddddd\n" - " ee:fddd];\n" - "}"); -} - -TEST_F(FormatTestObjC, AlwaysBreakBeforeMultilineStrings) { - Style = getGoogleStyle(FormatStyle::LK_ObjC); - Style.ColumnLimit = 40; - verifyFormat("aaaa = @\"bbbb\"\n" - " @\"cccc\";"); - verifyFormat("aaaa(@\"bbbb\"\n" - " @\"cccc\");"); - verifyFormat("aaaa(qqq, @\"bbbb\"\n" - " @\"cccc\");"); - verifyFormat("[aaaa qqqq:@\"bbbb\"\n" - " @\"cccc\"];"); - verifyFormat("aaaa = [aaaa qqqq:@\"bbbb\"\n" - " @\"cccc\"];"); - verifyFormat("[aaaa qqqq:@\"bbbb\"\n" - " @\"cccc\"\n" - " rr:42\n" - " ssssss:@\"ee\"\n" - " @\"fffff\"];"); -} - -} // end namespace -} // end namespace format -} // end namespace clang diff --git a/unittests/Format/FormatTestProto.cpp b/unittests/Format/FormatTestProto.cpp deleted file mode 100644 index 70ef2d2f13445..0000000000000 --- a/unittests/Format/FormatTestProto.cpp +++ /dev/null @@ -1,653 +0,0 @@ -//===- unittest/Format/FormatTestProto.cpp --------------------------------===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "FormatTestUtils.h" -#include "clang/Format/Format.h" -#include "llvm/Support/Debug.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -namespace clang { -namespace format { - -class FormatTestProto : public ::testing::Test { -protected: - static std::string format(llvm::StringRef Code, unsigned Offset, - unsigned Length, const FormatStyle &Style) { - LLVM_DEBUG(llvm::errs() << "---\n"); - LLVM_DEBUG(llvm::errs() << Code << "\n\n"); - std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length)); - tooling::Replacements Replaces = reformat(Style, Code, Ranges); - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); - return *Result; - } - - static std::string format(llvm::StringRef Code) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_Proto); - Style.ColumnLimit = 60; // To make writing tests easier. - return format(Code, 0, Code.size(), Style); - } - - static void verifyFormat(llvm::StringRef Code) { - EXPECT_EQ(Code.str(), format(Code)) << "Expected code is not stable"; - EXPECT_EQ(Code.str(), format(test::messUp(Code))); - } -}; - -TEST_F(FormatTestProto, FormatsMessages) { - verifyFormat("message SomeMessage {\n" - " required int32 field1 = 1;\n" - "}"); - verifyFormat("message SomeMessage {\n" - " required .absolute.Reference field1 = 1;\n" - "}"); - verifyFormat("message SomeMessage {\n" - " required int32 field1 = 1;\n" - " optional string field2 = 2 [default = \"2\"]\n" - "}"); - - verifyFormat("message SomeMessage {\n" - " optional really.really.long.qualified.type.aaa.aaaaaaa\n" - " fiiiiiiiiiiiiiiiiiiiiiiiiield = 1;\n" - " optional\n" - " really.really.long.qualified.type.aaa.aaaaaaa.aaaaaaaa\n" - " another_fiiiiiiiiiiiiiiiiiiiiield = 2;\n" - "}"); - verifyFormat("message SomeMessage {\n" - " map<string, Project> projects = 1;\n" - " optional map<string, int32> size_projects = 2;\n" - " map<int, really.really.really.long.qualified.type.nameeee>\n" - " projects = 3;\n" - " map<int, really.really.really.really.long.qualified.type\n" - " .nameeee> projects = 4;\n" - " map<int,\n" - " reallyreallyreallyreallyreallyreallyreallylongname>\n" - " projects = 5;\n" - " map<int, Project>\n" - " longlonglonglonglonglonglonglonglonglongonglon = 6;\n" - " map<releleallyreallyreallyreallyreallyreallyreallylongname,\n" - " int> projects = 7;\n" - " map<releleallyreallyreallyreallyreallyreallyreallylongname,\n" - " releleallyreallyreallyreallyreallyreallyreallylongname>\n" - " releleallyreallyreallyreallyreallyreallyreallylongnam =\n" - " 8;\n" - " map<relele.llyreal.yreallyr.allyreally.eallyreal\n" - " .sauenirylongname,\n" - " really.really.really.really.long.qualified.type\n" - " .nameeee> projects = 9;\n" - "}"); -} - -TEST_F(FormatTestProto, KeywordsInOtherLanguages) { - verifyFormat("optional string operator = 1;"); -} - -TEST_F(FormatTestProto, FormatsEnums) { - verifyFormat("enum Type {\n" - " UNKNOWN = 0;\n" - " TYPE_A = 1;\n" - " TYPE_B = 2;\n" - "};"); - verifyFormat("enum Type {\n" - " UNKNOWN = 0 [(some_options) = { a: aa, b: bb }];\n" - "};"); - verifyFormat("enum Type {\n" - " UNKNOWN = 0 [(some_options) = {\n" - " a: aa, // wrap\n" - " b: bb\n" - " }];\n" - "};"); -} - -TEST_F(FormatTestProto, UnderstandsReturns) { - verifyFormat("rpc Search(SearchRequest) returns (SearchResponse);"); -} - -TEST_F(FormatTestProto, MessageFieldAttributes) { - verifyFormat("optional string test = 1 [default = \"test\"];"); - verifyFormat("optional bool a = 1 [default = true, deprecated = true];"); - verifyFormat("optional LongMessageType long_proto_field = 1 [\n" - " default = REALLY_REALLY_LONG_CONSTANT_VALUE,\n" - " deprecated = true\n" - "];"); - verifyFormat("optional LongMessageType long_proto_field = 1\n" - " [default = REALLY_REALLY_LONG_CONSTANT_VALUE];"); - verifyFormat("repeated double value = 1\n" - " [(aaaaaaa.aaaaaaaaa) = { aaaaaaaaaaaaaaaaa: AAAAAAAA }];"); - verifyFormat("repeated double value = 1 [(aaaaaaa.aaaaaaaaa) = {\n" - " aaaaaaaaaaaaaaaa: AAAAAAAAAA,\n" - " bbbbbbbbbbbbbbbb: BBBBBBBBBB\n" - "}];"); - verifyFormat("repeated double value = 1 [(aaaaaaa.aaaaaaaaa) = {\n" - " aaaaaaaaaaaaaaaa: AAAAAAAAAA\n" - " bbbbbbbbbbbbbbbb: BBBBBBBBBB\n" - "}];"); - verifyFormat("repeated double value = 1 [\n" - " (aaaaaaa.aaaaaaaaa) = {\n" - " aaaaaaaaaaaaaaaa: AAAAAAAAAA\n" - " bbbbbbbbbbbbbbbb: BBBBBBBBBB\n" - " },\n" - " (bbbbbbb.bbbbbbbbb) = {\n" - " aaaaaaaaaaaaaaaa: AAAAAAAAAA\n" - " bbbbbbbbbbbbbbbb: BBBBBBBBBB\n" - " }\n" - "];"); - verifyFormat("repeated double value = 1 [(aaaaaaa.aaaaaaaaa) = {\n" - " type: \"AAAAAAAAAA\"\n" - " is: \"AAAAAAAAAA\"\n" - " or: \"BBBBBBBBBB\"\n" - "}];"); - verifyFormat("repeated double value = 1 [(aaaaaaa.aaaaaaaaa) = {\n" - " aaaaaaaaaaaaaaaa: AAAAAAAAAA,\n" - " bbbbbbb: BBBB,\n" - " bbbb: BBB\n" - "}];"); - verifyFormat("optional AAA aaa = 1 [\n" - " foo = {\n" - " key: 'a' //\n" - " },\n" - " bar = {\n" - " key: 'a' //\n" - " }\n" - "];"); - verifyFormat("optional string test = 1 [default = \"test\"\n" - " \"test\"];"); - verifyFormat("optional Aaaaaaaa aaaaaaaa = 12 [\n" - " (aaa) = aaaa,\n" - " (bbbbbbbbbbbbbbbbbbbbbbbbbb) = {\n" - " aaaaaaaaaaaaaaaaa: true,\n" - " aaaaaaaaaaaaaaaa: true\n" - " }\n" - "];"); - verifyFormat("extensions 20 [(proto2.type) = 'Aaaa.bbbb'];"); - verifyFormat("extensions 20\n" - " [(proto3.type) = 'Aaaa.bbbb', (aaa.Aaa) = 'aaa.bbb'];"); - verifyFormat("extensions 123 [\n" - " (aaa) = aaaa,\n" - " (bbbbbbbbbbbbbbbbbbbbbbbbbb) = {\n" - " aaaaaaaaaaaaaaaaa: true,\n" - " aaaaaaaaaaaaaaaa: true\n" - " }\n" - "];"); -} - -TEST_F(FormatTestProto, DoesntWrapFileOptions) { - EXPECT_EQ( - "option java_package = " - "\"some.really.long.package.that.exceeds.the.column.limit\";", - format("option java_package = " - "\"some.really.long.package.that.exceeds.the.column.limit\";")); -} - -TEST_F(FormatTestProto, FormatsOptions) { - verifyFormat("option (MyProto.options) = {\n" - " field_a: OK\n" - " field_b: \"OK\"\n" - " field_c: \"OK\"\n" - " msg_field: { field_d: 123 }\n" - "};"); - verifyFormat("option (MyProto.options) = {\n" - " field_a: OK\n" - " field_b: \"OK\"\n" - " field_c: \"OK\"\n" - " msg_field: { field_d: 123 field_e: OK }\n" - "};"); - verifyFormat("option (MyProto.options) = {\n" - " field_a: OK // Comment\n" - " field_b: \"OK\"\n" - " field_c: \"OK\"\n" - " msg_field: { field_d: 123 }\n" - "};"); - verifyFormat("option (MyProto.options) = {\n" - " field_c: \"OK\"\n" - " msg_field { field_d: 123 }\n" - "};"); - verifyFormat("option (MyProto.options) = {\n" - " field_a: OK\n" - " field_b { field_c: OK }\n" - " field_d: OKOKOK\n" - " field_e: OK\n" - "}"); - - // Support syntax with <> instead of {}. - verifyFormat("option (MyProto.options) = {\n" - " field_c: \"OK\",\n" - " msg_field: < field_d: 123 >\n" - " empty: <>\n" - " empty <>\n" - "};"); - - verifyFormat("option (MyProto.options) = {\n" - " field_a: OK\n" - " field_b < field_c: OK >\n" - " field_d: OKOKOK\n" - " field_e: OK\n" - "}"); - - verifyFormat("option (MyProto.options) = {\n" - " msg_field: <>\n" - " field_c: \"OK\",\n" - " msg_field: < field_d: 123 >\n" - " field_e: OK\n" - " msg_field: < field_d: 12 >\n" - "};"); - - verifyFormat("option (MyProto.options) = <\n" - " field_a: OK\n" - " field_b: \"OK\"\n" - " field_c: 1\n" - " field_d: 12.5\n" - " field_e: OK\n" - ">;"); - - verifyFormat("option (MyProto.options) = <\n" - " field_a: OK,\n" - " field_b: \"OK\",\n" - " field_c: 1,\n" - " field_d: 12.5,\n" - " field_e: OK,\n" - ">;"); - - verifyFormat("option (MyProto.options) = <\n" - " field_a: \"OK\"\n" - " msg_field: { field_b: OK }\n" - " field_g: OK\n" - " field_g: OK\n" - " field_g: OK\n" - ">;"); - - verifyFormat("option (MyProto.options) = <\n" - " field_a: \"OK\"\n" - " msg_field <\n" - " field_b: OK\n" - " field_c: OK\n" - " field_d: OK\n" - " field_e: OK\n" - " field_f: OK\n" - " >\n" - " field_g: OK\n" - ">;"); - - verifyFormat("option (MyProto.options) = <\n" - " field_a: \"OK\"\n" - " msg_field <\n" - " field_b: OK,\n" - " field_c: OK,\n" - " field_d: OK,\n" - " field_e: OK,\n" - " field_f: OK\n" - " >\n" - " field_g: OK\n" - ">;"); - - verifyFormat("option (MyProto.options) = <\n" - " field_a: \"OK\"\n" - " msg_field: <\n" - " field_b: OK\n" - " field_c: OK\n" - " field_d: OK\n" - " field_e: OK\n" - " field_f: OK\n" - " >\n" - " field_g: OK\n" - ">;"); - - verifyFormat("option (MyProto.options) = <\n" - " field_a: \"OK\"\n" - " msg_field: {\n" - " field_b: OK\n" - " field_c: OK\n" - " field_d: OK\n" - " field_e: OK\n" - " field_f: OK\n" - " }\n" - " field_g: OK\n" - ">;"); - - verifyFormat("option (MyProto.options) = <\n" - " field_a: \"OK\"\n" - " msg_field {\n" - " field_b: OK\n" - " field_c: OK\n" - " field_d: OK\n" - " field_e: OK\n" - " field_f: OK\n" - " }\n" - " field_g: OK\n" - ">;"); - - verifyFormat("option (MyProto.options) = {\n" - " field_a: \"OK\"\n" - " msg_field <\n" - " field_b: OK\n" - " field_c: OK\n" - " field_d: OK\n" - " field_e: OK\n" - " field_f: OK\n" - " >\n" - " field_g: OK\n" - "};"); - - verifyFormat("option (MyProto.options) = {\n" - " field_a: \"OK\"\n" - " msg_field: <\n" - " field_b: OK\n" - " field_c: OK\n" - " field_d: OK\n" - " field_e: OK\n" - " field_f: OK\n" - " >\n" - " field_g: OK\n" - "};"); - - verifyFormat("option (MyProto.options) = <\n" - " field_a: \"OK\"\n" - " msg_field {\n" - " field_b: OK\n" - " field_c: OK\n" - " field_d: OK\n" - " msg_field <\n" - " field_A: 1\n" - " field_B: 2\n" - " field_C: 3\n" - " field_D: 4\n" - " field_E: 5\n" - " >\n" - " msg_field < field_A: 1 field_B: 2 field_C: 3 f_D: 4 >\n" - " field_e: OK\n" - " field_f: OK\n" - " }\n" - " field_g: OK\n" - ">;"); - - verifyFormat("option (MyProto.options) = <\n" - " data1 < key1: value1 >\n" - " data2 { key2: value2 }\n" - ">;"); - - verifyFormat("option (MyProto.options) = <\n" - " app_id: 'com.javax.swing.salsa.latino'\n" - " head_id: 1\n" - " data < key: value >\n" - ">;"); - - verifyFormat("option (MyProto.options) = {\n" - " app_id: 'com.javax.swing.salsa.latino'\n" - " head_id: 1\n" - " headheadheadheadheadhead_id: 1\n" - " product_data { product { 1 } }\n" - "};"); -} - -TEST_F(FormatTestProto, FormatsService) { - verifyFormat("service SearchService {\n" - " rpc Search(SearchRequest) returns (SearchResponse) {\n" - " option foo = true;\n" - " }\n" - "};"); -} - -TEST_F(FormatTestProto, ExtendingMessage) { - verifyFormat("extend .foo.Bar {}"); -} - -TEST_F(FormatTestProto, FormatsImports) { - verifyFormat("import \"a.proto\";\n" - "import \"b.proto\";\n" - "// comment\n" - "message A {}"); - - verifyFormat("import public \"a.proto\";\n" - "import \"b.proto\";\n" - "// comment\n" - "message A {}"); - - // Missing semicolons should not confuse clang-format. - verifyFormat("import \"a.proto\"\n" - "import \"b.proto\"\n" - "// comment\n" - "message A {}"); -} - -TEST_F(FormatTestProto, KeepsLongStringLiteralsOnSameLine) { - verifyFormat( - "option (MyProto.options) = {\n" - " foo: {\n" - " text: \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaasaaaaaaaa\"\n" - " }\n" - "}"); -} - -TEST_F(FormatTestProto, FormatsOptionsExtensions) { - verifyFormat("option (MyProto.options) = {\n" - " msg_field: { field_d: 123 }\n" - " [ext.t/u] { key: value }\n" - " key: value\n" - " [t.u/v] <\n" - " [ext] { key: value }\n" - " >\n" - "};"); -} - -TEST_F(FormatTestProto, SpacesAroundPercents) { - verifyFormat("option (MyProto.options) = {\n" - " key: %lld\n" - " key: 0x%04x\n" - " key: \"%d %d\"\n" - "};"); -} - -TEST_F(FormatTestProto, FormatsRepeatedListInitializersInOptions) { - verifyFormat("option (MyProto.options) = {\n" - " key: item\n" - " keys: [\n" - " 'ala',\n" - " 'bala',\n" - " 'porto',\n" - " 'kala',\n" - " 'too',\n" - " 'long',\n" - " 'long',\n" - " 'long'\n" - " ]\n" - " key: [ item ]\n" - " msg {\n" - " key: item\n" - " keys: [\n" - " 'ala',\n" - " 'bala',\n" - " 'porto',\n" - " 'kala',\n" - " 'too',\n" - " 'long',\n" - " 'long'\n" - " ]\n" - " }\n" - " key: value\n" - "};"); -} - -TEST_F(FormatTestProto, AcceptsOperatorAsKeyInOptions) { - verifyFormat("option (MyProto.options) = {\n" - " bbbbbbbbb: <\n" - " ccccccccccccccccccccccc: <\n" - " operator: 1\n" - " operator: 2\n" - " operator: 3\n" - " operator { key: value }\n" - " >\n" - " >\n" - "};"); -} - -TEST_F(FormatTestProto, BreaksEntriesOfSubmessagesContainingSubmessages) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_TextProto); - Style.ColumnLimit = 60; - // The column limit allows for the keys submessage to be put on 1 line, but we - // break it since it contains a submessage an another entry. - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " sub <>\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " sub {}\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " sub {}\n" - " sub: <>\n" - " sub: []\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " item: 'aaaaaaaaaaa'\n" - " sub { msg: 1 }\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " item: 'aaaaaaaaaaa'\n" - " sub: { msg: 1 }\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " item: 'aaaaaaaaaaa'\n" - " sub < msg: 1 >\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " item: 'aaaaaaaaaaa'\n" - " sub: [ msg: 1 ]\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: <\n" - " item: 'aaaaaaaaaaa'\n" - " sub: [ 1, 2 ]\n" - " >\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " sub {}\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " sub: []\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " sub <>\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " sub { key: value }\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " sub: [ 1, 2 ]\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " sub < sub_2: {} >\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " item: data\n" - " sub: [ 1, 2 ]\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " item: data\n" - " sub < sub_2: {} >\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " sub: {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " sub: [ 1, 2 ]\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " }\n" - " }\n" - "}"); -} - -TEST_F(FormatTestProto, PreventBreaksBetweenKeyAndSubmessages) { - verifyFormat("option (MyProto.options) = {\n" - " submessage: {\n" - " key: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " submessage {\n" - " key: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'\n" - " }\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " submessage: <\n" - " key: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'\n" - " >\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " submessage <\n" - " key: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'\n" - " >\n" - "}"); - verifyFormat("option (MyProto.options) = {\n" - " repeatedd: [\n" - " 'eyaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'\n" - " ]\n" - "}"); -} - - -} // end namespace tooling -} // end namespace clang diff --git a/unittests/Format/FormatTestRawStrings.cpp b/unittests/Format/FormatTestRawStrings.cpp deleted file mode 100644 index 2a8a43dc95d83..0000000000000 --- a/unittests/Format/FormatTestRawStrings.cpp +++ /dev/null @@ -1,987 +0,0 @@ -//===- unittest/Format/FormatTestRawStrings.cpp - Formatting unit tests ---===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "clang/Format/Format.h" - -#include "../Tooling/ReplacementTest.h" -#include "FormatTestUtils.h" - -#include "clang/Frontend/TextDiagnosticPrinter.h" -#include "llvm/Support/Debug.h" -#include "llvm/Support/MemoryBuffer.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -using clang::tooling::ReplacementTest; -using clang::tooling::toReplacements; - -namespace clang { -namespace format { -namespace { - -class FormatTestRawStrings : public ::testing::Test { -protected: - enum StatusCheck { SC_ExpectComplete, SC_ExpectIncomplete, SC_DoNotCheck }; - - std::string format(llvm::StringRef Code, - const FormatStyle &Style = getLLVMStyle(), - StatusCheck CheckComplete = SC_ExpectComplete) { - LLVM_DEBUG(llvm::errs() << "---\n"); - LLVM_DEBUG(llvm::errs() << Code << "\n\n"); - std::vector<tooling::Range> Ranges(1, tooling::Range(0, Code.size())); - FormattingAttemptStatus Status; - tooling::Replacements Replaces = - reformat(Style, Code, Ranges, "<stdin>", &Status); - if (CheckComplete != SC_DoNotCheck) { - bool ExpectedCompleteFormat = CheckComplete == SC_ExpectComplete; - EXPECT_EQ(ExpectedCompleteFormat, Status.FormatComplete) - << Code << "\n\n"; - } - ReplacementCount = Replaces.size(); - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); - return *Result; - } - - FormatStyle getStyleWithColumns(FormatStyle Style, unsigned ColumnLimit) { - Style.ColumnLimit = ColumnLimit; - return Style; - } - - FormatStyle getLLVMStyleWithColumns(unsigned ColumnLimit) { - return getStyleWithColumns(getLLVMStyle(), ColumnLimit); - } - - int ReplacementCount; - - FormatStyle getRawStringPbStyleWithColumns(unsigned ColumnLimit) { - FormatStyle Style = getLLVMStyle(); - Style.ColumnLimit = ColumnLimit; - Style.RawStringFormats = { - { - /*Language=*/FormatStyle::LK_TextProto, - /*Delimiters=*/{"pb"}, - /*EnclosingFunctions=*/{}, - /*CanonicalDelimiter=*/"", - /*BasedOnStyle=*/"google", - }, - }; - return Style; - } - - FormatStyle getRawStringLLVMCppStyleBasedOn(std::string BasedOnStyle) { - FormatStyle Style = getLLVMStyle(); - Style.RawStringFormats = { - { - /*Language=*/FormatStyle::LK_Cpp, - /*Delimiters=*/{"cpp"}, - /*EnclosingFunctions=*/{}, - /*CanonicalDelimiter=*/"", - BasedOnStyle, - }, - }; - return Style; - } - - FormatStyle getRawStringGoogleCppStyleBasedOn(std::string BasedOnStyle) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_Cpp); - Style.RawStringFormats = { - { - /*Language=*/FormatStyle::LK_Cpp, - /*Delimiters=*/{"cpp"}, - /*EnclosingFunctions=*/{}, - /*CanonicalDelimiter=*/"", - BasedOnStyle, - }, - }; - return Style; - } - - // Gcc 4.8 doesn't support raw string literals in macros, which breaks some - // build bots. We use this function instead. - void expect_eq(const std::string Expected, const std::string Actual) { - EXPECT_EQ(Expected, Actual); - } -}; - -TEST_F(FormatTestRawStrings, ReformatsAccordingToBaseStyle) { - // llvm style puts '*' on the right. - // google style puts '*' on the left. - - // Use the llvm style if the raw string style has no BasedOnStyle. - expect_eq(R"test(int *i = R"cpp(int *p = nullptr;)cpp")test", - format(R"test(int * i = R"cpp(int * p = nullptr;)cpp")test", - getRawStringLLVMCppStyleBasedOn(""))); - - // Use the google style if the raw string style has BasedOnStyle=google. - expect_eq(R"test(int *i = R"cpp(int* p = nullptr;)cpp")test", - format(R"test(int * i = R"cpp(int * p = nullptr;)cpp")test", - getRawStringLLVMCppStyleBasedOn("google"))); - - // Use the llvm style if the raw string style has no BasedOnStyle=llvm. - expect_eq(R"test(int* i = R"cpp(int *p = nullptr;)cpp")test", - format(R"test(int * i = R"cpp(int * p = nullptr;)cpp")test", - getRawStringGoogleCppStyleBasedOn("llvm"))); -} - -TEST_F(FormatTestRawStrings, UsesConfigurationOverBaseStyle) { - // llvm style puts '*' on the right. - // google style puts '*' on the left. - - // Uses the configured google style inside raw strings even if BasedOnStyle in - // the raw string format is llvm. - FormatStyle Style = getGoogleStyle(FormatStyle::LK_Cpp); - EXPECT_EQ(0, parseConfiguration("---\n" - "Language: Cpp\n" - "BasedOnStyle: Google", &Style).value()); - Style.RawStringFormats = {{ - FormatStyle::LK_Cpp, - {"cpp"}, - {}, - /*CanonicalDelimiter=*/"", - /*BasedOnStyle=*/"llvm", - }}; - expect_eq(R"test(int* i = R"cpp(int* j = 0;)cpp";)test", - format(R"test(int * i = R"cpp(int * j = 0;)cpp";)test", Style)); -} - -TEST_F(FormatTestRawStrings, MatchesDelimitersCaseSensitively) { - // Don't touch the 'PB' raw string, format the 'pb' raw string. - expect_eq(R"test( -s = R"PB(item:1)PB"; -t = R"pb(item: 1)pb";)test", - format(R"test( -s = R"PB(item:1)PB"; -t = R"pb(item:1)pb";)test", - getRawStringPbStyleWithColumns(40))); -} - -TEST_F(FormatTestRawStrings, RespectsClangFormatOff) { - expect_eq(R"test( -// clang-format off -s = R"pb(item: 1)pb"; -// clang-format on -t = R"pb(item: 1)pb";)test", - format(R"test( -// clang-format off -s = R"pb(item: 1)pb"; -// clang-format on -t = R"pb(item: 1)pb";)test", - getRawStringPbStyleWithColumns(40))); -} - -TEST_F(FormatTestRawStrings, ReformatsShortRawStringsOnSingleLine) { - expect_eq( - R"test(P p = TP(R"pb()pb");)test", - format( - R"test(P p = TP(R"pb( )pb");)test", - getRawStringPbStyleWithColumns(40))); - expect_eq( - R"test(P p = TP(R"pb(item_1: 1)pb");)test", - format( - R"test(P p = TP(R"pb(item_1:1)pb");)test", - getRawStringPbStyleWithColumns(40))); - expect_eq( - R"test(P p = TP(R"pb(item_1: 1)pb");)test", - format( - R"test(P p = TP(R"pb( item_1 : 1 )pb");)test", - getRawStringPbStyleWithColumns(40))); - expect_eq( - R"test(P p = TP(R"pb(item_1: 1 item_2: 2)pb");)test", - format( - R"test(P p = TP(R"pb(item_1:1 item_2:2)pb");)test", - getRawStringPbStyleWithColumns(40))); - // Merge two short lines into one. - expect_eq(R"test( -std::string s = R"pb( - item_1: 1 item_2: 2 -)pb"; -)test", - format(R"test( -std::string s = R"pb( - item_1:1 - item_2:2 -)pb"; -)test", - getRawStringPbStyleWithColumns(40))); -} - -TEST_F(FormatTestRawStrings, BreaksShortRawStringsWhenNeeded) { - // The raw string contains multiple submessage entries, so break for - // readability. - expect_eq(R"test( -P p = TP(R"pb(item_1 < 1 > - item_2: { 2 })pb");)test", - format( - R"test( -P p = TP(R"pb(item_1<1> item_2:{2})pb");)test", - getRawStringPbStyleWithColumns(40))); -} - -TEST_F(FormatTestRawStrings, BreaksRawStringsExceedingColumnLimit) { - expect_eq(R"test( -P p = TPPPPPPPPPPPPPPP( - R"pb(item_1: 1, item_2: 2)pb");)test", - format(R"test( -P p = TPPPPPPPPPPPPPPP(R"pb(item_1: 1, item_2: 2)pb");)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -P p = - TPPPPPPPPPPPPPPP( - R"pb(item_1: 1, - item_2: 2, - item_3: 3)pb");)test", - format(R"test( -P p = TPPPPPPPPPPPPPPP(R"pb(item_1: 1, item_2: 2, item_3: 3)pb");)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -P p = TP(R"pb(item_1 < 1 > - item_2: < 2 > - item_3 {})pb");)test", - format(R"test( -P p = TP(R"pb(item_1<1> item_2:<2> item_3{ })pb");)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq( - R"test( -P p = TP(R"pb(item_1: 1, - item_2: 2, - item_3: 3, - item_4: 4)pb");)test", - format( - R"test( -P p = TP(R"pb(item_1: 1, item_2: 2, item_3: 3, item_4: 4)pb");)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -P p = TPPPPPPPPPPPPPPP( - R"pb(item_1 < 1 >, - item_2: { 2 }, - item_3: < 3 >, - item_4: { 4 })pb");)test", - format(R"test( -P p = TPPPPPPPPPPPPPPP(R"pb(item_1<1>, item_2: {2}, item_3: <3>, item_4:{4})pb");)test", - getRawStringPbStyleWithColumns(40))); - - // Breaks before a short raw string exceeding the column limit. - expect_eq(R"test( -FFFFFFFFFFFFFFFFFFFFFFFFFFF( - R"pb(key: 1)pb"); -P p = TPPPPPPPPPPPPPPPPPPPP( - R"pb(key: 2)pb"); -auto TPPPPPPPPPPPPPPPPPPPP = - R"pb(key: 3)pb"; -P p = TPPPPPPPPPPPPPPPPPPPP( - R"pb(i: 1, j: 2)pb"); - -int f(string s) { - FFFFFFFFFFFFFFFFFFFFFFFFFFFFFF( - R"pb(key: 1)pb"); - P p = TPPPPPPPPPPPPPPPPPPPP( - R"pb(key: 2)pb"); - auto TPPPPPPPPPPPPPPPPPPPP = - R"pb(key: 3)pb"; - if (s.empty()) - P p = TPPPPPPPPPPPPPPPPPPPP( - R"pb(i: 1, j: 2)pb"); -} -)test", - format(R"test( -FFFFFFFFFFFFFFFFFFFFFFFFFFF(R"pb(key:1)pb"); -P p = TPPPPPPPPPPPPPPPPPPPP(R"pb(key:2)pb"); -auto TPPPPPPPPPPPPPPPPPPPP = R"pb(key:3)pb"; -P p = TPPPPPPPPPPPPPPPPPPPP(R"pb(i: 1, j:2)pb"); - -int f(string s) { - FFFFFFFFFFFFFFFFFFFFFFFFFFFFFF(R"pb(key:1)pb"); - P p = TPPPPPPPPPPPPPPPPPPPP(R"pb(key:2)pb"); - auto TPPPPPPPPPPPPPPPPPPPP = R"pb(key:3)pb"; - if (s.empty()) - P p = TPPPPPPPPPPPPPPPPPPPP(R"pb(i: 1, j:2)pb"); -} -)test", - getRawStringPbStyleWithColumns(40))); -} - -TEST_F(FormatTestRawStrings, FormatsRawStringArguments) { - expect_eq(R"test( -P p = TP(R"pb(key { 1 })pb", param_2);)test", - format(R"test( -P p = TP(R"pb(key{1})pb",param_2);)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -PPPPPPPPPPPPP(R"pb(keykeyk)pb", - param_2);)test", - format(R"test( -PPPPPPPPPPPPP(R"pb(keykeyk)pb", param_2);)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -P p = TP( - R"pb(item: { i: 1, s: 's' } - item: { i: 2, s: 't' })pb");)test", - format(R"test( -P p = TP(R"pb(item: {i: 1, s: 's'} item: {i: 2, s: 't'})pb");)test", - getRawStringPbStyleWithColumns(40))); - expect_eq(R"test( -FFFFFFFFFFFFFFFFFFF( - R"pb(key: "value")pb", - R"pb(key2: "value")pb");)test", - format(R"test( -FFFFFFFFFFFFFFFFFFF(R"pb(key: "value")pb", R"pb(key2: "value")pb");)test", - getRawStringPbStyleWithColumns(40))); - - // Formats the first out of two arguments. - expect_eq(R"test( -FFFFFFFF(R"pb(key: 1)pb", argument2); -struct S { - const s = - f(R"pb(key: 1)pb", argument2); - void f() { - if (gol) - return g(R"pb(key: 1)pb", - 132789237); - return g(R"pb(key: 1)pb", "172893"); - } -};)test", - format(R"test( -FFFFFFFF(R"pb(key:1)pb", argument2); -struct S { -const s = f(R"pb(key:1)pb", argument2); -void f() { - if (gol) - return g(R"pb(key:1)pb", 132789237); - return g(R"pb(key:1)pb", "172893"); -} -};)test", - getRawStringPbStyleWithColumns(40))); - - // Formats the second out of two arguments. - expect_eq(R"test( -FFFFFFFF(argument1, R"pb(key: 2)pb"); -struct S { - const s = - f(argument1, R"pb(key: 2)pb"); - void f() { - if (gol) - return g(12784137, - R"pb(key: 2)pb"); - return g(17283122, R"pb(key: 2)pb"); - } -};)test", - format(R"test( -FFFFFFFF(argument1, R"pb(key:2)pb"); -struct S { -const s = f(argument1, R"pb(key:2)pb"); -void f() { - if (gol) - return g(12784137, R"pb(key:2)pb"); - return g(17283122, R"pb(key:2)pb"); -} -};)test", - getRawStringPbStyleWithColumns(40))); - - // Formats two short raw string arguments. - expect_eq(R"test( -FFFFF(R"pb(key: 1)pb", R"pb(key: 2)pb");)test", - format(R"test( -FFFFF(R"pb(key:1)pb", R"pb(key:2)pb");)test", - getRawStringPbStyleWithColumns(40))); - // TODO(krasimir): The original source code fits on one line, so the - // non-optimizing formatter is chosen. But after the formatting in protos is - // made, the code doesn't fit on one line anymore and further formatting - // splits it. - // - // Should we disable raw string formatting for the non-optimizing formatter? - expect_eq(R"test( -FFFFFFF(R"pb(key: 1)pb", R"pb(key: 2)pb");)test", - format(R"test( -FFFFFFF(R"pb(key:1)pb", R"pb(key:2)pb");)test", - getRawStringPbStyleWithColumns(40))); - - // Formats two short raw string arguments, puts second on newline. - expect_eq(R"test( -FFFFFFFF(R"pb(key: 1)pb", - R"pb(key: 2)pb");)test", - format(R"test( -FFFFFFFF(R"pb(key:1)pb", R"pb(key:2)pb");)test", - getRawStringPbStyleWithColumns(40))); - - // Formats both arguments. - expect_eq(R"test( -FFFFFFFF(R"pb(key: 1)pb", - R"pb(key: 2)pb"); -struct S { - const s = f(R"pb(key: 1)pb", - R"pb(key: 2)pb"); - void f() { - if (gol) - return g(R"pb(key: 1)pb", - R"pb(key: 2)pb"); - return g(R"pb(k1)pb", R"pb(k2)pb"); - } -};)test", - format(R"test( -FFFFFFFF(R"pb(key:1)pb", R"pb(key:2)pb"); -struct S { -const s = f(R"pb(key:1)pb", R"pb(key:2)pb"); -void f() { - if (gol) - return g(R"pb(key:1)pb", R"pb(key:2)pb"); - return g(R"pb( k1 )pb", R"pb( k2 )pb"); -} -};)test", - getRawStringPbStyleWithColumns(40))); -} - -TEST_F(FormatTestRawStrings, RawStringStartingWithNewlines) { - expect_eq(R"test( -std::string s = R"pb( - item_1: 1 -)pb"; -)test", - format(R"test( -std::string s = R"pb( - item_1:1 -)pb"; -)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -std::string s = R"pb( - - item_1: 1 -)pb"; -)test", - format(R"test( -std::string s = R"pb( - - item_1:1 -)pb"; -)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -std::string s = R"pb( - item_1: 1 -)pb"; -)test", - format(R"test( -std::string s = R"pb( - item_1:1 - -)pb"; -)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -std::string s = R"pb( - item_1: 1, - item_2: 2 -)pb"; -)test", - format(R"test( -std::string s = R"pb( - item_1:1, item_2:2 -)pb"; -)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -std::string s = R"pb( - book { - title: "Alice's Adventures" - author: "Lewis Caroll" - } - book { - title: "Peter Pan" - author: "J. M. Barrie" - } -)pb"; -)test", - format(R"test( -std::string s = R"pb( - book { title: "Alice's Adventures" author: "Lewis Caroll" } - book { title: "Peter Pan" author: "J. M. Barrie" } -)pb"; -)test", - getRawStringPbStyleWithColumns(40))); -} - -TEST_F(FormatTestRawStrings, BreaksBeforeRawStrings) { - expect_eq(R"test( -ASSERT_TRUE( - ParseFromString(R"pb(item_1: 1)pb"), - ptr);)test", - format(R"test( -ASSERT_TRUE(ParseFromString(R"pb(item_1: 1)pb"), ptr);)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -ASSERT_TRUE(toolong::ParseFromString( - R"pb(item_1: 1)pb"), - ptr);)test", - format(R"test( -ASSERT_TRUE(toolong::ParseFromString(R"pb(item_1: 1)pb"), ptr);)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -ASSERT_TRUE(ParseFromString( - R"pb(item_1: 1, - item_2: 2)pb"), - ptr);)test", - format(R"test( -ASSERT_TRUE(ParseFromString(R"pb(item_1: 1, item_2: 2)pb"), ptr);)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -ASSERT_TRUE( - ParseFromString( - R"pb(item_1: 1 item_2: 2)pb"), - ptr);)test", - format(R"test( -ASSERT_TRUE(ParseFromString(R"pb(item_1: 1 item_2: 2)pb"), ptr);)test", - getRawStringPbStyleWithColumns(40))); - -} - -TEST_F(FormatTestRawStrings, RawStringsInOperands) { - // Formats the raw string first operand of a binary operator expression. - expect_eq(R"test(auto S = R"pb(item_1: 1)pb" + rest;)test", - format(R"test(auto S = R"pb(item_1:1)pb" + rest;)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -auto S = R"pb(item_1: 1, item_2: 2)pb" + - rest;)test", - format(R"test( -auto S = R"pb(item_1:1,item_2:2)pb"+rest;)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -auto S = - R"pb(item_1: 1 item_2: 2)pb" + rest;)test", - format(R"test( -auto S = R"pb(item_1:1 item_2:2)pb"+rest;)test", - getRawStringPbStyleWithColumns(40))); - - // `rest` fits on the line after )pb", but forced on newline since the raw - // string literal is multiline. - expect_eq(R"test( -auto S = R"pb(item_1: 1, - item_2: 2, - item_3: 3)pb" + - rest;)test", - format(R"test( -auto S = R"pb(item_1:1,item_2:2,item_3:3)pb"+rest;)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -auto S = R"pb(item_1: 1, - item_2: 2, - item_3: 3)pb" + - longlongrest;)test", - format(R"test( -auto S = R"pb(item_1:1,item_2:2,item_3:3)pb"+longlongrest;)test", - getRawStringPbStyleWithColumns(40))); - - // Formats the raw string second operand of a binary operator expression. - expect_eq(R"test(auto S = first + R"pb(item_1: 1)pb";)test", - format(R"test(auto S = first + R"pb(item_1:1)pb";)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -auto S = first + R"pb(item_1: 1, - item_2: 2)pb";)test", - format(R"test( -auto S = first+R"pb(item_1:1,item_2:2)pb";)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -auto S = first + R"pb(item_1: 1 - item_2: 2)pb";)test", - format(R"test( -auto S = first+R"pb(item_1:1 item_2:2)pb";)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -auto S = R"pb(item_1: 1, - item_2: 2, - item_3: 3)pb" + - rest;)test", - format(R"test( -auto S = R"pb(item_1:1,item_2:2,item_3:3)pb"+rest;)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -auto S = R"pb(item_1: 1, - item_2: 2, - item_3: 3)pb" + - longlongrest;)test", - format(R"test( -auto S = R"pb(item_1:1,item_2:2,item_3:3)pb"+longlongrest;)test", - getRawStringPbStyleWithColumns(40))); - - // Formats the raw string operands in expressions. - expect_eq(R"test( -auto S = R"pb(item_1: 1)pb" + - R"pb(item_2: 2)pb"; -)test", - format(R"test( -auto S=R"pb(item_1:1)pb"+R"pb(item_2:2)pb"; -)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -auto S = R"pb(item_1: 1)pb" + - R"pb(item_2: 2)pb" + - R"pb(item_3: 3)pb"; -)test", - format(R"test( -auto S=R"pb(item_1:1)pb"+R"pb(item_2:2)pb"+R"pb(item_3:3)pb"; -)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -auto S = (count < 3) - ? R"pb(item_1: 1)pb" - : R"pb(item_2: 2)pb"; -)test", - format(R"test( -auto S=(count<3)?R"pb(item_1:1)pb":R"pb(item_2:2)pb"; -)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -auto S = - (count < 3) - ? R"pb(item_1: 1, item_2: 2)pb" - : R"pb(item_3: 3)pb"; -)test", - format(R"test( -auto S=(count<3)?R"pb(item_1:1,item_2:2)pb":R"pb(item_3:3)pb"; -)test", - getRawStringPbStyleWithColumns(40))); - - expect_eq(R"test( -auto S = - (count < 3) - ? R"pb(item_1: 1)pb" - : R"pb(item_2: 2, item_3: 3)pb"; -)test", - format(R"test( -auto S=(count<3)?R"pb(item_1:1)pb":R"pb(item_2:2,item_3:3)pb"; -)test", - getRawStringPbStyleWithColumns(40))); - -} - -TEST_F(FormatTestRawStrings, PrefixAndSuffixAlignment) { - // Keep the suffix at the end of line if not on newline. - expect_eq(R"test( -int s() { - auto S = PTP( - R"pb( - item_1: 1, - item_2: 2)pb"); -})test", - format(R"test( -int s() { - auto S = PTP( - R"pb( - item_1: 1, - item_2: 2)pb"); -})test", - getRawStringPbStyleWithColumns(20))); - - // Align the suffix with the surrounding indent if the prefix is not on - // a line of its own. - expect_eq(R"test( -int s() { - auto S = PTP(R"pb( - item_1: 1, - item_2: 2 - )pb"); -})test", - format(R"test( -int s() { - auto S = PTP(R"pb( - item_1: 1, - item_2: 2 - )pb"); -})test", - getRawStringPbStyleWithColumns(20))); - - // Align the prefix with the suffix if both the prefix and suffix are on a - // line of their own. - expect_eq(R"test( -int s() { - auto S = PTP( - R"pb( - item_1: 1, - item_2: 2, - )pb"); -})test", - format(R"test( -int s() { - auto S = PTP( - R"pb( - item_1: 1, - item_2: 2, - )pb"); -})test", - getRawStringPbStyleWithColumns(20))); -} - -TEST_F(FormatTestRawStrings, EstimatesPenalty) { - // The penalty for characters exceeding the column limit in the raw string - // forces 'hh' to be put on a newline. - expect_eq(R"test( -ff(gggggg, - hh(R"pb(key { - i1: k1 - i2: k2 - })pb")); -)test", - format(R"test( -ff(gggggg, hh(R"pb(key { - i1: k1 - i2: k2 - })pb")); -)test", - getRawStringPbStyleWithColumns(20))); -} - -TEST_F(FormatTestRawStrings, DontFormatNonRawStrings) { - expect_eq(R"test(a = R"pb(key:value)";)test", - format(R"test(a = R"pb(key:value)";)test", - getRawStringPbStyleWithColumns(20))); -} - -TEST_F(FormatTestRawStrings, FormatsRawStringsWithEnclosingFunctionName) { - FormatStyle Style = getRawStringPbStyleWithColumns(40); - Style.RawStringFormats[0].EnclosingFunctions.push_back( - "PARSE_TEXT_PROTO"); - Style.RawStringFormats[0].EnclosingFunctions.push_back("ParseTextProto"); - expect_eq(R"test(a = PARSE_TEXT_PROTO(R"(key: value)");)test", - format(R"test(a = PARSE_TEXT_PROTO(R"(key:value)");)test", Style)); - - expect_eq(R"test( -a = PARSE_TEXT_PROTO /**/ ( - /**/ R"(key: value)");)test", - format(R"test( -a = PARSE_TEXT_PROTO/**/(/**/R"(key:value)");)test", - Style)); - - expect_eq(R"test( -a = ParseTextProto<ProtoType>( - R"(key: value)");)test", - format(R"test( -a = ParseTextProto<ProtoType>(R"(key:value)");)test", - Style)); -} - -TEST_F(FormatTestRawStrings, UpdatesToCanonicalDelimiters) { - FormatStyle Style = getRawStringPbStyleWithColumns(25); - Style.RawStringFormats[0].CanonicalDelimiter = "proto"; - expect_eq(R"test(a = R"proto(key: value)proto";)test", - format(R"test(a = R"pb(key:value)pb";)test", Style)); - - // Don't update to canonical delimiter if it occurs as a raw string suffix in - // the raw string content. - expect_eq(R"test(a = R"pb(key: ")proto")pb";)test", - format(R"test(a = R"pb(key:")proto")pb";)test", Style)); -} - -TEST_F(FormatTestRawStrings, PenalizesPrefixExcessChars) { - FormatStyle Style = getRawStringPbStyleWithColumns(60); - - // The '(' in R"pb is at column 60, no break. - expect_eq(R"test( -xxxxxxxaaaaax wwwwwww = _Verxrrrrrrrr(PARSE_TEXT_PROTO(R"pb( - Category: aaaaaaaaaaaaaaaaaaaaaaaaaa -)pb")); -)test", - format(R"test( -xxxxxxxaaaaax wwwwwww = _Verxrrrrrrrr(PARSE_TEXT_PROTO(R"pb( - Category: aaaaaaaaaaaaaaaaaaaaaaaaaa -)pb")); -)test", Style)); - // The '(' in R"pb is at column 61, break. - expect_eq(R"test( -xxxxxxxaaaaax wwwwwww = - _Verxrrrrrrrrr(PARSE_TEXT_PROTO(R"pb( - Category: aaaaaaaaaaaaaaaaaaaaaaaaaa - )pb")); -)test", - format(R"test( -xxxxxxxaaaaax wwwwwww = _Verxrrrrrrrrr(PARSE_TEXT_PROTO(R"pb( - Category: aaaaaaaaaaaaaaaaaaaaaaaaaa -)pb")); -)test", Style)); -} - -TEST_F(FormatTestRawStrings, KeepsRBraceFolloedByMoreLBracesOnSameLine) { - FormatStyle Style = getRawStringPbStyleWithColumns(80); - - expect_eq( - R"test( -int f() { - if (1) { - TTTTTTTTTTTTTTTTTTTTT s = PARSE_TEXT_PROTO(R"pb( - ttttttttt { - ppppppppppppp { - [cccccccccc.pppppppppppppp.TTTTTTTTTTTTTTTTTTTT] { field_1: "123_1" } - [cccccccccc.pppppppppppppp.TTTTTTTTTTTTTTTTTTTT] { field_2: "123_2" } - } - } - )pb"); - } -} -)test", - format( - R"test( -int f() { - if (1) { - TTTTTTTTTTTTTTTTTTTTT s = PARSE_TEXT_PROTO(R"pb( - ttttttttt { - ppppppppppppp { - [cccccccccc.pppppppppppppp.TTTTTTTTTTTTTTTTTTTT] { field_1: "123_1" } - [cccccccccc.pppppppppppppp.TTTTTTTTTTTTTTTTTTTT] { field_2: "123_2" }}} - )pb"); - } -} -)test", - Style)); -} - -TEST_F(FormatTestRawStrings, - DoNotFormatUnrecognizedDelimitersInRecognizedFunctions) { - FormatStyle Style = getRawStringPbStyleWithColumns(60); - Style.RawStringFormats[0].EnclosingFunctions.push_back( - "EqualsProto"); - // EqualsProto is a recognized function, but the Raw delimiter is - // unrecognized. Do not touch the string in this case, since it might be - // special. - expect_eq(R"test( -void f() { - aaaaaaaaa(bbbbbbbbb, EqualsProto(R"Raw( -item { - key: value -} -)Raw")); -})test", - format(R"test( -void f() { - aaaaaaaaa(bbbbbbbbb, EqualsProto(R"Raw( -item { - key: value -} -)Raw")); -})test", - Style)); -} - -TEST_F(FormatTestRawStrings, - BreaksBeforeNextParamAfterMultilineRawStringParam) { - FormatStyle Style = getRawStringPbStyleWithColumns(60); - expect_eq(R"test( -int f() { - int a = g(x, R"pb( - key: 1 # - key: 2 - )pb", - 3, 4); -} -)test", - format(R"test( -int f() { - int a = g(x, R"pb( - key: 1 # - key: 2 - )pb", 3, 4); -} -)test", - Style)); - - // Breaks after a parent of a multiline param. - expect_eq(R"test( -int f() { - int a = g(x, h(R"pb( - key: 1 # - key: 2 - )pb"), - 3, 4); -} -)test", - format(R"test( -int f() { - int a = g(x, h(R"pb( - key: 1 # - key: 2 - )pb"), 3, 4); -} -)test", - Style)); - - expect_eq(R"test( -int f() { - int a = g(x, - h(R"pb( - key: 1 # - key: 2 - )pb", - 2), - 3, 4); -} -)test", - format(R"test( -int f() { - int a = g(x, h(R"pb( - key: 1 # - key: 2 - )pb", 2), 3, 4); -} -)test", - Style)); - // Breaks if formatting introduces a multiline raw string. - expect_eq(R"test( -int f() { - int a = g(x, R"pb(key1: value111111111 - key2: value2222222222)pb", - 3, 4); -} -)test", - format(R"test( -int f() { - int a = g(x, R"pb(key1: value111111111 key2: value2222222222)pb", 3, 4); -} -)test", - Style)); - // Does not force a break after an original multiline param that is - // reformatterd as on single line. - expect_eq(R"test( -int f() { - int a = g(R"pb(key: 1)pb", 2); -})test", - format(R"test( -int f() { - int a = g(R"pb(key: - 1)pb", 2); -})test", Style)); -} - -} // end namespace -} // end namespace format -} // end namespace clang diff --git a/unittests/Format/FormatTestSelective.cpp b/unittests/Format/FormatTestSelective.cpp deleted file mode 100644 index 36d9089c60569..0000000000000 --- a/unittests/Format/FormatTestSelective.cpp +++ /dev/null @@ -1,609 +0,0 @@ -//===- unittest/Format/FormatTestSelective.cpp - Formatting unit tests ----===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "FormatTestUtils.h" -#include "clang/Format/Format.h" -#include "llvm/Support/Debug.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -namespace clang { -namespace format { -namespace { - -class FormatTestSelective : public ::testing::Test { -protected: - std::string format(llvm::StringRef Code, unsigned Offset, unsigned Length) { - LLVM_DEBUG(llvm::errs() << "---\n"); - LLVM_DEBUG(llvm::errs() << Code << "\n\n"); - std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length)); - FormattingAttemptStatus Status; - tooling::Replacements Replaces = - reformat(Style, Code, Ranges, "<stdin>", &Status); - EXPECT_TRUE(Status.FormatComplete) << Code << "\n\n"; - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); - return *Result; - } - - FormatStyle Style = getLLVMStyle(); -}; - -TEST_F(FormatTestSelective, RemovesTrailingWhitespaceOfFormattedLine) { - EXPECT_EQ("int a;\nint b;", format("int a; \nint b;", 0, 0)); - EXPECT_EQ("int a;", format("int a; ", 0, 0)); - EXPECT_EQ("int a;\n", format("int a; \n \n \n ", 0, 0)); - EXPECT_EQ("int a;\nint b; ", format("int a; \nint b; ", 0, 0)); -} - -TEST_F(FormatTestSelective, FormatsCorrectRegionForLeadingWhitespace) { - EXPECT_EQ("{int b;\n" - " int a;\n" - "}", - format("{int b;\n int a;}", 8, 0)); - EXPECT_EQ("{\n" - " int b;\n" - " int a;}", - format("{int b;\n int a;}", 7, 0)); - - Style.ColumnLimit = 12; - EXPECT_EQ("#define A \\\n" - " int a; \\\n" - " int b;", - format("#define A \\\n" - " int a; \\\n" - " int b;", - 26, 0)); - EXPECT_EQ("#define A \\\n" - " int a; \\\n" - " int b;", - format("#define A \\\n" - " int a; \\\n" - " int b;", - 25, 0)); -} - -TEST_F(FormatTestSelective, FormatLineWhenInvokedOnTrailingNewline) { - EXPECT_EQ("int b;\n\nint a;", format("int b;\n\nint a;", 8, 0)); - EXPECT_EQ("int b;\n\nint a;", format("int b;\n\nint a;", 7, 0)); - - // This might not strictly be correct, but is likely good in all practical - // cases. - EXPECT_EQ("int b;\nint a;", format("int b;int a;", 7, 0)); -} - -TEST_F(FormatTestSelective, RemovesWhitespaceWhenTriggeredOnEmptyLine) { - EXPECT_EQ("int a;\n\n int b;", format("int a;\n \n\n int b;", 8, 0)); - EXPECT_EQ("int a;\n\n int b;", format("int a;\n \n\n int b;", 9, 0)); -} - -TEST_F(FormatTestSelective, ReformatsMovedLines) { - EXPECT_EQ( - "template <typename T> T *getFETokenInfo() const {\n" - " return static_cast<T *>(FETokenInfo);\n" - "}\n" - "int a; // <- Should not be formatted", - format( - "template<typename T>\n" - "T *getFETokenInfo() const { return static_cast<T*>(FETokenInfo); }\n" - "int a; // <- Should not be formatted", - 9, 5)); -} - -TEST_F(FormatTestSelective, FormatsIfWithoutCompoundStatement) { - Style.AllowShortIfStatementsOnASingleLine = true; - EXPECT_EQ("if (a) return;", format("if(a)\nreturn;", 7, 1)); - EXPECT_EQ("if (a) return; // comment", - format("if(a)\nreturn; // comment", 20, 1)); -} - -TEST_F(FormatTestSelective, FormatsCommentsLocally) { - EXPECT_EQ("int a; // comment\n" - "int b; // comment", - format("int a; // comment\n" - "int b; // comment", - 0, 0)); - EXPECT_EQ("int a; // comment\n" - " // line 2\n" - "int b;", - format("int a; // comment\n" - " // line 2\n" - "int b;", - 28, 0)); - EXPECT_EQ("int a; // comment\n" - "// comment 2\n" - "int b;", - format("int a; // comment\n" - "// comment 2\n" - "int b;", 28, 0)); - EXPECT_EQ("int aaaaaa; // comment\n" - "int b;\n" - "int c; // unrelated comment", - format("int aaaaaa; // comment\n" - "int b;\n" - "int c; // unrelated comment", - 31, 0)); - - EXPECT_EQ("int a; // This\n" - " // is\n" - " // a", - format("int a; // This\n" - " // is\n" - " // a", - 0, 0)); - EXPECT_EQ("int a; // This\n" - " // is\n" - " // a\n" - "// This is b\n" - "int b;", - format("int a; // This\n" - " // is\n" - " // a\n" - "// This is b\n" - "int b;", - 0, 0)); - EXPECT_EQ("int a; // This\n" - " // is\n" - " // a\n" - "\n" - "//This is unrelated", - format("int a; // This\n" - " // is\n" - " // a\n" - "\n" - "//This is unrelated", - 0, 0)); - EXPECT_EQ("int a;\n" - "// This is\n" - "// not formatted. ", - format("int a;\n" - "// This is\n" - "// not formatted. ", - 0, 0)); - EXPECT_EQ("int x; // Format this line.\n" - "int xx; //\n" - "int xxxxx; //", - format("int x; // Format this line.\n" - "int xx; //\n" - "int xxxxx; //", - 0, 0)); -} - -TEST_F(FormatTestSelective, ContinueReindenting) { - // When we change an indent, we continue formatting as long as following - // lines are not indented correctly. - EXPECT_EQ("int i;\n" - "int b;\n" - "int c;\n" - "int d;\n" - "int e;\n" - " int f;\n", - format("int i;\n" - " int b;\n" - " int c;\n" - " int d;\n" - "int e;\n" - " int f;\n", - 11, 0)); -} - -TEST_F(FormatTestSelective, ReindentClosingBrace) { - EXPECT_EQ("int i;\n" - "int f() {\n" - " int a;\n" - " int b;\n" - "}\n" - " int c;\n", - format("int i;\n" - " int f(){\n" - "int a;\n" - "int b;\n" - " }\n" - " int c;\n", - 11, 0)); - EXPECT_EQ("void f() {\n" - " if (foo) {\n" - " b();\n" - " } else {\n" - " c();\n" - " }\n" - "int d;\n" - "}\n", - format("void f() {\n" - " if (foo) {\n" - "b();\n" - "}else{\n" - "c();\n" - "}\n" - "int d;\n" - "}\n", - 13, 0)); - EXPECT_EQ("int i = []() {\n" - " class C {\n" - " int a;\n" - " int b;\n" - " };\n" - " int c;\n" - "};\n", - format("int i = []() {\n" - " class C{\n" - "int a;\n" - "int b;\n" - "};\n" - "int c;\n" - " };\n", - 17, 0)); -} - -TEST_F(FormatTestSelective, IndividualStatementsOfNestedBlocks) { - EXPECT_EQ("DEBUG({\n" - " int i;\n" - " int j;\n" - "});", - format("DEBUG( {\n" - " int i;\n" - " int j;\n" - "} ) ;", - 20, 1)); - EXPECT_EQ("DEBUG( {\n" - " int i;\n" - " int j;\n" - "} ) ;", - format("DEBUG( {\n" - " int i;\n" - " int j;\n" - "} ) ;", - 41, 1)); - EXPECT_EQ("DEBUG( {\n" - " int i;\n" - " int j;\n" - "} ) ;", - format("DEBUG( {\n" - " int i;\n" - " int j;\n" - "} ) ;", - 41, 1)); - EXPECT_EQ("DEBUG({\n" - " int i;\n" - " int j;\n" - "});", - format("DEBUG( {\n" - " int i;\n" - " int j;\n" - "} ) ;", - 20, 1)); - - EXPECT_EQ("Debug({\n" - " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" - " return;\n" - " },\n" - " a);", - format("Debug({\n" - " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" - " return;\n" - " },\n" - " a);", - 50, 1)); - EXPECT_EQ("DEBUG({\n" - " DEBUG({\n" - " int a;\n" - " int b;\n" - " }) ;\n" - "});", - format("DEBUG({\n" - " DEBUG({\n" - " int a;\n" - " int b;\n" // Format this line only. - " }) ;\n" // Don't touch this line. - "});", - 35, 0)); - EXPECT_EQ("DEBUG({\n" - " int a; //\n" - "});", - format("DEBUG({\n" - " int a; //\n" - "});", - 0, 0)); - EXPECT_EQ("someFunction(\n" - " [] {\n" - " // Only with this comment.\n" - " int i; // invoke formatting here.\n" - " }, // force line break\n" - " aaa);", - format("someFunction(\n" - " [] {\n" - " // Only with this comment.\n" - " int i; // invoke formatting here.\n" - " }, // force line break\n" - " aaa);", - 63, 1)); - - EXPECT_EQ("int longlongname; // comment\n" - "int x = f({\n" - " int x; // comment\n" - " int y; // comment\n" - "});", - format("int longlongname; // comment\n" - "int x = f({\n" - " int x; // comment\n" - " int y; // comment\n" - "});", - 65, 0)); - EXPECT_EQ("int s = f({\n" - " class X {\n" - " public:\n" - " void f();\n" - " };\n" - "});", - format("int s = f({\n" - " class X {\n" - " public:\n" - " void f();\n" - " };\n" - "});", - 0, 0)); - EXPECT_EQ("SomeFunction(\n" - " [] {\n" - " int i;\n" - " return i;\n" // Format this line. - " },\n" - " [] {\n" - " return 2;\n" // Don't fix this. - " });", - format("SomeFunction(\n" - " [] {\n" - " int i;\n" - " return i;\n" // Format this line. - " },\n" - " [] {\n" - " return 2;\n" // Don't fix this. - " });", - 40, 0)); -} - -TEST_F(FormatTestSelective, WrongIndent) { - EXPECT_EQ("namespace {\n" - "int i;\n" - "int j;\n" - "}", - format("namespace {\n" - " int i;\n" // Format here. - " int j;\n" - "}", - 15, 0)); - EXPECT_EQ("namespace {\n" - " int i;\n" - " int j;\n" - "}", - format("namespace {\n" - " int i;\n" - " int j;\n" // Format here. - "}", - 24, 0)); -} - -TEST_F(FormatTestSelective, AlwaysFormatsEntireMacroDefinitions) { - Style.AlignEscapedNewlines = FormatStyle::ENAS_Left; - EXPECT_EQ("int i;\n" - "#define A \\\n" - " int i; \\\n" - " int j\n" - "int k;", - format("int i;\n" - "#define A \\\n" - " int i ; \\\n" - " int j\n" - "int k;", - 8, 0)); // 8: position of "#define". - EXPECT_EQ("int i;\n" - "#define A \\\n" - " int i; \\\n" - " int j\n" - "int k;", - format("int i;\n" - "#define A \\\n" - " int i ; \\\n" - " int j\n" - "int k;", - 45, 0)); // 45: position of "j". -} - -TEST_F(FormatTestSelective, ReformatRegionAdjustsIndent) { - EXPECT_EQ("{\n" - "{\n" - "a;\n" - "b;\n" - "}\n" - "}", - format("{\n" - "{\n" - "a;\n" - " b;\n" - "}\n" - "}", - 13, 2)); - EXPECT_EQ("{\n" - "{\n" - " a;\n" - " b;\n" - " c;\n" - " d;\n" - "}\n" - "}", - format("{\n" - "{\n" - " a;\n" - " b;\n" - " c;\n" - " d;\n" - "}\n" - "}", - 9, 2)); - EXPECT_EQ("{\n" - "{\n" - "public:\n" - " b;\n" - "}\n" - "}", - format("{\n" - "{\n" - "public:\n" - " b;\n" - "}\n" - "}", - 17, 2)); - EXPECT_EQ("{\n" - "{\n" - "a;\n" - "}\n" - "{\n" - " b; //\n" - "}\n" - "}", - format("{\n" - "{\n" - "a;\n" - "}\n" - "{\n" - " b; //\n" - "}\n" - "}", - 22, 2)); - EXPECT_EQ(" {\n" - " a; //\n" - " }", - format(" {\n" - "a; //\n" - " }", - 4, 2)); - EXPECT_EQ("void f() {}\n" - "void g() {}", - format("void f() {}\n" - "void g() {}", - 13, 0)); - EXPECT_EQ("int a; // comment\n" - " // line 2\n" - "int b;", - format("int a; // comment\n" - " // line 2\n" - " int b;", - 35, 0)); - - EXPECT_EQ(" void f() {\n" - "#define A 1\n" - " }", - format(" void f() {\n" - " #define A 1\n" // Format this line. - " }", - 20, 0)); - EXPECT_EQ(" void f() {\n" - " int i;\n" - "#define A \\\n" - " int i; \\\n" - " int j;\n" - " int k;\n" - " }", - format(" void f() {\n" - " int i;\n" - "#define A \\\n" - " int i; \\\n" - " int j;\n" - " int k;\n" // Format this line. - " }", - 67, 0)); - - Style.ColumnLimit = 11; - EXPECT_EQ(" int a;\n" - " void\n" - " ffffff() {\n" - " }", - format(" int a;\n" - "void ffffff() {}", - 11, 0)); -} - -TEST_F(FormatTestSelective, UnderstandsTabs) { - Style.IndentWidth = 8; - Style.UseTab = FormatStyle::UT_Always; - Style.AlignEscapedNewlines = FormatStyle::ENAS_Left; - EXPECT_EQ("void f() {\n" - "\tf();\n" - "\tg();\n" - "}", - format("void f() {\n" - "\tf();\n" - "\tg();\n" - "}", - 0, 0)); - EXPECT_EQ("void f() {\n" - "\tf();\n" - "\tg();\n" - "}", - format("void f() {\n" - "\tf();\n" - "\tg();\n" - "}", - 16, 0)); - EXPECT_EQ("void f() {\n" - " \tf();\n" - "\tg();\n" - "}", - format("void f() {\n" - " \tf();\n" - " \tg();\n" - "}", - 21, 0)); -} - -TEST_F(FormatTestSelective, StopFormattingWhenLeavingScope) { - EXPECT_EQ( - "void f() {\n" - " if (a) {\n" - " g();\n" - " h();\n" - " }\n" - "\n" - "void g() {\n" - "}", - format("void f() {\n" - " if (a) {\n" // Assume this was added without the closing brace. - " g();\n" - " h();\n" - "}\n" - "\n" - "void g() {\n" // Make sure not to format this. - "}", - 15, 0)); -} - -TEST_F(FormatTestSelective, SelectivelyRequoteJavaScript) { - Style = getGoogleStyle(FormatStyle::LK_JavaScript); - EXPECT_EQ( - "var x = \"a\";\n" - "var x = 'a';\n" - "var x = \"a\";", - format("var x = \"a\";\n" - "var x = \"a\";\n" - "var x = \"a\";", - 20, 0)); -} - -TEST_F(FormatTestSelective, KeepsIndentAfterCommentSectionImport) { - std::string Code = "#include <a> // line 1\n" // 23 chars long - " // line 2\n" // 23 chars long - "\n" // this newline is char 47 - "int i;"; // this line is not indented - EXPECT_EQ(Code, format(Code, 47, 1)); -} - -} // end namespace -} // end namespace format -} // end namespace clang diff --git a/unittests/Format/FormatTestTableGen.cpp b/unittests/Format/FormatTestTableGen.cpp deleted file mode 100644 index 820ea783cc9c8..0000000000000 --- a/unittests/Format/FormatTestTableGen.cpp +++ /dev/null @@ -1,56 +0,0 @@ -//===- unittest/Format/FormatTestTableGen.cpp -----------------------------===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "FormatTestUtils.h" -#include "clang/Format/Format.h" -#include "llvm/Support/Debug.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -namespace clang { -namespace format { - -class FormatTestTableGen : public ::testing::Test { -protected: - static std::string format(llvm::StringRef Code, unsigned Offset, - unsigned Length, const FormatStyle &Style) { - LLVM_DEBUG(llvm::errs() << "---\n"); - LLVM_DEBUG(llvm::errs() << Code << "\n\n"); - std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length)); - tooling::Replacements Replaces = reformat(Style, Code, Ranges); - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); - return *Result; - } - - static std::string format(llvm::StringRef Code) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_TableGen); - Style.ColumnLimit = 60; // To make writing tests easier. - return format(Code, 0, Code.size(), Style); - } - - static void verifyFormat(llvm::StringRef Code) { - EXPECT_EQ(Code.str(), format(Code)) << "Expected code is not stable"; - EXPECT_EQ(Code.str(), format(test::messUp(Code))); - } -}; - -TEST_F(FormatTestTableGen, FormatStringBreak) { - verifyFormat("include \"OptParser.td\"\n" - "def flag : Flag<\"--foo\">,\n" - " HelpText<\n" - " \"This is a very, very, very, very, \"\n" - " \"very, very, very, very, very, very, \"\n" - " \"very long help string\">;\n"); -} - -} // namespace format -} // end namespace clang diff --git a/unittests/Format/FormatTestTextProto.cpp b/unittests/Format/FormatTestTextProto.cpp deleted file mode 100644 index 44431e4dc6ec3..0000000000000 --- a/unittests/Format/FormatTestTextProto.cpp +++ /dev/null @@ -1,739 +0,0 @@ -//===- unittest/Format/FormatTestTextProto.cpp ----------------------------===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "FormatTestUtils.h" -#include "clang/Format/Format.h" -#include "llvm/Support/Debug.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -namespace clang { -namespace format { - -class FormatTestTextProto : public ::testing::Test { -protected: - static std::string format(llvm::StringRef Code, unsigned Offset, - unsigned Length, const FormatStyle &Style) { - LLVM_DEBUG(llvm::errs() << "---\n"); - LLVM_DEBUG(llvm::errs() << Code << "\n\n"); - std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length)); - tooling::Replacements Replaces = reformat(Style, Code, Ranges); - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); - return *Result; - } - - static std::string format(llvm::StringRef Code, const FormatStyle &Style) { - return format(Code, 0, Code.size(), Style); - } - - static void verifyFormat(llvm::StringRef Code, const FormatStyle &Style) { - EXPECT_EQ(Code.str(), format(Code, Style)) << "Expected code is not stable"; - EXPECT_EQ(Code.str(), format(test::messUp(Code), Style)); - } - - static void verifyFormat(llvm::StringRef Code) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_TextProto); - Style.ColumnLimit = 60; // To make writing tests easier. - verifyFormat(Code, Style); - } -}; - -TEST_F(FormatTestTextProto, KeepsTopLevelEntriesFittingALine) { - verifyFormat("field_a: OK field_b: OK field_c: OK field_d: OK field_e: OK"); -} - -TEST_F(FormatTestTextProto, SupportsMessageFields) { - verifyFormat("msg_field: {}"); - - verifyFormat("msg_field: { field_a: A }"); - - verifyFormat("msg_field: { field_a: \"OK\" field_b: 123 }"); - - verifyFormat("msg_field: {\n" - " field_a: 1\n" - " field_b: OK\n" - " field_c: \"OK\"\n" - " field_d: 123\n" - " field_e: 23\n" - "}"); - - verifyFormat("msg_field {}"); - - verifyFormat("msg_field { field_a: A }"); - - verifyFormat("msg_field { field_a: \"OK\" field_b: 123 }"); - - verifyFormat("msg_field {\n" - " field_a: 1\n" - " field_b: OK\n" - " field_c: \"OK\"\n" - " field_d: 123\n" - " field_e: 23.0\n" - " field_f: false\n" - " field_g: 'lala'\n" - " field_h: 1234.567e-89\n" - "}"); - - verifyFormat("msg_field: { msg_field { field_a: 1 } }"); - - verifyFormat("id: \"ala.bala\"\n" - "item { type: ITEM_A rank: 1 score: 90.0 }\n" - "item { type: ITEM_B rank: 2 score: 70.5 }\n" - "item {\n" - " type: ITEM_A\n" - " rank: 3\n" - " score: 20.0\n" - " description: \"the third item has a description\"\n" - "}"); -} - -TEST_F(FormatTestTextProto, AvoidsTopLevelBinPacking) { - verifyFormat("field_a: OK\n" - "field_b: OK\n" - "field_c: OK\n" - "field_d: OK\n" - "field_e: OK\n" - "field_f: OK"); - - verifyFormat("field_a: OK\n" - "field_b: \"OK\"\n" - "field_c: \"OK\"\n" - "msg_field: { field_d: 123 }\n" - "field_e: OK\n" - "field_f: OK"); - - verifyFormat("field_a: OK\n" - "field_b: \"OK\"\n" - "field_c: \"OK\"\n" - "msg_field: { field_d: 123 field_e: OK }"); - - verifyFormat("a: {\n" - " field_a: OK\n" - " field_b { field_c: OK }\n" - " field_d: OKOKOK\n" - " field_e: OK\n" - "}"); - - verifyFormat("field_a: OK,\n" - "field_b { field_c: OK },\n" - "field_d: OKOKOK,\n" - "field_e: OK"); -} - -TEST_F(FormatTestTextProto, AddsNewlinesAfterTrailingComments) { - verifyFormat("field_a: OK // Comment\n" - "field_b: 1"); - - verifyFormat("field_a: OK\n" - "msg_field: {\n" - " field_b: OK // Comment\n" - "}"); - - verifyFormat("field_a: OK\n" - "msg_field {\n" - " field_b: OK // Comment\n" - "}"); -} - -TEST_F(FormatTestTextProto, ImplicitStringLiteralConcatenation) { - verifyFormat("field_a: 'aaaaa'\n" - " 'bbbbb'"); - verifyFormat("field_a: \"aaaaa\"\n" - " \"bbbbb\""); - FormatStyle Style = getGoogleStyle(FormatStyle::LK_TextProto); - Style.AlwaysBreakBeforeMultilineStrings = true; - verifyFormat("field_a:\n" - " 'aaaaa'\n" - " 'bbbbb'", - Style); - verifyFormat("field_a:\n" - " \"aaaaa\"\n" - " \"bbbbb\"", - Style); -} - -TEST_F(FormatTestTextProto, SupportsAngleBracketMessageFields) { - // Single-line tests - verifyFormat("msg_field <>"); - verifyFormat("msg_field: <>"); - verifyFormat("msg_field < field_a: OK >"); - verifyFormat("msg_field: < field_a: 123 >"); - verifyFormat("msg_field < field_a <> >"); - verifyFormat("msg_field < field_a < field_b <> > >"); - verifyFormat("msg_field: < field_a < field_b: <> > >"); - verifyFormat("msg_field < field_a: OK, field_b: \"OK\" >"); - verifyFormat("msg_field: < field_a: OK, field_b: \"OK\" >"); - // Multiple lines tests - verifyFormat("msg_field <\n" - " field_a: OK\n" - " field_b: <>,\n" - " field_c: OK\n" - ">"); - - verifyFormat("msg_field <\n" - " field_a { field_b: 1 },\n" - " field_c: < f_d: 2 >\n" - ">"); - - verifyFormat("msg_field: <\n" - " field_a: OK\n" - " field_b: <>,\n" - " field_c: OK\n" - ">"); - - verifyFormat("msg_field: <\n" - " field_a { field_b: 1 },\n" - " field_c: < fd_d: 2 >\n" - ">"); - - verifyFormat("field_a: \"OK\",\n" - "msg_field: < field_b: 123 >,\n" - "field_c: {}"); - - verifyFormat("field_a < field_b: 1 >,\n" - "msg_fid: < fiel_b: 123 >,\n" - "field_c <>"); - - verifyFormat("field_a < field_b: 1 >\n" - "msg_fied: < field_b: 123 >\n" - "field_c <>"); - - verifyFormat("field <\n" - " field < field: <> >,\n" - " field <>\n" - ">\n" - "field: < field: 1 >"); - - verifyFormat("msg_field <\n" - " field_a: OK\n" - " field_b: \"OK\"\n" - " field_c: 1\n" - " field_d: 12.5\n" - " field_e: OK\n" - ">"); - - verifyFormat("msg_field: <>\n" - "field_c: \"OK\",\n" - "msg_field: < field_d: 123 >\n" - "field_e: OK\n" - "msg_field: < field_d: 12 >"); - - verifyFormat("field_a: OK,\n" - "field_b < field_c: OK >,\n" - "field_d: < 12.5 >,\n" - "field_e: OK"); - - verifyFormat("field_a: OK\n" - "field_b < field_c: OK >\n" - "field_d: < 12.5 >\n" - "field_e: OKOKOK"); - - verifyFormat("msg_field <\n" - " field_a: OK,\n" - " field_b < field_c: OK >,\n" - " field_d: < 12.5 >,\n" - " field_e: OK\n" - ">"); - - verifyFormat("msg_field <\n" - " field_a: < field: OK >,\n" - " field_b < field_c: OK >,\n" - " field_d: < 12.5 >,\n" - " field_e: OK,\n" - ">"); - - verifyFormat("msg_field: <\n" - " field_a: \"OK\"\n" - " msg_field: { field_b: OK }\n" - " field_g: OK\n" - " field_g: OK\n" - " field_g: OK\n" - ">"); - - verifyFormat("field_a {\n" - " field_d: ok\n" - " field_b: < field_c: 1 >\n" - " field_d: ok\n" - " field_d: ok\n" - "}"); - - verifyFormat("field_a: {\n" - " field_d: ok\n" - " field_b: < field_c: 1 >\n" - " field_d: ok\n" - " field_d: ok\n" - "}"); - - verifyFormat("field_a: <\n" - " f1: 1,\n" - " f2: <>\n" - ">\n" - "field_b <\n" - " field_b1: <>\n" - " field_b2: ok,\n" - " field_b3: <\n" - " field_x {} // Comment\n" - " field_y: { field_z: 1 }\n" - " field_w: ok\n" - " >\n" - " field {\n" - " field_x <> // Comment\n" - " field_y: < field_z: 1 >\n" - " field_w: ok\n" - " msg_field: <\n" - " field: <>\n" - " field: < field: 1 >\n" - " field: < field: 2 >\n" - " field: < field: 3 >\n" - " field: < field: 4 >\n" - " field: ok\n" - " >\n" - " }\n" - ">\n" - "field: OK,\n" - "field_c < field < field <> > >"); - - verifyFormat("app_id: 'com.javax.swing.salsa.latino'\n" - "head_id: 1\n" - "data < key: value >"); - - verifyFormat("app_id: 'com.javax.swing.salsa.latino'\n" - "head_id: 1\n" - "data < key: value >\n" - "tail_id: 2"); - - verifyFormat("app_id: 'com.javax.swing.salsa.latino'\n" - "head_id: 1\n" - "data < key: value >\n" - "data { key: value }"); - - verifyFormat("app {\n" - " app_id: 'com.javax.swing.salsa.latino'\n" - " head_id: 1\n" - " data < key: value >\n" - "}"); - - verifyFormat("app: {\n" - " app_id: 'com.javax.swing.salsa.latino'\n" - " head_id: 1\n" - " data < key: value >\n" - "}"); - - verifyFormat("app_id: 'com.javax.swing.salsa.latino'\n" - "headheadheadheadheadhead_id: 1\n" - "product_data { product { 1 } }"); - - verifyFormat("app_id: 'com.javax.swing.salsa.latino'\n" - "headheadheadheadheadhead_id: 1\n" - "product_data < product { 1 } >"); - - verifyFormat("app_id: 'com.javax.swing.salsa.latino'\n" - "headheadheadheadheadhead_id: 1\n" - "product_data < product < 1 > >"); - - verifyFormat("app <\n" - " app_id: 'com.javax.swing.salsa.latino'\n" - " headheadheadheadheadhead_id: 1\n" - " product_data < product { 1 } >\n" - ">"); - - verifyFormat("dcccwrnfioeruvginerurneitinfo {\n" - " exte3nsionrnfvui { key: value }\n" - "}"); -} - -TEST_F(FormatTestTextProto, DiscardsUnbreakableTailIfCanBreakAfter) { - // The two closing braces count towards the string UnbreakableTailLength, but - // since we have broken after the corresponding opening braces, we don't - // consider that length for string breaking. - verifyFormat( - "foo: {\n" - " bar: {\n" - " text: \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" - " }\n" - "}"); -} - -TEST_F(FormatTestTextProto, KeepsLongStringLiteralsOnSameLine) { - verifyFormat( - "foo: {\n" - " text: \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaasaaaaaaaaaa\"\n" - "}"); -} - -TEST_F(FormatTestTextProto, KeepsCommentsIndentedInList) { - verifyFormat("aaaaaaaaaa: 100\n" - "bbbbbbbbbbbbbbbbbbbbbbbbbbb: 200\n" - "# Single line comment for stuff here.\n" - "cccccccccccccccccccccccc: 3849\n" - "# Multiline comment for stuff here.\n" - "# Multiline comment for stuff here.\n" - "# Multiline comment for stuff here.\n" - "cccccccccccccccccccccccc: 3849"); -} - -TEST_F(FormatTestTextProto, UnderstandsHashHashComments) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_TextProto); - Style.ColumnLimit = 60; // To make writing tests easier. - EXPECT_EQ("aaa: 100\n" - "##this is a double-hash comment.\n" - "bb: 100\n" - "## another double-hash comment.\n" - "### a triple-hash comment\n" - "cc: 200\n" - "#### a quadriple-hash comment\n" - "dd: 100\n", - format("aaa: 100\n" - "##this is a double-hash comment.\n" - "bb: 100\n" - "## another double-hash comment.\n" - "### a triple-hash comment\n" - "cc: 200\n" - "#### a quadriple-hash comment\n" - "dd: 100\n", - Style)); -} - -TEST_F(FormatTestTextProto, FormatsExtensions) { - verifyFormat("[type] { key: value }"); - verifyFormat("[type] {\n" - " keyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy: value\n" - "}"); - verifyFormat("[type.type] { key: value }"); - verifyFormat("[type.type] < key: value >"); - verifyFormat("[type.type/type.type] { key: value }"); - verifyFormat("msg {\n" - " [type.type] { key: value }\n" - "}"); - verifyFormat("msg {\n" - " [type.type] {\n" - " keyyyyyyyyyyyyyy: valuuuuuuuuuuuuuuuuuuuuuuuuue\n" - " }\n" - "}"); - verifyFormat("key: value\n" - "[a.b] { key: value }"); - verifyFormat("msg: <\n" - " key: value\n" - " [a.b.c/d.e]: < key: value >\n" - " [f.g]: <\n" - " key: valueeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee\n" - " key: {}\n" - " >\n" - " key {}\n" - " [h.i.j] < key: value >\n" - " [a]: {\n" - " [b.c]: {}\n" - " [d] <>\n" - " [e/f]: 1\n" - " }\n" - ">"); - verifyFormat("[longg.long.long.long.long.long.long.long.long.long.long\n" - " .longg.longlong] { key: value }"); - verifyFormat("[longg.long.long.long.long.long.long.long.long.long.long\n" - " .longg.longlong] {\n" - " key: value\n" - " key: value\n" - " key: value\n" - " key: value\n" - "}"); - verifyFormat("[longg.long.long.long.long.long.long.long.long.long\n" - " .long/longg.longlong] { key: value }"); - verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/\n" - " bbbbbbbbbbbbbb] { key: value }"); - // These go over the column limit intentionally, since the alternative - // [aa..a\n] is worse. - verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa] {\n" - " key: value\n" - "}"); - verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa] {\n" - " [type.type] {\n" - " keyyyyyyyyyyyyyy: valuuuuuuuuuuuuuuuuuuuuuuuuue\n" - " }\n" - "}"); - verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/\n" - " bbbbbbb] {\n" - " [type.type] {\n" - " keyyyyyyyyyyyyyy: valuuuuuuuuuuuuuuuuuuuuuuuuue\n" - " }\n" - "}"); - verifyFormat( - "aaaaaaaaaaaaaaa {\n" - " bbbbbb {\n" - " [a.b/cy] {\n" - " eeeeeeeeeeeee: \"The lazy coo cat jumps over the lazy hot dog\"\n" - " }\n" - " }\n" - "}"); -} - -TEST_F(FormatTestTextProto, SpacesAroundPercents) { - verifyFormat("key: %d"); - verifyFormat("key: 0x%04x"); - verifyFormat("key: \"%d %d\""); -} - -TEST_F(FormatTestTextProto, FormatsRepeatedListInitializers) { - verifyFormat("keys: []"); - verifyFormat("keys: [ 1 ]"); - verifyFormat("keys: [ 'ala', 'bala' ]"); - verifyFormat("keys: [\n" - " 'ala',\n" - " 'bala',\n" - " 'porto',\n" - " 'kala',\n" - " 'too',\n" - " 'long',\n" - " 'ng'\n" - "]"); - verifyFormat("key: item\n" - "keys: [\n" - " 'ala',\n" - " 'bala',\n" - " 'porto',\n" - " 'kala',\n" - " 'too',\n" - " 'long',\n" - " 'long',\n" - " 'long'\n" - "]\n" - "key: item\n" - "msg {\n" - " key: item\n" - " keys: [\n" - " 'ala',\n" - " 'bala',\n" - " 'porto',\n" - " 'kala',\n" - " 'too',\n" - " 'long',\n" - " 'long'\n" - " ]\n" - "}\n" - "key: value" - ); - FormatStyle Style = getGoogleStyle(FormatStyle::LK_TextProto); - Style.ColumnLimit = 60; // To make writing tests easier. - Style.Cpp11BracedListStyle = true; - verifyFormat("keys: [1]", Style); -} - -TEST_F(FormatTestTextProto, AcceptsOperatorAsKey) { - verifyFormat("aaaaaaaaaaa: <\n" - " bbbbbbbbb: <\n" - " ccccccccccccccccccccccc: <\n" - " operator: 1\n" - " operator: 2\n" - " operator: 3\n" - " operator { key: value }\n" - " >\n" - " >\n" - ">"); -} - -TEST_F(FormatTestTextProto, BreaksConsecutiveStringLiterals) { - verifyFormat("ala: \"str1\"\n" - " \"str2\"\n"); -} - -TEST_F(FormatTestTextProto, PutsMultipleEntriesInExtensionsOnNewlines) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_TextProto); - verifyFormat("pppppppppp: {\n" - " ssssss: \"http://example.com/blahblahblah\"\n" - " ppppppp: \"sssss/MMMMMMMMMMMM\"\n" - " [ns.sssss.eeeeeeeee.eeeeeeeeeeeeeee] { begin: 24 end: 252 }\n" - " [ns.sssss.eeeeeeeee.eeeeeeeeeeeeeee] {\n" - " begin: 24\n" - " end: 252\n" - " key: value\n" - " key: value\n" - " }\n" - "}", Style); -} - -TEST_F(FormatTestTextProto, BreaksAfterBraceFollowedByClosingBraceOnNextLine) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_TextProto); - Style.ColumnLimit = 60; - verifyFormat("keys: [\n" - " data: { item: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' }\n" - "]"); - verifyFormat("keys: <\n" - " data: { item: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' }\n" - ">"); -} - -TEST_F(FormatTestTextProto, BreaksEntriesOfSubmessagesContainingSubmessages) { - FormatStyle Style = getGoogleStyle(FormatStyle::LK_TextProto); - Style.ColumnLimit = 60; - // The column limit allows for the keys submessage to be put on 1 line, but we - // break it since it contains a submessage an another entry. - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " sub <>\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " sub {}\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " sub {}\n" - " sub: <>\n" - " sub: []\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " item: 'aaaaaaaaaaa'\n" - " sub { msg: 1 }\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " item: 'aaaaaaaaaaa'\n" - " sub: { msg: 1 }\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " item: 'aaaaaaaaaaa'\n" - " sub < msg: 1 >\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " item: 'aaaaaaaaaaa'\n" - " sub: [ msg: 1 ]\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: <\n" - " item: 'aaaaaaaaaaa'\n" - " sub: [ 1, 2 ]\n" - ">"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " sub {}\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " sub: []\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " sub <>\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " sub { key: value }\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " sub: [ 1, 2 ]\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " sub < sub_2: {} >\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " item: data\n" - " sub: [ 1, 2 ]\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - "}"); - verifyFormat("key: valueeeeeeee\n" - "keys: {\n" - " item: data\n" - " sub < sub_2: {} >\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - "}"); - verifyFormat("sub: {\n" - " key: valueeeeeeee\n" - " keys: {\n" - " sub: [ 1, 2 ]\n" - " item: 'aaaaaaaaaaaaaaaa'\n" - " }\n" - "}"); - verifyFormat("sub: {\n" - " key: 1\n" - " sub: {}\n" - "}\n" - "# comment\n"); - verifyFormat("sub: {\n" - " key: 1\n" - " # comment\n" - " sub: {}\n" - "}"); -} - -TEST_F(FormatTestTextProto, PreventBreaksBetweenKeyAndSubmessages) { - verifyFormat("submessage: {\n" - " key: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'\n" - "}"); - verifyFormat("submessage {\n" - " key: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'\n" - "}"); - verifyFormat("submessage: <\n" - " key: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'\n" - ">"); - verifyFormat("submessage <\n" - " key: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'\n" - ">"); - verifyFormat("repeatedd: [\n" - " 'eyaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'\n" - "]"); - // "{" is going over the column limit. - verifyFormat( - "submessageeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee: {\n" - " key: 'aaaaa'\n" - "}"); -} - -TEST_F(FormatTestTextProto, FormatsCommentsAtEndOfFile) { - verifyFormat("key: value\n" - "# endfile comment"); - verifyFormat("key: value\n" - "// endfile comment"); - verifyFormat("key: value\n" - "// endfile comment 1\n" - "// endfile comment 2"); - verifyFormat("submessage { key: value }\n" - "# endfile comment"); - verifyFormat("submessage <\n" - " key: value\n" - " item {}\n" - ">\n" - "# endfile comment"); -} - -TEST_F(FormatTestTextProto, KeepsAmpersandsNextToKeys) { - verifyFormat("@tmpl { field: 1 }"); - verifyFormat("@placeholder: 1"); - verifyFormat("@name <>"); - verifyFormat("submessage: @base { key: value }"); - verifyFormat("submessage: @base {\n" - " key: value\n" - " item: {}\n" - "}"); - verifyFormat("submessage: {\n" - " msg: @base {\n" - " yolo: {}\n" - " key: value\n" - " }\n" - " key: value\n" - "}"); -} - -} // end namespace tooling -} // end namespace clang diff --git a/unittests/Format/FormatTestUtils.h b/unittests/Format/FormatTestUtils.h deleted file mode 100644 index d82d84ebedeff..0000000000000 --- a/unittests/Format/FormatTestUtils.h +++ /dev/null @@ -1,68 +0,0 @@ -//===- unittest/Format/FormatTestUtils.h - Formatting unit tests ----------===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// -// -// This file defines utility functions for Clang-Format related tests. -// -//===----------------------------------------------------------------------===// - -#ifndef LLVM_CLANG_UNITTESTS_FORMAT_FORMATTESTUTILS_H -#define LLVM_CLANG_UNITTESTS_FORMAT_FORMATTESTUTILS_H - -#include "llvm/ADT/StringRef.h" - -namespace clang { -namespace format { -namespace test { - -inline std::string messUp(llvm::StringRef Code) { - std::string MessedUp(Code.str()); - bool InComment = false; - bool InPreprocessorDirective = false; - bool JustReplacedNewline = false; - for (unsigned i = 0, e = MessedUp.size() - 1; i != e; ++i) { - if (MessedUp[i] == '/' && MessedUp[i + 1] == '/') { - if (JustReplacedNewline) - MessedUp[i - 1] = '\n'; - InComment = true; - } else if (MessedUp[i] == '#' && - (JustReplacedNewline || i == 0 || MessedUp[i - 1] == '\n')) { - if (i != 0) - MessedUp[i - 1] = '\n'; - InPreprocessorDirective = true; - } else if (MessedUp[i] == '\\' && MessedUp[i + 1] == '\n') { - MessedUp[i] = ' '; - MessedUp[i + 1] = ' '; - } else if (MessedUp[i] == '\n') { - if (InComment) { - InComment = false; - } else if (InPreprocessorDirective) { - InPreprocessorDirective = false; - } else { - JustReplacedNewline = true; - MessedUp[i] = ' '; - } - } else if (MessedUp[i] != ' ') { - JustReplacedNewline = false; - } - } - std::string WithoutWhitespace; - if (MessedUp[0] != ' ') - WithoutWhitespace.push_back(MessedUp[0]); - for (unsigned i = 1, e = MessedUp.size(); i != e; ++i) { - if (MessedUp[i] != ' ' || MessedUp[i - 1] != ' ') - WithoutWhitespace.push_back(MessedUp[i]); - } - return WithoutWhitespace; -} - -} // end namespace test -} // end namespace format -} // end namespace clang - -#endif diff --git a/unittests/Format/NamespaceEndCommentsFixerTest.cpp b/unittests/Format/NamespaceEndCommentsFixerTest.cpp deleted file mode 100644 index ee083b8ad14cf..0000000000000 --- a/unittests/Format/NamespaceEndCommentsFixerTest.cpp +++ /dev/null @@ -1,786 +0,0 @@ -//===- NamespaceEndCommentsFixerTest.cpp - Formatting unit tests ----------===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "clang/Format/Format.h" - -#include "clang/Frontend/TextDiagnosticPrinter.h" -#include "llvm/Support/Debug.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "namespace-end-comments-fixer-test" - -namespace clang { -namespace format { -namespace { - -class NamespaceEndCommentsFixerTest : public ::testing::Test { -protected: - std::string - fixNamespaceEndComments(llvm::StringRef Code, - const std::vector<tooling::Range> &Ranges, - const FormatStyle &Style = getLLVMStyle()) { - LLVM_DEBUG(llvm::errs() << "---\n"); - LLVM_DEBUG(llvm::errs() << Code << "\n\n"); - tooling::Replacements Replaces = - clang::format::fixNamespaceEndComments(Style, Code, Ranges, "<stdin>"); - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); - return *Result; - } - - std::string - fixNamespaceEndComments(llvm::StringRef Code, - const FormatStyle &Style = getLLVMStyle()) { - return fixNamespaceEndComments( - Code, - /*Ranges=*/{1, tooling::Range(0, Code.size())}, Style); - } -}; - -TEST_F(NamespaceEndCommentsFixerTest, AddsEndComment) { - EXPECT_EQ("namespace {\n" - " int i;\n" - " int j;\n" - "}// namespace", - fixNamespaceEndComments("namespace {\n" - " int i;\n" - " int j;\n" - "}")); - EXPECT_EQ("namespace {\n" - " int i;\n" - " int j;\n" - "}// namespace\n", - fixNamespaceEndComments("namespace {\n" - " int i;\n" - " int j;\n" - "}\n")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - " int j;\n" - "}// namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - " int j;\n" - "}")); - EXPECT_EQ("inline namespace A {\n" - " int i;\n" - " int j;\n" - "}// namespace A", - fixNamespaceEndComments("inline namespace A {\n" - " int i;\n" - " int j;\n" - "}")); - EXPECT_EQ("namespace ::A {\n" - " int i;\n" - " int j;\n" - "}// namespace ::A", - fixNamespaceEndComments("namespace ::A {\n" - " int i;\n" - " int j;\n" - "}")); - EXPECT_EQ("namespace ::A::B {\n" - " int i;\n" - " int j;\n" - "}// namespace ::A::B", - fixNamespaceEndComments("namespace ::A::B {\n" - " int i;\n" - " int j;\n" - "}")); - EXPECT_EQ("namespace /**/::/**/A/**/::/**/B/**/ {\n" - " int i;\n" - " int j;\n" - "}// namespace ::A::B", - fixNamespaceEndComments("namespace /**/::/**/A/**/::/**/B/**/ {\n" - " int i;\n" - " int j;\n" - "}")); - EXPECT_EQ("namespace A {\n" - "namespace B {\n" - " int i;\n" - "}\n" - "}// namespace A", - fixNamespaceEndComments("namespace A {\n" - "namespace B {\n" - " int i;\n" - "}\n" - "}")); - EXPECT_EQ("namespace A {\n" - "namespace B {\n" - " int i;\n" - " int j;\n" - "}// namespace B\n" - "}// namespace A", - fixNamespaceEndComments("namespace A {\n" - "namespace B {\n" - " int i;\n" - " int j;\n" - "}\n" - "}")); - EXPECT_EQ("namespace A {\n" - " int a;\n" - " int b;\n" - "}// namespace A\n" - "namespace B {\n" - " int b;\n" - " int a;\n" - "}// namespace B", - fixNamespaceEndComments("namespace A {\n" - " int a;\n" - " int b;\n" - "}\n" - "namespace B {\n" - " int b;\n" - " int a;\n" - "}")); - EXPECT_EQ("namespace A {\n" - " int a1;\n" - " int a2;\n" - "}// namespace A\n" - "namespace A {\n" - " int a2;\n" - " int a1;\n" - "}// namespace A", - fixNamespaceEndComments("namespace A {\n" - " int a1;\n" - " int a2;\n" - "}\n" - "namespace A {\n" - " int a2;\n" - " int a1;\n" - "}")); - EXPECT_EQ("namespace A {\n" - " int a;\n" - " int b;\n" - "}// namespace A\n" - "// comment about b\n" - "int b;", - fixNamespaceEndComments("namespace A {\n" - " int a;\n" - " int b;\n" - "}\n" - "// comment about b\n" - "int b;")); - - EXPECT_EQ("namespace A {\n" - "namespace B {\n" - "namespace C {\n" - "namespace D {\n" - "}\n" - "}// namespace C\n" - "}// namespace B\n" - "}// namespace A", - fixNamespaceEndComments("namespace A {\n" - "namespace B {\n" - "namespace C {\n" - "namespace D {\n" - "}\n" - "}\n" - "}\n" - "}")); - - // Add comment for namespaces which will be 'compacted' - FormatStyle CompactNamespacesStyle = getLLVMStyle(); - CompactNamespacesStyle.CompactNamespaces = true; - EXPECT_EQ("namespace out { namespace in {\n" - "int i;\n" - "int j;\n" - "}}// namespace out::in", - fixNamespaceEndComments("namespace out { namespace in {\n" - "int i;\n" - "int j;\n" - "}}", - CompactNamespacesStyle)); - EXPECT_EQ("namespace out {\n" - "namespace in {\n" - "int i;\n" - "int j;\n" - "}\n" - "}// namespace out::in", - fixNamespaceEndComments("namespace out {\n" - "namespace in {\n" - "int i;\n" - "int j;\n" - "}\n" - "}", - CompactNamespacesStyle)); - EXPECT_EQ("namespace out { namespace in {\n" - "int i;\n" - "int j;\n" - "};}// namespace out::in", - fixNamespaceEndComments("namespace out { namespace in {\n" - "int i;\n" - "int j;\n" - "};}", - CompactNamespacesStyle)); - - // Adds an end comment after a semicolon. - EXPECT_EQ("namespace {\n" - " int i;\n" - " int j;\n" - "};// namespace", - fixNamespaceEndComments("namespace {\n" - " int i;\n" - " int j;\n" - "};")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - " int j;\n" - "};// namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - " int j;\n" - "};")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - " int j;\n" - "};// namespace A\n" - "// unrelated", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - " int j;\n" - "};\n" - "// unrelated")); -} - -TEST_F(NamespaceEndCommentsFixerTest, AddsNewlineIfNeeded) { - EXPECT_EQ("namespace A {\n" - " int i;\n" - " int j;\n" - "}// namespace A\n" - " int k;", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - " int j;\n" - "} int k;")); - EXPECT_EQ("namespace {\n" - " int i;\n" - " int j;\n" - "}// namespace\n" - " int k;", - fixNamespaceEndComments("namespace {\n" - " int i;\n" - " int j;\n" - "} int k;")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - " int j;\n" - "}// namespace A\n" - " namespace B {\n" - " int j;\n" - " int k;\n" - "}// namespace B", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - " int j;\n" - "} namespace B {\n" - " int j;\n" - " int k;\n" - "}")); - EXPECT_EQ("namespace {\n" - " int i;\n" - " int j;\n" - "};// namespace\n" - "int k;", - fixNamespaceEndComments("namespace {\n" - " int i;\n" - " int j;\n" - "};int k;")); - EXPECT_EQ("namespace {\n" - " int i;\n" - " int j;\n" - "};// namespace\n" - ";", - fixNamespaceEndComments("namespace {\n" - " int i;\n" - " int j;\n" - "};;")); -} - -TEST_F(NamespaceEndCommentsFixerTest, DoesNotAddEndCommentForShortNamespace) { - EXPECT_EQ("namespace {}", fixNamespaceEndComments("namespace {}")); - EXPECT_EQ("namespace A {}", fixNamespaceEndComments("namespace A {}")); - EXPECT_EQ("namespace A { a }", - fixNamespaceEndComments("namespace A { a }")); - EXPECT_EQ("namespace A { a };", - fixNamespaceEndComments("namespace A { a };")); -} - -TEST_F(NamespaceEndCommentsFixerTest, DoesNotAddCommentAfterUnaffectedRBrace) { - EXPECT_EQ("namespace A {\n" - " int i;\n" - "}", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "}", - // The range (16, 3) spans the 'int' above. - /*Ranges=*/{1, tooling::Range(16, 3)})); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "};", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "};", - // The range (16, 3) spans the 'int' above. - /*Ranges=*/{1, tooling::Range(16, 3)})); -} - -TEST_F(NamespaceEndCommentsFixerTest, DoesNotAddCommentAfterRBraceInPPDirective) { - EXPECT_EQ("#define SAD \\\n" - "namespace A { \\\n" - " int i; \\\n" - "}", - fixNamespaceEndComments("#define SAD \\\n" - "namespace A { \\\n" - " int i; \\\n" - "}")); -} - -TEST_F(NamespaceEndCommentsFixerTest, KeepsValidEndComment) { - EXPECT_EQ("namespace {\n" - " int i;\n" - "} // end anonymous namespace", - fixNamespaceEndComments("namespace {\n" - " int i;\n" - "} // end anonymous namespace")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "} /* end of namespace A */", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "} /* end of namespace A */")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "} // namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "} // namespace A")); - EXPECT_EQ("namespace A::B {\n" - " int i;\n" - "} // end namespace A::B", - fixNamespaceEndComments("namespace A::B {\n" - " int i;\n" - "} // end namespace A::B")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "}; // end namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "}; // end namespace A")); - EXPECT_EQ("namespace {\n" - " int i;\n" - "}; /* unnamed namespace */", - fixNamespaceEndComments("namespace {\n" - " int i;\n" - "}; /* unnamed namespace */")); -} - -TEST_F(NamespaceEndCommentsFixerTest, UpdatesInvalidEndLineComment) { - EXPECT_EQ("namespace {\n" - " int i;\n" - "} // namespace", - fixNamespaceEndComments("namespace {\n" - " int i;\n" - "} // namespace A")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "} // namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "} // namespace")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "} // namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "} //")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "} // namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "} //")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "} // namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "} // banamespace A")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "}; // namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "}; // banamespace A")); - // Updates invalid line comments even for short namespaces. - EXPECT_EQ("namespace A {} // namespace A", - fixNamespaceEndComments("namespace A {} // namespace")); - EXPECT_EQ("namespace A {}; // namespace A", - fixNamespaceEndComments("namespace A {}; // namespace")); - - // Update invalid comments for compacted namespaces. - FormatStyle CompactNamespacesStyle = getLLVMStyle(); - CompactNamespacesStyle.CompactNamespaces = true; - EXPECT_EQ("namespace out { namespace in {\n" - "}} // namespace out::in", - fixNamespaceEndComments("namespace out { namespace in {\n" - "}} // namespace out", - CompactNamespacesStyle)); - EXPECT_EQ("namespace out { namespace in {\n" - "}} // namespace out::in", - fixNamespaceEndComments("namespace out { namespace in {\n" - "}} // namespace in", - CompactNamespacesStyle)); - EXPECT_EQ("namespace out { namespace in {\n" - "}\n" - "} // namespace out::in", - fixNamespaceEndComments("namespace out { namespace in {\n" - "}// banamespace in\n" - "} // namespace out", - CompactNamespacesStyle)); -} - -TEST_F(NamespaceEndCommentsFixerTest, UpdatesInvalidEndBlockComment) { - EXPECT_EQ("namespace {\n" - " int i;\n" - "} // namespace", - fixNamespaceEndComments("namespace {\n" - " int i;\n" - "} /* namespace A */")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "} // namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "} /* end namespace */")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "} // namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "} /**/")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "} // namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "} /* end unnamed namespace */")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "} // namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "} /* banamespace A */")); - EXPECT_EQ("namespace A {\n" - " int i;\n" - "}; // namespace A", - fixNamespaceEndComments("namespace A {\n" - " int i;\n" - "}; /* banamespace A */")); - EXPECT_EQ("namespace A {} // namespace A", - fixNamespaceEndComments("namespace A {} /**/")); - EXPECT_EQ("namespace A {}; // namespace A", - fixNamespaceEndComments("namespace A {}; /**/")); -} - -TEST_F(NamespaceEndCommentsFixerTest, - DoesNotAddEndCommentForNamespacesControlledByMacros) { - EXPECT_EQ("#ifdef 1\n" - "namespace A {\n" - "#elseif\n" - "namespace B {\n" - "#endif\n" - " int i;\n" - "}\n" - "}\n", - fixNamespaceEndComments("#ifdef 1\n" - "namespace A {\n" - "#elseif\n" - "namespace B {\n" - "#endif\n" - " int i;\n" - "}\n" - "}\n")); -} - -TEST_F(NamespaceEndCommentsFixerTest, AddEndCommentForNamespacesAroundMacros) { - // Conditional blocks around are fine - EXPECT_EQ("namespace A {\n" - "#if 1\n" - "int i;\n" - "#endif\n" - "}// namespace A", - fixNamespaceEndComments("namespace A {\n" - "#if 1\n" - "int i;\n" - "#endif\n" - "}")); - EXPECT_EQ("#if 1\n" - "#endif\n" - "namespace A {\n" - "int i;\n" - "int j;\n" - "}// namespace A", - fixNamespaceEndComments("#if 1\n" - "#endif\n" - "namespace A {\n" - "int i;\n" - "int j;\n" - "}")); - EXPECT_EQ("namespace A {\n" - "int i;\n" - "int j;\n" - "}// namespace A\n" - "#if 1\n" - "#endif", - fixNamespaceEndComments("namespace A {\n" - "int i;\n" - "int j;\n" - "}\n" - "#if 1\n" - "#endif")); - EXPECT_EQ("#if 1\n" - "namespace A {\n" - "int i;\n" - "int j;\n" - "}// namespace A\n" - "#endif", - fixNamespaceEndComments("#if 1\n" - "namespace A {\n" - "int i;\n" - "int j;\n" - "}\n" - "#endif")); - - // Macro definition has no impact - EXPECT_EQ("namespace A {\n" - "#define FOO\n" - "int i;\n" - "}// namespace A", - fixNamespaceEndComments("namespace A {\n" - "#define FOO\n" - "int i;\n" - "}")); - EXPECT_EQ("#define FOO\n" - "namespace A {\n" - "int i;\n" - "int j;\n" - "}// namespace A", - fixNamespaceEndComments("#define FOO\n" - "namespace A {\n" - "int i;\n" - "int j;\n" - "}")); - EXPECT_EQ("namespace A {\n" - "int i;\n" - "int j;\n" - "}// namespace A\n" - "#define FOO\n", - fixNamespaceEndComments("namespace A {\n" - "int i;\n" - "int j;\n" - "}\n" - "#define FOO\n")); - - // No replacement if open & close in different conditional blocks - EXPECT_EQ("#if 1\n" - "namespace A {\n" - "#endif\n" - "int i;\n" - "int j;\n" - "#if 1\n" - "}\n" - "#endif", - fixNamespaceEndComments("#if 1\n" - "namespace A {\n" - "#endif\n" - "int i;\n" - "int j;\n" - "#if 1\n" - "}\n" - "#endif")); - EXPECT_EQ("#ifdef A\n" - "namespace A {\n" - "#endif\n" - "int i;\n" - "int j;\n" - "#ifdef B\n" - "}\n" - "#endif", - fixNamespaceEndComments("#ifdef A\n" - "namespace A {\n" - "#endif\n" - "int i;\n" - "int j;\n" - "#ifdef B\n" - "}\n" - "#endif")); - - // No replacement inside unreachable conditional block - EXPECT_EQ("#if 0\n" - "namespace A {\n" - "int i;\n" - "int j;\n" - "}\n" - "#endif", - fixNamespaceEndComments("#if 0\n" - "namespace A {\n" - "int i;\n" - "int j;\n" - "}\n" - "#endif")); -} - -TEST_F(NamespaceEndCommentsFixerTest, - DoesNotAddEndCommentForNamespacesInMacroDeclarations) { - EXPECT_EQ("#ifdef 1\n" - "namespace A {\n" - "#elseif\n" - "namespace B {\n" - "#endif\n" - " int i;\n" - "}\n" - "}\n", - fixNamespaceEndComments("#ifdef 1\n" - "namespace A {\n" - "#elseif\n" - "namespace B {\n" - "#endif\n" - " int i;\n" - "}\n" - "}\n")); - EXPECT_EQ("namespace {\n" - " int i;\n" - " int j;\n" - "}// namespace\n" - "#if A\n" - " int i;\n" - "#else\n" - " int j;\n" - "#endif", - fixNamespaceEndComments("namespace {\n" - " int i;\n" - " int j;\n" - "}\n" - "#if A\n" - " int i;\n" - "#else\n" - " int j;\n" - "#endif")); - EXPECT_EQ("#if A\n" - "namespace A {\n" - "#else\n" - "namespace B {\n" - "#endif\n" - "int i;\n" - "int j;\n" - "}", - fixNamespaceEndComments("#if A\n" - "namespace A {\n" - "#else\n" - "namespace B {\n" - "#endif\n" - "int i;\n" - "int j;\n" - "}")); - EXPECT_EQ("#if A\n" - "namespace A {\n" - "#else\n" - "namespace B {\n" - "#endif\n" - "int i;\n" - "int j;\n" - "} // namespace A", - fixNamespaceEndComments("#if A\n" - "namespace A {\n" - "#else\n" - "namespace B {\n" - "#endif\n" - "int i;\n" - "int j;\n" - "} // namespace A")); - EXPECT_EQ("#if A\n" - "namespace A {\n" - "#else\n" - "namespace B {\n" - "#endif\n" - "int i;\n" - "int j;\n" - "} // namespace B", - fixNamespaceEndComments("#if A\n" - "namespace A {\n" - "#else\n" - "namespace B {\n" - "#endif\n" - "int i;\n" - "int j;\n" - "} // namespace B")); - EXPECT_EQ("namespace A\n" - "int i;\n" - "int j;\n" - "#if A\n" - "}\n" - "#else\n" - "}\n" - "#endif", - fixNamespaceEndComments("namespace A\n" - "int i;\n" - "int j;\n" - "#if A\n" - "}\n" - "#else\n" - "}\n" - "#endif")); - EXPECT_EQ("namespace A\n" - "int i;\n" - "int j;\n" - "#if A\n" - "} // namespace A\n" - "#else\n" - "} // namespace A\n" - "#endif", - fixNamespaceEndComments("namespace A\n" - "int i;\n" - "int j;\n" - "#if A\n" - "} // namespace A\n" - "#else\n" - "} // namespace A\n" - "#endif")); -} - -TEST_F(NamespaceEndCommentsFixerTest, - DoesNotAddEndCommentForUnbalancedRBracesAfterNamespaceEnd) { - EXPECT_EQ("namespace {\n" - " int i;\n" - "} // namespace\n" - "}", - fixNamespaceEndComments("namespace {\n" - " int i;\n" - "} // namespace\n" - "}")); -} - -TEST_F(NamespaceEndCommentsFixerTest, HandlesInlineAtEndOfLine_PR32438) { - EXPECT_EQ("template <int> struct a {};\n" - "struct a<bool{}> b() {\n" - "}\n" - "#define c inline\n" - "void d() {\n" - "}\n", - fixNamespaceEndComments("template <int> struct a {};\n" - "struct a<bool{}> b() {\n" - "}\n" - "#define c inline\n" - "void d() {\n" - "}\n")); -} -} // end namespace -} // end namespace format -} // end namespace clang diff --git a/unittests/Format/SortImportsTestJS.cpp b/unittests/Format/SortImportsTestJS.cpp deleted file mode 100644 index 91be0313cf80f..0000000000000 --- a/unittests/Format/SortImportsTestJS.cpp +++ /dev/null @@ -1,313 +0,0 @@ -//===- unittest/Format/SortImportsTestJS.cpp - JS import sort unit tests --===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "FormatTestUtils.h" -#include "clang/Format/Format.h" -#include "llvm/Support/Debug.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -namespace clang { -namespace format { -namespace { - -class SortImportsTestJS : public ::testing::Test { -protected: - std::string sort(StringRef Code, unsigned Offset = 0, unsigned Length = 0) { - StringRef FileName = "input.js"; - if (Length == 0U) - Length = Code.size() - Offset; - std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length)); - auto Sorted = - applyAllReplacements(Code, sortIncludes(Style, Code, Ranges, FileName)); - EXPECT_TRUE(static_cast<bool>(Sorted)); - auto Formatted = applyAllReplacements( - *Sorted, reformat(Style, *Sorted, Ranges, FileName)); - EXPECT_TRUE(static_cast<bool>(Formatted)); - return *Formatted; - } - - void verifySort(llvm::StringRef Expected, llvm::StringRef Code, - unsigned Offset = 0, unsigned Length = 0) { - std::string Result = sort(Code, Offset, Length); - EXPECT_EQ(Expected.str(), Result) << "Expected:\n" - << Expected << "\nActual:\n" - << Result; - } - - FormatStyle Style = getGoogleStyle(FormatStyle::LK_JavaScript); -}; - -TEST_F(SortImportsTestJS, AlreadySorted) { - verifySort("import {sym} from 'a';\n" - "import {sym} from 'b';\n" - "import {sym} from 'c';\n" - "\n" - "let x = 1;", - "import {sym} from 'a';\n" - "import {sym} from 'b';\n" - "import {sym} from 'c';\n" - "\n" - "let x = 1;"); -} - -TEST_F(SortImportsTestJS, BasicSorting) { - verifySort("import {sym} from 'a';\n" - "import {sym} from 'b';\n" - "import {sym} from 'c';\n" - "\n" - "let x = 1;", - "import {sym} from 'a';\n" - "import {sym} from 'c';\n" - "import {sym} from 'b';\n" - "let x = 1;"); -} - -TEST_F(SortImportsTestJS, DefaultBinding) { - verifySort("import A from 'a';\n" - "import B from 'b';\n" - "\n" - "let x = 1;", - "import B from 'b';\n" - "import A from 'a';\n" - "let x = 1;"); -} - -TEST_F(SortImportsTestJS, DefaultAndNamedBinding) { - verifySort("import A, {a} from 'a';\n" - "import B, {b} from 'b';\n" - "\n" - "let x = 1;", - "import B, {b} from 'b';\n" - "import A, {a} from 'a';\n" - "let x = 1;"); -} - -TEST_F(SortImportsTestJS, WrappedImportStatements) { - verifySort("import {sym1, sym2} from 'a';\n" - "import {sym} from 'b';\n" - "\n" - "1;", - "import\n" - " {sym}\n" - " from 'b';\n" - "import {\n" - " sym1,\n" - " sym2\n" - "} from 'a';\n" - "1;"); -} - -TEST_F(SortImportsTestJS, SeparateMainCodeBody) { - verifySort("import {sym} from 'a';" - "\n" - "let x = 1;\n", - "import {sym} from 'a'; let x = 1;\n"); -} - -TEST_F(SortImportsTestJS, Comments) { - verifySort("/** @fileoverview This is a great file. */\n" - "// A very important import follows.\n" - "import {sym} from 'a'; /* more comments */\n" - "import {sym} from 'b'; // from //foo:bar\n", - "/** @fileoverview This is a great file. */\n" - "import {sym} from 'b'; // from //foo:bar\n" - "// A very important import follows.\n" - "import {sym} from 'a'; /* more comments */\n"); - verifySort("import {sym} from 'a';\n" - "import {sym} from 'b';\n" - "\n" - "/** Comment on variable. */\n" - "const x = 1;\n", - "import {sym} from 'b';\n" - "import {sym} from 'a';\n" - "\n" - "/** Comment on variable. */\n" - "const x = 1;\n"); -} - -TEST_F(SortImportsTestJS, SortStar) { - verifySort("import * as foo from 'a';\n" - "import {sym} from 'a';\n" - "import * as bar from 'b';\n", - "import {sym} from 'a';\n" - "import * as foo from 'a';\n" - "import * as bar from 'b';\n"); -} - -TEST_F(SortImportsTestJS, AliasesSymbols) { - verifySort("import {sym1 as alias1} from 'b';\n" - "import {sym2 as alias2, sym3 as alias3} from 'c';\n", - "import {sym2 as alias2, sym3 as alias3} from 'c';\n" - "import {sym1 as alias1} from 'b';\n"); -} - -TEST_F(SortImportsTestJS, SortSymbols) { - verifySort("import {sym1, sym2 as a, sym3} from 'b';\n", - "import {sym2 as a, sym1, sym3} from 'b';\n"); - verifySort("import {sym1 /* important! */, /*!*/ sym2 as a} from 'b';\n", - "import {/*!*/ sym2 as a, sym1 /* important! */} from 'b';\n"); - verifySort("import {sym1, sym2} from 'b';\n", "import {\n" - " sym2 \n" - ",\n" - " sym1 \n" - "} from 'b';\n"); -} - -TEST_F(SortImportsTestJS, GroupImports) { - verifySort("import {a} from 'absolute';\n" - "\n" - "import {b} from '../parent';\n" - "import {b} from '../parent/nested';\n" - "\n" - "import {b} from './relative/path';\n" - "import {b} from './relative/path/nested';\n" - "\n" - "let x = 1;\n", - "import {b} from './relative/path/nested';\n" - "import {b} from './relative/path';\n" - "import {b} from '../parent/nested';\n" - "import {b} from '../parent';\n" - "import {a} from 'absolute';\n" - "let x = 1;\n"); -} - -TEST_F(SortImportsTestJS, Exports) { - verifySort("import {S} from 'bpath';\n" - "\n" - "import {T} from './cpath';\n" - "\n" - "export {A, B} from 'apath';\n" - "export {P} from '../parent';\n" - "export {R} from './relative';\n" - "export {S};\n" - "\n" - "let x = 1;\n" - "export y = 1;\n", - "export {R} from './relative';\n" - "import {T} from './cpath';\n" - "export {S};\n" - "export {A, B} from 'apath';\n" - "import {S} from 'bpath';\n" - "export {P} from '../parent';\n" - "let x = 1;\n" - "export y = 1;\n"); - verifySort("import {S} from 'bpath';\n" - "\n" - "export {T} from 'epath';\n", - "export {T} from 'epath';\n" - "import {S} from 'bpath';\n"); -} - -TEST_F(SortImportsTestJS, SideEffectImports) { - verifySort("import 'ZZside-effect';\n" - "import 'AAside-effect';\n" - "\n" - "import {A} from 'absolute';\n" - "\n" - "import {R} from './relative';\n", - "import {R} from './relative';\n" - "import 'ZZside-effect';\n" - "import {A} from 'absolute';\n" - "import 'AAside-effect';\n"); -} - -TEST_F(SortImportsTestJS, AffectedRange) { - // Affected range inside of import statements. - verifySort("import {sym} from 'a';\n" - "import {sym} from 'b';\n" - "import {sym} from 'c';\n" - "\n" - "let x = 1;", - "import {sym} from 'c';\n" - "import {sym} from 'b';\n" - "import {sym} from 'a';\n" - "let x = 1;", - 0, 30); - // Affected range outside of import statements. - verifySort("import {sym} from 'c';\n" - "import {sym} from 'b';\n" - "import {sym} from 'a';\n" - "\n" - "let x = 1;", - "import {sym} from 'c';\n" - "import {sym} from 'b';\n" - "import {sym} from 'a';\n" - "\n" - "let x = 1;", - 70, 1); -} - -TEST_F(SortImportsTestJS, SortingCanShrink) { - // Sort excluding a suffix. - verifySort("import {B} from 'a';\n" - "import {A} from 'b';\n" - "\n" - "1;", - "import {A} from 'b';\n" - "\n" - "import {B} from 'a';\n" - "\n" - "1;"); -} - -TEST_F(SortImportsTestJS, TrailingComma) { - verifySort("import {A, B,} from 'aa';\n", "import {B, A,} from 'aa';\n"); -} - -TEST_F(SortImportsTestJS, SortCaseInsensitive) { - verifySort("import {A} from 'aa';\n" - "import {A} from 'Ab';\n" - "import {A} from 'b';\n" - "import {A} from 'Bc';\n" - "\n" - "1;", - "import {A} from 'b';\n" - "import {A} from 'Bc';\n" - "import {A} from 'Ab';\n" - "import {A} from 'aa';\n" - "\n" - "1;"); - verifySort("import {aa, Ab, b, Bc} from 'x';\n" - "\n" - "1;", - "import {b, Bc, Ab, aa} from 'x';\n" - "\n" - "1;"); -} - -TEST_F(SortImportsTestJS, SortMultiLine) { - // Reproduces issue where multi-line import was not parsed correctly. - verifySort("import {A} from 'a';\n" - "import {A} from 'b';\n" - "\n" - "1;", - "import\n" - "{\n" - "A\n" - "}\n" - "from\n" - "'b';\n" - "import {A} from 'a';\n" - "\n" - "1;"); -} - -TEST_F(SortImportsTestJS, SortDefaultImports) { - // Reproduces issue where multi-line import was not parsed correctly. - verifySort("import {A} from 'a';\n" - "import {default as B} from 'b';\n", - "import {default as B} from 'b';\n" - "import {A} from 'a';\n"); -} - -} // end namespace -} // end namespace format -} // end namespace clang diff --git a/unittests/Format/SortImportsTestJava.cpp b/unittests/Format/SortImportsTestJava.cpp deleted file mode 100644 index 3bcf809d961bb..0000000000000 --- a/unittests/Format/SortImportsTestJava.cpp +++ /dev/null @@ -1,267 +0,0 @@ -#include "clang/Format/Format.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -namespace clang { -namespace format { -namespace { - -class SortImportsTestJava : public ::testing::Test { -protected: - std::vector<tooling::Range> GetCodeRange(StringRef Code) { - return std::vector<tooling::Range>(1, tooling::Range(0, Code.size())); - } - - std::string sort(StringRef Code, std::vector<tooling::Range> Ranges) { - auto Replaces = sortIncludes(FmtStyle, Code, Ranges, "input.java"); - Ranges = tooling::calculateRangesAfterReplacements(Replaces, Ranges); - auto Sorted = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Sorted)); - auto Result = applyAllReplacements( - *Sorted, reformat(FmtStyle, *Sorted, Ranges, "input.java")); - EXPECT_TRUE(static_cast<bool>(Result)); - return *Result; - } - - std::string sort(StringRef Code) { return sort(Code, GetCodeRange(Code)); } - - FormatStyle FmtStyle; - -public: - SortImportsTestJava() { - FmtStyle = getGoogleStyle(FormatStyle::LK_Java); - FmtStyle.JavaImportGroups = {"com.test", "org", "com"}; - FmtStyle.SortIncludes = true; - } -}; - -TEST_F(SortImportsTestJava, StaticSplitFromNormal) { - EXPECT_EQ("import static org.b;\n" - "\n" - "import org.a;\n", - sort("import org.a;\n" - "import static org.b;\n")); -} - -TEST_F(SortImportsTestJava, CapitalBeforeLowercase) { - EXPECT_EQ("import org.Test;\n" - "import org.a.Test;\n" - "import org.b;\n", - sort("import org.a.Test;\n" - "import org.Test;\n" - "import org.b;\n")); -} - -TEST_F(SortImportsTestJava, KeepSplitGroupsWithOneNewImport) { - EXPECT_EQ("import static com.test.a;\n" - "\n" - "import static org.a;\n" - "\n" - "import static com.a;\n" - "\n" - "import com.test.b;\n" - "import com.test.c;\n" - "\n" - "import org.b;\n" - "\n" - "import com.b;\n", - sort("import static com.test.a;\n" - "\n" - "import static org.a;\n" - "\n" - "import static com.a;\n" - "\n" - "import com.test.b;\n" - "\n" - "import org.b;\n" - "\n" - "import com.b;\n" - "import com.test.c;\n")); -} - -TEST_F(SortImportsTestJava, SplitGroupsWithNewline) { - EXPECT_EQ("import static com.test.a;\n" - "\n" - "import static org.a;\n" - "\n" - "import static com.a;\n" - "\n" - "import com.test.b;\n" - "\n" - "import org.b;\n" - "\n" - "import com.b;\n", - sort("import static com.test.a;\n" - "import static org.a;\n" - "import static com.a;\n" - "import com.test.b;\n" - "import org.b;\n" - "import com.b;\n")); -} - -TEST_F(SortImportsTestJava, UnspecifiedGroupAfterAllGroups) { - EXPECT_EQ("import com.test.a;\n" - "\n" - "import org.a;\n" - "\n" - "import com.a;\n" - "\n" - "import abc.a;\n" - "import xyz.b;\n", - sort("import com.test.a;\n" - "import com.a;\n" - "import xyz.b;\n" - "import abc.a;\n" - "import org.a;\n")); -} - -TEST_F(SortImportsTestJava, NoSortOutsideRange) { - std::vector<tooling::Range> Ranges = {tooling::Range(27, 15)}; - EXPECT_EQ("import org.b;\n" - "import org.a;\n" - "// comments\n" - "// that do\n" - "// nothing\n", - sort("import org.b;\n" - "import org.a;\n" - "// comments\n" - "// that do\n" - "// nothing\n", - Ranges)); -} - -TEST_F(SortImportsTestJava, SortWhenRangeContainsOneLine) { - std::vector<tooling::Range> Ranges = {tooling::Range(27, 20)}; - EXPECT_EQ("import org.a;\n" - "import org.b;\n" - "\n" - "import com.a;\n" - "// comments\n" - "// that do\n" - "// nothing\n", - sort("import org.b;\n" - "import org.a;\n" - "import com.a;\n" - "// comments\n" - "// that do\n" - "// nothing\n", - Ranges)); -} - -TEST_F(SortImportsTestJava, SortLexicographically) { - EXPECT_EQ("import org.a.*;\n" - "import org.a.a;\n" - "import org.aA;\n" - "import org.aa;\n", - sort("import org.aa;\n" - "import org.a.a;\n" - "import org.a.*;\n" - "import org.aA;\n")); -} - -TEST_F(SortImportsTestJava, StaticInCommentHasNoEffect) { - EXPECT_EQ("import org.a; // static\n" - "import org.b;\n" - "import org.c; // static\n", - sort("import org.a; // static\n" - "import org.c; // static\n" - "import org.b;\n")); -} - -TEST_F(SortImportsTestJava, CommentsWithAffectedImports) { - EXPECT_EQ("import org.a;\n" - "// commentB\n" - "/* commentB\n" - " commentB*/\n" - "import org.b;\n" - "// commentC\n" - "import org.c;\n", - sort("import org.a;\n" - "// commentC\n" - "import org.c;\n" - "// commentB\n" - "/* commentB\n" - " commentB*/\n" - "import org.b;\n")); -} - -TEST_F(SortImportsTestJava, CommentWithUnaffectedImports) { - EXPECT_EQ("import org.a;\n" - "// comment\n" - "import org.b;\n", - sort("import org.a;\n" - "// comment\n" - "import org.b;\n")); -} - -TEST_F(SortImportsTestJava, CommentAfterAffectedImports) { - EXPECT_EQ("import org.a;\n" - "import org.b;\n" - "// comment\n", - sort("import org.b;\n" - "import org.a;\n" - "// comment\n")); -} - -TEST_F(SortImportsTestJava, CommentBeforeAffectedImports) { - EXPECT_EQ("// comment\n" - "import org.a;\n" - "import org.b;\n", - sort("// comment\n" - "import org.b;\n" - "import org.a;\n")); -} - -TEST_F(SortImportsTestJava, FormatTotallyOff) { - EXPECT_EQ("// clang-format off\n" - "import org.b;\n" - "import org.a;\n" - "// clang-format on\n", - sort("// clang-format off\n" - "import org.b;\n" - "import org.a;\n" - "// clang-format on\n")); -} - -TEST_F(SortImportsTestJava, FormatTotallyOn) { - EXPECT_EQ("// clang-format off\n" - "// clang-format on\n" - "import org.a;\n" - "import org.b;\n", - sort("// clang-format off\n" - "// clang-format on\n" - "import org.b;\n" - "import org.a;\n")); -} - -TEST_F(SortImportsTestJava, FormatPariallyOnShouldNotReorder) { - EXPECT_EQ("// clang-format off\n" - "import org.b;\n" - "import org.a;\n" - "// clang-format on\n" - "import org.d;\n" - "import org.c;\n", - sort("// clang-format off\n" - "import org.b;\n" - "import org.a;\n" - "// clang-format on\n" - "import org.d;\n" - "import org.c;\n")); -} - -TEST_F(SortImportsTestJava, DeduplicateImports) { - EXPECT_EQ("import org.a;\n", sort("import org.a;\n" - "import org.a;\n")); -} - -TEST_F(SortImportsTestJava, NoNewlineAtEnd) { - EXPECT_EQ("import org.a;\n" - "import org.b;", - sort("import org.b;\n" - "import org.a;")); -} - -} // end namespace -} // end namespace format -} // end namespace clang diff --git a/unittests/Format/SortIncludesTest.cpp b/unittests/Format/SortIncludesTest.cpp deleted file mode 100644 index dde88003784c0..0000000000000 --- a/unittests/Format/SortIncludesTest.cpp +++ /dev/null @@ -1,596 +0,0 @@ -//===- unittest/Format/SortIncludesTest.cpp - Include sort unit tests -----===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "FormatTestUtils.h" -#include "clang/Format/Format.h" -#include "llvm/Support/Debug.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "format-test" - -namespace clang { -namespace format { -namespace { - -class SortIncludesTest : public ::testing::Test { -protected: - std::vector<tooling::Range> GetCodeRange(StringRef Code) { - return std::vector<tooling::Range>(1, tooling::Range(0, Code.size())); - } - - std::string sort(StringRef Code, std::vector<tooling::Range> Ranges, - StringRef FileName = "input.cc") { - auto Replaces = sortIncludes(FmtStyle, Code, Ranges, FileName); - Ranges = tooling::calculateRangesAfterReplacements(Replaces, Ranges); - auto Sorted = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Sorted)); - auto Result = applyAllReplacements( - *Sorted, reformat(FmtStyle, *Sorted, Ranges, FileName)); - EXPECT_TRUE(static_cast<bool>(Result)); - return *Result; - } - - std::string sort(StringRef Code, StringRef FileName = "input.cpp") { - return sort(Code, GetCodeRange(Code), FileName); - } - - unsigned newCursor(llvm::StringRef Code, unsigned Cursor) { - sortIncludes(FmtStyle, Code, GetCodeRange(Code), "input.cpp", &Cursor); - return Cursor; - } - - FormatStyle FmtStyle = getLLVMStyle(); - tooling::IncludeStyle &Style = FmtStyle.IncludeStyle; -}; - -TEST_F(SortIncludesTest, BasicSorting) { - EXPECT_EQ("#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n", - sort("#include \"a.h\"\n" - "#include \"c.h\"\n" - "#include \"b.h\"\n")); - - EXPECT_EQ("// comment\n" - "#include <a>\n" - "#include <b>\n", - sort("// comment\n" - "#include <b>\n" - "#include <a>\n", - {tooling::Range(25, 1)})); -} - -TEST_F(SortIncludesTest, NoReplacementsForValidIncludes) { - // Identical #includes have led to a failure with an unstable sort. - std::string Code = "#include <a>\n" - "#include <b>\n" - "#include <c>\n" - "#include <d>\n" - "#include <e>\n" - "#include <f>\n"; - EXPECT_TRUE(sortIncludes(FmtStyle, Code, GetCodeRange(Code), "a.cc").empty()); -} - -TEST_F(SortIncludesTest, SortedIncludesInMultipleBlocksAreMerged) { - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Merge; - EXPECT_EQ("#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n", - sort("#include \"a.h\"\n" - "#include \"c.h\"\n" - "\n" - "\n" - "#include \"b.h\"\n")); - - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup; - EXPECT_EQ("#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n", - sort("#include \"a.h\"\n" - "#include \"c.h\"\n" - "\n" - "\n" - "#include \"b.h\"\n")); -} - -TEST_F(SortIncludesTest, SupportClangFormatOff) { - EXPECT_EQ("#include <a>\n" - "#include <b>\n" - "#include <c>\n" - "// clang-format off\n" - "#include <b>\n" - "#include <a>\n" - "#include <c>\n" - "// clang-format on\n", - sort("#include <b>\n" - "#include <a>\n" - "#include <c>\n" - "// clang-format off\n" - "#include <b>\n" - "#include <a>\n" - "#include <c>\n" - "// clang-format on\n")); -} - -TEST_F(SortIncludesTest, IncludeSortingCanBeDisabled) { - FmtStyle.SortIncludes = false; - EXPECT_EQ("#include \"a.h\"\n" - "#include \"c.h\"\n" - "#include \"b.h\"\n", - sort("#include \"a.h\"\n" - "#include \"c.h\"\n" - "#include \"b.h\"\n")); -} - -TEST_F(SortIncludesTest, MixIncludeAndImport) { - EXPECT_EQ("#include \"a.h\"\n" - "#import \"b.h\"\n" - "#include \"c.h\"\n", - sort("#include \"a.h\"\n" - "#include \"c.h\"\n" - "#import \"b.h\"\n")); -} - -TEST_F(SortIncludesTest, FixTrailingComments) { - EXPECT_EQ("#include \"a.h\" // comment\n" - "#include \"bb.h\" // comment\n" - "#include \"ccc.h\"\n", - sort("#include \"a.h\" // comment\n" - "#include \"ccc.h\"\n" - "#include \"bb.h\" // comment\n")); -} - -TEST_F(SortIncludesTest, LeadingWhitespace) { - EXPECT_EQ("#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n", - sort(" #include \"a.h\"\n" - " #include \"c.h\"\n" - " #include \"b.h\"\n")); - EXPECT_EQ("#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n", - sort("# include \"a.h\"\n" - "# include \"c.h\"\n" - "# include \"b.h\"\n")); -} - -TEST_F(SortIncludesTest, GreaterInComment) { - EXPECT_EQ("#include \"a.h\"\n" - "#include \"b.h\" // >\n" - "#include \"c.h\"\n", - sort("#include \"a.h\"\n" - "#include \"c.h\"\n" - "#include \"b.h\" // >\n")); -} - -TEST_F(SortIncludesTest, SortsLocallyInEachBlock) { - EXPECT_EQ("#include \"a.h\"\n" - "#include \"c.h\"\n" - "\n" - "#include \"b.h\"\n", - sort("#include \"a.h\"\n" - "#include \"c.h\"\n" - "\n" - "#include \"b.h\"\n")); -} - -TEST_F(SortIncludesTest, SortsAllBlocksWhenMerging) { - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Merge; - EXPECT_EQ("#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n", - sort("#include \"a.h\"\n" - "#include \"c.h\"\n" - "\n" - "#include \"b.h\"\n")); -} - -TEST_F(SortIncludesTest, CommentsAlwaysSeparateGroups) { - EXPECT_EQ("#include \"a.h\"\n" - "#include \"c.h\"\n" - "// comment\n" - "#include \"b.h\"\n", - sort("#include \"c.h\"\n" - "#include \"a.h\"\n" - "// comment\n" - "#include \"b.h\"\n")); - - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Merge; - EXPECT_EQ("#include \"a.h\"\n" - "#include \"c.h\"\n" - "// comment\n" - "#include \"b.h\"\n", - sort("#include \"c.h\"\n" - "#include \"a.h\"\n" - "// comment\n" - "#include \"b.h\"\n")); - - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup; - EXPECT_EQ("#include \"a.h\"\n" - "#include \"c.h\"\n" - "// comment\n" - "#include \"b.h\"\n", - sort("#include \"c.h\"\n" - "#include \"a.h\"\n" - "// comment\n" - "#include \"b.h\"\n")); -} - -TEST_F(SortIncludesTest, HandlesAngledIncludesAsSeparateBlocks) { - EXPECT_EQ("#include \"a.h\"\n" - "#include \"c.h\"\n" - "#include <b.h>\n" - "#include <d.h>\n", - sort("#include <d.h>\n" - "#include <b.h>\n" - "#include \"c.h\"\n" - "#include \"a.h\"\n")); - - FmtStyle = getGoogleStyle(FormatStyle::LK_Cpp); - EXPECT_EQ("#include <b.h>\n" - "#include <d.h>\n" - "#include \"a.h\"\n" - "#include \"c.h\"\n", - sort("#include <d.h>\n" - "#include <b.h>\n" - "#include \"c.h\"\n" - "#include \"a.h\"\n")); -} - -TEST_F(SortIncludesTest, RegroupsAngledIncludesInSeparateBlocks) { - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup; - EXPECT_EQ("#include \"a.h\"\n" - "#include \"c.h\"\n" - "\n" - "#include <b.h>\n" - "#include <d.h>\n", - sort("#include <d.h>\n" - "#include <b.h>\n" - "#include \"c.h\"\n" - "#include \"a.h\"\n")); -} - -TEST_F(SortIncludesTest, HandlesMultilineIncludes) { - EXPECT_EQ("#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n", - sort("#include \"a.h\"\n" - "#include \\\n" - "\"c.h\"\n" - "#include \"b.h\"\n")); -} - -TEST_F(SortIncludesTest, LeavesMainHeaderFirst) { - Style.IncludeIsMainRegex = "([-_](test|unittest))?$"; - EXPECT_EQ("#include \"llvm/a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n", - sort("#include \"llvm/a.h\"\n" - "#include \"c.h\"\n" - "#include \"b.h\"\n", - "a.cc")); - EXPECT_EQ("#include \"llvm/a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n", - sort("#include \"llvm/a.h\"\n" - "#include \"c.h\"\n" - "#include \"b.h\"\n", - "a_test.cc")); - EXPECT_EQ("#include \"llvm/input.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n", - sort("#include \"llvm/input.h\"\n" - "#include \"c.h\"\n" - "#include \"b.h\"\n", - "input.mm")); - - // Don't allow prefixes. - EXPECT_EQ("#include \"b.h\"\n" - "#include \"c.h\"\n" - "#include \"llvm/not_a.h\"\n", - sort("#include \"llvm/not_a.h\"\n" - "#include \"c.h\"\n" - "#include \"b.h\"\n", - "a.cc")); - - // Don't do this for _main and other suffixes. - EXPECT_EQ("#include \"b.h\"\n" - "#include \"c.h\"\n" - "#include \"llvm/a.h\"\n", - sort("#include \"llvm/a.h\"\n" - "#include \"c.h\"\n" - "#include \"b.h\"\n", - "a_main.cc")); - - // Don't do this in headers. - EXPECT_EQ("#include \"b.h\"\n" - "#include \"c.h\"\n" - "#include \"llvm/a.h\"\n", - sort("#include \"llvm/a.h\"\n" - "#include \"c.h\"\n" - "#include \"b.h\"\n", - "a.h")); - - // Only do this in the first #include block. - EXPECT_EQ("#include <a>\n" - "\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n" - "#include \"llvm/a.h\"\n", - sort("#include <a>\n" - "\n" - "#include \"llvm/a.h\"\n" - "#include \"c.h\"\n" - "#include \"b.h\"\n", - "a.cc")); - - // Only recognize the first #include with a matching basename as main include. - EXPECT_EQ("#include \"a.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n" - "#include \"llvm/a.h\"\n", - sort("#include \"b.h\"\n" - "#include \"a.h\"\n" - "#include \"c.h\"\n" - "#include \"llvm/a.h\"\n", - "a.cc")); -} - -TEST_F(SortIncludesTest, RecognizeMainHeaderInAllGroups) { - Style.IncludeIsMainRegex = "([-_](test|unittest))?$"; - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Merge; - - EXPECT_EQ("#include \"c.h\"\n" - "#include \"a.h\"\n" - "#include \"b.h\"\n", - sort("#include \"b.h\"\n" - "\n" - "#include \"a.h\"\n" - "#include \"c.h\"\n", - "c.cc")); -} - -TEST_F(SortIncludesTest, MainHeaderIsSeparatedWhenRegroupping) { - Style.IncludeIsMainRegex = "([-_](test|unittest))?$"; - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup; - - EXPECT_EQ("#include \"a.h\"\n" - "\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n", - sort("#include \"b.h\"\n" - "\n" - "#include \"a.h\"\n" - "#include \"c.h\"\n", - "a.cc")); -} - -TEST_F(SortIncludesTest, SupportCaseInsensitiveMatching) { - // Setup an regex for main includes so we can cover those as well. - Style.IncludeIsMainRegex = "([-_](test|unittest))?$"; - - // Ensure both main header detection and grouping work in a case insensitive - // manner. - EXPECT_EQ("#include \"llvm/A.h\"\n" - "#include \"b.h\"\n" - "#include \"c.h\"\n" - "#include \"LLVM/z.h\"\n" - "#include \"llvm/X.h\"\n" - "#include \"GTest/GTest.h\"\n" - "#include \"gmock/gmock.h\"\n", - sort("#include \"c.h\"\n" - "#include \"b.h\"\n" - "#include \"GTest/GTest.h\"\n" - "#include \"llvm/A.h\"\n" - "#include \"gmock/gmock.h\"\n" - "#include \"llvm/X.h\"\n" - "#include \"LLVM/z.h\"\n", - "a_TEST.cc")); -} - -TEST_F(SortIncludesTest, NegativePriorities) { - Style.IncludeCategories = {{".*important_os_header.*", -1}, {".*", 1}}; - EXPECT_EQ("#include \"important_os_header.h\"\n" - "#include \"c_main.h\"\n" - "#include \"a_other.h\"\n", - sort("#include \"c_main.h\"\n" - "#include \"a_other.h\"\n" - "#include \"important_os_header.h\"\n", - "c_main.cc")); - - // check stable when re-run - EXPECT_EQ("#include \"important_os_header.h\"\n" - "#include \"c_main.h\"\n" - "#include \"a_other.h\"\n", - sort("#include \"important_os_header.h\"\n" - "#include \"c_main.h\"\n" - "#include \"a_other.h\"\n", - "c_main.cc")); -} - -TEST_F(SortIncludesTest, PriorityGroupsAreSeparatedWhenRegroupping) { - Style.IncludeCategories = {{".*important_os_header.*", -1}, {".*", 1}}; - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup; - - EXPECT_EQ("#include \"important_os_header.h\"\n" - "\n" - "#include \"c_main.h\"\n" - "\n" - "#include \"a_other.h\"\n", - sort("#include \"c_main.h\"\n" - "#include \"a_other.h\"\n" - "#include \"important_os_header.h\"\n", - "c_main.cc")); - - // check stable when re-run - EXPECT_EQ("#include \"important_os_header.h\"\n" - "\n" - "#include \"c_main.h\"\n" - "\n" - "#include \"a_other.h\"\n", - sort("#include \"important_os_header.h\"\n" - "\n" - "#include \"c_main.h\"\n" - "\n" - "#include \"a_other.h\"\n", - "c_main.cc")); -} - -TEST_F(SortIncludesTest, CalculatesCorrectCursorPosition) { - std::string Code = "#include <ccc>\n" // Start of line: 0 - "#include <bbbbbb>\n" // Start of line: 15 - "#include <a>\n"; // Start of line: 33 - EXPECT_EQ(31u, newCursor(Code, 0)); - EXPECT_EQ(13u, newCursor(Code, 15)); - EXPECT_EQ(0u, newCursor(Code, 33)); - - EXPECT_EQ(41u, newCursor(Code, 10)); - EXPECT_EQ(23u, newCursor(Code, 25)); - EXPECT_EQ(10u, newCursor(Code, 43)); -} - -TEST_F(SortIncludesTest, DeduplicateIncludes) { - EXPECT_EQ("#include <a>\n" - "#include <b>\n" - "#include <c>\n", - sort("#include <a>\n" - "#include <b>\n" - "#include <b>\n" - "#include <b>\n" - "#include <b>\n" - "#include <c>\n")); - - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Merge; - EXPECT_EQ("#include <a>\n" - "#include <b>\n" - "#include <c>\n", - sort("#include <a>\n" - "#include <b>\n" - "\n" - "#include <b>\n" - "\n" - "#include <b>\n" - "#include <c>\n")); - - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup; - EXPECT_EQ("#include <a>\n" - "#include <b>\n" - "#include <c>\n", - sort("#include <a>\n" - "#include <b>\n" - "\n" - "#include <b>\n" - "\n" - "#include <b>\n" - "#include <c>\n")); -} - -TEST_F(SortIncludesTest, SortAndDeduplicateIncludes) { - EXPECT_EQ("#include <a>\n" - "#include <b>\n" - "#include <c>\n", - sort("#include <b>\n" - "#include <a>\n" - "#include <b>\n" - "#include <b>\n" - "#include <c>\n" - "#include <b>\n")); - - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Merge; - EXPECT_EQ("#include <a>\n" - "#include <b>\n" - "#include <c>\n", - sort("#include <b>\n" - "#include <a>\n" - "\n" - "#include <b>\n" - "\n" - "#include <c>\n" - "#include <b>\n")); - - Style.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup; - EXPECT_EQ("#include <a>\n" - "#include <b>\n" - "#include <c>\n", - sort("#include <b>\n" - "#include <a>\n" - "\n" - "#include <b>\n" - "\n" - "#include <c>\n" - "#include <b>\n")); -} - -TEST_F(SortIncludesTest, CalculatesCorrectCursorPositionAfterDeduplicate) { - std::string Code = "#include <b>\n" // Start of line: 0 - "#include <a>\n" // Start of line: 13 - "#include <b>\n" // Start of line: 26 - "#include <b>\n" // Start of line: 39 - "#include <c>\n" // Start of line: 52 - "#include <b>\n"; // Start of line: 65 - std::string Expected = "#include <a>\n" // Start of line: 0 - "#include <b>\n" // Start of line: 13 - "#include <c>\n"; // Start of line: 26 - EXPECT_EQ(Expected, sort(Code)); - // Cursor on 'i' in "#include <a>". - EXPECT_EQ(1u, newCursor(Code, 14)); - // Cursor on 'b' in "#include <b>". - EXPECT_EQ(23u, newCursor(Code, 10)); - EXPECT_EQ(23u, newCursor(Code, 36)); - EXPECT_EQ(23u, newCursor(Code, 49)); - EXPECT_EQ(23u, newCursor(Code, 36)); - EXPECT_EQ(23u, newCursor(Code, 75)); - // Cursor on '#' in "#include <c>". - EXPECT_EQ(26u, newCursor(Code, 52)); -} - -TEST_F(SortIncludesTest, DeduplicateLocallyInEachBlock) { - EXPECT_EQ("#include <a>\n" - "#include <b>\n" - "\n" - "#include <b>\n" - "#include <c>\n", - sort("#include <a>\n" - "#include <b>\n" - "\n" - "#include <c>\n" - "#include <b>\n" - "#include <b>\n")); -} - -TEST_F(SortIncludesTest, ValidAffactedRangesAfterDeduplicatingIncludes) { - std::string Code = "#include <a>\n" - "#include <b>\n" - "#include <a>\n" - "#include <a>\n" - "\n" - " int x ;"; - std::vector<tooling::Range> Ranges = {tooling::Range(0, 52)}; - auto Replaces = sortIncludes(FmtStyle, Code, Ranges, "input.cpp"); - Ranges = tooling::calculateRangesAfterReplacements(Replaces, Ranges); - EXPECT_EQ(1u, Ranges.size()); - EXPECT_EQ(0u, Ranges[0].getOffset()); - EXPECT_EQ(26u, Ranges[0].getLength()); -} - -TEST_F(SortIncludesTest, DoNotSortLikelyXml) { - EXPECT_EQ("<!--;\n" - "#include <b>\n" - "#include <a>\n" - "-->", - sort("<!--;\n" - "#include <b>\n" - "#include <a>\n" - "-->")); -} - -} // end namespace -} // end namespace format -} // end namespace clang diff --git a/unittests/Format/UsingDeclarationsSorterTest.cpp b/unittests/Format/UsingDeclarationsSorterTest.cpp deleted file mode 100644 index 2ba6520e057fb..0000000000000 --- a/unittests/Format/UsingDeclarationsSorterTest.cpp +++ /dev/null @@ -1,375 +0,0 @@ -//===- UsingDeclarationsSorterTest.cpp - Formatting unit tests ------------===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "clang/Format/Format.h" - -#include "llvm/Support/Debug.h" -#include "gtest/gtest.h" - -#define DEBUG_TYPE "using-declarations-sorter-test" - -namespace clang { -namespace format { -namespace { - -class UsingDeclarationsSorterTest : public ::testing::Test { -protected: - std::string sortUsingDeclarations(llvm::StringRef Code, - const std::vector<tooling::Range> &Ranges, - const FormatStyle &Style = getLLVMStyle()) { - LLVM_DEBUG(llvm::errs() << "---\n"); - LLVM_DEBUG(llvm::errs() << Code << "\n\n"); - tooling::Replacements Replaces = - clang::format::sortUsingDeclarations(Style, Code, Ranges, "<stdin>"); - auto Result = applyAllReplacements(Code, Replaces); - EXPECT_TRUE(static_cast<bool>(Result)); - LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); - return *Result; - } - - std::string sortUsingDeclarations(llvm::StringRef Code, - const FormatStyle &Style = getLLVMStyle()) { - return sortUsingDeclarations(Code, - /*Ranges=*/{1, tooling::Range(0, Code.size())}, - Style); - } -}; - -TEST_F(UsingDeclarationsSorterTest, SwapsTwoConsecutiveUsingDeclarations) { - EXPECT_EQ("using a;\n" - "using b;", - sortUsingDeclarations("using a;\n" - "using b;")); - EXPECT_EQ("using a;\n" - "using aa;", - sortUsingDeclarations("using aa;\n" - "using a;")); - EXPECT_EQ("using a;\n" - "using ::a;", - sortUsingDeclarations("using a;\n" - "using ::a;")); - - EXPECT_EQ("using a::bcd;\n" - "using a::cd;", - sortUsingDeclarations("using a::cd;\n" - "using a::bcd;")); - - EXPECT_EQ("using a;\n" - "using a::a;", - sortUsingDeclarations("using a::a;\n" - "using a;")); - - EXPECT_EQ("using a::ba::aa;\n" - "using a::bb::ccc;", - sortUsingDeclarations("using a::bb::ccc;\n" - "using a::ba::aa;")); - - EXPECT_EQ("using a;\n" - "using typename a;", - sortUsingDeclarations("using typename a;\n" - "using a;")); - - EXPECT_EQ("using typename z;\n" - "using typenamea;", - sortUsingDeclarations("using typenamea;\n" - "using typename z;")); - - EXPECT_EQ("using a, b;\n" - "using aa;", - sortUsingDeclarations("using aa;\n" - "using a, b;")); -} - -TEST_F(UsingDeclarationsSorterTest, UsingDeclarationOrder) { - EXPECT_EQ("using A;\n" - "using a;", - sortUsingDeclarations("using A;\n" - "using a;")); - EXPECT_EQ("using a;\n" - "using A;", - sortUsingDeclarations("using a;\n" - "using A;")); - EXPECT_EQ("using a;\n" - "using B;", - sortUsingDeclarations("using B;\n" - "using a;")); - - // Ignores leading '::'. - EXPECT_EQ("using ::a;\n" - "using A;", - sortUsingDeclarations("using ::a;\n" - "using A;")); - - EXPECT_EQ("using ::A;\n" - "using a;", - sortUsingDeclarations("using ::A;\n" - "using a;")); - - // Sorts '_' before 'a' and 'A'. - EXPECT_EQ("using _;\n" - "using A;", - sortUsingDeclarations("using A;\n" - "using _;")); - EXPECT_EQ("using _;\n" - "using a;", - sortUsingDeclarations("using a;\n" - "using _;")); - EXPECT_EQ("using a::_;\n" - "using a::a;", - sortUsingDeclarations("using a::a;\n" - "using a::_;")); - - // Sorts non-namespace names before namespace names at the same level. - EXPECT_EQ("using ::testing::_;\n" - "using ::testing::Aardvark;\n" - "using ::testing::kMax;\n" - "using ::testing::Xylophone;\n" - "using ::testing::apple::Honeycrisp;\n" - "using ::testing::zebra::Stripes;", - sortUsingDeclarations("using ::testing::Aardvark;\n" - "using ::testing::Xylophone;\n" - "using ::testing::kMax;\n" - "using ::testing::_;\n" - "using ::testing::apple::Honeycrisp;\n" - "using ::testing::zebra::Stripes;")); -} - -TEST_F(UsingDeclarationsSorterTest, SortsStably) { - EXPECT_EQ("using a;\n" - "using A;\n" - "using a;\n" - "using A;\n" - "using a;\n" - "using A;\n" - "using a;\n" - "using B;\n" - "using b;\n" - "using B;\n" - "using b;\n" - "using B;\n" - "using b;", - sortUsingDeclarations("using a;\n" - "using B;\n" - "using a;\n" - "using b;\n" - "using A;\n" - "using a;\n" - "using b;\n" - "using B;\n" - "using b;\n" - "using A;\n" - "using a;\n" - "using b;\n" - "using b;\n" - "using B;\n" - "using b;\n" - "using A;\n" - "using a;")); -} - -TEST_F(UsingDeclarationsSorterTest, SortsMultipleTopLevelDeclarations) { - EXPECT_EQ("using a;\n" - "using b;\n" - "using c;\n" - "using d;\n" - "using e;", - sortUsingDeclarations("using d;\n" - "using b;\n" - "using e;\n" - "using a;\n" - "using c;")); - - EXPECT_EQ("#include <iostream>\n" - "using std::cin;\n" - "using std::cout;\n" - "using ::std::endl;\n" - "int main();", - sortUsingDeclarations("#include <iostream>\n" - "using std::cout;\n" - "using ::std::endl;\n" - "using std::cin;\n" - "int main();")); -} - -TEST_F(UsingDeclarationsSorterTest, BreaksOnEmptyLines) { - EXPECT_EQ("using b;\n" - "using c;\n" - "\n" - "using a;\n" - "using d;", - sortUsingDeclarations("using c;\n" - "using b;\n" - "\n" - "using d;\n" - "using a;")); -} - -TEST_F(UsingDeclarationsSorterTest, BreaksOnUsingNamespace) { - EXPECT_EQ("using b;\n" - "using namespace std;\n" - "using a;", - sortUsingDeclarations("using b;\n" - "using namespace std;\n" - "using a;")); -} - -TEST_F(UsingDeclarationsSorterTest, KeepsUsingDeclarationsInPPDirectives) { - EXPECT_EQ("#define A \\\n" - "using b;\\\n" - "using a;", - sortUsingDeclarations("#define A \\\n" - "using b;\\\n" - "using a;")); -} - -TEST_F(UsingDeclarationsSorterTest, KeepsTypeAliases) { - auto Code = "struct C { struct B { struct A; }; };\n" - "using B = C::B;\n" - "using A = B::A;"; - EXPECT_EQ(Code, sortUsingDeclarations(Code)); -} - -TEST_F(UsingDeclarationsSorterTest, MovesTrailingCommentsWithDeclarations) { - EXPECT_EQ("using a; // line a1\n" - "using b; /* line b1\n" - " * line b2\n" - " * line b3 */\n" - "using c; // line c1\n" - " // line c2", - sortUsingDeclarations("using c; // line c1\n" - " // line c2\n" - "using b; /* line b1\n" - " * line b2\n" - " * line b3 */\n" - "using a; // line a1")); -} - -TEST_F(UsingDeclarationsSorterTest, SortsInStructScope) { - EXPECT_EQ("struct pt3 : pt2 {\n" - " using pt2::x;\n" - " using pt2::y;\n" - " float z;\n" - "};", - sortUsingDeclarations("struct pt3 : pt2 {\n" - " using pt2::y;\n" - " using pt2::x;\n" - " float z;\n" - "};")); -} - -TEST_F(UsingDeclarationsSorterTest, KeepsOperators) { - EXPECT_EQ("using a::operator();\n" - "using a::operator-;\n" - "using a::operator+;", - sortUsingDeclarations("using a::operator();\n" - "using a::operator-;\n" - "using a::operator+;")); -} - -TEST_F(UsingDeclarationsSorterTest, SortsUsingDeclarationsInsideNamespaces) { - EXPECT_EQ("namespace A {\n" - "struct B;\n" - "struct C;\n" - "}\n" - "namespace X {\n" - "using A::B;\n" - "using A::C;\n" - "}", - sortUsingDeclarations("namespace A {\n" - "struct B;\n" - "struct C;\n" - "}\n" - "namespace X {\n" - "using A::C;\n" - "using A::B;\n" - "}")); -} - -TEST_F(UsingDeclarationsSorterTest, SupportsClangFormatOff) { - EXPECT_EQ("// clang-format off\n" - "using b;\n" - "using a;\n" - "// clang-format on\n" - "using c;\n" - "using d;", - sortUsingDeclarations("// clang-format off\n" - "using b;\n" - "using a;\n" - "// clang-format on\n" - "using d;\n" - "using c;")); -} - -TEST_F(UsingDeclarationsSorterTest, SortsPartialRangeOfUsingDeclarations) { - // Sorts the whole block of using declarations surrounding the range. - EXPECT_EQ("using a;\n" - "using b;\n" - "using c;", - sortUsingDeclarations("using b;\n" - "using c;\n" // starts at offset 10 - "using a;", - {tooling::Range(10, 15)})); - EXPECT_EQ("using a;\n" - "using b;\n" - "using c;\n" - "using A = b;", - sortUsingDeclarations("using b;\n" - "using c;\n" // starts at offset 10 - "using a;\n" - "using A = b;", - {tooling::Range(10, 15)})); - - EXPECT_EQ("using d;\n" - "using c;\n" - "\n" - "using a;\n" - "using b;\n" - "\n" - "using f;\n" - "using e;", - sortUsingDeclarations("using d;\n" - "using c;\n" - "\n" - "using b;\n" // starts at offset 19 - "using a;\n" - "\n" - "using f;\n" - "using e;", - {tooling::Range(19, 1)})); -} - -TEST_F(UsingDeclarationsSorterTest, SortsUsingDeclarationsWithLeadingkComments) { - EXPECT_EQ("/* comment */ using a;\n" - "/* comment */ using b;", - sortUsingDeclarations("/* comment */ using b;\n" - "/* comment */ using a;")); -} - -TEST_F(UsingDeclarationsSorterTest, DeduplicatesUsingDeclarations) { - EXPECT_EQ("using a;\n" - "using b;\n" - "using c;\n" - "\n" - "using a;\n" - "using e;", - sortUsingDeclarations("using c;\n" - "using a;\n" - "using b;\n" - "using a;\n" - "using b;\n" - "\n" - "using e;\n" - "using a;\n" - "using e;")); - -} - -} // end namespace -} // end namespace format -} // end namespace clang |