summaryrefslogtreecommitdiff
path: root/lib/libc/rpc/rpcb_clnt.c
Commit message (Collapse)AuthorAgeFilesLines
* General further adoption of SPDX licensing ID tags.Pedro F. Giffuni2017-11-201-0/+2
| | | | | | | | | | | | | | | | | Mainly focus on files that use BSD 3-Clause license. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. Special thanks to Wind River for providing access to "The Duke of Highlander" tool: an older (2014) run over FreeBSD tree was useful as a starting point. Notes: svn path=/head/; revision=326025
* Fix use-after-free introduced in r300388.Xin LI2017-06-221-1/+2
| | | | | | | | | | | | | | | | In r300388, endnetconfig() was called on nc_handle which would release the associated netconfig structure, which means tmpnconf->nc_netid would be a use-after-free. Solve this by doing endnetconfig() in return paths instead. Reported by: jemalloc via kevlo Reviewed by: cem, ngie (earlier version) MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D11288 Notes: svn path=/head/; revision=320216
* Fix the rpcb_getaddr() definition to match its declaration.Kevin Lo2016-06-091-1/+1
| | | | | | | Submitted by: Sebastian Huber <sebastian dot huber at embedded-brains dot de> Notes: svn path=/head/; revision=301734
* Call endnetconfig on nc_handle sooner to avoid leaking nc_handle if tmpnconfEnji Cooper2016-05-221-1/+1
| | | | | | | | | | | | | | | was NULL This would theoretically happen if the netconfig protocol family and protocol semantics were never matched. MFC after: 2 weeks Reported by: Coverity CID: 978179 Sponsored by: EMC / Isilon Storage Division Notes: svn path=/head/; revision=300388
* Similar to r293704, fix theoretical leak of netconfig(3) resources inEnji Cooper2016-01-111-2/+2
| | | | | | | | | | | | | | __rpcbind_is_up(..) if getnetconfig(3) is partly successful in allocating resources, but not completely successful by moving the endnetconfig(3) call up before we return from the function if nconf == NULL. MFC after: 1 week Reported by: Coverity Submitted by: Miles Ohlrich <miles.ohlrich@isilon.com> Sponsored by: EMC / Isilon Storage Division Notes: svn path=/head/; revision=293705
* Remove unnecessary `if (x)` tests before calling `free(x)`; free(3)Enji Cooper2015-11-021-16/+8
| | | | | | | | | | already employs this check MFC after: 2 weeks Sponsored by: EMC / Isilon Storage Division Notes: svn path=/head/; revision=290253
* Use ANSI C prototypes. Eliminates -Wold-style-definition warnings.Craig Rodrigues2015-09-221-17/+16
| | | | Notes: svn path=/head/; revision=288113
* Use ANSI C prototypes.Craig Rodrigues2015-09-011-1/+1
| | | | | | | Eliminates gcc 4.9 warnings. Notes: svn path=/head/; revision=287350
* Use ANSI C prototypes.Craig Rodrigues2015-09-011-48/+20
| | | | | | | Eliminates gcc 4.9 warnings. Notes: svn path=/head/; revision=287341
* Replace Sun Industry Standards Source License for Sun RPC code with aHiroki Sato2013-11-251-47/+24
| | | | | | | | | 3-clause BSD license as specified by Oracle America, Inc. in 2010. This license change was approved by Wim Coekaerts, Senior Vice President, Linux and Virtualization at Oracle Corporation. Notes: svn path=/head/; revision=258581
* Complete revert of r239963:Pedro F. Giffuni2012-09-271-7/+0
| | | | | | | | | | | | | | | | | | The attempt to merge changes from the linux libtirpc caused rpc.lockd to exit after startup under unclear conditions. After many hours of selective experiments and inconsistent results the conclusion is that it's better to just revert everything and restart in a future time with a much smaller subset of the changes. ____ MFC after: 3 days Reported by: David Wolfskill Tested by: David Wolfskill Notes: svn path=/head/; revision=241007
* Bring some changes from Bull's NFSv4 libtirpc implementation.Pedro F. Giffuni2012-09-011-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We especifically ignored the glibc compatibility changes but this should help interaction with Solaris and Linux. ____ Fixed infinite loop in svc_run() author Steve Dickson Tue, 10 Jun 2008 12:35:52 -0500 (13:35 -0400) Fixed infinite loop in svc_run() ____ __rpc_taddr2uaddr_af() assumes the netbuf to always have a non-zero data. This is a bad assumption and can lead to a seg-fault. This patch adds a check for zero length and returns NULL when found. author Steve Dickson Mon, 27 Oct 2008 11:46:54 -0500 (12:46 -0400) ____ Changed clnt_spcreateerror() to return clearer and more concise error messages. author Steve Dickson Thu, 20 Nov 2008 08:55:31 -0500 (08:55 -0500) ____ Converted all uid and gid variables of the type uid_t and gid_t. author Steve Dickson Wed, 28 Jan 2009 12:44:46 -0500 (12:44 -0500) ____ libtirpc: set r_netid and r_owner in __rpcb_findaddr_timed These fields in the rpcbind GETADDR call are being passed uninitialized to CLNT_CALL. In the case of x86_64 at least, this usually leads to a segfault. On x86, it sometimes causes segfaults and other times causes garbage to be sent on the wire. rpcbind generally ignores the r_owner field for calls that come in over the wire, so it really doesn't matter what we send in that slot. We just need to send something. The reference implementation from Sun seems to send a blank string. Have ours follow suit. author Jeff Layton Fri, 13 Mar 2009 11:44:16 -0500 (12:44 -0400) ____ libtirpc: be sure to free cl_netid and cl_tp When creating a client with clnt_tli_create, it uses strdup to copy strings for these fields if nconf is passed in. clnt_dg_destroy frees these strings already. Make sure clnt_vc_destroy frees them in the same way. author Jeff Layton Fri, 13 Mar 2009 11:47:36 -0500 (12:47 -0400) Obtained from: Bull GNU/Linux NFSv4 Project MFC after: 3 weeks Notes: svn path=/head/; revision=239963
* Fix some improper handling of malloc failuresMatteo Riondato2007-09-201-4/+9
| | | | | | | | | | PR: bin/83344 , kern/81987 Reviewed by: alfred Approved by: re (kensmith) MFC after: 1 week Notes: svn path=/head/; revision=172259
* Sync with NetBSD rev. 1.20 + 1.21Martin Blapp2006-09-091-6/+11
| | | | | | | | | | Coverity CID 2284: Fix multiple memory leaks. Coverity CID 710: Remove unreachable code. MFC after: 1 month Notes: svn path=/head/; revision=162193
* Staticize a couple of functions.Daniel Eischen2006-02-271-3/+2
| | | | | | | | | Remove a few unused locks. Remove locks from application namespace. Notes: svn path=/head/; revision=156090
* Try to bring some sanity to the SCM ID's.David E. O'Brien2004-10-161-1/+1
| | | | | | | | | + spell LIBC_SCCS consistently + enable builds with LIBC_SCCS defined to not syntax error + minor SCM reformatting to try to have some consistency Notes: svn path=/head/; revision=136581
* Don't compare NULL against a character.Martin Blapp2003-10-291-3/+3
| | | | | | | Obtained from: NetBSD Notes: svn path=/head/; revision=121653
* Add missing __rpc_fixup_addr. This is needed to makeMartin Blapp2003-01-271-0/+3
| | | | | | | | | | | | mount_nfs -T work for scoped addresses. NetBSD Rev 1.11 Reviewed by: phk Obtained from: NetBSD Notes: svn path=/head/; revision=109952
* Revert part of revision 1.10, as it broke portmap lookups for IPv4Ian Dowse2002-07-261-9/+3
| | | | | | | | | | | | | | | | TCP clients. The problem was that a struct netconfig returned by getnetconfigent() was being treated as a handle for __rpc_getconf(), which certainly isn't right. The tirpc-99 code uses __rpc_setconf("udp")/__rpc_getconf() to find the IPv4 udp netconfig, but our implementation of these functions seem happy to return IPv6 entries, so we can't use them. By reverting to the old version, we are hard-coding the name of the udp4 netid. Tracked down by: Bakul Shah <bakul@bitblocks.com> Notes: svn path=/head/; revision=100701
* Add functions allowing for the user to specify a timeout for rpc functions.Alfred Perlstein2002-07-111-37/+112
| | | | | | | | | Update copyrights to reflect where this code was lifted from. (tirpc '99) Submitted by: mbr Notes: svn path=/head/; revision=99775
* Fix the style of the SCM ID's.David E. O'Brien2002-03-221-3/+2
| | | | | | | I believe have made all of libc .c's as consistent as possible. Notes: svn path=/head/; revision=92990
* Remove multi-line __P() usage.David E. O'Brien2002-03-221-6/+3
| | | | Notes: svn path=/head/; revision=92941
* Remove __P() usage.David E. O'Brien2002-03-211-4/+4
| | | | Notes: svn path=/head/; revision=92905
* Fix two file descriptor leaks in the internal function local_rpcb()Ian Dowse2002-02-161-1/+8
| | | | | | | | | | | that is used by a number of rpcbind-related library functions. Also fix a rpc client leak in rpcb_set(). Submitted by: mbr Obtained from: NetBSD Notes: svn path=/head/; revision=90735
* Do not call addrinfo on local transport adresses, if returning aAlfred Perlstein2002-02-051-5/+25
| | | | | | | | | | | | server handle (for reuse or whatever). We just return now a handle connected to the local rpcbind. Do not try to call checkcache, if host = NULL; Submitted by: mbr Notes: svn path=/head/; revision=90269
* In getclnthandle(), if the address is found in the cache we needIan Dowse2001-08-021-2/+5
| | | | | | | | | | | | | to strdup() the address string before returning it via *targaddr because the caller will free the string. Change the comment at the top of getclnthandle() to clarify that the caller is responsible for freeing *targaddr. Noticed by: sobomax Notes: svn path=/head/; revision=81069
* Fix a memory leak in __rpcb_findaddr(), avoid compiler warnings.Ian Dowse2001-07-141-1/+4
| | | | | | | Submitted by: Martin Blapp <mb@imp.ch> Notes: svn path=/head/; revision=79726
* Move the #includes of reentrant.h to after the `#include "namespace.h"',Ian Dowse2001-04-021-1/+1
| | | | | | | | | | | so that the underscored versions of the pthread functions get declared. This removes around 300 lines of 'implicit declaration of XXX' warnings from the output of a libc build with -Wall. Reviewed by: Martin Blapp <mb@imp.ch>, alfred Notes: svn path=/head/; revision=75094
* Bring in a hybrid of SunSoft's transport-independent RPC (TI-RPC) andAlfred Perlstein2001-03-191-0/+1253
associated changes that had to happen to make this possible as well as bugs fixed along the way. Bring in required TLI library routines to support this. Since we don't support TLI we've essentially copied what NetBSD has done, adding a thin layer to emulate direct the TLI calls into BSD socket calls. This is mostly from Sun's tirpc release that was made in 1994, however some fixes were backported from the 1999 release (supposedly only made available after this porting effort was underway). The submitter has agreed to continue on and bring us up to the 1999 release. Several key features are introduced with this update: Client calls are thread safe. (1999 code has server side thread safe) Updated, a more modern interface. Many userland updates were done to bring the code up to par with the recent RPC API. There is an update to the pthreads library, a function pthread_main_np() was added to emulate a function of Sun's threads library. While we're at it, bring in NetBSD's lockd, it's been far too long of a wait. New rpcbind(8) replaces portmap(8) (supporting communication over an authenticated Unix-domain socket, and by default only allowing set and unset requests over that channel). It's much more secure than the old portmapper. Umount(8), mountd(8), mount_nfs(8), nfsd(8) have also been upgraded to support TI-RPC and to support IPV6. Umount(8) is also fixed to unmount pathnames longer than 80 chars, which are currently truncated by the Kernel statfs structure. Submitted by: Martin Blapp <mb@imp.ch> Manpage review: ru Secure RPC implemented by: wpaul Notes: svn path=/head/; revision=74462