From fe815331bb40604ba31312acf7e4619674631777 Mon Sep 17 00:00:00 2001
From: Kyle Evans <kevans@FreeBSD.org>
Date: Fri, 18 Sep 2020 17:17:46 +0000
Subject: build: provide a default WARNS for all in-tree builds

The current default is provided in various Makefile.inc in some top-level
directories and covers a good portion of the tree, but doesn't cover parts
of the build a little deeper (e.g. libcasper).

Provide a default in src.sys.mk and set WARNS to it in bsd.sys.mk if that
variable is defined. This lets us relatively cleanly provide a default WARNS
no matter where you're building in the src tree without breaking things
outside of the tree.

Crunchgen has been updated as a bootstrap tool to work on this change
because it needs r365605 at a minimum to succeed. The cleanup necessary to
successfully walk over this change on WITHOUT_CLEAN builds has been added.

There is a supplemental project to this to list all of the warnings that are
encountered when the environment has WARNS=6 NO_WERROR=yes:
https://warns.kevans.dev -- this project will hopefully eventually go away
in favor of CI doing a much better job than it.

Reviewed by:	emaste, brooks, ngie (all earlier version)
Reviewed by:	emaste, arichardson (depend-cleanup.sh change)
Differential Revision:	https://reviews.freebsd.org/D26455
---
 tests/sys/cddl/zfs/bin/Makefile       | 2 ++
 tests/sys/cddl/zfs/tests/Makefile.inc | 3 +++
 tests/sys/geom/class/eli/Makefile     | 2 ++
 tests/sys/net/routing/Makefile        | 1 +
 4 files changed, 8 insertions(+)
 create mode 100644 tests/sys/cddl/zfs/tests/Makefile.inc

(limited to 'tests')

diff --git a/tests/sys/cddl/zfs/bin/Makefile b/tests/sys/cddl/zfs/bin/Makefile
index 21fff8e2ea515..165082e917472 100644
--- a/tests/sys/cddl/zfs/bin/Makefile
+++ b/tests/sys/cddl/zfs/bin/Makefile
@@ -7,6 +7,8 @@ MAN=
 BINDIR=		${TESTSBASE}/sys/cddl/zfs/bin
 SCRIPTSDIR=	${TESTSBASE}/sys/cddl/zfs/bin
 
+WARNS?=		0
+
 SCRIPTS+=	bsddisks.ksh
 SCRIPTS+=	dircmp.ksh
 SCRIPTS+=	dumpadm.ksh
diff --git a/tests/sys/cddl/zfs/tests/Makefile.inc b/tests/sys/cddl/zfs/tests/Makefile.inc
new file mode 100644
index 0000000000000..a73f0e488b1fb
--- /dev/null
+++ b/tests/sys/cddl/zfs/tests/Makefile.inc
@@ -0,0 +1,3 @@
+# $FreeBSD$
+
+WARNS?=	0
diff --git a/tests/sys/geom/class/eli/Makefile b/tests/sys/geom/class/eli/Makefile
index 8e4f2f4eb8392..c7f1342f45aef 100644
--- a/tests/sys/geom/class/eli/Makefile
+++ b/tests/sys/geom/class/eli/Makefile
@@ -4,6 +4,8 @@
 
 PACKAGE=	tests
 
+WARNS?=		3
+
 TESTSDIR=	${TESTSBASE}/sys/geom/class/${.CURDIR:T}
 
 ATF_TESTS_C=	pbkdf2_test
diff --git a/tests/sys/net/routing/Makefile b/tests/sys/net/routing/Makefile
index f0fe536fe7470..d32ba9af54a1d 100644
--- a/tests/sys/net/routing/Makefile
+++ b/tests/sys/net/routing/Makefile
@@ -1,6 +1,7 @@
 # $FreeBSD$
 
 PACKAGE=	tests
+WARNS?=		1
 
 TESTSDIR=       ${TESTSBASE}/sys/net/routing
 
-- 
cgit v1.2.3