FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=releng%2F11.2 2018-05-16T13:18:37Z 2018-05-16T13:18:37Z Warner Losh imp@FreeBSD.org 2018-05-16T13:18:37Z urn:sha1:4b4e9e06a85775b1eceb39c6101e94164ea23a35 Note: pc98 isn't run under VM, so I didn't do a direct commit to it. Approved by: re@ (gjb@) 2018-05-15T00:00:44Z Devin Teske dteske@FreeBSD.org 2018-05-15T00:00:44Z urn:sha1:16cdefa52d001a5c36b1500ef7de709d082a558e r329188: Use tabs in io.d, fix alignment issues, remove extra newlines r329334: Add errno definitions to /usr/lib/dtrace/errno.d r329353: Add inline to errno.d for translating int to string r329914: Updates and enhancements to io.d to aid DTrace scripting r329995: Updates and enhancements to signal.d to aid DTrace scripting r329996: Consistent casing for fallback SIGCHLD (s/Unknown/unknown/) MFC SVN r330559-330560,330672,332865-332867,333513-333519: dwatch(1) r330559: Introduce dwatch(1) as a tool for making DTrace more useful r330560: Bump dwatch(1) internal version from 1.0-beta-91 to 1.0 r330672: Fix display of wrong pid from dtrace_sched(4) r332865: Add `-dev' option to aid debugging of profiles r332866: Add profile for send(2)/recv(2) syscalls r332867: Remove the line used to demonstrate `-dev' option r333513: Bugfix, usage displayed with `-1Q' r333514: Separate default values so `-[BK] num' don't affect usage r333515: Simplify info message test r333516: Export ARGV to profiles loaded via load_profile() r333517: Allow `-E code' to override profile EVENT_DETAILS r333518: Expose process for ip/tcp/udp r333519: Refactor sendrecv profile Reviewed by: markj, gnn, bdrewery (head; earlier version) Approved by: re (gjb) Relnotes: yes Sponsored by: Smule, Inc. Differential Revision: https://reviews.freebsd.org/D15418 2018-05-10T23:58:33Z Glen Barber gjb@FreeBSD.org 2018-05-10T23:58:33Z urn:sha1:4ceb2a8428116a973a0d68114a1a02748244dd0b cycle. Update the default pkg(8) repository to the 'quarterly' branch to prevent further 11.2 builds from downgrading packages when invoking 'pkg upgrade' for the duration of the cycle. Approved by: re (implicit) Sponsored by: The FreeBSD Foundation 2018-04-27T18:07:31Z John Baldwin jhb@FreeBSD.org 2018-04-27T18:07:31Z urn:sha1:689b7855b14b86072c95372abe16bf4c77d71a49 Properly do a deep copy of the ioctls capability array for fget_cap(). fget_cap() tries to do a cheaper snapshot of a file descriptor without holding the file descriptor lock. This snapshot does not do a deep copy of the ioctls capability array, but instead uses a different return value to inform the caller to retry the copy with the lock held. However, filecaps_copy() was returning 1 to indicate that a retry was required, and fget_cap() was checking for 0 (actually '!filecaps_copy()'). As a result, fget_cap() did not do a deep copy of the ioctls array and just reused the original pointer. This cause multiple file descriptor entries to think they owned the same pointer and eventually resulted in duplicate frees. The only code path that I'm aware of that triggers this is to create a listen socket that has a restricted list of ioctls and then call accept() which calls fget_cap() with a valid filecaps structure from getsock_cap(). To fix, change the return value of filecaps_copy() to return true if it succeeds in copying the caps and false if it fails because the lock is required. I find this more intuitive than fixing the caller in this case. While here, change the return type from 'int' to 'bool'. Finally, make filecaps_copy() more robust in the failure case by not copying any of the source filecaps structure over. This avoids the possibility of leaking a pointer into a structure if a similar future caller doesn't properly handle the return value from filecaps_copy() at the expense of one more branch. I also added a test case that panics before this change and now passes. 2018-04-22T00:26:35Z Kyle Evans kevans@FreeBSD.org 2018-04-22T00:26:35Z urn:sha1:f6e097a71c003f8322e490519b184c7c2b4021e1 r288291 added a call to limits(1), which isn't available before partitions are mounted. This broke the ddb rc script, which does not provide its own start_cmd. Alleviate the situation here by providing a start_cmd. We still have other problems with diskless setups that need to be considered, but this is a start. PR: 206291 2018-04-18T16:22:23Z Glen Barber gjb@FreeBSD.org 2018-04-18T16:22:23Z urn:sha1:3460556abb974b8461725daf406c48028a72a9d9 growfs: Commit the changes after expanding the partition This fix the problem in arm snapshot present since at least 6 months where growfs was failing at firstboot and dropped you in a single user shell. Note: In addition to this merge, kern.geom.part.mbr.enforce_chs has been enabled on the build machine to mitigate against the issue in the PR referenced. PR: 226536 Sponsored by: The FreeBSD Foundation 2018-04-16T16:32:00Z Alan Somers asomers@FreeBSD.org 2018-04-16T16:32:00Z urn:sha1:574094a6d7c6b8c2abea0c15766932940679a4c7 r330696: Add some functional tests for tftpd(8) tftpd(8) is difficult to test in isolation due to its relationship with inetd. Create a test program that mimics the behavior of tftp(1) and inetd(8) and verifies tftpd's response in several different scenarios. These test cases cover all of the basic TFTP protocol, but not the optional parts. PR: 157700 PR: 225996 PR: 226004 PR: 226005 Differential Revision: https://reviews.freebsd.org/D14310 r330709: Commit missing file from r330696 X-MFC-With: 330696 r330742: tftpd: fix the build of tests on i386 after 330696 It's those darn printf format specifiers again Reported by: cy, kibab X-MFC-With: 330696 r331358: tftpd: misc Coverity cleanup in the tests A bunch of unchecked return values from open(2) and read(2) Reported by: Coverity CID: 1386900, 1386911, 1386926, 1386928, 1386932, 1386942 CID: 1386961, 1386979 X-MFC-With: 330696 2018-04-16T16:25:42Z Alan Somers asomers@FreeBSD.org 2018-04-16T16:25:42Z urn:sha1:b0453544ba4bc5b953e625debb9f3993e936ccac Add tests for lagg(4) and other cloned network interfaces Unfortunately, most of the tests are disabled because they fairly frequently trigger panics. Sponsored by: Spectra Logic Corp 2018-04-16T16:02:09Z Kristof Provost kp@FreeBSD.org 2018-04-16T16:02:09Z urn:sha1:8f0b3d1d03a2bf4f2f14202127399aeab75ebec6 pf: reload and resync do the same thing The reload and resync commands for the startup script do exactly the same thing, so implement one as a call to the other. 2018-04-16T16:01:06Z Edward Tomasz Napierala trasz@FreeBSD.org 2018-04-16T16:01:06Z urn:sha1:3d02e69168a860e4a6ef3347e482c17a5c473f18 etc: clean up trailing whitespace in autofs