src-test2/lib/libalias, branch release/5.3.0 FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=release%2F5.3.0 2004-08-14T14:21:09Z Fix outgoing ICMP on global instance. 2004-08-14T14:21:09Z Poul-Henning Kamp phk@FreeBSD.org 2004-08-14T14:21:09Z urn:sha1:e7581f0fc2b97703022b42069967a8cfca46e8a2 Fix Skinny and PPTP NAT'ing after the introduction of the {ip,tcp,udp}_next 2004-08-04T15:17:08Z Joe Marcus Clarke marcus@FreeBSD.org 2004-08-04T15:17:08Z urn:sha1:5c7e7e80ccdf71f9d2cfe8864a449ac63ae16cc9 functions. Basically, the ip_next() function was used to get the PPTP and Skinny headers when tcp_next() should have been used instead. Symptoms of this included a segfault in natd when trying to process a PPTP or Skinny packet. Approved by: des Push WARNS back up to 6, but define NO_WERROR; I want the warts out in the 2004-07-06T12:15:24Z Dag-Erling Smørgrav des@FreeBSD.org 2004-07-06T12:15:24Z urn:sha1:de47739e71230510257271ca49da6184b038eb3b open where people can see them and hopefully fix them. Introduce inline {ip,udp,tcp}_next() functions which take a pointer to an 2004-07-06T12:13:28Z Dag-Erling Smørgrav des@FreeBSD.org 2004-07-06T12:13:28Z urn:sha1:9fa0fd268273d90e765d9ebfe0be87ea4d64e138 {ip,udp,tcp} header and return a void * pointing to the payload (i.e. the first byte past the end of the header and any required padding). Use them consistently throughout libalias to a) reduce code duplication, b) improve code legibility, c) get rid of a bunch of alignment warnings. Rewrite twowords() to access its argument through a char pointer and not 2004-07-06T09:22:18Z Dag-Erling Smørgrav des@FreeBSD.org 2004-07-06T09:22:18Z urn:sha1:e3e2c216398b34e94a5d10701c8a25745cb910e0 a short pointer. The previous implementation seems to be in a gray zone of the C standard, and GCC generates incorrect code for it at -O2 or higher on some platforms. Temporarily lower WARNS to 3 while I figure out the alignment issues on 2004-07-06T08:44:41Z Dag-Erling Smørgrav des@FreeBSD.org 2004-07-06T08:44:41Z urn:sha1:95347a8ee0f4caf215f8847feac63a2b62c15f92 alpha. Make libalias WARNS?=6-clean. This mostly involves renaming variables 2004-07-05T11:10:57Z Dag-Erling Smørgrav des@FreeBSD.org 2004-07-05T11:10:57Z urn:sha1:ed01a5821550bf9859165f24c95b30c5f1b69f22 named link, foo_link or link_foo to lnk, foo_lnk or lnk_foo, fixing signed / unsigned comparisons, and shoving unused function arguments under the carpet. I was hoping WARNS?=6 might reveal more serious problems, and perhaps the source of the -O2 breakage, but found no smoking gun. Parenthesize return values. 2004-07-05T10:55:23Z Dag-Erling Smørgrav des@FreeBSD.org 2004-07-05T10:55:23Z urn:sha1:ffcb611a9d2113db86746085135c2d822e3bf357 Mechanical whitespace cleanup. 2004-07-05T10:53:28Z Dag-Erling Smørgrav des@FreeBSD.org 2004-07-05T10:53:28Z urn:sha1:f311ebb4ec205d59f36b71b24e8695cbb19a31ac Add LibAliasOutTry() which checks a packet for a hit in the tables, but 2004-07-04T12:53:07Z Poul-Henning Kamp phk@FreeBSD.org 2004-07-04T12:53:07Z urn:sha1:e6bbb691490917101f86a904b01319f0617b00a6 does not create a new entry if none is found.