FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=release%2F11.0.0 2016-02-04T21:16:35Z 2016-02-04T21:16:35Z Glen Barber gjb@FreeBSD.org 2016-02-04T21:16:35Z urn:sha1:a70cba95822f662d3f9da5119b6a0c433e8f70af Sponsored by: The FreeBSD Foundation 2015-11-25T19:10:28Z Bryan Drewery bdrewery@FreeBSD.org 2015-11-25T19:10:28Z urn:sha1:7b3ea376a27ada7a61eb0c3102f13040fb8c16cb This both avoids some dependencies on xinstall.host and allows bootstrapping on older releases to work due to lack of at least 'install -l' support. Sponsored by: EMC / Isilon Storage Division 2015-10-06T18:07:00Z Conrad Meyer cem@FreeBSD.org 2015-10-06T18:07:00Z urn:sha1:e6b95927f39018d10fcfc39f8236525c72b84d06 This fix is spiritually similar to r287442 and was discovered thanks to the KASSERT added in that revision. NT_PROCSTAT_VMMAP output length, when packing kinfo structs, is tied to the length of filenames corresponding to vnodes in the process' vm map via vn_fullpath. As vnodes may move during coredump, this is racy. We do not remove the race, only prevent it from causing coredump corruption. - Add a sysctl, kern.coredump_pack_vmmapinfo, to allow users to disable kinfo packing for PROCSTAT_VMMAP notes. This avoids VMMAP corruption and truncation, even if names change, at the cost of up to PATH_MAX bytes per mapped object. The new sysctl is documented in core.5. - Fix note_procstat_vmmap to self-limit in the second pass. This addresses corruption, at the cost of sometimes producing a truncated result. - Fix PROCSTAT_VMMAP consumers libutil (and libprocstat, via copy-paste) to grok the new zero padding. Reported by: pho (https://people.freebsd.org/~pho/stress/log/datamove4-2.txt) Relnotes: yes Sponsored by: EMC / Isilon Storage Division Differential Revision: https://reviews.freebsd.org/D3824 2015-09-03T20:32:10Z Conrad Meyer cem@FreeBSD.org 2015-09-03T20:32:10Z urn:sha1:14bdbaf2e40a827e84f6c2fe27b1f8229767f03c Coredump notes depend on being able to invoke dump routines twice; once in a dry-run mode to get the size of the note, and another to actually emit the note to the corefile. When a note helper emits a different length section the second time around than the length it requested the first time, the kernel produces a corrupt coredump. NT_PROCSTAT_FILES output length, when packing kinfo structs, is tied to the length of filenames corresponding to vnodes in the process' fd table via vn_fullpath. As vnodes may move around during dump, this is racy. So: - Detect badly behaved notes in putnote() and pad underfilled notes. - Add a fail point, debug.fail_point.fill_kinfo_vnode__random_path to exercise the NT_PROCSTAT_FILES corruption. It simply picks random lengths to expand or truncate paths to in fo_fill_kinfo_vnode(). - Add a sysctl, kern.coredump_pack_fileinfo, to allow users to disable kinfo packing for PROCSTAT_FILES notes. This should avoid both FILES note corruption and truncation, even if filenames change, at the cost of about 1 kiB in padding bloat per open fd. Document the new sysctl in core.5. - Fix note_procstat_files to self-limit in the 2nd pass. Since sometimes this will result in a short write, pad up to our advertised size. This addresses note corruption, at the risk of sometimes truncating the last several fd info entries. - Fix NT_PROCSTAT_FILES consumers libutil and libprocstat to grok the zero padding. With suggestions from: bjk, jhb, kib, wblock Approved by: markj (mentor) Relnotes: yes Sponsored by: EMC / Isilon Storage Division Differential Revision: https://reviews.freebsd.org/D3548 2015-06-13T19:20:56Z Simon J. Gerraty sjg@FreeBSD.org 2015-06-13T19:20:56Z urn:sha1:ccfb965433c67f3bda935a3cdf334be2e3c4348d Off by default, build behaves normally. WITH_META_MODE we get auto objdir creation, the ability to start build from anywhere in the tree. Still need to add real targets under targets/ to build packages. Differential Revision: D2796 Reviewed by: brooks imp 2015-06-08T23:35:17Z Simon J. Gerraty sjg@FreeBSD.org 2015-06-08T23:35:17Z urn:sha1:44d314f704764f0247a540648a4b4fc3e8012133 2015-06-01T06:05:53Z Marcelo Araujo araujo@FreeBSD.org 2015-06-01T06:05:53Z urn:sha1:a770b4d8ae6633c99e5ab0638ea2d04f028e8d26 Differential Revision: D2685 Reviewed by: rodrigc, stas 2015-05-27T01:19:58Z Simon J. Gerraty sjg@FreeBSD.org 2015-05-27T01:19:58Z urn:sha1:98e0ffaefb0f241cda3a72395d3be04192ae0d47 2015-05-21T03:32:44Z Allan Jude allanjude@FreeBSD.org 2015-05-21T03:32:44Z urn:sha1:04017fc7a4ca85f49b9c4c9419b7dd53500adb1d Add a cross refrence to libprocstat in the procstat.1 man page Differential Revision: https://reviews.freebsd.org/D2578 Suggested by: jmg Reviewed by: brueffer Approved by: wblock (mentor) MFC after: 1 week Sponsored by: ScaleEngine Inc. 2014-11-25T11:07:26Z Baptiste Daroussin bapt@FreeBSD.org 2014-11-25T11:07:26Z urn:sha1:6b129086dcee14496517fae085b448e3edc69bc7 While here reduce a bit overlinking