src-test2/sys/dev/ae, branch release/11.0.0FreeBSD source treehttps://cgit-dev.freebsd.org/src-test2/atom?h=release%2F11.0.02016-04-21T20:30:38ZYet more redundant parenthesis from r298431.2016-04-21T20:30:38ZPedro F. Giffunipfg@FreeBSD.org2016-04-21T20:30:38Zurn:sha1:a380994fff81ff425769164b7422beb260c60f14
Mea culpa.
sys: use our nitems() macro when param.h is available.2016-04-21T19:40:10ZPedro F. Giffunipfg@FreeBSD.org2016-04-21T19:40:10Zurn:sha1:323b076e9c3bdccf78698ad0f1934ca8ec5438ce
This should cover all the remaining cases in the kernel.
Discussed in: freebsd-current
Fix a potentially "forever" loop.2016-02-17T21:24:26ZGleb Smirnoffglebius@FreeBSD.org2016-02-17T21:24:26Zurn:sha1:7b0c04c29c08952e4ec9a7730d557114b01a0ccd
Found by: PVS-Studio
Mechanically convert to if_inc_counter().2014-09-19T03:51:26ZGleb Smirnoffglebius@FreeBSD.org2014-09-19T03:51:26Zurn:sha1:c8dfaf382fa6df9dc6fd1e1c3356e0c8bf607e6aUse define from if_var.h to access a field inside struct if_data,2014-08-30T19:55:54ZGleb Smirnoffglebius@FreeBSD.org2014-08-30T19:55:54Zurn:sha1:1bffa9511fe94125820858b0ead796db54ac019d
that resides in struct ifnet.
Sponsored by: Nginx, Inc.
Fix various NIC drivers to properly cleanup static DMA resources.2014-06-11T14:53:58ZJohn Baldwinjhb@FreeBSD.org2014-06-11T14:53:58Zurn:sha1:068d8643adb13434b57fdd5febf43a11194d508f
In particular, don't check the value of the bus_dma map against NULL
to determine if either bus_dmamem_alloc() or bus_dmamap_load() succeeded.
Instead, assume that bus_dmamap_load() succeeeded (and thus that
bus_dmamap_unload() should be called) if the bus address for a resource
is non-zero, and assume that bus_dmamem_alloc() succeeded (and thus
that bus_dmamem_free() should be called) if the virtual address for a
resource is not NULL.
In many cases these bugs could result in leaks when a driver was detached.
Reviewed by: yongari
MFC after: 2 weeks
Failed m_devget(9) indicates lack of free mbuf cluster. Update2013-12-18T07:23:42ZPyun YongHyeonyongari@FreeBSD.org2013-12-18T07:23:42Zurn:sha1:2e6383a8e8ede6c437544a3bdc211b465b643bfc
if_iqdrops counter for that case since the received frame is ok.
While here, simplify updating counter logic.
The r48589 promised to remove implicit inclusion of if_var.h soon. Prepare2013-10-26T17:58:36ZGleb Smirnoffglebius@FreeBSD.org2013-10-26T17:58:36Zurn:sha1:76039bc84fae9915788b54ff28fe0cc4876952d2
to this event, adding if_var.h to files that do need it. Also, include
all includes that now are included due to implicit pollution via if_var.h
Sponsored by: Netflix
Sponsored by: Nginx, Inc.
Avoid magic constant.2013-07-17T01:34:25ZPyun YongHyeonyongari@FreeBSD.org2013-07-17T01:34:25Zurn:sha1:fcb1bf41530e241c43310e48d4c8320c083da698
No functional change.
o TxD ring requires 8 bytes alignment to work so change alignment2013-07-17T01:24:23ZPyun YongHyeonyongari@FreeBSD.org2013-07-17T01:24:23Zurn:sha1:b9a17c6ce4dc2cd4860ca4990edb40effe0824a9
constraint to 8. Previously it may have triggered watchdog
timeouts.
o Check whether interrupt is ours or not.
o Enable interrupts before attemping to transmit queued packets.
This will slightly improve TX performance.
o No need to clear IFF_DRV_OACTIVE in a loop. AE_FLAG_TXAVAIL is
used to know whether there are enough available TxD ring space.
o Added missing bus_dmamap_sync(9) in ae_rx_intr() and rearranged
code to avoid unncessary register access.
o Make sure to clear TxD, TxS, RxD rings in driver initialization.
Otherwise some data in these rings could be interpreted as
'updated' which in turn will advance internally maintained
pointers and can trigger watchdog timeouts.
PR: kern/180382