FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=release%2F8.1.0 2009-02-04T20:39:45Z 2009-02-04T20:39:45Z Warner Losh imp@FreeBSD.org 2009-02-04T20:39:45Z urn:sha1:56e63ed73847c621879ead4d7ee9a4c4c3a0254e 2008-11-06T08:55:46Z Bjoern A. Zeeb bz@FreeBSD.org 2008-11-06T08:55:46Z urn:sha1:994d867cf7281c903ae9eba3408270d1145d5fc0 the sc does not have 'an_have_rssimap' variable. Add an ANCACHE check to poperly hide the case and make an(4) compile without INET. MFC after: 2 months 2008-01-18T16:34:18Z Doug Ambrisko ambrisko@FreeBSD.org 2008-01-18T16:34:18Z urn:sha1:ecefd670f5b908c89e3d4c362105e2aeb2688373 Submitted by: avatar 2008-01-18T16:31:24Z Doug Ambrisko ambrisko@FreeBSD.org 2008-01-18T16:31:24Z urn:sha1:f0e1e8d9fb38d0167e09e214d6f8a3d819d6b55d since the the command and data that is being built to be sent to or read from the HW lives in the softc. Commands are later run via an_setdef etc. In the ioctl path various references are kept to the data stored in the softc so it needs to be protected. Almost think of the command in the softc a global variable since it essentially is. Since locking wasn't done in this type of context the commands would get corrupted. Thanks to avatar@ for catching some lock issues and dhw@ for testing. Things are a lot more stable except for the MPI-350 cards. My an(4) remote laptop stays on the network now. The driver should be changed so that it uses private memory that is passed to the functions that talk to the card. Then only those functions would really need to grab locks. Reviewed by: avatar@ 2007-11-27T08:29:24Z Tai-hwa Liang avatar@FreeBSD.org 2007-11-27T08:29:24Z urn:sha1:8c81b154da8526a55aeee00a1a77e2ea51da9c93 an_stats_update() since a properly locked callout_stop(9) does do the right thing. Reviewed by: ambrisko, jhb MFC after: 3 days 2007-11-16T11:22:18Z Tai-hwa Liang avatar@FreeBSD.org 2007-11-16T11:22:18Z urn:sha1:6404b102387e3cb370ba444552c761eb9cbbaccf - Trying to eliminate another racing by replacing the timeout(9) with callout APIs. In addition to that, the callout_drain() in an_detach() help us to avoid a possible panic-on-free due to the callout API tries to lock a destroyed mutex. - In an_stats_update(), check the return value of an_read_record(). This should reduce the chance of device removal(PCCARD) panic [2]. - Adding a comment to state the fact that an_stats_update() is now called via callout(9) with a lock held [2]. Submitted by: jhb [1], ambrisko [2] Reviewed by: jhb, ambrisko Reported by: dhw Tested by: dhw MFC after: 3 days 2007-09-10T12:53:34Z Tai-hwa Liang avatar@FreeBSD.org 2007-09-10T12:53:34Z urn:sha1:73474451b9b7fcbab46cabac50763accbe29ce0c ioctl(). Note that other information provided by ifconfig(8) such like "list chan" or "list ap" are still not available at this moment. Before an(4) is connected to wlan(4), users are encouraged to use ancontrol(8) to retrieve aforementioned information. Reported by: dhw (http://lists.freebsd.org/pipermail/freebsd-current/2007-July/074848.html) Reviewed by: ambrisko Tested by: dhw Approved by: re (bmah) 2007-08-07T12:26:19Z Tai-hwa Liang avatar@FreeBSD.org 2007-08-07T12:26:19Z urn:sha1:07b6a9bed88c1fbc5ba03c7e3410f97f6e0b4647 to if_input(). Reviewed by: ambrisko Tested by: dhw Approved by: re (kensmith) 2007-08-02T02:20:19Z Tai-hwa Liang avatar@FreeBSD.org 2007-08-02T02:20:19Z urn:sha1:d28ab8736ff4571ee0046cf9d3757e8a21f20556 around copyin()/copyout(). Reviewed by: sam, thompsa Tested by: dhw Approved by: re (kensmith) 2007-06-08T01:21:20Z Matt Jacob mjacob@FreeBSD.org 2007-06-08T01:21:20Z urn:sha1:2342e96586db5d4de1ea709219d9641b6179d5c1