FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=release%2F8.2.0 2010-02-11T18:34:06Z 2010-02-11T18:34:06Z Matt Jacob mjacob@FreeBSD.org 2010-02-11T18:34:06Z urn:sha1:7733cf8fffadd4b286f7ed03e7748ee70e36433d 201408,201325,200089,198822,197373,197372,197214,196162). Since one of those changes was a semicolon cleanup from somebody else, this touches a lot more. 2009-02-18T18:41:34Z Sean Bruno sbruno@FreeBSD.org 2009-02-18T18:41:34Z urn:sha1:f541131711924523f9487e8a324aac07e2fd851c it instead of overloading sbp_show_sdev_info(). replace calls to printf with calls to device_printf and cleanup debug messages Remove a bit of dead, commented out code. Reviewed by: scottl(mentor) MFC after: 2 weeks 2009-02-09T16:57:07Z Max Khon fjoe@FreeBSD.org 2009-02-09T16:57:07Z urn:sha1:166366b5cd44e683f2dd6abba1b5176596fb3c67 Found with: Coverity Prevent(tm) CID: 3693 2009-02-01T23:28:52Z Sean Bruno sbruno@FreeBSD.org 2009-02-01T23:28:52Z urn:sha1:3042cc43f09c5d2300f94d6a5c4c4fd0aa96295a Move the interupt handler to a driver_intr_t type function as it was trying to do way to much for a lightweight filter interrupt function. Introduce much more locking around fc->mtx. Tested this for lock reversals and other such lockups. Locking seems to be working better, but there is much more to do with regard to locking. The most significant lock is in the BUS RESET handler. It was possible, before this checkin, to set a bus reset via "fwcontrol -r" and have the BUS RESET handler fire before the code responsible for asserting BUS RESET was complete. This locking fixes that issue. Move some of the memory allocations in the fc struct to the attach function in firewire.c Rework the businfo.generation indicator to be merely a on/off bit now. It's purpose according to spec is to notify the bus that the config ROM has changed. That's it. Catch and squash a possible panic in SBP where in the SBP_LOCK was held during a possible error case. The error handling code would definitely panic as it would try to acquire the SBP_LOCK on entrance. Catch and squash a camcontrol/device lockup when firewire drives go away. When a firewire device was powered off or disconnected from the firewire bus, a "camcontrol rescan all" would hang trying to poll removed devices as they were not properly detached. Don't do that. Approved by: scottl MFC after: 2 weeks 2007-06-17T05:55:54Z Scott Long scottl@FreeBSD.org 2007-06-17T05:55:54Z urn:sha1:b50569b71dfb110a58aa3e83f629115291802a74 now takes a device_t to be the parent of the bus that is being created. Most SIMs have been updated with a reasonable argument, but a few exceptions just pass NULL for now. This argument isn't used yet and the newbus integration likely won't be ready until after 7.0-RELEASE. 2007-06-16T00:59:41Z Hidetoshi Shimokawa simokawa@FreeBSD.org 2007-06-16T00:59:41Z urn:sha1:99b242f3543d3642417bdf7adf3f6461ac011e77 - Remove unnecessary timestamps. - Return CAM_RESRC_UNAVAIL for ORB shortage. - Fix a lock problem when doorbell is used. - Fix a potential bug for unordered execution. 2007-06-14T12:52:13Z Hidetoshi Shimokawa simokawa@FreeBSD.org 2007-06-14T12:52:13Z urn:sha1:9b33b1ab380d4d014727175e3f3ac0267aa6fcec We may need an explicit memory barrier for other architectures other than i386/amd64. MFC after: 3 days 2007-06-07T13:20:48Z Hidetoshi Shimokawa simokawa@FreeBSD.org 2007-06-07T13:20:48Z urn:sha1:ac2d2894b48d170a998e294c0fc8df0bbd783705 This is enabled by default. It should be disabled for those who are uneasy with peeking/poking from FireWire. Please note sbp(4) and dcons(4) over FireWire need this feature. 2007-06-06T18:33:38Z Andrew Gallatin gallatin@FreeBSD.org 2007-06-06T18:33:38Z urn:sha1:4930d13c506aa892f0f35d615325893ef9e27831 2007-06-06T14:31:36Z Hidetoshi Shimokawa simokawa@FreeBSD.org 2007-06-06T14:31:36Z urn:sha1:9950b741e91ab7a7e26badccc0d82f2e103a1f1e - lock its own locks and drop Giant. - create its own taskqueue thread. - split interrupt routine - use interrupt filter as a fast interrupt. - run watchdog timer in taskqueue so that it should be serialized with the bottom half. - add extra sanity check for transaction labels. disable ad-hoc workaround for unknown tlabels. - add sleep/wakeup synchronization primitives - don't reset OHCI in fwohci_stop()