src-test2/sys/dev/mlx, branch release/11.4.0

Revert r330897:

2018-03-29T02:50:57Z

This was intended to be a non-functional change. It wasn't. The commit message was thus wrong. In addition it broke arm, and merged crypto related code. Revert with prejudice. This revert skips files touched in r316370 since that commit was since MFCed. This revert also skips files that require $FreeBSD$ property changes. Thank you to those who helped me get out of this mess including but not limited to gonzo, kevans, rgrimes. Requested by: gjb (re)

Partial merge of the SPDX changes

2018-03-14T03:19:51Z

These changes are incomplete but are making it difficult to determine what other changes can/should be merged. No objections from: pfg

sys/dev: minor spelling fixes.

2016-05-03T03:41:25Z

Most affect comments, very few have user-visible effects.

sys/dev: extend use of the howmany() macro when available.

2016-04-26T15:03:15Z

We have a howmany() macro in the header that is convenient to re-use as it makes things easier to read.

sys/dev: use our nitems() macro when it is avaliable through param.h.

2016-04-19T23:37:24Z

No functional change, only trivial cases are done in this sweep, Drivers that can get further enhancements will be done independently. Discussed in: freebsd-current

Remove MAXBSIZE use from drivers where it has nothing to do.

2015-03-22T16:10:28Z

In some cases limits are just not needed, in others -- DFLTPHYS is the right constant to use instead. MFC after: 1 month

Add missing calls to bus_dmamap_unload() when freeing static DMA

2014-06-13T18:20:44Z

allocations. Reviewed by: scottl

Remove FreeBSD 4.x compat shims. Verified by md5.

2012-09-26T14:17:14Z

Add locking to mlx(4) to make it MPSAFE along with some other fixes:

2012-09-17T15:27:30Z

- Use callout(9) rather than timeout(9). - Add a mutex as an I/O lock that protects the adapter and is used for the I/O path. - Add an sx lock as a configuration lock that protects the relationship of configured volumes. - Freeze the request queue when a DMA load is deferred with EINPROGRESS and unfreeze the queue when the DMA callback is invoked. - Explicitly poll the hardware while waiting to submit a command to allow completed commands to free up slots in the command ring. - Remove driver-wide 'initted' variable from mlx_*_fw_handshake() routines. That state should be per-controller instead. Add it as an argument since the first caller knows when it is the first caller. - Remove explicit bus_space tag/handle and use bus_*() rather than bus_space_*(). - Move duplicated PCI device ID probing into a mlx_pci_match() routine. - Don't check for PCIM_CMD_MEMEN (the PCI bus will enable that when allocating the resource) and use pci_enable_busmaster() rather than manipulating the register directly. Tested by: no one despite multiple requests (hope it works)

Correct a typo.

2012-08-03T00:11:13Z

Reported by: Sascha Wildner Reviewed by: scottl MFC after: 3 days