FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=stable%2F10 2017-03-23T06:55:32Z 2017-03-23T06:55:32Z Alexander Motin mav@FreeBSD.org 2017-03-23T06:55:32Z urn:sha1:96f1383729678ae7da15671f776e142342044fd9 - XPT_NOTIFY_ACKNOWLEDGE was not handled, causing stuck requests. - XPT_ABORT was not even trying to abort active ATIOs/INOTs. - Initiator's tag was not stored and not used where needed. - List of TM request types needed update. - mpt_scsi_tgt_status() missed some useful debugging. After this change global TM requests, such as reset, should work properly. ABORT TASK (ABTS) requests are still not passes to CTL, that is not good and should be fixed. 2017-03-23T06:52:29Z Alexander Motin mav@FreeBSD.org 2017-03-23T06:52:29Z urn:sha1:d1247da352786fc558a4aeb63f64f21f3ec5e028 Target mode is still limited to 256 LUNs due to the way driver is written, but initiator can now use full 8 byte LUN space. 2017-03-23T06:50:46Z Alexander Motin mav@FreeBSD.org 2017-03-23T06:50:46Z urn:sha1:0cfa89a7f096e5f3f15d9847af34fc5ae4240d28 2017-03-23T06:49:01Z Alexander Motin mav@FreeBSD.org 2017-03-23T06:49:01Z urn:sha1:775c1ec2be045cfb85f13215a0bc840894aac07f - Not set BufferLength caused receive of empty ATIOs. - CDB length guessing was broken at least for RC16. - mpt_req_untimeout() was called with wrong req parameter. - Sense data reporting was broken in several ways. With this change my LSI7204EP-LC can pass at least basic tests as target. The code is still far from perfect, but finally I found second hw/driver after isp(4) that really can work in CAM target mode. 2017-03-23T06:47:48Z Alexander Motin mav@FreeBSD.org 2017-03-23T06:47:48Z urn:sha1:c2eab4ca18270342889c63e181ef77acfe7b8ca7 2017-03-23T06:45:57Z Alexander Motin mav@FreeBSD.org 2017-03-23T06:45:57Z urn:sha1:1695c01b5bb675212584c17a04530e682480816b I am not sure they are used anywhere, but why not. 2017-03-23T06:42:27Z Alexander Motin mav@FreeBSD.org 2017-03-23T06:42:27Z urn:sha1:2253da04cf70a6f40233b816354511226574070e 2017-03-23T06:41:13Z Alexander Motin mav@FreeBSD.org 2017-03-23T06:41:13Z urn:sha1:63a2397e28702b82eca0410a0a7db8f60fc51215 Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name) The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are fixed-length strings. AFAICT the only place they're read is in sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated. However, the kernel doesn't null-terminate them. A bunch of copy-pasted code uses strncpy to write them, and doesn't guarantee null-termination. For at least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually overflows. You can see the result by doing "camcontrol negotiate da0 -v". This change null-terminates those fields everywhere they're set in the kernel. It also shortens a few strings to ensure they'll fit within the 16-character field. PR: 215474 Reported by: Coverity CID: 1009997 1010000 1010001 1010002 1010003 1010004 1010005 CID: 1331519 1010006 1215097 1010007 1288967 1010008 1306000 CID: 1211924 1010009 1010010 1010011 1010012 1010013 1010014 CID: 1147190 1010017 1010016 1010018 1216435 1010020 1010021 CID: 1010022 1009666 1018185 1010023 1010025 1010026 1010027 CID: 1010028 1010029 1010030 1010031 1010033 1018186 1018187 CID: 1010035 1010036 1010042 1010041 1010040 1010039 2017-03-23T06:37:23Z Alexander Motin mav@FreeBSD.org 2017-03-23T06:37:23Z urn:sha1:8aaf841ffb665ead3cf2ea877c0e26f4d935438e Fix the fallout from r308268 (mpt driver causes endless witness warnings in VMWare and elsewhere) with the precision of a dull, rusty butter knife. 2017-03-23T06:34:45Z Alexander Motin mav@FreeBSD.org 2017-03-23T06:34:45Z urn:sha1:8b0f3056188bb05b5c4ddc6f4afe6c23b64d28d9 Remove NULL check after M_WAITOK allocation from mpt(4).