FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=release%2F12.0.0 2018-11-15T18:51:37Z 2018-11-15T18:51:37Z Vincenzo Maffione vmaffione@FreeBSD.org 2018-11-15T18:51:37Z urn:sha1:03bc8eede4fd826c1df4210dc5f4ee8c51eb5e41 vtnet: fix netmap support netmap(4) support for vtnet(4) was incomplete and had multiple bugs. This commit fixes those bugs to bring netmap on vtnet in a functional state. Changelist: - handle errors returned by virtqueue_enqueue() properly (they were previously ignored) - make sure netmap XOR rest of the kernel access each virtqueue. - compute the number of netmap slots for TX and RX separately, according to whether indirect descriptors are used or not for a given virtqueue. - make sure sglist are freed according to their type (mbufs or netmap buffers) - add support for mulitiqueue and netmap host (aka sw) rings. - intercept VQ interrupts directly instead of intercepting them in txq_eof and rxq_eof. This simplifies the code and makes it easier to make sure taskqueues are not running for a VQ while it is in netmap mode. - implement vntet_netmap_config() to cope with changes in the number of queues. Sponsored by: Sunny Valley Networks Differential Revision: https://reviews.freebsd.org/D17916 Approved by: re (gjb) 2018-10-30T08:36:36Z Vincenzo Maffione vmaffione@FreeBSD.org 2018-10-30T08:36:36Z urn:sha1:d740f837946a032c60ddba5cc4cbf899eb4fbaee netmap: align codebase to the current upstream (sha 8374e1a7e6941) Changelist: - Move large parts of VALE code to a new file and header netmap_bdg.[ch]. This is useful to reuse the code within upcoming projects. - Improvements and bug fixes to pipes and monitors. - Introduce nm_os_onattach(), nm_os_onenter() and nm_os_onexit() to handle differences between FreeBSD and Linux. - Introduce some new helper functions to handle more host rings and fake rings (netmap_all_rings(), netmap_real_rings(), ...) - Added new sysctl to enable/disable hw checksum in emulated netmap mode. - nm_inject: add support for NS_MOREFRAG Approved by: re (gjb) 2018-08-14T19:12:45Z David Bright dab@FreeBSD.org 2018-08-14T19:12:45Z urn:sha1:53e992cfb9bfbc5c77588165b3a250a1fa555a23 The libkqueue tests have several places that leak memory by using an idiom like: puts(kevent_to_str(kevp)); Rework to save the pointer returned from kevent_to_str() and then free() it after it has been used. Reported by: asomers (pointer to Coverity), Coverity CID: 1296063, 1296064, 1296065, 1296066, 1296067, 1350287, 1394960 Sponsored by: Dell EMC 2018-05-19T05:57:26Z Matt Macy mmacy@FreeBSD.org 2018-05-19T05:57:26Z urn:sha1:24a7d6d3a6ac1bc35adeac8233ecf59afe1728bf 2018-05-19T05:37:18Z Matt Macy mmacy@FreeBSD.org 2018-05-19T05:37:18Z urn:sha1:3535fae8477ff568b74041cbc22842ae03032605 2018-05-18T03:38:17Z Matt Macy mmacy@FreeBSD.org 2018-05-18T03:38:17Z urn:sha1:cfa866f6a1ba4798cd6d877f0f0e4f45227efb9c Approved by: sbruno 2018-04-13T19:43:23Z Brooks Davis brooks@FreeBSD.org 2018-04-13T19:43:23Z urn:sha1:1315f9b59f83b4ed83fccfd5a0e696267ede902f 2018-04-12T07:20:50Z Vincenzo Maffione vmaffione@FreeBSD.org 2018-04-12T07:20:50Z urn:sha1:2ff91c175eca50b7d0d9da6b31eae4109c034137 Changelist: - Turn tx_rings and rx_rings arrays into arrays of pointers to kring structs. This patch includes fixes for ixv, ixl, ix, re, cxgbe, iflib, vtnet and ptnet drivers to cope with the change. - Generalize the nm_config() callback to accept a struct containing many parameters. - Introduce NKR_FAKERING to support buffers sharing (used for netmap pipes) - Improved API for external VALE modules. - Various bug fixes and improvements to the netmap memory allocator, including support for externally (userspace) allocated memory. - Refactoring of netmap pipes: now linked rings share the same netmap buffers, with a separate set of kring pointers (rhead, rcur, rtail). Buffer swapping does not need to happen anymore. - Large refactoring of the control API towards an extensible solution; the goal is to allow the addition of more commands and extension of existing ones (with new options) without the need of hacks or the risk of running out of configuration space. A new NIOCCTRL ioctl has been added to handle all the requests of the new control API, which cover all the functionalities so far supported. The netmap API bumps from 11 to 12 with this patch. Full backward compatibility is provided for the old control command (NIOCREGIF), by means of a new netmap_legacy module. Many parts of the old netmap.h header has now been moved to netmap_legacy.h (included by netmap.h). Approved by: hrs (mentor) 2018-04-09T09:24:26Z Vincenzo Maffione vmaffione@FreeBSD.org 2018-04-09T09:24:26Z urn:sha1:4f80b14ce2b17100b12dc3a346fb9e6e76764e11 Changelist: - remove unused nkr_slot_flags - new nm_intr adapter callback to enable/disable interrupts - remove unused sysctls and document the other sysctls - new infrastructure to support NS_MOREFRAG for NIC ports - support for external memory allocator (for now linux-only), including linux-specific changes in common headers - optimizations within netmap pipes datapath - improvements on VALE control API - new nm_parse() helper function in netmap_user.h - various bug fixes and code clean up Approved by: hrs (mentor) 2018-04-04T21:31:12Z Vincenzo Maffione vmaffione@FreeBSD.org 2018-04-04T21:31:12Z urn:sha1:46023447b69f76174fb12abd910b9b6cba31345b The change upgrades the driver to use the split Communication Status Block (CSB) format. In this way the variables written by the guest and read by the host are allocated in a different cacheline than the variables written by the host and read by the guest; this is needed to avoid cache thrashing. Approved by: hrs (mentor)