src-test2/sys/dev/pms, branch release/12.0.0

pms/freebsd: fix compiler warnings

2017-10-21T07:23:45Z

- A number of unused variable warnings, - a missing prototype warning (actually a dead function), - and a potential use of an uninitialized variable. Reviewed by: pfg Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D12683

sys/dev: Replace zero with NULL for pointers.

2017-02-20T03:43:12Z

Makes things easier to read, plus architectures may set NULL to something different than zero. Found with: devel/coccinelle MFC after: 3 weeks

Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name)

2017-01-04T20:26:42Z

The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are fixed-length strings. AFAICT the only place they're read is in sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated. However, the kernel doesn't null-terminate them. A bunch of copy-pasted code uses strncpy to write them, and doesn't guarantee null-termination. For at least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually overflows. You can see the result by doing "camcontrol negotiate da0 -v". This change null-terminates those fields everywhere they're set in the kernel. It also shortens a few strings to ensure they'll fit within the 16-character field. PR: 215474 Reported by: Coverity CID: 1009997 1010000 1010001 1010002 1010003 1010004 1010005 CID: 1331519 1010006 1215097 1010007 1288967 1010008 1306000 CID: 1211924 1010009 1010010 1010011 1010012 1010013 1010014 CID: 1147190 1010017 1010016 1010018 1216435 1010020 1010021 CID: 1010022 1009666 1018185 1010023 1010025 1010026 1010027 CID: 1010028 1010029 1010030 1010031 1010033 1018186 1018187 CID: 1010035 1010036 1010042 1010041 1010040 1010039 Reviewed by: imp, sephe, slm MFC after: 4 weeks Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D9037 Differential Revision: https://reviews.freebsd.org/D9038

Don't repeat the the word 'the'

2016-05-17T12:52:31Z

(one manual change to fix grammar) Confirmed With: db Approved by: secteam (not really, but this is a comment typo fix)

dev/pms: minor spelling fixes for the FreeBSD-specific part.

2016-05-04T17:52:53Z

sys: use our roundup2/rounddown2() macros when param.h is available.

2016-04-21T19:57:40Z

rounddown2 tends to produce longer lines than the original code and when the code has a high indentation level it was not really advantageous to do the replacement. This tries to strike a balance between readability using the macros and flexibility of having the expressions, so not everything is converted.

As is included from , there is no need to

2016-02-22T09:02:20Z

include it explicitly when is already included. Reviewed by: alc, kib Differential Revision: https://reviews.freebsd.org/D5373

ostiInitiatorIOCompleted(): wrong sizeof() argument.

2016-02-21T16:45:22Z

Detected by: PVS Static Analysis CID: 1331601, 1331523

Don't forget to check the vendor when probing. Also, there's no need

2015-08-02T16:26:41Z

to double check for if the card has probed before. In fact, there's no reason to single check either. Simplify the code as a result. $FreeBSD$ added to lxutil.c in a non-standard way to help keep the diffs with upstream to a minimum. Differential Revision: https://reviews.freebsd.org/D3263

Disable debugging.

2015-07-17T20:29:47Z

Submitted by: Vasanthalakshmi Tharmarajan Reviewed by: scottl