src-test2/sys/dev/random/randomdev_soft.c, branch release/6.1.0_cvs FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=release%2F6.1.0_cvs 2006-02-08T05:58:17Z MFC: 2006-02-08T05:58:17Z Paul Saab ps@FreeBSD.org 2006-02-08T05:58:17Z urn:sha1:1e2be7eaab67cd541228131d8dd7c38312bbf701 Remove GIANT from device random. Approved by: re (scottl) Revert to the more correct array size, and correct a KASSERT to 2005-03-29T11:08:45Z Mark Murray markm@FreeBSD.org 2005-03-29T11:08:45Z urn:sha1:3a0323d92f29bd5a20dc60de017964326d9111d6 only allow proper values. ENTROPYSOURCE is a maxval+1, not an allowable number. Suggested loose protons in the solution: phk Prefers to keep the pH close to seven: markm Fix off-by-one (too little!) array size problem. 2005-03-18T07:13:35Z Poul-Henning Kamp phk@FreeBSD.org 2005-03-18T07:13:35Z urn:sha1:f7e6cbd933cafe20568561761a54ea72fd68f0b5 Detected by: Coverity (ID#661) Check O_NONBLOCK not IO_NDELAY. 2004-12-22T17:29:37Z Poul-Henning Kamp phk@FreeBSD.org 2004-12-22T17:29:37Z urn:sha1:4c4a94cefeed0bc69827ae4d43f07ff375f7537b Don't include vnode.h Don't change the priority to PUSER when sleeping, just keep the current 2004-11-05T20:15:06Z John Baldwin jhb@FreeBSD.org 2004-11-05T20:15:06Z urn:sha1:6ac27fe1e672525584a599491321f250481bceef priority. (1) Move from O(n) list copies to O(1) list concatenation, which is 2004-11-03T10:02:50Z Robert Watson rwatson@FreeBSD.org 2004-11-03T10:02:50Z urn:sha1:b899bc84c5dcdd5282a40283fc7c2fce5f81d5c2 supported for STAILQ via STAILQ_CONCAT(). (2) Maintain a count of the number of entries in the thread-local entropy fifo so that we can keep the other fifo counts in synch. MFC after: 3 weeks MFC with: randomdev_soft.c revisions 1.5 and 1.6 Suggested by: jhb (1) Assert that the entropy source category provided by a caller submitting 2004-10-12T14:57:14Z Robert Watson rwatson@FreeBSD.org 2004-10-12T14:57:14Z urn:sha1:f5c3a745029ef47abbb8a584b05cebb3973696b1 entropy is valid, as an invalid source will cause dereferencing of an array of queues to an incorrect memory location. Modify entropy harvesting locking strategy: 2004-10-09T22:04:13Z Robert Watson rwatson@FreeBSD.org 2004-10-09T22:04:13Z urn:sha1:a28ce935d9503eb47cb82ad643fdb99ef7df8312 - Trade off granularity to reduce overhead, since the current model doesn't appear to reduce contention substantially: move to a single harvest mutex protecting harvesting queues, rather than one mutex per source plus a mutex for the free list. - Reduce mutex operations in a harvesting event to 2 from 4, and maintain lockless read to avoid mutex operations if the queue is full. - When reaping harvested entries from the queue, move all entries from the queue at once, and when done with them, insert them all into a thread-local queue for processing; then insert them all into the empty fifo at once. This reduces O(4n) mutex operations to O(2) mutex operations per wakeup. In the future, we may want to look at re-introducing granularity, although perhaps at the granularity of the source rather than the source class; both the new and old strategies would cause contention between different instances of the same source (i.e., multiple network interfaces). Reviewed by: markm Perform a lockless read to test whether an entropy havesting fifo is 2004-08-11T03:33:32Z Robert Watson rwatson@FreeBSD.org 2004-08-11T03:33:32Z urn:sha1:38c9c1708b198018ba6ddfae9ab7e1ebaeed050c full, avoiding the cost of mutex operations if it is. We re-test once the mutex is acquired to make sure it's still true before doing the -modify-write part of the read-modify-write. Note that due to the maximum fifo depth being pretty deep, this is unlikely to improve harvesting performance yet. Approved by: markm Start the entropy device insecure/unblocked. I'll be handing over 2004-07-18T09:07:58Z Mark Murray markm@FreeBSD.org 2004-07-18T09:07:58Z urn:sha1:587d5fc63b5ff4d566419b897a56b2fff92dfd34 responsibility for critical randomness requirements (like sshd) to rc.d/* Requested by: many