FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=release%2F10.0.0 2013-08-03T21:24:52Z 2013-08-03T21:24:52Z Marius Strobl marius@FreeBSD.org 2013-08-03T21:24:52Z urn:sha1:eb84fc95061d8b4f540ac1befe4fdab834597378 2013-08-02T23:31:51Z Marius Strobl marius@FreeBSD.org 2013-08-02T23:31:51Z urn:sha1:1e53269ac2d96ce70747e18aa1942285ffee67dd 2013-08-02T23:30:32Z Marius Strobl marius@FreeBSD.org 2013-08-02T23:30:32Z urn:sha1:71bda3eb9aa62e7073ad31ff4c374a21e2fc34ef - Remove unnecessary __RMAN_RESOURCE_VISIBLE. 2013-08-02T23:28:49Z Marius Strobl marius@FreeBSD.org 2013-08-02T23:28:49Z urn:sha1:c4b1deaf0d05e7ba715124b4c752edef80222115 this is is crucial at least for the latter. What happens is that attaching uart(4) to scc(4) causes the SAB 82532 to "receive" something and trigger a SER_INT_RXREADY interrupt, given that at least fast/filter interrupts are already enabled. Prior to r253161, uart_bus_ihand() was set up at this point and handled that condition, i. e. read the RX FIFO and issued a Receive Message Complete. Now, uart_bus_ihand() and uart_intr() are setup after attaching uart(4), leaving the SER_INT_RXREADY interrupt triggered during the latter to be handled by the iclear method. However, with that method not implement, this in turn causes SAB 82532 to not issue any further SER_INT_RXREADY interrupts until the RX FIFO is full again. Thus, 15 received bytes go to nowhere, given that "the other half" of the RX FIFO is used for status information. Hence, implementing sab82532_bfe_iclear() fixes things again. Potentially, the same problem exists for QUICC. - Remove unnecessary __RMAN_RESOURCE_VISIBLE. - Remove a superfluous header. - Use KOBJMETHOD_END. - Mark unused arguments as such. - Remove variables unused after initialization. Reviewed by: marcel (earlier version) 2011-11-22T21:28:20Z Marius Strobl marius@FreeBSD.org 2011-11-22T21:28:20Z urn:sha1:4b7ec27007570e0ce4fe9dbb447e7afc131b487a one. Interestingly, these are actually the default for quite some time (bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9) since r52045) but even recently added device drivers do this unnecessarily. Discussed with: jhb, marcel - While at it, use DEVMETHOD_END. Discussed with: jhb - Also while at it, use __FBSDID. 2011-11-07T06:44:47Z Ed Schouten ed@FreeBSD.org 2011-11-07T06:44:47Z urn:sha1:d745c852becf3792a2185003947324721209195a This means that their use is restricted to a single C file. 2011-05-15T13:27:38Z Marius Strobl marius@FreeBSD.org 2011-05-15T13:27:38Z urn:sha1:c71dacd16819b980c0b740e5cecc5e9f6331c080 2009-02-05T19:32:34Z Warner Losh imp@FreeBSD.org 2009-02-05T19:32:34Z urn:sha1:005f7c33086f8ecbcc37a2915e13e69bf1c158c3 2008-04-26T18:40:59Z Marcel Moolenaar marcel@FreeBSD.org 2008-04-26T18:40:59Z urn:sha1:6239f9e5f1c3272eb7d16415bb6c24bef21b1f1d total of 6 interrupt resources for scc(4) on macio(4). This is 3 per channel, of which the 1st of each channel is the interrupt associated with the SCC. The other 2 are for DMA operation. Change scc_bfe_attach() to accept an argument that's the number of interrupts per channel (ipc) and change each bus front-end (bfe) to pass that argument through a wrapper for the device_attach method. For now, we only allocate the 1st interrupt of each channel to perserve behaviour. 2008-03-03T18:20:17Z Rafal Jaworowski raj@FreeBSD.org 2008-03-03T18:20:17Z urn:sha1:e1ef781113fba635a7fa4a979607261385971992 The QUICC engine is found on various Freescale parts including MPC85xx, and provides multiple generic time-division serial channel resources, which are in turn muxed/demuxed by the Serial Communications Controller (SCC). Along with core QUICC/SCC functionality a uart(4)-compliant device driver is provided which allows for serial ports over QUICC/SCC. Approved by: cognet (mentor) Obtained from: Juniper MFp4: e500