FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=release%2F11.3.0 2018-03-29T02:50:57Z 2018-03-29T02:50:57Z Eitan Adler eadler@FreeBSD.org 2018-03-29T02:50:57Z urn:sha1:4ab2e064d7950be84256d671a7ae93f87cc6aa36 This was intended to be a non-functional change. It wasn't. The commit message was thus wrong. In addition it broke arm, and merged crypto related code. Revert with prejudice. This revert skips files touched in r316370 since that commit was since MFCed. This revert also skips files that require $FreeBSD$ property changes. Thank you to those who helped me get out of this mess including but not limited to gonzo, kevans, rgrimes. Requested by: gjb (re) 2018-03-14T03:19:51Z Eitan Adler eadler@FreeBSD.org 2018-03-14T03:19:51Z urn:sha1:be5d0b9566b13fdf8cabebb63334cbec12bfc409 These changes are incomplete but are making it difficult to determine what other changes can/should be merged. No objections from: pfg 2014-09-19T03:51:26Z Gleb Smirnoff glebius@FreeBSD.org 2014-09-19T03:51:26Z urn:sha1:c8dfaf382fa6df9dc6fd1e1c3356e0c8bf607e6a 2014-08-30T19:55:54Z Gleb Smirnoff glebius@FreeBSD.org 2014-08-30T19:55:54Z urn:sha1:1bffa9511fe94125820858b0ead796db54ac019d that resides in struct ifnet. Sponsored by: Nginx, Inc. 2014-06-11T14:53:58Z John Baldwin jhb@FreeBSD.org 2014-06-11T14:53:58Z urn:sha1:068d8643adb13434b57fdd5febf43a11194d508f In particular, don't check the value of the bus_dma map against NULL to determine if either bus_dmamem_alloc() or bus_dmamap_load() succeeded. Instead, assume that bus_dmamap_load() succeeeded (and thus that bus_dmamap_unload() should be called) if the bus address for a resource is non-zero, and assume that bus_dmamem_alloc() succeeded (and thus that bus_dmamem_free() should be called) if the virtual address for a resource is not NULL. In many cases these bugs could result in leaks when a driver was detached. Reviewed by: yongari MFC after: 2 weeks 2013-10-26T17:58:36Z Gleb Smirnoff glebius@FreeBSD.org 2013-10-26T17:58:36Z urn:sha1:76039bc84fae9915788b54ff28fe0cc4876952d2 to this event, adding if_var.h to files that do need it. Also, include all includes that now are included due to implicit pollution via if_var.h Sponsored by: Netflix Sponsored by: Nginx, Inc. 2012-12-04T09:32:43Z Gleb Smirnoff glebius@FreeBSD.org 2012-12-04T09:32:43Z urn:sha1:c6499eccad497913a5025fbde8ae76da70e08043 malloc(9) flags in sys/dev. 2012-11-05T19:16:27Z Dimitry Andric dim@FreeBSD.org 2012-11-05T19:16:27Z urn:sha1:29658c96ce9914fdf4ff4e3519fbec696ef32118 them, please let me know if not). Most of these are of the form: static const struct bzzt_type { [...list of members...] } const bzzt_devs[] = { [...list of initializers...] }; The second const is unnecessary, as arrays cannot be modified anyway, and if the elements are const, the whole thing is const automatically (e.g. it is placed in .rodata). I have verified this does not change the binary output of a full kernel build (except for build timestamps embedded in the object files). Reviewed by: yongari, marius MFC after: 1 week 2011-11-22T21:28:20Z Marius Strobl marius@FreeBSD.org 2011-11-22T21:28:20Z urn:sha1:4b7ec27007570e0ce4fe9dbb447e7afc131b487a one. Interestingly, these are actually the default for quite some time (bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9) since r52045) but even recently added device drivers do this unnecessarily. Discussed with: jhb, marcel - While at it, use DEVMETHOD_END. Discussed with: jhb - Also while at it, use __FBSDID. 2011-11-01T16:13:59Z Marius Strobl marius@FreeBSD.org 2011-11-01T16:13:59Z urn:sha1:8c1093fc50ab084b2ddd4750290a23d62616e0b6 take advantage of it instead of duplicating it. This reduces the size of the i386 GENERIC kernel by about 4k. The only potential in-tree user left unconverted is xe(4), which generally should be changed to use miibus(4) instead of implementing PHY handling on its own, as otherwise it makes not much sense to add a dependency on miibus(4)/mii_bitbang(4) to xe(4) just for the MII bitbang'ing code. The common MII bitbang'ing code also is useful in the embedded space for using GPIO pins to implement MII access. - Based on lessons learnt with dc(4) (see r185750), add bus barriers to the MII bitbang read and write functions of the other drivers converted in order to ensure the intended ordering. Given that register access via an index register as well as register bank/window switching is subject to the same problem, also add bus barriers to the respective functions of smc(4), tl(4) and xl(4). - Sprinkle some const. Thanks to the following testers: Andrew Bliznak (nge(4)), nwhitehorn@ (bm(4)), yongari@ (sis(4) and ste(4)) Thanks to Hans-Joerg Sirtl for supplying hardware to test stge(4). Reviewed by: yongari (subset of drivers) Obtained from: NetBSD (partially)