src-test2/sys/dev/uart/uart_cpu_pc98.c, branch release/5.2.0_cvs FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=release%2F5.2.0_cvs 2004-01-10T05:53:29Z This commit was manufactured by cvs2svn to create tag 2004-01-10T05:53:29Z cvs2svn cvs2svn@FreeBSD.org 2004-01-10T05:53:29Z urn:sha1:58c9ff44c8041f394c663cb9640e9b77fe07bb13 'RELENG_5_2_0_RELEASE'. This commit was manufactured to restore the state of the 5.2-RELEASE image. Releases prior to 5.3-RELEASE are omitting the secure/ and crypto/ subdirs. Revert the introduction of iobase in struct uart_bas. Both the SAB82532 2003-09-26T05:14:56Z Marcel Moolenaar marcel@FreeBSD.org 2003-09-26T05:14:56Z urn:sha1:875f70dba4ac5331af98ce31da9e3f02bdf2af21 and the Z8530 drivers used the I/O address as a quick and dirty way to determine which channel they operated on, but formalizing this by introducing iobase is not a solution. How for example would a driver know which channel it controls for a multi-channel UART that only has a single I/O range? Instead, add an explicit field, called chan, to struct uart_bas that holds the channel within a device, or 0 otherwise. The chan field is initialized both by the system device probing (i.e. a system console) or it is passed down to uart_bus_probe() by any of the bus front-ends. As such, it impacts all platforms and bus drivers and makes it a rather large commit. Remove the use of iobase in uart_cpu_eqres() for pc98. It is expected that platforms have the capability to compare tag and handle pairs for equality; as to determine whether two pairs access the same device or not. The use of iobase for pc98 makes it impossible to formalize this and turn it into a real newbus function later. This commit reverts uart_cpu_eqres() for pc98 to an unimplemented function. It has to be reimplemented using only the tag and handle fields in struct uart_bas. Rewrite the SAB82532 and Z8530 drivers to use the chan field in struct uart_bas. Remove the IS_CHANNEL_A and IS_CHANNEL_B macros. We don't need to abstract anything anymore. Discussed with: nyan Tested on: i386, ia64, sparc64 Don't return to search another ports even if bus_space_map() fails. 2003-09-23T13:03:22Z Yoshihiro Takahashi nyan@FreeBSD.org 2003-09-23T13:03:22Z urn:sha1:312ebe0323fc59785bbb68fd4b7366eacc5cc7ed Compare base address instead of bus_handle. 2003-09-23T09:49:37Z Yoshihiro Takahashi nyan@FreeBSD.org 2003-09-23T09:49:37Z urn:sha1:82df4f3134d636d48f7854df45a3d9337c8ca610 - Keep the base address in struct uart_bas for sab82532 and z8530 modules. 2003-09-23T09:25:38Z Yoshihiro Takahashi nyan@FreeBSD.org 2003-09-23T09:25:38Z urn:sha1:c423dba33446cdad2bea753403c9520ceb9ac488 - Remove buggy uart_cpu_busaddr() function. Use bus_space_map() to initialize a bus_handle. 2003-09-23T08:38:49Z Yoshihiro Takahashi nyan@FreeBSD.org 2003-09-23T08:38:49Z urn:sha1:81a11def25e5cb23c9f4672a866d0b2720effe65 Minor commentary cleanup, since I didn't understand the comments that 2003-09-11T04:22:28Z Warner Losh imp@FreeBSD.org 2003-09-11T04:22:28Z urn:sha1:3e49a687ffa42f749fc91b74934076521b8ff025 I wrote. Fix compile on pc98. Maybe this is correct. 2003-09-11T04:14:26Z Warner Losh imp@FreeBSD.org 2003-09-11T04:14:26Z urn:sha1:04ea3df7d929293fc7f82ec1c6e77d172b5a2375 Remove the assumption that a bus_space_handle_t is an I/O address 2003-09-07T21:51:03Z Marcel Moolenaar marcel@FreeBSD.org 2003-09-07T21:51:03Z urn:sha1:5cc705512d61b0e69a92da59a5d034a0e882a6fd from the SAB82532 and the Z8530 hardware drivers by introducing uart_cpu_busaddr(). The assumption is not true on pc98 where bus_space_handle_t is a pointer to a structure. The uart_cpu_busaddr() function will return the bus address corresponding the tag and handle given to it by the BAS. WARNING: the intend of the function is STRICTLY to allow hardware drivers to determine which logical channel they control and is NOT to be used for actual I/O. It is therefore EXPLICITLY allowed that uart_cpu_busaddr() returns only the lower 8 bits of the address and garbage in all other bits. No mistakes... Better stab at MD code for pc98. The 8251 stuff is a total lie 2003-09-07T04:59:15Z Warner Losh imp@FreeBSD.org 2003-09-07T04:59:15Z urn:sha1:af1af2d2cce18446faaa0e7336b97d98dc39e287 (ns8250 copied and s/ns8250/i8251/g), but there for linkage purposes. Real code to follow, once I get past some boot issues on my pc98 boxes with recent current.