FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=release%2F11.3.0 2019-05-16T18:26:42Z 2019-05-16T18:26:42Z Michael Tuexen tuexen@FreeBSD.org 2019-05-16T18:26:42Z urn:sha1:62792d6cb797d786f4cbb917cd0dc0238dcfc5ed Remove non-functional SCTP checksum offload support for virtio. Checksum offloading for SCTP is not currently specified for virtio. If the hypervisor announces checksum offloading support, it means TCP and UDP checksum offload. If an SCTP packet is sent and the host announced checksum offload support, the hypervisor inserts the IP checksum (16-bit) at the correct offset, but this is not the right checksum, which is a CRC32c. This results in all outgoing packets having the wrong checksum and therefore breaking SCTP based communications. This patch removes SCTP checksum offloading support from the virtio network interface. Thanks to Felix Weinrank for making me aware of the issue. 2019-04-19T03:47:59Z Alexander Motin mav@FreeBSD.org 2019-04-19T03:47:59Z urn:sha1:d3ad69ea0d8acdb1442a313c20c00a98182d4ab9 2019-02-01T12:24:56Z Vincenzo Maffione vmaffione@FreeBSD.org 2019-02-01T12:24:56Z urn:sha1:3c77f34940fb881dbcb7969c5c6b189a743ad0b2 vtnet: fix typo in vtnet_free_taskqueues Because of a typo, the code was mistakenly resetting the vtnrx_vq pointer rather than vtntx_tq. Reviewed by: bryanv Differential Revision: https://reviews.freebsd.org/D19015 2018-12-04T17:44:12Z Vincenzo Maffione vmaffione@FreeBSD.org 2018-12-04T17:44:12Z urn:sha1:803bb5c96e5fa1c86aa3b0fec8109e3d811e8e72 vtnet: fix netmap support netmap(4) support for vtnet(4) was incomplete and had multiple bugs. This commit fixes those bugs to bring netmap on vtnet in a functional state. Changelist: - handle errors returned by virtqueue_enqueue() properly (they were previously ignored) - make sure netmap XOR rest of the kernel access each virtqueue. - compute the number of netmap slots for TX and RX separately, according to whether indirect descriptors are used or not for a given virtqueue. - make sure sglist are freed according to their type (mbufs or netmap buffers) - add support for mulitiqueue and netmap host (aka sw) rings. - intercept VQ interrupts directly instead of intercepting them in txq_eof and rxq_eof. This simplifies the code and makes it easier to make sure taskqueues are not running for a VQ while it is in netmap mode. - implement vntet_netmap_config() to cope with changes in the number of queues. Reviewed by: bryanv Approved by: gnn (mentor) Sponsored by: Sunny Valley Networks Differential Revision: https://reviews.freebsd.org/D17916 2018-03-29T02:50:57Z Eitan Adler eadler@FreeBSD.org 2018-03-29T02:50:57Z urn:sha1:4ab2e064d7950be84256d671a7ae93f87cc6aa36 This was intended to be a non-functional change. It wasn't. The commit message was thus wrong. In addition it broke arm, and merged crypto related code. Revert with prejudice. This revert skips files touched in r316370 since that commit was since MFCed. This revert also skips files that require $FreeBSD$ property changes. Thank you to those who helped me get out of this mess including but not limited to gonzo, kevans, rgrimes. Requested by: gjb (re) 2018-03-17T20:37:01Z Bryan Venteicher bryanv@FreeBSD.org 2018-03-17T20:37:01Z urn:sha1:bea861cfe1ac2953b3d5c87a3dd8d07f0c78fda3 Sync VirtIO IDs with Linux Add VirtIO bus config_generation method Add more virtqueue getter methods 2018-03-14T03:19:51Z Eitan Adler eadler@FreeBSD.org 2018-03-14T03:19:51Z urn:sha1:be5d0b9566b13fdf8cabebb63334cbec12bfc409 These changes are incomplete but are making it difficult to determine what other changes can/should be merged. No objections from: pfg 2017-03-23T06:40:20Z Alexander Motin mav@FreeBSD.org 2017-03-23T06:40:20Z urn:sha1:6352900b3df2d8e5409dbf52d6b3d6c494817605 Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name) The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are fixed-length strings. AFAICT the only place they're read is in sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated. However, the kernel doesn't null-terminate them. A bunch of copy-pasted code uses strncpy to write them, and doesn't guarantee null-termination. For at least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually overflows. You can see the result by doing "camcontrol negotiate da0 -v". This change null-terminates those fields everywhere they're set in the kernel. It also shortens a few strings to ensure they'll fit within the 16-character field. PR: 215474 Reported by: Coverity CID: 1009997 1010000 1010001 1010002 1010003 1010004 1010005 CID: 1331519 1010006 1215097 1010007 1288967 1010008 1306000 CID: 1211924 1010009 1010010 1010011 1010012 1010013 1010014 CID: 1147190 1010017 1010016 1010018 1216435 1010020 1010021 CID: 1010022 1009666 1018185 1010023 1010025 1010026 1010027 CID: 1010028 1010029 1010030 1010031 1010033 1018186 1018187 CID: 1010035 1010036 1010042 1010041 1010040 1010039 2016-12-14T16:44:33Z Andriy Gapon avg@FreeBSD.org 2016-12-14T16:44:33Z urn:sha1:2df2eada162803d272c197ee031cb3eb0bfc8320 2016-08-14T00:40:17Z Steven Hartland smh@FreeBSD.org 2016-08-14T00:40:17Z urn:sha1:c54cc95cd3608fd970a85aab345f69ba9a7ed4a6 Fix vtnet hang with max_virtqueue_pairs > VTNET_MAX_QUEUE_PAIRS Sponsored by: Multiplay