src-test2/sys/dev, branch release/11.4.0

Fix USB HID descriptor parsing error.

2020-06-09T16:13:54Z

Approved by: so Approved by: re (implicit) Security: FreeBSD-SA-20:17.usb Security: CVE-2020-7456

MF11: r361467-361468,361534

2020-05-26T22:41:12Z

This patch upgrades the ENA driver to version 2.2.0. Approved by: re (gjb) Sponsored by: Amazon, Inc.

MFC r361276, r361276:

2020-05-23T18:03:19Z

mlx5_core: add new port module event types to decode. Sponsored by: Mellanox Technologies Approved by: re (delphij)

MF11 361044,361048: Deprecate ubsec(4) for FreeBSD 13.0.

2020-05-14T19:29:08Z

With the removal of in-tree consumers of DES, Triple DES, and MD5-HMAC, the only algorithm this driver still supports is SHA1-HMAC. This is not very useful as a standalone algorithm (IPsec AH-only with SHA1 would be the only user). This driver has also not been kept up to date with the original driver in OpenBSD which supports a few more cards and AES-CBC on newer cards. The newest card currently supported by this driver was released in 2005. Approved by: re (gjb) Relnotes: yes

MF11 361038,361040: Don't dereference various user pointers.

2020-05-14T18:50:43Z

360171: Don't access a user buffer directly from the kernel. The handle_string callback for the ENCIOC_SETSTRING ioctl was passing a user pointer to memcpy(). Fix by using copyin() instead. For ENCIOC_GETSTRING ioctls, the handler was storing the user pointer in a CCB's data_ptr field where it was indirected by other code. Fix this by allocating a temporary buffer (which ENCIOC_SETSTRING already did) and copying the result out to the user buffer after the CCB has been processed. 360179: Don't pass a user buffer pointer as the data pointer in a CCB. Allocate a temporary buffer in the kernel to serve as the CCB data pointer for a pass-through transaction and use copyin/copyout to shuffle the data to/from the user buffer. 360285: Don't indirect user pointers directly in two 802.11s ioctls. IEEE80211_MESH_RTCMD_ADD was invoking memcmp() to validate the supplied address directly on the user pointer rather than first doing a copyin() and validating the copied value. IEEE80211_MESH_RTCMD_DELETE was passing the user pointer directly to ieee80211_mesh_rt_del() rather than copying the user buffer into a temporary kernel buffer. 360388: Don't run strcmp() against strings stored in user memory. Instead, copy the strings into a temporary buffer on the stack and run strcmp on the copies. 360818: Fix a memory leak for ENCIOC_GETSTRING I introduced in r360171. Approved by: re (gjb)

MF11 r360782:

2020-05-08T18:16:53Z

MFC r306679 (by glebius): Fix indentation. CID: 1363671 Approved by: re (gjb)

Fix misleading indentation warning:

2020-05-07T08:22:47Z

sys/dev/vxge/vxgehal/vxgehal-virtualpath.c:5550:6: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation] return (VXGE_HAL_ERR_EVENT_MRPCIM_CRITICAL); ^ sys/dev/vxge/vxgehal/vxgehal-virtualpath.c:5545:5: note: previous statement is here if (!skip_alarms) ^ Direct commit to stable/11, since vxge(4) has been removed from FreeBSD 12 and later.

Fix misleading indentation warning:

2020-05-06T17:44:17Z

sys/dev/urtwn/if_urtwn.c:4183:4: error: misleading indentation; statement is not part of the previous 'for' [-Werror,-Wmisleading-indentation] if (error != USB_ERR_NORMAL_COMPLETION) ^ sys/dev/urtwn/if_urtwn.c:4180:3: note: previous statement is here for (i = 0; i < nitems(rtl8192cu_mac); i++) ^ Direct commit to stable/11, since urtwn(4) has been merged into rtwn(4) in FreeBSD 12 and later (and this code is not in rtwn).

Fix misleading indentation warning:

2020-05-06T17:35:42Z

sys/dev/nxge/xgehal/xgehal-mgmt.c:1743:6: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation] addr = 0xA074; ^ sys/dev/nxge/xgehal/xgehal-mgmt.c:1736:2: note: previous statement is here if(CHECKBIT(val_1, 0x0)) ^ Direct commit to stable/11, since nxge(4) has been removed from FreeBSD 12 and later.

MFC r318297 (by tsoome):

2020-05-06T11:10:13Z

e1000api: misleading-indentation Two blocks in e1000_ich8lan.c are misaligned, causing noise with some compilers (gcc 6). Reviewed by: imp, erj Differential Revision: https://reviews.freebsd.org/D10741