FreeBSD source tree https://cgit-dev.freebsd.org/src-test2/atom?h=releng%2F11.2 2018-04-01T16:43:30Z 2018-04-01T16:43:30Z Mark Johnston markj@FreeBSD.org 2018-04-01T16:43:30Z urn:sha1:ed042408fd3a0f85072ffe5a5e97c965c8355d81 netsmb: Fix buggy/racy smb_strdupin() PR: 222687 2018-03-29T02:50:57Z Eitan Adler eadler@FreeBSD.org 2018-03-29T02:50:57Z urn:sha1:4ab2e064d7950be84256d671a7ae93f87cc6aa36 This was intended to be a non-functional change. It wasn't. The commit message was thus wrong. In addition it broke arm, and merged crypto related code. Revert with prejudice. This revert skips files touched in r316370 since that commit was since MFCed. This revert also skips files that require $FreeBSD$ property changes. Thank you to those who helped me get out of this mess including but not limited to gonzo, kevans, rgrimes. Requested by: gjb (re) 2018-03-14T03:19:51Z Eitan Adler eadler@FreeBSD.org 2018-03-14T03:19:51Z urn:sha1:be5d0b9566b13fdf8cabebb63334cbec12bfc409 These changes are incomplete but are making it difficult to determine what other changes can/should be merged. No objections from: pfg 2016-05-03T18:05:43Z Pedro F. Giffuni pfg@FreeBSD.org 2016-05-03T18:05:43Z urn:sha1:a4641f4eaad242fd40c50e4dd14522aff3494f9a No functional change. 2016-04-20T21:13:24Z Pedro F. Giffuni pfg@FreeBSD.org 2016-04-20T21:13:24Z urn:sha1:a9a25801e81825f58e052af0d37d6ef46dde559c Found by: jhb 2016-04-19T23:48:27Z Pedro F. Giffuni pfg@FreeBSD.org 2016-04-19T23:48:27Z urn:sha1:02abd40029ea0d6cbb65cbb70816266541fb45a2 No functional change, only trivial cases are done in this sweep, Discussed in: freebsd-current 2016-04-10T23:07:00Z Pedro F. Giffuni pfg@FreeBSD.org 2016-04-10T23:07:00Z urn:sha1:74b8d63dcc17c07d8cb21e13f6db517698efd49f Found with devel/coccinelle. 2015-11-18T23:04:01Z Rick Macklem rmacklem@FreeBSD.org 2015-11-18T23:04:01Z urn:sha1:69527b11bb5e1bb234a29eed864896cb1a13d652 trying to do a mount. Given the backtrace, it appears that the crash occurred when smb_vc_create() failed and then called smb_vc_put() with vcp->vc_iod == NULL. smb_vc_put() subsequently called smb_vc_disconnect() with vcp->vc_iod == NULL, causing the crash. This patch adds a check for vcp->vc_iod != NULL in smb_vc_disconnect() to avoid the crash. It also fixes the case in smb_vc_create() where kproc_create() fails so that it destroys the mutexes and sets vcp->vc_iod == NULL before free()'ing the iod structure. The person who reported the PR tested the patch, but was not able to reproduce the crash with or without the patch. PR: 201912 Reviewed by: jhb MFC after: 2 weeks 2015-11-16T23:19:53Z Rick Macklem rmacklem@FreeBSD.org 2015-11-16T23:19:53Z urn:sha1:e06f502c9e76b300c1844c1c6e0af103751f6c12 would call smb_iod_request(). This call could return as soon as the wakeup(evp) in smb_iod_main() call is done and then could destroy the mutexes. This caused a race with the rest of smb_iod_main()s use of these mutexes. A crash reported on freebsd-stable@ by Christian Kratzer was diagnosed as a use of one of these mutexes after it was destroyed. This patch moves destruction of the mutexes from smb_iod_destroy() to the end of smb_iod_thread(), so that they aren't destroyed before the thread is done with them. Christian comfirmed that the patch stopped the crashes from happening. Reported by: ck-lists@cksoft.de (Christian Kratzer) Tested by: ck-lists@cksoft.de (Christian Kratzer) Diagnosed by: jhb Reviewed by: jhb MFC after: 2 weeks 2014-04-17T12:22:08Z Andrey V. Elsukov ae@FreeBSD.org 2014-04-17T12:22:08Z urn:sha1:99143cd46cee62bb7cdaea65e72d31e9bd07136c This code was removed from the opensolaris and darwin's netsmb implementations, in DfBSD it also has been disabled. PR: 36566, 87859, 139407, 161579, 175557, 178412, 186652 MFC after: 2 weeks Sponsored by: Yandex LLC