summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorColin Percival <cperciva@FreeBSD.org>2004-03-17 09:37:13 +0000
committerColin Percival <cperciva@FreeBSD.org>2004-03-17 09:37:13 +0000
commit018e32c194500f646f74fee2263de320553fa771 (patch)
treedf5a6d87e2c0322267422d72b40429e83823c8f2
parentd67e2df265f7e89981c41cae65c6b27fc464a009 (diff)
Notes
-rw-r--r--sys/kern/sysv_sem.c18
1 files changed, 12 insertions, 6 deletions
diff --git a/sys/kern/sysv_sem.c b/sys/kern/sysv_sem.c
index e07e632d8af4..1cd6e1bb0eac 100644
--- a/sys/kern/sysv_sem.c
+++ b/sys/kern/sysv_sem.c
@@ -1040,12 +1040,7 @@ semop(td, uap)
error = msleep(semaptr, sema_mtxp, (PZERO - 4) | PCATCH,
"semwait", 0);
DPRINTF(("semop: good morning (error=%d)!\n", error));
-
- if (error != 0) {
- error = EINTR;
- goto done2;
- }
- DPRINTF(("semop: good morning!\n"));
+ /* return code is checked below, after sem[nz]cnt-- */
/*
* Make sure that the semaphore still exists
@@ -1064,6 +1059,17 @@ semop(td, uap)
semptr->semzcnt--;
else
semptr->semncnt--;
+
+ /*
+ * Is it really morning, or was our sleep interrupted?
+ * (Delayed check of msleep() return code because we
+ * need to decrement sem[nz]cnt either way.)
+ */
+ if (error != 0) {
+ error = EINTR;
+ goto done2;
+ }
+ DPRINTF(("semop: good morning!\n"));
}
done: