summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRebecca Cran <brucec@FreeBSD.org>2010-08-07 12:51:44 +0000
committerRebecca Cran <brucec@FreeBSD.org>2010-08-07 12:51:44 +0000
commit0d3b069a8723cefecf6c42b63912c915a1136dfd (patch)
tree56e0f1f8ab6da00b8541ffb915e7338bab28330b
parent89dc1abf71dc6567d246ae5351e996a70354ae05 (diff)
Notes
-rw-r--r--usr.sbin/sysinstall/dist.c22
-rw-r--r--usr.sbin/sysinstall/install.c6
2 files changed, 19 insertions, 9 deletions
diff --git a/usr.sbin/sysinstall/dist.c b/usr.sbin/sysinstall/dist.c
index cf5566f4c103..31c596da7c93 100644
--- a/usr.sbin/sysinstall/dist.c
+++ b/usr.sbin/sysinstall/dist.c
@@ -613,7 +613,7 @@ getinfo:
if (fp == NULL)
msgConfirm("Failed to find %s on this media. Reinitializing media.", fname);
else
- msgConfirm("Failed to retreive piece file %s.\n"
+ msgConfirm("Failed to retrieve piece file %s.\n"
"%s: Reinitializing media.",
fname, !intr ? "I/O error" : "User interrupt");
DEVICE_SHUTDOWN(mediaDevice);
@@ -709,6 +709,7 @@ distExtract(char *parent, Distribution *me)
char *path, *dist;
WINDOW *w = savescr();
struct sigaction old, new;
+ int canceled = 0;
status = TRUE;
if (isDebug())
@@ -723,7 +724,7 @@ distExtract(char *parent, Distribution *me)
sigaction(SIGINT, &new, &old);
/* Loop through to see if we're in our parent's plans */
- for (i = 0; me[i].my_name; i++) {
+ for (i = 0; me[i].my_name && canceled == 0; i++) {
dist = me[i].my_name;
path = parent ? parent : dist;
@@ -758,8 +759,11 @@ distExtract(char *parent, Distribution *me)
status = msgYesNo("Unable to transfer the %s distribution from\n%s.\n\n"
"Do you want to try to retrieve it again?",
me[i].my_name, mediaDevice->name);
- if (!status)
+ if (status == 0)
--i;
+ else
+ canceled = 1;
+
status = FALSE;
}
}
@@ -773,6 +777,7 @@ distExtract(char *parent, Distribution *me)
if (status)
*(me[i].my_mask) &= ~(me[i].my_bit);
}
+
sigaction(SIGINT, &old, NULL); /* Restore signal handler */
restorescr(w);
return status;
@@ -865,8 +870,9 @@ printSelected(char *buf, int selected, Distribution *me, int *col)
int
distExtractAll(dialogMenuItem *self)
{
- int old_dists, old_kernel, retries = 0, status = DITEM_SUCCESS;
+ int old_dists, old_kernel, status = DITEM_SUCCESS;
char buf[512];
+ int extract_status = TRUE;
WINDOW *w;
/* paranoia */
@@ -886,9 +892,7 @@ distExtractAll(dialogMenuItem *self)
w = savescr();
msgNotify("Attempting to install all selected distributions..");
- /* Try for 3 times around the loop, then give up. */
- while (Dists && ++retries < 3)
- distExtract(NULL, DistTable);
+ extract_status = distExtract(NULL, DistTable);
dialog_clear_norefresh();
/* Only do base fixup if base dist was successfully extracted */
@@ -915,5 +919,9 @@ distExtractAll(dialogMenuItem *self)
}
}
restorescr(w);
+
+ if (extract_status == FALSE)
+ status = DITEM_FAILURE;
+
return status;
}
diff --git a/usr.sbin/sysinstall/install.c b/usr.sbin/sysinstall/install.c
index 003271763a2e..642cea016da0 100644
--- a/usr.sbin/sysinstall/install.c
+++ b/usr.sbin/sysinstall/install.c
@@ -676,8 +676,7 @@ nodisks:
msgConfirm("Installation completed with some errors. You may wish to\n"
"scroll through the debugging messages on VTY1 with the\n"
"scroll-lock feature. You can also choose \"No\" at the next\n"
- "prompt and go back into the installation menus to retry\n"
- "whichever operations have failed.");
+ "prompt and reboot and try the installation again.");
return i;
}
@@ -853,6 +852,9 @@ try_media:
/* Now go get it all */
i = distExtractAll(self);
+ if (i == FALSE)
+ return FALSE;
+
/* When running as init, *now* it's safe to grab the rc.foo vars */
installEnvironment();