diff options
| author | David Xu <davidxu@FreeBSD.org> | 2003-04-21 14:42:04 +0000 |
|---|---|---|
| committer | David Xu <davidxu@FreeBSD.org> | 2003-04-21 14:42:04 +0000 |
| commit | 11b20c685b3e8ddbaf035ea6f1fbecaf161c7c70 (patch) | |
| tree | 3883b3769c9c6154638adbf188670165e4bc9b34 | |
| parent | d3fc864f930c2f65179c12d879590714155ca16c (diff) | |
Notes
| -rw-r--r-- | sys/kern/kern_exit.c | 2 | ||||
| -rw-r--r-- | sys/kern/kern_kse.c | 5 | ||||
| -rw-r--r-- | sys/kern/kern_thread.c | 5 |
3 files changed, 4 insertions, 8 deletions
diff --git a/sys/kern/kern_exit.c b/sys/kern/kern_exit.c index 0339bb613c3e..187364b72ab0 100644 --- a/sys/kern/kern_exit.c +++ b/sys/kern/kern_exit.c @@ -137,9 +137,7 @@ exit1(struct thread *td, int rv) * First check if some other thread got here before us.. * if so, act apropriatly, (exit or suspend); */ - DROP_GIANT(); thread_suspend_check(0); - PICKUP_GIANT(); /* * Kill off the other threads. This requires diff --git a/sys/kern/kern_kse.c b/sys/kern/kern_kse.c index 18c097f1f936..6ccb19c528eb 100644 --- a/sys/kern/kern_kse.c +++ b/sys/kern/kern_kse.c @@ -1867,13 +1867,12 @@ thread_single(int force_exit) * In the mean time we suspend as well. */ thread_suspend_one(td); - /* XXX If you recursed this is broken. */ - mtx_unlock(&Giant); + DROP_GIANT(); PROC_UNLOCK(p); p->p_stats->p_ru.ru_nvcsw++; mi_switch(); mtx_unlock_spin(&sched_lock); - mtx_lock(&Giant); + PICKUP_GIANT(); PROC_LOCK(p); } if (force_exit == SINGLE_EXIT) { diff --git a/sys/kern/kern_thread.c b/sys/kern/kern_thread.c index 18c097f1f936..6ccb19c528eb 100644 --- a/sys/kern/kern_thread.c +++ b/sys/kern/kern_thread.c @@ -1867,13 +1867,12 @@ thread_single(int force_exit) * In the mean time we suspend as well. */ thread_suspend_one(td); - /* XXX If you recursed this is broken. */ - mtx_unlock(&Giant); + DROP_GIANT(); PROC_UNLOCK(p); p->p_stats->p_ru.ru_nvcsw++; mi_switch(); mtx_unlock_spin(&sched_lock); - mtx_lock(&Giant); + PICKUP_GIANT(); PROC_LOCK(p); } if (force_exit == SINGLE_EXIT) { |