summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPoul-Henning Kamp <phk@FreeBSD.org>2002-10-16 10:40:43 +0000
committerPoul-Henning Kamp <phk@FreeBSD.org>2002-10-16 10:40:43 +0000
commit8b7f9bdcdf76e05ec93a8271e82606a730541e94 (patch)
tree9566edc4ba7c230420b2caecd4f96bbade8e9416
parent633eb1fc9eaad65884cc8475c7c9f0ac823cbb5b (diff)
Notes
-rw-r--r--sys/isa/pnp.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/sys/isa/pnp.c b/sys/isa/pnp.c
index 08b614c21b36..1007886f4f6b 100644
--- a/sys/isa/pnp.c
+++ b/sys/isa/pnp.c
@@ -639,6 +639,10 @@ pnp_create_devices(device_t parent, pnp_id *p, int csn,
* bytes already in the buffer should be passed in '*lenp'. The memory
* allocated will be returned in '*resourcesp' with its size and the
* number of bytes of resources in '*spacep' and '*lenp' respectively.
+ *
+ * XXX: Multiple problems here, we forget to free() stuff in one
+ * XXX: error return, and in another case we free (*resourcesp) but
+ * XXX: don't tell the caller.
*/
static int
pnp_read_bytes(int amount, u_char **resourcesp, int *spacep, int *lenp)