summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSam Leffler <sam@FreeBSD.org>2005-03-31 21:58:53 +0000
committerSam Leffler <sam@FreeBSD.org>2005-03-31 21:58:53 +0000
commitaa083c3dc60a3ad93fc8e855b74d1597066b53e3 (patch)
treea6b1d8060355cb77dd47044c11b0ddc3df17d831
parent23691262f00a502ab508bb65cae83885dd997d7e (diff)
Notes
-rw-r--r--sys/dev/mlx/mlx.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/sys/dev/mlx/mlx.c b/sys/dev/mlx/mlx.c
index 844a265bbac6..dcee43c6576c 100644
--- a/sys/dev/mlx/mlx.c
+++ b/sys/dev/mlx/mlx.c
@@ -1983,8 +1983,10 @@ mlx_user_command(struct mlx_softc *sc, struct mlx_usercommand *mu)
* initial contents
*/
if (mu->mu_datasize > 0) {
- if (mu->mu_datasize > MAXPHYS)
- return (EINVAL);
+ if (mu->mu_datasize > MAXPHYS) {
+ error = EINVAL;
+ goto out;
+ }
if (((kbuf = malloc(mu->mu_datasize, M_DEVBUF, M_WAITOK)) == NULL) ||
(error = copyin(mu->mu_buf, kbuf, mu->mu_datasize)))
goto out;