summaryrefslogtreecommitdiff
path: root/sys/dev/random
diff options
context:
space:
mode:
authorDag-Erling Smørgrav <des@FreeBSD.org>2014-11-02 02:01:55 +0000
committerDag-Erling Smørgrav <des@FreeBSD.org>2014-11-02 02:01:55 +0000
commit8c9ba8414c3bfbea7a47bb64710720c8904cc2c3 (patch)
tree61141ac6cdb1d15a5dd5adee6f01bd61dce121ad /sys/dev/random
parent7417198fcf8ee28079f8d31248f677dc0ad9b741 (diff)
Notes
Diffstat (limited to 'sys/dev/random')
-rw-r--r--sys/dev/random/random_adaptors.c29
-rw-r--r--sys/dev/random/yarrow.c2
2 files changed, 5 insertions, 26 deletions
diff --git a/sys/dev/random/random_adaptors.c b/sys/dev/random/random_adaptors.c
index c58f929e5acf..76d2c3e0c3e6 100644
--- a/sys/dev/random/random_adaptors.c
+++ b/sys/dev/random/random_adaptors.c
@@ -447,30 +447,8 @@ random_adaptors_deinit(void)
}
/*
- * First seed.
- *
- * NB! NB! NB!
- * NB! NB! NB!
- *
- * It turns out this is bloody dangerous. I was fiddling with code elsewhere
- * and managed to get conditions where a safe (i.e. seeded) entropy device should
- * not have been possible. This managed to hide that by unblocking the device anyway.
- * As crap randomness is not directly distinguishable from good randomness, this
- * could have gone unnoticed for quite a while.
- *
- * NB! NB! NB!
- * NB! NB! NB!
- *
- * Very luckily, the probe-time entropy is very nearly good enough to cause a
- * first seed all of the time, and the default settings for other entropy
- * harvesting causes a proper, safe, first seed (unblock) in short order after that.
- *
- * That said, the below would be useful where folks are more concerned with
- * a quick start than with extra paranoia in a low-entropy environment.
- *
- * markm - October 2013.
+ * Reseed the active adaptor shortly before starting init(8).
*/
-#ifdef RANDOM_AUTOSEED
/* ARGSUSED */
static void
random_adaptors_seed(void *unused __unused)
@@ -484,6 +462,5 @@ random_adaptors_seed(void *unused __unused)
arc4rand(NULL, 0, 1);
}
-SYSINIT(random_seed, SI_SUB_INTRINSIC_POST, SI_ORDER_LAST,
- random_adaptors_reseed, NULL);
-#endif /* RANDOM_AUTOSEED */
+SYSINIT(random_seed, SI_SUB_KTHREAD_INIT, SI_ORDER_FIRST,
+ random_adaptors_seed, NULL);
diff --git a/sys/dev/random/yarrow.c b/sys/dev/random/yarrow.c
index a8da20a93bf3..d6905e89e192 100644
--- a/sys/dev/random/yarrow.c
+++ b/sys/dev/random/yarrow.c
@@ -508,7 +508,9 @@ void
random_yarrow_reseed(void)
{
+ mtx_lock(&random_reseed_mtx);
reseed(SLOW);
+ mtx_unlock(&random_reseed_mtx);
}
int