summaryrefslogtreecommitdiff
path: root/sys/netinet6
diff options
context:
space:
mode:
authorMark Johnston <markj@FreeBSD.org>2020-03-31 02:25:53 +0000
committerMark Johnston <markj@FreeBSD.org>2020-03-31 02:25:53 +0000
commit431f2b8712e950e4507eae618b233c45f784ccd9 (patch)
treeac89d3d48e03cddcea0bd314f9183d8a58918f16 /sys/netinet6
parentadc03881170952d5fde1df538193bc75fd07ea0b (diff)
downloadsrc-test2-431f2b8712e950e4507eae618b233c45f784ccd9.tar.gz
src-test2-431f2b8712e950e4507eae618b233c45f784ccd9.zip
Notes
Diffstat (limited to 'sys/netinet6')
-rw-r--r--sys/netinet6/in6_mcast.c13
1 files changed, 9 insertions, 4 deletions
diff --git a/sys/netinet6/in6_mcast.c b/sys/netinet6/in6_mcast.c
index 9a0678f50470..28a7fdfe638d 100644
--- a/sys/netinet6/in6_mcast.c
+++ b/sys/netinet6/in6_mcast.c
@@ -510,14 +510,19 @@ in6m_release(struct in6_multi *inm)
}
}
-static struct task free_task;
+/*
+ * Interface detach can happen in a taskqueue thread context, so we must use a
+ * dedicated thread to avoid deadlocks when draining in6m_release tasks.
+ */
+TASKQUEUE_DEFINE_THREAD(in6m_free);
+static struct task in6m_free_task;
static struct in6_multi_head in6m_free_list = SLIST_HEAD_INITIALIZER();
static void in6m_release_task(void *arg __unused, int pending __unused);
static void
in6m_init(void)
{
- TASK_INIT(&free_task, 0, in6m_release_task, NULL);
+ TASK_INIT(&in6m_free_task, 0, in6m_release_task, NULL);
}
SYSINIT(in6m_init, SI_SUB_TASKQ, SI_ORDER_ANY, in6m_init, NULL);
@@ -529,13 +534,13 @@ in6m_release_list_deferred(struct in6_multi_head *inmh)
mtx_lock(&in6_multi_free_mtx);
SLIST_CONCAT(&in6m_free_list, inmh, in6_multi, in6m_nrele);
mtx_unlock(&in6_multi_free_mtx);
- taskqueue_enqueue(taskqueue_thread, &free_task);
+ taskqueue_enqueue(taskqueue_in6m_free, &in6m_free_task);
}
void
in6m_release_wait(void)
{
- taskqueue_drain_all(taskqueue_thread);
+ taskqueue_drain_all(taskqueue_in6m_free);
}
void