diff options
| author | Eitan Adler <eadler@FreeBSD.org> | 2012-10-22 03:07:05 +0000 |
|---|---|---|
| committer | Eitan Adler <eadler@FreeBSD.org> | 2012-10-22 03:07:05 +0000 |
| commit | 50e04779c499d5c329d1863b71ecd7c2b5824f76 (patch) | |
| tree | 90ec7fe4bf0dae506d699603babb4917082f098a /usr.bin/lock | |
| parent | c969ca9408ebdda12176a10520a73ea4f7a3c23c (diff) | |
| download | src-test2-50e04779c499d5c329d1863b71ecd7c2b5824f76.tar.gz src-test2-50e04779c499d5c329d1863b71ecd7c2b5824f76.zip | |
Check the return error of set[e][ug]id. While this can never fail in the
current version of FreeBSD, this isn't guarenteed by the API.
Custom security modules, or future implementations of the setuid and
setgid may fail.
Submitted by: Erik Cederstrand
Approved by: cperciva
MFC after: 3 days
Notes
Notes:
svn path=/head/; revision=241848
Diffstat (limited to 'usr.bin/lock')
| -rw-r--r-- | usr.bin/lock/lock.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/usr.bin/lock/lock.c b/usr.bin/lock/lock.c index 0382e831862c..acc0e29d62d8 100644 --- a/usr.bin/lock/lock.c +++ b/usr.bin/lock/lock.c @@ -129,7 +129,9 @@ main(int argc, char **argv) } timeout.tv_sec = sectimeout * 60; - setuid(getuid()); /* discard privs */ + /* discard privs */ + if (setuid(getuid()) != 0) + errx(1, "setuid failed"); if (tcgetattr(0, &tty)) /* get information for header */ exit(1); |