diff options
| author | Conrad Meyer <cem@FreeBSD.org> | 2018-02-16 20:46:44 +0000 |
|---|---|---|
| committer | Conrad Meyer <cem@FreeBSD.org> | 2018-02-16 20:46:44 +0000 |
| commit | 9531d560cfc98948c8462b2cc0a5aee7ac3d8d6d (patch) | |
| tree | a1968e99322e54f939b1b315e61d2d286cc7d76c /usr.sbin/trpt | |
| parent | 954b921d6615024563b189027bcc5e3c737c328b (diff) | |
| download | src-test2-9531d560cfc98948c8462b2cc0a5aee7ac3d8d6d.tar.gz src-test2-9531d560cfc98948c8462b2cc0a5aee7ac3d8d6d.zip | |
trpt(8): Clean up build hack to detect ancient compiler
Detect ancient GCC specifically, rather than using target architecture as a
crude heuristic.
Side note: compilers should really ignore -Wno- and -Wno-error= flags they
don't recognize. Seems like modern compilers produce warnings instead of
errors. Though, with -Werror they turn into errors. Clang's error can be
disabled with -Wno-error=unknown-warning-option, but GCC doesn't seem to
have a named method to disable the specific warning.
Submitted by: rpokala@ (earlier version)
Suggested by: rpokala@
Reviewed by: tinderbox
Sponsored by: Dell EMC Isilon
Notes
Notes:
svn path=/head/; revision=329411
Diffstat (limited to 'usr.sbin/trpt')
| -rw-r--r-- | usr.sbin/trpt/Makefile | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/usr.sbin/trpt/Makefile b/usr.sbin/trpt/Makefile index 53c1660f2b25..4756cb1a0d03 100644 --- a/usr.sbin/trpt/Makefile +++ b/usr.sbin/trpt/Makefile @@ -8,8 +8,7 @@ MAN= trpt.8 BINGRP= kmem BINMODE= 2555 -.if ${MACHINE_CPUARCH} != "aarch64" && ${MACHINE_CPUARCH} != "amd64" && \ - ${MACHINE_CPUARCH} != "i386" && ${MACHINE_CPUARCH} != "riscv" +.if ${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} < 50000 WARNS?= 4 .endif @@ -19,8 +18,7 @@ CFLAGS+= -DINET6 .include <bsd.prog.mk> -.if ${MACHINE_CPUARCH} == "aarch64" || ${MACHINE_CPUARCH} == "amd64" || \ - ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "riscv" +.if ${COMPILER_TYPE} != "gcc" || ${COMPILER_VERSION} >= 50000 # Several included system headers tickle this warning in ways that are # difficult to work around in this program. CFLAGS+= -Wno-missing-variable-declarations |