summaryrefslogtreecommitdiff
path: root/lib/libforms/bindings.c
diff options
context:
space:
mode:
Diffstat (limited to 'lib/libforms/bindings.c')
-rw-r--r--lib/libforms/bindings.c12
1 files changed, 4 insertions, 8 deletions
diff --git a/lib/libforms/bindings.c b/lib/libforms/bindings.c
index 4ebdd8d99b73..947b5ee47bdd 100644
--- a/lib/libforms/bindings.c
+++ b/lib/libforms/bindings.c
@@ -45,12 +45,6 @@ bind_tuple(hash_table *htable, char *name,
{
struct Tuple *tuple;
- /* First check to see if we've been bound in already */
- if (hash_search(htable, tuple->name, NULL, NULL)) {
- warn("Duplicate tuple name, %s, skipping", name);
- return (ST_ERROR);
- }
-
tuple = malloc(sizeof (struct Tuple));
if (!tuple) {
warn("Couldn't allocate memory for new tuple");
@@ -61,8 +55,10 @@ bind_tuple(hash_table *htable, char *name,
tuple->type = type;
tuple->addr = fn;
- /* Insert it */
- hash_search(htable, tuple->name, tuple, NULL);
+ if (hash_search(htable, tuple->name, tuple, NULL)) {
+ warn("Duplicate tuple name, %s, skipping", name);
+ return (ST_ERROR);
+ }
#ifdef DEBUG
debug_dump_table(htable);