summaryrefslogtreecommitdiff
path: root/sys/kern/vfs_subr.c
Commit message (Collapse)AuthorAgeFilesLines
* In vfs_kqfilter(), return EINVAL instead of 1 (EPERM) when an unsupportedRobert Watson2005-09-121-1/+1
| | | | | | | | | kqueue filter type is requested on a vnode. MFC after: 3 days Notes: svn path=/head/; revision=150062
* use monotonic `time_uptime' instead of `time_second'Jung-uk Kim2005-09-121-4/+4
| | | | | | | | Approved by: anholt (mentor) Discussed on: arch Notes: svn path=/head/; revision=150047
* Introduce vfs_read_dirent() which can help VOP_READDIR() implementationsPoul-Henning Kamp2005-09-121-0/+27
| | | | | | | by handling all the cookie stuff. Notes: svn path=/head/; revision=150020
* Fix a typo in vop_rename_pre() where we ended up using vholdl()Suleiman Souhlal2005-08-281-1/+1
| | | | | | | | | instead of vhold(), even though the vnode interlock is unlocked. MFC after: 3 days Notes: svn path=/head/; revision=149557
* Back out the removal of LK_NOWAIT from the VOP_LOCK() call inDon Lewis2005-08-231-7/+37
| | | | | | | | | | | | | | | | | | | | | vlrureclaim() in vfs_subr.c 1.636 because waiting for the vnode lock aggravates an existing race condition. It is also undesirable according to the commit log for 1.631. Fix the tiny race condition that remains by rechecking the vnode state after grabbing the vnode lock and grabbing the vnode interlock. Fix the problem of other threads being starved (which 1.636 attempted to fix by removing LK_NOWAIT) by calling uio_yield() periodically in vlrureclaim(). This should be more deterministic than hoping that VOP_LOCK() without LK_NOWAIT will block, which may not happen in this loop. Reviewed by: kan MFC after: 5 days Notes: svn path=/head/; revision=149385
* Silence "busy" warnings when unmounting devfs at system shutdown. ThisRobert Watson2005-08-201-6/+16
| | | | | | | | | | | | | | | is a workaround for non-symetric teardown of the file systems at shutdown with respect to the mount order at boot. The proper long term fix is to properly detach devfs from the root mount before unmounting each, and should be implemented, but since the problem is non-harmful, this temporary band-aid will prevent false positive bug reports and unnecessary error output for 6.0-RELEASE. MFC after: 3 days Tested by: pav, pjd Notes: svn path=/head/; revision=149340
* Make mpsafe_vfs=1 the default on ia64.Marcel Moolenaar2005-08-131-1/+2
| | | | Notes: svn path=/head/; revision=149034
* Do not drop the vnode interlock if vdropl is called on already doomed vnode.Alexander Kabaev2005-08-101-3/+1
| | | | | | | | | vdropl callers expect it to return with interlock still being held. MFC after: 2 days Notes: svn path=/head/; revision=148922
* Holding a vnode doesn't prevent v_mount from disappearing (when theSuleiman Souhlal2005-08-061-0/+2
| | | | | | | | | | | | | | | vnode is inactivated), possibly leading to a NULL dereference when checking if the mount wants knotes to be activated in the VOP hooks. So, we add a new vnode flag VV_NOKNOTE that is only set in getnewvnode(), if necessary, and check it when activating knotes. Since the flags are not erased when a vnode is being held, we can safely read them. Reviewed by: kris@ MFC after: 3 days Notes: svn path=/head/; revision=148768
* - Unlock before we call mac_destroy_vnode to prevent a lock order reversal.Jeff Roberson2005-08-031-0/+1
| | | | | | | Found by: trhodes Notes: svn path=/head/; revision=148671
* - Allow vnlru to drop giant if the filesystem does not require it. TheJeff Roberson2005-07-201-2/+11
| | | | | | | | | | | | | | | | | vnlru proc is extremely inefficient, potentially iteration over tens of thousands of vnodes without blocking. Droping Giant allows other threads to preempt us although we should revisit the algorithm to fix the runtime problems especially since this may hold up all vnode allocations. - Remove the LK_NOWAIT from the VOP_LOCK in vlrureclaim. This provides a natural blocking point to help alleviate the situation described above although it may not technically be desirable. - yield after we make a pass on all mount points to prevent us from blocking other threads which require Giant. MFC after: 2 weeks Notes: svn path=/head/; revision=148167
* Fix one "wrong b_bufobj" panic in reassignbuf() by moving VI_UNLOCK(vp)Pawel Jakub Dawidek2005-07-051-1/+1
| | | | | | | | | | | below KASSERT()s, which means there was no real problem here, we just needed better locking for assertions. OK'ed by: jeff Approved by: re (scottl) Notes: svn path=/head/; revision=147772
* Fix the recent panics/LORs/hangs created by my kqueue commit by:Suleiman Souhlal2005-07-011-23/+49
| | | | | | | | | | | | | | | | | | | | - Introducing the possibility of using locks different than mutexes for the knlist locking. In order to do this, we add three arguments to knlist_init() to specify the functions to use to lock, unlock and check if the lock is owned. If these arguments are NULL, we assume mtx_lock, mtx_unlock and mtx_owned, respectively. - Using the vnode lock for the knlist locking, when doing kqueue operations on a vnode. This way, we don't have to lock the vnode while holding a mutex, in filt_vfsread. Reviewed by: jmg Approved by: re (scottl), scottl (mentor override) Pointyhat to: ssouhlal Will be happy: everyone Notes: svn path=/head/; revision=147730
* - Try to catch the wrong bufobj panics a little earlier. I believe theyJeff Roberson2005-06-181-0/+5
| | | | | | | | | | | | | are actually caused by a buf with both VNCLEAN and VNDIRTY set. In the traces it is clear that the buf is removed from the dirty queue while it is actually on the clean queue which leaves the tail pointer set. Assert that both flags are not set in buf_vlist_add and buf_vlist_remove. Sponsored by: Isilon Systems, Inc. Approved by: re (blanket vfs) Notes: svn path=/head/; revision=147478
* - Change holdcnt use around vnode recycling. We now always keep a holdcntJeff Roberson2005-06-161-202/+198
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ref while we're calling vgone(). This prevents transient refs from re-adding us to the free list. Previously, a vfree() triggered via vinvalbuf() getting rid of all of a vnode's pages could place a partially destructed vnode on the free list where vtryrecycle() could find it. The first call to vtryrecycle would hang up on the vnode lock, but when it failed it would place a now dead vnode onto the free list, and another call to vtryrecycle() would free an already free vnode. There were many complications of having a zero ref count while freeing which can now go away. - Change vdropl() to release the interlock before returning. All callers now respect this, so vdropl() directly frees VI_DOOMED vnodes once the last ref is dropped. This means that we'll never have VI_DOOMED vnodes on the free list. - Seperate v_incr_usecount() into v_incr_usecount(), v_decr_usecount() and v_decr_useonly(). The incr/decr split is so that incr usecount can return with the interlock still held while decr drops the interlock so it can call vdropl() which will potentially free the vnode. The calling function can't drop the lock of an already free'd node. v_decr_useonly() drops a usecount without droping the hold count. This is done so the usecount reaches zero in vput() before we recycle, however the holdcount is still 1 which prevents any new references from placing the vnode back on the free list. - Fix vnlrureclaim() to vhold the vnode since it doesn't do a vget(). We wouldn't want vnlrureclaim() to bump the usecount since this has different semantics. Also change vnlrureclaim() to do a NOWAIT on the vn_lock. When this function runs we're usually in a desperate situation and we wouldn't want to wait for any specific vnode to be released. - Fix a bunch of misc comments to reflect the new behavior. - Add vhold() and vdrop() to vflush() for the same reasons that we do in vlrureclaim(). Previously we held no reference and a vnode could have been freed while we were waiting on the lock. - Get rid of vlruvp() and vfreehead(). Neither are used. vlruvp() should really be rethought before it's reintroduced. - vgonel() always returns with the vnode locked now and never puts the vnode back on a free list. The vnode will be freed as soon as the last reference is released. Sponsored by: Isilon Systems, Inc. Debugging help from: Kris Kennaway, Peter Holm Approved by: re (blanket vfs) Notes: svn path=/head/; revision=147407
* - In reassignbuf() add many asserts to validate the head and tail pointersJeff Roberson2005-06-141-18/+29
| | | | | | | | | | | | | | of the clean and dirty lists. This is in an attempt to catch the wrong bufobj problem sooner. - In vgonel() don't acquire an extra reference in the active case, the vnode lock and VI_DOOMED protect us from recursively cleaning. - Also in vgonel() clean up some stale comments. Sponsored by: Isilon Systems, Inc. Approved by: re (blanket vfs) Notes: svn path=/head/; revision=147387
* - Don't make vgonel() globally visible, we want to change its prototypeJeff Roberson2005-06-131-36/+19
| | | | | | | | | | | | | | | anyway and it's not used outside of vfs_subr.c. - Change vgonel() to accept a parameter which determines whether or not we'll put the vnode on the free list when we're done. - Use the new vgonel() parameter rather than VI_DOOMED to signal our intentions in vtryrecycle(). - In vgonel() return if VI_DOOMED is already set, this vnode has already been reclaimed. Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=147332
* - Add KTR_VFS events to vdestroy, vtruncbuf, vinvalbuf, vfreehead.Jeff Roberson2005-06-131-0/+4
| | | | | | | Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=147327
* - Assert that we're not in the name cache anymore in vdestroy().Jeff Roberson2005-06-111-0/+2
| | | | | | | Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=147297
* - Add KTR_VFS tracing to track the life of vnodes. Eventually KTR_VFSJeff Roberson2005-06-111-1/+20
| | | | | | | | | | | | | events could be added to cover other interesting details. - Add some VNASSERTs to discover places where we access vnodes after they have been uma_zfree'd before we try to free them again. - Add a few more VNASSERTs to vdestroy() to be certain that the vnode is really unused. Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=147290
* Allow EVFILT_VNODE events to work on every filesystem type, not justSuleiman Souhlal2005-06-091-1/+232
| | | | | | | | | | | | | | | | | | UFS by: - Making the pre and post hooks for the VOP functions work even when DEBUG_VFS_LOCKS is not defined. - Moving the KNOTE activations into the corresponding VOP hooks. - Creating a MNTK_NOKNOTE flag for the mnt_kern_flag field of struct mount that permits filesystems to disable the new behavior. - Creating a default VOP_KQFILTER function: vfs_kqfilter() My benchmarks have not revealed any performance degradation. Reviewed by: jeff, bde Approved by: rwatson, jmg (kqueue changes), grehan (mentor) Notes: svn path=/head/; revision=147198
* - Clear OWEINACT prior to calling VOP_INACTIVE to remove the possibilityJeff Roberson2005-06-071-1/+2
| | | | | | | of a vget causing another call to INACTIVE before we're finished. Notes: svn path=/head/; revision=147113
* If we are going toColin Percival2005-05-061-0/+3
| | | | | | | | | | | | | 1. Copy a NULL-terminated string into a fixed-length buffer, and 2. copyout that buffer to userland, we really ought to 0. Zero the entire buffer first. Security: FreeBSD-SA-05:08.kmem Notes: svn path=/head/; revision=145953
* - A vnode may have made its way onto the free list while it was beingJeff Roberson2005-05-031-0/+2
| | | | | | | | | | vgone'd. We must remove it from the freelist before returning in vtryrecycle() or we may get a duplicate free. Reported by: kkenn Notes: svn path=/head/; revision=145822
* Since it is not possible for curthread to be NULL in this context,Christian S.J. Peron2005-05-021-4/+2
| | | | | | | | | | | drop the check+initialization for a straight initialization. Also assert that curthread will never be NULL just to be sure. Discussed with: rwatson, peter MFC after: 1 week Notes: svn path=/head/; revision=145785
* - All buffers should either be clean or dirty. If neither of these flagsJeff Roberson2005-05-011-0/+4
| | | | | | | | | | are set when we attempt to remove a buffer from a queue we should panic. Hopefully this will catch the source of the wrong bufobj panics. Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=145767
* - In vnlru_free() remove the vnode from the free list before we callJeff Roberson2005-04-301-33/+51
| | | | | | | | | | | | | | | vtryrecycle(). We could sometimes get into situations where two threads could try to recycle the same vnode before this. - vtryrecycle() is now responsible for returning the vnode to the free list if it fails and someone else hasn't done it. - Make a new function vfreehead() which moves a vnode to the head of the free list and use it in vgone() to clean up that code a bit. Sponsored by: Isilon Systems, Inc. Reported by: pho, kkenn Notes: svn path=/head/; revision=145697
* - Don't vgonel() via vgone() or vrecycle() if the vnode is already doomed.Jeff Roberson2005-04-271-1/+8
| | | | | | | | | | This fixes forced unmounts via nullfs. Reported by: kkenn Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=145590
* - Stop setting vxthread, we've asserted that it was useless for severalJeff Roberson2005-04-271-2/+0
| | | | | | | weeks now. Notes: svn path=/head/; revision=145588
* - Disable code which allows getnewvnode() to fail. Many ffs_vget() callersJeff Roberson2005-04-221-0/+2
| | | | | | | | | | | do not correctly deal with failures. This presently risks deadlock problems if dependency processing is held up by failures to allocate a vnode, however, this is better than the situation with the failures. Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=145385
* Initialize mountlist_mtx with an MTX_SYSINIT(), we need it to be readyPoul-Henning Kamp2005-04-181-1/+0
| | | | | | | earlier. Notes: svn path=/head/; revision=145249
* - Change vop_lookup_post assertions to reflect recent vfs_lookup changes.Jeff Roberson2005-04-131-12/+2
| | | | | | | Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=145005
* - Enable ASSERT_VOP_ELOCKED and assert_vop_elocked() now that vnode_if.awkJeff Roberson2005-04-111-1/+1
| | | | | | | | | uses it. Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=144908
* - Change the VOP_LOCK UPGRADE in vput() to do a LK_NOWAIT to avoid aJeff Roberson2005-04-111-39/+43
| | | | | | | | | | | | | | | potential lock order reversal. Also, don't unlock the vnode if this fails, lockmgr has already unlocked it for us. - Restructure vget() now that vn_lock() does all of VI_DOOMED checking for us and also handles the case where there is no real lock type. - If VI_OWEINACT is set, we need to upgrade the lock request to EXCLUSIVE so that we can call inactive. It's not legal to vget a vnode that hasn't had INACTIVE called yet. Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=144900
* - Assert that the bufobj matches in flushbuflists. I still haven't gottenJeff Roberson2005-04-061-0/+3
| | | | | | | | | | | | | to root cause on exactly how this happens. - If the assert is disabled, we presently try to handle this case, but the BUF_UNLOCK was missing. Thus, if this condition ever hit we would leak a buf lock. Many thanks to Peter Holm for all his help in finding this bug. He really put more effort into it than I did. Notes: svn path=/head/; revision=144704
* - Move NDFREE() from vfs_subr to vfs_lookup where namei() is.Jeff Roberson2005-04-051-38/+0
| | | | Notes: svn path=/head/; revision=144661
* - Add a missing unlock of the vnode_free_list_mtx.Jeff Roberson2005-04-041-1/+3
| | | | | | | Spotted by: Antoine Brodin Notes: svn path=/head/; revision=144625
* - Instead of waiting forever to get a vnode in getnewvnode() wait forJeff Roberson2005-04-041-1/+3
| | | | | | | | | | | | | one to become available for one second and then return ENFILE. We can run out of vnodes, and there must be a hard limit because without one we can quickly run out of KVA on x86. Presently the system can deadlock if there are maxvnodes directories in the namecache. The original 4.x BSD behavior was to return ENFILE if we reached the max, but 4.x BSD did not have the vnlru proc so it was less profitable to wait. Notes: svn path=/head/; revision=144624
* - Disable vfs shared locks by default. They must be specifically enabledJeff Roberson2005-03-311-1/+5
| | | | | | | | | | on filesystems which safely support them. It appears that many network filesystems specifically are not shared lock safe. Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=144374
* - LK_NOPAUSE is a nop now.Jeff Roberson2005-03-311-2/+2
| | | | | | | Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=144367
* Eliminate v_id and v_ddid. The name cache now holds references toDavid Schultz2005-03-301-2/+1
| | | | | | | | | | | | | vnodes whose names it caches, so we no longer need a `generation number' to tell us if a referenced vnode is invalid. Replace the use of the parent's v_id in the hash function with the address of the parent vnode. Tested by: Peter Holm Glanced at by: jeff, phk Notes: svn path=/head/; revision=144319
* - Dont clear OWEINACT in vbusy(), we still owe an inactive call if someoneJeff Roberson2005-03-291-11/+16
| | | | | | | | | | | | | vhold()s us. - Avoid an extra mutex acquire and release in the common case of vgonel() by checking for OWEINACT at the start of the function. - Fix the case where we set OWEINACT in vput(). LK_EXCLUPGRADE drops our shared lock if it fails. Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=144284
* - Don't initial v_dd here, let cache_purge() do it for us.Jeff Roberson2005-03-291-1/+0
| | | | | | | Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=144283
* - Move code that should probably be an assert above the main body ofJeff Roberson2005-03-281-15/+14
| | | | | | | | | | vrele so that we can decrease the indentation of the real work and make things slightly more clear. Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=144219
* - Adjust asserts in vop_lookup_post() to match the new post PDIRUNLOCKJeff Roberson2005-03-281-11/+8
| | | | | | | | | vfs. Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=144204
* Remove another ';' after if().Poul-Henning Kamp2005-03-271-1/+1
| | | | | | | Also spotted by: bz Notes: svn path=/head/; revision=144173
* Remove extra ; at end of if().Poul-Henning Kamp2005-03-271-1/+1
| | | | | | | Found by: bz Notes: svn path=/head/; revision=144172
* - Don't recycle vnodes anymore. Free them once they are dead. getnewvnodeJeff Roberson2005-03-251-121/+116
| | | | | | | | | | | | | | | | | | | now always allocates a new vnode. - Define a new function, vnlru_free, which frees vnodes from the free list. It takes as a parameter the number of vnodes to free, which is wantfreevnodes - freevnodes when called from vnlru_proc or 1 when called from getnewvnode(). For now, getnewvnode() still tries to reclaim a free vnode before creating a new one when we are near the limit. - Define a function, vdestroy, which handles the actual release of memory and teardown of locks, etc. This could become a uma_dtor() routine. - Get rid of minvnodes. Now wantfreevnodes is 1/4th the max vnodes. This keeps more unreferenced vnodes around so that files which have only been stat'd are less likely to be kicked out of the system before we have a chance to read them, etc. These vnodes may still be freed via the normal vnlru_proc() routines which may some day become a real lru. Notes: svn path=/head/; revision=144092
* - Pass LK_EXCLUSIVE to VFS_ROOT() to satisfy the new flags argument. ForJeff Roberson2005-03-241-1/+1
| | | | | | | | | now, all calls to VFS_ROOT() should still acquire exclusive locks. Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=144055
* - If vput() is called with a shared lock it must upgrade to an exclusiveJeff Roberson2005-03-241-3/+12
| | | | | | | | | | | | | | before it can call VOP_INACTIVE(). This must use the EXCLUPGRADE path because we may violate some lock order with another locked vnode if we drop and reacquire the lock. If EXCLUPGRADE fails, we mark the vnode with VI_OWEINACT. This case should be very rare. - Clear VI_OWEINACT in vinactive() and vbusy(). - If VI_OWEINACT is set in vgone() do the VOP_INACTIVE call here as well. Sponsored by: Isilon Systems, Inc. Notes: svn path=/head/; revision=144051
generated by cgit v1.2.3 (git 2.25.1) at 2025-12-08 22:51:36 +0000