From c90c9021e94dd95b34bb48c3f8bb29761379a8d8 Mon Sep 17 00:00:00 2001 From: Ed Schouten Date: Thu, 26 Feb 2009 15:51:54 +0000 Subject: Remove even more unneeded variable assignments. kern_time.c: - Unused variable `p'. kern_thr.c: - Variable `error' is always caught immediately, so no reason to initialize it. There is no way that error != 0 at the end of create_thread(). kern_sig.c: - Unused variable `code'. kern_synch.c: - `rval' is always assigned in all different cases. kern_rwlock.c: - `v' is always overwritten with RW_UNLOCKED further on. kern_malloc.c: - `size' is always initialized with the proper value before being used. kern_exit.c: - `error' is always caught and returned immediately. abort2() never returns a non-zero value. kern_exec.c: - `len' is always assigned inside the if-statement right below it. tty_info.c: - `td' is always overwritten by FOREACH_THREAD_IN_PROC(). Found by: LLVM's scan-build --- sys/kern/kern_sig.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'sys/kern/kern_sig.c') diff --git a/sys/kern/kern_sig.c b/sys/kern/kern_sig.c index f4cf8ad05a59..7460c13caac9 100644 --- a/sys/kern/kern_sig.c +++ b/sys/kern/kern_sig.c @@ -2585,7 +2585,6 @@ postsig(sig) sig_t action; ksiginfo_t ksi; sigset_t returnmask; - int code; KASSERT(sig != 0, ("postsig")); @@ -2653,10 +2652,7 @@ postsig(sig) ps->ps_sigact[_SIG_IDX(sig)] = SIG_DFL; } td->td_ru.ru_nsignals++; - if (p->p_sig != sig) { - code = 0; - } else { - code = p->p_code; + if (p->p_sig == sig) { p->p_code = 0; p->p_sig = 0; } -- cgit v1.2.3